[
https://issues.apache.org/jira/browse/ARTEMIS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219571#comment-16219571
]
ASF GitHub Bot commented on ARTEMIS-1476:
-----------------------------------------
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1605
@franz1981 The Sync calculation is not part of the life cycle of the server
running at all...
Think about it.. we first had nothings.. users had to figure out themselves
based on their hardware specifications how many syncs their system supported,
and then they would place it there.
At a later point, when we added create.. I added this sync tool to make an
approximated auto-tune for the system. anything beyond that is out of context.
It doesn't really matter to add histograms at the sync-calculation, or to
perform any writes...
However.. during the process (aka production)... it would matter...
Look at TimedBuffer::logRatesTimer...
there a Histogram would make a lot more sense... and actually that
logRatesTimer doesn't belong into TimedBuffer maybe.
> HdrHistogram support on verbose SyncCalculation
> -----------------------------------------------
>
> Key: ARTEMIS-1476
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1476
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
>
> The SyncCalculation::syncTest could benefit of
> [HdrHistogram|http://hdrhistogram.org/] support to represent the write
> latencies percentile distribution while using it as a CLI command (ie through
> the perf-journal command).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
