[ 
https://issues.apache.org/jira/browse/ARTEMIS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219417#comment-16219417
 ] 

ASF GitHub Bot commented on ARTEMIS-1476:
-----------------------------------------

Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1605
  
    @clebertsuconic 
    > if this complexity was added around say.. for instance... 
JournalImpl::show statistics.. I would go for it... but here at the sync 
calculation? I think this is being a lot of complexity for something that is 
supposed to be simple.
    
    +100 This is exactly the point mate :)
    So do you think that is better to provide an ad hoc command (if not exists) 
for that (ie single write latencies measurements)?
    This time I have trying to avoid having 2 tools similar but different, but 
I trust you if you see a different usage for it...
    
    >for instance.. you could have chosen to add the Histogram without making 
any other changes
    This is sadly seems not possible (to me at least): each write request (with 
ASYNCIO and not syncWrites) need its own start time in order to compute the 
latency of the operation (and record it on the histogram).
    How can you provide for each write its own start time with ASYNCIO and not 
syncWrites?
    



> HdrHistogram support on verbose SyncCalculation
> -----------------------------------------------
>
>                 Key: ARTEMIS-1476
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1476
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>
> The SyncCalculation::syncTest could benefit of 
> [HdrHistogram|http://hdrhistogram.org/] support to represent the write 
> latencies percentile distribution while using it as a CLI command (ie through 
> the perf-journal command).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to