[
https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281719#comment-16281719
]
ASF GitHub Bot commented on FLINK-8122:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5068#discussion_r155493818
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/TableSinkITCase.scala
---
@@ -583,7 +583,7 @@ private[flink] class TestAppendSink extends
AppendStreamTableSink[Row] {
new MapFunction[Row, JTuple2[JBool, Row]] {
override def map(value: Row): JTuple2[JBool, Row] = new
JTuple2(true, value)
})
- .addSink(new RowSink)
+ .addSink(new RowSink).name(explainSink())
--- End diff --
IMO, we don't need to change the test sinks / sources.
> Name all table sinks and sources
> --------------------------------
>
> Key: FLINK-8122
> URL: https://issues.apache.org/jira/browse/FLINK-8122
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: Timo Walther
> Assignee: Xingcan Cui
>
> Not all table sink and sources have proper names. Therefore, they are
> displayed as "Unnamed" in the logs and Web UI (e.g. CsvTableSink). We should
> add names for all built-in connectors. Having information about the table
> sink name (via {{INSERT INTO}}) would be even better.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
