[
https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281720#comment-16281720
]
ASF GitHub Bot commented on FLINK-8122:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5068#discussion_r155491207
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/TableSink.scala
---
@@ -45,6 +45,10 @@ trait TableSink[T] {
/** Returns the types of the table fields. */
def getFieldTypes: Array[TypeInformation[_]]
+ /** Describes the table sink. */
+ def explainSink(): String =
--- End diff --
As far as I can see, this method is only called from within the interface
implementations and not from external code. I'd rather not add this method
unless it is required.
> Name all table sinks and sources
> --------------------------------
>
> Key: FLINK-8122
> URL: https://issues.apache.org/jira/browse/FLINK-8122
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: Timo Walther
> Assignee: Xingcan Cui
>
> Not all table sink and sources have proper names. Therefore, they are
> displayed as "Unnamed" in the logs and Web UI (e.g. CsvTableSink). We should
> add names for all built-in connectors. Having information about the table
> sink name (via {{INSERT INTO}}) would be even better.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
