[
https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281716#comment-16281716
]
ASF GitHub Bot commented on FLINK-8122:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5068#discussion_r155493746
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/table/TableSourceITCase.scala
---
@@ -58,7 +58,7 @@ class TableSourceITCase(
override def getDataSet(execEnv: JExecEnv): DataSet[Row] = {
val data = List(Row.of("Mary", new JLong(1L), new JInt(1))).asJava
// return DataSet[Row] with GenericTypeInfo
- execEnv.fromCollection(data, new
GenericTypeInfo[Row](classOf[Row]))
+ execEnv.fromCollection(data, new
GenericTypeInfo[Row](classOf[Row])).name(explainSource())
--- End diff --
I don't think we have to add this to test sources.
> Name all table sinks and sources
> --------------------------------
>
> Key: FLINK-8122
> URL: https://issues.apache.org/jira/browse/FLINK-8122
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: Timo Walther
> Assignee: Xingcan Cui
>
> Not all table sink and sources have proper names. Therefore, they are
> displayed as "Unnamed" in the logs and Web UI (e.g. CsvTableSink). We should
> add names for all built-in connectors. Having information about the table
> sink name (via {{INSERT INTO}}) would be even better.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
