[
https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281717#comment-16281717
]
ASF GitHub Bot commented on FLINK-8122:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5068#discussion_r155489914
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceTestBase.java
---
@@ -62,13 +64,15 @@
private static final Properties PROPS = createSourceProperties();
@Test
+ @SuppressWarnings("unchecked")
public void testKafkaConsumer() {
KafkaTableSource.Builder b = getBuilder();
configureBuilder(b);
// assert that correct
KafkaTableSource observed = spy(b.build());
StreamExecutionEnvironment env =
mock(StreamExecutionEnvironment.class);
+
when(env.addSource(any(SourceFunction.class))).thenReturn(mock(DataStreamSource.class));
--- End diff --
Why do we need this change?
> Name all table sinks and sources
> --------------------------------
>
> Key: FLINK-8122
> URL: https://issues.apache.org/jira/browse/FLINK-8122
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: Timo Walther
> Assignee: Xingcan Cui
>
> Not all table sink and sources have proper names. Therefore, they are
> displayed as "Unnamed" in the logs and Web UI (e.g. CsvTableSink). We should
> add names for all built-in connectors. Having information about the table
> sink name (via {{INSERT INTO}}) would be even better.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
