[
https://issues.apache.org/jira/browse/TAJO-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055325#comment-15055325
]
ASF GitHub Bot commented on TAJO-1999:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/891#discussion_r47457581
--- Diff: tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
---
@@ -1191,7 +1191,8 @@ public LogicalNode visitJoin(PlanContext context,
Stack<Expr> stack, Join join)
// In this case, this join is the top most one within a query block.
boolean isTopMostJoin = stack.isEmpty() ? true :
stack.peek().getType() != OpType.Join;
List<String> newlyEvaluatedExprs =
getNewlyEvaluatedExprsForJoin(context, joinNode, isTopMostJoin);
- List<Target> targets =
TUtil.newList(PlannerUtil.schemaToTargets(merged));
+ List<Target> targets = new ArrayList<>();
+ targets.addAll(PlannerUtil.schemaToTargets(merged));
--- End diff --
Can be rewritten with a single constructor call.
> TUtil.newList/newLinkedHashMap should be replaced by Java's diamond operator
> ----------------------------------------------------------------------------
>
> Key: TAJO-1999
> URL: https://issues.apache.org/jira/browse/TAJO-1999
> Project: Tajo
> Issue Type: Improvement
> Reporter: Dongkyu Hwangbo
> Assignee: Dongkyu Hwangbo
> Priority: Minor
> Labels: migration, newbie
>
> We introduced Java 8. We don't need TUtil.newList/newLinkedHashMap utility
> methods anymore. We need to eliminate them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
