[ 
https://issues.apache.org/jira/browse/TAJO-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055322#comment-15055322
 ] 

ASF GitHub Bot commented on TAJO-1999:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/891#discussion_r47457562
  
    --- Diff: 
tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java ---
    @@ -1163,7 +1170,9 @@ public static void 
scheduleScatteredHashShuffleFetches(TaskSchedulerContext sche
           if (hashed.containsKey(entry.getPartId())) {
             hashed.get(entry.getPartId()).add(entry);
           } else {
    -        hashed.put(entry.getPartId(), TUtil.newList(entry));
    +        List inputList = new ArrayList<>();
    +        inputList.addAll(Arrays.asList(entry));
    +        hashed.put(entry.getPartId(), inputList);
    --- End diff --
    
    Can be rewritten with Arrays.asList().


> TUtil.newList/newLinkedHashMap should be replaced by Java's diamond operator
> ----------------------------------------------------------------------------
>
>                 Key: TAJO-1999
>                 URL: https://issues.apache.org/jira/browse/TAJO-1999
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Dongkyu Hwangbo
>            Assignee: Dongkyu Hwangbo
>            Priority: Minor
>              Labels: migration, newbie
>
> We introduced Java 8. We don't need TUtil.newList/newLinkedHashMap utility 
> methods anymore. We need to eliminate them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to