[ 
https://issues.apache.org/jira/browse/TAJO-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055320#comment-15055320
 ] 

ASF GitHub Bot commented on TAJO-1999:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/891#discussion_r47457550
  
    --- Diff: 
tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java ---
    @@ -987,7 +991,8 @@ public static void 
scheduleScatteredHashShuffleFetches(TaskSchedulerContext sche
             int partId = eachInterm.getPartId();
             List<IntermediateEntry> partitionInterms = 
partitionIntermMap.get(partId);
             if (partitionInterms == null) {
    -          partitionInterms = TUtil.newList(eachInterm);
    +          partitionInterms = new ArrayList<>();
    +          partitionInterms.addAll(Arrays.asList(eachInterm));
    --- End diff --
    
    Can be rewritten with a single constructor call.


> TUtil.newList/newLinkedHashMap should be replaced by Java's diamond operator
> ----------------------------------------------------------------------------
>
>                 Key: TAJO-1999
>                 URL: https://issues.apache.org/jira/browse/TAJO-1999
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Dongkyu Hwangbo
>            Assignee: Dongkyu Hwangbo
>            Priority: Minor
>              Labels: migration, newbie
>
> We introduced Java 8. We don't need TUtil.newList/newLinkedHashMap utility 
> methods anymore. We need to eliminate them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to