Code Owners does not prevent merges by other contributors with Write permissions. We could combine CODEOWNERS with required reviews <https://help.github.com/en/github/administering-a-repository/enabling-required-reviews-for-pull-requests>, but it will apply to the entire Jenkins repository. I am not sure this is what we want, but happy to discuss it. Setting up permissions on the repo level is easier that wrangling with a new repo and the delivery pipeline patches
On Thu, Jan 23, 2020 at 12:07 PM Tim Jacomb <[email protected]> wrote: > Is there a problem with using code owners for those files? > > On Thu, 23 Jan 2020 at 11:05, Oleg Nenashev <[email protected]> > wrote: > >> Hi all, >> >> Thanks to everyone involved in this discussion. I would also like to move >> the page and to improve its look&feel. Moving the Commercial Support >> <https://wiki.jenkins.io/display/JENKINS/Commercial+Support> and Approved >> Trademark Usage >> <https://wiki.jenkins.io/display/JENKINS/Approved+Trademark+Usage> pages >> is in my backlog for Wiki migration. This pages are not easy to migrate >> IMO, because jenkins.io grants a wide access for managing these pages >> (Copy Editors, SIG leaders, GSoC team, etc.). Such access is supposed to be >> restricted IMO, especially for the trademarks page. Access in Wiki was also >> restricted at some point. >> >> My plan for these pages is/was to... >> >> - Create a new public repository within Jenkins Infra for the >> sensitive content. Write permissions will be restricted to the Jenkins >> Infra team and to the Jenkins Board >> - Repository will include sensitive content, including Commercial >> Support, Trademarks, and maybe Governance docs in the future (once under >> https://jenkins.io/project/). >> - For Commercial Support and Approved Trademarks we will use separate >> Asciidoc pages for each entry. >> - jenkins.io builder will pull this resource and include pages into >> jenkins.io, similar to how it happens with currently generated content >> >> Would appreciate feedback about such process. >> >> P.S: I will make sure to create a JIRA entry for it if someone wants to >> contribute >> >> >> On Thursday, January 23, 2020 at 6:22:29 AM UTC+1, Marky Jackson wrote: >>> >>> I like the idea of waiting for the advocacy meeting but that doesn’t >>> mean we can’t get started on a WIP pr >>> >>> > On Jan 22, 2020, at 9:21 PM, 'Gavin Mogan' via Jenkins Developers < >>> [email protected]> wrote: >>> > >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/6cc34bcb-d4b6-4f5a-a293-8c8b6f03356e%40googlegroups.com >> <https://groups.google.com/d/msgid/jenkinsci-dev/6cc34bcb-d4b6-4f5a-a293-8c8b6f03356e%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to a topic in the > Google Groups "Jenkins Developers" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/jenkinsci-dev/vjLgQtpz06Y/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BidZWKWSGL3xAbuGhkHtp02JjvFE0ze9SLag5dNuEgZ-OA%40mail.gmail.com > <https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BidZWKWSGL3xAbuGhkHtp02JjvFE0ze9SLag5dNuEgZ-OA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLB_059-YyxN%3DP-RNPm48euCLYk61oUJDv_aMAyOkcuyMw%40mail.gmail.com.
