Le 10/02/2018 à 22:24, Jean-Marc Lasgouttes a écrit :
I can propose something simple on Monday: remove from GUI (like we do in Linux) and always act as if the pref is off.

Here is what I had in mind. I discovered that the checkbox was not hidden but disabled on Linux. I added code to hide it and ignore it.

This seems simple enough, but of course should be checked by Mac/Win people.

I also removed traces of it in the English User's Guide, and added some entries in release notes. Feel free to improve on the wording.

Comments welcome.


PS: I do not think it is worth applying this to master. We will either end up fixing the feature or removing it altogether.
From 49c6aad0d025867aaf1adeae56bbdfa51f7616d5 Mon Sep 17 00:00:00 2001
From: Jean-Marc Lasgouttes <lasgout...@lyx.org>
Date: Mon, 12 Feb 2018 11:12:50 +0100
Subject: [PATCH] Disable and hide the pixmap cache feature

 lib/RELEASE-NOTES                |  6 ++++++
 lib/doc/UserGuide.lyx            | 18 ------------------
 src/frontends/qt4/GuiPainter.cpp |  2 +-
 src/frontends/qt4/GuiPrefs.cpp   |  2 +-
 4 files changed, 8 insertions(+), 20 deletions(-)

diff --git a/lib/RELEASE-NOTES b/lib/RELEASE-NOTES
index dccd1f1..95485d6 100644
@@ -20,6 +20,10 @@
   See chapter "Dashes and Line Breaks" of the User Guide and
   "Caveats when upgrading from earlier versions to 2.3.x" below.
+* The preference "Tools->Preferences->Look&Feel->Screen Fonts->Use
+  pixmap cache to speed up font rendering" is not available anymore.
+  It was of dubious value and led to rendering issues.
 * The following UI translations were dropped, because the lack of translation
   maintenance:  Russian, Danish, Greek, Serbian, Galician, Catalan, Romanian,
@@ -87,6 +91,8 @@
 * \screen_zoom
   This is now independent of the value set via buffer-zoom[-in|-out].
+* \use_pixmap_cache
+  The value of this variable is now ignored.
 !!!The following new LyX functions have been introduced in 2.3:
diff --git a/lib/doc/UserGuide.lyx b/lib/doc/UserGuide.lyx
index 06cfd1f..fb8cac9 100644
--- a/lib/doc/UserGuide.lyx
+++ b/lib/doc/UserGuide.lyx
@@ -46198,24 +46198,6 @@ reference "subsec:Document-Font"
-\begin_layout Standard
-With the option 
-\family sans
-Use pixmap cache to speed up font rendering
-\family default
- enabled, \SpecialChar LyX
- needs to redraw the screen less often.
- This results in better performance, especially on slow systems.
- On the other hand, the characters might look more fuzzy on screen.
- So whether you enable this or not depends on whether you prefer speed over
- aesthetics.
- Note that the Pixmap Cache is only available and useful under Mac
-\begin_inset space ~
-OS and Windows.
 \begin_layout Subsection
 \begin_inset Index idx
diff --git a/src/frontends/qt4/GuiPainter.cpp b/src/frontends/qt4/GuiPainter.cpp
index a3cb089..e832f23 100644
--- a/src/frontends/qt4/GuiPainter.cpp
+++ b/src/frontends/qt4/GuiPainter.cpp
@@ -50,7 +50,7 @@ const int Painter::thin_line = 1;
 GuiPainter::GuiPainter(QPaintDevice * device, double pixel_ratio)
 	: QPainter(device), Painter(pixel_ratio),
-	  use_pixmap_cache_(lyxrc.use_pixmap_cache && USE_PIXMAP_CACHE)
+	  use_pixmap_cache_(false)
 	// new QPainter has default QPen:
 	current_color_ = guiApp->colorCache().get(Color_black);
diff --git a/src/frontends/qt4/GuiPrefs.cpp b/src/frontends/qt4/GuiPrefs.cpp
index 4681dd3..dc04ec5 100644
--- a/src/frontends/qt4/GuiPrefs.cpp
+++ b/src/frontends/qt4/GuiPrefs.cpp
@@ -1137,7 +1137,7 @@ void PrefScreenFonts::updateRC(LyXRC const & rc)
 #if defined(Q_WS_X11) || defined(QPA_XCB)
+	pixmapCacheCB->hide();

Reply via email to