[
https://issues.apache.org/jira/browse/OAK-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623616#comment-13623616
]
angela commented on OAK-709:
----------------------------
one more observation while testing the patch:
calling TreeImpl#getNodeState will return the SecureNodeState which in turn
will be pushed to the NodeStoreBranch upon RootImpl#purgePendingChanges
(actually the
call is {@code branch.setRoot(rootTree.getNodeState());}. this has the effect
that
the commit hooks need to deal with SecureNodeState, which looks pretty wrong to
me
as the internal work should operate and compare on the original node state.
similarly Root#hasPendingChanges looks very wrong if
Root#getBaseState() is compared to Tree#getNodeState() and those are 2 different
types of NodeStates...
shouldn't Tree#getNodeState() return the internal non-secure node state
representation?
wdyt?
> Consider moving permission evaluation to the node state level
> -------------------------------------------------------------
>
> Key: OAK-709
> URL: https://issues.apache.org/jira/browse/OAK-709
> Project: Jackrabbit Oak
> Issue Type: Sub-task
> Components: core
> Reporter: angela
> Attachments:
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch,
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch,
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch,
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch,
> OAK-709_2.patch, OAK-709_3.patch, OAK-709-equals_hack.patch, OAK-709.patch,
> SecureNodeState.java
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
