On Wed, 23 Sep 2026 13:31:04 GMT, Ziad El Midaoui <[email protected]> wrote:
> Improve the usability of several manual tests : > > - `ButtonMnemonicPositionTest`, `WindowResizableTest` and `EmojiTest` : Skip > unsupported platforms > - `DndTest` : Clarify expected result and added reset button > - `CapsLockTest` : Replace terminal prompts with a JavaFX window > - `PrintDialogModalityTest` : Increase the initial window height so all > buttons are visible > - `PrintOrientTest` : Replace fixed positioning of instructions and button > with padded, aligned `VBox` > - `DragDropFromSwingComponentInSwingNodeTest` and > `SimpleSwingNodeBlurryTextTest` : Close stage from Pass/Fail handlers so > Swing cleanup occurs before shutdown and avoid hang after exit > - `JavaSwingNodeCleanupBug` : Position the second stage beside the > instructions window > - `StartIconified` : Enlarge the iconified test window for better visibility > - `HostServicesShowDocumentTest` , `BigGlyphIDTest` , > `INVISIBLE_GLYPH_IDTest` : use `getResource()` and `getResourceAsStream()` > instead of direct calls > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). some comments and suggestions. I've ran the tests on macOS, skipping windows- and printer-specific ones. tests/manual/UI/WindowResizableTest.java line 41: > 39: return System.getProperty("os.name").contains("Mac"); > 40: } > 41: it might be common knowledge, but the green button is not visible when maximized - one needs to move the mouse above the screen edge for the toolbar to appear. tests/manual/desktop/HostServices/HostServicesShowDocumentTest.java line 40: > 38: public class HostServicesShowDocumentTest extends Application { > 39: > 40: private final String testHtmlUri = > getClass().getResource("test.html").toExternalForm(); I suggest we show the test name in the title bar, _for all the tests_. tests/manual/desktop/HostServices/HostServicesShowDocumentTest.java line 42: > 40: private final String testHtmlUri = > getClass().getResource("test.html").toExternalForm(); > 41: private final String testTxtUri = > getClass().getResource("test.txt").toExternalForm(); > 42: private final String testCsvUri = > getClass().getResource("test.csv").toExternalForm(); suggestion: modify all three resource files to prominently identify the type (HTML, TEXT, CSV) so it's immediately apparent. in test.html, `<h1>HTML</h1>` in test.txt, `TEXT` in test.csv, `CSV,` tests/manual/desktop/HostServices/HostServicesShowDocumentTest.java line 43: > 41: private final String testTxtUri = > getClass().getResource("test.txt").toExternalForm(); > 42: private final String testCsvUri = > getClass().getResource("test.csv").toExternalForm(); > 43: in this test, a CSV gets downloaded, so visually no document is shown. can we modify the instructions to indicate this as a PASS scenario? (maybe say: opened or downloaded) tests/manual/dnd/DndTest.java line 57: > 55: > 56: Label instructions = new Label(""" > 57: Perform each case separately. Click Reset after each case. should this test window have PASS/FAIL buttons? tests/manual/events/CapsLockTest.java line 41: > 39: > 40: public static class App extends Application { > 41: private final Label result = new Label(); With macOS IME installed, CapsLock switches the input between locales, the instructions might account for that (maybe). Shift-CapsLock does toggle the caps lock. Maybe instead of replacing the instructions, we could convert it to a checklist with two items and have PASS/FAIL labels or checkmark symbols at each step? Or perhaps wait until https://bugs.openjdk.org/browse/JDK-8392960 to make substantial changes to the test. tests/manual/stage/StartIconified.java line 63: > 61: primaryStage.setTitle("Iconified Window Test"); > 62: primaryStage.setWidth(700); > 63: primaryStage.setHeight(600); maybe change the background color of the iconified stage? let's say to magenta? tests/manual/swing/DragDropFromSwingComponentInSwingNodeTest.java line 80: > 78: stage.close(); > 79: throw new AssertionError("Drag / drop from a Swing component > in a SwingNode not working"); > 80: }); minor comment: we should change the text being dropped to something more descriptive (in the instructions also) how about: `"TEXT COPIED FROM [" + testTitle = "]"` (also maybe use the class name as the window title?) tests/manual/swing/SimpleSwingNodeBlurryTextTest.java line 74: > 72: failButton.setOnAction(e -> { > 73: stage.close(); > 74: throw new AssertionError("SwingNode text rendering is blurry > in HIDPI scale"); maybe also print the scale here? ------------- PR Review: https://git.openjdk.org/jfx/pull/2320#pullrequestreview-5295883123 PR Review Comment: https://git.openjdk.org/jfx/pull/2320#discussion_r4087719174 PR Review Comment: https://git.openjdk.org/jfx/pull/2320#discussion_r4086539290 PR Review Comment: https://git.openjdk.org/jfx/pull/2320#discussion_r4086589241 PR Review Comment: https://git.openjdk.org/jfx/pull/2320#discussion_r4086605515 PR Review Comment: https://git.openjdk.org/jfx/pull/2320#discussion_r4087181044 PR Review Comment: https://git.openjdk.org/jfx/pull/2320#discussion_r4087266701 PR Review Comment: https://git.openjdk.org/jfx/pull/2320#discussion_r4087382197 PR Review Comment: https://git.openjdk.org/jfx/pull/2320#discussion_r4087403267 PR Review Comment: https://git.openjdk.org/jfx/pull/2320#discussion_r4087669555
