On Wed, 23 Sep 2026 21:17:58 GMT, Andy Goryachev <[email protected]> wrote:
>> Improve the usability of several manual tests : >> >> - `ButtonMnemonicPositionTest`, `WindowResizableTest` and `EmojiTest` : Skip >> unsupported platforms >> - `DndTest` : Clarify expected result and added reset button >> - `CapsLockTest` : Replace terminal prompts with a JavaFX window >> - `PrintDialogModalityTest` : Increase the initial window height so all >> buttons are visible >> - `PrintOrientTest` : Replace fixed positioning of instructions and button >> with padded, aligned `VBox` >> - `DragDropFromSwingComponentInSwingNodeTest` and >> `SimpleSwingNodeBlurryTextTest` : Close stage from Pass/Fail handlers so >> Swing cleanup occurs before shutdown and avoid hang after exit >> - `JavaSwingNodeCleanupBug` : Position the second stage beside the >> instructions window >> - `StartIconified` : Enlarge the iconified test window for better visibility >> - `HostServicesShowDocumentTest` , `BigGlyphIDTest` , >> `INVISIBLE_GLYPH_IDTest` : use `getResource()` and `getResourceAsStream()` >> instead of direct calls >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > tests/manual/swing/DragDropFromSwingComponentInSwingNodeTest.java line 80: > >> 78: stage.close(); >> 79: throw new AssertionError("Drag / drop from a Swing component >> in a SwingNode not working"); >> 80: }); > > minor comment: we should change the text being dropped to something more > descriptive (in the instructions also) > > how about: `"TEXT COPIED FROM [" + testTitle = "]"` > > (also maybe use the class name as the window title?) another thing: this test throws an java.lang.AssertionError if failed, while some other tests simply print error to stdout. should there be a consistent way to signal pass/fail? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2320#discussion_r4087616119
