On Thu, 24 Sep 2026 22:36:24 GMT, Kevin Rushforth <[email protected]> wrote:

>> Ziad El Midaoui has updated the pull request incrementally with two 
>> additional commits since the last revision:
>> 
>>  - Address review feedback on manual test usability
>>  - Add missing pass/fail buttons to 14 tests
>>    
>>    As part of this, I made the printing and polling threads daemon,
>>    so they will exit cleanly
>
> tests/manual/desktop/HostServices/HostServicesShowDocumentTest.java line 42:
> 
>> 40:     private final String testHtmlUri = 
>> getClass().getResource("test.html").toExternalForm();
>> 41:     private final String testTxtUri  = 
>> getClass().getResource("test.txt").toExternalForm();
>> 42:     private final String testCsvUri  = 
>> getClass().getResource("test.csv").toExternalForm();
> 
> This works on Firefox, but not other browsers. Also, it doesn't test simple 
> File URLs. I recommend to revert this.

It worked for me on Chrome on macOS

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2320#discussion_r4114290190

Reply via email to