On Sun, 27 Sep 2026 05:49:30 GMT, Ziad El Midaoui <[email protected]> wrote:
>> Improve the usability of several manual tests : >> >> - `ButtonMnemonicPositionTest`, `WindowResizableTest` and `EmojiTest` : Skip >> unsupported platforms >> - `DndTest` : Clarify expected result and added reset button >> - `CapsLockTest` : Replace terminal prompts with a JavaFX window >> - `PrintDialogModalityTest` : Increase the initial window height so all >> buttons are visible >> - `PrintOrientTest` : Replace fixed positioning of instructions and button >> with padded, aligned `VBox` >> - `DragDropFromSwingComponentInSwingNodeTest` and >> `SimpleSwingNodeBlurryTextTest` : Close stage from Pass/Fail handlers so >> Swing cleanup occurs before shutdown and avoid hang after exit >> - `JavaSwingNodeCleanupBug` : Position the second stage beside the >> instructions window >> - `StartIconified` : Enlarge the iconified test window for better visibility >> - `HostServicesShowDocumentTest` , `BigGlyphIDTest` , >> `INVISIBLE_GLYPH_IDTest` : use `getResource()` and `getResourceAsStream()` >> instead of direct calls >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Ziad El Midaoui has updated the pull request incrementally with two > additional commits since the last revision: > > - Address review feedback on manual test usability > - Add missing pass/fail buttons to 14 tests > > As part of this, I made the printing and polling threads daemon, > so they will exit cleanly tests/manual/swing/JFXPanelOrientationTest.java line 110: > 108: frame.setContentPane(p); > 109: frame.setSize(400, 200); > 110: frame.setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE); should probably revert this - the test is useless once the operator closes the swing frame. tests/manual/swing/SimpleSwingNodeBlurryTextTest.java line 71: > 69: Button passButton = new Button("Pass"); > 70: Button failButton = new Button("Fail"); > 71: passButton.setOnAction(e -> stage.close()); should this print PASS to stdout? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2320#discussion_r4123544815 PR Review Comment: https://git.openjdk.org/jfx/pull/2320#discussion_r4123563486
