On Wed, 23 Sep 2026 13:31:04 GMT, Ziad El Midaoui <[email protected]> wrote:
> Improve the usability of several manual tests : > > - `ButtonMnemonicPositionTest`, `WindowResizableTest` and `EmojiTest` : Skip > unsupported platforms > - `DndTest` : Clarify expected result and added reset button > - `CapsLockTest` : Replace terminal prompts with a JavaFX window > - `PrintDialogModalityTest` : Increase the initial window height so all > buttons are visible > - `PrintOrientTest` : Replace fixed positioning of instructions and button > with padded, aligned `VBox` > - `DragDropFromSwingComponentInSwingNodeTest` and > `SimpleSwingNodeBlurryTextTest` : Close stage from Pass/Fail handlers so > Swing cleanup occurs before shutdown and avoid hang after exit > - `JavaSwingNodeCleanupBug` : Position the second stage beside the > instructions window > - `StartIconified` : Enlarge the iconified test window for better visibility > - `HostServicesShowDocumentTest` , `BigGlyphIDTest` , > `INVISIBLE_GLYPH_IDTest` : use `getResource()` and `getResourceAsStream()` > instead of direct calls > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). The changes so far are good except for one change that needs to be reverted. Here are some other improvements that could be made, which I noticed after running the tests on Windows and macOS: `DragDropOntoSwingComponentInSwingNodeTest` -- hangs on exit when you press either PASS or FAIL `JavaSwingNodeCleanupBug` -- hangs if you press PASS or FAIL before closing Swing window; also it should throw AssertionError from FAIL rather than just printing a message `InputTypeAcceptAttributeTest` -- You might consider updating the instructions for the "txt" filter to add "and other text files" in case this is run from a dir with other files. `JFXPanelOrientationTest` -- Closing the window in the upper left (the one with the RTL checkbox and text field) exits the app without giving the user a change to press PASS/FAIL `StartIconified` -- I just ran this on Windows and it briefly flashes there too. I recommend changing the instructions to be similar to Mac and say something to the effect that the window "may briefly flash on some platforms". tests/manual/desktop/HostServices/HostServicesShowDocumentTest.java line 42: > 40: private final String testHtmlUri = > getClass().getResource("test.html").toExternalForm(); > 41: private final String testTxtUri = > getClass().getResource("test.txt").toExternalForm(); > 42: private final String testCsvUri = > getClass().getResource("test.csv").toExternalForm(); This works on Firefox, but not other browsers. Also, it doesn't test simple File URLs. I recommend to revert this. tests/manual/events/CapsLockTest.java line 50: > 48: if (capsLock.get() != expected) { > 49: System.out.println("TEST FAILED"); > 50: System.exit(1); Another usability improvement would be to throw an AssertionError like other tests with a manual FAIL button do. ------------- PR Review: https://git.openjdk.org/jfx/pull/2320#pullrequestreview-5311035691 PR Review Comment: https://git.openjdk.org/jfx/pull/2320#discussion_r4099170081 PR Review Comment: https://git.openjdk.org/jfx/pull/2320#discussion_r4099195639
