Hi Marcus, all,
On Fri, 2007-08-24 at 11:03 +0200, Marcus Lindblom wrote:
> (cleaned the topic a bit)
> Carsten Neumann wrote:
> > Hi,
> > attached patch should make this work, but before committing it I'd
> > appreciate it if Gerrit could take a look at it and/or if someone would
> > give it a try (I've also attached the test I used, which just writes new
> > data into the image each frame. The log messages from Window indicate
> > that only refreshes are performed).
>
> Great!
>
> I might be able to try it out, but I'm not sure. I'm a bit busy and
> recompiling OpenSG and my app takes a few hours.
don't worry too much about it.
> Just a small comment: Wouldn't it also make sense to make
> imageContentChanged() protected or otherwise hidden from public (but not
> >from Image), so that users don't call it unnecessarily, relying on
> outdated docs/advice/memory.
Up to this point we have been telling everyone to either call
imageContentChanged or setImage (this one does not really make sense to
me,
beginEditCP(texChunk, TextureChunk::ImageFieldMask);
endEditCP(texChunk, TextureChunk::ImageFieldMask);
should be sufficient/better), so making it protected has the potential
of breaking a lot of code. I'll add some doc comments though.
Also there is still justification for imageContentChanged, because Image
will cause an update of the whole texture, where a smaller area would
suffice. Hm, now that I've written this, I realize that my patch will
cause performance problems for apps that update only small regions of a
large texture.
I'd like to hear opinions whether the patch should still be applied or
if there other ideas on what to do.
On a related issue, I think that successive calls to imageContentChanged
with non-default arguments should extend the dirty rectangle rather than
replace the previous values. Any comments on this idea?
Thanks,
Carsten
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Opensg-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensg-users
