Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10068 )
Change subject: Allow bootstrap_system.sh to work on existing impala/ repo ...................................................................... Patch Set 1: (1 comment) I think you and Fredy need to resolve conflicts vis-a-vis https://gerrit.cloudera.org/c/9994/8/bin/bootstrap_system.sh. I'm fine with this in general, though. http://gerrit.cloudera.org:8080/#/c/10068/1/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/10068/1/bin/bootstrap_system.sh@108 PS1, Line 108: if ! [[ -e "NOTICE.txt" && "$(head -1 'NOTICE.txt')" = "Apache Impala" ]] Perhaps: if ! [[ -d .git ]]; then echo "Detected git repo at ..." else ... fi -- To view, visit http://gerrit.cloudera.org:8080/10068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If18a34ae54933d9ced2069602a8dca172826b18c Gerrit-Change-Number: 10068 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Fri, 13 Apr 2018 22:22:47 +0000 Gerrit-HasComments: Yes
