Hello Jim Apple, Philip Zeyliger,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10068
to look at the new patch set (#2).
Change subject: Allow bootstrap_system.sh to work on existing impala/ repo
......................................................................
Allow bootstrap_system.sh to work on existing impala/ repo
bootstrap_system.sh always assumes that Impala should be checked
out to the user's home directory, which does not need to be the case.
We end up checking out a second Impala repo if that assumption doesn't
hold true.
Also, since we need to check out the repo to access bin/bootstrap_*.sh,
it's a bit awkward to assume that this might be run as a standalone
script.
This change assumes that the script is being run from $IMPALA_HOME/bin/
and falls back to checking out the repo if that's not the case.
Testing: Ran bin/bootstrap_development.sh on a fresh machine and made
sure that it works as expected in the following cases:
- User has already set $IMPALA_HOME to a valid Impala repo:
Uses existing repo
- User has already set $IMPALA_HOME but to an invalid location:
Checks out new repo
- $IMPALA_HOME not specified and script run from a valid impala repo, i.e.
/path/to/impala/bin/ : Uses existing repo
- $IMPALA_HOME not specified but script run in a standalone manner, i.e. not
from a valid impala repo: Checks out new repo
Change-Id: If18a34ae54933d9ced2069602a8dca172826b18c
---
M bin/bootstrap_system.sh
1 file changed, 14 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/10068/2
--
To view, visit http://gerrit.cloudera.org:8080/10068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If18a34ae54933d9ced2069602a8dca172826b18c
Gerrit-Change-Number: 10068
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
