Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10068 )

Change subject: Allow bootstrap_system.sh to work on existing impala/ repo
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/10068/2/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/10068/2/bin/bootstrap_system.sh@109
PS2, Line 109: if ! [[ -e $IMPALA_HOME/.git ]]
Surround the $IMPALA_HOME with double quotes.


http://gerrit.cloudera.org:8080/#/c/10068/2/bin/bootstrap_system.sh@112
PS2, Line 112:   echo ">>> Checking out Impala"
It might be better to put this echo after L:113 and maybe update the message to 
specify the checkout location, i.e.

echo ">>> Checking out Impala at: $IMPALA_HOME"


http://gerrit.cloudera.org:8080/#/c/10068/2/bin/bootstrap_system.sh@116
PS2, Line 116:   echo "Impala repo detected at:" $IMPALA_HOME
nit: put space after at:



--
To view, visit http://gerrit.cloudera.org:8080/10068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If18a34ae54933d9ced2069602a8dca172826b18c
Gerrit-Change-Number: 10068
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Apr 2018 18:41:20 +0000
Gerrit-HasComments: Yes

Reply via email to