Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10068 )
Change subject: Allow bootstrap_system.sh to work on existing impala/ repo ...................................................................... Patch Set 2: (6 comments) Thanks for the review. http://gerrit.cloudera.org:8080/#/c/10068/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10068/2//COMMIT_MSG@33 PS2, Line 33: - $IMPALA_HOME not specified but script run in a standalone manner, i.e. not > I think there's a bug in this case. I think it checks it out to the parent This case works, I've explained how in a review comment in bootstrap_system.sh. http://gerrit.cloudera.org:8080/#/c/10068/2/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/10068/2/bin/bootstrap_system.sh@26 PS2, Line 26: # location specified. > update to indicate where. Done http://gerrit.cloudera.org:8080/#/c/10068/2/bin/bootstrap_system.sh@100 PS2, Line 100: # Get the location of this script. We assume it's being run as part of an already > I don't think this is quite right. It's perfectly reasonable for someone to If IMPALA_HOME is not preset by the user, on L108, we will set IMPALA_HOME to the parent directory of the script. But on L109, if we detect that this is not a valid repo, we reset IMPALA_HOME to ~/Impala in L113. So this case works fine. The reason I make this assumption is that a few users have told me that they downloaded the repo, but forgot to set IMPALA_HOME before running the script. In that case, they end up with 2 different Impala repos. http://gerrit.cloudera.org:8080/#/c/10068/2/bin/bootstrap_system.sh@109 PS2, Line 109: if ! [[ -e $IMPALA_HOME/.git ]] > Surround the $IMPALA_HOME with double quotes. Done http://gerrit.cloudera.org:8080/#/c/10068/2/bin/bootstrap_system.sh@112 PS2, Line 112: echo ">>> Checking out Impala" > It might be better to put this echo after L:113 and maybe update the messag Done http://gerrit.cloudera.org:8080/#/c/10068/2/bin/bootstrap_system.sh@116 PS2, Line 116: echo "Impala repo detected at:" $IMPALA_HOME > nit: put space after at: Done -- To view, visit http://gerrit.cloudera.org:8080/10068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If18a34ae54933d9ced2069602a8dca172826b18c Gerrit-Change-Number: 10068 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Mon, 16 Apr 2018 19:05:00 +0000 Gerrit-HasComments: Yes
