Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10068 )
Change subject: Allow bootstrap_system.sh to work on existing impala/ repo ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10068/2/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/10068/2/bin/bootstrap_system.sh@100 PS2, Line 100: apt-get update > But I don't want it to check out to ~/Impala. I explicitly set IMPALA_HOME In summary, with my change, the script will respect IMPALA_HOME it's set. If not, the default IMPALA_HOME will be ~/Impala. For example, if we download the bootstrap_system.sh script from GitHub. /home/foo/tmp/Impala does not exist IMPALA_HOME=/home/foo/tmp/Impala ./bootstrap_system.sh (will clone Impala in /home/foo/tmp/Impala and run a build in /home/foo/tmp/Impala) ~/Impala does not exist ./bootstrap_system (will clone Impala in the default IMPALA_HOME, which is ~/Impala and run the build in ~/Impala) /home/foo/tmp/Impala already exists IMPALA_HOME=/home/foo/tmp/Impala ./bootstrap_system.sh (will skip the clone, but will run the build in /home/foo/tmp/Impala) ~/Impala exists ./bootstrap_system.sh (will skip the clone, but will run the build in the default IMPALA_HOME, which is ~/Impala) -- To view, visit http://gerrit.cloudera.org:8080/10068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If18a34ae54933d9ced2069602a8dca172826b18c Gerrit-Change-Number: 10068 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Tue, 17 Apr 2018 19:35:56 +0000 Gerrit-HasComments: Yes
