Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10068 )

Change subject: Allow bootstrap_system.sh to work on existing impala/ repo
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/10068/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10068/2//COMMIT_MSG@33
PS2, Line 33: - $IMPALA_HOME not specified but script run in a standalone 
manner, i.e. not
I think there's a bug in this case. I think it checks it out to the parent 
directory of the script rather than ~/Impala.


http://gerrit.cloudera.org:8080/#/c/10068/2/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/10068/2/bin/bootstrap_system.sh@26
PS2, Line 26: # location specified.
update to indicate where.


http://gerrit.cloudera.org:8080/#/c/10068/2/bin/bootstrap_system.sh@100
PS2, Line 100: # Get the location of this script. We assume it's being run as 
part of an already
I don't think this is quite right. It's perfectly reasonable for someone to 
download this script via HTTPS from Github or wherever. You, in fact, captured 
that case in your commit message.

The issue is that on line 108 you default IMPALA_HOME to the parent directory 
of this script, which isn't sensible in a standalone case.



--
To view, visit http://gerrit.cloudera.org:8080/10068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If18a34ae54933d9ced2069602a8dca172826b18c
Gerrit-Change-Number: 10068
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Apr 2018 18:43:21 +0000
Gerrit-HasComments: Yes

Reply via email to