Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10068 )

Change subject: Allow bootstrap_system.sh to work on existing impala/ repo
......................................................................


Patch Set 2:

(1 comment)

> Patch Set 1:
>
> (1 comment)
>
> I think you and Fredy need to resolve conflicts vis-a-vis 
> https://gerrit.cloudera.org/c/9994/8/bin/bootstrap_system.sh.
>
> I'm fine with this in general, though.

Thanks, I didn't see the above patch. I rebased on top of it and extended 
Fredy's patch, which is to always assume that the script is running from 
Impala/bin/ if $IMPALA_HOME is not set.

http://gerrit.cloudera.org:8080/#/c/10068/1/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/10068/1/bin/bootstrap_system.sh@108
PS1, Line 108: : ${IMPALA_HOME:=$REPO_BIN_DIR/../}
> Perhaps:
Done



--
To view, visit http://gerrit.cloudera.org:8080/10068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If18a34ae54933d9ced2069602a8dca172826b18c
Gerrit-Change-Number: 10068
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Apr 2018 18:35:17 +0000
Gerrit-HasComments: Yes

Reply via email to