Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10068 )
Change subject: Allow bootstrap_system.sh to work on existing impala/ repo ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10068/2/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/10068/2/bin/bootstrap_system.sh@100 PS2, Line 100: apt-get update > Ok, then the case where IMPALA_HOME=/foo but IMPALA_HOME is not a current g No, that works too. If IMPALA_HOME=/foo (which is not a valid repo), then on L109, we would detect that it's not a valid repo, and go ahead and check out impala to '~/Impala', and also update IMPALA_HOME appropriately. The only way this can fail is if '/foo' is a git repo of some other project. If we think that's a serious possibility, I can add code to handle that as well in L109. -- To view, visit http://gerrit.cloudera.org:8080/10068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If18a34ae54933d9ced2069602a8dca172826b18c Gerrit-Change-Number: 10068 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Tue, 17 Apr 2018 18:47:41 +0000 Gerrit-HasComments: Yes
