Caideyipi commented on PR #19051: URL: https://github.com/apache/iotdb/pull/19051#issuecomment-6598724450
Independent P1 re-review of the SessionPool failed-write and interrupted-borrow capacity recovery coverage. Reviewed `986e23a1d46a595896ed8168ba5cdf35eb3475a6` against base `24fd30e1ac6b43a32aaeca2066034b1ae81fbc44`; exactly one independent round was performed. No actionable issue was found in the complete P1 target diff or its necessary SessionPool interactions. The test verifies an actual capacity wait on the same pool monitor before interruption, return and reuse of the held Session, the preserved interrupt flag, propagated worker failures, exact data excluding the rejected write, capacity counts, bounded worker cleanup, and node/result cleanup. Other P0/P1 scenarios were outside this review's scope. No source or test changes were needed. Validation: - This round: `git diff --check` passed; no new build or test run was needed because the reviewed code was unchanged. - Local workstation: the previous Windows/JDK 17 Cluster1 focused JUnit run covers the unchanged current SessionPoolIT source: **1 test, 0 failures, 0 errors, 0 skipped; exit 0**. That is a focused JUnit result, not a passing final Maven reactor/Failsafe result. The attempted final Maven run was blocked before the test by a corrupt shared TsFile JAR. - Remote execution: the earlier 37-module reactor and 1/0/0/0 IT result covered `339f1074518b0a611f86f9a094250b62a8e86942`, not the reviewed head. This round did not run remote verification. - CI at the reviewed head: the latest complete check-runs query returned 42 checks: 20 successful, 1 failed (`SonarCloud Code Analysis`), 1 skipped, 19 in progress, and 1 queued. No final CI pass is claimed; the SonarCloud failure was not investigated outside this P1 scope. Final local, source-branch, and PR heads were confirmed equal at **`986e23a1d46a595896ed8168ba5cdf35eb3475a6`**. The candidate worktree remains clean. After confirming that the head had not changed, the PR was marked **ready for review** and its non-draft status was verified. This approval is limited to the P1 scope above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
