Caideyipi commented on PR #19051:
URL: https://github.com/apache/iotdb/pull/19051#issuecomment-6622334776

   Scoped independent re-review of commit 
`8fdf070a2cc12653d2f1c3d7da4babe22c40f787` against parent 
`339f1074518b0a611f86f9a094250b62a8e86942`, limited to that test repair and 
necessary context.
   
   **[P2] Fixed a remaining replication race in the TTL recovery test.** 
Successful writes and reads through different SQL coordinators do not establish 
that every actual IoTConsensus data replica has caught up. Stopping a DataNode 
immediately after fixture setup, or asserting final rows immediately after 
recovery writes, could mistake replication lag for a TTL/recovery failure. 
Added the existing `MetadataFaultTestUtils.awaitDataReplication(database)` 
barrier at both boundaries in 
[IoTDBTableMetadataRecoveryIT.java](https://github.com/apache/iotdb/blob/906980acc9064627a01ac64dfb052c488086ea5b/integration-test/src/test/java/org/apache/iotdb/relational/it/schema/IoTDBTableMetadataRecoveryIT.java#L100).
 Exact TTL, row and expired-write rejection assertions are retained. No new 
test methods or production changes.
   
   Other scoped conclusions:
   
   - The P0 bounded wait retries complete row/header assertions before fault 
injection and is appropriate for its live-node scenario.
   - Database TTL supplies the creation-time table default; altering it does 
not update existing tables. Explicitly altering the table TTL correctly 
exercises missed-broadcast recovery while preserving the overridden table's TTL.
   - Keeping the auto-sync reproducer ignored has evidence: `auto_sync_schema` 
is absent from the current allowed-property validation, and the corresponding 
existing tests were already ignored in #18874. This remains a coverage gap, not 
a verified recovery scenario. The previously recorded `ttl=DEFAULT` 
catalog/cache discrepancy remains a separate follow-up and was not changed here.
   
   Final verification: Linux/JDK 17, `TableClusterIT`, 3 ConfigNodes/3 
DataNodes; clean-source build of the required 37-module IoTDB reactor with the 
build cache disabled. Failsafe actually executed 
`IoTDBTableMetadataRecoveryIT#testTableTtlChangeAfterMissedBroadcast`: **1 
test, 0 failures, 0 errors, 0 skipped**, Maven exit 0. Spotless and diff checks 
passed. Earlier preparation/cache-enabled attempts are not counted as 
verification. The unchanged P0 case relies on its previously recorded focused 
result. Auto-sync remains ignored and was not executed in this run; other PR 
suites and remote CI are not certified by this review.
   
   Repair commit, final local SHA, confirmed source-branch SHA and confirmed PR 
head: `906980acc9064627a01ac64dfb052c488086ea5b`. The later `986e23a` 
SessionPool change was preserved. Exactly one review round was performed; 
because it found a test-logic issue, a fresh scoped re-review is still 
required. The existing open/non-draft state was left unchanged as requested. 
This is not approval of the whole PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to