Alexey Serbin has posted comments on this change.

Change subject: [tools]: Keep the verbosity of CLI at FATAL and above

Patch Set 1:

(1 comment)
File src/kudu/tools/

PS1, Line 215:   // Set the verbosity of the commands to WARNING(2) and above.
             :   // If the user had explicitly specified verbosity, then user's
             :   // verbosity level is honored. Since '--v' depends on 
             :   // specifying either of them on CLI will override this setting.
             :   if 
(google::GetCommandLineFlagInfoOrDie("minloglevel").is_default &&
             :       google::GetCommandLineFlagInfoOrDie("v").is_default) {
             :     google::SetCommandLineOption("minloglevel",
             :   }
> "I'm arguing for more verbosity in anything that is "unexpected" or "abnorm
What it we could set up different level of logging for different components?  
I.e., imagine we could set INFO for CLI tools, WARNING for client library, and 
ERROR for util and RPC?

Would it help?

In previous project I worked on that was possible (actually, that was me who 
brought that functionality).  It was also possible to change it dynamically via 
REST interface (for server-side components).  I think we can have something 
similar for Kudu.  That proved to be very useful while tracing some issues 
(e.g., set it to DEBUG level just for one sub-component and leave ERROR for the 

What do you think?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I882a340d4c1d205e4e998c888f487b7185000e3c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <>
Gerrit-Reviewer: Adar Dembo <>
Gerrit-Reviewer: Alexey Serbin <>
Gerrit-Reviewer: David Ribeiro Alves <>
Gerrit-Reviewer: Dinesh Bhat <>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <>
Gerrit-HasComments: Yes

Reply via email to