Todd Lipcon has posted comments on this change.

Change subject: [tools]: Keep the verbosity of CLI at FATAL and above

Patch Set 1:

(1 comment)
File src/kudu/tools/

PS1, Line 215:   // Set the verbosity of the commands to WARNING(2) and above.
             :   // If the user had explicitly specified verbosity, then user's
             :   // verbosity level is honored. Since '--v' depends on 
             :   // specifying either of them on CLI will override this setting.
             :   if 
(google::GetCommandLineFlagInfoOrDie("minloglevel").is_default &&
             :       google::GetCommandLineFlagInfoOrDie("v").is_default) {
             :     google::SetCommandLineOption("minloglevel",
             :   }
> One of the motivations of being less verbose here was to keep the output mo
I'm arguing for more verbosity in anything that is "unexpected" or "abnormal" 
which is definitely the case for anything WARN or ERROR. For 'INFO' level, I'm 
also saying that if anything is 100% expected, we probably shouldn't bother 
with it.

As for machine-parseable output, I have a couple thoughts:

1) any machine consuming the output should be parsing stdout, not stderr (where 
the logs go)

2) we should be very careful about signing up for any compatibility guarantee 
on the textual output format of these tools. I'd say in fact we should 
explicitly document that the output of these tools is _not_ parseable. 
Otherwise we'll be unable to make improvements over time to make things more 
human-readable. If machine-parseable output is a goal, we should provide --json 
options as appropriate.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I882a340d4c1d205e4e998c888f487b7185000e3c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <>
Gerrit-Reviewer: Adar Dembo <>
Gerrit-Reviewer: Alexey Serbin <>
Gerrit-Reviewer: David Ribeiro Alves <>
Gerrit-Reviewer: Dinesh Bhat <>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <>
Gerrit-HasComments: Yes

Reply via email to