Hello Thorsten, I've just spent some time reviewing the preliminary editor you submitted. This is what I have noted.
Simple Issues Feedback: ----------------------- * Move shortcut editor to Edit->Shortcuts from Tool->Shortcuts. I see you used the F? keys, which makes your placement logical in that respect. But we already have Edit->Preferences. Do it would be more logical to place this under the edit menu. ...Assuming it stays on the drop down menu as such (See next section) * Shortcuts should accept multiple shortcuts "Ctrl+O, Enter". Though your code looks like it supports this, I could not get two shortcuts to call the same action. I tried "Ctrl+Alt+H, Return" to open the default editor. Each worked alone, but the comma separated list would validate (using the validate method in the dialog box code) but still would not work properly, only the Second shortcut listed function. I tried several variations. * Shortcuts, upon hitting the Ok button, rewrote every shortcut for the screen. Maybe I'm being picky here, but I'd like to see this done a little more elegantly * Use of tr() missing which will help with some of the translation issues. For an example see: http://doc.trolltech.com/4.5/qkeysequence.html#QKeySequence-2 * Load / Edit / Save are not being issued as command using the RGs Undo / Redo mechanisms * All shoprtcuts are saved under a "shortcuts" group. This will need to be expanded separate each screens shortcuts. Major Design Considerations: ---------------------------- I would like to see a lot more communication, planning and agreement involved before too much more time is invested (specially if this is not moved to a branch for development). I would hate for you to spend time on this only for it to be rejected. There are several issue that we need to address. * Shortcut editor should be integrated to the Edit->Preferences. That is where the action takes place for things like this in RG. * The Shortcut Editor should be Application wide, not one dialog for each window. People need a central location to edit these shortcuts. I'd imagine one window with a way to select which screen / editor to edit. * A method to capture a key press and convert it to the the Qt Friendly names * Provide a way to restore the default shortcuts. Application wide or per screen. * Provide a way to export / import the shortcuts. .... There really is much to consider. I hope that we will be able to find some common ground on these and other issues before too much effort coding is spent. I think it is important that this is designed with usability, compactness, and maintainability in mind. We have a lot of rough edges to reign in from the port to Qt4 -- as you know. So any new big features should not add to this backlog. Sincerely, Julie S. ------------------------------------------------------------------------------ _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
