Hi Julie, thanks alot for your comments. After I was able to change some keys with this small piece of code, I was a bit euphoric about the possibilities. But you are right, there is much more to consider.
On Tue, 4 May 2010, Julie S wrote: > * Move shortcut editor to Edit->Shortcuts from Tool->Shortcuts. ok, you are right, this would be better place. > * Shortcuts should accept multiple shortcuts "Ctrl+O, Enter". Hmm, Ctrl+O is for opening a file and Enter is for opening a segment in an editor. Maybe the term shortcut is not appropriate in this context. This code is only able to change the key that is connected to an entry in the menue. As far as I know, only Ctrl+V, Ctrl+X and Ctrl-C have several "shortcuts" in the rc-files but only one is visible in the menue. > * Shortcuts, upon hitting the Ok button, rewrote every shortcut for the > screen. Maybe I'm being picky here, but I'd like to see this done a > little more elegantly Yes, any changes are made instantly. What do you mean by more elegantly? > * Use of tr() missing which will help with some of the translation issues. > For an example see: > http://doc.trolltech.com/4.5/qkeysequence.html#QKeySequence-2 Hmm, that is something I don't understand. Any parameter that is passed to QKeySequence is already translated (as it comes from querylist("QAction") which contains the translated strings from the menue). > * Load / Edit / Save are not being issued as command using the RGs > Undo / Redo mechanisms Yes, for the same reason that it is Qt3 code ... > * All shoprtcuts are saved under a "shortcuts" group. This will need > to be expanded separate each screens shortcuts. On the other side there is only one Ctrl-X shortcut within the whole program. So why do you want to split this for different screens? Isn't it better to change every shortcut only once and then have it available everywhere? > * Shortcut editor should be integrated to the Edit->Preferences. That is > where the action takes place for things like this in RG. Wouldn't someone who is using shortcuts prefer to change these shortcuts only by pressing some keys? > * The Shortcut Editor should be Application wide, not one dialog for each > window. People need a central location to edit these shortcuts. If you see a window, you might only want to change the shortcuts of that window. It might be more clearly to not search the whole list for the entry you want to change. > * A method to capture a key press and convert it to the the Qt Friendly names Yes, that is a good idea. > * Provide a way to restore the default shortcuts. Application wide or per > screen. Ok. > * Provide a way to export / import the shortcuts. Hmm, who shall import them? Thorsten ------------------------------------------------------------------------------ _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
