#17034: New user interface for orthogonal arrays and a .explain_construction 
method
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.4
      Component:  combinatorial      |   Resolution:
  designs                            |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Nathann Cohen      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/ncohen/17034     |  e37125b68b03058d52b44404b400af9865886ff1
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by ncohen):

 Hello !

 > I pushed a commit at `u/vdelecroix/17034`. With your version we add a
 very ugly documentation for
 > {{{
 > sage: designs.orthogonal_arrays?
 > }}}

 Oh, True.

 > I moved the examples from the function `orthogonal_array` to the class
 used for the tab completion.

 Thanks

 > I also renamed `OATabThing` into `OAMainFunctions`... it is much more
 explicit.

 I prefered mine. Those are not the 'main functions', they are the ones
 exposed to the user. The 'main function' is `orthogonal_array` that they
 don't see anymore.

 > Beyond my modifications:
 >  - why do we have `designs.orthogonal_arrays.build` but
 `designs.orthogonal_arrays.exists`. It should be uniform for the
 presence/absence of `s`.

 As we are only talking of english here, I do not agree. "Build" is an
 order given to Sage. As in "Build me that orthogonal array". While for
 'exists' comes from "An OA(k,n) exists". In particular, you can't order
 something to exist. But perhaps it already exists `:-P`

 >  - having a class `OATabThing` to imitate a module is really ugly...
 wouldn't it be better to create a new file `orthogonal_arrays_catalog.py`
 which would gather the things.

 Well, I did that to avoid creating a new file for absolutely nothing.
 Otherwise it means newfile+doc module+entry in the reference manual+import
 the functions+import the module.

 Here we have a class defined with 10 lines, I found that better.

 >  - you wrote that you would like to remove the argument `existence` from
 the function `orthogonal_array`... but I really do not see how we can
 achieve that right now without duplication!

 Oh, sorry. I will fix that in my next commit. You have no idea how many
 'drafts' of this patch I wrote before deciding that it was the right way.

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/17034#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to