API does not return email, first_name, last_name fields for some users
Hi,
I am not sure whether this is a bug or not, but here goes:
The API does not return the {first_name, last_name, email} fields for some
users ( 3 out of 8135 on reviews.review-board.org ) . I assume that this is
some sort of privacy setting, but I think it would be best for the fields to
be returned but empty, as it makes consistent parsing easier.
This happens for both the JSON and the XML formats.
One such example is
http://reviews.reviewboard.org/api/users/mbait/
Let me know if I should open a bug report or if this is expected .
Robert
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Problems with inactive users
Hello, I understand that can be a problem, but consider the benefit: reviewboard as a knowledge base. I think this could be solved by filtering reviews out like you said, but keep an option so that they can be searched. Best regards, Raul -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Searching for [Submitted] reviews
Hi, Is there a way to search for all reviews marked as [Submitted]? Thanks. Raul -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: API does not return email, first_name, last_name fields for some users
Hi Robert.
I believe this is the private profile feature which was added in 1.6 RC1.
http://code.google.com/p/reviewboard/issues/detail?id=2127
In general, user profiles are private by default so that email, first_name
and last_name won't show up. Maybe you can upgrade your account to site
admin if you can. Those fields should always show to site admin.
Hongbin
On Fri, Sep 2, 2011 at 2:41 AM, Robert Munteanu
robert.munte...@gmail.comwrote:
Hi,
I am not sure whether this is a bug or not, but here goes:
The API does not return the {first_name, last_name, email} fields for some
users ( 3 out of 8135 on reviews.review-board.org ) . I assume that this
is some sort of privacy setting, but I think it would be best for the fields
to be returned but empty, as it makes consistent parsing easier.
This happens for both the JSON and the XML formats.
One such example is
http://reviews.reviewboard.org/api/users/mbait/
Let me know if I should open a bug report or if this is expected .
Robert
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: API does not return email, first_name, last_name fields for some users
Thanks for the reply, I now understand the root cause. As for my
point, it was that the actual JSON and XML field declarations should
still appear, i.e. instead of something like
user
id1/id
usernamebla/username
/user
there should be
user
id1/id
usernamebla/username
email/
/user
This would make sense from a consistency point of view and avoid
making special cases in code, for both JSON and XML parsers.
Robert
On Fri, Sep 2, 2011 at 4:53 PM, Hongbin Lu hongbin...@gmail.com wrote:
Hi Robert.
I believe this is the private profile feature which was added in 1.6 RC1.
http://code.google.com/p/reviewboard/issues/detail?id=2127
In general, user profiles are private by default so that email, first_name
and last_name won't show up. Maybe you can upgrade your account to site
admin if you can. Those fields should always show to site admin.
Hongbin
On Fri, Sep 2, 2011 at 2:41 AM, Robert Munteanu robert.munte...@gmail.com
wrote:
Hi,
I am not sure whether this is a bug or not, but here goes:
The API does not return the {first_name, last_name, email} fields for some
users ( 3 out of 8135 on reviews.review-board.org ) . I assume that this is
some sort of privacy setting, but I think it would be best for the fields to
be returned but empty, as it makes consistent parsing easier.
This happens for both the JSON and the XML formats.
One such example is
http://reviews.reviewboard.org/api/users/mbait/
Let me know if I should open a bug report or if this is expected .
Robert
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Sent from my (old) computer
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Improvements on usability
Hi, I'm a new happy user of reviewboard. I think it's a fantastic tool and has nice design :D I'd like to give you a few ideas that I think would improve user experience. 1. View that integrates diff and comments so you see all comments of a file in same place instead of grouping comments by user 2. Arrows to navigate diffs on each file: Now you have squares Jump to revision: on top menu and Changes between r2 and. So if you want to go to any of those options you have to scroll up click then scroll down to see what you wanted. You could have arrows (back and forward) on top of each half of the diff on each file that did that. This is also related to previous request. Comments should be in the version they were so you can navigate history of changes of a file looking at comments that were made at each point. 3.User preferences options regarding mails: You should be able to configure when you want to receive mails. I dont want to receive a mail when there is a new diff, just when someone leaves me a comment o replies to my comments (for example). If I'm in a group I want to see my group requests in dashboard but maybe I dont want to get a mail every time something happens in a review of my group. Hope you find this ideas useful. Thanks, Julia -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Problems with multi-page reviews
I had a feeling it might be. Is there any way to export the db from sqlite and import into MySql? We only have a few users so apart from the multipage issue we have not really had any problems with the sqlite DB. Using MySql instead would be no problem but I would prefer not to loose all the data that we have so far. David On 2 Sep 2011, at 03:09, Christian Hammond chip...@chipx86.com wrote: Oh. SQLite. That's your problem. SQLite is not intended for any production use. Unlike other databases, it doesn't really support concurrent access. We don't provide any support for it except for development use. I strongly recommend migrating away from it. Christian On Thursday, September 1, 2011, David Dibben dib...@ieee.org wrote: On 01/09/2011 08:03, Paul Schulz wrote: Did you manage to get a solution to this problem? I am seeing something very similar with the locking issue and message, but the system will come good again after a short period. I am using Reviewboard 1.5.4, with Apache2 and SQlite database. Unfortunately I never had time to investigate the problem and find a solution. My guess was a problem with locking the SQlite database. Most of our reviews are only on one page, so I only occasionally have a problem. David -- David Dibben -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Reports for completed reviews
Is there an easy way of exporting a report of previous reviews in some readable format? A company we are doing business with requires us to submit our code reviews to them as part of the project. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
git trailing slash issue with post-review
Hi, I had a question where lets say when you try to do a git clone http:/xyz.com/abc/ and have a trailing slash at the end, will the post review figure out the correct path ? Because we are hitting issues where post-review complains about the trailing slash and fails. Are there workaround except changing the config file ? Thanks for your inputs. Nirmam -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Improvements on usability
Hi Julia, On Friday, September 2, 2011, Julia S. Simon ju...@tuenti.com wrote: Hi, I'm a new happy user of reviewboard. I think it's a fantastic tool and has nice design :D Thanks! Can we list your company on our Happy Users list? :) I'd like to give you a few ideas that I think would improve user experience. 1. View that integrates diff and comments so you see all comments of a file in same place instead of grouping comments by user This has certainly been requested before, and is doable. I think we could offer this in a future release. I'm not sure if we have a ticket filed. Would you mind filing one? 2. Arrows to navigate diffs on each file: Now you have squares Jump to revision: on top menu and Changes between r2 and. So if you want to go to any of those options you have to scroll up click then scroll down to see what you wanted. You could have arrows (back and forward) on top of each half of the diff on each file that did that. This is also related to previous request. Comments should be in the version they were so you can navigate history of changes of a file looking at comments that were made at each point. The comments part confused me a bit, but we actually have many keyboard shortcuts for navigating diffs. Look in our documentation (top-right of Review Board) in the section on reviewing diffs. We list the shortcuts in there. Eventually we plan to list those in the UI somewhere. 3.User preferences options regarding mails: You should be able to configure when you want to receive mails. I dont want to receive a mail when there is a new diff, just when someone leaves me a comment o replies to my comments (for example). If I'm in a group I want to see my group requests in dashboard but maybe I dont want to get a mail every time something happens in a review of my group. Another frequently requested feature, but one that we don't necessarily have control over. This works if emails are sent directly to you, but in many (most?) deployments, they're actually sent to mailing lists. We obviously can't control whether you get it then. Offering options for that may mislead users. Christian -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: git trailing slash issue with post-review
What's the complaint? That it can't find the repository? If you can move your configuration to named repositories (see the post-review docs) that would solve that problem. Christian On Friday, September 2, 2011, Nirmam Sandesara nirma...@gmail.com wrote: Hi, I had a question where lets say when you try to do a git clone http:/xyz.com/abc/ and have a trailing slash at the end, will the post review figure out the correct path ? Because we are hitting issues where post-review complains about the trailing slash and fails. Are there workaround except changing the config file ? Thanks for your inputs. Nirmam -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Error when attempting to update review request
While attempting to update a review request through the Eclipse plugin, I receive the following error: An internal error occurred during: Update Review Request. Stack trace: org.eclipse.swt.SWTException: Invalid thread access at org.eclipse.swt.SWT.error(SWT.java:3884) at org.eclipse.swt.SWT.error(SWT.java:3799) at org.eclipse.swt.SWT.error(SWT.java:3770) at org.eclipse.swt.widgets.Widget.error(Widget.java:450) at org.eclipse.swt.widgets.Widget.checkWidget(Widget.java:389) at org.eclipse.swt.widgets.Text.getText(Text.java:963) at org.review_board.ereviewboard.ui.editor.ReviewRequestEditorAttributesPart.getInput(ReviewRequestEditorAttributesPart.java: 216) at org.review_board.ereviewboard.ui.editor.ReviewRequestEditorAttributesPart $2.run(ReviewRequestEditorAttributesPart.java:158) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55) Has anyone else been receiving this error? Any ideas of how to fix it? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Searching for [Submitted] reviews
Through the UI? No, though it should be easy to add. Please file a ticket and we can look into it. This can be done through the API if needed. See http://www.reviewboard.org/docs/manual/dev/webapi/2.0/resources/review-request-list/#GET Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Sep 2, 2011 at 5:29 AM, rmc rmpcarva...@gmail.com wrote: Hi, Is there a way to search for all reviews marked as [Submitted]? Thanks. Raul -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: git trailing slash issue with post-review
The other question I had was is post-review working with git now ? On Fri, Sep 2, 2011 at 11:45 AM, Christian Hammond chip...@chipx86.comwrote: No, it's just a configuration in the .reviewboardrc in your git repository. post-review by default will look up the repository on Review Board using the origin remote path. If you instead have a .reviewboardrc at the root of the repository with: REPOSITORY = name Where name is the name given to that repository on Review Board, then it will look it up via that name instead, and ignore differences in the paths (like the trailing slash). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Sep 2, 2011 at 11:32 AM, Nirmam nirma...@gmail.com wrote: Yup it cannot find it bcoz there is slash at the end like abc/. Changing config file in git ? Is that what you mean ? So while creating clones we will have to change the config file ? Correct ? On Fri, Sep 2, 2011 at 11:25 AM, Christian Hammond chip...@chipx86.comwrote: What's the complaint? That it can't find the repository? If you can move your configuration to named repositories (see the post-review docs) that would solve that problem. Christian On Friday, September 2, 2011, Nirmam Sandesara nirma...@gmail.com wrote: Hi, I had a question where lets say when you try to do a git clone http:/xyz.com/abc/ and have a trailing slash at the end, will the post review figure out the correct path ? Because we are hitting issues where post-review complains about the trailing slash and fails. Are there workaround except changing the config file ? Thanks for your inputs. Nirmam -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
PUTing to review-requests/x/draft results in HTTP 301 error
Hi all, Very briefly, I'm attempting to change the target_groups property of a review request. However, when attempting to send a PUT request to change the property, I get a HTTP 301 error (urllib2.HTTPError: HTTP Error 301: Moved Permanently). Can someone provide insight into how to update a review request with this info? (Note: if I change the request type to GET, I do receive the JSON data for the specified review.) Code snippet: https://gist.github.com/1189749 Thanks! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: PUTing to review-requests/x/draft results in HTTP 301 error
You're missing the trailing slash on the URL. That's what's causing the redirect. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Sep 2, 2011 at 1:14 PM, Stefan stefan.louis.no...@gmail.com wrote: Hi all, Very briefly, I'm attempting to change the target_groups property of a review request. However, when attempting to send a PUT request to change the property, I get a HTTP 301 error (urllib2.HTTPError: HTTP Error 301: Moved Permanently). Can someone provide insight into how to update a review request with this info? (Note: if I change the request type to GET, I do receive the JSON data for the specified review.) Code snippet: https://gist.github.com/1189749 Thanks! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Issue 2270 in reviewboard: Screenshot comment alignment
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2270 by leifaff...@gmail.com: Screenshot comment alignment http://code.google.com/p/reviewboard/issues/detail?id=2270 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.55 What's the URL of the page containing the problem? What steps will reproduce the problem? 1. Make a new repository-free review 2. Add screenshots 3. Tag screenshots What is the expected output? What do you see instead? Comments and regions have wacky alignments. Page needs to be resized or refreshed for everything to appear in the right place. What operating system are you using? What browser? Windows, Firefox 6 / Chrome Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
