Change in vdsm[master]: logging: More standard logging format
Michal Skrivanek has posted comments on this change. Change subject: logging: More standard logging format .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Remove volume run link after live merge
Ala Hino has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge .. Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/59725/9/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: PS9, Line 829: self.log.error("Failed to unlink volume run link: %r", :volRunlink) > I'd just raise without logging Done Line 826: os.unlink(volRunLink) Line 827: except OSError as e: Line 828: if e.error != errno.ENOENT: Line 829: self.log.error("Failed to unlink volume run link: %r", Line 830:volRunlink) > I commented about this in Done Line 831: raise Line 832: self.log.debug("Volume run link %r does not exist", volRunlink) Line 833: Line 834: -- To view, visit https://gerrit.ovirt.org/59725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Teardown volume on HSM after live merge
Ala Hino has posted comments on this change. Change subject: Live Merge: Teardown volume on HSM after live merge .. Patch Set 3: (4 comments) https://gerrit.ovirt.org/#/c/64301/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-09-22 15:47:20 +0300 Line 4: Commit: Ala Hino Line 5: CommitDate: 2016-09-23 00:01:49 +0300 Line 6: Line 7: Live Merge: teardown volume on HSM after live merge > Teardown Done Line 8: Line 9: If a VM is running on HSM and live merge is performed, the LV isn't Line 10: deactivated because, the deactivation is done when deleting the volume. Line 11: However, deleting the volume is done on SPM and this means that the LV PS3, Line 10: , > This comma is redundant. Done PS3, Line 13: > missing "is" Done https://gerrit.ovirt.org/#/c/64301/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4782: self.vm.enableDriveMonitor() Line 4783: self.success = True Line 4784: self.vm.log.info("Synchronization completed (job %s)", Line 4785: self.job['jobID']) Line 4786: self.teardown_top_volume() > This must be done *before* we set self.success to True, so it this fails, w After another thought, I think it is better not to fail merge in this case, as the chances to fail here are really low and if failed, probably the env is severely damaged Line 4787: Line 4788: def isSuccessful(self): Line 4789: """ Line 4790: Returns True if this phase completed successfully. -- To view, visit https://gerrit.ovirt.org/64301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Teardown volume on HSM after live merge
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Teardown volume on HSM after live merge .. Patch Set 4: * #1377849::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1377849::OK, public bug * Check Product::#1377849::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Remove volume run link after live merge
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge .. Patch Set 10: * #1321018::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1321018::OK, public bug * Check Product::#1321018::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: Improve log level alignment
Milan Zamazal has posted comments on this change. Change subject: logging: Improve log level alignment .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia18649258f145f974fd4a8f7a96b5849c4a77938 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: Unify SimpleLogAdapter format
Milan Zamazal has posted comments on this change. Change subject: logging: Unify SimpleLogAdapter format .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4edb64d214e515c9cfc45175f6cfee4340d28de Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: jsonrpcvdscli: add migrateStatus
Sandro Bonazzola has posted comments on this change. Change subject: jsonrpcvdscli: add migrateStatus .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: Improve log level alignment
Nir Soffer has posted comments on this change. Change subject: logging: Improve log level alignment .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/64217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia18649258f145f974fd4a8f7a96b5849c4a77938 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: More standard logging format
Nir Soffer has posted comments on this change. Change subject: logging: More standard logging format .. Patch Set 4: Verified+1 This version moves the thread name before the logger name and include the example log in the commit message. -- To view, visit https://gerrit.ovirt.org/64113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: Unify SimpleLogAdapter format
Nir Soffer has posted comments on this change. Change subject: logging: Unify SimpleLogAdapter format .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/64227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4edb64d214e515c9cfc45175f6cfee4340d28de Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: Use same log format in the tests
gerrit-hooks has posted comments on this change. Change subject: logging: Use same log format in the tests .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8a6c07442d3fb2dd86d08f5c71c3b640bbda43d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: Unify SimpleLogAdapter format
gerrit-hooks has posted comments on this change. Change subject: logging: Unify SimpleLogAdapter format .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4edb64d214e515c9cfc45175f6cfee4340d28de Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: Use same log format in the tests
Nir Soffer has posted comments on this change. Change subject: logging: Use same log format in the tests .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/64216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8a6c07442d3fb2dd86d08f5c71c3b640bbda43d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: More standard logging format
gerrit-hooks has posted comments on this change. Change subject: logging: More standard logging format .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: logging: Improve log level alignment
gerrit-hooks has posted comments on this change. Change subject: logging: Improve log level alignment .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia18649258f145f974fd4a8f7a96b5849c4a77938 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Consume ifcfg files that have a non vdsm standard name
Petr Horáček has posted comments on this change. Change subject: net: Consume ifcfg files that have a non vdsm standard name .. Patch Set 4: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/63990/4/lib/vdsm/network/configurators/ifcfg.py File lib/vdsm/network/configurators/ifcfg.py: Line 236: DynamicSourceRoute.addInterfaceTracking(netEnt) Line 237: Line 238: def removeBond(self, bonding): Line 239: if not self.owned_device(bonding.name): Line 240: self.normalize_device_filename(bonding.name) > As far as I know, network caps is generated from actual kernel settings, an For networks I guess it would be somehow 'emergency' removed. Not sure about bonds. I can't imagine a situation where would the additional check hurt. Line 241: to_be_removed = self._ifaceDownAndCleanup(bonding) Line 242: if to_be_removed: Line 243: self.configApplier.removeBonding(bonding.name) Line 244: if bonding.on_removal_just_detach_from_network: -- To view, visit https://gerrit.ovirt.org/63990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bf70ba936d5de1f17a90742644719216018f674 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michael Burman Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: drop the warnings module configuration
Nir Soffer has posted comments on this change. Change subject: vdsm: drop the warnings module configuration .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/62212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I791882a2dd8ba2dda9135b087bca33610db8a20d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Refactor workarounds.detect_format
Nir Soffer has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 4: Continuous-Integration+1 Networks tests continue to fail -- To view, visit https://gerrit.ovirt.org/64230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7b2be176c474f9049d067f0a0c169644ac39899 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter.
Nir Soffer has posted comments on this change. Change subject: qemuimg: Add qcow_compat optional parameter. .. Patch Set 12: (4 comments) https://gerrit.ovirt.org/#/c/64169/12/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 110: cmd.extend(("-f", format)) Line 111: if format == FORMAT.QCOW2: Line 112: if qcow2_compat is None: Line 113: qcow2_compat = default_qcow2_compat() Line 114: if qcow2_compat in ("0.10", "1.1"): We have a constant for this. Line 115: cmd.extend(('-o', 'compat=' + qcow2_compat)) Line 116: else: Line 117: raise ValueError("Invalid compat version '%s'" % qcow2_compat) Line 118: Line 113: qcow2_compat = default_qcow2_compat() Line 114: if qcow2_compat in ("0.10", "1.1"): Line 115: cmd.extend(('-o', 'compat=' + qcow2_compat)) Line 116: else: Line 117: raise ValueError("Invalid compat version '%s'" % qcow2_compat) Use %r instead of '%s'. Please always use the happy path idiom: if qcow2_compat not in _QCOW2_COMPAT_SUPPORTED: raise ... normal flow Line 118: Line 119: if backing: Line 120: if not os.path.isabs(backing): Line 121: cwdPath = os.path.dirname(image) Line 176: qcow2_compat = default_qcow2_compat() Line 177: if qcow2_compat in ("0.10", "1.1"): Line 178: cmd.extend(('-o', 'compat=' + qcow2_compat)) Line 179: else: Line 180: raise ValueError("Invalid compat version '%s'" % qcow2_compat) We do this logic twice - maybe extract a little helper for this, so we can write: qcow2_compat = _validate_qcow2_compat(qcow2_compat) None will return the default format, and invalid value will raise. Line 181: Line 182: if backing: Line 183: if not os.path.isabs(backing): Line 184: cwdPath = os.path.dirname(srcImage) https://gerrit.ovirt.org/#/c/64169/12/tests/qemuimg_test.py File tests/qemuimg_test.py: Line 170: qemuimg.create('image', format='qcow2') Line 171: Line 172: def test_qcow2_compat_invalid(self): Line 173: with self.assertRaises(ValueError): Line 174: qemuimg.create('image', format='qcow2', qcow2_compat='1.11') Nice! But we should test also convert. Then we should test also both valid value and None, in both create and convert. Line 175: Line 176: def test_invalid_config(self): Line 177: config = make_config([('irs', 'qcow2_compat', '1.2')]) Line 178: with MonkeyPatchScope([(qemuimg, 'config', config)]): -- To view, visit https://gerrit.ovirt.org/64169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Pass only srcVol to workarounds.detect_format
gerrit-hooks has posted comments on this change. Change subject: storage: Pass only srcVol to workarounds.detect_format .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/64261 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c3be993a1326ec2b4e85d93602e8afed39561a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Pass only srcVol to workarounds.detect_format
Nir Soffer has abandoned this change. Change subject: storage: Pass only srcVol to workarounds.detect_format .. Abandoned Seems that this patch was replaced by https://gerrit.ovirt.org/64230, please restore if I'm wrong. -- To view, visit https://gerrit.ovirt.org/64261 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I6c3be993a1326ec2b4e85d93602e8afed39561a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Refactor workarounds.detect_format
Nir Soffer has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 4: I rebase this on master, the tests should pass now. -- To view, visit https://gerrit.ovirt.org/64230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7b2be176c474f9049d067f0a0c169644ac39899 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Use detect_format workaround in copy_data
gerrit-hooks has posted comments on this change. Change subject: storage: Use detect_format workaround in copy_data .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecfd3e0fd5923e9a79ab21e01c9b12def78c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Refactor workarounds.detect_format
gerrit-hooks has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7b2be176c474f9049d067f0a0c169644ac39899 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Refactor workarounds.detect_format
Nir Soffer has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 3: Code-Review+2 This needs verification running the old code in image.py. -- To view, visit https://gerrit.ovirt.org/64230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7b2be176c474f9049d067f0a0c169644ac39899 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Consume ifcfg files that have a non vdsm standard name
Edward Haas has posted comments on this change. Change subject: net: Consume ifcfg files that have a non vdsm standard name .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/63990/4/lib/vdsm/network/configurators/ifcfg.py File lib/vdsm/network/configurators/ifcfg.py: Line 236: DynamicSourceRoute.addInterfaceTracking(netEnt) Line 237: Line 238: def removeBond(self, bonding): Line 239: if not self.owned_device(bonding.name): Line 240: self.normalize_device_filename(bonding.name) > do we need to handle removals and editations? if we acquired iface in confi As far as I know, network caps is generated from actual kernel settings, and not ifcfg. Therefore, a command to remove a device (bond is a good example) may arrive without vdsm owning it yet. (Unless we somewhere check that it is not in running/persistent config before actually doing this). Do we have something that blocks vdsm from removing a bond created by the user before the host was added? Line 241: to_be_removed = self._ifaceDownAndCleanup(bonding) Line 242: if to_be_removed: Line 243: self.configApplier.removeBonding(bonding.name) Line 244: if bonding.on_removal_just_detach_from_network: https://gerrit.ovirt.org/#/c/63990/4/tests/network/func_net_basic_test.py File tests/network/func_net_basic_test.py: Line 71: class NetworkBasicLegacyTest(NetworkBasicTemplate): Line 72: __test__ = True Line 73: switch = 'legacy' Line 74: Line 75: def test_add_net_based_on_device_with_non_standard_ifcfg_file(self): > please add a TODO, we need this also for ifacquire (OVS) We should open an internal ticker for this. It's an ifacquire module test "todo", it makes no sense to add it here. Line 76: with dummy_device() as nic: Line 77: NETCREATE = {NETWORK_NAME: {'nic': nic, 'switch': self.switch}} Line 78: NETREMOVE = {NETWORK_NAME: {'remove': True}} Line 79: with self.setupNetworks(NETCREATE, {}, NOCHK): -- To view, visit https://gerrit.ovirt.org/63990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bf70ba936d5de1f17a90742644719216018f674 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michael Burman Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Move detect_format to new workarounds module
gerrit-hooks has posted comments on this change. Change subject: storage: Move detect_format to new workarounds module .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/64229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4da9d2c16679f99b55438d7336d0cfb27429c12 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Move detect_format to new workarounds module
Nir Soffer has submitted this change and it was merged. Change subject: storage: Move detect_format to new workarounds module .. storage: Move detect_format to new workarounds module The function Image._detect_format is a workaround for a bug where the vdsm metadata disagrees with qemuimg about the format of a volume. While the underlying bug has been fixed, we still need to maintain this code in order to prevent problems with preexisting affected volumes. For reusability and maintainability, move this function to a new module called workarounds.py and add some basic unit tests. This code will be reused by sdm.copy_data in a followup patch. Change-Id: If4da9d2c16679f99b55438d7336d0cfb27429c12 Signed-off-by: Adam Litke Reviewed-on: https://gerrit.ovirt.org/64229 Reviewed-by: Nir Soffer Continuous-Integration: Jenkins CI Tested-by: Nir Soffer --- M lib/vdsm/storage/Makefile.am A lib/vdsm/storage/workarounds.py M tests/Makefile.am A tests/storage_workarounds_test.py M vdsm.spec.in M vdsm/storage/image.py 6 files changed, 151 insertions(+), 26 deletions(-) Approvals: Nir Soffer: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4da9d2c16679f99b55438d7336d0cfb27429c12 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Move detect_format to new workarounds module
Nir Soffer has posted comments on this change. Change subject: storage: Move detect_format to new workarounds module .. Patch Set 5: Verified+1 The new module is well tested, and code calling it looks ok, I think this is good enough. -- To view, visit https://gerrit.ovirt.org/64229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4da9d2c16679f99b55438d7336d0cfb27429c12 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Rename lvmTests to new naming convention
Nir Soffer has posted comments on this change. Change subject: tests: Rename lvmTests to new naming convention .. Patch Set 1: Continuous-Integration+1 Network tests acting again. -- To view, visit https://gerrit.ovirt.org/64328 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia266cfde3308f2a842a4fe3be4b6e2bbf2265386 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: teardown volume on HSM after live merge
Nir Soffer has posted comments on this change. Change subject: Live Merge: teardown volume on HSM after live merge .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/64301/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-09-22 15:47:20 +0300 Line 4: Commit: Ala Hino Line 5: CommitDate: 2016-09-23 00:01:49 +0300 Line 6: Line 7: Live Merge: teardown volume on HSM after live merge Teardown Line 8: Line 9: If a VM is running on HSM and live merge is performed, the LV isn't Line 10: deactivated because, the deactivation is done when deleting the volume. Line 11: However, deleting the volume is done on SPM and this means that the LV -- To view, visit https://gerrit.ovirt.org/64301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Remove volume run link after live merge
Nir Soffer has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge .. Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/59725/8/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 821: """ Line 822: volRunlink = os.path.join(constants.P_VDSM_STORAGE, Line 823: self.sdUUID, imgUUID, volUUID) Line 824: try: Line 825: self.log.info("Unlinking volme runtime link: %r", volRunLink) Read again the comments in version 6 (your replied Done, but ignored the comments). Line 826: os.unlink(volRunLink) Line 827: except OSError as e: Line 828: if e.error != errno.ENOENT: Line 829: self.log.error("Failed to unlink volume run link: %r", https://gerrit.ovirt.org/#/c/59725/9/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 826: os.unlink(volRunLink) Line 827: except OSError as e: Line 828: if e.error != errno.ENOENT: Line 829: self.log.error("Failed to unlink volume run link: %r", Line 830:volRunlink) > I'd just raise without logging I commented about this in https://gerrit.ovirt.org/#/c/59725/6/vdsm/storage/blockSD.py Seems like leftover from older version. Line 831: raise Line 832: self.log.debug("Volume run link %r does not exist", volRunlink) Line 833: Line 834: -- To view, visit https://gerrit.ovirt.org/59725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: teardown volume on HSM after live merge
Nir Soffer has posted comments on this change. Change subject: Live Merge: teardown volume on HSM after live merge .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/64301/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4771 Line 4772 Line 4773 Line 4774 Line 4775 This can be good place for tearing down the volume. Line 4782: self.vm.enableDriveMonitor() Line 4783: self.success = True Line 4784: self.vm.log.info("Synchronization completed (job %s)", Line 4785: self.job['jobID']) Line 4786: self.teardown_top_volume() This must be done *before* we set self.success to True, so it this fails, we will try again. Line 4787: Line 4788: def isSuccessful(self): Line 4789: """ Line 4790: Returns True if this phase completed successfully. -- To view, visit https://gerrit.ovirt.org/64301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Remove volume run link after live merge
Allon Mureinik has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge .. Patch Set 9: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/59725/9/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: PS9, Line 829: self.log.error("Failed to unlink volume run link: %r", :volRunlink) I'd just raise without logging -- To view, visit https://gerrit.ovirt.org/59725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: teardown volume on HSM after live merge
Allon Mureinik has posted comments on this change. Change subject: Live Merge: teardown volume on HSM after live merge .. Patch Set 3: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/64301/3//COMMIT_MSG Commit Message: PS3, Line 10: , This comma is redundant. PS3, Line 13: missing "is" -- To view, visit https://gerrit.ovirt.org/64301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Move detect_format to new workarounds module
Nir Soffer has posted comments on this change. Change subject: storage: Move detect_format to new workarounds module .. Patch Set 5: Code-Review+2 Added the missing __future__ import. -- To view, visit https://gerrit.ovirt.org/64229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4da9d2c16679f99b55438d7336d0cfb27429c12 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Move detect_format to new workarounds module
gerrit-hooks has posted comments on this change. Change subject: storage: Move detect_format to new workarounds module .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4da9d2c16679f99b55438d7336d0cfb27429c12 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Rename lvmTests to new naming convention
Nir Soffer has posted comments on this change. Change subject: tests: Rename lvmTests to new naming convention .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/64328 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia266cfde3308f2a842a4fe3be4b6e2bbf2265386 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Nir Soffer Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Rename lvmTests to new naming convention
Nir Soffer has uploaded a new change for review. Change subject: tests: Rename lvmTests to new naming convention .. tests: Rename lvmTests to new naming convention Change-Id: Ia266cfde3308f2a842a4fe3be4b6e2bbf2265386 Signed-off-by: Nir Soffer --- M tests/Makefile.am R tests/storage_lvm_test.py 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/64328/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 38ab95c..ba958de 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -78,7 +78,6 @@ jobsTests.py \ libvirtconnectionTests.py \ logutils_test.py \ - lvmTests.py \ miscTests.py \ mkimageTests.py \ modprobe.py \ @@ -125,6 +124,7 @@ storage_directio_test.py \ storage_guarded_test.py \ storage_hsm_test.py \ + storage_lvm_test.py \ storage_monitor_test.py \ storage_rwlock_test.py \ storage_sdm_copy_data_test.py \ @@ -184,7 +184,6 @@ hoststatsTests.py \ imagetickets_test.py \ iscsiTests.py \ - lvmTests.py \ miscTests.py \ mkimageTests.py \ momPolicyTests.py \ @@ -222,6 +221,7 @@ storageMailboxTests.py \ storage_guarded_test.py \ storage_hsm_test.py \ + storage_lvm_test.py \ storage_monitor_test.py \ storageServerTests.py \ storage_rwlock_test.py \ diff --git a/tests/lvmTests.py b/tests/storage_lvm_test.py similarity index 100% rename from tests/lvmTests.py rename to tests/storage_lvm_test.py -- To view, visit https://gerrit.ovirt.org/64328 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia266cfde3308f2a842a4fe3be4b6e2bbf2265386 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: teardown volume on HSM after live merge
gerrit-hooks has posted comments on this change. Change subject: Live Merge: teardown volume on HSM after live merge .. Patch Set 3: * #1377849::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1377849::OK, public bug * Check Product::#1377849::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Remove volume run link after live merge
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge .. Patch Set 9: * #1321018::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1321018::OK, public bug * Check Product::#1321018::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: teardown volume on HSM after live merge
Ala Hino has posted comments on this change. Change subject: Live Merge: teardown volume on HSM after live merge .. Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/64301/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4769 Line 4770 Line 4771 Line 4772 Line 4773 > Another place where we should not pass an argument. separate patch ... Line 4763: self.vm._setVolumeSize(self.drive.domainID, self.drive.poolID, Line 4764:self.drive.imageID, baseVolUUID, Line 4765:topVolInfo['capacity']) Line 4766: Line 4767: def teardown_top_volume(self, imgUUID, volUUID): > Don't pass arguments to this method, it make the code harder to read, and Done Line 4768: # TODO move this method to storage public API Line 4769: sd_manifest = sdc.sdCache.produce_manifest(self.drive.domainID) Line 4770: sd_manifest.teardownVolume(imgUUID, volUUID) Line 4771: Line 4781: self.vm.enableDriveMonitor() Line 4782: self.success = True Line 4783: self.vm.log.info("Synchronization completed (job %s)", Line 4784: self.job['jobID']) Line 4785: self.teardown_top_volume(self.drive.imageID, self.job['topVolume']) > This would be much nicer as: Done Line 4786: Line 4787: def isSuccessful(self): Line 4788: """ Line 4789: Returns True if this phase completed successfully. -- To view, visit https://gerrit.ovirt.org/64301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Remove volume run link after live merge
Ala Hino has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge .. Patch Set 6: (9 comments) https://gerrit.ovirt.org/#/c/59725/6//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-09-22 16:41:56 +0300 Line 4: Commit: Ala Hino Line 5: CommitDate: 2016-09-22 17:01:55 +0300 Line 6: Line 7: Live Merge: Unlink volume runtime dir after live merge > Remove volume run link after live merge? Done Line 8: Line 9: Unlink volume runtime dir after live megre. Line 10: Line 11: Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Line 5: CommitDate: 2016-09-22 17:01:55 +0300 Line 6: Line 7: Live Merge: Unlink volume runtime dir after live merge Line 8: Line 9: Unlink volume runtime dir after live megre. > Please explain the context like you did in the previous patch. Done Line 10: Line 11: Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Line 12: Bug-Url: https://bugzilla.redhat.com/1321018 Line 5: CommitDate: 2016-09-22 17:01:55 +0300 Line 6: Line 7: Live Merge: Unlink volume runtime dir after live merge Line 8: Line 9: Unlink volume runtime dir after live megre. > Please also explain here why this is not needed in file storage. Done Line 10: Line 11: Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Line 12: Bug-Url: https://bugzilla.redhat.com/1321018 https://gerrit.ovirt.org/#/c/59725/6/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 810: offset = ((slot + blockVolume.RESERVED_LEASES) * self.logBlkSize * Line 811: sd.LEASE_BLOCKS) Line 812: return clusterlock.Lease(volUUID, self.getLeasesFilePath(), offset) Line 813: Line 814: def teardownVolume(self, imgUUID, volUUID): > This change belongs to the previous patch. Done Line 815: lvm.deactivateLVs(self.sdUUID, [volUUID]) Line 816: self.removeVolumeRunDir(imgUUID, volUUID) Line 817: Line 818: def removeVolumeRunDir(self, imgUUID, volUUID): Line 814: def teardownVolume(self, imgUUID, volUUID): Line 815: lvm.deactivateLVs(self.sdUUID, [volUUID]) Line 816: self.removeVolumeRunDir(imgUUID, volUUID) Line 817: Line 818: def removeVolumeRunDir(self, imgUUID, volUUID): > removeVolumeRunLink Done Line 819: """ Line 820: Remove /run/vdsm/storage/sdUUID/imgUUID/volUUID Line 821: """ Line 822: sdRunDir = os.path.join(constants.P_VDSM_STORAGE, self.sdUUID) Line 820: Remove /run/vdsm/storage/sdUUID/imgUUID/volUUID Line 821: """ Line 822: sdRunDir = os.path.join(constants.P_VDSM_STORAGE, self.sdUUID) Line 823: imgRunDir = os.path.join(sdRunDir, imgUUID) Line 824: volRunDir = os.path.join(imgRunDir, volUUID) > volSymlink, this is not a directory Done Line 825: try: Line 826: self.log.info("Unlinking volme runtime dir: %s", volRunDir) Line 827: os.unlink(volRunDir) Line 828: except OSError as e: Line 822: sdRunDir = os.path.join(constants.P_VDSM_STORAGE, self.sdUUID) Line 823: imgRunDir = os.path.join(sdRunDir, imgUUID) Line 824: volRunDir = os.path.join(imgRunDir, volUUID) Line 825: try: Line 826: self.log.info("Unlinking volme runtime dir: %s", volRunDir) > The log cannot raise OSError, it should always be out of the try block. Done Line 827: os.unlink(volRunDir) Line 828: except OSError as e: Line 829: if e.error == errno.ENOENT: Line 830: self.log.debug("Link doesn't exist") Line 830: self.log.debug("Link doesn't exist") Line 831: else: Line 832: self.log.error("Failed to unlink vol runtime dir: %s", Line 833:volRunDir) Line 834: raise > Logging and raising is bad practice. If you cannot handle the error, raise, Done Line 835: Line 836: Line 837: class BlockStorageDomain(sd.StorageDomain): Line 838: manifestClass = BlockStorageDomainManifest https://gerrit.ovirt.org/#/c/59725/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4781: self.success = True Line 4782: self.vm.log.info("Synchronization completed (job %s)", Line 4783: self.job['jobID']) Line 4784: # teardown the merged volume Line 4785: self.teardownVolume(self.drive.imageID, self.job['topVolume']) > All these changes belong to the previous patch. Done Line 4786: Line 4787: def isSuccessful(self): Line 4788: """ Line 4789: Returns True if this phase completed successfully. -- To view, visit https://gerrit.ovirt.org/59725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer
Change in vdsm[master]: Live Merge: Remove volume run link after live merge
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Remove volume run link after live merge .. Patch Set 8: * #1321018::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1321018::OK, public bug * Check Product::#1321018::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: teardown volume on HSM after live merge
Nir Soffer has posted comments on this change. Change subject: Live Merge: teardown volume on HSM after live merge .. Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/64301/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4769 Line 4770 Line 4771 Line 4772 Line 4773 Another place where we should not pass an argument. Line 4763: self.vm._setVolumeSize(self.drive.domainID, self.drive.poolID, Line 4764:self.drive.imageID, baseVolUUID, Line 4765:topVolInfo['capacity']) Line 4766: Line 4767: def teardown_top_volume(self, imgUUID, volUUID): Don't pass arguments to this method, it make the code harder to read, and is not needed. We have al the context needed to get the arguments inside this helper. Line 4768: # TODO move this method to storage public API Line 4769: sd_manifest = sdc.sdCache.produce_manifest(self.drive.domainID) Line 4770: sd_manifest.teardownVolume(imgUUID, volUUID) Line 4771: Line 4781: self.vm.enableDriveMonitor() Line 4782: self.success = True Line 4783: self.vm.log.info("Synchronization completed (job %s)", Line 4784: self.job['jobID']) Line 4785: self.teardown_top_volume(self.drive.imageID, self.job['topVolume']) This would be much nicer as: self.teardown_top_volume() Line 4786: Line 4787: def isSuccessful(self): Line 4788: """ Line 4789: Returns True if this phase completed successfully. -- To view, visit https://gerrit.ovirt.org/64301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Move detect_format to new workarounds module
Nir Soffer has posted comments on this change. Change subject: storage: Move detect_format to new workarounds module .. Patch Set 4: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/64229/4/lib/vdsm/storage/workarounds.py File lib/vdsm/storage/workarounds.py: Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA Line 17: # Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: Missing absolute_import in lib/vdsm/storage/workarounds.py Line 21: import logging Line 22: Line 23: from vdsm import qemuimg Line 24: from vdsm.storage import constants as sc -- To view, visit https://gerrit.ovirt.org/64229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4da9d2c16679f99b55438d7336d0cfb27429c12 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Consume ifcfg files that have a non vdsm standard name
Petr Horáček has posted comments on this change. Change subject: net: Consume ifcfg files that have a non vdsm standard name .. Patch Set 4: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/63990/4/lib/vdsm/network/configurators/ifcfg.py File lib/vdsm/network/configurators/ifcfg.py: Line 236: DynamicSourceRoute.addInterfaceTracking(netEnt) Line 237: Line 238: def removeBond(self, bonding): Line 239: if not self.owned_device(bonding.name): Line 240: self.normalize_device_filename(bonding.name) do we need to handle removals and editations? if we acquired iface in configure*, it must be already renamed. Line 241: to_be_removed = self._ifaceDownAndCleanup(bonding) Line 242: if to_be_removed: Line 243: self.configApplier.removeBonding(bonding.name) Line 244: if bonding.on_removal_just_detach_from_network: https://gerrit.ovirt.org/#/c/63990/4/tests/network/func_net_basic_test.py File tests/network/func_net_basic_test.py: Line 71: class NetworkBasicLegacyTest(NetworkBasicTemplate): Line 72: __test__ = True Line 73: switch = 'legacy' Line 74: Line 75: def test_add_net_based_on_device_with_non_standard_ifcfg_file(self): please add a TODO, we need this also for ifacquire (OVS) Line 76: with dummy_device() as nic: Line 77: NETCREATE = {NETWORK_NAME: {'nic': nic, 'switch': self.switch}} Line 78: NETREMOVE = {NETWORK_NAME: {'remove': True}} Line 79: with self.setupNetworks(NETCREATE, {}, NOCHK): -- To view, visit https://gerrit.ovirt.org/63990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bf70ba936d5de1f17a90742644719216018f674 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michael Burman Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Use detect_format workaround in copy_data
Nir Soffer has posted comments on this change. Change subject: storage: Use detect_format workaround in copy_data .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/64231/3/tests/storage_sdm_copy_data_test.py File tests/storage_sdm_copy_data_test.py: Line 218: img_id=dst_vol.imgUUID, vol_id=dst_vol.volUUID) Line 219: job = storage.sdm.api.copy_data.Job(job_id, 0, source, dest) Line 220: job.run() Line 221: wait_for_job(job) Line 222: self.assertEqual(jobs.STATUS.DONE, job.status) After all this setup, we did not verify the copy, jus that it did not raise. I think we should write some data to the source image and read it from the target. Can we use the helpers in this class - creating two cow volumes, and then corrupt the image by writing data into it - just like virt guys used to do? This will cut the amount of code here to half. Line 223: Line 224: # TODO: Missing tests: Line 225: # Copy between 2 different domains Line 226: # Abort before copy https://gerrit.ovirt.org/#/c/64231/3/vdsm/storage/sdm/api/copy_data.py File vdsm/storage/sdm/api/copy_data.py: Line 66: return Line 67: Line 68: # Workaround for volumes containing VM configuration info that Line 69: # were created with invalid vdsm metadata. Line 70: if self._source.is_invalid_vm_conf_disk: is_xxx is typically a method, not property. Line 71: src_format = dst_format = qemuimg.FORMAT.RAW Line 72: else: Line 73: src_format = self._source.qemu_format Line 74: dst_format = self._dest.qemu_format -- To view, visit https://gerrit.ovirt.org/64231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecfd3e0fd5923e9a79ab21e01c9b12def78c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Use detect_format workaround in copy_data
Nir Soffer has posted comments on this change. Change subject: storage: Use detect_format workaround in copy_data .. Patch Set 4: Code-Review-1 See comments in v3 -- To view, visit https://gerrit.ovirt.org/64231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecfd3e0fd5923e9a79ab21e01c9b12def78c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Use detect_format workaround in copy_data
gerrit-hooks has posted comments on this change. Change subject: storage: Use detect_format workaround in copy_data .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecfd3e0fd5923e9a79ab21e01c9b12def78c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Move detect_format to new workarounds module
gerrit-hooks has posted comments on this change. Change subject: storage: Move detect_format to new workarounds module .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4da9d2c16679f99b55438d7336d0cfb27429c12 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Refactor workarounds.detect_format
gerrit-hooks has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7b2be176c474f9049d067f0a0c169644ac39899 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Move detect_format to new workarounds module
Adam Litke has posted comments on this change. Change subject: storage: Move detect_format to new workarounds module .. Patch Set 2: (5 comments) https://gerrit.ovirt.org/#/c/64229/2/vdsm/storage/Makefile.am File vdsm/storage/Makefile.am: Line 55:taskManager.py \ Line 56:task.py \ Line 57:threadPool.py \ Line 58:volume.py \ Line 59:workarounds.py \ > We cannot create new volumes in the vdsm tree - we are trying to move stuff Done Line 60:$(NULL) Line 61: Line 62: dist_vdsmexec_SCRIPTS = \ Line 63:curl-img-wrap \ https://gerrit.ovirt.org/#/c/64229/2/vdsm/storage/workarounds.py File vdsm/storage/workarounds.py: Line 35: Line 36: Since commit 0b61c4851a528fd6354d9ab77a68085c41f35dc9 copy of internal raw Line 37: volumes is done using 'qemu-img convert' instead of invoking 'dd'. Line 38: Line 39: Consequently, exporting VM metadata images (produce during live snapshot) > produced Done Line 40: fails on qemu-img convert - since the images 'impersonate' to qcow2 (the Line 41: format in .meta file is cow, whereas the real format is raw). This problem Line 42: is documented by https://bugzilla.redhat.com/show_bug.cgi?id=1282239 and Line 43: has subsequently been fixed in ovirt-engine Line 38: Line 39: Consequently, exporting VM metadata images (produce during live snapshot) Line 40: fails on qemu-img convert - since the images 'impersonate' to qcow2 (the Line 41: format in .meta file is cow, whereas the real format is raw). This problem Line 42: is documented by https://bugzilla.redhat.com/show_bug.cgi?id=1282239 and > can you use https://bugzilla.redhat.com/1282239? Done Line 43: has subsequently been fixed in ovirt-engine Line 44: (see https://gerrit.ovirt.org/#/c/48768/). Line 45: Line 46: Since VM metadata volumes with this problem may still exist in storage we Line 40: fails on qemu-img convert - since the images 'impersonate' to qcow2 (the Line 41: format in .meta file is cow, whereas the real format is raw). This problem Line 42: is documented by https://bugzilla.redhat.com/show_bug.cgi?id=1282239 and Line 43: has subsequently been fixed in ovirt-engine Line 44: (see https://gerrit.ovirt.org/#/c/48768/). > Can you use https://gerrit.ovirt.org/48768? Done Line 45: Line 46: Since VM metadata volumes with this problem may still exist in storage we Line 47: must keep using this workaround to avoid problems with copying VM disks. Line 48: """ Line 44: (see https://gerrit.ovirt.org/#/c/48768/). Line 45: Line 46: Since VM metadata volumes with this problem may still exist in storage we Line 47: must keep using this workaround to avoid problems with copying VM disks. Line 48: """ > I don't think any workaround got such quality documentation :-) Sadly, no. Line 49: src_format = srcVol.getFormat() Line 50: size_in_blk = srcVol.getSize() Line 51: if src_format == sc.COW_FORMAT and size_in_blk == VM_CONF_SIZE_BLK: Line 52: info = qemuimg.info(srcVol.getVolumePath()) -- To view, visit https://gerrit.ovirt.org/64229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4da9d2c16679f99b55438d7336d0cfb27429c12 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Refactor workarounds.detect_format
Nir Soffer has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 2: Code-Review+2 Seems that this is the best way. -- To view, visit https://gerrit.ovirt.org/64230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7b2be176c474f9049d067f0a0c169644ac39899 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Move detect_format to new workarounds module
Nir Soffer has posted comments on this change. Change subject: storage: Move detect_format to new workarounds module .. Patch Set 3: Code-Review-1 See comments in version 2. -- To view, visit https://gerrit.ovirt.org/64229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4da9d2c16679f99b55438d7336d0cfb27429c12 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Move detect_format to new workarounds module
Nir Soffer has posted comments on this change. Change subject: storage: Move detect_format to new workarounds module .. Patch Set 2: (7 comments) https://gerrit.ovirt.org/#/c/64229/2/tests/storage_workarounds_test.py File tests/storage_workarounds_test.py: Line 30: from vdsm.storage import constants as sc Line 31: Line 32: Line 33: md_formats = dict(raw=sc.RAW_FORMAT, cow=sc.COW_FORMAT) Line 34: qemu_formats = dict(raw=qemuimg.FORMAT.RAW, cow=qemuimg.FORMAT.QCOW2) Nice! Line 35: VM_CONF_SIZE = workarounds.VM_CONF_SIZE_BLK * sc.BLOCK_SIZE Line 36: Line 37: Line 38: def make_volume(env, size, md_fmt, real_fmt): Line 40: vol_id = str(uuid.uuid4()) Line 41: env.make_volume(size, img_id, vol_id, vol_format=md_formats[md_fmt]) Line 42: vol = env.sd_manifest.produceVolume(img_id, vol_id) Line 43: qemuimg.create(vol.getVolumePath(), size, qemu_formats[real_fmt]) Line 44: return vol Neat Line 45: Line 46: Line 47: class DetectFormatTest(VdsmTestCase): Line 48: https://gerrit.ovirt.org/#/c/64229/2/vdsm/storage/Makefile.am File vdsm/storage/Makefile.am: Line 55:taskManager.py \ Line 56:task.py \ Line 57:threadPool.py \ Line 58:volume.py \ Line 59:workarounds.py \ We cannot create new volumes in the vdsm tree - we are trying to move stuff to lib/vdsm. Please move this to lib/vdsm/storage/workarounds.py Line 60:$(NULL) Line 61: Line 62: dist_vdsmexec_SCRIPTS = \ Line 63:curl-img-wrap \ https://gerrit.ovirt.org/#/c/64229/2/vdsm/storage/workarounds.py File vdsm/storage/workarounds.py: Line 35: Line 36: Since commit 0b61c4851a528fd6354d9ab77a68085c41f35dc9 copy of internal raw Line 37: volumes is done using 'qemu-img convert' instead of invoking 'dd'. Line 38: Line 39: Consequently, exporting VM metadata images (produce during live snapshot) produced Line 40: fails on qemu-img convert - since the images 'impersonate' to qcow2 (the Line 41: format in .meta file is cow, whereas the real format is raw). This problem Line 42: is documented by https://bugzilla.redhat.com/show_bug.cgi?id=1282239 and Line 43: has subsequently been fixed in ovirt-engine Line 38: Line 39: Consequently, exporting VM metadata images (produce during live snapshot) Line 40: fails on qemu-img convert - since the images 'impersonate' to qcow2 (the Line 41: format in .meta file is cow, whereas the real format is raw). This problem Line 42: is documented by https://bugzilla.redhat.com/show_bug.cgi?id=1282239 and can you use https://bugzilla.redhat.com/1282239? Line 43: has subsequently been fixed in ovirt-engine Line 44: (see https://gerrit.ovirt.org/#/c/48768/). Line 45: Line 46: Since VM metadata volumes with this problem may still exist in storage we Line 40: fails on qemu-img convert - since the images 'impersonate' to qcow2 (the Line 41: format in .meta file is cow, whereas the real format is raw). This problem Line 42: is documented by https://bugzilla.redhat.com/show_bug.cgi?id=1282239 and Line 43: has subsequently been fixed in ovirt-engine Line 44: (see https://gerrit.ovirt.org/#/c/48768/). Can you use https://gerrit.ovirt.org/48768? Line 45: Line 46: Since VM metadata volumes with this problem may still exist in storage we Line 47: must keep using this workaround to avoid problems with copying VM disks. Line 48: """ Line 44: (see https://gerrit.ovirt.org/#/c/48768/). Line 45: Line 46: Since VM metadata volumes with this problem may still exist in storage we Line 47: must keep using this workaround to avoid problems with copying VM disks. Line 48: """ I don't think any workaround got such quality documentation :-) Line 49: src_format = srcVol.getFormat() Line 50: size_in_blk = srcVol.getSize() Line 51: if src_format == sc.COW_FORMAT and size_in_blk == VM_CONF_SIZE_BLK: Line 52: info = qemuimg.info(srcVol.getVolumePath()) -- To view, visit https://gerrit.ovirt.org/64229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4da9d2c16679f99b55438d7336d0cfb27429c12 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: teardown volume on HSM after live merge
gerrit-hooks has posted comments on this change. Change subject: Live Merge: teardown volume on HSM after live merge .. Patch Set 2: * #1377849::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1377849::OK, public bug * Check Product::#1377849::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Unlink volume runtime dir after live merge
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Unlink volume runtime dir after live merge .. Patch Set 7: * #1321018::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1321018::OK, public bug * Check Product::#1321018::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: teardown volume on HSM after live merge
Ala Hino has posted comments on this change. Change subject: Live Merge: teardown volume on HSM after live merge .. Patch Set 1: (8 comments) https://gerrit.ovirt.org/#/c/64301/1/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 810: offset = ((slot + blockVolume.RESERVED_LEASES) * self.logBlkSize * Line 811: sd.LEASE_BLOCKS) Line 812: return clusterlock.Lease(volUUID, self.getLeasesFilePath(), offset) Line 813: Line 814: def teardownVolume(self, volUUID): > Add image uuid, standard api for volume methods. Done Line 815: lvm.deactivateLVs(self.sdUUID, [volUUID]) Line 816: Line 817: Line 818: class BlockStorageDomain(sd.StorageDomain): https://gerrit.ovirt.org/#/c/64301/1/vdsm/storage/sd.py File vdsm/storage/sd.py: Line 524: Line 525: if preallocate is not None and preallocate not in sc.VOL_TYPE: Line 526: raise se.IncorrectType(preallocate) Line 527: Line 528: def teardownVolume(self, volUUID): > Volume is defined by domain id, image id and volume id. Please add the imag Done Line 529: """ Line 530: By default, this method does nothing. It is overriden in blockSD Line 531: to do the necessary cleaning. Line 532: """ Line 527: Line 528: def teardownVolume(self, volUUID): Line 529: """ Line 530: By default, this method does nothing. It is overriden in blockSD Line 531: to do the necessary cleaning. > Replace the text with something like: Done Line 532: """ Line 533: pass Line 534: Line 535: Line 529: """ Line 530: By default, this method does nothing. It is overriden in blockSD Line 531: to do the necessary cleaning. Line 532: """ Line 533: pass > pass is not needed, having a docstring is enough. Done Line 534: Line 535: Line 536: class StorageDomain(object): Line 537: log = logging.getLogger("storage.StorageDomain") https://gerrit.ovirt.org/#/c/64301/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 64: from vdsm.virt.vmpowerdown import VmShutdown, VmReboot Line 65: from vdsm.virt.utils import isVdsmImage, cleanup_guest_socket Line 66: from storage import outOfProcess as oop Line 67: from storage import sd Line 68: from storage.sdc import sdCache > Please avoid this bad practice - this must be: Done Line 69: Line 70: # local imports Line 71: # In future those should be imported via .. Line 72: import caps Line 4763: self.vm._setVolumeSize(self.drive.domainID, self.drive.poolID, Line 4764:self.drive.imageID, baseVolUUID, Line 4765:topVolInfo['capacity']) Line 4766: Line 4767: def teardownVolume(self, volUUID): > This should match other methods like update_base_size - no arguments, lower Done Line 4768: dom_manifest = sdCache.produce_manifest(self.drive.domainID) Line 4769: dom_manifest.teardownVolume(volUUID) Line 4770: Line 4771: @utils.traceback() Line 4764:self.drive.imageID, baseVolUUID, Line 4765:topVolInfo['capacity']) Line 4766: Line 4767: def teardownVolume(self, volUUID): Line 4768: dom_manifest = sdCache.produce_manifest(self.drive.domainID) > We call this sd_manifest elsewhere. Done Line 4769: dom_manifest.teardownVolume(volUUID) Line 4770: Line 4771: @utils.traceback() Line 4772: def run(self): Line 4780: self.vm.enableDriveMonitor() Line 4781: self.success = True Line 4782: self.vm.log.info("Synchronization completed (job %s)", Line 4783: self.job['jobID']) Line 4784: # teardown the merged volume > The comment is not needed, the function name should reveal the intent. If y Done Line 4785: self.teardownVolume(self.job['topVolume']) Line 4786: Line 4787: def isSuccessful(self): Line 4788: """ -- To view, visit https://gerrit.ovirt.org/64301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: jsonrpcvdscli: add migrateStatus
Irit Goihman has posted comments on this change. Change subject: jsonrpcvdscli: add migrateStatus .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Share FakeScheduler and use in TestCopyDataDIV
Nir Soffer has submitted this change and it was merged. Change subject: tests: Share FakeScheduler and use in TestCopyDataDIV .. tests: Share FakeScheduler and use in TestCopyDataDIV The FakeScheduler class in jobsTests.py is also needed by TestCopyDataDIV. Introduce a new fakelib.py module for sharing fakes of top-level vdsm lib objects. The copy_data job now relies on the jobs module being properly initialized with a Scheduler (for autodelete). Add setUp and tearDown methods to the tests to properly manage this using the newly available FakeScheduler. Change-Id: I44a7e15f28aefa9a2470f940237dc5b4469d Signed-off-by: Adam Litke Reviewed-on: https://gerrit.ovirt.org/64228 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer Tested-by: Nir Soffer --- M tests/Makefile.am A tests/fakelib.py M tests/jobsTests.py M tests/storage_sdm_copy_data_test.py 4 files changed, 42 insertions(+), 11 deletions(-) Approvals: Nir Soffer: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44a7e15f28aefa9a2470f940237dc5b4469d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Share FakeScheduler and use in TestCopyDataDIV
gerrit-hooks has posted comments on this change. Change subject: tests: Share FakeScheduler and use in TestCopyDataDIV .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/64228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44a7e15f28aefa9a2470f940237dc5b4469d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Share FakeScheduler and use in TestCopyDataDIV
Nir Soffer has posted comments on this change. Change subject: tests: Share FakeScheduler and use in TestCopyDataDIV .. Patch Set 3: Verified+1 Tests pass, looks verified. -- To view, visit https://gerrit.ovirt.org/64228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44a7e15f28aefa9a2470f940237dc5b4469d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Share FakeScheduler and use in TestCopyDataDIV
Nir Soffer has posted comments on this change. Change subject: tests: Share FakeScheduler and use in TestCopyDataDIV .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/64228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44a7e15f28aefa9a2470f940237dc5b4469d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Unlink volume runtime dir after live merge
Nir Soffer has posted comments on this change. Change subject: Live Merge: Unlink volume runtime dir after live merge .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/59725/6//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-09-22 17:01:55 +0300 Line 6: Line 7: Live Merge: Unlink volume runtime dir after live merge Line 8: Line 9: Unlink volume runtime dir after live megre. > Please explain the context like you did in the previous patch. Please also explain here why this is not needed in file storage. Line 10: Line 11: Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Line 12: Bug-Url: https://bugzilla.redhat.com/1321018 -- To view, visit https://gerrit.ovirt.org/59725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Unlink volume runtime dir after live merge
Nir Soffer has posted comments on this change. Change subject: Live Merge: Unlink volume runtime dir after live merge .. Patch Set 6: (8 comments) Did you verify that we don't leave stale symlinks on file storage? https://gerrit.ovirt.org/#/c/59725/6//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-09-22 16:41:56 +0300 Line 4: Commit: Ala Hino Line 5: CommitDate: 2016-09-22 17:01:55 +0300 Line 6: Line 7: Live Merge: Unlink volume runtime dir after live merge Remove volume run link after live merge? Line 8: Line 9: Unlink volume runtime dir after live megre. Line 10: Line 11: Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Line 5: CommitDate: 2016-09-22 17:01:55 +0300 Line 6: Line 7: Live Merge: Unlink volume runtime dir after live merge Line 8: Line 9: Unlink volume runtime dir after live megre. Please explain the context like you did in the previous patch. Note that we are removing a symlink, not a directory. Line 10: Line 11: Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Line 12: Bug-Url: https://bugzilla.redhat.com/1321018 https://gerrit.ovirt.org/#/c/59725/6/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 810: offset = ((slot + blockVolume.RESERVED_LEASES) * self.logBlkSize * Line 811: sd.LEASE_BLOCKS) Line 812: return clusterlock.Lease(volUUID, self.getLeasesFilePath(), offset) Line 813: Line 814: def teardownVolume(self, imgUUID, volUUID): This change belongs to the previous patch. Line 815: lvm.deactivateLVs(self.sdUUID, [volUUID]) Line 816: self.removeVolumeRunDir(imgUUID, volUUID) Line 817: Line 818: def removeVolumeRunDir(self, imgUUID, volUUID): Line 814: def teardownVolume(self, imgUUID, volUUID): Line 815: lvm.deactivateLVs(self.sdUUID, [volUUID]) Line 816: self.removeVolumeRunDir(imgUUID, volUUID) Line 817: Line 818: def removeVolumeRunDir(self, imgUUID, volUUID): removeVolumeRunLink Line 819: """ Line 820: Remove /run/vdsm/storage/sdUUID/imgUUID/volUUID Line 821: """ Line 822: sdRunDir = os.path.join(constants.P_VDSM_STORAGE, self.sdUUID) Line 820: Remove /run/vdsm/storage/sdUUID/imgUUID/volUUID Line 821: """ Line 822: sdRunDir = os.path.join(constants.P_VDSM_STORAGE, self.sdUUID) Line 823: imgRunDir = os.path.join(sdRunDir, imgUUID) Line 824: volRunDir = os.path.join(imgRunDir, volUUID) volSymlink, this is not a directory We don't need 3 calls to os.path.join - use: volRunlink = os.path.join(constants.P_VDSM_STORAGE, self.sdUUID, imgUUID, volUUID) Line 825: try: Line 826: self.log.info("Unlinking volme runtime dir: %s", volRunDir) Line 827: os.unlink(volRunDir) Line 828: except OSError as e: Line 822: sdRunDir = os.path.join(constants.P_VDSM_STORAGE, self.sdUUID) Line 823: imgRunDir = os.path.join(sdRunDir, imgUUID) Line 824: volRunDir = os.path.join(imgRunDir, volUUID) Line 825: try: Line 826: self.log.info("Unlinking volme runtime dir: %s", volRunDir) The log cannot raise OSError, it should always be out of the try block. Please check the other file system related logs and use the same format. Line 827: os.unlink(volRunDir) Line 828: except OSError as e: Line 829: if e.error == errno.ENOENT: Line 830: self.log.debug("Link doesn't exist") Line 830: self.log.debug("Link doesn't exist") Line 831: else: Line 832: self.log.error("Failed to unlink vol runtime dir: %s", Line 833:volRunDir) Line 834: raise Logging and raising is bad practice. If you cannot handle the error, raise, and let someone else handle it and log about it. Also we don't have here two equal cases (if, else). We have: - Can we handle this error? if not raise and let someone else handle it. We want to do this first. - Handle missing link by logging about it So this is the code that reveal this intent best: if e.error != errno.ENOENT: raise self.log.debug("Volume run link %r does not exists", volRunlink) Line 835: Line 836: Line 837: class BlockStorageDomain(sd.StorageDomain): Line 838: manifestClass = BlockStorageDomainManifest https://gerrit.ovirt.org/#/c/59725/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4781: self.success = True Line 4782: self.vm.log.info("Synchronization completed (job %s)", Line 4783: self.job['jobID']) Line 4784: # teardown the merged volume Line 4785: self.teardownVolume(self.drive.imageID, self.job['topVolume']) All these changes belong to the previous patch. Line 4786: Line 4787: def isSuccessful(self): Line 4788: """ Line 4789: Returns True if this phase completed successfully. -
Change in vdsm[master]: Live Merge: teardown volume on HSM after live merge
Nir Soffer has posted comments on this change. Change subject: Live Merge: teardown volume on HSM after live merge .. Patch Set 1: (8 comments) Nice! https://gerrit.ovirt.org/#/c/64301/1/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 810: offset = ((slot + blockVolume.RESERVED_LEASES) * self.logBlkSize * Line 811: sd.LEASE_BLOCKS) Line 812: return clusterlock.Lease(volUUID, self.getLeasesFilePath(), offset) Line 813: Line 814: def teardownVolume(self, volUUID): Add image uuid, standard api for volume methods. Line 815: lvm.deactivateLVs(self.sdUUID, [volUUID]) Line 816: Line 817: Line 818: class BlockStorageDomain(sd.StorageDomain): https://gerrit.ovirt.org/#/c/64301/1/vdsm/storage/sd.py File vdsm/storage/sd.py: Line 524: Line 525: if preallocate is not None and preallocate not in sc.VOL_TYPE: Line 526: raise se.IncorrectType(preallocate) Line 527: Line 528: def teardownVolume(self, volUUID): Volume is defined by domain id, image id and volume id. Please add the image id to this function in this patch (you added it in the next patch). Line 529: """ Line 530: By default, this method does nothing. It is overriden in blockSD Line 531: to do the necessary cleaning. Line 532: """ Line 527: Line 528: def teardownVolume(self, volUUID): Line 529: """ Line 530: By default, this method does nothing. It is overriden in blockSD Line 531: to do the necessary cleaning. Replace the text with something like: Called when a volume is detached from a prepared image during live merge flow. In this case the volume will not be teardown when the image is tear down. This does nothing, subclass should override this if needed. Line 532: """ Line 533: pass Line 534: Line 535: Line 529: """ Line 530: By default, this method does nothing. It is overriden in blockSD Line 531: to do the necessary cleaning. Line 532: """ Line 533: pass pass is not needed, having a docstring is enough. Line 534: Line 535: Line 536: class StorageDomain(object): Line 537: log = logging.getLogger("storage.StorageDomain") https://gerrit.ovirt.org/#/c/64301/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 64: from vdsm.virt.vmpowerdown import VmShutdown, VmReboot Line 65: from vdsm.virt.utils import isVdsmImage, cleanup_guest_socket Line 66: from storage import outOfProcess as oop Line 67: from storage import sd Line 68: from storage.sdc import sdCache Please avoid this bad practice - this must be: from storage import sdc Line 69: Line 70: # local imports Line 71: # In future those should be imported via .. Line 72: import caps Line 4763: self.vm._setVolumeSize(self.drive.domainID, self.drive.poolID, Line 4764:self.drive.imageID, baseVolUUID, Line 4765:topVolInfo['capacity']) Line 4766: Line 4767: def teardownVolume(self, volUUID): This should match other methods like update_base_size - no arguments, lower_case: def teardown_top_volume(self): The flow in _run() should read like documentation. Add TODO to move this to storage public api. This is a layering violation, virt code should not call storage code except via public storage apis (e.g. irs.getVolumeSize()) Line 4768: dom_manifest = sdCache.produce_manifest(self.drive.domainID) Line 4769: dom_manifest.teardownVolume(volUUID) Line 4770: Line 4771: @utils.traceback() Line 4764:self.drive.imageID, baseVolUUID, Line 4765:topVolInfo['capacity']) Line 4766: Line 4767: def teardownVolume(self, volUUID): Line 4768: dom_manifest = sdCache.produce_manifest(self.drive.domainID) We call this sd_manifest elsewhere. Get volume and image id here, from self.job. Line 4769: dom_manifest.teardownVolume(volUUID) Line 4770: Line 4771: @utils.traceback() Line 4772: def run(self): Line 4780: self.vm.enableDriveMonitor() Line 4781: self.success = True Line 4782: self.vm.log.info("Synchronization completed (job %s)", Line 4783: self.job['jobID']) Line 4784: # teardown the merged volume The comment is not needed, the function name should reveal the intent. If you need more documentation - why we must do this, add a docstring to the function. Line 4785: self.teardownVolume(self.job['topVolume']) Line 4786: Line 4787: def isSuccessful(self): Line 4788: """ -- To view, visit https://gerrit.ovirt.org/64301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino
Change in vdsm[master]: storage: Move detect_format to new workarounds module
gerrit-hooks has posted comments on this change. Change subject: storage: Move detect_format to new workarounds module .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4da9d2c16679f99b55438d7336d0cfb27429c12 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Use detect_format workaround in copy_data
gerrit-hooks has posted comments on this change. Change subject: storage: Use detect_format workaround in copy_data .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecfd3e0fd5923e9a79ab21e01c9b12def78c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Refactor workarounds.detect_format
gerrit-hooks has posted comments on this change. Change subject: storage: Refactor workarounds.detect_format .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7b2be176c474f9049d067f0a0c169644ac39899 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Share FakeScheduler and use in TestCopyDataDIV
gerrit-hooks has posted comments on this change. Change subject: tests: Share FakeScheduler and use in TestCopyDataDIV .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44a7e15f28aefa9a2470f940237dc5b4469d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter.
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add qcow_compat optional parameter. .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter.
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add qcow_compat optional parameter. .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter for.
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add qcow_compat optional parameter for. .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: jsonrpcvdscli: add migrateStatus
Simone Tiraboschi has posted comments on this change. Change subject: jsonrpcvdscli: add migrateStatus .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/64324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: jsonrpcvdscli: add migrateStatus
Simone Tiraboschi has uploaded a new change for review. Change subject: jsonrpcvdscli: add migrateStatus .. jsonrpcvdscli: add migrateStatus Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17 Signed-off-by: Simone Tiraboschi --- M lib/vdsm/jsonrpcvdscli.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/64324/1 diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py index 670a02b..490794b 100644 --- a/lib/vdsm/jsonrpcvdscli.py +++ b/lib/vdsm/jsonrpcvdscli.py @@ -91,6 +91,7 @@ 'hotunplugNic': 'VM.hotunplugNic', 'list': 'Host.getVMList', 'migrationCreate': 'VM.migrationCreate', +'migrateStatus': 'VM.getMigrationStatus', 'ping': 'Host.ping', 'prepareImage': 'Image.prepare', 'repoStats': 'Host.getStorageRepoStats', -- To view, visit https://gerrit.ovirt.org/64324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: jsonrpcvdscli: add migrateStatus
gerrit-hooks has posted comments on this change. Change subject: jsonrpcvdscli: add migrateStatus .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: storage: Refactor workarounds.detect_format
Adam Litke has restored this change. Change subject: storage: Refactor workarounds.detect_format .. Restored -- To view, visit https://gerrit.ovirt.org/64230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: Id7b2be176c474f9049d067f0a0c169644ac39899 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: inspect.getargspec() is deprecated in py3
Piotr Kliczewski has posted comments on this change. Change subject: tests: inspect.getargspec() is deprecated in py3 .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/64313/1/tests/testlib.py File tests/testlib.py: Line 45: import mock Line 46: mock Line 47: Line 48: try: Line 49: from inspect import getfullargspec as getargspec > gasp. I see in https://docs.python.org/3/library/inspect.html#inspect.getfu signature, is very compatible with get*argspec :/, will explore Line 50: except ImportError: # py2 Line 51: from inspect import getargspec as getargspec Line 52: getargspec Line 53: -- To view, visit https://gerrit.ovirt.org/64313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25a58ea32bf7548a8f27cc217392fd0958cc8b7d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: inspect.getargspec() is deprecated in py3
Piotr Kliczewski has uploaded a new change for review. Change subject: tests: inspect.getargspec() is deprecated in py3 .. tests: inspect.getargspec() is deprecated in py3 We do not want to see following warning during running tests: DeprecationWarning: inspect.getargspec() is deprecated Change-Id: I25a58ea32bf7548a8f27cc217392fd0958cc8b7d Signed-off-by: Piotr Kliczewski --- M tests/api_test.py M tests/schemaValidationTest.py M tests/testlib.py 3 files changed, 12 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/64313/1 diff --git a/tests/api_test.py b/tests/api_test.py index 3c57381..b977415 100644 --- a/tests/api_test.py +++ b/tests/api_test.py @@ -18,12 +18,11 @@ # Refer to the README and COPYING files for full details of the license # -import inspect - from vdsm.common import api from vdsm.common import exception from vdsm.common import response +from testlib import getargspec from testlib import VdsmTestCase as TestCaseBase @@ -31,10 +30,10 @@ def test_preserve_signature(self): vm = FakeVM() -args = inspect.getargspec(vm.fail) +args = getargspec(vm.fail) self.assertEqual(args.args, ['self', 'exc']) self.assertEqual(args.varargs, None) -self.assertEqual(args.keywords, None) +self.assertEqual(getattr(args, 'keywords', None), None) class TestResponse(TestCaseBase): diff --git a/tests/schemaValidationTest.py b/tests/schemaValidationTest.py index fd87724..13df62f 100644 --- a/tests/schemaValidationTest.py +++ b/tests/schemaValidationTest.py @@ -29,6 +29,7 @@ from vdsm.rpc import Bridge from api import vdsmapi +from testlib import getargspec from testlib import VdsmTestCase as TestCaseBase from contextlib import contextmanager @@ -169,12 +170,12 @@ yield class_name, class_obj def _get_args(self, method_obj): -args = inspect.getargspec(method_obj).args +args = getargspec(method_obj).args args.remove('self') return args def _get_default_args(self, method_obj): -argSpec = inspect.getargspec(method_obj) +argSpec = getargspec(method_obj) if argSpec.defaults: return argSpec.args[- len(argSpec.defaults):] else: diff --git a/tests/testlib.py b/tests/testlib.py index c341c24..7c63a38 100644 --- a/tests/testlib.py +++ b/tests/testlib.py @@ -45,6 +45,12 @@ import mock mock +try: +from inspect import getfullargspec as getargspec +except ImportError: # py2 +from inspect import getargspec as getargspec +getargspec + from nose import config from nose import core from nose import result -- To view, visit https://gerrit.ovirt.org/64313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I25a58ea32bf7548a8f27cc217392fd0958cc8b7d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: inspect.getargspec() is deprecated in py3
Dan Kenigsberg has posted comments on this change. Change subject: tests: inspect.getargspec() is deprecated in py3 .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/64313/1/tests/testlib.py File tests/testlib.py: Line 45: import mock Line 46: mock Line 47: Line 48: try: Line 49: from inspect import getfullargspec as getargspec gasp. I see in https://docs.python.org/3/library/inspect.html#inspect.getfullargspec that this itself is deprecated in Python 3.5 in favor of https://docs.python.org/3/library/inspect.html#inspect.signature Since Fedora already has 3.5, can we jump ahead? Line 50: except ImportError: # py2 Line 51: from inspect import getargspec as getargspec Line 52: getargspec Line 53: -- To view, visit https://gerrit.ovirt.org/64313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25a58ea32bf7548a8f27cc217392fd0958cc8b7d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: gluster: set selinux labels while creating bricks
Piotr Kliczewski has posted comments on this change. Change subject: gluster: set selinux labels while creating bricks .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64296 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Ramesh N Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: stomp: simplified client
Piotr Kliczewski has posted comments on this change. Change subject: stomp: simplified client .. Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: contrib: Simple jsonrpc client
Piotr Kliczewski has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 20: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/35181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: utils: build cert paths in single place
Piotr Kliczewski has posted comments on this change. Change subject: utils: build cert paths in single place .. Patch Set 13: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yedidyah Bar David Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: inspect.getargspec() is deprecated in py3
gerrit-hooks has posted comments on this change. Change subject: tests: inspect.getargspec() is deprecated in py3 .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25a58ea32bf7548a8f27cc217392fd0958cc8b7d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter for.
Nir Soffer has posted comments on this change. Change subject: qemuimg: Add qcow_compat optional parameter for. .. Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/64169/9//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-09-20 01:41:01 +0300 Line 4: Commit: Maor Lipchuk Line 5: CommitDate: 2016-09-22 15:03:52 +0300 Line 6: Line 7: qemuimg: Add qcow_compat optional parameter for. qcow_compat -> qcow2_compat for. ? Line 8: Line 9: Add qcow_compat parameter that indicates the apropriate qemu Line 10: compatibility level to be used for create and convert operations. Line 11: Line 5: CommitDate: 2016-09-22 15:03:52 +0300 Line 6: Line 7: qemuimg: Add qcow_compat optional parameter for. Line 8: Line 9: Add qcow_compat parameter that indicates the apropriate qemu qemu compatibility level -> qcow2 compat value Line 10: compatibility level to be used for create and convert operations. Line 11: Line 12: Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180 -- To view, visit https://gerrit.ovirt.org/64169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bbf8a60d0af1f99b3fae2c30ac06b36d5986180 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: stomp: simplified client
Irit Goihman has posted comments on this change. Change subject: stomp: simplified client .. Patch Set 10: Verified+1 verified by running jsonrpc Host.getVMList -- To view, visit https://gerrit.ovirt.org/59151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Unlink volume runtime dir after live merge
Ala Hino has posted comments on this change. Change subject: Live Merge: Unlink volume runtime dir after live merge .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/59725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Unlink volume runtime dir after live merge
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Unlink volume runtime dir after live merge .. Patch Set 6: * #1321018::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1321018::OK, public bug * Check Product::#1321018::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: teardown volume on HSM after live merge
Ala Hino has posted comments on this change. Change subject: Live Merge: teardown volume on HSM after live merge .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/64301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: teardown volume on HSM after live merge
gerrit-hooks has posted comments on this change. Change subject: Live Merge: teardown volume on HSM after live merge .. Patch Set 1: * #1377849::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1377849::OK, public bug * Check Product::#1377849::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: Unlink volume runtime dir after live merge
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Unlink volume runtime dir after live merge .. Patch Set 5: * #1321018::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1321018::OK, public bug * Check Product::#1321018::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: Live Merge: teardown volume on HSM after live merge
Ala Hino has uploaded a new change for review. Change subject: Live Merge: teardown volume on HSM after live merge .. Live Merge: teardown volume on HSM after live merge If a VM is running on HSM and live merge is performed, the LV isn't deactivated because, the deactivation is done when deleting the volume. However, deleting the volume is done on SPM and this means that the LV is not deactivated on the HSM. In this patch, a logic to teardown the volume added after live merge has completed. Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549 Bug-Url: https://bugzilla.redhat.com/1377849 Signed-off-by: Ala Hino --- M vdsm/storage/blockSD.py M vdsm/storage/sd.py M vdsm/virt/vm.py 3 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/64301/1 diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py index 8ac7433..a538581 100644 --- a/vdsm/storage/blockSD.py +++ b/vdsm/storage/blockSD.py @@ -811,6 +811,9 @@ sd.LEASE_BLOCKS) return clusterlock.Lease(volUUID, self.getLeasesFilePath(), offset) +def teardownVolume(self, volUUID): +lvm.deactivateLVs(self.sdUUID, [volUUID]) + class BlockStorageDomain(sd.StorageDomain): manifestClass = BlockStorageDomainManifest diff --git a/vdsm/storage/sd.py b/vdsm/storage/sd.py index b5b902e..29dcf53 100644 --- a/vdsm/storage/sd.py +++ b/vdsm/storage/sd.py @@ -525,6 +525,13 @@ if preallocate is not None and preallocate not in sc.VOL_TYPE: raise se.IncorrectType(preallocate) +def teardownVolume(self, volUUID): +""" +By default, this method does nothing. It is overriden in blockSD +to do the necessary cleaning. +""" +pass + class StorageDomain(object): log = logging.getLogger("storage.StorageDomain") diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index 1d9a3d5..7004615 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -65,6 +65,7 @@ from vdsm.virt.utils import isVdsmImage, cleanup_guest_socket from storage import outOfProcess as oop from storage import sd +from storage.sdc import sdCache # local imports # In future those should be imported via .. @@ -4763,6 +4764,10 @@ self.drive.imageID, baseVolUUID, topVolInfo['capacity']) +def teardownVolume(self, volUUID): +dom_manifest = sdCache.produce_manifest(self.drive.domainID) +dom_manifest.teardownVolume(volUUID) + @utils.traceback() def run(self): self.update_base_size() @@ -4776,6 +4781,8 @@ self.success = True self.vm.log.info("Synchronization completed (job %s)", self.job['jobID']) +# teardown the merged volume +self.teardownVolume(self.job['topVolume']) def isSuccessful(self): """ -- To view, visit https://gerrit.ovirt.org/64301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: utils: build cert paths in single place
Irit Goihman has posted comments on this change. Change subject: utils: build cert paths in single place .. Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/52354/12/vdsm/sos/vdsm.py.in File vdsm/sos/vdsm.py.in: Line 104: self.addCopySpec("/tmp/vds_bootstrap*") Line 105: self.addCopySpec("/etc/vdsm/*") Line 106: logsize = self.getOption('logsize') Line 107: self.__addCopySpecLogLimit("/var/log/vdsm/*", logsize) Line 108: self._addVdsmRunDir() > I'm working on a change now, I only rebased the patch and didn't refer the Done Line 109: self.addCopySpec("/etc/pki/vdsm") Line 110: self.addCopySpec("@HOOKSDIR@") Line 111: self.addCopySpec("@VDSMLIBDIR@") Line 112: self.addCopySpec("/var/log/ovirt.log") -- To view, visit https://gerrit.ovirt.org/52354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yedidyah Bar David Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: utils: build cert paths in single place
gerrit-hooks has posted comments on this change. Change subject: utils: build cert paths in single place .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/52354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yedidyah Bar David Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Ignore missing graphics from VM conf on target host
gerrit-hooks has posted comments on this change. Change subject: net: Ignore missing graphics from VM conf on target host .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64300 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cc730c6448b1f70500c86b3ab39af21fa23bd5a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Ignore missing graphics from VM conf on target host
Edward Haas has uploaded a new change for review. Change subject: net: Ignore missing graphics from VM conf on target host .. net: Ignore missing graphics from VM conf on target host The new VM migration libvirt hook handling, recreate the interface and graphics devices of the domxml to fir the target host. It does so using the VM conf data. Unfortunate, there was a bug in Engine that did not pushed the graphics configuration to VDSM, leaving VM conf without the display information. VDSM on the other hand, used a default, listen to all, when this data has not been received from Engine. On migration, the domxml includes the graphics section while the target VM conf does not, causing an exception that fails the action. This patch silently ignores such scenarios, leaving the source domxml as is in the graphics section. Change-Id: I8cc730c6448b1f70500c86b3ab39af21fa23bd5a Signed-off-by: Edward Haas --- M vdsm/virt/vm_migrate_hook.py 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/64300/1 diff --git a/vdsm/virt/vm_migrate_hook.py b/vdsm/virt/vm_migrate_hook.py index 633e4f0..0ae3995 100755 --- a/vdsm/virt/vm_migrate_hook.py +++ b/vdsm/virt/vm_migrate_hook.py @@ -37,6 +37,10 @@ pass +class VmMigrationMissingDisplayConf(Exception): +pass + + def main(domain, event, phase, stdin=sys.stdin, stdout=sys.stdout, *args): if event not in ('migrate', 'restore'): sys.exit(0) @@ -77,7 +81,14 @@ if 'devices' not in target_vm_conf: raise VmMigrationHookError('No devices entity in VM conf') -_set_graphics(devices, target_vm_conf) +try: +_set_graphics(devices, target_vm_conf) +except VmMigrationMissingDisplayConf: +# Due to a bug in Engine, there can be a scenario where the domxml +# includes a graphics section, however, the VM config on target does +# not. In such cases, ignore and do not touch this section. +pass + _set_bridge_interfaces(devices, target_vm_conf) @@ -174,7 +185,7 @@ if params and 'displayNetwork' in params and 'displayIp' in params: return params['displayNetwork'], params['displayIp'] -raise VmMigrationHookError('VM conf graphics not detected') +raise VmMigrationMissingDisplayConf('VM conf graphics not detected') def _vm_item(vdscli, vm_uuid): -- To view, visit https://gerrit.ovirt.org/64300 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8cc730c6448b1f70500c86b3ab39af21fa23bd5a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: drop the warnings module configuration
Irit Goihman has posted comments on this change. Change subject: vdsm: drop the warnings module configuration .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I791882a2dd8ba2dda9135b087bca33610db8a20d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org