[GitHub] dxichen opened a new pull request #1: Documentation updates

2019-01-23 Thread GitBox
dxichen opened a new pull request #1: Documentation updates URL: https://github.com/apache/samza-beam-examples/pull/1 @xinyuiscool Fixed missing instructions This is an automated message from the Apache Git Service. To respond

[GitHub] srinipunuru merged pull request #909: Support for empty records

2019-02-07 Thread GitBox
srinipunuru merged pull request #909: Support for empty records URL: https://github.com/apache/samza/pull/909 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use t

[GitHub] srinipunuru opened a new pull request #911: Support for types in Samza SQL UDF

2019-02-07 Thread GitBox
srinipunuru opened a new pull request #911: Support for types in Samza SQL UDF URL: https://github.com/apache/samza/pull/911 This PR adds following capabilities to UDF 1. Adds typed UDFS : Previously samza sql udfs were un-typed all the params used to be Objects, Although this allowe

[GitHub] srinipunuru commented on a change in pull request #911: Support for types in Samza SQL UDF

2019-02-07 Thread GitBox
srinipunuru commented on a change in pull request #911: Support for types in Samza SQL UDF URL: https://github.com/apache/samza/pull/911#discussion_r254886952 ## File path: samza-sql/src/main/java/org/apache/samza/sql/data/SamzaSqlExecutionContext.java ## @@ -38,7 +40,7 @

[GitHub] srinipunuru commented on a change in pull request #911: Support for types in Samza SQL UDF

2019-02-07 Thread GitBox
srinipunuru commented on a change in pull request #911: Support for types in Samza SQL UDF URL: https://github.com/apache/samza/pull/911#discussion_r254888242 ## File path: samza-sql/src/main/java/org/apache/samza/sql/data/SamzaSqlExecutionContext.java ## @@ -52,16 +54,19

[GitHub] shenodaguirguis commented on a change in pull request #911: Support for types in Samza SQL UDF

2019-02-07 Thread GitBox
shenodaguirguis commented on a change in pull request #911: Support for types in Samza SQL UDF URL: https://github.com/apache/samza/pull/911#discussion_r254915133 ## File path: samza-sql/src/main/java/org/apache/samza/sql/data/SamzaSqlExecutionContext.java ## @@ -52,16 +5

[GitHub] rmatharu opened a new pull request #912: Test sideinputrefactor

2019-02-07 Thread GitBox
rmatharu opened a new pull request #912: Test sideinputrefactor URL: https://github.com/apache/samza/pull/912 DO NOT REVIEW This is an automated message from the Apache Git Service. To respond to the message, please log on Git

[GitHub] strkkk opened a new pull request #913: SAMZA-2102: [samza-azure] code cleanup and refactoring

2019-02-08 Thread GitBox
strkkk opened a new pull request #913: SAMZA-2102: [samza-azure] code cleanup and refactoring URL: https://github.com/apache/samza/pull/913 1. Removed deprecated junit.framework.Assert 2. Add final modifiers 3. Remove redundant things (L literal, modifiers, local variables) 4. Opti

[GitHub] strkkk opened a new pull request #914: SAMZA-2103: [samza-aws] code cleanup and refactoring

2019-02-08 Thread GitBox
strkkk opened a new pull request #914: SAMZA-2103: [samza-aws] code cleanup and refactoring URL: https://github.com/apache/samza/pull/914 1. Redundant things removed 2. Several methods simplified 3. Condition ``if (numRecordsPerShard > 0)`` in ``TestKinesisSystemConsumer.java`` was

[GitHub] rmatharu closed pull request #876: SEP-19 : Basic Standby task/container implementation

2019-02-08 Thread GitBox
rmatharu closed pull request #876: SEP-19 : Basic Standby task/container implementation URL: https://github.com/apache/samza/pull/876 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] rmatharu commented on issue #876: SEP-19 : Basic Standby task/container implementation

2019-02-08 Thread GitBox
rmatharu commented on issue #876: SEP-19 : Basic Standby task/container implementation URL: https://github.com/apache/samza/pull/876#issuecomment-461914315 Closing this in lieu of https://github.com/apache/samza/pull/912 and a follow on to that. ---

[GitHub] atoomula commented on a change in pull request #911: Support for types in Samza SQL UDF

2019-02-09 Thread GitBox
atoomula commented on a change in pull request #911: Support for types in Samza SQL UDF URL: https://github.com/apache/samza/pull/911#discussion_r255300421 ## File path: samza-sql/src/main/java/org/apache/samza/sql/planner/SamzaSqlScalarFunctionImpl.java ## @@ -61,17 +63,

[GitHub] atoomula commented on a change in pull request #911: Support for types in Samza SQL UDF

2019-02-09 Thread GitBox
atoomula commented on a change in pull request #911: Support for types in Samza SQL UDF URL: https://github.com/apache/samza/pull/911#discussion_r255300436 ## File path: samza-sql/src/main/java/org/apache/samza/sql/data/SamzaSqlExecutionContext.java ## @@ -38,7 +40,10 @@

[GitHub] atoomula commented on a change in pull request #911: Support for types in Samza SQL UDF

2019-02-09 Thread GitBox
atoomula commented on a change in pull request #911: Support for types in Samza SQL UDF URL: https://github.com/apache/samza/pull/911#discussion_r255300768 ## File path: samza-sql/src/main/java/org/apache/samza/sql/fn/GetSqlFieldUdf.java ## @@ -51,22 +52,21 @@ *

[GitHub] atoomula commented on a change in pull request #911: Support for types in Samza SQL UDF

2019-02-09 Thread GitBox
atoomula commented on a change in pull request #911: Support for types in Samza SQL UDF URL: https://github.com/apache/samza/pull/911#discussion_r255299964 ## File path: samza-sql/src/main/java/org/apache/samza/sql/fn/BuildOutputRecordUdf.java ## @@ -61,13 +61,13 @@ * I

[GitHub] atoomula commented on a change in pull request #911: Support for types in Samza SQL UDF

2019-02-09 Thread GitBox
atoomula commented on a change in pull request #911: Support for types in Samza SQL UDF URL: https://github.com/apache/samza/pull/911#discussion_r255277549 ## File path: samza-api/src/main/java/org/apache/samza/sql/udfs/ScalarUdf.java ## @@ -36,5 +36,4 @@ * @param udfC

[GitHub] srinipunuru commented on a change in pull request #911: Support for types in Samza SQL UDF

2019-02-11 Thread GitBox
srinipunuru commented on a change in pull request #911: Support for types in Samza SQL UDF URL: https://github.com/apache/samza/pull/911#discussion_r255613496 ## File path: samza-sql/src/main/java/org/apache/samza/sql/data/SamzaSqlExecutionContext.java ## @@ -38,7 +40,10

[GitHub] srinipunuru commented on a change in pull request #911: Support for types in Samza SQL UDF

2019-02-11 Thread GitBox
srinipunuru commented on a change in pull request #911: Support for types in Samza SQL UDF URL: https://github.com/apache/samza/pull/911#discussion_r255614560 ## File path: samza-sql/src/main/java/org/apache/samza/sql/fn/GetSqlFieldUdf.java ## @@ -51,22 +52,21 @@ *

[GitHub] weiqingy commented on a change in pull request #911: Support for types in Samza SQL UDF

2019-02-11 Thread GitBox
weiqingy commented on a change in pull request #911: Support for types in Samza SQL UDF URL: https://github.com/apache/samza/pull/911#discussion_r255648188 ## File path: samza-api/src/main/java/org/apache/samza/sql/udfs/ScalarUdf.java ## @@ -24,7 +24,7 @@ /** * The ba

[GitHub] weiqingy commented on a change in pull request #911: Support for types in Samza SQL UDF

2019-02-11 Thread GitBox
weiqingy commented on a change in pull request #911: Support for types in Samza SQL UDF URL: https://github.com/apache/samza/pull/911#discussion_r255648188 ## File path: samza-api/src/main/java/org/apache/samza/sql/udfs/ScalarUdf.java ## @@ -24,7 +24,7 @@ /** * The ba

[GitHub] weiqingy commented on a change in pull request #911: Support for types in Samza SQL UDF

2019-02-11 Thread GitBox
weiqingy commented on a change in pull request #911: Support for types in Samza SQL UDF URL: https://github.com/apache/samza/pull/911#discussion_r255648188 ## File path: samza-api/src/main/java/org/apache/samza/sql/udfs/ScalarUdf.java ## @@ -24,7 +24,7 @@ /** * The ba

[GitHub] atoomula commented on a change in pull request #911: Support for types in Samza SQL UDF

2019-02-11 Thread GitBox
atoomula commented on a change in pull request #911: Support for types in Samza SQL UDF URL: https://github.com/apache/samza/pull/911#discussion_r255648927 ## File path: samza-sql/src/main/java/org/apache/samza/sql/fn/GetSqlFieldUdf.java ## @@ -51,22 +52,21 @@ *

[GitHub] atoomula commented on a change in pull request #911: Support for types in Samza SQL UDF

2019-02-11 Thread GitBox
atoomula commented on a change in pull request #911: Support for types in Samza SQL UDF URL: https://github.com/apache/samza/pull/911#discussion_r255631894 ## File path: samza-sql/src/main/java/org/apache/samza/sql/data/SamzaSqlExecutionContext.java ## @@ -38,7 +40,10 @@

[GitHub] srinipunuru merged pull request #911: Support for types in Samza SQL UDF

2019-02-11 Thread GitBox
srinipunuru merged pull request #911: Support for types in Samza SQL UDF URL: https://github.com/apache/samza/pull/911 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] rmatharu opened a new pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

2019-02-11 Thread GitBox
rmatharu opened a new pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility URL: https://github.com/apache/samza/pull/915 This is an automated message fro

[GitHub] mynameborat commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

2019-02-11 Thread GitBox
mynameborat commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility URL: https://github.com/apache/samza/pull/915#discussion_r255819677 ## File path: samza-core/src/main/java/org/apache/sa

[GitHub] mynameborat commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

2019-02-11 Thread GitBox
mynameborat commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility URL: https://github.com/apache/samza/pull/915#discussion_r255819974 ## File path: samza-core/src/main/java/org/apache/sa

[GitHub] mynameborat commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

2019-02-11 Thread GitBox
mynameborat commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility URL: https://github.com/apache/samza/pull/915#discussion_r255824624 ## File path: samza-core/src/main/java/org/apache/sa

[GitHub] mynameborat commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

2019-02-11 Thread GitBox
mynameborat commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility URL: https://github.com/apache/samza/pull/915#discussion_r255822722 ## File path: samza-core/src/main/java/org/apache/sa

[GitHub] mynameborat commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

2019-02-11 Thread GitBox
mynameborat commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility URL: https://github.com/apache/samza/pull/915#discussion_r255823615 ## File path: samza-core/src/test/scala/org/apache/s

[GitHub] rmatharu commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

2019-02-11 Thread GitBox
rmatharu commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility URL: https://github.com/apache/samza/pull/915#discussion_r255834501 ## File path: samza-core/src/main/java/org/apache/samza/

[GitHub] rmatharu commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

2019-02-11 Thread GitBox
rmatharu commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility URL: https://github.com/apache/samza/pull/915#discussion_r255834529 ## File path: samza-core/src/main/java/org/apache/samza/

[GitHub] rmatharu commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

2019-02-11 Thread GitBox
rmatharu commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility URL: https://github.com/apache/samza/pull/915#discussion_r255834674 ## File path: samza-core/src/main/java/org/apache/samza/

[GitHub] rmatharu commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

2019-02-11 Thread GitBox
rmatharu commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility URL: https://github.com/apache/samza/pull/915#discussion_r255834702 ## File path: samza-core/src/test/scala/org/apache/samza

[GitHub] rmatharu commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

2019-02-11 Thread GitBox
rmatharu commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility URL: https://github.com/apache/samza/pull/915#discussion_r255834741 ## File path: samza-core/src/main/java/org/apache/samza/

[GitHub] mynameborat commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

2019-02-12 Thread GitBox
mynameborat commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility URL: https://github.com/apache/samza/pull/915#discussion_r256068006 ## File path: samza-core/src/main/java/org/apache/sa

[GitHub] mynameborat commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

2019-02-12 Thread GitBox
mynameborat commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility URL: https://github.com/apache/samza/pull/915#discussion_r256068006 ## File path: samza-core/src/main/java/org/apache/sa

[GitHub] shanthoosh merged pull request #874: SAMZA-2058: Integrate the input stream expansion aware SystemStreamGrouper to JobModel generation flow.

2019-02-12 Thread GitBox
shanthoosh merged pull request #874: SAMZA-2058: Integrate the input stream expansion aware SystemStreamGrouper to JobModel generation flow. URL: https://github.com/apache/samza/pull/874 This is an automated message from the

[GitHub] vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover

2019-02-12 Thread GitBox
vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover URL: https://github.com/apache/samza/pull/903#discussion_r256084515 ## File path: samza-core/src/main/java/org/apache/samza/clus

[GitHub] vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover

2019-02-12 Thread GitBox
vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover URL: https://github.com/apache/samza/pull/903#discussion_r255766345 ## File path: samza-core/src/main/java/org/apache/samza/clus

[GitHub] vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover

2019-02-12 Thread GitBox
vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover URL: https://github.com/apache/samza/pull/903#discussion_r256082808 ## File path: samza-core/src/main/java/org/apache/samza/clus

[GitHub] vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover

2019-02-12 Thread GitBox
vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover URL: https://github.com/apache/samza/pull/903#discussion_r255777131 ## File path: samza-core/src/main/java/org/apache/samza/clus

[GitHub] vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover

2019-02-12 Thread GitBox
vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover URL: https://github.com/apache/samza/pull/903#discussion_r255771228 ## File path: samza-core/src/main/java/org/apache/samza/clus

[GitHub] vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover

2019-02-12 Thread GitBox
vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover URL: https://github.com/apache/samza/pull/903#discussion_r256070415 ## File path: samza-core/src/main/java/org/apache/samza/clus

[GitHub] vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover

2019-02-12 Thread GitBox
vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover URL: https://github.com/apache/samza/pull/903#discussion_r256081802 ## File path: samza-core/src/main/java/org/apache/samza/clus

[GitHub] vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover

2019-02-12 Thread GitBox
vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover URL: https://github.com/apache/samza/pull/903#discussion_r256072645 ## File path: samza-core/src/main/java/org/apache/samza/clus

[GitHub] vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover

2019-02-12 Thread GitBox
vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover URL: https://github.com/apache/samza/pull/903#discussion_r255769800 ## File path: samza-core/src/main/java/org/apache/samza/clus

[GitHub] vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover

2019-02-12 Thread GitBox
vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover URL: https://github.com/apache/samza/pull/903#discussion_r256083123 ## File path: samza-core/src/main/java/org/apache/samza/clus

[GitHub] vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover

2019-02-12 Thread GitBox
vjagadish1989 commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover URL: https://github.com/apache/samza/pull/903#discussion_r254810012 ## File path: samza-core/src/main/java/org/apache/samza/clus

[GitHub] rmatharu commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

2019-02-12 Thread GitBox
rmatharu commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility URL: https://github.com/apache/samza/pull/915#discussion_r256096861 ## File path: samza-core/src/main/java/org/apache/samza/

[GitHub] rmatharu commented on issue #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

2019-02-12 Thread GitBox
rmatharu commented on issue #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility URL: https://github.com/apache/samza/pull/915#issuecomment-462886896 Addressed all comments. --

[GitHub] mynameborat commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

2019-02-12 Thread GitBox
mynameborat commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility URL: https://github.com/apache/samza/pull/915#discussion_r256143994 ## File path: samza-core/src/main/scala/org/apache/s

[GitHub] mynameborat commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

2019-02-12 Thread GitBox
mynameborat commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility URL: https://github.com/apache/samza/pull/915#discussion_r256144714 ## File path: samza-core/src/main/scala/org/apache/s

[GitHub] srinipunuru opened a new pull request #916: End to end test case for union type with subRecord

2019-02-12 Thread GitBox
srinipunuru opened a new pull request #916: End to end test case for union type with subRecord URL: https://github.com/apache/samza/pull/916 1. Fix the bug in AvroRelConverter where it throws when a union type has a subRecord 2. Adding a test case with union type with a subrecord.

[GitHub] rmatharu commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

2019-02-12 Thread GitBox
rmatharu commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility URL: https://github.com/apache/samza/pull/915#discussion_r256213370 ## File path: samza-core/src/main/scala/org/apache/samza

[GitHub] rmatharu commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

2019-02-12 Thread GitBox
rmatharu commented on a change in pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility URL: https://github.com/apache/samza/pull/915#discussion_r256213346 ## File path: samza-core/src/main/scala/org/apache/samza

[GitHub] jmakes merged pull request #914: SAMZA-2103: [samza-aws] code cleanup and refactoring

2019-02-13 Thread GitBox
jmakes merged pull request #914: SAMZA-2103: [samza-aws] code cleanup and refactoring URL: https://github.com/apache/samza/pull/914 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] atoomula commented on a change in pull request #916: End to end test case for union type with subRecord

2019-02-13 Thread GitBox
atoomula commented on a change in pull request #916: End to end test case for union type with subRecord URL: https://github.com/apache/samza/pull/916#discussion_r256434838 ## File path: samza-sql/src/main/java/org/apache/samza/sql/avro/AvroRelConverter.java ## @@ -207,7 +

[GitHub] jmakes merged pull request #913: SAMZA-2102: [samza-azure] code cleanup and refactoring

2019-02-13 Thread GitBox
jmakes merged pull request #913: SAMZA-2102: [samza-azure] code cleanup and refactoring URL: https://github.com/apache/samza/pull/913 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] atoomula commented on a change in pull request #916: End to end test case for union type with subRecord

2019-02-13 Thread GitBox
atoomula commented on a change in pull request #916: End to end test case for union type with subRecord URL: https://github.com/apache/samza/pull/916#discussion_r256438362 ## File path: samza-sql/src/main/java/org/apache/samza/sql/avro/AvroRelConverter.java ## @@ -283,4 +

[GitHub] srinipunuru commented on a change in pull request #916: End to end test case for union type with subRecord

2019-02-13 Thread GitBox
srinipunuru commented on a change in pull request #916: End to end test case for union type with subRecord URL: https://github.com/apache/samza/pull/916#discussion_r256547872 ## File path: samza-sql/src/main/java/org/apache/samza/sql/avro/AvroRelConverter.java ## @@ -207,

[GitHub] srinipunuru commented on issue #916: End to end test case for union type with subRecord

2019-02-13 Thread GitBox
srinipunuru commented on issue #916: End to end test case for union type with subRecord URL: https://github.com/apache/samza/pull/916#issuecomment-463330256 > General comment not entirely related to this specific change: > All the schemas in our tests have an outer record with primitive

[GitHub] srinipunuru merged pull request #916: End to end test case for union type with subRecord

2019-02-13 Thread GitBox
srinipunuru merged pull request #916: End to end test case for union type with subRecord URL: https://github.com/apache/samza/pull/916 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] srinipunuru commented on a change in pull request #916: End to end test case for union type with subRecord

2019-02-13 Thread GitBox
srinipunuru commented on a change in pull request #916: End to end test case for union type with subRecord URL: https://github.com/apache/samza/pull/916#discussion_r256548128 ## File path: samza-sql/src/main/java/org/apache/samza/sql/avro/AvroRelConverter.java ## @@ -283,

[GitHub] asfgit closed pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility

2019-02-13 Thread GitBox
asfgit closed pull request #915: Consolidating offset read and write for store-offsets and side-inputs, maintaining backward compatbility URL: https://github.com/apache/samza/pull/915 This is an automated message from the Ap

[GitHub] rmatharu opened a new pull request #917: Adding bounded-time start of SamzaContainer from StreamProcessor

2019-02-13 Thread GitBox
rmatharu opened a new pull request #917: Adding bounded-time start of SamzaContainer from StreamProcessor URL: https://github.com/apache/samza/pull/917 This bounded-time start is needed to account for cases where the start of a container never returns within a bounded amount of time, e.g.,

[GitHub] Sanil15 commented on a change in pull request #917: Adding bounded-time start of SamzaContainer from StreamProcessor

2019-02-13 Thread GitBox
Sanil15 commented on a change in pull request #917: Adding bounded-time start of SamzaContainer from StreamProcessor URL: https://github.com/apache/samza/pull/917#discussion_r256664270 ## File path: samza-core/src/main/java/org/apache/samza/processor/StreamProcessor.java #

[GitHub] shanthoosh closed pull request #901: SAMZA-2094: Implement the StartpointVisitor for KafkaSystemConsumer.

2019-02-13 Thread GitBox
shanthoosh closed pull request #901: SAMZA-2094: Implement the StartpointVisitor for KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/901 This is an automated message from the Apache Git Service. To respond to

[GitHub] Sanil15 commented on a change in pull request #917: Adding bounded-time start of SamzaContainer from StreamProcessor

2019-02-13 Thread GitBox
Sanil15 commented on a change in pull request #917: Adding bounded-time start of SamzaContainer from StreamProcessor URL: https://github.com/apache/samza/pull/917#discussion_r256665921 ## File path: samza-core/src/main/java/org/apache/samza/processor/StreamProcessor.java #

[GitHub] Sanil15 commented on a change in pull request #917: Adding bounded-time start of SamzaContainer from StreamProcessor

2019-02-13 Thread GitBox
Sanil15 commented on a change in pull request #917: Adding bounded-time start of SamzaContainer from StreamProcessor URL: https://github.com/apache/samza/pull/917#discussion_r256664270 ## File path: samza-core/src/main/java/org/apache/samza/processor/StreamProcessor.java #

[GitHub] Sanil15 commented on a change in pull request #917: Adding bounded-time start of SamzaContainer from StreamProcessor

2019-02-13 Thread GitBox
Sanil15 commented on a change in pull request #917: Adding bounded-time start of SamzaContainer from StreamProcessor URL: https://github.com/apache/samza/pull/917#discussion_r256671506 ## File path: samza-core/src/main/java/org/apache/samza/processor/StreamProcessor.java #

[GitHub] shanthoosh opened a new pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-13 Thread GitBox
shanthoosh opened a new pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918 This is an automated message from the Apache Git Service. To r

[GitHub] Sanil15 commented on a change in pull request #917: Adding bounded-time start of SamzaContainer from StreamProcessor

2019-02-13 Thread GitBox
Sanil15 commented on a change in pull request #917: Adding bounded-time start of SamzaContainer from StreamProcessor URL: https://github.com/apache/samza/pull/917#discussion_r256671506 ## File path: samza-core/src/main/java/org/apache/samza/processor/StreamProcessor.java #

[GitHub] shanthoosh commented on issue #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-13 Thread GitBox
shanthoosh commented on issue #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#issuecomment-463462935 @cameronlee314 Please take a look when you have a chance. -

[GitHub] strkkk opened a new pull request #919: Make config immutable again

2019-02-14 Thread GitBox
strkkk opened a new pull request #919: Make config immutable again URL: https://github.com/apache/samza/pull/919 Config is supposed to be immutable, but method Map#replaceAll in its default implementation mutates the config. Code to check: ``` Map m = new HashMap() { { pu

[GitHub] jmakes merged pull request #919: Make config immutable again

2019-02-14 Thread GitBox
jmakes merged pull request #919: Make config immutable again URL: https://github.com/apache/samza/pull/919 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] vjagadish1989 commented on a change in pull request #899: SAMZA-2091: Update ZkClient in samza-standalone to use string serializer

2019-02-14 Thread GitBox
vjagadish1989 commented on a change in pull request #899: SAMZA-2091: Update ZkClient in samza-standalone to use string serializer URL: https://github.com/apache/samza/pull/899#discussion_r256973855 ## File path: samza-core/src/main/java/org/apache/samza/zk/ZkBarrierForVersionUpgr

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257063321 ## File path: samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSyst

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257058381 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemCo

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257060720 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemCo

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257063162 ## File path: samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSyst

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257062107 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemCo

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257062873 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemCo

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257058746 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemCo

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257061221 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemCo

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257061763 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemCo

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257063620 ## File path: samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSyst

[GitHub] Sanil15 commented on issue #920: SAMZA-2106: Samza app and job config refactor

2019-02-14 Thread GitBox
Sanil15 commented on issue #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#issuecomment-463866182 @vjagadish1989 please have a look. This is an automated message from the Apach

[GitHub] Sanil15 opened a new pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-14 Thread GitBox
Sanil15 opened a new pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920 Proposal doc: https://docs.google.com/document/d/1Q8tNF6zlXSyefOO6koXWgiDuyV6eLngKoU-5KLvq3I4/edit --

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-14 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257073732 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemCo

[GitHub] strkkk opened a new pull request #921: SAMZA-2105: [elasticsearch, hdfs, kafka] code cleanup and refactoring

2019-02-15 Thread GitBox
strkkk opened a new pull request #921: SAMZA-2105: [elasticsearch, hdfs, kafka] code cleanup and refactoring URL: https://github.com/apache/samza/pull/921 1. Added/removed modifiers 2. Guava optional -> java optional and removed guava from samza-elasticsearch module dependencies. Guava

[GitHub] strkkk opened a new pull request #922: SAMZA-2051: bump checkstyle version

2019-02-15 Thread GitBox
strkkk opened a new pull request #922: SAMZA-2051: bump checkstyle version URL: https://github.com/apache/samza/pull/922 Checkstyle version upgrade 5.9 -> 6.11 and fixes to pass checks **Why this version (6.11) but not latest (8.17)?** In version [6.11.1](http://checkstyle.sourcef

[GitHub] rmatharu commented on issue #917: Adding bounded-time start of SamzaContainer from StreamProcessor

2019-02-15 Thread GitBox
rmatharu commented on issue #917: Adding bounded-time start of SamzaContainer from StreamProcessor URL: https://github.com/apache/samza/pull/917#issuecomment-464229696 Closing this since deciding the bound on the start of a container is non-trivial, and depends on a large number of para

[GitHub] rmatharu closed pull request #917: Adding bounded-time start of SamzaContainer from StreamProcessor

2019-02-15 Thread GitBox
rmatharu closed pull request #917: Adding bounded-time start of SamzaContainer from StreamProcessor URL: https://github.com/apache/samza/pull/917 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] Sanil15 edited a comment on issue #920: SAMZA-2106: Samza app and job config refactor

2019-02-15 Thread GitBox
Sanil15 edited a comment on issue #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#issuecomment-463866182 @vjagadish1989 @srinipunuru please have a look. This is an automated m

[GitHub] rmatharu opened a new pull request #923: Adding a bound on EventHubSystemConsumer's initalizeEventHubsManagers

2019-02-15 Thread GitBox
rmatharu opened a new pull request #923: Adding a bound on EventHubSystemConsumer's initalizeEventHubsManagers URL: https://github.com/apache/samza/pull/923 Being a sync call, eventHubManagers can cause the container-start or the runLoop to block. Like so, "Samza StreamProcessor Co

[GitHub] dxichen commented on a change in pull request #923: Adding a bound on EventHubSystemConsumer's initalizeEventHubsManagers

2019-02-15 Thread GitBox
dxichen commented on a change in pull request #923: Adding a bound on EventHubSystemConsumer's initalizeEventHubsManagers URL: https://github.com/apache/samza/pull/923#discussion_r257425144 ## File path: samza-azure/src/main/java/org/apache/samza/system/eventhub/consumer/EventHubSy

[GitHub] dxichen commented on a change in pull request #923: Adding a bound on EventHubSystemConsumer's initalizeEventHubsManagers

2019-02-15 Thread GitBox
dxichen commented on a change in pull request #923: Adding a bound on EventHubSystemConsumer's initalizeEventHubsManagers URL: https://github.com/apache/samza/pull/923#discussion_r257425828 ## File path: samza-azure/src/main/java/org/apache/samza/system/eventhub/consumer/EventHubSy

[GitHub] dxichen commented on a change in pull request #923: Adding a bound on EventHubSystemConsumer's initalizeEventHubsManagers

2019-02-15 Thread GitBox
dxichen commented on a change in pull request #923: Adding a bound on EventHubSystemConsumer's initalizeEventHubsManagers URL: https://github.com/apache/samza/pull/923#discussion_r257430975 ## File path: samza-azure/src/main/java/org/apache/samza/system/eventhub/consumer/EventHubSy

[GitHub] rmatharu commented on a change in pull request #923: Adding a bound on EventHubSystemConsumer's initalizeEventHubsManagers

2019-02-15 Thread GitBox
rmatharu commented on a change in pull request #923: Adding a bound on EventHubSystemConsumer's initalizeEventHubsManagers URL: https://github.com/apache/samza/pull/923#discussion_r257439718 ## File path: samza-azure/src/main/java/org/apache/samza/system/eventhub/consumer/EventHubS

  1   2   3   4   5   6   7   8   9   10   >