Re: [HACKERS] Combining Aggregates

2015-03-05 Thread Ashutosh Bapat
On Fri, Mar 6, 2015 at 12:41 PM, David Rowley wrote: > On 6 March 2015 at 19:01, Ashutosh Bapat > wrote: > >> Postgres-XC solved this question by creating a plan with two Agg/Group >> nodes, one for combining transitioned result and one for creating the >> distributed transition results (one per

Re: [HACKERS] pg_upgrade and rsync

2015-03-05 Thread Vladimir Borodin
> 6 марта 2015 г., в 6:11, Bruce Momjian написал(а): > > On Thu, Mar 5, 2015 at 10:55:28AM +0300, Vladimir Borodin wrote: >>You are correct that a pg_controldata file is copied over that has >>wal_level=minimal, but that should not be a problem. >> >> >> I suppose, this is the root ca

Re: [HACKERS] Combining Aggregates

2015-03-05 Thread David Rowley
On 6 March 2015 at 19:01, Ashutosh Bapat wrote: > Postgres-XC solved this question by creating a plan with two Agg/Group > nodes, one for combining transitioned result and one for creating the > distributed transition results (one per distributed run per group). > > So, Agg/Group for combining

Re: [HACKERS] Combining Aggregates

2015-03-05 Thread Ashutosh Bapat
On Thu, Mar 5, 2015 at 9:30 AM, Kouhei Kaigai wrote: > > On Wed, Mar 4, 2015 at 4:41 AM, David Rowley > wrote: > > >> This thread mentions "parallel queries" as a use case, but that means > > >> passing data between processes, and that requires being able to > > >> serialize and deserialize the

Re: [HACKERS] Weirdly pesimistic estimates in optimizer

2015-03-05 Thread Tom Lane
=?UTF-8?Q?David_Kube=C4=8Dka?= writes: > There is division by loop_count because of predicted effect of caching and > it is exactly this division which makes the run_cost for single index > lookup so low compared with the query version with random_fk_uniq. So the > main problem is that the planne

Re: [HACKERS] Strange assertion using VACOPT_FREEZE in vacuum.c

2015-03-05 Thread Michael Paquier
On Fri, Mar 6, 2015 at 12:42 AM, Robert Haas wrote: > On Thu, Mar 5, 2015 at 9:58 AM, Alvaro Herrera wrote: >> Here's a simple idea to improve the patch: make VacuumParams include >> VacuumStmt and the for_wraparound and do_toast flags. ISTM that reduces >> the number of arguments to be passed dow

Re: [HACKERS] Table-level log_autovacuum_min_duration

2015-03-05 Thread Fujii Masao
On Thu, Mar 5, 2015 at 9:49 PM, Michael Paquier wrote: > On Thu, Mar 5, 2015 at 7:10 PM, Fujii Masao wrote: >> With the patch, VACUUM ANALYZE VERBOSE doesn't emit any verbose message. >> Why did you remove that functionality? > > Oops. Sorry about that. In gram.y, the combination of VacuumStmt wit

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2015-03-05 Thread Fujii Masao
On Thu, Mar 5, 2015 at 10:28 PM, Andres Freund wrote: > On 2015-03-05 12:14:04 +, Syed, Rahila wrote: >> Please find attached a patch. As discussed, flag to denote >> compression and presence of hole in block image has been added in >> XLogRecordImageHeader rather than block header. > > FWIW,

Re: [HACKERS] Providing catalog view to pg_hba.conf file - Patch submission

2015-03-05 Thread Peter Eisentraut
On 3/5/15 9:42 AM, Greg Stark wrote: > Well if you want to read the file as is you can do so using the file > reading functions which afaik were specifically intended for the > purpose of writing config editing tools. Sure, but those things are almost never installed by default, and I don't want t

Re: [HACKERS] pg_upgrade and rsync

2015-03-05 Thread Bruce Momjian
On Thu, Mar 5, 2015 at 10:55:28AM +0300, Vladimir Borodin wrote: > You are correct that a pg_controldata file is copied over that has > wal_level=minimal, but that should not be a problem. > > > I suppose, this is the root cause of why replica does not start as hot > standby. > It it en

Re: [HACKERS] Weirdly pesimistic estimates in optimizer

2015-03-05 Thread Jim Nasby
On 3/5/15 7:58 PM, Jim Nasby wrote: This got answered on one of the other lists, right? That was supposed to be off-list. I'll answer my own question: yes. Sorry for the noise. :( -- Jim Nasby, Data Architect, Blue Treble Consulting Data in Trouble? Get it in Treble! http://BlueTreble.com --

Re: [HACKERS] anyarray

2015-03-05 Thread Peter Eisentraut
On 3/4/15 10:28 PM, Tom Lane wrote: > Peter Eisentraut writes: >> On 2/13/15 10:20 AM, Teodor Sigaev wrote: >>> Some of users of intarray contrib module wish to use its features with >>> another kind of arrays, not only for int4 type. Suggested module >>> generalizes intarray over other (not all)

Re: [HACKERS] Configurable location for extension .control files

2015-03-05 Thread Jim Nasby
On 3/4/15 1:41 AM, Oskari Saarenmaa wrote: >I'm interested in this because it could potentially make it possible to >install SQL extensions without OS access. (My understanding is there's >some issue with writing the extension files even if LIBDIR is writable >by the OS account). I'm not sure th

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-03-05 Thread Jim Nasby
On 3/2/15 10:58 AM, Sawada Masahiko wrote: On Wed, Feb 25, 2015 at 4:58 PM, Jim Nasby wrote: On 2/24/15 8:28 AM, Sawada Masahiko wrote: According to the above discussion, VACUUM and REINDEX should have trailing options. Tom seems (to me) suggesting that SQL-style (bare word preceded by WITH)

Re: [HACKERS] Weirdly pesimistic estimates in optimizer

2015-03-05 Thread Jim Nasby
On 2/28/15 12:01 PM, David Kubečka wrote: With 'random_fk_dupl': -> Index Scan using facts_fk_idx on facts (cost=0.42..5.75 rows=100 width=15) (actual time=0.009..0.117 rows=98 loops=100) With 'random_fk_uniq': -> Index Scan using facts_fk_idx on facts (cost=0.42..214.26 ro

Re: [HACKERS] object description for FDW user mappings

2015-03-05 Thread David G Johnston
Tom Lane-2 wrote > Amit Langote < > Langote_Amit_f8@.co > > writes: >> By the way, in this case, is "foo" the name/id of a local user or does it >> really refer to some "foo on the remote server"? > > It's the name of a local user. I see your point that somebody might > misread this as suggesti

Re: [HACKERS] Join push-down support for foreign tables

2015-03-05 Thread Kouhei Kaigai
> Actually val and val2 come from public.lt in "r" side, but as you say > it's too difficult to know that from EXPLAIN output. Do you have any > idea to make the "Output" item more readable? > A fundamental reason why we need to have symbolic aliases here is that postgres_fdw has remote query in c

Re: [HACKERS] object description for FDW user mappings

2015-03-05 Thread Tom Lane
Amit Langote writes: > By the way, in this case, is "foo" the name/id of a local user or does it > really refer to some "foo on the remote server"? It's the name of a local user. I see your point that somebody might misread this as suggesting that it's a remote username, but not sure that there'

Re: [HACKERS] object description for FDW user mappings

2015-03-05 Thread Amit Langote
On 06-03-2015 AM 09:30, Tom Lane wrote: > Amit Langote writes: > >> One more option may be "for server" (reading the doc for CREATE USER MAPPING) > > Hm, but then you'd have "user mapping for foo for server bar", which > doesn't read so nicely either. > Yeah, I had totally missed the "for foo"

Re: [HACKERS] object description for FDW user mappings

2015-03-05 Thread Tom Lane
Amit Langote writes: > On 06-03-2015 AM 01:32, Tom Lane wrote: >> +1 for the concept, but to be nitpicky, "in" doesn't seem like the right >> word here. "on server" would read better to me; or perhaps "at server". > One more option may be "for server" (reading the doc for CREATE USER MAPPING) H

[HACKERS] Rethinking pg_dump's function sorting code

2015-03-05 Thread Tom Lane
In bug #12832 Marko Tiikkaja points out that commit 7b583b20b1c95acb621c71251150beef958bb603 created a rather unnecessary dump failure hazard, since it applies pg_get_function_identity_arguments() to every function in the database, even those that won't get dumped. I think we should fix this by get

Re: [HACKERS] object description for FDW user mappings

2015-03-05 Thread Amit Langote
On 06-03-2015 AM 09:18, Amit Langote wrote: > On 06-03-2015 AM 01:32, Tom Lane wrote: >> +1 for the concept, but to be nitpicky, "in" doesn't seem like the right >> word here. "on server" would read better to me; or perhaps "at server". >> > > One more option may be "for server" (reading the doc

Re: [HACKERS] object description for FDW user mappings

2015-03-05 Thread Amit Langote
On 06-03-2015 AM 01:32, Tom Lane wrote: > Alvaro Herrera writes: >> appendStringInfo(&buffer, _("user mapping for %s in server %s"), >> usename, >> srv->servername); > > +1 for the concept, but to be nitpicky, "in" doesn't seem like the right > word here. "on

Re: [HACKERS] INSERT ... ON CONFLICT IGNORE (and UPDATE) 3.0

2015-03-05 Thread Peter Geoghegan
On Wed, Mar 4, 2015 at 5:18 PM, Peter Geoghegan wrote: > Attached patch series forms what I'm calling V3.0 of the INSERT ... ON > CONFLICT IGNORE/UPDATE feature. (Sorry about all the threads. I feel > this development justifies a new thread, though.) Bruce Momjian kindly made available a server f

Re: [HACKERS] Bug in pg_dump

2015-03-05 Thread Michael Paquier
On Wed, Mar 4, 2015 at 2:03 PM, Michael Paquier wrote: > On Wed, Mar 4, 2015 at 6:48 AM, Peter Eisentraut wrote: >> - set up basic scaffolding for TAP tests in src/bin/pg_dump > > Agreed. > >> - write a Perl function that can create an extension on the fly, given >> name, C code, SQL code > > I a

Re: [HACKERS] Question about lazy_space_alloc() / linux over-commit

2015-03-05 Thread Jim Nasby
On 3/4/15 9:10 AM, Robert Haas wrote: On Wed, Feb 25, 2015 at 5:06 PM, Jim Nasby wrote: Could the large allocation[2] for the dead tuple array in lazy_space_alloc cause problems with linux OOM? [1] and some other things I've read indicate that a large mmap will count towards total system memory

Re: [HACKERS] Idea: closing the loop for "pg_ctl reload"

2015-03-05 Thread Jim Nasby
On 3/4/15 7:13 PM, Jan de Visser wrote: On March 4, 2015 11:08:09 PM Andres Freund wrote: Let's get the basic feature (notification of failed reloads) done first. That will be required with or without including the error message. Then we can get more fancy later, if somebody really wants to inv

Re: [HACKERS] MD5 authentication needs help

2015-03-05 Thread Stephen Frost
* Jim Nasby (jim.na...@bluetreble.com) wrote: > On 3/5/15 2:17 PM, Stephen Frost wrote: > >* Jim Nasby (jim.na...@bluetreble.com) wrote: > >I'm all for it, though I would ask that we provide a way for superusers > >to delegate the ability to reset locked accounts to non-superusers. > > > >I'd want

Re: [HACKERS] MD5 authentication needs help

2015-03-05 Thread Jim Nasby
On 3/5/15 2:17 PM, Stephen Frost wrote: * Jim Nasby (jim.na...@bluetreble.com) wrote: On 3/4/15 2:56 PM, Stephen Frost wrote: 2) The per-session salt sent to the client is only 32-bits, meaning that it is possible to reply an observed MD5 hash in ~16k connection attempts. Yes, and we have no

Re: [HACKERS] a2e35b53 added unused variable to ConversionCreate()

2015-03-05 Thread Alvaro Herrera
Peter Geoghegan wrote: > I'm seeing this on a the master branch tip when building at -O2: > > pg_conversion.c: In function ‘ConversionCreate’: > pg_conversion.c:53:6: error: variable ‘oid’ set but not used > [-Werror=unused-but-set-variable] > Oid oid; > ^ > cc1: all warnings being treat

Re: [HACKERS] MD5 authentication needs help

2015-03-05 Thread Stephen Frost
* Jim Nasby (jim.na...@bluetreble.com) wrote: > On 3/4/15 2:56 PM, Stephen Frost wrote: > >>2) The per-session salt sent to the client is only 32-bits, meaning > >>>that it is possible to reply an observed MD5 hash in ~16k connection > >>>attempts. > >Yes, and we have no (PG-based) mechanism to pr

Re: [HACKERS] MD5 authentication needs help

2015-03-05 Thread Jim Nasby
On 3/4/15 2:56 PM, Stephen Frost wrote: 2) The per-session salt sent to the client is only 32-bits, meaning >that it is possible to reply an observed MD5 hash in ~16k connection >attempts. Yes, and we have no (PG-based) mechanism to prevent those connection attempts, which is a pretty horrible

Re: [HACKERS] deparsing utility commands

2015-03-05 Thread Stephen Frost
Alvaro, * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > Thanks for the review. I have pushed these patches, squashed in one > commit, with the exception of the one that changed ALTER TABLE. You had > enough comments about that one that I decided to put it aside for now, > and get the other

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-03-05 Thread Stephen Frost
* Peter Eisentraut (pete...@gmx.net) wrote: > On 3/3/15 5:58 PM, Tom Lane wrote: > > One aspect of this that merits some thought is that in some cases > > access to some set of functions is best granted as a unit. That's > > easy with role properties but much less so with plain GRANT. > > Do we ha

Re: [HACKERS] CATUPDATE confusion?

2015-03-05 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Peter Eisentraut writes: > > Any other opinions? > > The options are: > > 0) Leave as is. > > 1) Remove catupdate and replace with superuser checks. > > 2) Remove catupdate and rely on regular table permissions on catalogs. > > I think I vote for (1). I d

Re: [HACKERS] contraints_exclusion fails to refute simple condition

2015-03-05 Thread Andrew Gierth
> "Sandro" == Sandro Santilli writes: Sandro> PostGIS installs standard constraints of this kind: Sandro> CHECK (geometrytype(g) = 'POINT'::text OR g IS NULL) If geometrytype() is strict, the IS NULL condition is superfluous. CHECK(x) _passes_ when x is null, rather than rejecting the r

Re: [HACKERS] Additional role attributes && superuser review

2015-03-05 Thread Stephen Frost
* Peter Eisentraut (pete...@gmx.net) wrote: > On 2/28/15 10:10 PM, Stephen Frost wrote: > > * Adam Brightwell (adam.brightw...@crunchydatasolutions.com) wrote: > >> I have attached and updated patch for review. > > > > Thanks! I've gone over this and made quite a few documentation and > > comment

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-03-05 Thread Stephen Frost
* Peter Eisentraut (pete...@gmx.net) wrote: > On 3/3/15 5:29 PM, Stephen Frost wrote: > > For my part, I understood that we specifically didn't want to allow that > > for the same reason that we didn't want to simply depend on the GRANT > > system for the above functions, but everyone else on these

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-03-05 Thread Sawada Masahiko
On Sat, Feb 28, 2015 at 2:27 PM, Stephen Frost wrote: > Sawada, > > * Sawada Masahiko (sawada.m...@gmail.com) wrote: >> Attached patch is latest version including following changes. >> - This view is available to super use only >> - Add sourceline coulmn > > Alright, first off, to Josh's point- I'

Re: [HACKERS] object description for FDW user mappings

2015-03-05 Thread Tom Lane
Alvaro Herrera writes: > When commit cae565e503 introduced FDW user mappings, it used this in > getObjectDescription for them: > appendStringInfo(&buffer, _("user mapping for %s"), usename); > This was later mostly copied (by yours truly) as object identity by > commit f8348ea32e wherein I

Re: [HACKERS] MD5 authentication needs help

2015-03-05 Thread Stephen Frost
* Bruce Momjian (br...@momjian.us) wrote: > On Wed, Mar 4, 2015 at 04:19:00PM -0500, Stephen Frost wrote: > > > Hm, well, "don't change the wireline protocol" could be another wanna-have > > > ... but if we want to stop using MD5, that's not really a realistic goal > > > is it? > > > > I'm trying

Re: [HACKERS] MD5 authentication needs help

2015-03-05 Thread Stephen Frost
* Bruce Momjian (br...@momjian.us) wrote: > One way to fix #2 would be to use a per-user or per-cluster counter for > the session salt, rather than a random number --- that would change > replays from ~16k to 4 billion, with no wire protocol change needed. I'm not against doing that if we decide t

Re: [HACKERS] MD5 authentication needs help

2015-03-05 Thread Stephen Frost
* Bruce Momjian (br...@momjian.us) wrote: > On Wed, Mar 4, 2015 at 05:56:25PM -0800, Josh Berkus wrote: > > So, are we more worried about attackers getting a copy of pg_authid, or > > sniffing the hash on the wire? > > Both. Stephen is more worried about pg_authid, but I am more worried > about

Re: [HACKERS] MD5 authentication needs help

2015-03-05 Thread Stephen Frost
* Josh Berkus (j...@agliodbs.com) wrote: > Catching up here ... > > On 03/03/2015 06:01 PM, Bruce Momjian wrote: > > It feels like MD5 has accumulated enough problems that we need to start > > looking for another way to store and pass passwords. The MD5 problems > > are: > > > > 1) MD5 makes us

Re: [HACKERS] File based Incremental backup v8

2015-03-05 Thread Robert Haas
On Wed, Mar 4, 2015 at 11:42 PM, Bruce Momjian wrote: > On Thu, Mar 5, 2015 at 01:25:13PM +0900, Fujii Masao wrote: >> >> Yeah, it might make the situation better than today. But I'm afraid that >> >> many users might get disappointed about that behavior of an incremental >> >> backup after the r

Re: [HACKERS] Combining Aggregates

2015-03-05 Thread Robert Haas
On Wed, Mar 4, 2015 at 11:00 PM, Kouhei Kaigai wrote: > Anyway, I could find out, at least, these complicated issues around > two-phase aggregate integration with planner. Someone can suggest > minimum invasive way for these integration? I don't think I have the brain space to think about that un

[HACKERS] object description for FDW user mappings

2015-03-05 Thread Alvaro Herrera
When commit cae565e503 introduced FDW user mappings, it used this in getObjectDescription for them: appendStringInfo(&buffer, _("user mapping for %s"), usename); This was later mostly copied (by yours truly) as object identity by commit f8348ea32e wherein I used this: appendString

Re: [HACKERS] Strange assertion using VACOPT_FREEZE in vacuum.c

2015-03-05 Thread Robert Haas
On Thu, Mar 5, 2015 at 9:58 AM, Alvaro Herrera wrote: > Robert Haas wrote: >> On Sun, Mar 1, 2015 at 6:58 AM, Michael Paquier >> wrote: >> > Hm, why not. That would remove all inconsistencies between the parser >> > and the autovacuum code path. Perhaps something like the attached >> > makes sens

Re: [HACKERS] Join push-down support for foreign tables

2015-03-05 Thread Shigeru Hanada
Here is the v5 patch of Join push-down support for foreign tables. Changes since v4: - Separete remote conditions into ON and WHERE, per Ashutosh. - Add regression test cases for foreign join. - Don't skip reversed relation combination in OUTER join cases. I'm now working on two issues from Kaig

Re: [HACKERS] Strange assertion using VACOPT_FREEZE in vacuum.c

2015-03-05 Thread Stephen Frost
Alvaro, * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > Robert Haas wrote: > > On Sun, Mar 1, 2015 at 6:58 AM, Michael Paquier > > wrote: > > > Hm, why not. That would remove all inconsistencies between the parser > > > and the autovacuum code path. Perhaps something like the attached > > >

Re: [HACKERS] Strange assertion using VACOPT_FREEZE in vacuum.c

2015-03-05 Thread Alvaro Herrera
Robert Haas wrote: > On Sun, Mar 1, 2015 at 6:58 AM, Michael Paquier > wrote: > > Hm, why not. That would remove all inconsistencies between the parser > > and the autovacuum code path. Perhaps something like the attached > > makes sense then? > > I really don't see this patch, or any of the prev

Re: [HACKERS] Providing catalog view to pg_hba.conf file - Patch submission

2015-03-05 Thread Greg Stark
On Wed, Mar 4, 2015 at 9:41 PM, Peter Eisentraut wrote: > everyone seems to have quite different uses for it. Greg wants to join > against other catalog tables, Jim wants to reassemble a valid and > accurate pg_hba.conf, Josh wants to write an editing tool. Personally, > I'd like to see somethin

Re: [HACKERS] anyarray

2015-03-05 Thread Andrew Dunstan
On 03/04/2015 10:28 PM, Tom Lane wrote: Peter Eisentraut writes: On 2/13/15 10:20 AM, Teodor Sigaev wrote: Some of users of intarray contrib module wish to use its features with another kind of arrays, not only for int4 type. Suggested module generalizes intarray over other (not all) types op

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2015-03-05 Thread Andres Freund
On 2015-03-05 12:14:04 +, Syed, Rahila wrote: > Please find attached a patch. As discussed, flag to denote > compression and presence of hole in block image has been added in > XLogRecordImageHeader rather than block header. FWIW, I personally won't commit it with things done that way. I thin

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2015-03-05 Thread Michael Paquier
On Thu, Mar 5, 2015 at 9:14 PM, Syed, Rahila wrote: > Please find attached a patch. As discussed, flag to denote compression and > presence of hole in block image has been added in XLogRecordImageHeader > rather than block header. > > Following are WAL numbers based on attached test script po

Re: [HACKERS] Join push-down support for foreign tables

2015-03-05 Thread Shigeru Hanada
Hi Ashutosh, thanks for the review. 2015-03-04 19:17 GMT+09:00 Ashutosh Bapat : > In create_foreignscan_path() we have lines like - > 1587 pathnode->path.param_info = get_baserel_parampathinfo(root, rel, > 1588 > required_outer); > Now, that the same function is being used for creating foreign

Re: [HACKERS] Providing catalog view to pg_hba.conf file - Patch submission

2015-03-05 Thread Pavel Stehule
2015-03-04 22:41 GMT+01:00 Peter Eisentraut : > On 3/3/15 7:17 PM, Jim Nasby wrote: > > I think we're screwed in that regard anyway, because of the special > > constructs. You'd need different logic to handle things like +role and > > sameuser. We might even end up painted in a corner where we can

[HACKERS] contraints_exclusion fails to refute simple condition

2015-03-05 Thread Sandro Santilli
PostGIS installs standard constraints of this kind: CHECK (geometrytype(g) = 'POINT'::text OR g IS NULL) The constraint is used by constraint_exclusion if using this condition: WHERE g IS NOT NULL AND geometrytype(g) = 'LINESTRING' But it is _NOT_ used if the NOT NULL condition is removed:

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2015-03-05 Thread Syed, Rahila
Hello, Please find attached a patch. As discussed, flag to denote compression and presence of hole in block image has been added in XLogRecordImageHeader rather than block header. Following are WAL numbers based on attached test script posted by Michael earlier in the thread.

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

2015-03-05 Thread Etsuro Fujita
On 2015/03/04 17:07, Etsuro Fujita wrote: On 2015/03/04 16:58, Albe Laurenz wrote: Etsuro Fujita wrote: While updating the patch, I noticed that in the previous patch, there is a bug in pushing down parameterized UPDATE/DELETE queries; generic plans for such queries fail with a can't-happen err

Re: [HACKERS] Table-level log_autovacuum_min_duration

2015-03-05 Thread Fujii Masao
On Thu, Feb 19, 2015 at 3:32 PM, Michael Paquier wrote: > On Thu, Feb 19, 2015 at 2:13 PM, Naoya Anzai > wrote: >> As a result, I think you should not delete VACOPT_VERBOSE. > > In v8 it is not deleted. It is still declared, and its use is isolated > in gram.y, similarly to VACOPT_FREEZE. > >> Ac

Re: [HACKERS] WALWriter active during recovery

2015-03-05 Thread Fujii Masao
On Thu, Dec 18, 2014 at 6:43 PM, Fujii Masao wrote: > On Tue, Dec 16, 2014 at 3:51 AM, Simon Riggs wrote: >> Currently, WALReceiver writes and fsyncs data it receives. Clearly, >> while we are waiting for an fsync we aren't doing any other useful >> work. >> >> Following patch starts WALWriter du

Re: [HACKERS] TABLESAMPLE patch

2015-03-05 Thread Amit Kapila
On Tue, Feb 17, 2015 at 3:29 AM, Petr Jelinek wrote: > > > I didn't add the whole page visibility caching as the tuple ids we get from sampling methods don't map well to the visibility info we get from heapgetpage (it maps to the values in the rs_vistuples array not to to its indexes). Commented a