On 27 February 2016 at 06:37, Michael Paquier
wrote:
> On Sat, Feb 27, 2016 at 4:30 AM, Alvaro Herrera
> wrote:
> > Craig Ringer wrote:
> >> Should be committed ASAP IMO.
> >
> > Finally pushed it. Let's see how it does in the buildfarm. Now let'
On 17 December 2015 at 10:08, Craig Ringer wrote:
> On 15 December 2015 at 20:17, Andres Freund wrote:
>>
>>
>> I think this is quite the wrong approach. You're calling the logical
>> decoding callback directly from decode.c, circumventing
>> reorderbuf
rly easily because I think we need this in 9.6
and the tests demonstrate that it works when run separately.
See for a git tree containing the timeline following patch, TAP
enhancements and the tests for timeline following.
https://github.com/2ndQuadrant/postgres/tree/dev/logical-decoding-timeli
tion. It also
provides a 'psql_check' that dies on error.
I'll incorporate the wanted changes into that patch.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
en it belongs in the
infrastructure.
Patches attached, each explains what it does and what for.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From 26fdff1b8f76f3c47d4e19be7c4aef3cdcd3393c Mon Sep 17 00:00:00 2001
From: Andre
On 1 March 2016 at 21:05, Craig Ringer wrote:
> On 1 March 2016 at 20:45, Michael Paquier
> wrote:
>
>> On Tue, Mar 1, 2016 at 5:13 PM, Kyotaro HORIGUCHI
>> wrote:
>> > 0001-Change-behavior-...
>> >
>> > Changes of PostmasterNode.pm and Tes
Here are the tests.
They depend on https://commitfest.postgresql.org/9/569/#
I've also rebased the git tree for failover slots on top of the tree for
TAP test improvements.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training &
27;s a nitpick, but it makes a 1-liner
patch into a lot more.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
On 1 March 2016 at 22:08, salvador fandino wrote:
>
>
> On Tue, Mar 1, 2016 at 2:48 PM, Craig Ringer
> wrote:
>
>>
>> Hi all
>>
>> I've been working with the new TAP tests for recovery and have a number
>> of enhancements I'd like to make t
On 2 March 2016 at 07:07, Alvaro Herrera wrote:
> Craig Ringer wrote:
>
> > diff --git a/src/test/perl/TestLib.pm b/src/test/perl/TestLib.pm
> > index 3d11cbb..8c13655 100644
> > --- a/src/test/perl/TestLib.pm
> > +++ b/src/test/perl/TestLib.pm
> > @@ -1
on top of a
perltidy'd version. I can bite the bullet and move the perltidy to the
start of the patch series then make sure each subsequent patch is tidy'd
but I'd want to be very sure you'd be OK to commit the perltidy of
PostgresNode.pm otherwise I'd have to rebase messily all over again...
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
h to keep an eye on manually. Ugh.
Why do we requite a 10yo Perl anyway?
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
On 2 March 2016 at 11:22, Craig Ringer wrote:
> 2016-03-02 6:57 GMT+08:00 Alvaro Herrera :
>
>> Just pushed 0006.
>>
>>
> This upset buildfarm members running prehistoric Perl versions because
> is_passing was added after 5.8.8.
>
> Fix attached.
>
On 2 March 2016 at 11:23, Craig Ringer wrote:
> Really, this time.
>
Really, really this time, the version in git that actually works, not a
format-patch'd version before I made a last fix. Sigh. I can't even blame
lack of coffee...
--
Craig Ringer
On 2 March 2016 at 10:07, Craig Ringer wrote:
> On 2 March 2016 at 05:46, Alvaro Herrera wrote:
>
>
>>
>> I think we should change the existing psql method to be what you propose
>> as psql_expert. I don't see any advantage in keeping the old one. Many
>&g
ugh to let caller know the failure when
> just one test has been found as not passing. See attached.
>
Thanks.
I'm setting up a container with Debian Wheezy, which looks old enough to
test proposed framework changes, so I'll be able to test future patches
against a real Perl 5.8.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
On 1 March 2016 at 05:30, Petr Jelinek wrote:
>
> On 29/02/16 03:23, Craig Ringer wrote:
>>
>>
> Sound reasonable?
>>
>
> I wonder if it would be acceptable to create new info flag for RM_SEQ_ID
> that would behave just like XLOG_SEQ_LOG but would be used onl
separate files, so it's self-contained.
Happy Perl 5.8'ing!
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Dockerfile
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postg
On 3 March 2016 at 11:06, Craig Ringer wrote:
> Hi all
>
> I've prepared a Dockerfile that produces a canned Perl 5.8.8 environment
> based on CentOS 5 on any host with Docker. It has ccache installed and
> enabled, git installed, IPC::Run installed, all the mess required
8.8 has 1.08. No
buildfarm member has complained, so clearly we don't actually test with the
stated supported Perl version.
The attached patch fixes it to use the legacy File::Path interface 'rmtree'
so master runs on 588 again.
--
Craig Ringer http://www.2n
On 3 March 2016 at 13:23, Michael Paquier wrote:
> On Thu, Mar 3, 2016 at 2:20 PM, Craig Ringer
> wrote:
> > On the Perl 5.8.8 test env I've set up now, per
> >
> >
> http://www.postgresql.org/message-id/camsr+ygr6pu-guyp-ft98xwxasc9n6j-awzaqxvw_+p3rtc...@mail.gm
On 3 March 2016 at 13:08, Craig Ringer wrote:
> On 3 March 2016 at 11:06, Craig Ringer wrote:
>
>> Hi all
>>
>> I've prepared a Dockerfile that produces a canned Perl 5.8.8 environment
>> based on CentOS 5 on any host with Docker. It has ccache installed and
On 3 March 2016 at 21:16, Michael Paquier wrote:
> On Thu, Mar 3, 2016 at 4:11 PM, Craig Ringer
> wrote:
> > The first three are simple fixes that should go in without fuss:
> >
> > 001 fixes the above 5.8.8 compat issue.
> > 002 fixes another minor whoopsie,
uest merging of a branch
you've published somewhere accessible.
Please explain what the change is and why it's needed in your ticket/email,
rather than just "please merge" etc.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
o push them too.
Great, thanks.
>
> > I don't expect to be doing much more on the framework at this point as I
> > want to be able to get back to the code I had to enhance the framework in
> > order to test
>
> How come!?!?
This yak grows hair faster than I c
ased failover slots in order to get the
timeline following for logical decoding patch committed separately to, and
prior to, failover slots. It's complicated enough that it needs a variety
of tests, but self-contained and non-intrusive enough to be a fairly easy
commit if it's shown to wor
evel copy, but that there are WAL retention
issues (unsurprisingly) when the backup is created without slots then the
slot state is synced over by an external client.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
On 4 March 2016 at 20:35, Craig Ringer wrote:
> Fix attached.
>
>
Apparently I need a "remind me if you see the word attach in an email"
plugin. Sigh.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Train
; was, attached is an updated patch).
>
>
If it's the result of perltidy changing its mind about the formatting as a
result of this change I guess we have to eyeroll and live with it. perltidy
leaves the file alone as it is in the tree currently, so that be it.
Gripe withdrawn, ready for committer IMO
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
On 1 March 2016 at 21:00, Craig Ringer wrote:
> Hi all
>
> Per discussion on the failover slots thread (
> https://commitfest.postgresql.org/9/488/) I'm splitting timeline
> following for logical slots into its own separate patch.
>
>
I've updated the logical decod
On 24 February 2016 at 18:02, Craig Ringer wrote:
> I really want to focus on the first patch, timeline following for logical
> slots. That part is much less invasive and is useful stand-alone. I'll move
> it to a separate CF entry and post it to a separate thread as I th
On 5 March 2016 at 00:10, Alvaro Herrera wrote:
> Craig Ringer wrote:
>
> > If it's the result of perltidy changing its mind about the formatting as
> a
> > result of this change I guess we have to eyeroll and live with it.
> perltidy
> > leaves the file alone
s
> it would be possible to compile the code on Windows using MSVC without
> having to install MSYS. I haven't done that in this patch, thoughts on
> the matter are welcome.
>
That's consistent with how we include the generated scanner and lexer files
etc in the source tarball, so +1.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
ations. It's not
unusual for me to be working on something and think "gee, I wish there was
a hook here".
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
g position on whether a DTM should be in core or not as
I haven't done enough work in the area. I do think it's interesting to
strongly require that a DTM be in core while we also reject things like
pooling that are needed by a large proportion of users.
--
Craig Ringer
how to even begin to tackle it. What you've
mentioned here is helpful and I'd be interested if you could share a bit
more of your experience in the area.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
#if
PG_VERSION_NUM around them if you use them.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
's what I want to prevent. Sharding that only-just-works and then stops
us getting anything better into core.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
at
not? Are there restrictions to what it can do in terms of access to
syscache/relcache/heap etc?
Why do you pass GetSessionUserId() to the hook given that the caller can
look it up directly? Just a convenience?
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
ng these two pages side by side:
http://www.postgresql.org/
https://www.mongodb.org/
... and tell me which you'd look over first if you were evaluating things.
> How can we attract software vendors to support PostgreSQL? What words are
> convincing to appeal the increasing potential of PostgreSQL as a good
> replacement for commercial databases?
>
Change the name :p
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
read some code...
There might be some wiggle room in terms of letting
> non-SERIALIZABLE transactions commit while the ordering of
> SERIALIZABLE transactions remain in doubt, but that would involve
> allowing bigger deviations from commit order in transaction
> application, which
y. Plugins can just talk straight to the DB, and are written by
people who have never heard of parametrized queries or, half the time,
transactions.
What makes it popular and successful is also what makes supporting Pg in a
way that'll actually see useful adoption hard.
--
Craig Ringer
-to-fix-it
systems I tend to favour doing it right myself. Which is why some of the
compromises currently necessary in the logical replication space on Pg irk
me so
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
On 7 March 2016 at 23:02, Robert Haas wrote:
> On Fri, Mar 4, 2016 at 11:17 PM, Craig Ringer
> wrote:
> > If FDW-based sharding works, I'm happy enough, I have no horse in this
> race.
> > If it doesn't work I don't much care either. What I'm worried abo
y the JDBC driver's requirements and anything else
that might be related.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
On 7 March 2016 at 20:55, MauMau wrote:
> From: Craig Ringer
> --
> We could help ORMs solve the N+1 SELECTs problem and help them avoid
> transferring vast join projections unnecessarily. That'd make PostgreSQL
> pretty compel
dea to add some tests to src/test/recovery
for parallel query on standby servers...
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
e that's not practical for all
apps, which is why supporting the int flag form better is desirable, and we
just have to figure out what exactly we should be returning...
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
and so long as
they're on the same session, haven't committed or rolled back, and haven't
run another statement. This would make working with big binary objects in
the DB considerably more practical.
I'm sure there are others I haven't remembered or run into in there too.
See https://wiki.postgresql.org/wiki/Todo#Wire_Protocol_Changes for some.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
to
move a patch from needs-review to ready-for-committer. I've done a chunk of
review for a number of patches, but I'm not always confident saying "all
clear, proceed".
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
urning 2000-01-01 I think that's a bug - it should
return null if timestamps aren't recorded. (We can't really differentiate
between the real timestamp 2000-01-01 00:00:00 and the case where we didn't
record a timestamp, but I don't think we care about tx's generate
On 9 March 2016 at 21:30, Robert Haas wrote:
> On Tue, Mar 8, 2016 at 8:12 PM, Craig Ringer
> wrote:
> > There certainly are server/protocol frustrations.
>
> I'm sympathetic to all of these and think we should work on fixing
> them, particularly..
On 10 March 2016 at 00:41, Igal @ Lucee.org wrote:
> On 3/8/2016 5:12 PM, Craig Ringer wrote:
>
>> One of the worst problems (IMO) is in the driver architecture its self.
>> It attempts to prevent blocking by guestimating the server's send buffer
>> state and its
On 10 March 2016 at 05:30, Alvaro Herrera wrote:
> Craig Ringer wrote:
>
> > 004 allows filtering on RecursiveCopy by a predicate function. Needed for
> > filesystem level backups (007). It could probably be squashed with 007 if
> > desired.
>
> I pu
long as we satisfy the
basic constraint that we should return a set of generated keys in the case
where a statement does an insert that adds rows to a table with a SERIAL
(or an owned SEQUENCE). Seems like we could do pretty much whatever we want
for multiple-generated-columns cases etc.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
ch
client driver to support replication protocol extensions.
Opinions?
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
s, this looks
interesting/handy". But usually just bug reports or complaints that
whatever you built isn't good enough to meet some random person's
particular use case. Ah well.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
e column names of the primary keys => ORMs
> should use "return specific column names" API, not just "return something
> generated".
>
Yep. There are many "should"s. I absolutely agree that this is one of them.
One reason some clients do it this way is t
you do a _peek_changes then a _confirm when you know you've flushed them,
prior to the next peek.
I think the docs for pg_replication_slots are wrong about the confirm
location btw, it says data from before the confirm location can't be
replayed, but it can over the walsender protocol. There's just no way to
ask for it over the SQL interface.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
On 11 March 2016 at 20:15, Alvaro Herrera wrote:
> Craig Ringer wrote:
> > Hi all
> >
> > I think I found a couple of logical decoding issues while writing tests
> for
> > failover slots.
> >
> > Despite the docs' claim that a logical slo
lsn you expect to start at, but it's ugly.
Ugh.
I didn't realise pg_logical_slot_get_changes could backtrack by setting an
upto_lsn in the past. That doesn't seem like something we should really be
doing - if it's a limit, and we're already past that limit,
On 15 March 2016 at 07:10, Alvaro Herrera wrote:
> Petr Jelinek wrote:
> > On 04/03/16 17:08, Craig Ringer wrote:
> > >I'd really appreciate some review of the logic there by people who know
> > >timelines well and preferably know the xlogreader. It's
On 15 March 2016 at 04:48, Andres Freund wrote:
> On 2016-01-31 05:09:33 +0800, Craig Ringer wrote:
> > On 29 January 2016 at 18:16, Andres Freund wrote:
> >
> > > Hi,
> > >
> > > so, I'm reviewing the output of:
> > >
> >
> >
On 11 March 2016 at 22:24, Petr Jelinek wrote:
> On 02/03/16 08:05, Craig Ringer wrote:
>
>> On 1 March 2016 at 05:30, Petr Jelinek > <mailto:p...@2ndquadrant.com>> wrote:
>>
>
>
>>
>> I wonder if it would be acceptable to create new info
ues ('1'::integer);
^
HINT: You will need to rewrite or cast the expression.
At the time PostgreSQL parses the statement it doesn't know the parameter
values yet, because PgJDBC hasn't sent them to it. It cannot log them even
if they mattered, which they don't.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
BC.
Really, the problem is your code: you should setBool not setInteger here.
That's really all there is too it.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
t are
kept so there's some test coverage for timeline following in logical slots.
I wrote it as a PoC to show that it worked, and the best way to do that was
to write it as a new test suite component. Since it seemed useful to test
logical decoding timeline following for a slot created after a ba
ual changes are more
logically grouped and clearer. I expect it'd be mostly or entirely squashed
for commit.
From 256d43f4c8195c893efeb0319d7642853d15f3a9 Mon Sep 17 00:00:00 2001
From: Craig Ringer
Date: Tue, 23 Feb 2016 15:59:37 +0800
Subject: [PATCH 1/7] Allow replication slots to fo
ommunity.
>
I still remember them being very non-obvious, so I agree.
> Because I'm still going through the learning curve, I'm probably the least
> qualified to write the actual documentation.
>
You're *extremely* qualified to make notes of what's hard, though, which is
something people who've worked on the codebase for a while tend to forget.
I've been trying to write little bits of docs as I go and as I learn.
Going to write one on how timelines work soon.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Also attached is another patch to amend the docs to reflect the fact that a
slot can actually replay the same change more than once. I avoided the
strong temptation to update other parts of the docs nearby.
Both these are fixes that should IMO be applied to 9.6.
--
Craig Ringer
On 15 March 2016 at 21:40, Craig Ringer wrote:
> Here's a new failover slots rev, addressing the issues Oleksii Kliukin
> raised and adding a bunch of TAP tests.
>
Ahem, just found an issue here. I'll need to send another revision.
--
Craig Ringer http://
eries to the WAL using a hook and replicates this
> queries at subscribers.
>
Would you mind sharing the plugin here? I could add it to src/test/modules
and add some t/ tests so it runs under the TAP test framework.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
The first patch was incorrectly created on top of failover slots not HEAD.
Attached patch applies on HEAD.
From 87d839f8a2e78abb17fa985502fd5b66f0872b57 Mon Sep 17 00:00:00 2001
From: Craig Ringer
Date: Wed, 16 Mar 2016 15:45:16 +0800
Subject: [PATCH 1/2] Correct incorrect claim that slots output
ith both xlc and gcc
builds.
http://buildfarm.postgresql.org/cgi-bin/show_members.pl
If you're looking for help with that then I suggest posting to
pgsql-general rather than -hackers.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
On 10 March 2016 at 09:53, Craig Ringer wrote:
>
> Thanks for pushing.
>
I found a minor issue with the new psql method while writing tests for
failover slots. Patch attached.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support,
On 18 March 2016 at 20:36, Artur Zakirov wrote:
> On 17.03.2016 15:42, Craig Ringer wrote:
>
>>
>>
>> Would you mind sharing the plugin here? I could add it to
>> src/test/modules and add some t/ tests so it runs under the TAP test
>> framework.
>
; 5. Now try to start the services, the second service fails with the
> >> error message.
> >> 6. Error details can be found out in Event log viewer.
>
Can you get a Process Monitor trace of startup and check exactly where it's
getting access denied, doing what?
You may hav
lots is less than 10. For
> multimaster this assumption is true - even Oracle RAC rarely has two-digit
> number of nodes.
> But if we want to perform sharding and use logical replication for
> providing redundancy, then number of nodes and slots can be essentially
> larger.
>
Sou
et by the addition of new label file entries. Everything we
found used regexps to find what they wanted and didn't care in the
slightest about new lines. So I wouldn't worry too much.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
On 22 March 2016 at 19:48, Andres Freund wrote:
> On 2016-03-15 21:04:12 +0800, Craig Ringer wrote:
> > Thanks very much for the review.
>
> Are you planning to update the patch?
>
Yes. I just spoke to Álvaro earlier. I'll pick up his modified version of
my patch, remov
tive of xlog decoding and logical
replication. It's not really the right place so I'd be happier pointing to
a comment somewhere appropriately placed instead. Same with xlog records.
The rest is pretty specific to the area of interest.
--
Craig Ringer http://www.2ndQu
On 22 March 2016 at 19:48, Andres Freund wrote:
> On 2016-03-15 21:04:12 +0800, Craig Ringer wrote:
> > Thanks very much for the review.
>
> Are you planning to update the patch?
>
>
Updated patch attached.
It removes the questionable cleanups, fixes the randAccess commen
of 2PC we should send it to callbacks anyway. So I’ve added that info to
> abort records.
>
I was wondering what that was. Again, seems sensible, though I'm not
totally convinced of the naming.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
he server with endless copies of the same PREPARE statements would
be good.
BTW, PgJDBC doesn't use SQL-level PREPARE anyway, it does it with named
portals at the protocol level. You can't add IF NOT EXISTS there, at least
not the same way.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
On 23 March 2016 at 23:54, Alvaro Herrera wrote:
> Craig Ringer wrote:
> > Hi all
> >
> > As part of some internal training/discussion I wrote some notes on
> logical
> > decoding's structure and flow that seemed worth polishing up into a draft
> > R
ustrating issue with client-side upsert retry
loop approaches. Less of a concern now that 9.5 has a true upsert, but
that's not the only area where the client is expected to try it and handle
the error if it fails.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
protocol version
bump. The current protocol is too inflexible and doesn't have any kind of
capabilities negotiation. I don't think any of those options can work.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
f it won't
understand that could land up breaking it.
Right now we've really got no way to add additional data to query
responses, commandcomplete, etc, because we've got no way to make sure the
client can cope with it being there.
See also https://wiki.postgresql.org/wiki/Todo#Wire_
e ... add column ... default not null) and things that
don't (alter table ... drop column ; alter table ... add column ...;
without not null or default).
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
On 15 March 2016 at 04:48, Andres Freund wrote:
> On 2016-01-31 05:09:33 +0800, Craig Ringer wrote:
> > On 29 January 2016 at 18:16, Andres Freund wrote:
> >
> > > Hi,
> > >
> > > so, I'm reviewing the output of:
> > >
> >
> >
, I tried to address your comments as best I could. The main one that
I think stayed open was about the loop that finds the last timeline on a
segment. If you think that's better done by directly scanning the List* of
timeline history entries I'm happy to prep a follow-up.
--
Cra
(buf->record);
> + RepOriginId origin_id = XLogRecGetOrigin(buf->record);
> int i;
>
Even though it's trivial, created as
https://commitfest.postgresql.org/10/594/ so we don't lose it.
--
Craig Ringer http://www.2nd
and targetPagePtr could be declared
>> inside directly the new while loop.
>>
>
> Thanks Michael for reviewing the patch. I've fixed these issues and new
> version is attached.
>
>
Can you describe the process used to generate the sample WAL segment?
I'd like
n't beautiful, to be sure, but is a burden carried mainly by those who
care about Windows support. If we eventually get a CMake build system
conversion that'll mostly go away too.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
and targetPagePtr could be declared
>> inside directly the new while loop.
>>
>
> Thanks Michael for reviewing the patch. I've fixed these issues and new
> version is attached.
>
Looks sensible to me based on a reading of "git diff -w" of the applied
patch. It pa
On 17 January 2016 at 14:46, leo wrote:
> I also run into same problem and waiting for bug fix.
> please update if new patch has published.
>
>
There's a point release coming soon that'll incorporate these fixes and a
number of others. It'll be posted here in a fe
kind of like tgisinternal and 'i' dependencies, but without the
restriction on the object being dropped directly?
Is there any particular reason the user needs to be able to drop the
created trigger directly?
Is it reasonable to endorse the use of 'i' dependencies by
g.
Nothing seems to spring out on https://searchcode.com either.
It seems quite reasonable to leave such an esoteric corner as "fix it if
somebody screams" territory for a point release.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
is that the commit of the pg_am rework greatly eases the path
of this patch into core.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Needs rework after the commit of https://commitfest.postgresql.org/8/336/
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
1 - 100 of 2076 matches
Mail list logo
