Hello Adar Dembo, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3234
to review the following change.
Change subject: log: Mark allocation finished even if allocation had an error
.
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3134
to look at the new patch set (#2).
Change subject: Make BuildLog() return Status
..
Make B
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3135
to look at the new patch set (#2).
Change subject: Allow for reserving disk space for non-Kudu processes
..
Mike Percy has posted comments on this change.
Change subject: log: Mark allocation finished even if allocation had an error
..
Patch Set 1: Verified+1
Overriding flaky python test
kudu.tests.test_scanner.TestScanner.test_scan
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3235
Change subject: Don't use InMemoryEnv in deltafile-test
..
Don't use InMemoryEnv in deltafile-test
Get out the vote: #NeverMemEnv.
This is
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3135
to look at the new patch set (#3).
Change subject: Allow for reserving disk space for non-Kudu processes
..
Allow f
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3135
to look at the new patch set (#4).
Change subject: Allow for reserving disk space for non-Kudu processes
..
Allow f
Mike Percy has submitted this change and it was merged.
Change subject: Disable tracing for tablet bootstrap during remote bootstrap
..
Disable tracing for tablet bootstrap during remote bootstrap
The StartRemoteBootstrap RPC c
Mike Percy has posted comments on this change.
Change subject: Disable tracing for tablet bootstrap during remote bootstrap
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3236
To unsubscribe, v
Mike Percy has posted comments on this change.
Change subject: Add support for anchors.js to get permalinks on all headers
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/2739
To unsubscribe, visit
Mike Percy has posted comments on this change.
Change subject: Add support for anchors.js to get permalinks on all headers
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/2739
To unsubscribe, vi
Mike Percy has submitted this change and it was merged.
Change subject: Add support for anchors.js to get permalinks on all headers
..
Add support for anchors.js to get permalinks on all headers
Change-Id: I17bb50f412d8214f91fc
Mike Percy has submitted this change and it was merged.
Change subject: Make BuildLog() return Status
..
Make BuildLog() return Status
This allows for writing a reasonable test related to du.reserved
Change-Id: Icfa8ddba74b909
Mike Percy has posted comments on this change.
Change subject: Allow for reserving disk space for non-Kudu processes
..
Patch Set 4:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/3135/4//COMMIT_MSG
Commit Message:
Line 13:
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3235
to look at the new patch set (#2).
Change subject: Don't use InMemoryEnv in deltafile-test
..
Don't use InMemoryEnv
Mike Percy has uploaded a new patch set (#2).
Change subject: log: Mark allocation finished even if allocation had an error
..
log: Mark allocation finished even if allocation had an error
The problem this patch fixes is that if
Mike Percy has posted comments on this change.
Change subject: Don't use InMemoryEnv in deltafile-test
..
Patch Set 1:
(1 comment)
> Sure. I never cared much for MemEnv; more hassle than good, I
> think.
Agreed
> The test
Mike Percy has posted comments on this change.
Change subject: log: Mark allocation finished even if allocation had an error
..
Patch Set 1:
(3 comments)
I'll try to add an isolated test for this
http://gerrit.cloudera.org:80
Mike Percy has submitted this change and it was merged.
Change subject: Don't use InMemoryEnv in deltafile-test
..
Don't use InMemoryEnv in deltafile-test
Get out the vote: #NeverMemEnv.
This is causing problems due to Status:
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3258
to review the following change.
Change subject: Remove InMemoryEnv completely
..
Remove InMemoryEnv completely
Every t
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3257
to review the following change.
Change subject: Remove last two usages of MemEnv in tests
..
Remove last two usages of
Mike Percy has posted comments on this change.
Change subject: Remove InMemoryEnv completely
..
Patch Set 1:
There are no mentions of MemEnv or InMemoryEnv anywhere else in the code base
that I could find.
For the EnvWrapper,
Mike Percy has posted comments on this change.
Change subject: Remove InMemoryEnv completely
..
Patch Set 1:
Ah, should've used git grep.
--
To view, visit http://gerrit.cloudera.org:8080/3258
To unsubscribe, visit http://ger
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3258
to look at the new patch set (#2).
Change subject: Remove InMemoryEnv completely
..
Remove InMemoryEnv completely
Mike Percy has submitted this change and it was merged.
Change subject: Fix license issues
..
Fix license issues
Change-Id: Id23c13f3bb0b5f2b8dd21af5decf061c9ee825a4
Reviewed-on: http://gerrit.cloudera.org:8080/3254
Reviewed-by
Mike Percy has posted comments on this change.
Change subject: Fix license issues
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3254
To unsubscribe, visit http://gerrit.cloudera.org:8080/setti
Mike Percy has posted comments on this change.
Change subject: Remove InMemoryEnv completely
..
Patch Set 2: Verified+1
Overriding unrelated flaky test
--
To view, visit http://gerrit.cloudera.org:8080/3258
To unsubscribe, vi
Mike Percy has submitted this change and it was merged.
Change subject: Remove InMemoryEnv completely
..
Remove InMemoryEnv completely
Every time we extend the Env interface we need to create a mock
implementation for MemEnv. M
Mike Percy has submitted this change and it was merged.
Change subject: Remove last two usages of MemEnv in tests
..
Remove last two usages of MemEnv in tests
TestEnv.TestReadFully still only takes about 6ms to execute.
TestPBU
Mike Percy has abandoned this change.
Change subject: KUDU-1262. Fix WritableFile::PreAllocate() on MemEnv
..
Abandoned
MemEnv has been removed
--
To view, visit http://gerrit.cloudera.org:8080/1439
To unsubscribe, visit http
Mike Percy has posted comments on this change.
Change subject: Replace boost::{lock, unique_lock, mutex} with std lib
equivalents
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3262/3/src/kudu/benchmarks/tpc
Mike Percy has posted comments on this change.
Change subject: Replace boost::{lock, unique_lock, mutex} with std lib
equivalents
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3262
To unsubsc
Mike Percy has posted comments on this change.
Change subject: Replace kudu::{lock_guard, unique_lock} with std lib equivalents
..
Patch Set 7: Code-Review+2
On second thought, I agree with Adar that it looks cleaner without th
Mike Percy has posted comments on this change.
Change subject: Replace kudu::{lock_guard, unique_lock} with std lib equivalents
..
Patch Set 7:
Although I'm not overriding Adar's concern, he should chime back in.
--
To view,
Mike Percy has posted comments on this change.
Change subject: Replace kudu::{lock_guard, unique_lock} with std lib equivalents
..
Patch Set 7:
Er, I mean using std::lock_guard
--
To view, visit http://gerrit.cloudera.org:808
Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3279
to review the following change.
Change subject: Improve tpch usability
..
Improve tpch usability
* tpch.sh sho
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3280
Change subject: Improve tpch usability
..
Improve tpch usability
* tpch.sh should use $ROOT to find the CPU scaling script (I had a
probl
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3281
Change subject: Fix reorder warning in TabletMetadata
..
Fix reorder warning in TabletMetadata
Fix the following warning:
In file included
Mike Percy has posted comments on this change.
Change subject: Improve tpch usability
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3279/1/src/kudu/scripts/tpch.sh
File src/kudu/scripts/tpch.sh:
Line 70: $
Mike Percy has posted comments on this change.
Change subject: Improve tpch usability
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3279/1/src/kudu/scripts/tpch.sh
File src/kudu/scripts/tpch.sh:
Line 70: $
Mike Percy has abandoned this change.
Change subject: Improve tpch usability
..
Abandoned
accidental dup review
--
To view, visit http://gerrit.cloudera.org:8080/3280
To unsubscribe, visit http://gerrit.cloudera.org:8080/sett
Mike Percy has uploaded a new patch set (#2).
Change subject: Improve tpch usability
..
Improve tpch usability
* tpch.sh should use $ROOT to find the CPU scaling script (I had a
problem with it otherwise)
* tpch1.cc should pri
Mike Percy has posted comments on this change.
Change subject: Improve tpch usability
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3279/1/src/kudu/scripts/tpch.sh
File src/kudu/scripts/tpch.sh:
Line 70: $
Mike Percy has posted comments on this change.
Change subject: Improve tpch usability
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3279/2/src/kudu/scripts/tpch.sh
File src/kudu/scripts/tpch.sh:
Line 129: $
Mike Percy has posted comments on this change.
Change subject: Add weekly update for 06/06
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3316/5/_posts/2016-06-06-weekly-update.md
File _posts/2016-06-06-weekly
Mike Percy has posted comments on this change.
Change subject: Improve tpch usability
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3279
To unsubscribe, visit http://gerrit.cloudera.org:8080/sett
Mike Percy has posted comments on this change.
Change subject: Improve tpch usability
..
Patch Set 3:
Overriding Jenkins due to flaky test
--
To view, visit http://gerrit.cloudera.org:8080/3279
To unsubscribe, visit http://ge
Mike Percy has submitted this change and it was merged.
Change subject: Improve tpch usability
..
Improve tpch usability
* tpch.sh should use $ROOT to find the CPU scaling script (I had a
problem with it otherwise)
* tpch1.cc
Hello David Ribeiro Alves,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3350
to review the following change.
Change subject: Remove the LocalConsensus implementation
..
Remove the LocalCo
Hello David Ribeiro Alves,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3346
to review the following change.
Change subject: Use RaftConsensus instead of LocalConsensus in tests
..
Use Ra
Hello David Ribeiro Alves,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3347
to review the following change.
Change subject: Convert alter_table-test to use RaftConsensus
..
Convert alter
Hello David Ribeiro Alves,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3349
to review the following change.
Change subject: Always write last_known_addr into ConsensusMetadata
..
Always
Hello David Ribeiro Alves,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3348
to review the following change.
Change subject: Prepare some tests for RaftConsensus
..
Prepare some tests for
Hello David Ribeiro Alves,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3345
to review the following change.
Change subject: Add WaitUntilLeader() to Consensus interface
..
Add WaitUntilL
Hello David Ribeiro Alves,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3344
to review the following change.
Change subject: RaftConsensus: Trigger election at startup if single node
..
R
Mike Percy has posted comments on this change.
Change subject: Always write last_known_addr into ConsensusMetadata
..
Patch Set 1:
I'm actually not quite sure about this solution. It works for now but it may
not work well for
Mike Percy has posted comments on this change.
Change subject: KUDU-1353: remove per-tablet replica locations cache
..
Patch Set 11: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/2887
To unsubscribe, visit ht
Mike Percy has submitted this change and it was merged.
Change subject: KUDU-1353: remove per-tablet replica locations cache
..
KUDU-1353: remove per-tablet replica locations cache
This is the simpler alternative to rebuilding
Mike Percy has posted comments on this change.
Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager
..
Patch Set 6:
(1 comment)
I wish there was an easier way to hide the data object so that we can only
acc
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3344
to look at the new patch set (#2).
Change subject: RaftConsensus: Trigger election at startup if single node
..
Raf
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3350
to look at the new patch set (#2).
Change subject: Remove the LocalConsensus implementation
..
Remove the LocalCons
Mike Percy has posted comments on this change.
Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3309
To unsubscribe, visit
Mike Percy has posted comments on this change.
Change subject: Do not run (g)addr2line translator on MacOS X
..
Patch Set 1: Code-Review+1
lgtm but Dan should take a look too, since he develops on a Mac
--
To view, visit http
Mike Percy has posted comments on this change.
Change subject: KUDU-1469. Fix handling of fully-deduped requests after a
leader change
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3228/4/src/kudu/consensus/
Mike Percy has abandoned this change.
Change subject: Always write last_known_addr into ConsensusMetadata
..
Abandoned
abandoning this one
--
To view, visit http://gerrit.cloudera.org:8080/3349
To unsubscribe, visit http://ge
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3350
to look at the new patch set (#3).
Change subject: Remove the LocalConsensus implementation
..
Remove the LocalCons
Mike Percy has abandoned this change.
Change subject: Convert alter_table-test to use RaftConsensus
..
Abandoned
squashing this. hard to do it separate
--
To view, visit http://gerrit.cloudera.org:8080/3347
To unsubscribe, vi
Mike Percy has abandoned this change.
Change subject: Prepare some tests for RaftConsensus
..
Abandoned
squashing this one. hard to do it separate
--
To view, visit http://gerrit.cloudera.org:8080/3348
To unsubscribe, visit h
Mike Percy has posted comments on this change.
Change subject: Use RaftConsensus instead of LocalConsensus in tests
..
Patch Set 2: Verified+1
Overriding Jenkins due to super flaky Java test
org.kududb.client.TestAsyncKuduClie
Mike Percy has posted comments on this change.
Change subject: RaftConsensus: Trigger election at startup if single node
..
Patch Set 2: Verified+1
Overriding Jenkins due to super flaky Java test
org.kududb.client.TestAsyncKud
Mike Percy has posted comments on this change.
Change subject: Add WaitUntilLeader() to Consensus interface
..
Patch Set 2: Verified+1
Overriding Jenkins due to super flaky Java test
org.kududb.client.TestAsyncKuduClient.testD
Mike Percy has posted comments on this change.
Change subject: Blog post for 0.9.0 release
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3357/2/_posts/2016-06-10-apache-kudu-0-9-0-released.md
File _posts/2016
Mike Percy has posted comments on this change.
Change subject: Add 0.9.0 release and refresh docs
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3355
To unsubscribe, visit http://gerrit.clouder
Mike Percy has posted comments on this change.
Change subject: Remove the LocalConsensus implementation
..
Patch Set 3: Verified+1
Mas escamadura de org.kududb.client.TestAsyncKuduClient.testDisconnect()
--
To view, visit htt
Mike Percy has posted comments on this change.
Change subject: Add WaitUntilLeader() to Consensus interface
..
Patch Set 2:
It's used in the following patch. Maybe I should just squash it.
--
To view, visit http://gerrit.clou
Mike Percy has posted comments on this change.
Change subject: RaftConsensus: Trigger election at startup if single node
..
Patch Set 2:
> (1 comment)
>
> can you add a test for this? something simple like setting the
> ele
Mike Percy has posted comments on this change.
Change subject: Remove the LocalConsensus implementation
..
Patch Set 3:
> general wondering. Should we just kill the consensus.h interface
> and refactor RaftConsensus->Consensus
Mike Percy has abandoned this change.
Change subject: Add WaitUntilLeader() to Consensus interface
..
Abandoned
Squashing this into the following commit.
--
To view, visit http://gerrit.cloudera.org:8080/3345
To unsubscribe,
Mike Percy has posted comments on this change.
Change subject: RaftConsensus: Trigger election at startup if single node
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3344/2/src/kudu/consensus/raft_consensus.
Mike Percy has posted comments on this change.
Change subject: Remove the LocalConsensus implementation
..
Patch Set 3:
OK, still let's do it a bit later.
--
To view, visit http://gerrit.cloudera.org:8080/3350
To unsubscribe,
Mike Percy has uploaded a new patch set (#4).
Change subject: Remove the LocalConsensus implementation
..
Remove the LocalConsensus implementation
This implementation was intended as scaffolding while we built a true
consensus i
Mike Percy has uploaded a new patch set (#3).
Change subject: RaftConsensus: Trigger election at startup if single node
..
RaftConsensus: Trigger election at startup if single node
If a tablet's replication factor is 1 then don'
Mike Percy has uploaded a new patch set (#3).
Change subject: Use RaftConsensus instead of LocalConsensus in tests
..
Use RaftConsensus instead of LocalConsensus in tests
This paves the way to remove the LocalConsensus implement
Mike Percy has uploaded a new patch set (#4).
Change subject: RaftConsensus: Trigger election at startup if single node
..
RaftConsensus: Trigger election at startup if single node
If a tablet's replication factor is 1 then don'
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3368
Change subject: create-demo-table must specify parition columns
..
create-demo-table must specify parition columns
This is a recent API cha
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3367
Change subject: Fix variable name typo in ITBLL
..
Fix variable name typo in ITBLL
Change-Id: I606d0e2eb931fb355d58cb43ef7f0e471371326e
---
Mike Percy has uploaded a new patch set (#2).
Change subject: create-demo-table must specify partition columns
..
create-demo-table must specify partition columns
This is a recent API change that didn't make it into this dev too
Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3380
to review the following change.
Change subject: ITBLL: Specify all possible columns to partition on
..
ITBLL: S
Mike Percy has posted comments on this change.
Change subject: RaftConsensus: Trigger election at startup if single node
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3344/4/src/kudu/consensus/raft_consensus
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3344
to look at the new patch set (#5).
Change subject: RaftConsensus: Trigger election at startup if single node
..
Raf
Mike Percy has posted comments on this change.
Change subject: docs: informal design for handling permanent master failures
..
Patch Set 1:
(15 comments)
This is sounding more formal, let's just call it a real design doc :)
I
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3394
to review the following change.
Change subject: Link to raft config change design from design-docs index page
..
Link t
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3395
to review the following change.
Change subject: Add Raft remote bootstrap design doc
..
Add Raft remote bootstrap desig
Mike Percy has uploaded a new patch set (#2).
Change subject: Add Raft remote bootstrap design doc
..
Add Raft remote bootstrap design doc
This was ported over from a Google doc
Change-Id: I3551e8fcd19628cfbeb25f822a403155f8ba2
Mike Percy has posted comments on this change.
Change subject: Add Raft remote bootstrap design doc
..
Patch Set 2:
See the rendered page at
https://github.com/mpercy/kudu/blob/consensus-docs-3/docs/design-docs/raft-remote-boo
Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3396
to review the following change.
Change subject: Add more helpful CHECK message at master startup
..
Add more he
Mike Percy has submitted this change and it was merged.
Change subject: RaftConsensus: Trigger election at startup if single node
..
RaftConsensus: Trigger election at startup if single node
If a tablet's replication factor is
Mike Percy has posted comments on this change.
Change subject: RaftConsensus: Trigger election at startup if single node
..
Patch Set 5: Verified+1
Overriding Jenkins, which is currently broken
--
To view, visit http://gerrit
Mike Percy has posted comments on this change.
Change subject: Add more helpful CHECK message at master startup
..
Patch Set 1:
Jenkins in borken so +1ing myself
--
To view, visit http://gerrit.cloudera.org:8080/3396
To unsub
Mike Percy has submitted this change and it was merged.
Change subject: Add more helpful CHECK message at master startup
..
Add more helpful CHECK message at master startup
Maybe this could help debug KUDU-1488 a little bit
Ch
1 - 100 of 297 matches
Mail list logo