Re: Review Request 35542: GEODE-51 - Hostname for clients property for cache servers

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35542/#review88417
---



gemfire-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java 
(line 1441)
https://reviews.apache.org/r/35542/#comment140925

Need to add this to helpMap. The other newer arguments that were added for 
cluster config also need to be added to helpMap. The LocatorLauncher is 
probably similarly effected (newer arguments missing from the helpMap).


- Kirk Lund


On June 16, 2015, 11:18 p.m., William Markito wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/35542/
 ---
 
 (Updated June 16, 2015, 11:18 p.m.)
 
 
 Review request for geode, Darrel Schneider and Kirk Lund.
 
 
 Bugs: GEODE-51
 https://issues.apache.org/jira/browse/GEODE-51
 
 
 Repository: geode
 
 
 Description
 ---
 
 hostname-for-clients property was being ignored by server startup, preventing 
 external clients to connect to the cache servers after connecting to the 
 locator.
 
 
 Diffs
 -
 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java
  d5db59d 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java
  68b2483 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherJUnitTest.java
  5af33e1 
 
 Diff: https://reviews.apache.org/r/35542/diff/
 
 
 Testing
 ---
 
 Passed all JUnit tests.
 Manual verification using Docker-composer example.
 JMX MBean values are OK.
 
 
 Thanks,
 
 William Markito
 

Re: geode contribution process proposal

[Kirk Lund]

+1

Welcome Jun!

On Friday, June 12, 2015, jun aoki ja...@apache.org wrote:

 Hi Geode community

 My name is Jun Aoki and I work for Pivotal's Ambari project, and am super
 excited to contribute to Geode!

 I'd like to propose a few things about contribution process.

 The Geode community should have a clear cut process to open up to anybody
 who are interested in contributing to Geode.
 e.g. Apache Ambari community has adopted a contribution process
 https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute
 Ambari's workflow

 https://docs.google.com/document/d/1hz7qjGKkNeckMibEs67ZmAa2kxjie0zkG6H_IiC2RgA/edit



 I am listing a few tasks that can be Jira tickets of Geode.
 - test-patch CI job to make sure submitted patches to Geode jira has
 minimum quality (Apache RAT pass, being able to compile, unit test added,
 etc)
 - commit CI job to make sure master branch passes the unit test upon patch
 commits.
 - Geode build environment within Docker to enable anybody and any OS and
 any environment can build Geode as long as there is Docker.

 e.g. jobs serve for ambari
 https://builds.apache.org/view/A-D/view/Ambari/


 Please let me know if my proposals are good for the Geode community, then I
 will make tickets and will work on them.

 - jun

Re: geode contribution process proposal

[Kirk Lund]

Hi Jun,

Here's some info on Geode tests.

1) junit

These are unit tests involving mocks as well as end-to-end functional
tests. These are currently marked with @Category(UnitTest.class) or
@Category(IntegrationTest.class).

We need to encourage Geode developers to write a lot of more of the
UnitTest category tests. There's really not enough of these at this point
in time. There needs to be a strong commitment to writing these unit tests
and refactoring older code to make it easier or even possible for certain
classes.

2) dunit

The majority of developer tests are dunit tests which extend
DistributedTestCase. These create and manipulate 6 JVMs. Think of these as
end-to-end functional tests for a cluster. Unfortunately it take hours to
execute them all and there are some reliability issues in these tests. I'm
working on replacing DistributedTestCase with a custom junit runner so that
the syntax of these tests can be updated to using JUnit 4 annotations and
rules.

3) hydra

These are bigger QA-developed tests that run longer and may use many more
JVMs than a dunit. Moving hydra and these tests into Geode is further down
the road after moving the rest of the dunit tests.


On Mon, Jun 15, 2015 at 4:00 PM, jun aoki ja...@apache.org wrote:

 Hi Dan,

 Unit testing is super important for open source projects, so I'm glad some
 high quality testing is coming in to the project!

 Along with Roman's comment, it will be nice those tests ;
 1. are unit level test where mocks are appropriately used and no running
 instances are required. (IMO, unit test should be lightweight, and more
 heavy integration tests should be done separately)
 2. completes up to 30mins so that contributors can get a quicker feedback.
 (we are hoping to get hundreds of contributors so be aware of this! :) )

 As Roman suggested, should the unit test of GEODE-6 have basic acceptance
 tests (can be subset of the several-hour test set) and the open source CI
 should only tests the subset coverage?


 On Mon, Jun 15, 2015 at 10:07 AM, Roman Shaposhnik ro...@shaposhnik.org
 wrote:

  On Mon, Jun 15, 2015 at 9:42 AM, Dan Smith dsm...@pivotal.io wrote:
   Welcome Jun!
  
   I like all of your suggestions! One thing to be aware of regarding the
 CI
   jobs is that the test time is going to go up a lot once GEODE-6 is
   resolved. We'll be adding several hours of tests. That will make
 having a
   test patch CI job all that more valuable, but it also affects how much
   resources need to be devoted to that.
 
  Does it just mean that we'd have to have a 'smoke test' testsuite?
 
  Thanks,
  Roman.
 



 --
 -jun

Re: Review Request 34814: GEODE-38. Gfsh init script ignored

[Kirk Lund]

1) System Rules for JUnit 4
I really like System Rules for JUnit 4. This library has been added to our
build on GitLabs develop but not in ASF git yet
http://stefanbirkner.github.io/system-rules/. This line resets all System
Properties changes you make in your tests:

  @Rule
  public final RestoreSystemProperties restoreSystemProperties = new
RestoreSystemProperties();

I think you could add it to open/build.gradle in ASF git if you want to use
these Rules before our next code merge (just add one line above the junit
4.11 dependency line):

testCompile 'com.github.stefanbirkner:system-rules:1.9.0'
testCompile 'junit:junit:4.11'

Or obviously you can write an @After/@AfterClass method to reset any System
Properties you set.

2) Unit test class names
I think our gradle test target requires the tests to be named *JUnitTest
for now: GfshConfigInitFileJUnitTest, GfshInitFileJUnitTest. Or we'll have
to change the gradle config to execute all Tests without DUnit in the
name for test and integrationTest (currently the latter targets look
for *JUnitTest).

3) Code format
Also, 2-space soft tabs is our official standard for indentation.

Changes look good! I think we should look into creating some reusable Rules
for all that logging setup you had to write in the tests.


On Fri, May 29, 2015 at 9:01 AM, Bruce Schuchardt bschucha...@pivotal.io
wrote:


 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/34814/#review85742
 ---


 This looks good, with the exception that I think there needs to be an
 @After in the config file unit test that resets the system properties to
 what they were before the test ran.

 - Bruce Schuchardt


 On May 29, 2015, 3:39 p.m., Roman Shaposhnik wrote:
 
  ---
  This is an automatically generated e-mail. To reply, visit:
  https://reviews.apache.org/r/34814/
  ---
 
  (Updated May 29, 2015, 3:39 p.m.)
 
 
  Review request for geode.
 
 
  Bugs: GEODE-38
  https://issues.apache.org/jira/browse/GEODE-38
 
 
  Repository: geode
 
 
  Description
  ---
 
  Gfsh launcher script implies an init file can be used. This was possible
 in GF 6.6, but wasn't implemented in the transition to the new Gfsh in GF
 7.0 onwards.
  From gemfire-assembly/src/main/dist/bin/gfsh.bat  :
  
  #
  Copy default .gfshrc to the home directory. Uncomment if needed.
  #
  #if [ ! -f $HOME/.gemfire/.gfsh2rc ]; then
  cp $GEMFIRE/defaultConfigs/.gemfire/.gfsh2rc $HOME
  #fi
  
  If this file is specified, it is currently ignored.
 
 
  Diffs
  -
 
 
  
 gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/Gfsh.java
 d9a396a
 
  
 gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/GfshConfig.java
 d7dba5a
 
  
 gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/shell/GfshConfigInitFileTest.java
 PRE-CREATION
 
  
 gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/shell/GfshInitFileTest.java
 PRE-CREATION
 
  Diff: https://reviews.apache.org/r/34814/diff/
 
 
  Testing
  ---
 
 
  Thanks,
 
  Roman Shaposhnik
 
 

Submitting podling report

[Kirk Lund]

According to https://wiki.apache.org/incubator/July2015, the podling report
is due today. I don't see where I'm supposed to submit it to though.

I'm not seeing any answers on
http://incubator.apache.org/guides/mentor.html#Sending+in+an+Incubation+Report
either.

Any pointers on where to send or upload?

-Kirk

Re: Using the LocatorLauncher

[Kirk Lund]

Yeah, the LocatorLauncher is intended to be an API for starting a
Locator in your local JVM or to use as the main when starting a new JVM.

You don't need to have a gemfire.properties file. You can programmatically
define all of your config options at runtime and either feed them in via
the LocatorLauncher.Builder.

LocatorLauncher launcher = new Builder()
  .setForce(true)
  .setMemberName(getUniqueName())
  .setPort(this.locatorPort)
  .set(DistributionConfig.LOG_LEVEL_NAME, config)
  .set(DistributionConfig.MCAST_PORT_NAME, 0)
  .set(DistributionConfig.LOCATORS_NAME, hostname:port)
  .build()
  .start();

*replace hostname:port with a real hostname and port for any other
locators

If you don't want to use the internal (non-user-API) DistributionConfig
then just specify strings for the property names:

  .set(log-level, config)
  .set(mcast-port, 0)
  .set(locators, hostname:port)

Another way to set these at runtime is to set System properties with
the gemfire. prefix:

System.setProperty(gemfire.log-level, config);
System.setProperty(gemfire.mcast-port, 0);
System.setProperty(gemfire.locators, hostname:port);

LocatorLauncher.start() is invoking InternalLocator.startLocator(...)
which is the implementation of a locator and it's passing in a Properties
instance with all the key:value gemfire.properties you set. Down inside
InternalLocator, it adds the local locator into the locators before
connecting to the DistributedSystem, so don't add the local locator to
your locators value within this JVM. Just list out hostname:port values
for other locators. If you did use a gemfire.properties file that's the
same place in the code that would trigger finding and loading the
properties file.

-Kirk (@kirk_lund)


On Tue, Jun 30, 2015 at 7:07 PM, Vinicius Carvalho 
viniciusccarva...@gmail.com wrote:

 Hi there, is it possible to use the LocatorLauncher class to bootstrap my
 locators within my code, and set the hosts of other locators dynamically?

 I don't have multicast enabled (AWS) and I need to specify the other
 locators by using an EC2 discovery.

 I could not find a way with the class to specify other locators in the
 system. Only via gemfire.properties.

 Is there a way to do such thing?

 Thank you

Geode podling report for review

[Kirk Lund]

Geode

Geode is a data management platform that provides real-time, consistent
access
to data-intensive applications throughout widely distributed cloud
architectures.

Geode has been incubating since 2015-04-27.

Three most important issues to address in the move towards graduation:

  1. Expanding the community to include contributors and committers outside
of
 Pivotal
  2. Execute and manage the project according to governance model required
by
 the Apache Way
  3. Have our first Apache (incubating) release (currently blocked on us
 solving JGroups licensing issues)

Any issues that the Incubator PMC (IPMC) or ASF Board wish/need to be aware
of?

  None.

How has the community developed since the last report?

  Mailing list activity in June: 208 emails on dev, 28 emails on user.
Topics
  range from Geode features and changes to Apache Way and policies affecting
  our project.

  There are 50 open issues on JIRA, 8 In Progress, 14 Resolved or Closed

  Events and conferences in June:

  - Virtual Meetup for Apache Geode (incubating) #1 - 2015-06-02
- 64 attended
  - Pune, India Meetup - 2015-06-06
- Discussion on Apache Geode -
  http://www.meetup.com/TechNext/events/222608288/
  - 30 attended
  - Pivotal Toronto User Group - 2015-06-24
- Introducing Apache Geode -
  http://www.meetup.com/Toronto-Pivotal-User-Group/events/39293/
  - 17 attended
  - Virtual Meetup for Apache Geode (incubating) #2 - 2015-06-25
- 25 attended
  - IMCSummit,
- Implementing a Highly Scalable In-Memory Stock Prediction System with
  Apache Geode, R and Spring XD - 2015-06-30
  - 35 attended
- Apache Geode Meetup - 2015-06-28
  - 14 attended

  Upcoming events and conferences:

  - OSCon IoT Lab - 2015-07-21
- http://www.oscon.com/open-source-2015/public/schedule/detail/44875
  - Apache Geode Hackathon - http://ambitious-apps.challengepost.com/
- winners to be announched 2015-07-23 at OSCON Portland
  - Virtual Meetup for Apache Geode (incubating) #3 - TBD
  - SpringOne2GX - September
- Implementing a Highly Scalable In-Memory Stock Prediction System with
  Apache Geode, R and Spring XD
- Building Highly Scalable Spring Applications With In-Memory
  Distributed Data Grids

  Apache Geode talks have been submitted to additional conferences:

  - ApacheCon Europe BigData - September
  - ApacheCon Europe Core - October
  - Spark Summit Europe - October
- Apache Geode, Zeppelin and Spark: unlocking analytics for your OLTP
data
  - Devoxx Belgium - November

How has the project developed since the last report?

  - Second SGA from Pivotal has been sent with final code drop including new
features:
- Off Heap support
- HDFS Integration
- Command line utilities
- JVSD - Statistic visualization tool
- Pulse monitoring tool
- Modules including HTTP Session Management
  - Renaming of source code packages will proceed
  - Renaming of command line from GFSH to GEODE will proceed

Date of last release:

  N/A - Just nightly builds.

When were the last committers or PMC members elected?

  7 members added by vote on June 15

Signed-off-by:

  [ ](geode) Konstantin Boudnik
  [ ](geode) Chip Childers
  [ ](geode) Justin Erenkrantz
  [ ](geode) Jan Iversen
  [ ](geode) Chris Mattmann
  [ ](geode) William A. Rowe Jr.
  [ ](geode) Henry Saputra
  [ ](geode) Roman Shaposhnik

Shepherd/Mentor notes:

Repackaging src code to org.apache.geode

[Kirk Lund]

I just want to clarify that the reason we are planning to repackage is
because of this policy:

http://incubator.apache.org/guides/mentor.html#repackaging

...which states that repackaging is recommended, but not mandated. Is there
a different source that states that it's mandated?

-Kirk

Re: Review Request 36221: GEODE-81 - Fixing unit test failures from AnalyzeSerializablesJUnitTest

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36221/#review90591
---

Ship it!


Ship It!

- Kirk Lund


On July 6, 2015, 9:55 p.m., Dan Smith wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36221/
 ---
 
 (Updated July 6, 2015, 9:55 p.m.)
 
 
 Review request for geode, Darrel Schneider and Kishor Bachhav.
 
 
 Repository: geode
 
 
 Description
 ---
 
 AnalyzeSerializablesJUnitTest is failing on the GEODE-8 branch due to 
 the introduction of a couple of classes that provide backwards 
 compatibility support: ShutdownAllGatewayHubsRequest and 
 GatewaySender$OrderPolicy. These classes need to have signatures 
 added to sanctionedDataSerializables.
 
 
 Diffs
 -
 
   
 gemfire-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedDataSerializables.txt
  d7a80e138977a5584dd6853a172b55d89da53973 
   
 gemfire-core/src/test/resources/com/gemstone/gemfire/codeAnalysis/sanctionedSerializables.txt
  f8725fa4a734554126936f685ffc8acd24d795e1 
 
 Diff: https://reviews.apache.org/r/36221/diff/
 
 
 Testing
 ---
 
 ./gradlew 
 -DintegrationTest.single=com/gemstone/gemfire/codeAnalysis/AnalyzeSerializablesJUnitTest
  gemfire-core:integrationTest
 
 
 Thanks,
 
 Dan Smith
 

Re: Geode podling report for review

[Kirk Lund]

!!
 
  On Wed, Jul 1, 2015 at 2:44 PM, Sean Busbey bus...@cloudera.com
 wrote:
 
   comments inline.
  
  
   On Wed, Jul 1, 2015 at 4:20 PM, Kirk Lund kl...@pivotal.io wrote:
  
Geode
   
Geode is a data management platform that provides real-time,
  consistent
access
to data-intensive applications throughout widely distributed cloud
architectures.
   
Geode has been incubating since 2015-04-27.
   
Three most important issues to address in the move towards
 graduation:
   
  1. Expanding the community to include contributors and committers
   outside
of
 Pivotal
  2. Execute and manage the project according to governance model
   required
by
 the Apache Way
  3. Have our first Apache (incubating) release (currently blocked
 on
  us
 solving JGroups licensing issues)
   
Any issues that the Incubator PMC (IPMC) or ASF Board wish/need to
 be
   aware
of?
   
  None.
   
   
  
   I repeat:
  
   Please include that you fostered a good discussion about distribution
 of
   non-release binary artifacts to downstream projects on the
   general@incubator
   list and include a status update on correcting those cases where Geode
  was
   distributing nightly builds to the general public (i.e. Docker Hub and
  the
   blog post pointing to nightlies).
  
  
  Talking about that, I've just updated the DockerHub profile to include
 the
  following disclaimer message:
 
  **DISCLAIMER**: Apache Geode (incubating) has not yet a release. The
 bits
  current available here are for development purposes arising from a
 nightly
  build.  Use at your own risk.
 
  Not to mention that the build is already identified with tag *nightly*
  which
  will probably be renamed to *unstable.*
 
  The next step will be to move the Dockerfile to Geode repository as
  well...
 
 
  
  
  
How has the community developed since the last report?
   
  Mailing list activity in June: 208 emails on dev, 28 emails on
 user.
Topics
  range from Geode features and changes to Apache Way and policies
affecting
  our project.
   
  There are 50 open issues on JIRA, 8 In Progress, 14 Resolved or
  Closed
   
  Events and conferences in June:
   
  - Virtual Meetup for Apache Geode (incubating) #1 - 2015-06-02
- 64 attended
  - Pune, India Meetup - 2015-06-06
- Discussion on Apache Geode -
  http://www.meetup.com/TechNext/events/222608288/
  - 30 attended
  - Pivotal Toronto User Group - 2015-06-24
- Introducing Apache Geode -
   
  http://www.meetup.com/Toronto-Pivotal-User-Group/events/39293/
  - 17 attended
  - Virtual Meetup for Apache Geode (incubating) #2 - 2015-06-25
- 25 attended
  - IMCSummit,
- Implementing a Highly Scalable In-Memory Stock Prediction
 System
   with
  Apache Geode, R and Spring XD - 2015-06-30
  - 35 attended
- Apache Geode Meetup - 2015-06-28
  - 14 attended
   
  Upcoming events and conferences:
   
  - OSCon IoT Lab - 2015-07-21
-
  http://www.oscon.com/open-source-2015/public/schedule/detail/44875
  - Apache Geode Hackathon -
 http://ambitious-apps.challengepost.com/
- winners to be announched 2015-07-23 at OSCON Portland
  - Virtual Meetup for Apache Geode (incubating) #3 - TBD
  - SpringOne2GX - September
- Implementing a Highly Scalable In-Memory Stock Prediction
 System
   with
  Apache Geode, R and Spring XD
- Building Highly Scalable Spring Applications With In-Memory
  Distributed Data Grids
   
  Apache Geode talks have been submitted to additional conferences:
   
  - ApacheCon Europe BigData - September
  - ApacheCon Europe Core - October
  - Spark Summit Europe - October
- Apache Geode, Zeppelin and Spark: unlocking analytics for your
  OLTP
data
  - Devoxx Belgium - November
   
How has the project developed since the last report?
   
  - Second SGA from Pivotal has been sent with final code drop
  including
new
features:
- Off Heap support
- HDFS Integration
- Command line utilities
- JVSD - Statistic visualization tool
- Pulse monitoring tool
- Modules including HTTP Session Management
  - Renaming of source code packages will proceed
  - Renaming of command line from GFSH to GEODE will proceed
   
Date of last release:
   
  N/A - Just nightly builds.
   
   
  
  
   You should not mention nightly builds under the last release section,
 as
   they are not releases.
  
  
  That's why we add N/A - Not applicable, we just mention that nightly
  builds are available. I've seen similar things on the Incubator wiki
 from
  older reports.
 
 
  
  
When were the last committers or PMC members elected?
   
  7 members added by vote on June 15
   
Signed-off-by:
   
  [ ](geode

Re: Repackaging src code to org.apache.geode

[Kirk Lund]

Yep, having 99% of the code in org.apache.geode pkgs with 1% in
com.gemstone.gemfire pkgs just to facilitate rolling upgrades seems like
something that would be reasonable to discuss on general@incubator.


On Thu, Jul 2, 2015 at 12:35 PM, Bruce Schuchardt bschucha...@pivotal.io
wrote:

 Hey, if we can do this then we should leave versions of exception classes
 in com.gemstone.gemfire so we can send them to old GemFire clients!  If we
 do that and swizzle package names in DataSerializer maybe we'll be able to
 support migration of GemFire clients to Geode.  That would facilitate
 faster adoption of Geode by users of the commercial product.




 Le 7/2/2015 12:28 PM, Sean Busbey a écrit :

 On Thu, Jul 2, 2015 at 1:25 PM, William Markito wmark...@pivotal.io
 wrote:

  My reading of that is it's specifically for incubation, which indeed is
 not
 required based on this thread
 

 https://www.mail-archive.com/search?l=dev@geode.incubator.apache.orgq=subject:%22Package+renaming%5C%3F%22o=newestf=1
 .

 But for leaving incubation and becoming a TLP my understanding was that
 it
 is required.


  Many projects leave code in packages that are not org.apache for
 backwards
 compatibility.

 Roman is correct, if you want to have things outside of org.apache you
 should bring up the matter on general@incubator. Including the reasoning
 for having things outside of org.apache and the long term plan (if any)
 for
 moving things will help avoid a longer set of questions.

Re: Where to place Spark + GemFire connector.

[Kirk Lund]

I would think that github would be a better option for the Spark Geode
Connector. That way it's not tightly coupled to the Geode release cycle.

I don't see why it's desirable to bloat Geode with every single script,
tool, or connector that might interact with Geode.

Another reason to consider separating projects is testing. Do we really
want the Geode build to run unit/integration/e2e tests for Geode, JVSD,
Spark connector, etc? If someone isn't working on the Spark connector,
should they be forced to execute the tests for it before committing? I
think the Geode tests alone are going to push the limits of what ASF allows
in Jenkins.

-Kirk


On Mon, Jul 6, 2015 at 11:22 PM, Qihong Chen qc...@pivotal.io wrote:

 The problem is caused by multiple major dependencies and different release
 cycles. Spark Geode Connector depends on two products: Spark and Geode (not
 counting other dependencies), and Spark moves much faster than Geode, and
 some features/code are not backward compatible.

 Our initial connector implementation depends on Spark 1.2 in before the
 last week of March 15. Then Spark 1.3 was released on the last week of
 March, and some connector feature doesn't work with Spark 1.3, then we
 moved on, and now support Spark 1.3 (but not 1.2 any more, we did create
 tag). Two weeks ago, Spark 1.4 was released, and it breaks our connector
 code again.

 Therefore, for each Geode release, we probably need multiple Connector
 releases, and probably need to maintain last 2 or 3 Connector releases, for
 example, we need to support both Spark 1.3 and 1.4 with the current Geode
 code.

 The question is how to support this with single source repository?

 Thanks,
 Qihong

Re: Review Request 37400: GEODE-211: shorten the time ConcurrentRegionOperationsJUnitTest runs

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37400/#review95197
---

Ship it!


Ship It!

- Kirk Lund


On Aug. 12, 2015, 5:16 p.m., Darrel Schneider wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37400/
 ---
 
 (Updated Aug. 12, 2015, 5:16 p.m.)
 
 
 Review request for geode and Kirk Lund.
 
 
 Bugs: GEODE-211
 https://issues.apache.org/jira/browse/GEODE-211
 
 
 Repository: geode
 
 
 Description
 ---
 
 GEODE-211: shorten the time ConcurrentRegionOperationsJUnitTest runs
 
 I see the elapsed time of this test go from 201 seconds to 85 seconds with 
 this change.
 
 
 Diffs
 -
 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/ConcurrentRegionOperationsJUnitTest.java
  ce0882af98ef3a28fe8cb0d34d9da7088a1578dc 
 
 Diff: https://reviews.apache.org/r/37400/diff/
 
 
 Testing
 ---
 
 ConcurrentRegionOperationsJUnitTest
 
 
 Thanks,
 
 Darrel Schneider
 

Re: Reviewboard seems to be malfunctioning

[Kirk Lund]

Check here to see if ASF already knows about it: http://status.apache.org/

If the problem isn't shown on that status page then report it in the ASF
infra hipchat: http://infra.chat/

-Kirk


On Wed, Aug 19, 2015 at 9:49 AM, Bruce Schuchardt bschucha...@pivotal.io
wrote:

 I get the same error accessing it from two different networks.

 https://reviews.apache.org/dashboard

 Something broke! (Error 500)

 It appears something broke when you tried to go to here. This is either a
 bug in Review Board or a server configuration error. Please report this to
 your administrator.

Re: Investigate test failures: Build 189

[Kirk Lund]

I don't have any ideas about the cause without looking at the full
stack of RegionDestroyedException
and the rest of the logs. We haven't been seeing anything like this so I
would expect it to be a real bug that was committed.

It might be caused by race condition(s) in either the test or the product
(or both). This could then this result in pollution in one or
more JVMs which then causes later tests (so it might be the earliest
misbehaving test that's of interest).

We usually copy entire test run to somewhere, merge them and then study the
logs and code. It's not quick or easy and I'm not sure where ASF is
archiving the results. I would expect the archived results to be found if
you dig through all the screens at
https://builds.apache.org/job/Geode-nightly/189/ (or whatever the build #
is).

-Kirk


On Wed, Aug 19, 2015 at 11:49 AM, Ashvin A aas@gmail.com wrote:

 Hi,

 The latest nightly build is reporting 4 test failures. These tests do not
 fail when I run them locally. Based on a quick search it also seems these
 tests failed for the first time and are not related to recent code changes.

1. c.g.g.i.c.ClientServerTransactionDUnitTest.testClientCommitFunction
2. c.g.g.i.c.ConnectDisconnectDUnitTest.testManyConnectsAndDisconnects
3.

  
 c.g.g.i.c.PartitionedRegionAsSubRegionDUnitTest.testSubRegionLocalDestroyRegion
4. c.g.g.i.c.PartitionedRegionAsSubRegionDUnitTest.testSubRegionClose


 All these failures have similar error message:

 Found suspect string in log4j at line 1430
 com.gemstone.gemfire.cache.RegionDestroyedException:...

 Can I conclude these failures are caused by some build hardware issue? Are
 there any other artifacts I could look at for additional details.

 Thanks,
 Ashvin

Pull requests, wiki page and multiple git commits

[Kirk Lund]

I just merged PR#15 in to develop. I tried following the instructions on
https://cwiki.apache.org/confluence/display/GEODE/Code+contributions but I
couldn't get things to really work the way I wanted or the way the page
seemed to describe it.

I wanted all three of the following commits to be one commit on today's
date with a single unified commit message including GEODE-213. The pulled
commit went in for Aug 12 despite attempting to use --rebase instead of
--squash.

If anyone knows git well, please update that wiki page so that we can
cleanly handle pull requests.

commit bbc2a5fa5f0bbcd00a8ab64451a2528a22d88bc0
Merge: 9efe74e 581702a
Author: Kirk Lund kl...@pivotal.io
Date:   Wed Aug 19 16:09:21 2015 -0700

Merge branch 'feature/GEODE-213' into develop

commit 581702ac1d2a9debe8619680d09fa868b9ca8b05
Author: Kirk Lund kl...@pivotal.io
Date:   Wed Aug 19 16:01:26 2015 -0700

GEODE-213: New unit test that confirms bug

commit 65e969439e3c03f5557b2e1adc609c97544ecb2b
Author: Vito Gavrilov vgavri...@pivotal.io
Date:   Wed Aug 12 13:13:55 2015 -0700

Fix JMX Http manager incorrectly treating 'start gateway-sender'
endpoint as 'start gateway-receiver'

klund@klund-e6420/c/dev/geode_CLEAN [590]$ git --version
git version 2.4.5

klund@klund-e6420/c/dev/geode_CLEAN [594]$ git-flow version
1.8.0 (AVH Edition)

Review Request 37683: Clean up WanCommandsControllerJUnitTest

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37683/
---

Review request for geode and Darrel Schneider.


Bugs: GEODE-246
https://issues.apache.org/jira/browse/GEODE-246


Repository: geode


Description
---

I added this test earlier in the week with pull request #15 and just noticed 
that its use of JUnitParams needs to be simplified. I also found a couple 
assertions to add to make the test more valuable.


Diffs
-

  
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/web/controllers/WanCommandsControllerJUnitTest.java
 fb39d8c 

Diff: https://reviews.apache.org/r/37683/diff/


Testing
---

WanCommandsControllerJUnitTest
test


Thanks,

Kirk Lund

Re: There was no nightly build yesterday?

[Kirk Lund]

Thanks Mark!


On Fri, Aug 21, 2015 at 1:13 PM, Mark Bretl mbr...@pivotal.io wrote:

 I will re-enable the nightly schedule.

 --Mark

 On Fri, Aug 21, 2015 at 1:11 PM, Kirk Lund kirk.l...@gmail.com wrote:

  Hi,
 
  We need to have the nightly build reenabled for Apache Geode incubating.
  Who do we need to speak with to make this happen?
 
  Thanks,
  Kirk
 
  On Fri, Aug 21, 2015 at 11:06 AM, Kirk Lund kl...@pivotal.io wrote:
 
  Hi Andrew,
 
  Please reenable our nightly build. It's about a 6 hour run and we don't
  want that triggered hourly. It was set to nightly because we are
 checking
  in changes every day but didn't want the build system to attempt to run
  all
  of those nightly tests every hour.
 
  Thanks,
  Kirk
 
 
  On Fri, Aug 21, 2015 at 10:33 AM, Andrew Bayer andrew.ba...@gmail.com
  wrote:
 
   See the email I sent to builds@. We disabled all timer triggers
  because a
   lot of jobs were set to run daily even if nothing changed, using up a
  lot
   of resources for no good reason. If you've got a couple jobs that you
  want
   running daily whether there are changes or not and they don't take an
   excessive amount of time, you can switch back to daily.
  
   A.
  
   On Fri, Aug 21, 2015 at 1:31 PM, Mark Bretl mbr...@pivotal.io
 wrote:
  
Looks as though user abayer changed the build nightly to poll SCM
   'hourly'.
   
Andrew, can you explain why you made the configuration change to the
   Geode
Nightly build job?
   
Best Regards,
   
--Mark
   
On Fri, Aug 21, 2015 at 9:58 AM, Ashvin A aas@gmail.com
 wrote:
   
Hi,
   
I was expecting to see build 191 results today morning. It seems
 the
nightly build did not happen or is stuck. There is no build mail or
   build
activity on https://builds.apache.org/job/Geode-nightly/.
   
Anyone knows more about it?
   
Thank you,
Ashvin
   
   
   
   
--
Mark Bretl
Software Build Engineer
Pivotal
503-533-3869
www.pivotal.io
   
  
 
 
 


 --
 Mark Bretl
 Software Build Engineer
 Pivotal
 503-533-3869
 www.pivotal.io

Re: Review Request 37670: Convert resource string to URI string for log4j2-cli.xml

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37670/
---

(Updated Aug. 21, 2015, 3:19 a.m.)


Review request for geode, Darrel Schneider, Eric Shu, and William Markito.


Bugs: GEODE-232
https://issues.apache.org/jira/browse/GEODE-232


Repository: geode


Description
---

Bug was introduced when a previous checkin removed two lines in LogService that 
were converting the resource string to a URI string for the value of the 
log4j.configurationFile system property during initialization.

The end result is gfsh prints ERROR StatusLogger log4j2-cli.xml not found in 
file system or classpath

In these changes, I restore the missing lines and add a bunch of new unit and 
integration tests to improve test coverage for LogService and ensure this does 
not happen again.


Diffs
-

  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java
 a4a399d 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/Configurator.java
 ccb2639 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LogServiceIntegrationJUnitTest.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LogServiceIntegrationTestSupport.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LogServiceJUnitTest.java
 ce1b6c2 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LogServiceUserDirIntegrationJUnitTest.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingIntegrationTestSuite.java
 1efaa59 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingUnitTestSuite.java
 cd39a9d 

Diff: https://reviews.apache.org/r/37670/diff/


Testing (updated)
---

manual testing with gemfire-assembly/build/install/apache-geode/bin/gfsh
LoggingUnitTestSuite
LoggingIntegrationTestSuite


Thanks,

Kirk Lund

Re: Updating JIRA issues

[Kirk Lund]

GEODE-47 has some comments but is still open (that's the correct state for
now).

The others appear to be mistakenly left open after committing fixes.

-Kirk


On Thu, Aug 20, 2015 at 8:49 PM, Anthony Baker aba...@pivotal.io wrote:

 It looks like several JIRA issues have been fixed but are still open.  Is
 this correct?

 GEODE-47
 GEODE-93
 GEODE-109
 GEODE-146
 GEODE-188
 GEODE-222

 Anthony

Re: Review Request 36866: GEODE-127: Improve reliability and increase execution speed of some tests

[Kirk Lund]

 On July 29, 2015, 12:47 a.m., William Markito wrote:
  Why some tests are using System.out.println and some uses LogWriter ? Since 
  it looks like you did a nice refactoring around that I'm just asking if we 
  could have some consensus around what should be used within our tests as a 
  standard.
 
 William Markito wrote:
 Since we're talking about speeding up our tests we could for instance use 
 an async appender for all our testing output if it's all log4j for example.  
 But this may actually be a separate JIRA and not block this patch.

The test.golden tests are testing what used to be the framework for the 
quickstart tests. These tests are testing a test framework that might be 
testing code that uses System.out, LogWriter, or Logger if that makes sense ;) 
It's kinda meta right now and there are no actual tests currently using this 
framework but I didn't want to throw away the framework because it would 
probably be useful for the integration testing of any new Examples that we 
might create. An Example might print to System.out or Log4J2 might be 
configured to append to System.out and this framework let's a test analyze that 
output for errors, expected errors, expected output (regex or static strings). 
Note: the test.process package is shared between these tests and our launcher 
tests (integration tests for ServerLauncher and LocatorLauncher).


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36866/#review93375
---


On July 28, 2015, 9:27 p.m., Kirk Lund wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36866/
 ---
 
 (Updated July 28, 2015, 9:27 p.m.)
 
 
 Review request for geode, Darrel Schneider, John Blum, and William Markito.
 
 
 Bugs: GEODE-127
 https://issues.apache.org/jira/browse/GEODE-127
 
 
 Repository: geode
 
 
 Description
 ---
 
 Recategorize some tests as IntegrationTests. Specifically the tests involving 
 spawned processes and file system I/O are now IntegrationTests.
 
 Improve reliability and screamline test execution time. Fix up JUnit 4 syntax 
 and misc tidying of test code.
 
 Add two new TestSuite classes for targeted testing.
 
 
 Diffs
 -
 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteJUnitTest.java
  fb0df63 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/ExecutableProcess.java
  PRE-CREATION 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailOutputTestCase.java
  a3995f8 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithErrorInOutputJUnitTest.java
  b3ca93e 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithExtraLineInOutputJUnitTest.java
  1c49749 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithLineMissingFromEndOfOutputJUnitTest.java
  877f671 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithLineMissingFromMiddleOfOutputJUnitTest.java
  629eb7f 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithLoggerErrorInOutputJUnitTest.java
  b485ba4 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithLoggerFatalInOutputJUnitTest.java
  a71ce18 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithLoggerWarnInOutputJUnitTest.java
  211008a 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithProblemInOutputTestCase.java
  5e1552f 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithSevereInOutputJUnitTest.java
  9089545 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithTimeoutOfWaitForOutputToMatchJUnitTest.java
  2417f3d 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithWarningInOutputJUnitTest.java
  89cc7dc 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/GoldenComparator.java
  34c1ce7 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/GoldenStringComparator.java
  75a3398 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/GoldenTestCase.java
  37b4e48 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/GoldenTestFrameworkTestSuite.java
  PRE-CREATION 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/PassJUnitTest.java
  886fc94 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/PassWithExpectedErrorJUnitTest.java
  39267e9 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/PassWithExpectedProblemTestCase.java
  2958007 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/PassWithExpectedSevereJUnitTest.java
  659e807 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/test

Review Request 36957: GEODE-181: Add new FastLogger tests and fix isDebug/TraceEnabled checks

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36957/
---

Review request for geode and Darrel Schneider.


Bugs: GEODE-181 and GEODE-89
https://issues.apache.org/jira/browse/GEODE-181
https://issues.apache.org/jira/browse/GEODE-89


Repository: geode


Description
---

I found GEODE-181 while refactoring the tests in FastLoggerJUnitTest for 
GEODE-89. These changes address both tickets.

Extract testDefaultConfig to FastLoggerWithDefaultConfigJUnitTest.

Refactor remaining test in FastLoggerJUnitTest to improve coverage and 
readability. Introduce use of TemporaryFolder instead of using tmp dir. Change 
from UnitTest to IntegrationTest because of file system I/O and execution speed.

Add new TestSuite classes for targeted testing of logging and log4j packages.


Diffs
-

  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/FastLogger.java
 21d7965 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingIntegrationTestSuite.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingUnitTestSuite.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerJUnitTest.java
 2aab5df 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerWithDefaultConfigJUnitTest.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/Log4jIntegrationTestSuite.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/Log4jUnitTestSuite.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/36957/diff/


Testing
---

test, integrationTest, new TestSuites, rebuild open+closed


Thanks,

Kirk Lund

Re: Review Request 36950: [GEODE-177] Adding Dockerfile to Geode codebase

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36950/#review93662
---



docker/Dockerfile (line 20)
https://reviews.apache.org/r/36950/#comment148074

Is it possible to use $JAVA_HOME here instead of hardcoding references to 
/jdk1.8.0_51?


- Kirk Lund


On July 30, 2015, 8:52 p.m., William Markito wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36950/
 ---
 
 (Updated July 30, 2015, 8:52 p.m.)
 
 
 Review request for geode.
 
 
 Bugs: GEODE-177
 https://issues.apache.org/jira/browse/GEODE-177
 
 
 Repository: geode
 
 
 Description
 ---
 
 Adding Dockerfile to Geode codebase
 
 
 Diffs
 -
 
   docker/Dockerfile PRE-CREATION 
   docker/README.md PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36950/diff/
 
 
 Testing
 ---
 
 Build executed under Dockerhub
 
 
 Thanks,
 
 William Markito
 

Re: Review Request 36857: Remove rerunTest task from gemfire-core/build.gradle

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36857/#review93301
---

Ship it!


Ship It!

- Kirk Lund


On July 27, 2015, 8:27 p.m., Mark Bretl wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36857/
 ---
 
 (Updated July 27, 2015, 8:27 p.m.)
 
 
 Review request for geode and Kirk Lund.
 
 
 Bugs: GEODE-161
 https://issues.apache.org/jira/browse/GEODE-161
 
 
 Repository: geode
 
 
 Description
 ---
 
 There is a commented task 'rerunTest' which was added revision 
 31d1b20ee47088f0518001d87d821838cb614771, this should be removed
 
 
 Diffs
 -
 
   gemfire-core/build.gradle 6b8a1df 
 
 Diff: https://reviews.apache.org/r/36857/diff/
 
 
 Testing
 ---
 
 'gradlew clean build -Dskip.tests=true'
 
 
 Thanks,
 
 Mark Bretl
 

Re: Review Request 36866: GEODE-127: Improve reliability and increase execution speed of some tests

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36866/
---

(Updated July 28, 2015, 4:14 p.m.)


Review request for geode, Darrel Schneider and William Markito.


Bugs: GEODE-127
https://issues.apache.org/jira/browse/GEODE-127


Repository: geode


Description (updated)
---

Recategorize some tests as IntegrationTests. Specifically the tests involving 
spawned processes and file system I/O are now IntegrationTests.

Improve reliability and screamline test execution time. Fix up JUnit 4 syntax 
and misc tidying of test code.

Add two new TestSuite classes for targeted testing.


Diffs
-

  
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteJUnitTest.java
 fb0df63 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/ExecutableProcess.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailOutputTestCase.java
 a3995f8 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithErrorInOutputJUnitTest.java
 b3ca93e 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithExtraLineInOutputJUnitTest.java
 1c49749 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithLineMissingFromEndOfOutputJUnitTest.java
 877f671 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithLineMissingFromMiddleOfOutputJUnitTest.java
 629eb7f 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithLoggerErrorInOutputJUnitTest.java
 b485ba4 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithLoggerFatalInOutputJUnitTest.java
 a71ce18 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithLoggerWarnInOutputJUnitTest.java
 211008a 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithProblemInOutputTestCase.java
 5e1552f 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithSevereInOutputJUnitTest.java
 9089545 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithTimeoutOfWaitForOutputToMatchJUnitTest.java
 2417f3d 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithWarningInOutputJUnitTest.java
 89cc7dc 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/GoldenComparator.java
 34c1ce7 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/GoldenStringComparator.java
 75a3398 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/GoldenTestCase.java 
37b4e48 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/GoldenTestFrameworkTestSuite.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/PassJUnitTest.java 
886fc94 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/PassWithExpectedErrorJUnitTest.java
 39267e9 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/PassWithExpectedProblemTestCase.java
 2958007 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/PassWithExpectedSevereJUnitTest.java
 659e807 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/PassWithExpectedWarningJUnitTest.java
 866e8b2 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/RegexGoldenComparator.java
 bc80b3a 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/StringGoldenComparator.java
 5547a9e 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/process/ProcessTestFrameworkTestSuite.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/process/ProcessWrapper.java
 3931b22 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/process/ProcessWrapperJUnitTest.java
 7c08fcc 
  
gemfire-core/src/test/resources/com/gemstone/gemfire/test/golden/log4j2-test.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/36866/diff/


Testing
---

test, integrationTest and targeted testing of TestSuites


Thanks,

Kirk Lund

Re: Review Request 37143: fix races in testRegionIdleInvalidate

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37143/#review94316
---

Ship it!


Ship It!

- Kirk Lund


On Aug. 5, 2015, 9:22 p.m., Darrel Schneider wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37143/
 ---
 
 (Updated Aug. 5, 2015, 9:22 p.m.)
 
 
 Review request for geode and Kirk Lund.
 
 
 Bugs: GEODE-185
 https://issues.apache.org/jira/browse/GEODE-185
 
 
 Repository: geode
 
 
 Description
 ---
 
 The test code is now careful to wait for the expiration clock to advance.
 A different assertion will be triggered if the expiration clock goes back in 
 time.
 Fixed two places in the product expiration code that did not use the 
 expiration clock.
 
 
 Diffs
 -
 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/ExpiryTask.java
  95cd3a807ef54d66aaa9f257f6a3720738377a83 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionIdleExpiryTask.java
  fbcb12c8284e8f8829f48be5a18cecd48dc7d711 
   gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 
 69eeec03016b98bb7b420e2d41e15e53053d43e8 
   gemfire-core/src/test/java/dunit/DistributedTestCase.java 
 564e7efb947e4dd77b8cb3fa40e1ac9491d75afa 
 
 Diff: https://reviews.apache.org/r/37143/diff/
 
 
 Testing
 ---
 
 precheckin
 
 
 Thanks,
 
 Darrel Schneider
 

Re: Review Request 36950: [GEODE-177] Adding Dockerfile to Geode codebase

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36950/#review93916
---

Ship it!


Ship It!

- Kirk Lund


On July 31, 2015, 12:13 a.m., William Markito wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36950/
 ---
 
 (Updated July 31, 2015, 12:13 a.m.)
 
 
 Review request for geode.
 
 
 Bugs: GEODE-177
 https://issues.apache.org/jira/browse/GEODE-177
 
 
 Repository: geode
 
 
 Description
 ---
 
 Adding Dockerfile to Geode codebase
 
 
 Diffs
 -
 
   docker/Dockerfile PRE-CREATION 
   docker/README.md PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36950/diff/
 
 
 Testing
 ---
 
 Build executed under Dockerhub
 
 
 Thanks,
 
 William Markito
 

Re: Review Request 36957: GEODE-181: Add new FastLogger tests and fix isDebug/TraceEnabled checks

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36957/#review93956
---



gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java
 (line 87)
https://reviews.apache.org/r/36957/#comment148399

This PropertyChangeListener is invokes this method once and then this line 
was invoking it a second time. I'll delete this line.



gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java
 (line 150)
https://reviews.apache.org/r/36957/#comment148401

I'll delete all deadcode such as these lines.



gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java
 (line 256)
https://reviews.apache.org/r/36957/#comment148402

I discovered that only two filter types were being handled correctly. 
Appender and AppenderRef filters were not being handled correctly. Basically, 
if there are any filters defined or if the level is DEBUG or lower then 
FastLogger must delegate to the underlying logger rather than early-out from 
the isEnabled checks.



gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/FastLogger.java
 (line 21)
https://reviews.apache.org/r/36957/#comment148404

I renamed this to delegating to avoid confusion with isDebugEnabled which 
is a pair of methods on Logger API.



gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerIntegrationJUnitTest.java
 (line 37)
https://reviews.apache.org/r/36957/#comment148408

Moved most tests from FastLoggerJUnitTest to here because they were all 
IntegrationTests. Expanded coverage to include all log4j2 filter types and all 
boundary/transition points interesting for FastLogger (ex: to/and/from 
isDelegating).



gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerWithDefaultConfigJUnitTest.java
 (line 56)
https://reviews.apache.org/r/36957/#comment148407

Need to rename debugAvailable to delegating


- Kirk Lund


On Aug. 3, 2015, 7:58 p.m., Kirk Lund wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36957/
 ---
 
 (Updated Aug. 3, 2015, 7:58 p.m.)
 
 
 Review request for geode and Darrel Schneider.
 
 
 Bugs: GEODE-181 and GEODE-89
 https://issues.apache.org/jira/browse/GEODE-181
 https://issues.apache.org/jira/browse/GEODE-89
 
 
 Repository: geode
 
 
 Description
 ---
 
 I found GEODE-181 while refactoring the tests in FastLoggerJUnitTest for 
 GEODE-89. These changes address both tickets.
 
 Extract testDefaultConfig to FastLoggerWithDefaultConfigJUnitTest.
 
 Refactor remaining test in FastLoggerJUnitTest to improve coverage and 
 readability. Introduce use of TemporaryFolder instead of using tmp dir. 
 Change from UnitTest to IntegrationTest because of file system I/O and 
 execution speed.
 
 Add new TestSuite classes for targeted testing of logging and log4j packages.
 
 
 Diffs
 -
 
   build.gradle c82e82a 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java
  6298cf6 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/Configurator.java
  c7ae945 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/FastLogger.java
  21d7965 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/DistributedSystemLogFileJUnitTest.java
  9c7ba58 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingIntegrationTestSuite.java
  PRE-CREATION 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingUnitTestSuite.java
  PRE-CREATION 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerIntegrationJUnitTest.java
  PRE-CREATION 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerJUnitTest.java
  2aab5df 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerWithDefaultConfigJUnitTest.java
  PRE-CREATION 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/Log4jIntegrationTestSuite.java
  PRE-CREATION 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/Log4jUnitTestSuite.java
  PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36957/diff/
 
 
 Testing
 ---
 
 test, integrationTest, new TestSuites, rebuild open+closed
 
 
 Thanks,
 
 Kirk Lund
 

Re: Review Request 36957: GEODE-181: Add new FastLogger tests and fix isDebug/TraceEnabled checks

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36957/
---

(Updated Aug. 3, 2015, 8:32 p.m.)


Review request for geode and Darrel Schneider.


Bugs: GEODE-181 and GEODE-89
https://issues.apache.org/jira/browse/GEODE-181
https://issues.apache.org/jira/browse/GEODE-89


Repository: geode


Description
---

I found GEODE-181 while refactoring the tests in FastLoggerJUnitTest for 
GEODE-89. These changes address both tickets.

Extract testDefaultConfig to FastLoggerWithDefaultConfigJUnitTest.

Refactor remaining test in FastLoggerJUnitTest to improve coverage and 
readability. Introduce use of TemporaryFolder instead of using tmp dir. Change 
from UnitTest to IntegrationTest because of file system I/O and execution speed.

Add new TestSuite classes for targeted testing of logging and log4j packages.


Diffs (updated)
-

  build.gradle c82e82a 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java
 6298cf6 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/Configurator.java
 c7ae945 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/FastLogger.java
 21d7965 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/DistributedSystemLogFileJUnitTest.java
 9c7ba58 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingIntegrationTestSuite.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingUnitTestSuite.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerIntegrationJUnitTest.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerJUnitTest.java
 2aab5df 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerWithDefaultConfigJUnitTest.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/Log4jIntegrationTestSuite.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/Log4jUnitTestSuite.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/36957/diff/


Testing
---

test, integrationTest, new TestSuites, rebuild open+closed


Thanks,

Kirk Lund

Re: Review Request 36957: GEODE-181: Add new FastLogger tests and fix isDebug/TraceEnabled checks

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36957/
---

(Updated Aug. 3, 2015, 7:58 p.m.)


Review request for geode and Darrel Schneider.


Changes
---

Created new FastLogger unit tests and integration tests. Added build dependency 
on mockito (GEODE-104).


Bugs: GEODE-181 and GEODE-89
https://issues.apache.org/jira/browse/GEODE-181
https://issues.apache.org/jira/browse/GEODE-89


Repository: geode


Description
---

I found GEODE-181 while refactoring the tests in FastLoggerJUnitTest for 
GEODE-89. These changes address both tickets.

Extract testDefaultConfig to FastLoggerWithDefaultConfigJUnitTest.

Refactor remaining test in FastLoggerJUnitTest to improve coverage and 
readability. Introduce use of TemporaryFolder instead of using tmp dir. Change 
from UnitTest to IntegrationTest because of file system I/O and execution speed.

Add new TestSuite classes for targeted testing of logging and log4j packages.


Diffs (updated)
-

  build.gradle c82e82a 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java
 6298cf6 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/Configurator.java
 c7ae945 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/FastLogger.java
 21d7965 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/DistributedSystemLogFileJUnitTest.java
 9c7ba58 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingIntegrationTestSuite.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingUnitTestSuite.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerIntegrationJUnitTest.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerJUnitTest.java
 2aab5df 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerWithDefaultConfigJUnitTest.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/Log4jIntegrationTestSuite.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/Log4jUnitTestSuite.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/36957/diff/


Testing
---

test, integrationTest, new TestSuites, rebuild open+closed


Thanks,

Kirk Lund

Re: Review Request 36957: GEODE-181: Add new FastLogger tests and fix isDebug/TraceEnabled checks

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36957/
---

(Updated Aug. 3, 2015, 8:34 p.m.)


Review request for geode and Darrel Schneider.


Changes
---

Latest complete diffs


Bugs: GEODE-181 and GEODE-89
https://issues.apache.org/jira/browse/GEODE-181
https://issues.apache.org/jira/browse/GEODE-89


Repository: geode


Description
---

I found GEODE-181 while refactoring the tests in FastLoggerJUnitTest for 
GEODE-89. These changes address both tickets.

Extract testDefaultConfig to FastLoggerWithDefaultConfigJUnitTest.

Refactor remaining test in FastLoggerJUnitTest to improve coverage and 
readability. Introduce use of TemporaryFolder instead of using tmp dir. Change 
from UnitTest to IntegrationTest because of file system I/O and execution speed.

Add new TestSuite classes for targeted testing of logging and log4j packages.


Diffs (updated)
-

  build.gradle c82e82a 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java
 6298cf6 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/Configurator.java
 c7ae945 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/FastLogger.java
 21d7965 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/DistributedSystemLogFileJUnitTest.java
 9c7ba58 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingIntegrationTestSuite.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingUnitTestSuite.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerIntegrationJUnitTest.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerJUnitTest.java
 2aab5df 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerWithDefaultConfigJUnitTest.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/Log4jIntegrationTestSuite.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/Log4jUnitTestSuite.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/36957/diff/


Testing
---

test, integrationTest, new TestSuites, rebuild open+closed


Thanks,

Kirk Lund

Re: Review Request 36963: GEODE-162: remove race condititions and long sleeps from region expiration test methods in RegionTestCase

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36963/#review94131
---

Ship it!


Ship It!

- Kirk Lund


On July 30, 2015, 11:50 p.m., Darrel Schneider wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36963/
 ---
 
 (Updated July 30, 2015, 11:50 p.m.)
 
 
 Review request for geode and Kirk Lund.
 
 
 Repository: geode
 
 
 Description
 ---
 
 removed race condititions and long sleeps from region expiration test methods 
 in RegionTestCase
 
 
 Diffs
 -
 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java
  9ea26a792f32fc025cf3b4cf6daf38e340f529be 
   gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 
 a20cfc50d3b47a3b0bc194cd9c38b44fd168bd8d 
 
 Diff: https://reviews.apache.org/r/36963/diff/
 
 
 Testing
 ---
 
 precheckin
 
 
 Thanks,
 
 Darrel Schneider
 

Re: Review Request 37148: fix race in testEntryTtlDestroyEvent

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37148/#review94424
---

Ship it!


Ship It!

- Kirk Lund


On Aug. 5, 2015, 11:52 p.m., Darrel Schneider wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37148/
 ---
 
 (Updated Aug. 5, 2015, 11:52 p.m.)
 
 
 Review request for geode and Kirk Lund.
 
 
 Bugs: GEODE-179
 https://issues.apache.org/jira/browse/GEODE-179
 
 
 Repository: geode
 
 
 Description
 ---
 
 A race existed that caused no-ack regions to fail because they
 did not see the entry expire.
 This race was fixed by suspending expiration until the create
 is seen on the remote side and then after permitting expiration
 using a wait for the expire to happen.
 
 
 Diffs
 -
 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java
  5e605dd11cd010053fb988dcc5d05a403cf288f2 
 
 Diff: https://reviews.apache.org/r/37148/diff/
 
 
 Testing
 ---
 
 precheckin
 
 
 Thanks,
 
 Darrel Schneider
 

Re: 16 days without a green build

[Kirk Lund]

For spurious failures, the problematic tests are predominantly dunit tests
which are actually end-to-end tests involving 6 jvms. End-to-end tests are
notorious for having reliability issues. This is magnified by reusing jvms
from one test case to the next. Eventually, one of the 6 jvms hits a
problem: 1) a race condition (writting a good distributed test is tricky)
or 2) a long stop-the-world GC pause which causes a test to fail with a
timeout or pause long enough to hit a more rare race condition. Since the
jvms are reused, a test failure is also very likely to pollute the jvm
which can in turn cause subsequent test failure(s).

The best overall way to improve the reliability of these dunit tests is to
fork brand-new jvms for every dunit test case which would force each test
case to run in isolation. I think changing build.gradle distributedTest
task from forkEvery 30 to forkEvery 1 would help greatly. I'll file a
JIRA ticket for forking the dunit jvms every test and propose it on dev.

Updating dunit to use junit 4 syntax would help a little by allowing us to
use some newer features and rules that are suitable to integration or
end-to-end tests. This is already under way with GEODE-217.

End-to-end tests are important but have some issues:
1) spurious failures and reliability problems are common
2) excessive redundant code coverage -- they tend to execute the same 10%
of the code base 90% of the time
3) long execution time

I would be remiss if I didn't use this opportunity to encourage the Geode
dev community to refocus on writing true unit tests with Mockito or JMock
while moderating the creation of new dunit (end-to-end) tests.

We have our automated developer tests categorized as UnitTest,
IntegrationTest and DistributedTest. True unit tests written using Mockito
or JMock do result in meaningful, worthwhile tests both as tests and as
design tools even for a code base such as Geode. These unit tests no less
important than integration tests or end-to-end tests (both are still
important and all three provide different types of complementary test
coverage).

Lastly a list of my favorite books (so far) on unit testing:

Working Effectively with Legacy Code by Michael Feathers
Practical Unit Testing with JUnit and Mockito by Tomek Kaczanowski
Effective Unit Testing by Lasse Koskela
Growing Object-Oriented Software, Guided by Tests by Steve Freeman and Nat
Pryce

Working Effectively with Legacy Code in particular covers best practices
for breaking dependencies so you can isolate a class for testing it.

-Kirk

On Thu, Aug 13, 2015 at 12:55 PM, Roman Shaposhnik ro...@shaposhnik.org
wrote:

 Hi!

 it seems that we're running into various spurious test
 failures. What's the plan to get it back to green again?

 Thanks,
 Roman.

Re: 16 days without a green build

[Kirk Lund]

I've created GEODE-218 Change distributedTest task to fork every 1 test
case for review and group discussion.

-Kirk


On Thu, Aug 13, 2015 at 5:29 PM, Kirk Lund kirk.l...@gmail.com wrote:

 For spurious failures, the problematic tests are predominantly dunit tests
 which are actually end-to-end tests involving 6 jvms. End-to-end tests are
 notorious for having reliability issues. This is magnified by reusing jvms
 from one test case to the next. Eventually, one of the 6 jvms hits a
 problem: 1) a race condition (writting a good distributed test is tricky)
 or 2) a long stop-the-world GC pause which causes a test to fail with a
 timeout or pause long enough to hit a more rare race condition. Since the
 jvms are reused, a test failure is also very likely to pollute the jvm
 which can in turn cause subsequent test failure(s).

 The best overall way to improve the reliability of these dunit tests is to
 fork brand-new jvms for every dunit test case which would force each test
 case to run in isolation. I think changing build.gradle distributedTest
 task from forkEvery 30 to forkEvery 1 would help greatly. I'll file a
 JIRA ticket for forking the dunit jvms every test and propose it on dev.

 Updating dunit to use junit 4 syntax would help a little by allowing us to
 use some newer features and rules that are suitable to integration or
 end-to-end tests. This is already under way with GEODE-217.

 End-to-end tests are important but have some issues:
 1) spurious failures and reliability problems are common
 2) excessive redundant code coverage -- they tend to execute the same 10%
 of the code base 90% of the time
 3) long execution time

 I would be remiss if I didn't use this opportunity to encourage the Geode
 dev community to refocus on writing true unit tests with Mockito or JMock
 while moderating the creation of new dunit (end-to-end) tests.

 We have our automated developer tests categorized as UnitTest,
 IntegrationTest and DistributedTest. True unit tests written using Mockito
 or JMock do result in meaningful, worthwhile tests both as tests and as
 design tools even for a code base such as Geode. These unit tests no less
 important than integration tests or end-to-end tests (both are still
 important and all three provide different types of complementary test
 coverage).

 Lastly a list of my favorite books (so far) on unit testing:

 Working Effectively with Legacy Code by Michael Feathers
 Practical Unit Testing with JUnit and Mockito by Tomek Kaczanowski
 Effective Unit Testing by Lasse Koskela
 Growing Object-Oriented Software, Guided by Tests by Steve Freeman and Nat
 Pryce

 Working Effectively with Legacy Code in particular covers best practices
 for breaking dependencies so you can isolate a class for testing it.

 -Kirk

 On Thu, Aug 13, 2015 at 12:55 PM, Roman Shaposhnik ro...@shaposhnik.org
 wrote:

 Hi!

 it seems that we're running into various spurious test
 failures. What's the plan to get it back to green again?

 Thanks,
 Roman.

Re: Review Request 37321: GEODE-138: remove race condition from testEventDelivery

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37321/#review94801
---



gemfire-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java
 (line 1587)
https://reviews.apache.org/r/37321/#comment149422

Did you want to hardcode to true or add a line to assert the argument is 
true?

Or maybe change the parameter to non-final and have the 1st line of this 
method change it's value to true?


- Kirk Lund


On Aug. 10, 2015, 9:28 p.m., Darrel Schneider wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37321/
 ---
 
 (Updated Aug. 10, 2015, 9:28 p.m.)
 
 
 Review request for geode and Kirk Lund.
 
 
 Bugs: GEODE-138
 https://issues.apache.org/jira/browse/GEODE-138
 
 
 Repository: geode
 
 
 Description
 ---
 
 The race due to the test expecting local event delivery to be synchronous
 but the implementation of off-heap resource manager events being async.
 The test has been changed to always use a wait criteria when waiting
 for a memory event to arrive.
 
 
 Diffs
 -
 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java
  0b704a6955e641e249c00fc0942d4bca214ebbaf 
 
 Diff: https://reviews.apache.org/r/37321/diff/
 
 
 Testing
 ---
 
 Ran MemoryThresholdsOffHeapDUnitTest (it was the only thing modified by this 
 fix).
 
 
 Thanks,
 
 Darrel Schneider
 

Re: Review Request 37486: GEODE-214: better Azul support

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37486/#review95470
---

Ship it!


Ship It!


gemfire-core/src/main/java/com/gemstone/gemfire/internal/SharedLibrary.java 
(line 112)
https://reviews.apache.org/r/37486/#comment150432

I would recommend fixing the indentation of this method. Also need to make 
sure the assumption of compressed oops is not used when using Zing JVM.


- Kirk Lund


On Aug. 14, 2015, 5:22 p.m., Darrel Schneider wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37486/
 ---
 
 (Updated Aug. 14, 2015, 5:22 p.m.)
 
 
 Review request for geode and Kirk Lund.
 
 
 Bugs: GEODE-214
 https://issues.apache.org/jira/browse/GEODE-214
 
 
 Repository: geode
 
 
 Description
 ---
 
 - isTenured now looks for GenPauseless Old Gen for azul.
 - Fatal message about jvm version no longer logged for azul jvm. 
 - Fatal log message about jvm version is now a warning since we continue to 
 run.
 - Fixed a bug in ReflectionSingleObjectSizer in how it calculated the size of 
 a field It was calling Field.getClass instead of Field.getType. 
 Field.getClass always returns and instance of Field.class which the sizer 
 always says is an objref size. getType will return a primitive class for 
 primitive fields which is what we want. 
 - Improved ObjectSizerJUnitTest. 
 - The object header size and reference size are now correctly computed for 
 azul. 
 - Fix tests that are unintentionally spawning processes that use the default 
 mcast-port. This fixes intermittent failures caused by finding another member 
 of the wrong GemFire version.
 
 
 Diffs
 -
 
   gemfire-core/src/main/java/com/gemstone/gemfire/internal/SharedLibrary.java 
 59ab34e8c13e1e47cfb5b918f551b4175855409a 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/MinimumSystemRequirements.java
  d0a346faaf9d9aa3f12ccf289de2bdb6910e3d51 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/HeapMemoryMonitor.java
  fda337b94f34d0ce2c8211152f82609325b29438 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/lang/SystemUtils.java
  f4f111ac0f108b326252786f925a669f85061634 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/size/ReflectionSingleObjectSizer.java
  47b73a8de2db21abd415ba7e71d3fc4eb276eaef 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteFileJUnitTest.java
  b4814619b821f20d7d5c8cab65231f77f3eaf31e 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java
  25aa23cc10dc4037d1b1277127c794be62e2cf79 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherLocalJUnitTest.java
  1addfc89427223b330ce6f476d1b37de7f058dd7 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteFileJUnitTest.java
  3b321edba497e7c2a3d4fb0802128b123218899e 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherWithSpringJUnitTest.java
  dbefdbdc06cd4174321c6483216f8e38ae478cd3 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/internal/size/ObjectSizerJUnitTest.java
  3d6a73189924cfb9a4bb86c81a60be730589ec2a 
 
 Diff: https://reviews.apache.org/r/37486/diff/
 
 
 Testing
 ---
 
 precheckin
 
 
 Thanks,
 
 Darrel Schneider
 

Re: So is it time to dump Hipchat and move to Geode conversations to Slack?

[Kirk Lund]

Did we ever move to Slack? I don't see any further mention of it. It
doesn't look like hipchat is being actively used for Geode anymore.

-Kirk

On Fri, Jul 17, 2015 at 11:26 AM, John Blum jb...@pivotal.io wrote:

 +1 for moving to Slack

 On Fri, Jul 17, 2015 at 11:13 AM, Bruce Schuchardt bschucha...@pivotal.io
 
 wrote:

  If we use Slack, please enable gateway access so we can plug it into
  Thunderbird.
 
  Le 7/17/2015 11:01 AM, Gregory Chase a écrit :
 
  Hi all,
  After than a less than satisfactory experience with HipChat, there's
 been
  talk about moving our chat line to Slack, so  we can at least have a
  history.
 
  Are the contributors in agreement?
 
 
 


 --
 -John
 503-504-8657
 john.blum10101 (skype)

Re: Review Request 36802: GEODE-86: add getDeserializedValue on OperationContext and add unit test coverage

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36802/#review93133
---

Ship it!


Ship It!

- Kirk Lund


On July 24, 2015, 11:54 p.m., Darrel Schneider wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36802/
 ---
 
 (Updated July 24, 2015, 11:54 p.m.)
 
 
 Review request for geode and Kirk Lund.
 
 
 Repository: geode
 
 
 Description
 ---
 
 Added getDeserializedValue and unit test coverage for PutOperationContext 
 getValue, getSerializedValue, and getDeserializedValue.
 Added test coverage for GetOperationContextImpl.
 Management events are now disabled if the distributed system is a loner.
 
 
 Diffs
 -
 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/cache/operations/GetOperationContext.java
  700ae00b6405720399e9d8c70997b39d1a7b5765 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/cache/operations/KeyValueOperationContext.java
  e0fefb952d898cfa47c35077ba0a37e24fd3f33c 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/cache/operations/internal/GetOperationContextImpl.java
  b8e13c60c3578318298d90d142484ff2b1a4e953 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java
  e30b20bab9391d907355b7d62b472c90932db03b 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/cache/operations/PutOperationContextJUnitTest.java
  PRE-CREATION 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/cache/operations/internal/GetOperationContextImplJUnitTest.java
  PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36802/diff/
 
 
 Testing
 ---
 
 precheckin
 
 
 Thanks,
 
 Darrel Schneider
 

Review Request 36866: GEODE-127: Improve reliability and increase execution speed of some tests

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36866/
---

Review request for geode and Darrel Schneider.


Bugs: GEODE-127
https://issues.apache.org/jira/browse/GEODE-127


Repository: geode


Description
---

Recategorize some tests as IntegrationTests. Specially the tests involving 
spawned processes and file system I/O are now IntegrationTests.

Improve reliability and screamline test execution time. Fix up JUnit 4 syntax 
and misc tidying of test code.

Add two new TestSuite classes for targeted testing.


Diffs
-

  
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteJUnitTest.java
 fb0df63 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/ExecutableProcess.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailOutputTestCase.java
 a3995f8 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithErrorInOutputJUnitTest.java
 b3ca93e 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithExtraLineInOutputJUnitTest.java
 1c49749 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithLineMissingFromEndOfOutputJUnitTest.java
 877f671 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithLineMissingFromMiddleOfOutputJUnitTest.java
 629eb7f 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithLoggerErrorInOutputJUnitTest.java
 b485ba4 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithLoggerFatalInOutputJUnitTest.java
 a71ce18 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithLoggerWarnInOutputJUnitTest.java
 211008a 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithProblemInOutputTestCase.java
 5e1552f 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithSevereInOutputJUnitTest.java
 9089545 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithTimeoutOfWaitForOutputToMatchJUnitTest.java
 2417f3d 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithWarningInOutputJUnitTest.java
 89cc7dc 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/GoldenComparator.java
 34c1ce7 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/GoldenStringComparator.java
 75a3398 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/GoldenTestCase.java 
37b4e48 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/GoldenTestFrameworkTestSuite.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/PassJUnitTest.java 
886fc94 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/PassWithExpectedErrorJUnitTest.java
 39267e9 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/PassWithExpectedProblemTestCase.java
 2958007 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/PassWithExpectedSevereJUnitTest.java
 659e807 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/PassWithExpectedWarningJUnitTest.java
 866e8b2 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/RegexGoldenComparator.java
 bc80b3a 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/StringGoldenComparator.java
 5547a9e 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/process/ProcessTestFrameworkTestSuite.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/process/ProcessWrapper.java
 3931b22 
  
gemfire-core/src/test/java/com/gemstone/gemfire/test/process/ProcessWrapperJUnitTest.java
 7c08fcc 
  
gemfire-core/src/test/resources/com/gemstone/gemfire/test/golden/log4j2-test.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/36866/diff/


Testing
---

test, integrationTest and targeted testing of TestSuites


Thanks,

Kirk Lund

Re: Review Request 36695: GEODE-148: change expiration tests to not run so long

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36695/#review92821
---

Ship it!


Ship It!


gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 
(line 3617)
https://reviews.apache.org/r/36695/#comment147062

Did you mean to leave the TODO here?


- Kirk Lund


On July 22, 2015, 4:36 p.m., Darrel Schneider wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36695/
 ---
 
 (Updated July 22, 2015, 4:36 p.m.)
 
 
 Review request for geode and Kirk Lund.
 
 
 Repository: geode
 
 
 Description
 ---
 
 The following tests have been improved to not run so long and to not have 
 intermittent failures.
 One general change is to no longer wait for the actual expiration to happen 
 but instead check the EntryExpiryTask
 to see if the expiration time it reports changed.
   - testEntryTtl3
   - testEntryIdleTimeout3
   - testCustomEntryIdleTimeout3
   - testEntryIdleTtl
   - testRegionIdleInvalidate
   - testUpdateResetsIdleTime 
   - testEntryIdleReset
 
 
 Diffs
 -
 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegion.java
  1dcd9184580f1a6fd8e04283897727ff3aef2f4b 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/ExpiryTask.java
  4e1f64bc952e4fb28cd39be14973538074f25d18 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java
  eab46abd2cf683a4715177445903053101da309e 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java
  003b69157fc2d02b8f6ec9e506f500dfa0c04a26 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionIdleExpiryTask.java
  30d839a26faa7ba6b3ba88bbbe8090c316a0d61c 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionTTLExpiryTask.java
  909af7dd895bfca83958448fb2e5aa5398371446 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java
  dfbc82d7939a923d989233077b66f4de4e23c67f 
   gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 
 c24791ba5187b26bba2e5cc370d71690b5070b42 
   gemfire-core/src/test/java/dunit/DistributedTestCase.java 
 e6f0941893e41cc3da12d70a99fa527c851efe73 
 
 Diff: https://reviews.apache.org/r/36695/diff/
 
 
 Testing
 ---
 
 precheckin
 
 
 Thanks,
 
 Darrel Schneider
 

Re: Review Request 36714: GEODE-143: logging must not cause cached values to be deserialized

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36714/#review92822
---

Ship it!


Ship It!

- Kirk Lund


On July 23, 2015, 12:15 a.m., Darrel Schneider wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36714/
 ---
 
 (Updated July 23, 2015, 12:15 a.m.)
 
 
 Review request for geode and Kirk Lund.
 
 
 Repository: geode
 
 
 Description
 ---
 
 A more powerful StringUtils.forceToString now exists that will also
 print out the elements of arrays. It used to just to a toString on the
 array which only shows the array identity. The new code will (by default)
 show the first 16 element values and after that say how many more the array
 had that are not shown. If you set the sys prop 
 StringUtils.MAX_ARRAY_ELEMENTS_TO_CONVERT
 you can change the default of 16.
 
 
 Diffs
 -
 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java
  809996bb62862895c4de64713ef3347885d3d5b9 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java
  25466dabdbe6e6e189ae465e6a36a122f33a99f9 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/lang/StringUtils.java
  f5a467c3d941a9ea060180666d08ccf3e45fb9ac 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapCachedDeserializable.java
  abba827f86ba37d7257071f48a3def1c604664e1 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/ChunkValueWrapperJUnitTest.java
  229719f59bbf7db83647e9b25b36a8ba48c446bf 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/internal/lang/StringUtilsJUnitTest.java
  1420fbd977b4a1361213a2baf54947afd8aa00b7 
 
 Diff: https://reviews.apache.org/r/36714/diff/
 
 
 Testing
 ---
 
 precheckin
 
 
 Thanks,
 
 Darrel Schneider
 

Re: Review Request 36533: GEODE-128: fix expiration tests to run faster with PR regions

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36533/#review92819
---

Ship it!


Ship It!

- Kirk Lund


On July 16, 2015, 12:11 a.m., Darrel Schneider wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36533/
 ---
 
 (Updated July 16, 2015, 12:11 a.m.)
 
 
 Review request for geode and Kirk Lund.
 
 
 Bugs: GEODE-128
 https://issues.apache.org/jira/browse/GEODE-128
 
 
 Repository: geode
 
 
 Description
 ---
 
 Slowdown was caused by the test hook EXPIRY_UNITS_MS not being set
 to true on a BucketRegion. BucketRegion does all the expiration on
 a PR. The test was setting it on the bucket's parent but not no the
 bucket itself. Bucket's now defer to their parent when initializing
 this final field.
 
 
 Diffs
 -
 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java
  02becb968eb5bd2d18029f905a0c0ce5f7c46d20 
   gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 
 8b22db8353dab81ab5c38cc1b95cd139b548d5e0 
 
 Diff: https://reviews.apache.org/r/36533/diff/
 
 
 Testing
 ---
 
 precheckin
 
 
 Thanks,
 
 Darrel Schneider
 

Re: Review Request 36747: GEODE-152: fix NPE in fetchJvmThreads

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36747/#review92926
---

Ship it!


Ship It!

- Kirk Lund


On July 23, 2015, 9:49 p.m., Darrel Schneider wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36747/
 ---
 
 (Updated July 23, 2015, 9:49 p.m.)
 
 
 Review request for geode and Kirk Lund.
 
 
 Repository: geode
 
 
 Description
 ---
 
 The code now uses an ArrayList and only adds non-null elements to it.
 It then allocates a array of that ArrayList size and returns it with
 the contents of the ArrayList.
 
 
 Diffs
 -
 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/beans/MemberMBeanBridge.java
  6a2d0850d40dac2ef247d021fb8ee755afc02dd8 
 
 Diff: https://reviews.apache.org/r/36747/diff/
 
 
 Testing
 ---
 
 MemberMBeanAttributesDUnitTest (this code that calls fetchJvmThreads).
 
 
 Thanks,
 
 Darrel Schneider
 

Re: Review Request 36750: GEODE-153: fix race in testRemoteCacheListener

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36750/#review92956
---

Ship it!


Ship It!

- Kirk Lund


On July 24, 2015, 4:23 p.m., Darrel Schneider wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36750/
 ---
 
 (Updated July 24, 2015, 4:23 p.m.)
 
 
 Review request for geode and Kirk Lund.
 
 
 Repository: geode
 
 
 Description
 ---
 
 Both testRemoteCacheListener and testRemoteCacheListenerInSubregion used 
 sleeps
 to try to avoid no-ack races. Both tests now use a wait criteria.
 
 
 Diffs
 -
 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java
  dfbc82d7939a923d989233077b66f4de4e23c67f 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/cache30/TestCacheCallback.java
  a252059a813d937e53c8cdfcecee724ff48d7f07 
 
 Diff: https://reviews.apache.org/r/36750/diff/
 
 
 Testing
 ---
 
 MultiVMRegionTestCase tests
 
 
 Thanks,
 
 Darrel Schneider
 

Re: Review Request 36594: Adding try-with-resources for Cache

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36594/#review92925
---

Ship it!


Ship It!

- Kirk Lund


On July 23, 2015, 6:19 a.m., William Markito wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36594/
 ---
 
 (Updated July 23, 2015, 6:19 a.m.)
 
 
 Review request for geode, Darrel Schneider and Kirk Lund.
 
 
 Bugs: GEODE-144
 https://issues.apache.org/jira/browse/GEODE-144
 
 
 Repository: geode
 
 
 Description
 ---
 
 Adding try-with-resources for Cache
 
 
 Diffs
 -
 
   gemfire-core/src/main/java/com/gemstone/gemfire/cache/RegionService.java 
 9ea65c0 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/cache/RegionFactoryJUnitTest.java
  151e9c8 
 
 Diff: https://reviews.apache.org/r/36594/diff/
 
 
 Testing
 ---
 
 Added JUnit test
 Ran test suite/build.
 
 
 Thanks,
 
 William Markito
 

Re: Review Request 36695: GEODE-148: change expiration tests to not run so long

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36695/#review92927
---

Ship it!


Ship It!

- Kirk Lund


On July 22, 2015, 4:36 p.m., Darrel Schneider wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36695/
 ---
 
 (Updated July 22, 2015, 4:36 p.m.)
 
 
 Review request for geode and Kirk Lund.
 
 
 Repository: geode
 
 
 Description
 ---
 
 The following tests have been improved to not run so long and to not have 
 intermittent failures.
 One general change is to no longer wait for the actual expiration to happen 
 but instead check the EntryExpiryTask
 to see if the expiration time it reports changed.
   - testEntryTtl3
   - testEntryIdleTimeout3
   - testCustomEntryIdleTimeout3
   - testEntryIdleTtl
   - testRegionIdleInvalidate
   - testUpdateResetsIdleTime 
   - testEntryIdleReset
 
 
 Diffs
 -
 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegion.java
  1dcd9184580f1a6fd8e04283897727ff3aef2f4b 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/ExpiryTask.java
  4e1f64bc952e4fb28cd39be14973538074f25d18 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java
  eab46abd2cf683a4715177445903053101da309e 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java
  003b69157fc2d02b8f6ec9e506f500dfa0c04a26 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionIdleExpiryTask.java
  30d839a26faa7ba6b3ba88bbbe8090c316a0d61c 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionTTLExpiryTask.java
  909af7dd895bfca83958448fb2e5aa5398371446 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java
  dfbc82d7939a923d989233077b66f4de4e23c67f 
   gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 
 c24791ba5187b26bba2e5cc370d71690b5070b42 
   gemfire-core/src/test/java/dunit/DistributedTestCase.java 
 e6f0941893e41cc3da12d70a99fa527c851efe73 
 
 Diff: https://reviews.apache.org/r/36695/diff/
 
 
 Testing
 ---
 
 precheckin
 
 
 Thanks,
 
 Darrel Schneider
 

Apache Jenkins question

[Kirk Lund]

Does anyone know why the Apache Jenkins does not show details on test
failures?

Our internal Jenkins has a Test Result link with links for each test
failure that you can follow to see detailed info on the test. Apache
Jenkins doesn't have this and the only way I can see results is in Console
Output which is primitive and doesn't show test history or anything else.

-Kirk

Re: Nightly build test failures

[Kirk Lund]

Yep, #127 completed after I'd typed up my email and filed several tickets.
#127 passed completely. Looks like #126 ran out of memory while gathering
test results for reports so I'll file a ticket on that. I'll also
individually review and test the distributed tests that failed in #126
before closing out any tickets I filed.

-Kirk


On Tue, Jul 14, 2015 at 9:53 AM, Ashvin A aas@gmail.com wrote:

 Seems builds fails on ubuntu hosts :-?

  https://builds.apache.org/view/All/job/Geode-nightly/buildTimeTrend#
 
 Build  ↑
 https://builds.apache.org/view/All/job/Geode-nightly/buildTimeTrend#
 Duration
 https://builds.apache.org/view/All/job/Geode-nightly/buildTimeTrend#
 Slave
 https://builds.apache.org/view/All/job/Geode-nightly/buildTimeTrend#
 [image:
 In progress]#128 
 https://builds.apache.org/view/All/job/Geode-nightly/128/9
 min 52 sec and countingubuntu-2
 https://builds.apache.org/computer/ubuntu-2[image: Success]#127
 https://builds.apache.org/view/All/job/Geode-nightly/127/6 hr 59 minH7
 https://builds.apache.org/computer/H7[image: Failed]#126
 https://builds.apache.org/view/All/job/Geode-nightly/126/7 hr 8 min
 ubuntu-1 https://builds.apache.org/computer/ubuntu-1[image: Failed]#125
 https://builds.apache.org/view/All/job/Geode-nightly/125/7 hr 14 min
 ubuntu-1 https://builds.apache.org/computer/ubuntu-1[image: Failed]#124
 https://builds.apache.org/view/All/job/Geode-nightly/124/7 hr 0 min
 ubuntu-1 https://builds.apache.org/computer/ubuntu-1[image: Failed]#123
 https://builds.apache.org/view/All/job/Geode-nightly/123/6 hr 55 min
 ubuntu3 https://builds.apache.org/computer/ubuntu3

 On Tue, Jul 14, 2015 at 9:44 AM, Anthony Baker aba...@pivotal.io wrote:

  Looks like #127 didn’t have any failures.
 
 
  Changes
  GEODE-16 https://issues.apache.org/jira/browse/GEODE-16 [DISTTX]
  Bringing pending changes for distributed transactions (still work in
  progress) from one of the internal gemfire branch (develop_dist_tx) to
 ASF
  i.e. (detail 
  https://builds.apache.org/job/Geode-nightly/127/changes#detail0)
  GEODE-16 https://issues.apache.org/jira/browse/GEODE-16 Fixing a
  failure of AnalyzeSerializablesJUnitTest.testDataSerializables that got
  introduced in my last checkin
 (1f6462876fe4056e820db74cfc7db8af70f7a01f).wq
  (detail https://builds.apache.org/job/Geode-nightly/127/changes#detail1
 )
 
 
  Anthony
 
 
   On Jul 14, 2015, at 9:29 AM, Kirk Lund kl...@pivotal.io wrote:
  
   Looks like we have nightly build failures. I think this means we need
 to
   freeze all checkins and work to stabilize these test failures:
  
  
 
 https://builds.apache.org/view/All/job/Geode-nightly/lastFailedBuild/console
  
   Jenkins also ran out of memory trying to archive test results. Any
 ideas
   what to do about that?
  
   ERROR: Failed to archive test reportsjava.io.IOException
   http://stacktrace.jenkins-ci.org/search?query=java.io.IOException:
   remote file operation failed:
   /home/jenkins/jenkins-slave/workspace/Geode-nightly at
   hudson.remoting.Channel@18a56604:ubuntu-1
 at hudson.FilePath.act(FilePath.java:916)
   
 
 http://stacktrace.jenkins-ci.org/search/?query=hudson.FilePath.actentity=method
  
 at hudson.FilePath.act(FilePath.java:893)
   
 
 http://stacktrace.jenkins-ci.org/search/?query=hudson.FilePath.actentity=method
  
 at hudson.tasks.junit.JUnitParser.parse(JUnitParser.java:87)
   
 
 http://stacktrace.jenkins-ci.org/search/?query=hudson.tasks.junit.JUnitParser.parseentity=method
  
 at
 
 hudson.tasks.junit.JUnitResultArchiver.parse(JUnitResultArchiver.java:117)
   
 
 http://stacktrace.jenkins-ci.org/search/?query=hudson.tasks.junit.JUnitResultArchiver.parseentity=method
  
 at
 
 hudson.tasks.junit.JUnitResultArchiver.perform(JUnitResultArchiver.java:129)
   
 
 http://stacktrace.jenkins-ci.org/search/?query=hudson.tasks.junit.JUnitResultArchiver.performentity=method
  
 at
  hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
   
 
 http://stacktrace.jenkins-ci.org/search/?query=hudson.tasks.BuildStepMonitor$1.performentity=method
  
 at
 
 hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:756)
   
 
 http://stacktrace.jenkins-ci.org/search/?query=hudson.model.AbstractBuild$AbstractBuildExecution.performentity=method
  
 at
 
 hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:720)
   
 
 http://stacktrace.jenkins-ci.org/search/?query=hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildStepsentity=method
  
 at hudson.model.Build$BuildExecution.post2(Build.java:182)
   
 
 http://stacktrace.jenkins-ci.org/search/?query=hudson.model.Build$BuildExecution.post2entity=method
  
 at
 
 hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:669)
   
 
 http://stacktrace.jenkins-ci.org/search/?query=hudson.model.AbstractBuild$AbstractBuildExecution.postentity=method

Re: git flow feature publish GEODE-nn step fails

[Kirk Lund]

It's working fine now. The networking problem seems to have been specific
to the LAN here in the office.

-Kirk

On Mon, Jul 13, 2015 at 12:11 PM, Dan Smith dsm...@pivotal.io wrote:

 It looks like we're running into networking problems here at pivotal, I
 think the git flow command is doing the right thing but you are not able to
 connect to the apache git server.

 -Dan

 On Mon, Jul 13, 2015 at 12:01 PM, Kirk Lund kl...@pivotal.io wrote:

  I had no trouble doing git fetch and starting a feature branch, but now
  that I'm ready to publish the feature branch and track it from another
  machine to run more tests, it seems that some step was missed and git
  complains that the branch doesn't exist on remote 'origin'
 
  *$ git flow feature start GEODE-94*
  Switched to a new branch 'feature/GEODE-94'
 
  Summary of actions:
  - A new branch 'feature/GEODE-94' was created, based on 'develop'
  - You are now on branch 'feature/GEODE-94'
 
  Now, start committing on your feature. When done, use:
 
   git flow feature finish GEODE-94
 
  *$ git status*
  On branch feature/GEODE-94
  Changes not staged for commit:
(use git add file... to update what will be committed)
(use git checkout -- file... to discard changes in working
 directory)
 
  modified:
 
 
 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/jgroup/JGroupMembershipManager.java
  modified:
 
 gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/FRAG2.java
  modified:
 
 gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/SMACK.java
  modified:
 
 
 gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/UDP_NIO.java
  modified:
 
 
 gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/VIEW_ENFORCER.java
 
  Untracked files:
(use git add file... to include in what will be committed)
 
  GEODE-97.diff
 
  no changes added to commit (use git add and/or git commit -a)
 
  *$ git add
 
 
 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/jgroup/JGroupMembershipManager.java
 
 gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/FRAG2.java
 
 gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/SMACK.java
 
 
 gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/UDP_NIO.java
 
 
 gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/VIEW_ENFORCER.java*
 
  *$ git commit*
  [feature/GEODE-94 2adb158] GEODE-94: Add typecast to prevent ambiguous
  method calls under JDK 8
   5 files changed, 6 insertions(+), 7 deletions(-)
 
  *$ git log*
  commit 2adb1588cce967c2a4149fa674d431871a3066fd
  Author: Kirk Lund kl...@pivotal.io
  Date:   Mon Jul 13 11:44:21 2015 -0700
 
  GEODE-94: Add typecast to prevent ambiguous method calls under JDK 8
 
  Add typecast to Object for ambiguous logger arguments.
 
  *$ git flow feature publish GEODE-94*
  fatal: unable to access '
  https://git-wip-us.apache.org/repos/asf/incubator-geode.git/': Unknown
 SSL
  protocol error in connection to git-wip-us.apache.org:443
  Fatal: Could not fetch branch 'feature/GEODE-94' from remote 'origin'.
 
  Our notes imply that git flow feature publish GEODE-nn is the same git
  push -u origin feature/GEODE-nn but this seems to be incorrect. It seems
  like git is complaining that no such branch exists on remote 'origin'
 which
  means we're missing a push in our workflow writeup. It would seem that
  there must be a push *BEFORE *attempting git flow publish GEODE-nn.
 
  Here are the relevant steps in our workflow writeup (something is
 obviously
  missing):
 
  5) start the feature branch for GEODE-nn
  git flow feature start GEODE-nn
 
  *Without git flow:*
  *git checkout develop*
  *git pull --rebase*
  *git checkout -b feature/GEODE-nn*
 
  6) work on the changes and tests for GEODE-nn (include GEODE-nn in commit
  messages)
 
  7) [optional] publish the feature branch to share with others or other
  machine
  git flow feature publish GEODE-nn
 
  *Without git flow:*
  *git push -u origin feature/GEODE-nn*
 
  -Kirk
 

git flow feature publish GEODE-nn step fails

[Kirk Lund]

I had no trouble doing git fetch and starting a feature branch, but now
that I'm ready to publish the feature branch and track it from another
machine to run more tests, it seems that some step was missed and git
complains that the branch doesn't exist on remote 'origin'

*$ git flow feature start GEODE-94*
Switched to a new branch 'feature/GEODE-94'

Summary of actions:
- A new branch 'feature/GEODE-94' was created, based on 'develop'
- You are now on branch 'feature/GEODE-94'

Now, start committing on your feature. When done, use:

 git flow feature finish GEODE-94

*$ git status*
On branch feature/GEODE-94
Changes not staged for commit:
  (use git add file... to update what will be committed)
  (use git checkout -- file... to discard changes in working directory)

modified:
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/jgroup/JGroupMembershipManager.java
modified:
gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/FRAG2.java
modified:
gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/SMACK.java
modified:
gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/UDP_NIO.java
modified:
gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/VIEW_ENFORCER.java

Untracked files:
  (use git add file... to include in what will be committed)

GEODE-97.diff

no changes added to commit (use git add and/or git commit -a)

*$ git add
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/jgroup/JGroupMembershipManager.java
gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/FRAG2.java
gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/SMACK.java
gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/UDP_NIO.java
gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/VIEW_ENFORCER.java*

*$ git commit*
[feature/GEODE-94 2adb158] GEODE-94: Add typecast to prevent ambiguous
method calls under JDK 8
 5 files changed, 6 insertions(+), 7 deletions(-)

*$ git log*
commit 2adb1588cce967c2a4149fa674d431871a3066fd
Author: Kirk Lund kl...@pivotal.io
Date:   Mon Jul 13 11:44:21 2015 -0700

GEODE-94: Add typecast to prevent ambiguous method calls under JDK 8

Add typecast to Object for ambiguous logger arguments.

*$ git flow feature publish GEODE-94*
fatal: unable to access '
https://git-wip-us.apache.org/repos/asf/incubator-geode.git/': Unknown SSL
protocol error in connection to git-wip-us.apache.org:443
Fatal: Could not fetch branch 'feature/GEODE-94' from remote 'origin'.

Our notes imply that git flow feature publish GEODE-nn is the same git
push -u origin feature/GEODE-nn but this seems to be incorrect. It seems
like git is complaining that no such branch exists on remote 'origin' which
means we're missing a push in our workflow writeup. It would seem that
there must be a push *BEFORE *attempting git flow publish GEODE-nn.

Here are the relevant steps in our workflow writeup (something is obviously
missing):

5) start the feature branch for GEODE-nn
git flow feature start GEODE-nn

*Without git flow:*
*git checkout develop*
*git pull --rebase*
*git checkout -b feature/GEODE-nn*

6) work on the changes and tests for GEODE-nn (include GEODE-nn in commit
messages)

7) [optional] publish the feature branch to share with others or other
machine
git flow feature publish GEODE-nn

*Without git flow:*
*git push -u origin feature/GEODE-nn*

-Kirk

Re: Review Request 36415: GEODE-75: System property to Rebalance multiple regions in parallel

[Kirk Lund]

That's good enough!

Thanks,
Kirk


On Mon, Jul 13, 2015 at 10:28 AM, Dan Smith dsm...@pivotal.io wrote:



  On July 13, 2015, 4:30 p.m., Kirk Lund wrote:
  
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/InternalResourceManager.java,
 line 62
   
 https://reviews.apache.org/r/36415/diff/1/?file=1008813#file1008813line62
  
   Please make sure that all new system properties are testable. I
 can't tell for sure if this one is or not. What I mean by this is that two
 different tests running without forking the JUnit JVM should be able to
 have two different values.

 This property can be reset by closing the cache and opening the cache.
 It's a non-static field on an object owned by GemFireCacheImpl. The
 RebalanceOperationDUnitTest does this - it clears the system property in
 the tearDown so that it doesn't affect the next test.

 Is that good enough, or would it be better for this property to not be
 final?


 - Dan


 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36415/#review91484
 ---


 On July 11, 2015, 12:28 a.m., Dan Smith wrote:
 
  ---
  This is an automatically generated e-mail. To reply, visit:
  https://reviews.apache.org/r/36415/
  ---
 
  (Updated July 11, 2015, 12:28 a.m.)
 
 
  Review request for geode, Darrel Schneider and Hitesh Khamesra.
 
 
  Repository: geode
 
 
  Description
  ---
 
  Allow multiple regions to be rebalanced in parallel, by setting
  gemfire.resource.manager.threads to something greater than 1.
 
 
  Diffs
  -
 
 
  
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/InternalResourceManager.java
 d144aaf0adab2fcfae54c71e6d4e886ee05884d5
 
  
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/RebalanceOperationImpl.java
 be4d8247c288dc12b5566ab80ba7571936649c30
 
  
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/RebalanceResultsImpl.java
 a74017b512ab6a319b63bd8ee09c6913fd1cd3ce
 
  
 gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/control/RebalanceOperationDUnitTest.java
 a80cb9bdcbac800ab39b722a25480a59f81dd1c2
 
  Diff: https://reviews.apache.org/r/36415/diff/
 
 
  Testing
  ---
 
 
  Thanks,
 
  Dan Smith
 
 

Re: Review Request 36416: GEODE-56 Decrementing bytesOverflowedOnDisk when an update happens to an evicted entry.

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36416/#review91481
---



gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionStatsJUnitTest.java
 (line 265)
https://reviews.apache.org/r/36416/#comment144864

This test uses JUnit 4 syntax (it doesn't extend TestCase) so all test 
methods require an @Test annotation or nothing will be executed. We may need to 
beef up checkMissedTests to look for this as well as missing categories.


- Kirk Lund


On July 11, 2015, 12:26 a.m., Dan Smith wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36416/
 ---
 
 (Updated July 11, 2015, 12:26 a.m.)
 
 
 Review request for geode, Darrel Schneider and Hitesh Khamesra.
 
 
 Repository: geode
 
 
 Description
 ---
 
 For persistent regions, we were correctly updating this stat. But for
 non persistent regions we did not read the old size on disk, so we were
 not updating the stat.
 
 If the entry was in the async queue, we only increment the stat once
 when the final value is actually written to disk. So we will only
 decrement the stat if the oldValue is not pending asynchronous write to
 disk.
 
 I'm still seeing issues with the entryCount. I've tracked this down to
 what I think is a problem with tombstones. It appears when we modify an
 entry that is a tombstone, we increment the entry count once for the new
 value, and once for removing the tombstone. But I'm not sure if that is
 the full story.
 
 
 Diffs
 -
 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java
  b46d897e693b397799533662ddeca6c0438ac49e 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java 
 b67d0f10c63a19307288d5c6f2f9538eb280bfe4 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionStatsJUnitTest.java
  3711329883e4f7f411c4389872f4ad9426a4122f 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionTestHelper.java
  5db33b6ea08548af1108cf42c8182562ad01 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/control/RebalanceOperationDUnitTest.java
  a80cb9bdcbac800ab39b722a25480a59f81dd1c2 
 
 Diff: https://reviews.apache.org/r/36416/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Dan Smith
 

Re: Review Request 36395: GEODE-90: IN SET Query using Index throws IllegalArgumentException

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36395/#review91475
---

Ship it!


Ship It!

- Kirk Lund


On July 10, 2015, 5:11 p.m., Jason Huynh wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36395/
 ---
 
 (Updated July 10, 2015, 5:11 p.m.)
 
 
 Review request for geode, anilkumar gingade, Jianxia Chen, and Qihong Chen.
 
 
 Bugs: GEODE-90
 https://issues.apache.org/jira/browse/GEODE-90
 
 
 Repository: geode
 
 
 Description
 ---
 
 The issue was that while iterating through indexed objects, if an object 
 satisfied the query filter, the entire collection was being added to the 
 result set which caused an exception because it should have been the object 
 and not the collection of objects.
 
 
 Diffs
 -
 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/AbstractIndex.java
  2ab3dd8 
   
 gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/RangeIndexAPIJUnitTest.java
  9d9c09f 
 
 Diff: https://reviews.apache.org/r/36395/diff/
 
 
 Testing
 ---
 
 build (some failing tests but unrelated to querying.  Will look into 
 rerunning those tests)
 
 
 Thanks,
 
 Jason Huynh
 

Review Request 36454: Typecast ambiguous logger arguments to allow JDK 8 compilation

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36454/
---

Review request for geode.


Bugs: GEODE-94
https://issues.apache.org/jira/browse/GEODE-94


Repository: geode


Description
---

A small number of log statements have an ambiguous argument under JDK 1.8. 
Casting these to (Object) fixes compilation.


Diffs
-

  
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/jgroup/JGroupMembershipManager.java
 9c2d9fd 
  gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/FRAG2.java 
0749859 
  gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/SMACK.java 
95ca1f1 
  gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/UDP_NIO.java 
573d461 
  
gemfire-jgroups/src/main/java/com/gemstone/org/jgroups/protocols/VIEW_ENFORCER.java
 426b8b4 

Diff: https://reviews.apache.org/r/36454/diff/


Testing
---

Run existing UnitTest, IntegrationTest, DistributedTest suites


Thanks,

Kirk Lund

Jenkins other testing failures last week

[Kirk Lund]

Please join in and select a ticket from the 1st group to assign to
yourself. We need to make each of these tests more reliable. Please remove
any Thread sleep calls or other actions that can cause a test to
intermittently fail.

Filed with no assignee yet:
GEODE-140
QueryUsingFunctionContextDUnitTest.testQueriesWithFilterKeysOnPRWithRebalancing
failed due to suspect string
GEODE-122 Suspect string from
ClientServerFunctionExecutionDUnitTest.testServerExecution_SocketTimeOut_WithoutRegister
GEODE-116 CopyOnReadIndexDUnitTest.testPRQueryOnLocalNode fails assertion
GEODE-111 DistributedAckPersistentRegionCCEDUnitTest failed with
DistributedSystemDisconnectedException
GEODE-99 BackupInspectorJUnitTest.testIncrementalBackupScript fails on
Windows
GEODE-98 OplogRVVJUnitTest.testRecoverRVV fails on Windows

Filed and assigned:
[Darrel] GEODE-143 PdxDeserializationDUnitTest and PdxClientServerDUnitTest
failing because debug level logging left enabled by previous test
[Kirk]   GEODE-142 ThreadUtilsJUnitTest.testSleepWithInterrupt failed
time-sensitive assertion
[Vivek]  GEODE-141
DistributedTransactionDUnitTest.testRemoveAllWithTransactions fails with
CommitIncompleteException
[Dan]GEODE-139 RebalanceOperationDUnitTest testWaitFor* methods failed
in nightly build
[Darrel] GEODE-138 MemoryThresholdsOffHeapDUnitTest.testEventDelivery failed
[Ashvin] GEODE-134 AnalyzeSerializablesJUnitTest is failing after hdfs api
changes
[Darrel] GEODE-133 testCustomEntryTtl3 RegionTestCase method takes too long
and does not validate correctly
[Kirk]   GEODE-127 FailWithTimeoutOfWaitForOutputToMatchJUnitTest takes too
long to execute
[Vivek]  GEODE-110
DistributedTransactionDUnitTest.testPutAllWithTransactions failed with
CommitIncompleteException
[Kirk]   GEODE-103 BlockingProcessStreamReaderJUnitTest fails to start
process within timeout

Filed and Resolved:
[Darrel] GEODE-128 Many expiration unit tests take too long to run on any
type of PartitionedRegion
[Darrel] GEODE-113
BridgeMembershipDUnitTest.testBridgeMembershipEventsInClient unit test
takes too long to run
[Kirk]   GEODE-108 HAInterestPart2DUnitTest.testInterestRecoveryFailure
failed with suspect string

Re: Review Request 39023: GEODE-381 enable gfsh https usage through SSL terminated environments

[Kirk Lund]

This is from the old Ant build (which Geode doesn't use):

$build.sh run-management-tests -DuseHTTP=true

What's the counterpart in the Geode gradle build?

-Kirk


On Thu, Oct 22, 2015 at 11:55 AM, John Blum  wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39023/#review103635
> ---
>
>
> You will also need to run the Management test suite using HTTP (especially
> for v8.x and earlier) with...
>
> $build.sh run-management-tests -DuseHTTP=true
>
> This will run all the Manager/Gfsh commands over HTTP using the Management
> REST API.  I am not exactly sure how to do this with the Apache Geode
> codebase and Gradle build, or even if the Management test suite is part of
> the Apache Geode codebase yet.
>
>
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java
> (line 255)
> 
>
> Make the "scheme" parameter final for consistency.
>
> Typically, you should add parameters to the end of the method
> parameter list and also include a method such as...
>
> protected static final String DEFAULT_SCHEME = "http";
>
> ...
>
> protected URI toUri(final String path) {
>   return toUri(path, DEFAULT_SCHEME);
> }
>
> This will help minimize the necessary code changes in areas of the
> code that are not affected by the scheme.
>
>
>
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java
> (line 256)
> 
>
> Structure as...
>
> return
> ServletUriComponentsBuilder.fromCurrentContextPath().scheme(scheme)
> .path(REST_API_VERSION).path(path).build().toUri();
>
>
>
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/ShellCommandsController.java
> (line 146)
> 
>
> Make the "scheme" parameter final for consistency.
>
>
>
> gemfire-web/src/test/java/com/gemstone/gemfire/management/internal/web/controllers/ShellCommandsControllerJUnitTest.java
> (line 215)
> 
>
> +1
>
>
> - John Blum
>
>
> On Oct. 5, 2015, 10:10 p.m., Jens Deppe wrote:
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/39023/
> > ---
> >
> > (Updated Oct. 5, 2015, 10:10 p.m.)
> >
> >
> > Review request for geode and John Blum.
> >
> >
> > Repository: geode
> >
> >
> > Description
> > ---
> >
> > GEODE-381 enable gfsh https usage through SSL terminated environments
> >
> >
> > Diffs
> > -
> >
> >
>  
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java
> 4bdab90ef905731c19568b0d7638ebb5bbe577bb
> >
>  
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java
> 73ce9265eb0f4d260b18919d3478738656fec073
> >
>  
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/ShellCommandsController.java
> ef4c49f1a5434cfae1e7fac2db3577cef7a0c834
> >   gemfire-web/build.gradle b9629d30a66d70e9283987ab2db8d4bb2b2f08a1
> >
>  
> gemfire-web/src/test/java/com/gemstone/gemfire/management/internal/web/controllers/ShellCommandsControllerJUnitTest.java
> 34aa28589cf1c30dbf37abe1c17f92749dea835a
> >
> > Diff: https://reviews.apache.org/r/39023/diff/
> >
> >
> > Testing
> > ---
> >
> > Ran Management JUnit tests
> >
> >
> > Thanks,
> >
> > Jens Deppe
> >
> >
>
>

Re: Review Request 39023: GEODE-381 enable gfsh https usage through SSL terminated environments

[Kirk Lund]

This would similar to having to rerun all of the "region" tests with a
system property specifying "replicated" or "partitioned". Perhaps all of
the management (integration or distributed) tests that have an HTTP REST
counterpart need to be subclassed with a test case that overrides some bit
of configuration to use HTTP REST instead of JMX RMI. In this way, the same
test would be executed but configured in a different way.

-Kirk


On Thu, Oct 22, 2015 at 1:35 PM, John Blum <jb...@pivotal.io> wrote:

> Well, there are 2 scenarios under which Management tests should run, 1 with
> JMX RMI and the other with HTTP.  So you you will need to incorporate some
> elaborate code in the Gradle-based build to handle this and capture the
> results without stomping on nearly identical runs, since it share the same
> test classes.
>
> So while I agree with your statement, it does not solve the problem by
> simply saying the tests should be run without a special flag.
>
>
> On Thu, Oct 22, 2015 at 1:31 PM, Dan Smith <dsm...@pivotal.io> wrote:
>
> > I don't think there is a counterpart in the gradle build. And I don't
> > think there should be - if this is something that needs to be tested it
> > should be running in every nightly build, not just when you pass a
> special
> > flag.
> >
> > -Dan
> >
> > On Thu, Oct 22, 2015 at 12:12 PM, Kirk Lund <kl...@pivotal.io> wrote:
> >
> >> This is from the old Ant build (which Geode doesn't use):
> >>
> >> $build.sh run-management-tests -DuseHTTP=true
> >>
> >> What's the counterpart in the Geode gradle build?
> >>
> >> -Kirk
> >>
> >>
> >> On Thu, Oct 22, 2015 at 11:55 AM, John Blum <jb...@pivotal.io> wrote:
> >>
> >> >
> >> > ---
> >> > This is an automatically generated e-mail. To reply, visit:
> >> > https://reviews.apache.org/r/39023/#review103635
> >> > ---
> >> >
> >> >
> >> > You will also need to run the Management test suite using HTTP
> >> (especially
> >> > for v8.x and earlier) with...
> >> >
> >> > $build.sh run-management-tests -DuseHTTP=true
> >> >
> >> > This will run all the Manager/Gfsh commands over HTTP using the
> >> Management
> >> > REST API.  I am not exactly sure how to do this with the Apache Geode
> >> > codebase and Gradle build, or even if the Management test suite is
> part
> >> of
> >> > the Apache Geode codebase yet.
> >> >
> >> >
> >> >
> >>
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java
> >> > (line 255)
> >> > <https://reviews.apache.org/r/39023/#comment161695>
> >> >
> >> > Make the "scheme" parameter final for consistency.
> >> >
> >> > Typically, you should add parameters to the end of the method
> >> > parameter list and also include a method such as...
> >> >
> >> > protected static final String DEFAULT_SCHEME = "http";
> >> >
> >> > ...
> >> >
> >> > protected URI toUri(final String path) {
> >> >   return toUri(path, DEFAULT_SCHEME);
> >> > }
> >> >
> >> > This will help minimize the necessary code changes in areas of the
> >> > code that are not affected by the scheme.
> >> >
> >> >
> >> >
> >> >
> >>
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java
> >> > (line 256)
> >> > <https://reviews.apache.org/r/39023/#comment161703>
> >> >
> >> > Structure as...
> >> >
> >> > return
> >> > ServletUriComponentsBuilder.fromCurrentContextPath().scheme(scheme)
> >> > .path(REST_API_VERSION).path(path).build().toUri();
> >> >
> >> >
> >> >
> >> >
> >>
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/ShellCommandsController.java
> >> > (line 146)
> >> > <https://reviews.apache.org/r/39023/#comment161700>
> >> >
> >> > Make the "scheme" parameter final for consistency.
> >> >
> >&g

Geode Bug Squashathon Day Three (Wednesday)

[Kirk Lund]

On the third day of Geode Bug Squashathon (Wed) we had our 1st GREEN build
of DistributedTests this week! We had 11 volunteers fixing 4 tickets (12
more remained in progress by end of day). The UnitTests and
IntegrationTests remained green for us except for 1 failure in
IntegrationTests. We had several Jenkins jobs that failed for reasons
outside of Geode tests. Most of the DistributedTests builds continued to
see 1-5 test failures each run. We're continuing to fix bugs (race
conditions, etc) in the test code itself. One failure turned out to be a
product bug (GEODE-370).

Geode Builds (since we began Mon):
UnitTests: 25 PASS, 2 FAIL
IntegrationTests: 111 PASS, 14 FAIL
DistributedTests: 1 PASS, 47 FAIL

Geode JIRA Tickets:
Previously Open: 52
Filed: Mon: 17, Tues: 15, Wed: 5
Fixed: Mon: 12, Tues: 3, Wed: 4
In Progress: 12

Remaining Open (end of day Wed): 56

Thanks,
Kirk

Re: Review Request 39023: GEODE-381 enable gfsh https usage through SSL terminated environments

[Kirk Lund]

If you want to use annotations or other JUnit 4 syntax in a DUnit, it'll
have to wait until after I merge feature/GEODE-217 to develop. We'll also
need an engineer to spend one or more weeks updating all of the relevant
management dunit tests to use JUnit 4 syntax.

-Kirk


On Thu, Oct 22, 2015 at 1:53 PM, Anthony Baker <aba...@pivotal.io> wrote:

> Can we apply the @Parameterized annotation here?  Two code paths, one test
> (as the old saying goes…)
>
> Anthony
>
> > On Oct 22, 2015, at 1:46 PM, Kirk Lund <kl...@pivotal.io> wrote:
> >
> > This would similar to having to rerun all of the "region" tests with a
> > system property specifying "replicated" or "partitioned". Perhaps all of
> > the management (integration or distributed) tests that have an HTTP REST
> > counterpart need to be subclassed with a test case that overrides some
> bit
> > of configuration to use HTTP REST instead of JMX RMI. In this way, the
> same
> > test would be executed but configured in a different way.
> >
> > -Kirk
> >
> >
> > On Thu, Oct 22, 2015 at 1:35 PM, John Blum <jb...@pivotal.io> wrote:
> >
> >> Well, there are 2 scenarios under which Management tests should run, 1
> with
> >> JMX RMI and the other with HTTP.  So you you will need to incorporate
> some
> >> elaborate code in the Gradle-based build to handle this and capture the
> >> results without stomping on nearly identical runs, since it share the
> same
> >> test classes.
> >>
> >> So while I agree with your statement, it does not solve the problem by
> >> simply saying the tests should be run without a special flag.
> >>
> >>
> >> On Thu, Oct 22, 2015 at 1:31 PM, Dan Smith <dsm...@pivotal.io> wrote:
> >>
> >>> I don't think there is a counterpart in the gradle build. And I don't
> >>> think there should be - if this is something that needs to be tested it
> >>> should be running in every nightly build, not just when you pass a
> >> special
> >>> flag.
> >>>
> >>> -Dan
> >>>
> >>> On Thu, Oct 22, 2015 at 12:12 PM, Kirk Lund <kl...@pivotal.io> wrote:
> >>>
> >>>> This is from the old Ant build (which Geode doesn't use):
> >>>>
> >>>> $build.sh run-management-tests -DuseHTTP=true
> >>>>
> >>>> What's the counterpart in the Geode gradle build?
> >>>>
> >>>> -Kirk
> >>>>
> >>>>
> >>>> On Thu, Oct 22, 2015 at 11:55 AM, John Blum <jb...@pivotal.io> wrote:
> >>>>
> >>>>>
> >>>>> ---
> >>>>> This is an automatically generated e-mail. To reply, visit:
> >>>>> https://reviews.apache.org/r/39023/#review103635
> >>>>> ---
> >>>>>
> >>>>>
> >>>>> You will also need to run the Management test suite using HTTP
> >>>> (especially
> >>>>> for v8.x and earlier) with...
> >>>>>
> >>>>> $build.sh run-management-tests -DuseHTTP=true
> >>>>>
> >>>>> This will run all the Manager/Gfsh commands over HTTP using the
> >>>> Management
> >>>>> REST API.  I am not exactly sure how to do this with the Apache Geode
> >>>>> codebase and Gradle build, or even if the Management test suite is
> >> part
> >>>> of
> >>>>> the Apache Geode codebase yet.
> >>>>>
> >>>>>
> >>>>>
> >>>>
> >>
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java
> >>>>> (line 255)
> >>>>> <https://reviews.apache.org/r/39023/#comment161695>
> >>>>>
> >>>>>Make the "scheme" parameter final for consistency.
> >>>>>
> >>>>>Typically, you should add parameters to the end of the method
> >>>>> parameter list and also include a method such as...
> >>>>>
> >>>>>protected static final String DEFAULT_SCHEME = "http";
> >>>>>
> >>>>>...
> >>>>>
> >>>>>protected URI toUri(final String path)

Re: Review Request 39664: GEODE-487: Remove integrationTest and distributedTest from build task.

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39664/#review104108
---

Ship it!


Ship It!

- Kirk Lund


On Oct. 26, 2015, 11:04 p.m., Mark Bretl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39664/
> ---
> 
> (Updated Oct. 26, 2015, 11:04 p.m.)
> 
> 
> Review request for geode, Kirk Lund and Dan Smith.
> 
> 
> Bugs: GEODE-487
> https://issues.apache.org/jira/browse/GEODE-487
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This commit removes integrationTest and distributedTest tasks from the
> build task lifecycle. The tasks were associated with the 'check' task,
> which is in the 'build' lifecycle. After removing the tasks, only the
> 'test' task is run when build task is executed.
> 
> 
> Diffs
> -
> 
>   build.gradle d8da7dee271af2d9c8334b3c3b1b6b2066abb3db 
> 
> Diff: https://reviews.apache.org/r/39664/diff/
> 
> 
> Testing
> ---
> 
> Tested by running 'clean build'
> 
> Build now runs in about 5 minutes
> 
> 
> Thanks,
> 
> Mark Bretl
> 
>

Re: Review Request 39585: Integrated Security DUnitTest

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39585/#review104173
---


We need to have you remove usage of hydra.Log. All hydra classes are either 
only on the closed side or need to be removed from open.

Please add comments to every commented out dead code block so we know why it 
was commented out instead of being deleted.

We also need to get rid of any thread sleeps and replace them with 
WaitCriterion from DistributedTestCase or the test will fail intermittently on 
heavily loaded machines (including ASF infrastructure).


gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/CommandTestBase.java
 (line 163)
<https://reviews.apache.org/r/39585/#comment162453>

please add comment explaining if this code works in old ant build but not 
gradle



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/CommandTestBase.java
 (line 298)
<https://reviews.apache.org/r/39585/#comment162454>

please add comment explaining if this code works in old ant build but not 
gradle



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/IntegratedSecDUnitTest.java
 (line 3)
<https://reviews.apache.org/r/39585/#comment162455>

need to remove this usage of hydra because it should be in open yet -- 
maybe just use a log4j2 logger:

private static final Logger logger = LogService.getLogger();



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/IntegratedSecDUnitTest.java
 (line 134)
<https://reviews.apache.org/r/39585/#comment162456>

please add comment explaining if this code works in old ant build but not 
gradle



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/IntegratedSecDUnitTest.java
 (line 230)
<https://reviews.apache.org/r/39585/#comment162457>

change this to use DistributedTestCase.WaitCriterion with check to see if 
mbeans have been registered or this will fail intermittently because of thread 
sleep



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/IntegratedSecDUnitTest.java
 (line 640)
<https://reviews.apache.org/r/39585/#comment162458>

please add comment explaining if this code works in old ant build but not 
gradle



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/MBeanSecurityJUnitTest.java
 (line 3)
<https://reviews.apache.org/r/39585/#comment162459>

same as the last test -- need to get rid of all hydra.Log imports and use 
log4j2 Logger or cache.getLogger instead



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/MBeanSecurityJUnitTest.java
 (line 148)
<https://reviews.apache.org/r/39585/#comment162460>

please add comment explaining if this code is incomplete or if it works in 
old ant build but not gradle



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/MBeanSecurityJUnitTest.java
 (line 225)
<https://reviews.apache.org/r/39585/#comment162461>

please add comment explaining if this code works in old ant build but not 
gradle



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/MBeanSecurityJUnitTest.java
 (line 281)
<https://reviews.apache.org/r/39585/#comment162462>

please add comment explaining if this code works in old ant build but not 
gradle



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/MBeanSecurityJUnitTest.java
 (line 328)
<https://reviews.apache.org/r/39585/#comment162463>

please add comment explaining if this code works in old ant build but not 
gradle



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestAccessControl.java
 (line 3)
<https://reviews.apache.org/r/39585/#comment162464>

need to get rid of using hydra.Log



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestAuthenticator.java
 (line 3)
<https://reviews.apache.org/r/39585/#comment162465>

need to get rid of using hydra.Log


- Kirk Lund


On Oct. 27, 2015, 3:39 p.m., Tushar Khairnar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39585/
> ---
> 
> (Updated Oct. 27, 2015, 3:39 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jens Deppe, Kirk Lund, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> 1. CommandTestBase - Base class for all the CLI/gfsh command dunit tests.
> 2. HeadlessGfsh - Gfsh as an API (and not a shell in terminal) which can be 
> used to submit random commands and get command-r

Re: Review Request 39659: squash-a-thon week 1 fixes

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39659/#review104059
---

Ship it!



gemfire-core/src/main/java/com/gemstone/gemfire/cache/DataPolicy.java (line 245)
<https://reviews.apache.org/r/39659/#comment162268>

delete this line



gemfire-core/src/main/java/com/gemstone/gemfire/cache/DataPolicy.java (line 246)
<https://reviews.apache.org/r/39659/#comment162270>

fix the indentation on this line



gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionedRegionRebalanceOp.java
 (line 80)
<https://reviews.apache.org/r/39659/#comment162271>

the disadvantage of using this technique is that you cannot enable 
debugging via log4j2



gemfire-core/src/test/java/com/gemstone/gemfire/internal/FDDUnitTest.java (line 
77)
<https://reviews.apache.org/r/39659/#comment162272>

add comment pointing at GEODE-338 and saying test is disabled because 
failing assertion is invalid



gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionSingleHopDUnitTest.java
 (line 109)
<https://reviews.apache.org/r/39659/#comment162273>

delete this commented block



gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/RemoteTransactionDUnitTest.java
 (line 4087)
<https://reviews.apache.org/r/39659/#comment162274>

is this newly declared variable used?



gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/OnGroupsFunctionExecutionDUnitTest.java
 (line 80)
<https://reviews.apache.org/r/39659/#comment162284>

indentation inside this block appears to be wrong



gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/OnGroupsFunctionExecutionDUnitTest.java
 (line 143)
<https://reviews.apache.org/r/39659/#comment162283>

indentation inside this block appears to be wrong



gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/OnGroupsFunctionExecutionDUnitTest.java
 (line 158)
<https://reviews.apache.org/r/39659/#comment162282>

indentation inside this block appears to be wrong



gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/OnGroupsFunctionExecutionDUnitTest.java
 (line 173)
<https://reviews.apache.org/r/39659/#comment162281>

indentation inside this block appears to be wrong



gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/OnGroupsFunctionExecutionDUnitTest.java
 (line 188)
<https://reviews.apache.org/r/39659/#comment162280>

    indentation inside this block appears to be wrong


- Kirk Lund


On Oct. 26, 2015, 5:29 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39659/
> ---
> 
> (Updated Oct. 26, 2015, 5:29 p.m.)
> 
> 
> Review request for geode, Kirk Lund and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> [GEODE-116] CopyOnReadIndexDUnitTest.testPRQueryOnLocalNode fails assertion 
> Modified test to not use mcast port Test will not spawn up multiple servers 
> for each test run, fixed to only start up servers once per test. Test now 
> runs in less time than before
> 
> 
> GEODE-399: Fixing race with stats in testNetSearchNormals
> 
> Some messages may not be done processing when the get completes. The
> test already had code to wait for one of the messages to show up, I've
> applied that wait to the rest of the assertions.
> 
> Fixing compile failures under JDK 7
> 
> NetSerachMessagingDUnitTest was not declaring fields as final that were
> used in an anonymous class.
> 
> GEODE-103: Increase timeout and improve assertion message
> 
> Increase timeout waiting for process start. Improve assertion message
> to include tiemout in milliseconds.
> 
> GEODE-398: fix race in TXExpiryJUnitTest
> 
> 
> GEODE-426: Making PartitionedRegionRedundancyZoneDUnitTest clean up
> 
> This test had a method called "caseTearDown" which I don't believe was
> actually getting run. It's really important for the tearDown code to
> happen, because otherwise the test leaves members configured with
> redundancy zones.
> 
> After changing caseTearDown to tearDown,
> PartitionedRegionTestUtilsDUnitTest now passes when it is run after this
> test.
> 
> GEODE-427: fix race in testEventDelivery
> 
> 
> GEODE-164: Improve reliability of launcher integration tests
> 
> 
> Fixes GEODE-444 by closing client cache before closing server cache.
> 
> 
> GEODE-407, GEODE-349: Fixing race in testDatastoreCommitsWithPutAllAndR

Geode Bug Squashathon Day Four

[Kirk Lund]

We just finished our 4th day of Geode Bug Squashathon (Thurs) and we've had
another GREEN build of DistributedTests. We had 12 volunteers and committed
fixes for another 4 tickets. The UnitTest and IntegrationTest suites
remained green for us except for 2 failures in IntegrationTests which were
both in the same test case. The DistributedTest builds continue to have 1-3
test failures each run, and we're continuing to primarily fix bugs in the
test code itself. Seven of the open Jira tickets were found to be caused by
one underlying bug in the registration of DataSerializers.

Geode Builds (This Week):
UnitTest Builds: 30 PASS, 2 FAIL
IntegrationTest Builds: 112 PASS, 16 FAIL
DistributedTest Builds: 2 PASS, 51 FAIL

Number Test By Category:
UnitTest: 1,572 tests
IntegrationTest: 2,571 tests
DistributedTest: 7,166 tests

Geode JIRA Tickets:
Previously Open: 52
Filed (each day): Mon: 17, Tues: 15, Wed: 5, Thurs: 7
Fixed (each day): Mon: 12, Tues: 3, Wed: 4, Thurs: 4
In Progress: 14 (including 3 tickets that each have a duplicate)
Remaining Open: 60 (7 tickets are the same DataSerializer registration bug)

Thanks,
Kirk

Geode Definition of Done (DOD)

[Kirk Lund]

I think we need to settle on a formal Definition of Done (DOD) for Apache
Geode. Again, borrowing from Spring Data we could start with what they
define and add to it:


   - Implemented according to specification in the ticket
   - Unit tested
   - Integration tested
   - Reference documentation updated
   - Changelog updated
   - Code formatted appropriately
   - JavaDoc polished
   - Feature branch merged into master [develop?]
   - Snapshot build deployed
   - Ticket closed


https://github.com/spring-projects/spring-data-commons/wiki/DOD

Any thoughts or feedback?

-Kirk

JIRA Resolved vs Closed

[Kirk Lund]

Is there a standard that ASF follows for when a JIRA ticket changes status
to Resolved vs Closed?

If not, then I'd like recommend that we follow the process that Spring uses:

Ticket changes to Resolved when the fix/implementation is committed or
merged (to develop in our case). It then moves to Closed when that fix or
implementation ships in a release. The two different states then have
meaning and purpose as well as having a clear definition of when a ticket
should be Resolved vs Closed.

If a bug actually originates on a branch and is then Resolved on that same
branch before merging anywhere, we could then specify that the ticket
should be Closed before merging to develop.

Thoughts or feedback?

-Kirk

Re: Review Request 39885: squash-a-thon week 2 fixes

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39885/#review104944
---

Ship it!


Two small issues to look into and then merge it


gemfire-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionCCEDUnitTest.java
 (line 143)
<https://reviews.apache.org/r/39885/#comment163296>

Is there a way to use a WaitCriterion here instead of a sleep?



gemfire-core/src/test/java/com/gemstone/gemfire/management/ClientHealthStatsDUnitTest.java
 (line 418)
<https://reviews.apache.org/r/39885/#comment163297>

Is this sleep needed? It's happening at the end of the test.


- Kirk Lund


On Nov. 3, 2015, 1:01 a.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39885/
> ---
> 
> (Updated Nov. 3, 2015, 1:01 a.m.)
> 
> 
> Review request for geode and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> remove unused local var accidently added to unit test
> 
> 
> GEODE-489: delegate in getRefCount
> 
> Certains subclasses of MemoryBlock do not have a refCount.
> But the MemoryBlockNode implementation was always trying to
> read a refCount using the memory address of the block.
> Instead it should have delegated getRefCount to the MemoryBlock
> implementation.
> 
> GEODE-464: Fix AutoBalancer test race condition
> 
> Instance of cache Initializer is not destroyed when the cache is destroyed. 
> As a
> result, a scheduled rebalance job can start after a different test starts. 
> This
> can cause failures. Add a destroy method to kill scheduler in test tearDown to
> prevent orphaned tasks from failing other tests.
> 
> GEODE-361: fix expiry races in unit test
> 
> The test now uses WaitCriterion when waiting
> for an expiration. Also it now configures
> millisecond expiry so the test runs faster.
> 
> GEODE-244 Flush entries to disk in 
> testRecoverRedundancyParallelAsyncEventQueue
> 
> The queue is configured for async persistence, which means entries were
> being flushed to disk asynchronously. Due to GEODE-498, the size of the
> buckets could vary widely if the entries were not flushed to disk,
> causing the rebalance to have problems later.
> 
> GEODE-438: wait longer for event
> 
> Also the assertion messages now describe what the
> test expects.
> 
> GEODE-367: wait longer for assertion
> 
> Also fixed assertion messages.
> 
> GEODE-452. We were checking cacheClientProxy after closing it. but sometimes 
> client was reconnecting and queue again. Now we check after closing the 
> client cache.
> 
> 
> fixed GEODE-423 and GEODE-432. Now we start cacheserver using port 0. That 
> will force cacheserver to find available port.
> 
> 
> GEODE-502: Keeping a reference to RMI objects in the dunit framework
> 
> My suspicion with this failure is that the GC happened that cleaned up
> one of these objects, if the RMI framework is not keeping a strong
> reference to the class.
> 
> GEODE-467: fix race in off-heap memory monitor tests
> 
> I think this may have been caused by the monitor thread
> continuing to run after the unit tests call stopMonitor.
> They now call a flavor of the method that joins on the
> monitor thread.
> 
> Fixes GEODE-495: fix for OffHeapManagementDUnitTest
> 
> - use a random port for the JMX manager
> - fixed cleanup not to create cache if not created already
> 
> This closes #25
> 
> GEODE-469: Don't log a warning if a region is destroyed during creation
> 
> This test saw a suspect string because we logged a warning about a
> RegionDestroyedException during region creation. I don't think this
> warning should be logged, we don't log warnings for CancelExceptions.
> 
> GEODE-366: Wait for clear to be propegated in ClientHealthStatsDUnitTest
> 
> The clear was showing up asynchronously on the second client. By moving
> the clear up before an existing wait, it should get to the second
> client before that client does a put.
> 
> GEODE-501. test no-ack region thus we need to wait before validating the 
> results.
> 
> 
> GEODE-411: fix suspect string on disconnect
> 
> DistributionManager now has a isCloseInProgress method
> that checks both the volatile closeInProgress boolean
> and ask its DistributedSystem if it is disconnecting.
> This new method is used in places that decide if a warning
> should be logged.
> 
> GEODE-453: Ignoring suspect string in testR

Re: Review Request 39879: Add gemfire-common and @Experimental annotation

[Kirk Lund]

Re: gemfire-test -- most of our test utility code is for DistributedTests
and uses GemFire classes (API and internal) so we cannot move these classes
to gemfire-test (it would be a circular dependency) until after we move API
classes to gemfire-api.

-Kirk


On Tue, Nov 3, 2015 at 7:38 AM, Anthony Baker <aba...@apache.org> wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39879/
>
> On November 3rd, 2015, 4:22 a.m. UTC, *Dan Smith* wrote:
>
>
>- Should this be consolodated with gemfire-junit?
>- Or maybe we should have a gemfire-api project and move the rest of the 
> public API there as well?
>
> FWIW, I asked the same questions initially and got denied :-)
>
> We should (eventually) rename gemfire-junit to gemfire-test and put our test 
> utilities and supporting test code in there.
>
> I think for now we continue to use the *.internal.* package naming to 
> differentiate between API and implementation.  That means gemfire-common can 
> contain both public classes and internal classes that are useful across all 
> other modules.  IOW, gemfire-common is at the root of the module dependency 
> tree.
>
> When we refactor to break dependencies such that we *can* separate out an API 
> module (both for client and server) we definitely should.
>
> IMO
>
>
> - Anthony
>
> On November 2nd, 2015, 9:57 p.m. UTC, Kirk Lund wrote:
> Review request for geode, Anthony Baker, William Markito, and Mark Bretl.
> By Kirk Lund.
>
> *Updated Nov. 2, 2015, 9:57 p.m.*
> *Bugs: * GEODE-328 <https://issues.apache.org/jira/browse/GEODE-328>
> *Repository: * geode
> Description
>
> Add new gemfire-common project containing code for Experimental annotation 
> under main and a UnitTest under test.
>
> Add gemfire-common to gemfire-assembly for publishing.
>
> Add dependency on gemfire-common to gemfire-core, gemfire-rebalancer, and 
> gemfire-web.
>
> Testing
>
> clean build and unit testing of the new annotation
>
> Diffs
>
>- gemfire-assembly/build.gradle (b351729)
>- gemfire-common/build.gradle (PRE-CREATION)
>- 
> gemfire-common/src/main/java/com/gemstone/gemfire/annotations/Experimental.java
>(PRE-CREATION)
>- 
> gemfire-common/src/test/java/com/gemstone/gemfire/annotations/ExperimentalJUnitTest.java
>(PRE-CREATION)
>- 
> gemfire-common/src/test/java/com/gemstone/gemfire/annotations/experimentalpackage/ClassInExperimentalPackage.java
>(PRE-CREATION)
>- 
> gemfire-common/src/test/java/com/gemstone/gemfire/annotations/experimentalpackage/package-info.java
>(PRE-CREATION)
>- 
> gemfire-common/src/test/java/com/gemstone/gemfire/experimental/nonexperimentalpackage/ClassInNonExperimentalPackage.java
>(PRE-CREATION)
>- 
> gemfire-common/src/test/java/com/gemstone/gemfire/experimental/nonexperimentalpackage/package-info.java
>(PRE-CREATION)
>- gemfire-core/build.gradle (1c17474)
>- gemfire-rebalancer/build.gradle (d87dd58)
>- gemfire-web/build.gradle (f0de25a)
>- settings.gradle (4b2da7b)
>
> View Diff <https://reviews.apache.org/r/39879/diff/>
>

Re: Review Request 39346: GEODE-405: sameAs needs to ignore ssl-* properties

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39346/#review105093
---

Ship it!


Ship It!

- Kirk Lund


On Oct. 15, 2015, 5:42 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39346/
> ---
> 
> (Updated Oct. 15, 2015, 5:42 p.m.)
> 
> 
> Review request for geode and Kirk Lund.
> 
> 
> Bugs: GEODE-405
> https://issues.apache.org/jira/browse/GEODE-405
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Since toProperties does not include ssl-* properties
> sameAs needs to also ignore ssl-* properties.
> Since the ssl-* are always copied to cluster-ssl-*
> and sameAs compares these it will still return false
> if the ssl-* properties had different values.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/AbstractConfig.java 
> 75e4314d67dbeff8fb6b97d712f689263094e7d7 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystemJUnitTest.java
>  88a06542383d50d41f6768b8142c9deb6d988392 
> 
> Diff: https://reviews.apache.org/r/39346/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Re: Review Request 39362: GEODE-406: Adding --J parameter to validate offline-disk-store

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39362/#review105092
---

Ship it!


Ship It!

- Kirk Lund


On Oct. 15, 2015, 11:02 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39362/
> ---
> 
> (Updated Oct. 15, 2015, 11:02 p.m.)
> 
> 
> Review request for geode and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> It's useful when debugging the contents of a disk store to be able to
> pass parameters to the validate command to enable tracing of the output.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DiskStoreCommands.java
>  4614ce70c5df4479b78bbb237d729cdd22806520 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/i18n/CliStrings.java
>  a4561bf929b7892772b040bc218a0e19f93ea363 
> 
> Diff: https://reviews.apache.org/r/39362/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 39925: GEODE-438: wait longer in test validation code

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39925/#review105090
---

Ship it!


Ship It!

- Kirk Lund


On Nov. 4, 2015, 12:49 a.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39925/
> ---
> 
> (Updated Nov. 4, 2015, 12:49 a.m.)
> 
> 
> Review request for geode and Kirk Lund.
> 
> 
> Bugs: GEODE-438
> https://issues.apache.org/jira/browse/GEODE-438
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Four places still existed that only waited for 3 seconds.
> One of those was the last failure of this test.
> Now the test waits 30 seconds.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java
>  8faa03cb8a8830c7c5cd37b44410830cce5743f0 
> 
> Diff: https://reviews.apache.org/r/39925/diff/
> 
> 
> Testing
> ---
> 
> testDRLoadRejection and testPRLoadRejection
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Re: Review Request 39921: GEODE-296: change test to handle EntryDestroyedException

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39921/#review105091
---

Ship it!


Ship It!

- Kirk Lund


On Nov. 3, 2015, 10:56 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39921/
> ---
> 
> (Updated Nov. 3, 2015, 10:56 p.m.)
> 
> 
> Review request for geode and Kirk Lund.
> 
> 
> Bugs: GEODE-296
> https://issues.apache.org/jira/browse/GEODE-296
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-296: change test to handle EntryDestroyedException
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAInterestPart2DUnitTest.java
>  b8617865aac339aef9c31094887fe1cb5e3c8bf5 
> 
> Diff: https://reviews.apache.org/r/39921/diff/
> 
> 
> Testing
> ---
> 
> testBug35945
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Re: Geode Release 1.0.0

[Kirk Lund]

Nitin,

The JIRA tickets for CI failures do not have a common parent JIRA, but
here's a query to see what's still open:

project = GEODE AND status in (Open, "In Progress", Reopened) AND labels =
CI

There are currently 57 open CI tickets. We are not officially continuing
the Squashathon but contributors need to continue to work on fixing these
tests. Discovery rate of new buggy DistributedTests is down to a few a day
and we've improved reliability such that we're up to at least 33% green
builds for any testing target that includes DistributedTests. My rough
estimate is 3 more weeks of dedicated work by 12 or more developers to
bring it up to very consistent green builds.

Fixing the Client/Server DistributedTests is an open problem because the
team that would focus on those bugs is busy working on JGroups.

-Kirk


On Thu, Oct 29, 2015 at 11:23 PM, Nitin Lamba  wrote:

> Thanks Anil for the update! Seems JGroups is progressing well. Out of
> curiosity, can you share any numbers (# of tests still failing or % test
> passing)?
>
> Also, any estimate for completion? Are we looking at days, weeks or months?
>
> GEODE-18 is also getting close. That only leaves tests to be resolved
> before we can cut a release.
>
> Kirk: any latest update from the Bug Squashathon from last week? Is there
> a parent JIRA that we can track on the Release page?
>
> -Nitin
>
> 
> From: Anilkumar Gingade 
> Sent: Thursday, October 29, 2015 10:54 PM
> To: dev@geode.incubator.apache.org
> Subject: Re: Geode Release 1.0.0
>
> Status update on Geode-77:
>
> We have made a great progress from where we were last week to this
> week...Last weekend, we started one more round of test runs (GemFire
> products HA test suites); from this run, we are seeing test failure count
> coming down significantly; and we are not seeing failures at the test-suite
> level (set of tests covering particular feature), instead we are seeing
> failures at individual test-case level...
>
> From the analysis we are seeing issues relating to:
> - Members not getting kicked out when they are supposed.
> - Members unexpectedly getting disconnected during HA.
> - Cache server spends time processing membership views after it is asked to
> stop.
> - Data inconsistency and performance issues with udp messaging.
> - Data inconsistency issue with wan and transaction.
> - Issues with startup during HA.
> - Issue with stopping process during the end of a HA test.
> - Issue with client/server transaction with HA.
> - Functions not getting directed to expected nodes.
>
> Team is working aggressively to address these issues...
>
> -Anil.
>
>
>
>
> On Tue, Oct 20, 2015 at 5:54 PM, Anilkumar Gingade 
> wrote:
>
> > Update on GEODE-77:
> >
> > As part of GEODE-77 we started replacing the old JGroups code that had a
> > LGPL license (incompatible with Apache) with the new version of JGroups.
> >
> > Proposal and the work regarding this can be found at:
> >
> https://cwiki.apache.org/confluence/display/GEODE/Replacing+JGroups+2.2.9
> > (JGroups section).
> > The work is done on feature branch: "feature/GEODE-77"
> >
> > We have done a great progress in adopting the new JGroups version; the
> > development work to provide similar stability and features as with
> > commercial GemFire product (with old JGroups) has been completed.
> >
> > Currently we are in hardening phase, trying to get the tests successfully
> > running and address any issues found:
> >
> > The unit tests are passing and we have only one failure, that is also
> seen
> > in development branch.
> >
> > In order to shake out any additional real-world problem; we are running
> > changes through GemFire products HA test suites...
> >
> > At high level we are seeing issues with:
> >
> > - Members unfairly getting kicked out from the cluster.
> >   Note: We are addressing this by adding tcp/ip connection check
> mechanism.
> > - We are sometimes not fast enough to detect crashes.
> > - We are having serialization and deserialization problems handling old
> > GemFire clients and in Transactions.
> > - Seeing issues with UDP messaging.
> >
> > We still have undiagnosed failures that we are looking into…I will keep
> > this thread updated as we analyze the test runs and any progress we make
> in
> > addressing the issues.
> >
> > Let me know if you have any questions.
> >
> > Thanks,
> > -Anil.
> >
> >
> >
> > On Fri, Oct 16, 2015 at 3:47 PM, Nitin Lamba  wrote:
> >
> >> Just a weekly check-in on the alpha release activities. Are there any
> >> updates on:
> >> - GEODE-77 [Bruce]: Any ETA established for this?
> >> - GEODE-18 [Anthony] Any update from the patch that was submitted?
> >>
> >> Thanks,
> >> Nitin
> >> 
> >> From: Anthony Baker 
> >> Sent: Friday, October 9, 2015 2:08 PM
> >> To: dev@geode.incubator.apache.org
> >> Subject: Re: Geode 

Review Request 39879: Add gemfire-common and @Experimental annotation

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39879/
---

Review request for geode, Anthony Baker, William Markito, and Mark Bretl.


Bugs: GEODE-328
https://issues.apache.org/jira/browse/GEODE-328


Repository: geode


Description
---

Add new gemfire-common project containing code for Experimental annotation 
under main and a UnitTest under test.

Add gemfire-common to gemfire-assembly for publishing.

Add dependency on gemfire-common to gemfire-core, gemfire-rebalancer, and 
gemfire-web.


Diffs
-

  gemfire-assembly/build.gradle b351729 
  gemfire-common/build.gradle PRE-CREATION 
  
gemfire-common/src/main/java/com/gemstone/gemfire/annotations/Experimental.java 
PRE-CREATION 
  
gemfire-common/src/test/java/com/gemstone/gemfire/annotations/ExperimentalJUnitTest.java
 PRE-CREATION 
  
gemfire-common/src/test/java/com/gemstone/gemfire/annotations/experimentalpackage/ClassInExperimentalPackage.java
 PRE-CREATION 
  
gemfire-common/src/test/java/com/gemstone/gemfire/annotations/experimentalpackage/package-info.java
 PRE-CREATION 
  
gemfire-common/src/test/java/com/gemstone/gemfire/experimental/nonexperimentalpackage/ClassInNonExperimentalPackage.java
 PRE-CREATION 
  
gemfire-common/src/test/java/com/gemstone/gemfire/experimental/nonexperimentalpackage/package-info.java
 PRE-CREATION 
  gemfire-core/build.gradle 1c17474 
  gemfire-rebalancer/build.gradle d87dd58 
  gemfire-web/build.gradle f0de25a 
  settings.gradle 4b2da7b 

Diff: https://reviews.apache.org/r/39879/diff/


Testing
---

clean build and unit testing of the new annotation


Thanks,

Kirk Lund

Re: Review Request 39877: GEODE-522: Fix eclipse classpath for generation of IDE project files

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39877/#review104800
---

Ship it!


Ship It!

- Kirk Lund


On Nov. 2, 2015, 9:38 p.m., Mark Bretl wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39877/
> ---
> 
> (Updated Nov. 2, 2015, 9:38 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Kirk Lund, and Dan Smith.
> 
> 
> Bugs: GEODE-522
> https://issues.apache.org/jira/browse/GEODE-522
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-522: Fix eclipse classpath for generation of IDE project files
> 
> 
> Diffs
> -
> 
>   gemfire-web/build.gradle f0de25aa9af036442ce115c82e2b7193504a5236 
> 
> Diff: https://reviews.apache.org/r/39877/diff/
> 
> 
> Testing
> ---
> 
> 'clean eclipse' then import into Spring Tool Suite 3.7.1
> 
> 
> Thanks,
> 
> Mark Bretl
> 
>

Fwd: Apache Geode Clubhouse: Tuesday, November 3

[Kirk Lund]

Reminder: next Clubhouse is tomorrow (Tues) morning 9AM PST!

Topic is: OQL Querying and Indexing in Geode

Be seeing you,
Kirk

-- Forwarded message --
From: Marie Nedich 
Date: Fri, Oct 23, 2015 at 11:26 AM
Subject: Apache Geode Clubhouse: Tuesday, November 3
To: dev@geode.incubator.apache.org, u...@geode.incubator.apache.org


Hello, the next Clubhouse is November 3rd!

Title: OQL Querying and Indexing in Geode
Speaker: Jason Huynh, Apache Geode Committer
Date: Tuesday, November 3 @ 9AM -10AM PDT
Abstract: We will discuss how to use Object Query Language (OQL) to create
queries in Apache Geode (incubating). We will cover query syntax, how the
query engine executes a query on a partitioned region, what index types are
supported in Geode, and some miscellaneous querying related topics
(Undefined objects, Geode specific keywords)

JOIN: https://pivotalcommunity.adobeconnect.com/clubhouse


Palo Alto- Tuesday, November 3, 2015 at 9:00:00 AM PST UTC-8 hours
New York - Tuesday, November 3, 2015 at 12:00:00 Noon EST UTC-5 hours
Beijing - Wednesday, November 4, 2015 at 1:00:00 AM CST UTC+8 hours
London - Tuesday, November 3, 2015 at 5:00:00 PM GMT UTC
Pune - Tuesday, November 3, 2015 at 10:30:00 PM IST UTC+5:30 hours
Corresponding UTC (GMT)Tuesday, November 3, 2015 at 17:00:00


Previous recordings: http://bit.ly/1GZuvcK



-Marie

Re: Review Request 39879: Add gemfire-common and @Experimental annotation

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39879/#review104808
---



gemfire-web/build.gradle (line 15)
<https://reviews.apache.org/r/39879/#comment163050>

I think this change was added to the diff by latest down-merge of develop 
HEAD to my branch. Let me know which is correct (testRuntime or provided).


- Kirk Lund


On Nov. 2, 2015, 9:57 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39879/
> ---
> 
> (Updated Nov. 2, 2015, 9:57 p.m.)
> 
> 
> Review request for geode, Anthony Baker, William Markito, and Mark Bretl.
> 
> 
> Bugs: GEODE-328
> https://issues.apache.org/jira/browse/GEODE-328
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Add new gemfire-common project containing code for Experimental annotation 
> under main and a UnitTest under test.
> 
> Add gemfire-common to gemfire-assembly for publishing.
> 
> Add dependency on gemfire-common to gemfire-core, gemfire-rebalancer, and 
> gemfire-web.
> 
> 
> Diffs
> -
> 
>   gemfire-assembly/build.gradle b351729 
>   gemfire-common/build.gradle PRE-CREATION 
>   
> gemfire-common/src/main/java/com/gemstone/gemfire/annotations/Experimental.java
>  PRE-CREATION 
>   
> gemfire-common/src/test/java/com/gemstone/gemfire/annotations/ExperimentalJUnitTest.java
>  PRE-CREATION 
>   
> gemfire-common/src/test/java/com/gemstone/gemfire/annotations/experimentalpackage/ClassInExperimentalPackage.java
>  PRE-CREATION 
>   
> gemfire-common/src/test/java/com/gemstone/gemfire/annotations/experimentalpackage/package-info.java
>  PRE-CREATION 
>   
> gemfire-common/src/test/java/com/gemstone/gemfire/experimental/nonexperimentalpackage/ClassInNonExperimentalPackage.java
>  PRE-CREATION 
>   
> gemfire-common/src/test/java/com/gemstone/gemfire/experimental/nonexperimentalpackage/package-info.java
>  PRE-CREATION 
>   gemfire-core/build.gradle 1c17474 
>   gemfire-rebalancer/build.gradle d87dd58 
>   gemfire-web/build.gradle f0de25a 
>   settings.gradle 4b2da7b 
> 
> Diff: https://reviews.apache.org/r/39879/diff/
> 
> 
> Testing
> ---
> 
> clean build and unit testing of the new annotation
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: Geode Definition of Done (DOD)

[Kirk Lund]

I was just sharing the Spring Data DoD. The Apache Geode DoD would include
CTR.

The DoD is a checklist every developer follows when working on a User
Story. If the DoD includes "UnitTests have been written and are passing"
then the developer must complete that step before they can say "I'm done
with this User Story".

-Kirk


On Mon, Nov 2, 2015 at 2:23 PM, Anthony Baker <aba...@pivotal.io> wrote:

> Practically speaking, when is the DOD used?  Also, how does this differ
> from the contribution process?
>
> I don’t see a review (CTR) step.
>
> Anthony
>
>
> > On Nov 2, 2015, at 1:33 PM, William Markito <wmark...@pivotal.io> wrote:
> >
> > +1
> >
> > Just one question, what is snapshot build deployed ? Is it the same as
> > snapshot build successfully completed ?
> >
> > On Mon, Nov 2, 2015 at 12:44 PM, John Blum <jb...@pivotal.io> wrote:
> >
> >> +1
> >>
> >> On Mon, Nov 2, 2015 at 12:36 PM, Udo Kohlmeyer <ukohlme...@pivotal.io>
> >> wrote:
> >>
> >>> +1
> >>> On 3 Nov 2015 7:14 am, "Kirk Lund" <kl...@pivotal.io> wrote:
> >>>
> >>>> I think we need to settle on a formal Definition of Done (DOD) for
> >> Apache
> >>>> Geode. Again, borrowing from Spring Data we could start with what they
> >>>> define and add to it:
> >>>>
> >>>>
> >>>>   - Implemented according to specification in the ticket
> >>>>   - Unit tested
> >>>>   - Integration tested
> >>>>   - Reference documentation updated
> >>>>   - Changelog updated
> >>>>   - Code formatted appropriately
> >>>>   - JavaDoc polished
> >>>>   - Feature branch merged into master [develop?]
> >>>>   - Snapshot build deployed
> >>>>   - Ticket closed
> >>>>
> >>>>
> >>>> https://github.com/spring-projects/spring-data-commons/wiki/DOD
> >>>>
> >>>> Any thoughts or feedback?
> >>>>
> >>>> -Kirk
> >>>>
> >>>
> >>
> >>
> >>
> >> --
> >> -John
> >> 503-504-8657
> >> john.blum10101 (skype)
> >>
> >
> >
> >
> > --
> >
> > William Markito Oliveira
> > -- For questions about Apache Geode, please write to
> > *dev@geode.incubator.apache.org
> > <dev@geode.incubator.apache.org>*
>
>

Re: Geode Definition of Done (DOD)

[Kirk Lund]

The DoD is a checklist with everything that needs to be done in order to
say you're done with a User Story, Iteration, or Release. Most contributors
would be primarily interested in DoD for User Story, but some projects add
additional steps to the DoD for Iterations and Releases (such as Capturing
Release Notes).

Defining "done" simply formalizes what it means to be done. Without
defining done, important work can easily be skipped accidentally or
purposefully (Javadocs, User Docs/Manual, UnitTests, IntegrationTests,
AcceptanceTests, product examples, license audit, crypto audit, etc). For
an open source project, it's extremely valuable to have a DoD so that new
contributors know what all needs to happen to contribute successfully.

The DoD should be a live document that is continually reviewed and improved
as needed. It would simply be a page on the wiki that mentions things like
writing UnitTests, reviewing changes prior to committing, etc.

Unless someone else wants to, I'll write up a draft tomorrow on the wiki
and then others can comment or modify.

Good definition of Done in Jira:
http://blogs.atlassian.com/2013/10/8-steps-to-a-definition-of-done-in-jira/

Interesting blog article about Multiple Levels of Done:
https://www.mountaingoatsoftware.com/blog/multiple-levels-of-done

Good article about DoD:
https://dzone.com/articles/definitions-done-practice

Another good article:
http://sauceio.com/index.php/2015/09/what-is-your-definition-of-done/

-Kirk


On Mon, Nov 2, 2015 at 3:38 PM, John Blum <jb...@pivotal.io> wrote:

> DoD is used continuously especially before a release goes out.  DoD occurs
> continuously with activities such as design, implementation, testing,
> documenting, merging (topic branches), getting feedback, iterating, etc.
> Other activities (Code Formatting, Polishing, Ticket Closing, etc) are
> "tie-up" tasks and necessarily happen at the end, right before a release.
>
> As for the "contribution process", there is not much difference.  A JIRA
> ticket is filed for the PR (especially for not committers) and the ticket
> progresses as any other ticket would.
>
> Finally, most Spring projects doe not have the luxury of having a
> "reviewer", mostly because there are 1 to many projects per engineer.  Some
> projects like the core Spring Framework, Spring Boot, Spring XD, Spring
> Cloud, etc, have a lot more eyes on it and so they do involve a more formal
> review process.  On the Spring Data team, for instance, Oliver is trying to
> have everyone work on minimally 2 SD modules.  That way, each engineer has
> someone who is familiar with the project and can share ideas with the other
> (a sanity check).
>
> But, for the most part, review, like refactoring, is something that needs
> to be continuous.  Besides, the code is never done, really, ;-)
>
> -j
>
>
> On Mon, Nov 2, 2015 at 2:23 PM, Anthony Baker <aba...@pivotal.io> wrote:
>
> > Practically speaking, when is the DOD used?  Also, how does this differ
> > from the contribution process?
> >
> > I don’t see a review (CTR) step.
> >
> > Anthony
> >
> >
> > > On Nov 2, 2015, at 1:33 PM, William Markito <wmark...@pivotal.io>
> wrote:
> > >
> > > +1
> > >
> > > Just one question, what is snapshot build deployed ? Is it the same as
> > > snapshot build successfully completed ?
> > >
> > > On Mon, Nov 2, 2015 at 12:44 PM, John Blum <jb...@pivotal.io> wrote:
> > >
> > >> +1
> > >>
> > >> On Mon, Nov 2, 2015 at 12:36 PM, Udo Kohlmeyer <ukohlme...@pivotal.io
> >
> > >> wrote:
> > >>
> > >>> +1
> > >>> On 3 Nov 2015 7:14 am, "Kirk Lund" <kl...@pivotal.io> wrote:
> > >>>
> > >>>> I think we need to settle on a formal Definition of Done (DOD) for
> > >> Apache
> > >>>> Geode. Again, borrowing from Spring Data we could start with what
> they
> > >>>> define and add to it:
> > >>>>
> > >>>>
> > >>>>   - Implemented according to specification in the ticket
> > >>>>   - Unit tested
> > >>>>   - Integration tested
> > >>>>   - Reference documentation updated
> > >>>>   - Changelog updated
> > >>>>   - Code formatted appropriately
> > >>>>   - JavaDoc polished
> > >>>>   - Feature branch merged into master [develop?]
> > >>>>   - Snapshot build deployed
> > >>>>   - Ticket closed
> > >>>>
> > >>>>
> > >>>> https://github.com/spring-projects/spring-data-commons/wiki/DOD
> > >>>>
> > >>>> Any thoughts or feedback?
> > >>>>
> > >>>> -Kirk
> > >>>>
> > >>>
> > >>
> > >>
> > >>
> > >> --
> > >> -John
> > >> 503-504-8657
> > >> john.blum10101 (skype)
> > >>
> > >
> > >
> > >
> > > --
> > >
> > > William Markito Oliveira
> > > -- For questions about Apache Geode, please write to
> > > *dev@geode.incubator.apache.org
> > > <dev@geode.incubator.apache.org>*
> >
> >
>
>
> --
> -John
> 503-504-8657
> john.blum10101 (skype)
>

Re: testDefaults in BasicI18nJUnitTest

[Kirk Lund]

+1 for deleting it. Test looks worthless.

I'd be in favor of completely replacing the internationalization code in
Geode.

-Kirk


On Thu, Nov 5, 2015 at 11:43 AM, Dan Smith  wrote:

> I don't see much purpose behind that test either. I'd be in favor of
> deleting it.
>
> -Dan
>
> On Wed, Nov 4, 2015 at 9:02 PM, Roman  wrote:
>
> > Hi,
> > Can you please explain the purpose of testDefaults()
> > in BasicI18nJUnitTest?It fails if run under a locale with a language
> other
> > than french or english as you describe in the comments.
> > -Roman
> >
>

Re: Delete feature/GEODE-409?

[Kirk Lund]

+1

On Thu, Nov 5, 2015 at 12:19 PM, Sai Boorlagadda 
wrote:

> +1
>
> On Thu, Nov 5, 2015 at 12:17 PM, William Markito 
> wrote:
>
> > +1
> >
> > On Thu, Nov 5, 2015 at 11:39 AM, Darrel Schneider  >
> > wrote:
> >
> > > +1
> > >
> > > On Thu, Nov 5, 2015 at 11:24 AM, Ashvin A  wrote:
> > >
> > > > Hi,
> > > >
> > > > Branch 'feature/GEODE-409' was merged into develop 2 days ago. I
> fixed
> > a
> > > > failing test and committed the change on feature/409 after the merge.
> > It
> > > > should have been committed on develop instead. I will need to merge
> the
> > > > branch again. I am thinking we should delete feature/409 as we are
> not
> > > > working on feature/409 actively.
> > > >
> > > > Thoughts?
> > > >
> > > > Thanks,
> > > > Ashvin
> > > >
> > >
> >
> >
> >
> > --
> >
> > William Markito Oliveira
> > -- For questions about Apache Geode, please write to
> > *dev@geode.incubator.apache.org
> > *
> >
>
>
>
> --
> Sai Boorlagadda
>

regex in jira

[Kirk Lund]

Does anyone know if it's possible to use regex in jira queries/filters?

-Kirk

Geode Bug Squashathon Day One

[Kirk Lund]

We started off our week of Geode Bug Squashathon with 6 volunteers fixing
12 tickets (with 4 more in-progress). The UnitTests and IntegrationTests
are predominantly green. We had a number of failures caused by git timeouts
and we hit 2 intermittent failures in IntegrationTests for which we filed
bugs. The DistributedTests target continues to see 1-3 test failures each
run. So far the failures we've fixed have been bugs (race conditions, etc)
in the test code itself.

Geode Builds:
UnitTests: 11 PASS, 2 FAIL
IntegrationTests: 50 PASS, 7 FAIL
DistributedTests: 0 PASS, 19 FAIL

Geode JIRA Tickets:
Previously Open: 52*
Filed: 17
Fixed: 12
In Progress: 4

Remaining Open: 53

* 5 of the tickets are for HDFS DUnit tests which will be moved with the
incomplete HDFS feature from develop to a feature branch.

If you haven't joined in yet, please consider joining in this week!

Thanks,
Kirk

[image: Inline image 2]

[image: Inline image 3]

Re: CI cleanup & squashaton

[Kirk Lund]

Here's a filter that shows all CI tickets for Geode that are Open,
In-Progress or Reopened (excluding HDFS):

project = GEODE AND status in (Open, "In Progress", Reopened) AND labels =
CI AND labels != HDFS

The HDFS tests are disabled and HDFS should probably be moved to a feature
branch (ie, removed from develop).

-Kirk


On Fri, Oct 16, 2015 at 3:07 PM, William Markito 
wrote:

> Hey folks
>
> What about dedicate the next week to work specifically on CI and test
> issues in order to make our builds more stable and predictable ?
>
> The work done as part of that effort will be tracked on GEODE-409 and on
> feature/GEODE-409 branch.
>
> Test failures (unit,integration), JIRA tickets with CI label and such are
> all valid.
>
> Thanks
> --
>
> William Markito Oliveira
> Enterprise Architect
> -- For questions about Apache Geode, please write to
> *dev@geode.incubator.apache.org
> *
>

Re: CI cleanup & squashaton

[Kirk Lund]

We're working on branch feature/GEODE-409. Most of the intermittent CI
failures are dunit tests (distributedTest target). If anyone decides to
join in please select a Geode JIRA ticket labeled CI, assign it to yourself
and start progress.

If you have any questions, please us know!

-Kirk


On Fri, Oct 16, 2015 at 4:25 PM, Anthony Baker <aba...@pivotal.io> wrote:

> +1
>
> > On Oct 16, 2015, at 3:33 PM, Kirk Lund <kl...@pivotal.io> wrote:
> >
> > Here's a filter that shows all CI tickets for Geode that are Open,
> > In-Progress or Reopened (excluding HDFS):
> >
> > project = GEODE AND status in (Open, "In Progress", Reopened) AND labels
> =
> > CI AND labels != HDFS
> >
> > The HDFS tests are disabled and HDFS should probably be moved to a
> feature
> > branch (ie, removed from develop).
> >
> > -Kirk
> >
> >
> > On Fri, Oct 16, 2015 at 3:07 PM, William Markito <wmark...@pivotal.io>
> > wrote:
> >
> >> Hey folks
> >>
> >> What about dedicate the next week to work specifically on CI and test
> >> issues in order to make our builds more stable and predictable ?
> >>
> >> The work done as part of that effort will be tracked on GEODE-409 and on
> >> feature/GEODE-409 branch.
> >>
> >> Test failures (unit,integration), JIRA tickets with CI label and such
> are
> >> all valid.
> >>
> >> Thanks
> >> --
> >>
> >> William Markito Oliveira
> >> Enterprise Architect
> >> -- For questions about Apache Geode, please write to
> >> *dev@geode.incubator.apache.org
> >> <dev@geode.incubator.apache.org>*
> >>
>
>

Re: Review Request 39028: fix intermittent failures in TXExpiryJUnitTest

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39028/#review101671
---

Ship it!


Ship It!

- Kirk Lund


On Oct. 5, 2015, 11:18 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39028/
> ---
> 
> (Updated Oct. 5, 2015, 11:18 p.m.)
> 
> 
> Review request for geode and Kirk Lund.
> 
> 
> Bugs: GEODE-362
> https://issues.apache.org/jira/browse/GEODE-362
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The test now enables millisecond expiration and uses expiration suspension 
> and resumption to prevent race conditions.
> A test hook was added so that the product will notify the test code when a 
> particular ExpiryTask has expired.
> Since this test now runs in less than a second I changed it from integration 
> to unit.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/ExpiryTask.java
>  d5dc5ee31905baec7d5fcf6958eb8cfaa92d 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java
>  617a7ec347cd5648115af66ed5216e7fbc18a3bd 
>   gemfire-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 
> da9623bee39e44f74c4b5b099d39a07be3a8d172 
> 
> Diff: https://reviews.apache.org/r/39028/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Re: Review Request 38866: PR put messages no longer deserialize old values early

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38866/#review101670
---

Ship it!


Ship It!

- Kirk Lund


On Sept. 29, 2015, 10:47 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38866/
> ---
> 
> (Updated Sept. 29, 2015, 10:47 p.m.)
> 
> 
> Review request for geode, Kirk Lund and Dan Smith.
> 
> 
> Bugs: GEODE-324
> https://issues.apache.org/jira/browse/GEODE-324
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> When a PR put returns the old value our internal messages were deserializing 
> the values before we get back to the user thread that initiated the 
> operation. If thread local class loader is used for the class we need to find 
> during deserialization then the early deserialization will fail.
> 
> Now the deserialization is delayed until the serialized old value gets 
> through our messaging layer and back to the thread that performed the pr put.
> 
> Added junit tests that verify that both PutReplyMessage classes no longer 
> deserialize their old value.
> 
> 
> Diffs
> -
> 
>   gemfire-core/src/main/java/com/gemstone/gemfire/DataSerializer.java 
> 8f977d8a9625ebde003f08bbb1df02cd120ad77c 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java
>  87ab28d38fe5ece8dab2617dc304de7fb3b42b01 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java
>  692595cb835fce8c0a244073c20046e07894110c 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutMessage.java
>  3f5efeb5da4f0aeacde2e59082aab3d0f30d6775 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PutMessage.java
>  1f7b08e7dbed9180cb0ed73992feb3485009a6ad 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapCachedDeserializable.java
>  764a051b9ae0243f1b9e235bf18d4aa0f6770c0a 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorImpl.java
>  7cf165644ce03859670cc1a4c80484c31e9cdfcd 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/StoredObject.java
>  8f179ae46d83ae4b4acb207029a8a89599357ae3 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/OldValueImporterTestBase.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/RemotePutReplyMessageJUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PutPutReplyMessageJUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapWriteObjectAsByteArrayJUnitTest.java
>  PRE-CREATION 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/pdx/ByteSourceJUnitTest.java 
> 0ef1bed199f0c137c4282182f704c729fa76600f 
> 
> Diff: https://reviews.apache.org/r/38866/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Re: Review Request 39058: GEODE-385: fix test race

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39058/#review101675
---



gemfire-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java (line 
324)
<https://reviews.apache.org/r/39058/#comment159130>

I think I would move this if-else block inside the try { below


- Kirk Lund


On Oct. 6, 2015, 6:28 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39058/
> ---
> 
> (Updated Oct. 6, 2015, 6:28 p.m.)
> 
> 
> Review request for geode and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Region expiration was being enabled before the test suspended expiration.
> This introduced a race in which the region could be expire destroyed
> before the first put happened. Now expiry is suspended before region
> expiration is configured.
> 
> 
> Diffs
> -
> 
>   gemfire-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 
> 2a0a58160307e83156f31d61c75b1f04b95932e0 
> 
> Diff: https://reviews.apache.org/r/39058/diff/
> 
> 
> Testing
> ---
> 
> TXExpiryJUnitTest
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Re: Review Request 39028: fix intermittent failures in TXExpiryJUnitTest

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39028/#review101672
---



gemfire-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java (line 57)
<https://reviews.apache.org/r/39028/#comment159126>

I would keep this as an IntegrationTest


- Kirk Lund


On Oct. 5, 2015, 11:18 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39028/
> ---
> 
> (Updated Oct. 5, 2015, 11:18 p.m.)
> 
> 
> Review request for geode and Kirk Lund.
> 
> 
> Bugs: GEODE-362
> https://issues.apache.org/jira/browse/GEODE-362
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The test now enables millisecond expiration and uses expiration suspension 
> and resumption to prevent race conditions.
> A test hook was added so that the product will notify the test code when a 
> particular ExpiryTask has expired.
> Since this test now runs in less than a second I changed it from integration 
> to unit.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/ExpiryTask.java
>  d5dc5ee31905baec7d5fcf6958eb8cfaa92d 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java
>  617a7ec347cd5648115af66ed5216e7fbc18a3bd 
>   gemfire-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 
> da9623bee39e44f74c4b5b099d39a07be3a8d172 
> 
> Diff: https://reviews.apache.org/r/39028/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Review Request 39290: Configure Log4J 2 on classpath instead of with system property

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39290/
---

Review request for geode, anilkumar gingade, Bruce Schuchardt, and Darrel 
Schneider.


Bugs: GEODE-189
https://issues.apache.org/jira/browse/GEODE-189


Repository: geode


Description
---

GemFire currently configures Log4J 2 only if it's not already configured. The 
new JGroups includes log4j2.xml in the root of the JAR which is on the 
classpath. Log4J 2 automatically picks this up and uses it. These change 
involve placing the default log4j2.xml for GemFire in the root of the 
gemfire-core JAR. If this JAR is earlier than the JGroups JAR then our config 
will be found first and used.

This change also allows us to simplify the configuration code in LogService.

The log4j2-cli.xml also moves to the root of the gemfire-core JAR which means 
the gfsh scripts can directly reference it by prefixing "classpath:" on the 
value of the configuration system property.

Overall these changes are much better for the product and I'd recommend making 
these changes even if JGroups wasn't changing.

Tests are altered, deleted and updated as needed. System-rules JUnit rules are 
updated to version 1.12.1.

I intend to commit these changes to develop and then we can down-merge this to 
the GEODE-77 feature branch.


Diffs
-

  build.gradle c1534de 
  gemfire-assembly/build.gradle f65930d 
  gemfire-assembly/src/main/dist/bin/gfsh e700aae 
  gemfire-assembly/src/main/dist/bin/gfsh.bat c4a9480 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java
 637f8ca 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/Configurator.java
 e07f214 
  
gemfire-core/src/main/resources/com/gemstone/gemfire/internal/logging/log4j/log4j2-cli.xml
 14b7075 
  
gemfire-core/src/main/resources/com/gemstone/gemfire/internal/logging/log4j/log4j2-default.xml
 a6e8cd8 
  gemfire-core/src/main/resources/log4j2-cli.xml PRE-CREATION 
  gemfire-core/src/main/resources/log4j2.xml PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LogServiceIntegrationJUnitTest.java
 6425c1f 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LogServiceJUnitTest.java
 8d6278a 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LogServiceUserDirIntegrationJUnitTest.java
 4d83c22 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingIntegrationTestSuite.java
 dd9504b 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingUnitTestSuite.java
 6b7b73e 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/MergeLogFilesJUnitTest.java
 d8d774c 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerIntegrationJUnitTest.java
 f1c7ab9 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerWithDefaultConfigJUnitTest.java
 2e08500 

Diff: https://reviews.apache.org/r/39290/diff/


Testing
---

precheckin-all


Thanks,

Kirk Lund

Review Request 36377: Convert FastLoggerJUnitTest to use junit rules

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36377/
---

Review request for geode and Darrel Schneider.


Bugs: GEODE-89
https://issues.apache.org/jira/browse/GEODE-89


Repository: geode


Description
---

Convert FastLoggerJUnitTest to use junit rules


Diffs
-

  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerJUnitTest.java
 2aab5df 

Diff: https://reviews.apache.org/r/36377/diff/


Testing
---

Unit tests:
./gradlew clean test


Thanks,

Kirk Lund

Re: Review Request 37737: GEODE-275: fix race in testRegionExpirationAfterMutate

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37737/#review96435
---

Ship it!


Ship It!

- Kirk Lund


On Aug. 24, 2015, 11:23 p.m., Darrel Schneider wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37737/
 ---
 
 (Updated Aug. 24, 2015, 11:23 p.m.)
 
 
 Review request for geode and Kirk Lund.
 
 
 Bugs: GEODE-275
 https://issues.apache.org/jira/browse/GEODE-275
 
 
 Repository: geode
 
 
 Description
 ---
 
 GEODE-275: fix race in testRegionExpirationAfterMutate
 
 
 Diffs
 -
 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/MsgOutputStream.java
  9ef54d7290e9e60de3e470f523f627e5ca7f8d95 
   gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 
 c063a55e2d48f1fd55f544a7d36c7f355b03fb02 
 
 Diff: https://reviews.apache.org/r/37737/diff/
 
 
 Testing
 ---
 
 testRegionExpirationAfterMutate
 
 
 Thanks,
 
 Darrel Schneider
 

Re: Review Request 37702: GEODE-264: Fix varargs compiler warnings

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37702/#review97333
---

Ship it!


Ship It!

- Kirk Lund


On Aug. 22, 2015, 4:03 p.m., Anthony Baker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37702/
> ---
> 
> (Updated Aug. 22, 2015, 4:03 p.m.)
> 
> 
> Review request for geode and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Add casts where needed so that invoke(null, null) is now
> invoke(null, (Ojbect[]) null).
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/compression/SnappyCompressorJUnitTest.java
>  56d647af99178bdb71f6969277cfe3c3f6769ea9 
>   gemfire-core/src/test/java/dunit/standalone/DUnitLauncher.java 
> 0f2eebcfc4e17501038f4e5300ea653ebc904b4d 
> 
> Diff: https://reviews.apache.org/r/37702/diff/
> 
> 
> Testing
> ---
> 
> Ran SnappyCompressorJUnitTest and a DUnit test.
> 
> 
> Thanks,
> 
> Anthony Baker
> 
>

Re: Review Request 38015: GEODE-295 - Expecting a suspect string in BridgeMembershipDUnitTet

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38015/#review97332
---

Ship it!


Ship It!

- Kirk Lund


On Sept. 1, 2015, 8:36 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38015/
> ---
> 
> (Updated Sept. 1, 2015, 8:36 p.m.)
> 
> 
> Review request for geode and Darrel Schneider.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> testBridgeMembershipEventsInClient already had some code to expect the
> suspect string, but it was writing to a weirdly constructed logger, so I
> think it was not actually taking effect.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/cache30/BridgeMembershipDUnitTest.java
>  7f6af30740bccdb58762c8096ed83bcfd3293c22 
> 
> Diff: https://reviews.apache.org/r/38015/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: DRAFT of August report

[Kirk Lund]

+1 Looks good Swapnil!

On Mon, Aug 31, 2015 at 11:48 PM, Swapnil Bawaskar 
wrote:

> Hi All,
> The following is a draft of the August report. Please provide any feedback
> you may have.
>
> Geode:
> Geode is a data management platform that provides real-time, consistent
> access to data-intensive applications throughout widely distributed cloud
> architectures.
>
> Geode has been incubating since 2015-04-27.
>
> ** Three most important issues to address in the move towards graduation:*
> 1. Have our first Apache (incubating) release (currently blocked on us
> solving
> JGroups licensing issues) GEODE-77.
> 2. Expanding the community to include contributors and committers outside
> of Pivotal.
> 3. Execute and manage the project according to governance model required
> by the
> "Apache Way"
>
> ** Any issues that the Incubator PMC or ASF Board might wish/need to
> be aware of*
>
>  None
>
> ** How has the community developed since the last report?*
>
> Geode now has a Zeppelin interpreter.
> In August 120 issues were created and 59 resolved, bringing the total to
> 304 created and 136 resolved.
> There were 6 pull requests to github in the last 30 days, for a total of 18
> pull requests.
> There were 322 messages on the dev list and 63 messages on the user list.
> There are now 117 subscribers on the user and 127 on the dev list.
>
> Events and Conferences in August:
> QCon Rio: (30 attended)
> In-Memory Analytics and Machine Learning in practice with Spark, Geode,
> Spring XD and Docker
> <
> http://qconrio.com/workshop/memory-analytics-e-machine-learning-na-pr%C3%A1tica-com-spark-geode-spring-xd-e-docker
> >
>
> Geode Clubhouse: Roundtable where 10 issues were discussed in the
> community. https://www.youtube.com/watch?v=qaOB3d-pvTI (about 20
> participated)
>
> September:
> Geode clubhouse: Building Effective *Apache Geode* Applications with
> *Spring
> Data GemFire (Sept 8th)*
>
> Three talks at "Apache: Big Data Europe"
> - An introduction to Apache Geode (incubating)
> - Building a highly scalable open-source Real-time Streaming Analytics
> system using Spark SQL, Apache Geode (incubating), SpringXD and Apache
> Zeppelin (incubating)
> - Implementing a Highly Scalable In-Memory Stock Prediction System with
> Apache Geode (incubating), R and Spring XD
>
>
> **   How has the project developed since the last report.*
>
> Great progress has been made on JGroups issue, where many unit and
> integration tests now pass on the feature/GEODE-77 branch.
> Good progress has also been made on stabilizing CI, by fixing various
> intermittent failures in integration tests.
>
> ** Date of last release:*
>
>N/A - Just nightly builds.
>
> *Signed-off-by:*
> [ ](geode) Konstantin Boudnik
> [ ](geode) Chip Childers
> [ ](geode) Justin Erenkrantz
> [ ](geode) Jan Iversen
> [ ](geode) Chris Mattmann
> [ ](geode) William A. Rowe Jr.
> [ ](geode) Henry Saputra
> [ ](geode) Roman Shaposhnik
>

Re: GEODE-218: Dunit Fork Every 1

[Kirk Lund]

+1

I like the idea of switching to fork=1 for a few months to focus on
stabilizing any dunit tests that fail without potential test pollution
causes. These failures are mostly like ones that involve race conditions.
Once we fix these, then we could change back to fork=30.


On Fri, Sep 4, 2015 at 11:16 AM, Mark Bretl  wrote:

> I see that Kirk made an update to the issue and wanted to follow up on the
> Dev list for discussion.
>
> I also ran a build on the open side with the dunit fork = 1. The total time
> of the build was: 9 hrs 58 mins 33.662 secs. The last Geode build took: 6
> hr 21 min .
> It is an increase of about 3.5 hours, which matches the increase in time
> that Kirk had.
>
> The question becomes: Do we want to make the change so we can increase the
> quality of tests by isolating each one at the cost of increasing the total
> build time?
>
> My thoughts would be to make the change to weed out the 'bad' tests and
> increase the overall quality of the tests, so when a test fails there is no
> questioning the result. Once we have them passing more consistently, then
> we can increase the fork count again.
>
> Thoughts?
>
> --
> Mark Bretl
> Software Build Engineer
> Pivotal
> 503-533-3869
> www.pivotal.io
>

Review Request 38133: Move AgentUtilJUnitTest into a package

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38133/
---

Review request for geode and Darrel Schneider.


Bugs: GEODE-309
https://issues.apache.org/jira/browse/GEODE-309


Repository: geode


Description
---

Move AgentUtilJUnitTest from the default package into the proper package.

Remove unused imports.
Uncomment commented test and put @Ignore on it.


Diffs
-

  gemfire-assembly/src/test/java/AgentUtilJUnitTest.java 0f7563b 
  
gemfire-assembly/src/test/java/com/gemstone/gemfire/management/internal/AgentUtilJUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/38133/diff/


Testing
---

integrationTest (AgentUtilJUnitTest is an IntegrationTest)


Thanks,

Kirk Lund

Re: Review Request 38029: GEODE-306: support printing of off-heap compressed nodes

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38029/#review97796
---

Ship it!


Ship It!

- Kirk Lund


On Sept. 1, 2015, 11:46 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38029/
> ---
> 
> (Updated Sept. 1, 2015, 11:46 p.m.)
> 
> 
> Review request for geode and Kirk Lund.
> 
> 
> Bugs: GEODE-306
> https://issues.apache.org/jira/browse/GEODE-306
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Before when a chunk of off-heap compressed memory tried to
> get the type of the data stored in the chunk it needed to
> decompress the data. Since it did not know what decompressor
> to use it throw an UnsupportedOperationException.
> Now for a compressed chunk it returns the DataType as either
> a "compressed object of size xxx" or "compressed byte[xxx]".
> Unit test coverage was added.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorImpl.java
>  29319e01b4447e6929ff2f25aea41fb4cf30893c 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapValidationJUnitTest.java
>  79918727bf855795b79dd3dde7e83e8bf031eab5 
> 
> Diff: https://reviews.apache.org/r/38029/diff/
> 
> 
> Testing
> ---
> 
> OffHeapValidationJUnitTest
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Re: Review Request 38135: make pdx logging info level

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38135/#review97812
---

Ship it!


Ship It!


gemfire-core/src/main/java/com/gemstone/gemfire/pdx/internal/TypeRegistry.java 
(line 125)
<https://reviews.apache.org/r/38135/#comment153834>

We should be optimizing for info level logging which means not using "if 
(logger.isInfoEnabled())"

It's only worth doing if it's for debug or trace because most people won't 
run in production with debug or trace.


- Kirk Lund


On Sept. 4, 2015, 8:50 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38135/
> ---
> 
> (Updated Sept. 4, 2015, 8:50 p.m.)
> 
> 
> Review request for geode and Kirk Lund.
> 
> 
> Bugs: GEODE-311
> https://issues.apache.org/jira/browse/GEODE-311
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> make pdx logging info level
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/pdx/internal/TypeRegistry.java
>  4ca1a90725221d1be4ccdc797559276a483b0e60 
> 
> Diff: https://reviews.apache.org/r/38135/diff/
> 
> 
> Testing
> ---
> 
> all unit tests
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Re: Review Request 38133: Move AgentUtilJUnitTest into a package

[Kirk Lund]

> On None, Kirk Lund wrote:
> > Ship It!

Ignore this. I meant to hit "Publish" instead of "Ship It!" (long week!)


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38133/#review97786
---


On Sept. 4, 2015, 7:36 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38133/
> ---
> 
> (Updated Sept. 4, 2015, 7:36 p.m.)
> 
> 
> Review request for geode and Darrel Schneider.
> 
> 
> Bugs: GEODE-309
> https://issues.apache.org/jira/browse/GEODE-309
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Move AgentUtilJUnitTest from the default package into the proper package.
> 
> Remove unused imports.
> Uncomment commented test and put @Ignore on it.
> 
> 
> Diffs
> -
> 
>   gemfire-assembly/src/test/java/AgentUtilJUnitTest.java 0f7563b 
>   
> gemfire-assembly/src/test/java/com/gemstone/gemfire/management/internal/AgentUtilJUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38133/diff/
> 
> 
> Testing
> ---
> 
> integrationTest (AgentUtilJUnitTest is an IntegrationTest)
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>