[RESULT] [VOTE] Release Apache Maven PMD Plugin version 3.7
Hi, The vote has passed with the following result: +1 : Olivier Lamy, Hervé Boutemy, Arnaud Héritier PMC quorum: reached I will promote the artifacts to the central repo. Am 10.10.2016 um 20:15 schrieb Andreas Dangel: > Hi, > > We solved 11 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317621&version=12334373&styleName=Text > > There are still a couple of issues left in JIRA: > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MPMD%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC > > Staging repo: > https://repository.apache.org/content/repositories/maven-1287 > https://repository.apache.org/content/repositories/maven-1287/org/apache/maven/plugins/maven-pmd-plugin/3.7/maven-pmd-plugin-3.7-source-release.zip > > Source release checksum(s): > maven-pmd-plugin-3.7-source-release.zip sha1: > a8ccd94fa6c41ef66ad29932027eb03ca45b402d > > Staging site: > https://maven.apache.org/plugins-archives/maven-pmd-plugin-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > Regards, > Andreas > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > -- Andreas Dangel https://github.com/adangel skype: andreas_dangel - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Support needed for releasing m-pmd-p 3.7
Hi, I'm currently in the process of publishing m-pmd-p 3.7 - and for some steps, I need support: * "Copy the source release to the Apache Distribution Area" - I guess, this always needs to be done by a PMC member. It's already synced to central [1]. * "Update the version tracking in JIRA" - It seems, I don't have sufficient permissions to do that. At least, I don't see anything to administer the project MPMD [2] in order to release version 3.7 and create version 3.8. Should I be able to do that on my own? * I'm a bit unsure about the plugins index page [3]. I've updated the trunk version [4]. Is this the correct one? As the CMS seems to be pointing to an older version... Regards, Andreas [1]: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-pmd-plugin/3.7/ [2]: https://issues.apache.org/jira/browse/MPMD/ [3]: https://maven.apache.org/plugins/ [4]: https://svn.apache.org/repos/asf/maven/site/trunk/content/apt/plugins/index.apt - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #86: Modifying test in DefaultWagonManagerTest
Github user asfgit closed the pull request at: https://github.com/apache/maven/pull/86 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Some thoughts on Maven 5
Adding a section to the wiki to help track this https://cwiki.apache.org/confluence/display/MAVEN/POM+Model+Version+5.0.0 On 16 October 2016 at 04:12, Christian Schulte wrote: > Am 10/16/16 um 02:03 schrieb Stephen Connolly: > >> On 16 Oct 2016, at 00:07, Christian Schulte wrote: > >> Any thoughts about how to name that new build pom? > > > > project.mvn or pom.mvn > > > > But only if we move to a non-xml DSL > > > > If we are still XML then I say stick with pom.xml and sniff the > modelVersion > > +1 > > Being able to build all Maven 2+ kinds of projects using Maven 5+ would > be cool. It's not a must have in my opinion. If this would degrade the > possibilities of Maven 5+, I'd say it's worth giving up on it. > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
AW: Some thoughts on Maven 5
Hi guys, I just wanted to add one thing to the list: https://issues.apache.org/jira/browse/MNG-6107 But I can't edit or comment on the page: https://cwiki.apache.org/confluence/display/MAVEN/POM+Model+Version+5.0.0 Chris Von: Stephen Connolly Gesendet: Sonntag, 16. Oktober 2016 13:33:29 An: Maven Developers List Betreff: Re: Some thoughts on Maven 5 Adding a section to the wiki to help track this https://cwiki.apache.org/confluence/display/MAVEN/POM+Model+Version+5.0.0 On 16 October 2016 at 04:12, Christian Schulte wrote: > Am 10/16/16 um 02:03 schrieb Stephen Connolly: > >> On 16 Oct 2016, at 00:07, Christian Schulte wrote: > >> Any thoughts about how to name that new build pom? > > > > project.mvn or pom.mvn > > > > But only if we move to a non-xml DSL > > > > If we are still XML then I say stick with pom.xml and sniff the > modelVersion > > +1 > > Being able to build all Maven 2+ kinds of projects using Maven 5+ would > be cool. It's not a must have in my opinion. If this would degrade the > possibilities of Maven 5+, I'd say it's worth giving up on it. > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: Some thoughts on Maven 5
Let us know your cwiki username and we can grant permission to edit On Sunday 16 October 2016, Christofer Dutz wrote: > Hi guys, > > > I just wanted to add one thing to the list: > > https://issues.apache.org/jira/browse/MNG-6107 > > But I can't edit or comment on the page: > > https://cwiki.apache.org/confluence/display/MAVEN/POM+Model+Version+5.0.0 > > > Chris > > > Von: Stephen Connolly > > Gesendet: Sonntag, 16. Oktober 2016 13:33:29 > An: Maven Developers List > Betreff: Re: Some thoughts on Maven 5 > > Adding a section to the wiki to help track this > > https://cwiki.apache.org/confluence/display/MAVEN/POM+Model+Version+5.0.0 > > On 16 October 2016 at 04:12, Christian Schulte > wrote: > > > Am 10/16/16 um 02:03 schrieb Stephen Connolly: > > >> On 16 Oct 2016, at 00:07, Christian Schulte > wrote: > > >> Any thoughts about how to name that new build pom? > > > > > > project.mvn or pom.mvn > > > > > > But only if we move to a non-xml DSL > > > > > > If we are still XML then I say stick with pom.xml and sniff the > > modelVersion > > > > +1 > > > > Being able to build all Maven 2+ kinds of projects using Maven 5+ would > > be cool. It's not a must have in my opinion. If this would degrade the > > possibilities of Maven 5+, I'd say it's worth giving up on it. > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > -- Sent from my phone
Re: Some thoughts on Maven 5
I'm kind of against includes and import... I favour mix-ins as the solution to that set of problems... Additionally I see all the "hacks" people have evolved as been significantly less relevant with PDTs including both ranges and hints as well as the provides and supports declarations... but yes we need to address what we see as the "resolution" of these issues is in the 5.0.0+ world On Sunday 16 October 2016, Christofer Dutz wrote: > Hi guys, > > > I just wanted to add one thing to the list: > > https://issues.apache.org/jira/browse/MNG-6107 > > But I can't edit or comment on the page: > > https://cwiki.apache.org/confluence/display/MAVEN/POM+Model+Version+5.0.0 > > > Chris > > > Von: Stephen Connolly > > Gesendet: Sonntag, 16. Oktober 2016 13:33:29 > An: Maven Developers List > Betreff: Re: Some thoughts on Maven 5 > > Adding a section to the wiki to help track this > > https://cwiki.apache.org/confluence/display/MAVEN/POM+Model+Version+5.0.0 > > On 16 October 2016 at 04:12, Christian Schulte > wrote: > > > Am 10/16/16 um 02:03 schrieb Stephen Connolly: > > >> On 16 Oct 2016, at 00:07, Christian Schulte > wrote: > > >> Any thoughts about how to name that new build pom? > > > > > > project.mvn or pom.mvn > > > > > > But only if we move to a non-xml DSL > > > > > > If we are still XML then I say stick with pom.xml and sniff the > > modelVersion > > > > +1 > > > > Being able to build all Maven 2+ kinds of projects using Maven 5+ would > > be cool. It's not a must have in my opinion. If this would degrade the > > possibilities of Maven 5+, I'd say it's worth giving up on it. > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > -- Sent from my phone
AW: Some thoughts on Maven 5
Hi Stephen, My Username is "cdutz". Chris Von: Stephen Connolly Gesendet: Sonntag, 16. Oktober 2016 13:49:39 An: Maven Developers List Betreff: Re: Some thoughts on Maven 5 Let us know your cwiki username and we can grant permission to edit On Sunday 16 October 2016, Christofer Dutz wrote: > Hi guys, > > > I just wanted to add one thing to the list: > > https://issues.apache.org/jira/browse/MNG-6107 > > But I can't edit or comment on the page: > > https://cwiki.apache.org/confluence/display/MAVEN/POM+Model+Version+5.0.0 > > > Chris > > > Von: Stephen Connolly > > Gesendet: Sonntag, 16. Oktober 2016 13:33:29 > An: Maven Developers List > Betreff: Re: Some thoughts on Maven 5 > > Adding a section to the wiki to help track this > > https://cwiki.apache.org/confluence/display/MAVEN/POM+Model+Version+5.0.0 > > On 16 October 2016 at 04:12, Christian Schulte > wrote: > > > Am 10/16/16 um 02:03 schrieb Stephen Connolly: > > >> On 16 Oct 2016, at 00:07, Christian Schulte > wrote: > > >> Any thoughts about how to name that new build pom? > > > > > > project.mvn or pom.mvn > > > > > > But only if we move to a non-xml DSL > > > > > > If we are still XML then I say stick with pom.xml and sniff the > > modelVersion > > > > +1 > > > > Being able to build all Maven 2+ kinds of projects using Maven 5+ would > > be cool. It's not a must have in my opinion. If this would degrade the > > possibilities of Maven 5+, I'd say it's worth giving up on it. > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > -- Sent from my phone
Re: Some thoughts on Maven 5
Karl/John can you give permissions to edit (or at least comment) to Christofer Also perhaps we should add all the PMC as owners of the space On Sunday 16 October 2016, Christofer Dutz wrote: > Hi Stephen, > > > My Username is "cdutz". > > > Chris > > > Von: Stephen Connolly > > Gesendet: Sonntag, 16. Oktober 2016 13:49:39 > An: Maven Developers List > Betreff: Re: Some thoughts on Maven 5 > > Let us know your cwiki username and we can grant permission to edit > > On Sunday 16 October 2016, Christofer Dutz > > wrote: > > > Hi guys, > > > > > > I just wanted to add one thing to the list: > > > > https://issues.apache.org/jira/browse/MNG-6107 > > > > But I can't edit or comment on the page: > > > > https://cwiki.apache.org/confluence/display/MAVEN/POM+ > Model+Version+5.0.0 > > > > > > Chris > > > > > > Von: Stephen Connolly > > > > Gesendet: Sonntag, 16. Oktober 2016 13:33:29 > > An: Maven Developers List > > Betreff: Re: Some thoughts on Maven 5 > > > > Adding a section to the wiki to help track this > > > > https://cwiki.apache.org/confluence/display/MAVEN/POM+ > Model+Version+5.0.0 > > > > On 16 October 2016 at 04:12, Christian Schulte > > > wrote: > > > > > Am 10/16/16 um 02:03 schrieb Stephen Connolly: > > > >> On 16 Oct 2016, at 00:07, Christian Schulte > > > wrote: > > > >> Any thoughts about how to name that new build pom? > > > > > > > > project.mvn or pom.mvn > > > > > > > > But only if we move to a non-xml DSL > > > > > > > > If we are still XML then I say stick with pom.xml and sniff the > > > modelVersion > > > > > > +1 > > > > > > Being able to build all Maven 2+ kinds of projects using Maven 5+ would > > > be cool. It's not a must have in my opinion. If this would degrade the > > > possibilities of Maven 5+, I'd say it's worth giving up on it. > > > > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > > > > > -- > Sent from my phone > -- Sent from my phone
Re: Support needed for releasing m-pmd-p 3.7
Am 2016-10-16 um 11:16 schrieb Andreas Dangel: Hi, I'm currently in the process of publishing m-pmd-p 3.7 - and for some steps, I need support: * "Copy the source release to the Apache Distribution Area" - I guess, this always needs to be done by a PMC member. It's already synced to central [1]. I will perform that for you today. * "Update the version tracking in JIRA" - It seems, I don't have sufficient permissions to do that. At least, I don't see anything to administer the project MPMD [2] in order to release version 3.7 and create version 3.8. Should I be able to do that on my own? Done. Request with Brian Fox. * I'm a bit unsure about the plugins index page [3]. I've updated the trunk version [4]. Is this the correct one? As the CMS seems to be pointing to an older version... Looks fine in the Subversion repo. Request cms.a.o to republish the site. Michael - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Support needed for releasing m-pmd-p 3.7
Am 2016-10-16 um 11:16 schrieb Andreas Dangel: Hi, I'm currently in the process of publishing m-pmd-p 3.7 - and for some steps, I need support: * "Copy the source release to the Apache Distribution Area" - I guess, this always needs to be done by a PMC member. It's already synced to central [1]. Hervé was faster. Issue resolved. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Support needed for releasing m-pmd-p 3.7
Le dimanche 16 octobre 2016 14:55:12 Michael Osipov a écrit : > Am 2016-10-16 um 11:16 schrieb Andreas Dangel: > > Hi, > > > > I'm currently in the process of publishing m-pmd-p 3.7 - and for some > > steps, I need support: > > > > * "Copy the source release to the Apache Distribution Area" - I guess, > > this always needs to be done by a PMC member. It's already synced to > > central [1]. > > I will perform that for you today. done :) > > > * "Update the version tracking in JIRA" - It seems, I don't have > > sufficient permissions to do that. At least, I don't see anything to > > administer the project MPMD [2] in order to release version 3.7 and > > create version 3.8. Should I be able to do that on my own? > > Done. Request with Brian Fox. no need to ask Brian: it's our current permission scheme for ou 65 Jira projects, with 2 different developer and PMC member roles If we want to change something, let's do it in a consistent way, not specifically for someone on one Jira project (something every PMC member can even do himself, since PMC member role makes you administrator for the Jira projects: Brian is needed to swith from developer to PMC member role, as he is global Jira administrator) > > > * I'm a bit unsure about the plugins index page [3]. I've updated the > > trunk version [4]. Is this the correct one? As the CMS seems to be > > pointing to an older version... > > Looks fine in the Subversion repo. Request cms.a.o to republish the site. > > Michael > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[ANN] Apache Maven PMD Plugin 3.7 Released
The Maven team is pleased to announce the release of the Apache Maven PMD Plugin, version 3.7 A Maven plugin for the PMD toolkit, that produces a report on both code rule violations and detected copy and paste fragments, as well as being able to fail the build based on these metrics. http://maven.apache.org/plugins/maven-pmd-plugin/ You should specify the version in your project's plugin configuration: org.apache.maven.plugins maven-pmd-plugin 3.7 Release Notes - Apache Maven PMD Plugin - Version 3.7 Bug * [MPMD-162] - PMD/CPD report does not take into account pmd.excludeFromFailureFile * [MPMD-178] - ExcludeRoots doesn't handle subdirectories (PMD isn't working nicely with Android projects) * [MPMD-213] - Remove unnecessary (read-only) parameter "language" from check goal * [MPMD-219] - Maven PMD Plugin ignores PMD processing errors Improvement * [MPMD-212] - Add documentation and IT for MPMD-206 * [MPMD-220] - Upgrade to PMD 5.5.1 (requires Java 7) * [MPMD-227] - Document multimodule configuration example * [MPMD-228] - Upgrade maven-plugins to version 30 * [MPMD-229] - Cleanup POM, remove temporary workarounds Enjoy, -The Maven team - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Support needed for releasing m-pmd-p 3.7
Thanks! I just sent out the annoucement. The cms.a.o publish action was indeed the bit, I missed. Michael updated Jira for me, so everything is in place now. Cheers, Andreas Am 16.10.2016 um 15:16 schrieb Hervé BOUTEMY: > Le dimanche 16 octobre 2016 14:55:12 Michael Osipov a écrit : >> Am 2016-10-16 um 11:16 schrieb Andreas Dangel: >>> Hi, >>> >>> I'm currently in the process of publishing m-pmd-p 3.7 - and for some >>> steps, I need support: >>> >>> * "Copy the source release to the Apache Distribution Area" - I guess, >>> this always needs to be done by a PMC member. It's already synced to >>> central [1]. >> I will perform that for you today. > done :) > >>> * "Update the version tracking in JIRA" - It seems, I don't have >>> sufficient permissions to do that. At least, I don't see anything to >>> administer the project MPMD [2] in order to release version 3.7 and >>> create version 3.8. Should I be able to do that on my own? >> Done. Request with Brian Fox. > no need to ask Brian: it's our current permission scheme for ou 65 Jira > projects, with 2 different developer and PMC member roles > > If we want to change something, let's do it in a consistent way, not > specifically for someone on one Jira project (something every PMC member can > even do himself, since PMC member role makes you administrator for the Jira > projects: Brian is needed to swith from developer to PMC member role, as he > is > global Jira administrator) > >>> * I'm a bit unsure about the plugins index page [3]. I've updated the >>> trunk version [4]. Is this the correct one? As the CMS seems to be >>> pointing to an older version... >> Looks fine in the Subversion repo. Request cms.a.o to republish the site. >> >> Michael >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
ApacheCon Europe 2016 in Sevilla
this event will happen on November 16-18: http://events.linuxfoundation.org/events/apachecon-europe Robert will do a talk (and I'll help him as I can): http://sched.co/8ULK I just updated Wiki page for the event: https://cwiki.apache.org/confluence/display/MAVEN/Meetups Who will attend in addition? (and you can also update past events, just for the records...) Regards, Hervé - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugins pull request #20: MCHANGES-376 Log level fix for ProjectUtils.
Github user asfgit closed the pull request at: https://github.com/apache/maven-plugins/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven git commit: [MNG-6105] properties.internal.SystemProperties.addSystemProperties() is not really thread-safe
Btw: Do you know why and where system properties are being removed?
Am 10/16/16 um 01:40 schrieb gb...@apache.org:
> Repository: maven
> Updated Branches:
> refs/heads/master f7c1359cf -> ace448158
>
>
> [MNG-6105] properties.internal.SystemProperties.addSystemProperties() is
> not really thread-safe
>
> Refactoring the current code setting system properties to synchronize
> correctly on the given ones: avoids ConcurrentModificationException and
> NullPointerException if the properties is modified by another thread.
>
> Project: http://git-wip-us.apache.org/repos/asf/maven/repo
> Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/ace44815
> Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/ace44815
> Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/ace44815
>
> Branch: refs/heads/master
> Commit: ace448158131285e5ef8fb54b96dfb3d8d05f37e
> Parents: f7c1359
> Author: Guillaume Boué
> Authored: Sun Oct 16 01:40:46 2016 +0200
> Committer: Guillaume Boué
> Committed: Sun Oct 16 01:40:46 2016 +0200
>
> --
> .../internal/MavenRepositorySystemUtils.java| 21 +++-
> .../execution/DefaultMavenExecutionRequest.java | 4 +--
> .../project/DefaultProjectBuildingRequest.java | 7 ++--
> .../properties/internal/SystemProperties.java | 35
> .../building/DefaultModelBuildingRequest.java | 5 ++-
> .../DefaultSettingsBuildingRequest.java | 12 ++-
> 6 files changed, 38 insertions(+), 46 deletions(-)
> --
>
>
> http://git-wip-us.apache.org/repos/asf/maven/blob/ace44815/maven-aether-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java
> --
> diff --git
> a/maven-aether-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java
>
> b/maven-aether-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java
> index 877c277..645fd1c 100644
> ---
> a/maven-aether-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java
> +++
> b/maven-aether-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java
> @@ -19,9 +19,6 @@ package org.apache.maven.repository.internal;
> * under the License.
> */
>
> -import java.io.ByteArrayInputStream;
> -import java.io.ByteArrayOutputStream;
> -import java.io.IOException;
> import java.util.Properties;
>
> import org.eclipse.aether.DefaultRepositorySystemSession;
> @@ -130,22 +127,14 @@ public final class MavenRepositorySystemUtils
>
> session.setArtifactDescriptorPolicy( new
> SimpleArtifactDescriptorPolicy( true, true ) );
>
> +final Properties systemProperties = new Properties();
> +
> // MNG-5670 guard against ConcurrentModificationException
> // MNG-6053 guard against key without value
> -final Properties systemProperties = new Properties();
> -// This relies on the fact that load/store are synchronized
> internally.
> -try ( final ByteArrayOutputStream out = new ByteArrayOutputStream() )
> -{
> -System.getProperties().store( out, null );
> -
> -try ( final ByteArrayInputStream in = new ByteArrayInputStream(
> out.toByteArray() ) )
> -{
> -systemProperties.load( in );
> -}
> -}
> -catch ( final IOException e )
> +Properties sysProp = System.getProperties();
> +synchronized ( sysProp )
> {
> -throw new AssertionError( "Unexpected IO error copying system
> properties.", e );
> +systemProperties.putAll( sysProp );
> }
>
> session.setSystemProperties( systemProperties );
>
> http://git-wip-us.apache.org/repos/asf/maven/blob/ace44815/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
> --
> diff --git
> a/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
>
> b/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
> index 71a6894..d67061f 100644
> ---
> a/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
> +++
> b/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
> @@ -33,6 +33,7 @@ import
> org.apache.maven.eventspy.internal.EventSpyDispatcher;
> import org.apache.maven.model.Profile;
> import org.apache.maven.project.DefaultProjectBuildingRequest;
> import org.apache.maven.project.ProjectBuildingRequest;
> +import org.apache.maven.properties.internal.SystemProperties;
> import org.apache.maven.settings.Mirror;
> import org.apache.maven.settings.Pr
[JIGSAW] third party dependencies causing Maven projects to fail
Hi, I've updated Java9/Jigsaw confluence page[1]. A new chapter has been added: a list of third party libraries where our projects depend on (though most are related to integration tests, compile-time is still looking fine), starting with the causes of failing integration tests of the maven-compiler-plugin when running with -Dinvoker.javaHome=/path/to/jdk-9 In some cases I've had contact with one of the maintainers, but for some I'm missing a contact. Concrete I have 2 projects where I could use some help: - com.google.errorprone, another compiler implementation - gmaven/groovy. We're still using org.codehaus.gmaven:gmaven-plugin to execute groovy-scripts, but I wonder if this is still the preferred plugin to do so. Anyone hitting issues with third party libraries in relation with Java9 and Maven is encouraged to update this page too. thanks, Robert [1] https://cwiki.apache.org/confluence/display/MAVEN/Java+9+-+Jigsaw - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven git commit: [MNG-6105] properties.internal.SystemProperties.addSystemProperties() is not really thread-safe
Am 2016-10-16 um 18:39 schrieb Christian Schulte:
Btw: Do you know why and where system properties are being removed?
This is still the question and I would like to have an answer for.
Am 10/16/16 um 01:40 schrieb gb...@apache.org:
Repository: maven
Updated Branches:
refs/heads/master f7c1359cf -> ace448158
[MNG-6105] properties.internal.SystemProperties.addSystemProperties() is
not really thread-safe
Refactoring the current code setting system properties to synchronize
correctly on the given ones: avoids ConcurrentModificationException and
NullPointerException if the properties is modified by another thread.
Project: http://git-wip-us.apache.org/repos/asf/maven/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/ace44815
Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/ace44815
Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/ace44815
Branch: refs/heads/master
Commit: ace448158131285e5ef8fb54b96dfb3d8d05f37e
Parents: f7c1359
Author: Guillaume Boué
Authored: Sun Oct 16 01:40:46 2016 +0200
Committer: Guillaume Boué
Committed: Sun Oct 16 01:40:46 2016 +0200
--
.../internal/MavenRepositorySystemUtils.java| 21 +++-
.../execution/DefaultMavenExecutionRequest.java | 4 +--
.../project/DefaultProjectBuildingRequest.java | 7 ++--
.../properties/internal/SystemProperties.java | 35
.../building/DefaultModelBuildingRequest.java | 5 ++-
.../DefaultSettingsBuildingRequest.java | 12 ++-
6 files changed, 38 insertions(+), 46 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/maven/blob/ace44815/maven-aether-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java
--
diff --git
a/maven-aether-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java
b/maven-aether-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java
index 877c277..645fd1c 100644
---
a/maven-aether-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java
+++
b/maven-aether-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java
@@ -19,9 +19,6 @@ package org.apache.maven.repository.internal;
* under the License.
*/
-import java.io.ByteArrayInputStream;
-import java.io.ByteArrayOutputStream;
-import java.io.IOException;
import java.util.Properties;
import org.eclipse.aether.DefaultRepositorySystemSession;
@@ -130,22 +127,14 @@ public final class MavenRepositorySystemUtils
session.setArtifactDescriptorPolicy( new
SimpleArtifactDescriptorPolicy( true, true ) );
+final Properties systemProperties = new Properties();
+
// MNG-5670 guard against ConcurrentModificationException
// MNG-6053 guard against key without value
-final Properties systemProperties = new Properties();
-// This relies on the fact that load/store are synchronized internally.
-try ( final ByteArrayOutputStream out = new ByteArrayOutputStream() )
-{
-System.getProperties().store( out, null );
-
-try ( final ByteArrayInputStream in = new ByteArrayInputStream(
out.toByteArray() ) )
-{
-systemProperties.load( in );
-}
-}
-catch ( final IOException e )
+Properties sysProp = System.getProperties();
+synchronized ( sysProp )
{
-throw new AssertionError( "Unexpected IO error copying system
properties.", e );
+systemProperties.putAll( sysProp );
}
session.setSystemProperties( systemProperties );
http://git-wip-us.apache.org/repos/asf/maven/blob/ace44815/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
--
diff --git
a/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
b/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
index 71a6894..d67061f 100644
---
a/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
+++
b/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
@@ -33,6 +33,7 @@ import org.apache.maven.eventspy.internal.EventSpyDispatcher;
import org.apache.maven.model.Profile;
import org.apache.maven.project.DefaultProjectBuildingRequest;
import org.apache.maven.project.ProjectBuildingRequest;
+import org.apache.maven.properties.internal.SystemProperties;
import org.apache.maven.settings.Mirror;
import org.apache.maven.settings.Proxy;
import org.apache.maven.settings.Server;
@@ -535,8 +536,7 @@ public class DefaultMavenExecutionRequest
module-info hygiene
Hi, with the introduction of the module-info something interesting is happening. Up until now the scope of a Java project was limited to the compilation of the classes. In case of Maven the end-user was in full control regarding the classpath and the order of entries. With the order of the dependencies you can control the order of classpath entries. You could add your own dependencies but could also exclude them. The exclude is especially powerful in those cases where library builders have made mistakes (e.g. junit without test-scope) or simply forgot to remove dependencies when refactoring code. The first project poms are often quite clean, but it requires discipline to keep cleaning up your pom, e.g. removing unused dependencies. However, you're not really punished if you don't do this. With the shift to module-info, suddenly every library-builder gets control. If the module-info of that library "requires A.B", it means that every project using this library MUST have A.B on its module-path. As end-user you cannot exclude A.B, nor can you say "B.A replaces A.B for x.y.z" in case of duplicate classes as allowed on the classpath. In short: the end-users must rely on the discipline of library builders. This loss of control for the end-user will have huge impact. Maven has a analyze-goal in the maven-dependency-plugin which show both unused declared dependencies and used undeclared dependencies (which means pulled in as transitive dependency, even though the code directly uses it). Almost every time I run this goal on any project it detects dependencies in one of both groups. To enforce the discipline, the java compiler should IMHO at least check if all required modules are indeed required and if the transitive required modules are indeed transitive. The role of the module-info is way too important to simply allow all content. The scope is not just about the classes anymore; the complete module tree is now locked into the jar. Any mis-configured module-info down the tree can never be fixed by the end-user, which could block the end-user to use the modulepath. just sharing my concerns, Robert - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
ASF IRC Services and Archives
http://wilderness.apache.org/ Just found out about this... should we request to get this setup for our two IRC channels on freenode? My vote is yes Sent from my iPhone - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Maven Resolver 1.2 with Maven 3.4?
Hi folks, are we going to incorporate v 1.2 of Resolver into Maven 3.4? I've seen that Christian done some fixing required by some MNGs as well as our rebranding of the project. Some dependencies need to be updated to match Maven's but it would be a good test having it in 3.4-0-rc-1. WDYT? Michael - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: ASF IRC Services and Archives
+1 On Sun, 16 Oct 2016 21:13:53 +0200, Stephen Connolly wrote: http://wilderness.apache.org/ Just found out about this... should we request to get this setup for our two IRC channels on freenode? My vote is yes Sent from my iPhone - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Plexus Archiver Replaces the Original Zip Archive on Update
Hi, There is an issue on Plexus Archiver about that when ZipArchiver.setUpdateMode() is set to true, the original archive is overridden instead of updated - https://github.com/codehaus-plexus/plexus-archiver/issues/2 As the issue is over an year old and it did not receive much attention I was wondering if there are any Maven plugins affected by it. Regards, Plamen Totev - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: ASF IRC Services and Archives
INFRA-12772 On 16 October 2016 at 20:43, Robert Scholte wrote: > +1 > > > On Sun, 16 Oct 2016 21:13:53 +0200, Stephen Connolly < > stephen.alan.conno...@gmail.com> wrote: > > >> http://wilderness.apache.org/ >> >> Just found out about this... should we request to get this setup for our >> two IRC channels on freenode? >> >> My vote is yes >> >> Sent from my iPhone >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: Maven Resolver 1.2 with Maven 3.4?
Am 10/16/16 um 21:43 schrieb Michael Osipov: > Hi folks, > > are we going to incorporate v 1.2 of Resolver into Maven 3.4? I've seen > that Christian done some fixing required by some MNGs as well as our > rebranding of the project. Some dependencies need to be updated to match > Maven's but it would be a good test having it in 3.4-0-rc-1. > > WDYT? > > Michael +1 Is the resolver repository ready for commits? I stopped working on it back when it wasn't clear how things will be refactored and committed WIP with one single commit just to have the changes in the repository before refactoring. I'd need to clean things up and would like to create JIRA tickets for the changes as well. There are build jobs setup? Integration with JIRA also setup? Regards, -- Christian - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [jira] [Created] (MRESOLVER-4) Use Commons Lang's Validate to intercept invalid input
Will the resolver be upgraded to Java 7? I would use 'java.util.Objects'
then.
Am 10/16/16 um 22:30 schrieb Michael Osipov (JIRA):
> Michael Osipov created MRESOLVER-4:
> --
>
> Summary: Use Commons Lang's Validate to intercept invalid input
> Key: MRESOLVER-4
> URL: https://issues.apache.org/jira/browse/MRESOLVER-4
> Project: Maven Resolver
> Issue Type: Improvement
> Affects Versions: Maven Artifact Resolver 1.2.0
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Minor
> Fix For: Maven Artifact Resolver 1.2.0
>
>
> In several spots of Maven Resolver IAE is thrown where an argument is null.
> This should be turned into NullPointerException since JDK adheres to is and
> the description of this exception indicates that and Effective Java does that
> too.
>
> Most likely to be misused:
> {noformat}
> $ grep -r "throw new IllegalArgumentException" .
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java:
> throw new IllegalArgumentException( "Bad artifact coordinates " +
> coords
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
> throw new IllegalArgumentException( "no type id specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:
> throw new IllegalArgumentException( "no type id specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/collection/CollectResult.java:
> throw new IllegalArgumentException( "dependency collection
> request has not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java:
> throw new IllegalArgumentException( "repository system session
> not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/deployment/DeployResult.java:
> throw new IllegalArgumentException( "deploy request has not been
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/graph/DefaultDependencyNode.java:
> throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/graph/Dependency.java:
> throw new IllegalArgumentException( "no artifact specified for
> dependency" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/installation/InstallResult.java:
> throw new IllegalArgumentException( "install request has not been
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/metadata/DefaultMetadata.java:
> throw new IllegalArgumentException( "metadata nature was not
> specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "repository system session
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "authentication data key
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:
> throw new IllegalArgumentException( "authentication data key
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalArtifactResult.java:
> throw new IllegalArgumentException( "local artifact request has
> not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalMetadataResult.java:
> throw new IllegalArgumentException( "local metadata request has
> not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/RemoteRepository.java:
> throw new IllegalArgumentException( "repository prototype
> missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java:
> throw new IllegalArgumentException( "session not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java:
> throw new IllegalArgumentException( "event type not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactDescriptorResult.java:
> throw new IllegalArgumentException( "artifact descriptor request
> has not been specified" );
> ./maven-resolver-api/src/main/java/or
Re: [jira] [Created] (MRESOLVER-4) Use Commons Lang's Validate to intercept invalid input
Am 2016-10-16 um 22:48 schrieb Christian Schulte: Will the resolver be upgraded to Java 7? I would use 'java.util.Objects' then. I have the very same idea. I wouldn't mind using j.u.Objects instead of o.a.c.l4.Validate. Is there any compelling reason not to switch to Java 7? NIO2 and try-with-resources is nice. Michael - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [jira] [Created] (MRESOLVER-4) Use Commons Lang's Validate to intercept invalid input
Am 10/16/16 um 22:51 schrieb Michael Osipov: > Am 2016-10-16 um 22:48 schrieb Christian Schulte: >> Will the resolver be upgraded to Java 7? I would use 'java.util.Objects' >> then. > > I have the very same idea. I wouldn't mind using j.u.Objects instead of > o.a.c.l4.Validate. > > Is there any compelling reason not to switch to Java 7? NIO2 and > try-with-resources is nice. > +1 for Java 7 Maven already is targeting Java 7. Depends on the other users of the resolver. If one of them still is not at Java 7, we will not be able to upgrade. I would not upgrade to Java 6 and keep it Java 5 then. So we go from 5 to 7 somewhen and skip 6. Regards, -- Christian - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugins pull request #17: Allow help:evaluate output in quiet mode (MP...
Github user asfgit closed the pull request at: https://github.com/apache/maven-plugins/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [jira] [Created] (MRESOLVER-4) Use Commons Lang's Validate to intercept invalid input
Let's just go for Java 7... this is linked to core... if you are stuck on an older Java likely you can't upgrade Maven anyway On Sunday 16 October 2016, Christian Schulte wrote: > Am 10/16/16 um 22:51 schrieb Michael Osipov: > > Am 2016-10-16 um 22:48 schrieb Christian Schulte: > >> Will the resolver be upgraded to Java 7? I would use 'java.util.Objects' > >> then. > > > > I have the very same idea. I wouldn't mind using j.u.Objects instead of > > o.a.c.l4.Validate. > > > > Is there any compelling reason not to switch to Java 7? NIO2 and > > try-with-resources is nice. > > > > +1 for Java 7 > > Maven already is targeting Java 7. Depends on the other users of the > resolver. If one of them still is not at Java 7, we will not be able to > upgrade. I would not upgrade to Java 6 and keep it Java 5 then. So we go > from 5 to 7 somewhen and skip 6. > > Regards, > -- > Christian > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Sent from my phone
[GitHub] maven-plugins pull request #1: Patch to address http://jira.codehaus.org/bro...
Github user gmcdonald closed the pull request at: https://github.com/apache/maven-plugins/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugins pull request #84: added initial .travis.yml
Github user gmcdonald closed the pull request at: https://github.com/apache/maven-plugins/pull/84 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugins pull request #75: Fix "Can not use a comma (,) in option addit...
Github user gmcdonald closed the pull request at: https://github.com/apache/maven-plugins/pull/75 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugins pull request #65: Try to replace absolute source directory pat...
Github user gmcdonald closed the pull request at: https://github.com/apache/maven-plugins/pull/65 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugins pull request #60: Add new option "failOnWarning".
Github user gmcdonald closed the pull request at: https://github.com/apache/maven-plugins/pull/60 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugins pull request #37: Generate RSS/Atom feeds for the site.
Github user gmcdonald closed the pull request at: https://github.com/apache/maven-plugins/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugins pull request #29: MPDF-66 maven-pdf-plugin puts project.proper...
Github user gmcdonald closed the pull request at: https://github.com/apache/maven-plugins/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugins pull request #26: [MDEPLOY-173] support flat pom functionality...
Github user gmcdonald closed the pull request at: https://github.com/apache/maven-plugins/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #66: Upgrade to Eclipse/Sisu 0.3.2
Github user gmcdonald closed the pull request at: https://github.com/apache/maven/pull/66 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-doxia-sitetools pull request #3: Actually display the "open in new win...
Github user gmcdonald closed the pull request at: https://github.com/apache/maven-doxia-sitetools/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugins pull request #76: Java 9 fixes
Github user gmcdonald closed the pull request at: https://github.com/apache/maven-plugins/pull/76 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-shared pull request #11: MJAR-223 - classpathLayoutType is not taken i...
Github user gmcdonald closed the pull request at: https://github.com/apache/maven-shared/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugins pull request #29: MPDF-66 maven-pdf-plugin puts project.proper...
GitHub user lbreuss reopened a pull request: https://github.com/apache/maven-plugins/pull/29 MPDF-66 maven-pdf-plugin puts project.properties into Velocity context. It works. Are there any side effects to be expected by putting all project.properties into the renderer context? You can merge this pull request into a Git repository by running: $ git pull https://github.com/lbreuss/maven-plugins trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-plugins/pull/29.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #29 commit 03165a8a48cb6e969318bcc08ee60f63bc198778 Author: Leo Breuss Date: 2014-10-14T09:05:38Z MPDF-66 maven-pdf-plugin puts project.properties into Velocity context. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugins pull request #29: MPDF-66 maven-pdf-plugin puts project.proper...
Github user gmcdonald closed the pull request at: https://github.com/apache/maven-plugins/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [jira] [Created] (MRESOLVER-4) Use Commons Lang's Validate to intercept invalid input
Am 10/16/16 um 23:51 schrieb Stephen Connolly: > Let's just go for Java 7... this is linked to core... if you are stuck on > an older Java likely you can't upgrade Maven anyway +1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-plugins pull request #69: Update the example of setting maven-compiler...
Github user asfgit closed the pull request at: https://github.com/apache/maven-plugins/pull/69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Some thoughts on Maven 5
Am 10/15/16 um 16:26 schrieb Stephen Connolly: > Thinking out loud... perhaps something like > > [version="..."] packaging="..."> > [ [relativePath="...']/> > > [] > [] > ... > [] Looking at this from a syntax point of view only, we will run into those "XML element declaration order has an implicit meaning" issues again. Q: How are conflicts resolved? A: There is no conflict resolution during building the effective model (in general - not only for mixins). Mixin elements are just substituted with what they reference in place - before inheritance processing. After all mixins have been substituted, the effective model is validated. So that it's perfectly valid to write redundant mixins like leading to an invalid effective model that will not pass further validation. Every identifiable complex content element should support mixins. Maybe we name that element 'include' following XML schema. Maybe allow selection of the node(s) to include based on XPapth. Q: How to handle properties? What if someone writes: ? A: Current master dependency management import scope uses the effective properties after inheritance processing. If mixins can bring in properties, this is no longer possible because there is no way to build the effective properties without substituting the properties of the mixins. Current dependency management import does not have this issue because it cannot import properties. So if properties can be brought in via mixins, we cannot allow properties in mixins anymore. That's pretty much the experience I gained by working on the import scope. > > [ Maybe mode="override|append-parent|prepend-parent" or mode="override|append|prepend" with "append" and "prepend" referencing the element of the attribute. So that "prepend" equals "append-parent" and "append" equals "prepend-parent". "prepend-parent"/"append" being the default. More verbose: inheritance-mode. Also need "final" and "override" boolean attributes working like the java keyword/annotation. > > > ... > "after" or "before" need to be mandatory to avoid order of XML element declaration issues, if I got the intention of those attributes correctly. As a general rule of thumb we should validate the model as strictly as possible in the first release. It's easier to relax a constraint in a next release then to enforce a new one. That's mainly where all those warnings in Maven 3 come from. Cannot enforce a new constraint, so print a warning. Let's try to do it the other way around this time. Be as strict as possible. If something isn't quite clear, just add a constraint disallowing the specific usage which can be relaxed later. That's mainly what came to mind when reading this the first time. Regards, -- Christian - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Some thoughts on Maven 5
Am 10/15/16 um 19:32 schrieb Stephen Connolly: > I'm thinking that we still want a dependency management section I think dependency management is a must have. That's a build tool feature to allow overriding dependency details from the consumed PDT. What is different here is that instead of having one global dependency management, you would need different management possibilities by tree. So that it becomes possible to manage all trees independently of each other. Hmm. Sounds like someone just needs to declare the dependency in question directly in the build pom to make that the dependency to use for the consumed trees, no? Seems like a build pom dependency already is the requested management facility. Will be transitive automatically. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Some thoughts on Maven 5
Am 10/15/16 um 15:20 schrieb Stephen Connolly: > * Pom doesn't need to be XML any more... (maybe we want to keep XML though... > just a less verbose form) Maybe XML really isn't the way to go. Whenever I look at an XML file, it appears to be a mixture of meta-data, data and behaviour/logic. Last being evil most of the time. Does not necessarily need to be contained in one single file. Almost never do I see people making use of the X in XML. Btw: You can execute "sh" and get a shell prompt, it would be cool if you could execute "mvn" and get a build prompt. Maven uses classloaders heavily. Almost no hotspot compiler optimization can be performed by the VM due to throwing away classloaders after plugin executions immediately. sh>ls src pom.xml sh>mvn Project: Some info from the pom.xml. Ready. mvn> If not in a project directory, error message "No project directory.". mvn> compile mvn> clean mvn> which compile Lifecycle: ...other bindings org.apache.maven.plugins:maven-compiler-plugin:x.y.z:compile ...other bindings mvn> which testCompile Goal: org.apache.maven.plugins:maven-compiler-plugin:x.y.z:testCompile What is the PATH environment variable for the shell is a list of plugin group ids for the build shell. Maven 5.0 really should work like this. Maybe an additional lauchner script is needed "mvnsh" so that the "mvn" becomes the batch launcher and "mvnsh" becomes what developers will be using most of the time. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Maven 3.4.0 color output and default slf4j implementation
Hello Hervé, I would like a simple approach here. If I understand it correctly, gossip was chosen because of its color capability. If we could have this without switching the log provider it would be a good thing IMO. Gossip seems to be unconfigurable by means of system properties, which is a pity. Regards Mirko -- Sent from my mobile Am 15.10.2016 07:51 schrieb "Hervé BOUTEMY" : > Jason Dillon started the Maven output color work by providing us a Gossip > slf4j provider renderer adapted to Maven context: thanks Jason > > Then current master uses Gossip slf4j provider by default with this > customization. > > Given there were feedback from people finding the change disturbing vs > usual > slf4j simple provider (some are just about changing habits, some are about > missing features like logging configuration with CLI and relative > timestamp), > I tried another approach: patch slf4j simple provider to add Maven-specific > rendering features. > > The result is available on MNG-6093 branch with maven-slf4j-provider module > addition [1] > > I didn't really try to add features or extensions to slf4j Gossip. > > > What is the best option for Maven: try to improve slf4j Gossip or use this > slf4j simple patched version? > > Regards, > > Hervé > > [1] https://github.com/apache/maven/tree/MNG-6093/maven-slf4j-provider > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: Maven 3.4.0 color output and default slf4j implementation
Hi Mirko, short answer: yes more precise answer: Gossip slf4j provider does not have color feature but has extensible Renderer interface which permits to inject Maven colorized renderer [1] with one configuration line [2] In maven-slf4j-simple, I copied the same Maven colorized renderer code [3] and injected it in slf4j simple through a Groovy script to patch slf4j simple source code [4]: not as straightforward than one fonciguration line, but same effect with clean separation of Maven-specific extension code to support colorized output with Maven styles Regards, Hervé [1] https://github.com/apache/maven/blob/master/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java [2] https://github.com/apache/maven/blob/master/maven-embedder/src/main/resources/META-INF/com.planet57.gossip/config.properties#L29 [3] https://github.com/apache/maven/blob/MNG-6093/maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java [4] https://github.com/apache/maven/blob/MNG-6093/maven-slf4j-provider/src/main/script/patch-slf4j-simple.groovy Le lundi 17 octobre 2016 07:00:50 Mirko Friedenhagen a écrit : > Hello Hervé, > > I would like a simple approach here. If I understand it correctly, gossip > was chosen because of its color capability. If we could have this without > switching the log provider it would be a good thing IMO. Gossip seems to be > unconfigurable by means of system properties, which is a pity. > > Regards > Mirko > > > Jason Dillon started the Maven output color work by providing us a Gossip > > slf4j provider renderer adapted to Maven context: thanks Jason > > > > Then current master uses Gossip slf4j provider by default with this > > customization. > > > > Given there were feedback from people finding the change disturbing vs > > usual > > slf4j simple provider (some are just about changing habits, some are about > > missing features like logging configuration with CLI and relative > > timestamp), > > I tried another approach: patch slf4j simple provider to add > > Maven-specific > > rendering features. > > > > The result is available on MNG-6093 branch with maven-slf4j-provider > > module > > addition [1] > > > > I didn't really try to add features or extensions to slf4j Gossip. > > > > > > What is the best option for Maven: try to improve slf4j Gossip or use this > > slf4j simple patched version? > > > > Regards, > > > > Hervé > > > > [1] https://github.com/apache/maven/tree/MNG-6093/maven-slf4j-provider > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
