[Geeqie-devel] Tying Panview changes into the rest of geeqie
Howdy, y'all. Another vacation, another good opportunity to do some geeqie hacking. So, what I was working on over winter break was a way to do image filtering in PanView. By the time I finished, it had morphed into boolean keyword filtering, plus some basic grouping features, using plain text or regular expressions. It's not perfect, but it's good enough for a V1. You can find that here (just rebased against today's github master): https://github.com/xsdg/geeqie/tree/kw-multifilter At this point, I need to figure out what other pieces of Geeqie need to get similar features, so that PanView actually makes sense in the context of the rest of Geeqie — it doesn't make sense to have image set concepts that only exist in PanView. Colin already brought up Collections as a feature that needs to be updated. The FileList is another one. Search is probably another. Are there other important things that I'm forgetting? From a high-level implementation perspective, I think it makes sense to separate the file data from the view of that data. It's been long enough that I've forgotten how that works in Geeqie, but basically, there'll be a thing that lists directory contents, and then a view that allows one to: — Group images that are manually added to a group — Filter images according to some criteria — (Perhaps) perform the RAW/JPEG grouping that Geeqie already supports. and then PanView can use the same File source as the rest of Geeqie, and they'll all support the various ways to filter and group images. If anyone is interested in helping with this effort, I could really use some help updating the various UI bits to expose the filtering and grouping stuff. I can do the UI stuff, but I'm fairly slow at it, and I'm already going to have my hands full with everything that touches FileList. Cheers, --xsdg -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] New project: filters and grouping in Pan View
For anyone who's curious to play around with it, this is now working. It has all of the features described, although the interface ended up going in a different direction than I had originally planned. https://github.com/xsdg/geeqie/tree/kw-multifilter It'll be a little bit before this gets merged into master, due to some unrelated issues with a parent commit that I had written. Anyway, give it a shot. Let me know how it could improve. I know that I need to add documentation somewhere (where?), but I'm curious to know whether the UI is intuitive at all. --xsdg On 12/22/2016 11:39 PM, Omari Stephens wrote: > > > Le 22 décembre 2016 13:57:35 GMT-08:00, Klaus Ethgen > a écrit : >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA512 >> >> Welcome back, Omari :-) >> >> Am Do den 22. Dez 2016 um 20:51 schrieb Omari Stephens: >> [Grouping in Pan view] >> >> Sounds promising. >> >> How do you plan to implement the SQL-Part? I am not sure, if it is a >> good idea to depend on full postgresql or other full DB system. Maybe >> sqlite... >> >> On the other hand, I know perl SQL::Statement. But I do not know if >> that >> is available as a library. > > Oh, the SQL was just a convenient way to explain the two behaviors I had in > mind. For the actual implementations, I would code them by hand. There are > a couple straightforward ways to do the filter behavior. The grouping would > be a little trickier, but probably not much. > > Most of the real work would probably come afterward — taking the basic > implementations and making sure that they're fast enough and don't consume > too much memory. > > --xsdg > > -- > Developer Access Program for Intel Xeon Phi Processors > Access to Intel Xeon Phi processor-based developer platforms. > With one year of Intel Parallel Studio XE. > Training and support from Colfax. > Order your platform today.http://sdm.link/intel > ___ > Geeqie-devel mailing list > Geeqie-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geeqie-devel > -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Geeqie++ fever dreams
On 12/26/2016 10:37 PM, Alexander Antimonov wrote: > On Sun, Dec 25, 2016 at 6:28 PM, Klaus Ethgen wrote: >> I for myself have technical reasons why I dislike C++. And I also have > Could you, please, provide a list of your dislikes of C++? > >> concerns about maintainability. Many times the encapsulating breaks >> necessary overview. > For instance? > >> So, conclusion, if you have something that can be done in C++ and you >> want to do it, go ahead. Especially if you stay with the project and >> maintain that stuff afterwards. :-) > Is there any plan, enhancement list, users' whishlist? There is a bug list, which does have some feature requests as well: https://github.com/BestImageViewer/geeqie/issues --xsdg -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Geeqie coding standards? Third edition :o)
On 12/24/2016 02:43 PM, Ian Zimmerman wrote:
> On 2016-12-24 15:00, Klaus Ethgen wrote:
::snip::
>> It is nothing more wrong than a mismatch of that options with the
>> current used style. (Does someone here use different editor than vim
>> that does not respect such a setting?)
>
> I use Emacs. The C style in Emacs is extremely customizable, but still
> I can't say for sure there is a 1-1 mapping of the settings with the vim
> style settings.
Emacs here also. I don't know a ton about configuring it, but I know
enough to make it do 3-space indentation :o)
> Other points:
>
> - I strongly prefer spaces only indentation
Agreed.
::snip::
> - I am actually pretty religious about keeping to 80 chars per line.
> IMO if an expression is longer than that it needs to be factored
> anyway to be readable. Of course some cultures (cough..Java) make
> this hard by adopting reallyInsaneLongDescriptiveNames, and then the
> people from such cultures move into your project ... ARRRGH!
I would generally agree with you, but large C projects fall into the
same bucket as Java, specifically because C doesn't have any real
concept of namespaces. Consequently, I think 80 chars is a bad idea for
Geeqie.
So when your line starts off like this:
"combo = tab_completion_new_with_history("
You're gonna have a bad time. Especially if it's inside of a loop or
conditional or something like that. Constants are even worse, the
constant "PAN_IMAGE_SIZE_THUMB_LARGE" is already 33% of an 80-character
budget. That's the kind of thing that causes statements to start
consuming extra lines without actually improving readability at all.
(As an aside, C++ namespaces and enum classes would help dramatically in
conserving readability while reducing statement length. But when C is
what you've got, the namespace info has to go in the method and constant
names, and you've got to set line lengths to accommodate.)
--xsdg
--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Geeqie coding standards? Third edition :o)
On 12/24/2016 02:00 PM, Klaus Ethgen wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Hi Omari, > > Am Fr den 23. Dez 2016 um 19:09 schrieb Omari Stephens: >> In #2, I had created a one-liner to compute a line-length histogram our >> codebase. I've rerun it and included the results below as [1]. If also >> attached a list of max-line-length by source file. As of my git clone from >> earlier this week, Geeqie has 106k lines. 227 of those lines are over 160 >> characters. That's 0.2% > > I personally doesn't care about long lines if they make stuff more logic > than a hell of linebreaks with indentations. > > Longer lines are also better sometimes for merging purpose. > > Moreover, most editors shows long lines in a better way as short ones > with indentations. Especially if you resize the window. I do many perl > coding and what I hate most is that limitation to 80 chars. When I use a > windows that is smaller, the code gets unreadable as the linebreaks from > the editor interfere with the artificial linebreaks. I agree with everything you just said. But my terminal is 190 columns wide, and when I see lines wrapping just because the author didn't bother to put a single newline in there, it's a problem. I think we could easily say "no lines longer than 160 chars" without incurring most of the downsides that you're bringing up. [snip] --xsdg -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/intel ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Geeqie++ fever dreams
On 12/24/2016 05:18 PM, Alexander Antimonov wrote: >> We should have a good expectation of improving life for our users ... > Users are important, but with such move we could improve developers' > life at least. More to the point, code that is easier maintain benefits developers as well as users. And having a language that actually encourages code encapsulation, reuse, and adaptation would help us build UIs and subcomponents that are more consistent, and consequently, that are easier and more intuitive for users to understand and to become familiar with. >> - Introduce new bugs (because big rewrites always do) > Sure, but with C++ port we can also simplify code, and less code - less bugs. > Now considerable part of Geeqie's code is plain C which builds UI. > It's a rare method of building UI nowadays. It should be replaced with > something like Glade description. It would also be a great opportunity to _remove_ latent bugs that already exist. _Especially_ typing-related bugs. Just yesterday (which is what spurred me to send this email), I fixed a latent buffer-overflow bug in the rcfile parsing code ([1]), because someone passed a short* to a function that was going to stuff an int into it. So I fixed it by manually copying and pasting the uint helper functions and replacing "uint *" with "uint16 *" in the prototype. Except I didn't copy all of them because it simply increases the maintenance burden for no benefit yet. Except not having a unified API across all of the types creates its own dev usability burden. If that's not a 100% prototypical "just throw templates at it" problem, I don't know what is. Also, say you've got a GList*. How do you avoid sticking the wrong type into it? In C, you've gotta be perfect (including when returning to code that hasn't been touched in 4 years) or your code will magically crash when a user is trying to get work done. In C++, your code isn't going to compile if you get it wrong. Here's another easy example: does Geeqie have any double-free or memory leak bugs? I can pretty much guarantee that it does, because they're so hard to detect. C++ features enable (but don't force) you to actually guarantee that those classes of bugs don't exist. Fewer crashes and less unintended memory use both offer significant quality-of-life improvements for users. >> - Maybe exclude some core developers who just don't have as much fun in C++ >> as in C > It might be a good chance for them to improve their skills a bit. > > My 5 cents, I prefer do not use love/hate words when it comes to > technical things. Agreed, Jeff, which is specifically why I posed this as a question and not as a proposal. That said, I also agree with Alexander. Learning C++11 (and _specifically_ C++11, as opposed to any earlier version) has made me a better C programmer, because it's made me more aware of the kinds of bugs I write in C that the compiler _doesn't_ catch. Especially around pointer memory ownership. And those problems are exacerbated by the asynchronous patterns used in Glib and GTK, as well as Geeqie itself (FileData, I'm looking at you). std::unique_ptr is annoying, but it's specifically so annoying because it exposes so many of my bad pointer-handling habits and forces me to fix them. Those bad habits also have a user impact (*cough* double free/memory leak), and being more aware helps me to write better code. But that awareness wouldn't have developed anywhere near as quickly without std::unique_ptr kicking me in the face every time I got it wrong. --xsdg [1] https://github.com/BestImageViewer/geeqie/commit/a43d40845dcc2fb63c1ad6cae31b8b1ff5527701 -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/intel ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
[Geeqie-devel] Geeqie++ fever dreams
It is at least hypothetically possible to port Geeqie to C++11 / GtkMM. Ignoring the inevitable ridiculous mountain of work that it would take, does the end state seem like a good idea? Personally, I only knew C89 and small quantities of C++98 until I started using C++11 for work earlier this year. One of the things I've come to appreciate about it is that std::unique_ptr and std::move make memory _ownership_ explicit, which basically makes memory leaks, double-frees, and other pointer maladies a non-issue. You still have bare pointers when you need them, but you only have to use them when really needed. The other thing that seems useful is that between C++ and GtkMM, you get real namespaces and an actual honest-to-goodness GTK class hierarchy. And templates mean GList* turns into GList*, so you can know what's inside of it just by glancing at the header file, without having to dig through the code. And then if you try to put the wrong thing into it, it's a compile-time error instead of a segfault. Thoughts? --xsdg -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/intel ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
[Geeqie-devel] Geeqie coding standards? Third edition :o)
It appears that each time I come back to working on Geeqie, I send one
of these emails ;o)
Here are threads #1 and #2:
#1: https://sourceforge.net/p/geeqie/mailman/message/22531197/
#2: https://sourceforge.net/p/geeqie/mailman/message/27441283/
In #2, I had created a one-liner to compute a line-length histogram our
codebase. I've rerun it and included the results below as [1]. If also
attached a list of max-line-length by source file. As of my git clone
from earlier this week, Geeqie has 106k lines. 227 of those lines are
over 160 characters. That's 0.2%
I am willing to change those 227 lines by hand if it means we can commit
to a line length limit of 160 characters.
But beyond that, ClangFormat exists now. Because it's part of Clang,
and actually lexes/parses the C language, it can make actual
semantically-driven decisions about how a piece of source code should
look. This means that _if_ we decide on some style, ClangFormat should
make it relatively straightforward to update the codebase in one fell
swoop. (And FYI, the C++ standard at Google, where I work, is to run
all code through ClangFormat, with exceptions specified as per [2])
With that said, I would love for us to get away from a style that
encourages us to mix tabs and spaces. See, for instance, [3]. There is
no way to match an arbitrary paren on the prior line without using
spaces for some indentation. But if our style is to use tabs for most
indentation, it either means that you can't match the exact paren offset
from the previous line, or you have to mix tabs and spaces.
My personal preference would be to switch to using spaces for all
indentation, but I would be okay with using tabs for all indentation as
well, so long as we avoid situations where the tabs need to be padded
with spaces.
--xsdg
[1] Note that keymap_template.c is a C-wrapped XML file, which is why I
exclude it.
$ruby -e 'lc = Hash.new{|h,k| h[k] = 0}; ARGV.each{|f|
File.new(f).each_line{|l| l.gsub!(/\t/, " "*8); lc[l.length/10] += 1}};
csum = 0; lc.sort.each{|(x,y)| csum += y; printf "%3d-%3d: %s %d\n",
10*x, 10*(x+1)-1, y.to_s.ljust(5), csum}' $(\ls *.c *.h *.cc | grep -v
keymap_template.c)
0- 9: 30198 30198
10- 19: 9074 39272
20- 29: 14334 53606
30- 39: 13148 66754
40- 49: 9292 76046
50- 59: 7223 83269
60- 69: 7534 90803
70- 79: 6587 97390
80- 89: 3974 101364
90- 99: 2194 103558
100-109: 1254 104812
110-119: 681 105493
120-129: 355 105848
130-139: 143 105991
140-149: 64106055
150-159: 39106094
160-169: 28106122
170-179: 22106144
180-189: 32106176
190-199: 38106214
200-209: 64106278
210-219: 36106314
220-229: 7 106321
[2]
http://clang.llvm.org/docs/ClangFormatStyleOptions.html#disabling-formatting-on-a-piece-of-code
[3]
http://geeqie.org/cgi-bin/gitweb.cgi?p=geeqie.git;a=blob;f=src/pan-types.h;h=de114bf5111ff7d676ac3fad8c70d630f5f10ccb;hb=HEAD#l274
["keymap_template.c", 404]
["rcfile.c", 226]
["rcfile.h", 214]
["ui_tree_edit.c", 201]
["filefilter.c", 192]
["utilops.c", 188]
["image_load_tiff.c", 187]
["image_load_jpeg.c", 187]
["image_load_gdk.c", 186]
["preferences.c", 175]
["filefilter.h", 175]
["editors.c", 171]
["layout_util.c", 167]
["metadata.h", 166]
["metadata.c", 165]
["utilops.h", 162]
["image-load.h", 161]
["bar_histogram.c", 161]
["renderer-tiles.c", 160]
["bar_keywords.c", 160]
["jpeg_parser.c", 157]
["bar_comment.c", 156]
["filedata.h", 155]
["filedata.c", 154]
["main.c", 153]
["image-load.c", 149]
["view_file_list.c", 148]
["compat.h", 147]
["secure_save.c", 146]
["ui_fileops.c", 145]
["main.h", 143]
["print.c", 142]
["editors.h", 142]
["dupe.c", 142]
["pixbuf-renderer.h", 141]
["debug.c", 140]
["cellrenderericon.h", 139]
["view_file.c", 138]
["pixbuf-renderer.c", 138]
["image.c", 138]
["bar_exif.c", 137]
["image-overlay.c", 136]
["view_file.h", 135]
["remote.c", 135]
["layout.c", 134]
["view_dir.h", 133]
["typedefs.h", 133]
["histogram.h", 131]
["exiv2.cc", 131]
["histogram.c", 130]
["view_file_icon.c", 128]
["compat.c", 128]
["collect-table.c", 128]
["bar.c", 128]
["layout.h", 127]
["ui_tabcomp.h", 126]
["exif.c", 126]
["ui_tabcomp.c", 125]
["collect-io.c", 124]
["bar_histogram.h", 124]
["bar_keywords.h", 123]
["search.c", 122]
["layout_image.c", 122]
["bar_exif.h", 122]
["bar_comment.h", 122]
["ui_menu.h", 121]
["ui_menu.c", 121]
["cellrenderericon.c", 121]
["trash.c", 120]
["bar_gps.c", 120]
["cache.c", 119]
["bar_sort.h", 118]
["bar_gps.h", 118]
["pixbuf_util.c", 117]
["bar_sort.c", 117]
["menu.h", 116]
["layout_image.h", 116]
["thumb_standard.h", 115]
["similar.c", 115]
["menu.c", 115]
["view_dir_tree.c", 114]
["ui_tree_edit.h", 114]
["thumb_standard.c", 114]
["bar.h", 114]
["ui_pathsel.c", 112]
["renderer-clutter.c", 112]
["fullscreen.h", 112]
["fullscreen.c", 112]
["view_dir_list.c", 111]
["ui_misc.c", 111]
["thumb.c", 111]
["img-view.c", 111]
["collect.c", 111]
["slideshow.h", 110]
["slideshow.c", 110]
["format_nikon.h", 110]
["deskto
Re: [Geeqie-devel] New project: filters and grouping in Pan View
Le 22 décembre 2016 13:57:35 GMT-08:00, Klaus Ethgen a écrit : >-BEGIN PGP SIGNED MESSAGE- >Hash: SHA512 > >Welcome back, Omari :-) > >Am Do den 22. Dez 2016 um 20:51 schrieb Omari Stephens: >[Grouping in Pan view] > >Sounds promising. > >How do you plan to implement the SQL-Part? I am not sure, if it is a >good idea to depend on full postgresql or other full DB system. Maybe >sqlite... > >On the other hand, I know perl SQL::Statement. But I do not know if >that >is available as a library. Oh, the SQL was just a convenient way to explain the two behaviors I had in mind. For the actual implementations, I would code them by hand. There are a couple straightforward ways to do the filter behavior. The grouping would be a little trickier, but probably not much. Most of the real work would probably come afterward — taking the basic implementations and making sure that they're fast enough and don't consume too much memory. --xsdg -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/intel ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
[Geeqie-devel] New project: filters and grouping in Pan View
Hey, y'all I finally have some time and some motivation, so it's time for a new project. I'm planning to add filters and grouping to Pan View. First off, here's my usecase: A few weeks ago, I photographed a 25-hour-long endurance car race. I shot 4,100 frames. When I was reviewing them, I found that sometimes I wanted to focus on certain "sections" of the race, and at other times, I wanted to be able to briefly skim the different sections. The sections might be "This was morning prep." "This was the start." "That's when the car hit a barrier." "This was sunset." And so on. Geeqie can already encode all of the relevant metadata using Keywords, so that's the obvious design choice there. As for filters and grouping, SQL is a pretty obvious conceptual analog for what I have in mind. Suppose that we have a PanView open to /panview/path/, and that panview_filtered_keywords and panview_grouped_keywords are arrays of keywords. Here's PanView now: SELECT * FROM images WHERE filename LIKE '/panview/path/%'; The filter step is this. Note that "&&" is the SQL operator to test for set overlap: SELECT * FROM images WHERE (filename LIKE '/panview/path/%') AND (keywords && panview_filtered_keywords); The grouping step is something like this — images that aren't in any grouped sets are unaffected, and ones that are in grouped sets are aggregated: SELECT * FROM images WHERE (filename LIKE '/panview/path%') AND NOT(keywords && panview_grouped_keywords) UNION SELECT first(*) FROM images WHERE (filename LIKE '/panview/path%') GROUP BY GROUPING SETS (panview_grouped_keywords); See a description of the GROUPING SETS behavior here: https://www.postgresql.org/docs/9.5/static/queries-table-expressions.html#QUERIES-GROUPING-SETS "first" is just an aggregation strategy, but it could (and probably should) just as well include some special UI treatment to show that the thing being displayed is a group rather than just a single image. Eventually, it could include a custom UI widget that allows scrolling through all of the entries in the group in-place. There are plenty of details yet to be ironed out, like "what happens if an image has two keywords that are both in the panview_grouped_keywords array?" Cheers, --xsdg -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/intel ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] geeqie window refresh issue
On 10/03/2016 07:53 PM, Hanno Foest wrote: > Hello, > > I have a picture collection with about 660 subdirectories. I recently > noticed the following issue: > > - I view some images in one of the image subdirectories > - I go back to the top directory (with the 660 subdirectories in it) > - geeqie window (combined file list + image window) stops updating until > I resize it. I don't see the list of the 660 subdirectories. > > More exactly, geeqie window returns blank if I iconify and restore it > (no size change involved). Hitting "r" (file list refresh) makes no > difference, only resizing fixes things. > > This is using Xubuntu 14.04, geeqie 1.1-8. Using PPA geeqie_1.2.2-1dhor > the situation improved a little: Starting in a subdir and then going one > up gives me the issue, but after switching back and forth (using the > back arrrow) things are back to normal. > > I was not able to reproduce the issue with a second machine, same > software versions, same directory layout. Since things seem to be > dependent on caching (see above), I suspect a timing issue. > > Any ideas? Since this seems to be hard to reproduce, I'd be happy to run > more checks, if someone can tell me what to look for. Debug output > wasn't helpful, I didn't notice a difference between issue showing or > not. > > Hanno Much belated, but I see this also. I find that if I scroll up or down in the file list, everything refreshes as expected, without having to resize the window at all. --xsdg -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/intel ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Color management strangeness
On 06/11/2016 10:42 PM, Saint Germain wrote: > Hello, > > Using Geeqie on Debian stable (so version 1.2.3), I noticed that on > some pictures, if I have "use color profiles" enabled, I see > really incorrect colors for one second and then the correct colors are > displayed. > > I experimented with a single RAW picture, with JPEG generated from > several softwares. Some JPEG start with really incorrect colors, and > then display the correct colors, and some others JPEG start with almost > the exact colors right from the beginning. > > I tried removing the embedded color profile, but the result is the same. > All my pictures are in the sRGB space. > > Could someone explain to me this behavior ? It is not that important > but it is really bothering me because I don't see the reason. > > Thanks Can you describe "really incorrect" further? Are the hues wrong? Lightnesses? Saturations? Are black and/or white the wrong colors? Geeqie definitely renders colors in two passes, where the first is not color-corrected and the second pass is color-corrected. If you disable color management, do you see the same wrong colors, or is everything close-to-correct (even if not perfectly correct)? --xsdg -- Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San Francisco, CA to explore cutting-edge tech and listen to tech luminaries present their vision of the future. This family event has something for everyone, including kids. Get more information and register today. http://sdm.link/attshape ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Copy path problem
On 07/15/2014 08:28 AM, Klaus Ethgen wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Hi, > > Am Mo den 14. Jul 2014 um 22:38 schrieb Ian Zimmerman: >> a. I am conditioned to expect middle-click to behave erractically, > > Sorry, can you explain »erractically«? I cannot translate that to my > language. Klaus: "erratically" Basically, unpredictable and often having unintended effects. --xsdg > >> b. I am the opposite of handy, so pointing devices in general are the >> stuff of my nightmares; > > I do not like them also. I like to work with the keyboard. However, for > some situaltions I like my mouse (or more specific, my "Knubbel" inside > my Thinkpad keyboard that replaces the mouse. And the buttons are > ecactly wher you need them to paste. > >> c. (related) I use a touchpad instead of a mouse, and middle-clicking is >> particularly clunky on touchpads, even when they have a real middle >> button as mine does (most don't). > > I can understand that. I find touchpads the most nightmare ever. And if > I buy a laptop I try to find one without touchpad at all, what is really > hard. > > Regards > Klaus > - -- > Klaus Ethgen http://www.ethgen.ch/ > pub 4096R/4E20AF1C 2011-05-16 Klaus Ethgen > Fingerprint: 85D4 CA42 952C 949B 1753 62B3 79D0 B06F 4E20 AF1C > -BEGIN PGP SIGNATURE- > Version: GnuPG v1 > > iQGcBAEBCgAGBQJTxOZIAAoJEKZ8CrGAGfasXmEL/1uTt1SxVoD7mmQDiRFsyEOF > KiS5ATKZQSeTb69XTbiUtfAHomIQnazaAsRFXm543U9dPewjzwRXcwewmcoyouW8 > TbZrbo1rF/ez1fGIjBcvhdDXgQEffpAoMZeYoiCA1j05MvLhgAPL0ToUoH6p50Yi > huwfgV8qMvzplywbAtvpf1DngV69SE62U6cq2bj0sqhLqTCMBZXIxtNIKRf1PtGu > 8vn+J+oUqsIa+33akfiSFNpcYMep5GUegmt/HdnLsy19ZsLh20NuAPtIxSVzcZuy > Pv1S6tRmhxhJxaMk82Jf8L//EcgTXcoP8nK1hxG4QcfV88KbA7kMYRie+FpfGwG8 > 680NjebDNc3mYQAllh3nqSsuHrwRMEI6seVT/DXk20LuBfo5PuNqXxKLUcmyU9fG > 1/WblGHCbeASpfGUwiXP25KmY6HBSXLErIFUDc85EVHJ8NXxhtsNgv8srfGenrrU > PxSWWPKx8fOZ9pfBgzkQ4y2Yn24CUn5dRKmv7paP1Q== > =IM4u > -END PGP SIGNATURE- > > -- > Want fast and easy access to all the code in your enterprise? Index and > search up to 200,000 lines of code with a free copy of Black Duck > Code Sight - the same software that powers the world's largest code > search on Ohloh, the Black Duck Open Hub! Try it now. > http://p.sf.net/sfu/bds > ___ > Geeqie-devel mailing list > Geeqie-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geeqie-devel > -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Copy path problem
Ian: what is your usecase? You jumped into the technical issues immediately, but as far as I can tell, you haven't actually explained what you're trying to accomplish. FTR, I agree with Klaus that I would be frustrated if selecting images in geeqie would blow away my X selection buffer, specifically because my only reason to select text is to copy it, but there are other reasons to select images in geeqie. For instance my most common reason to select images in geeqie is to just be able to compare similar images — if you have a selection active, then hitting "next image" will only cycle through the selected images. --xsdg On 07/14/2014 02:13 AM, Ian Zimmerman wrote: > Klaus Ethgen writes: > > Ian> You're right that simply changing the current code from > Ian> GDK_SELECTION_PRIMARY to GDK_SELECTION_CLIPBOARD would break your > Ian> usage while fixing mine. It would still be the right thing to do > Ian> IMO because of the convention. But we can keep the cake and eat it > Ian> if we add new hooks on selection change events, calling back the > Ian> current code with GDK_SELECTION_PRIMARY. How's that? > > Klaus> You mean just adding also to put the stuff to the other > Klaus> clipboard? Maybe also to the third one too? > Klaus> (GDK_SELECTION_SECONDARY, I think) > > Not at the same places/times. I mean setting GDK_SELECTION_PRIMARY _as > soon as the thing is selected_. That means setting a new callback in > each window where it makes sense on an event like "selchange" or > something (not sure how Gtk spells it). So a file name would be copied > as soon as you click on one in the file list, for example. > > This is the right thing to do according to my reading of the doc, at least. > > Ian> I can make a patch. It probably won't be trivially short; where do > Ian> you want it posted? > > Klaus> Here would be great. Or fork the repo on gitorious and create a > Klaus> merge request. > > Ok, looking at the code it's going to be a bit more challenge than I > thought, but I am giving it a try. If you think I should. > > Ian. > > > > -- > Want fast and easy access to all the code in your enterprise? Index and > search up to 200,000 lines of code with a free copy of Black Duck® > Code Sight™ - the same software that powers the world's largest code > search on Ohloh, the Black Duck Open Hub! Try it now. > http://p.sf.net/sfu/bds > ___ > Geeqie-devel mailing list > Geeqie-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geeqie-devel > -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck® Code Sight™ - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] New version
https://gitorious.org/geeqie/merge_requests ? --xsdg On 06/26/2014 06:04 PM, Klaus Ethgen wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > The last official version was done long ago and there are several bugs > fixed in the current head. > > Is there any objection against tagging a new version? > > Regards > Klaus > - -- > Klaus Ethgen http://www.ethgen.ch/ > pub 4096R/4E20AF1C 2011-05-16 Klaus Ethgen > Fingerprint: 85D4 CA42 952C 949B 1753 62B3 79D0 B06F 4E20 AF1C > -BEGIN PGP SIGNATURE- > Version: GnuPG v1 > > iQGcBAEBCgAGBQJTrGDCAAoJEKZ8CrGAGfasjNUL/0XP0AzxznjaiqnMVQoyLeFH > rt/l1CPy6x9tADIG2GbhXV53uOWjBt/kWpnuFgd4Z12+9//JpSCESFZapruLKBb1 > 0YQ2VZYbtxyHbox0FY8fMNr97ZosIN5d4yXgqtp1hUTa5ivmPg9dJlPjgBnhU48n > uWnSM5PG/3UcCsprfvWi3nbFgTrna+3TZuuDGe05TI6aG+nKZfLiZGtBSUGoeZqh > wR3L+hXtLy2IpbxwVtiLi4rz/U2cOWNWQkge7emUzJ7IyAP6Vdl5UzZVACWDfWEM > O5lH462rrRODRa0KpFSthTHgzyHCGxjJpp2Avcjud5PqK9P44WvKaaMHWbx3jjLe > sjZ0NCUaim0/qIc8F9VE1cizdgQn6emd2jdyqy7MIx2adHPWXzIZ95rK4Dfd6W5w > XjXnH4rf45DUM8kMtY5n2X9C6D74+R7YQyoP2krWD5UIsrTTd3mBbH/R0kgG9U2W > kDitxjqA7Oibg2iBIbDOO6SL9e2j8tiXKHh4ixjLYg== > =PBT/ > -END PGP SIGNATURE- > > -- > Open source business process management suite built on Java and Eclipse > Turn processes into business applications with Bonita BPM Community Edition > Quickly connect people, data, and systems into organized workflows > Winner of BOSSIE, CODIE, OW2 and Gartner awards > http://p.sf.net/sfu/Bonitasoft > ___ > Geeqie-devel mailing list > Geeqie-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geeqie-devel > -- Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Favorite keywords, really?
On 06/02/2014 05:04 AM, Ian Zimmerman wrote: > Hi, the documentation says I can add new keywords of my own with the > help of a "button bar" that's supposed to be next to the keywords part > of the sidebar. But, I can see no such button bar in my geeqie. > Directly below the keywords list there is the exif information. I just > built 1.1 from source ... I have no idea about a button bar, but you can certainly right-click the keyword checklist and it'll give you the menu option to add a keyword. --xsdg -- Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/NeoTech ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] EXIF data
Doable? Yes. But it will probably take some plumbing. I spent some time trying to get Geeqie to display IPTC metadata (which is generally embedded in the XMP metadata, iirc), and there was a _lot_ of plumbing to be done. I imagine that changing the EXIF pipeline from unidirectional to bidirectional would also involve a lot of plumbing. That said, _should_ it? Unless it's a hack, I imagine it'd take a lot of UI work to come up with something that's intuitive, easy to use, and that avoids harming the simplicity of the current EXIF-display mechanisms. Beyond that, I don't think Geeqie is the right place to do batch algorithmic EXIF modifications (such as "the EXIF timestamp is off by an hour; fix that"). That is something that is already supported by exiv2, and it seems more useful to just build a UI on top of exiv2 than to dump the functionality into Geeqie. From exiv2 help: Actions: ad | adjust Adjust Exif timestamps by the given time. This action requires at least one of the -a, -Y, -O or -D options. --xsdg On 02/05/2014 03:07 AM, David Vincent-Jones wrote: > Would there be any possibility of using geeqie to edit exif data? > > Some fields (particularly time/date) would be most useful and currently > there are no exif data editors with any sort of front end. > > David -- Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Geeqie-1.1 LCMS2 Patch
Niko: do you know if render speed is affected? ISTR that render speed was one downside to LCMS2, but that may have changed since I last heard that, and also it might not be significant (I haven't used a project using LCMS2 before). --xsdg On 12/05/2013 04:47 AM, Niko Sauer wrote: > I found a patch that will enable lcms2 when compiling Geeqie-1.1.This > is Gitorious Commit 1548a68. There is a small bug in the patch that I > remedied by deleting one single line. The new patch is attached. Since > it changes configure.in, one should run autoconf before configuring. > > Geeqie's colour rendition has improved with lcms2. > > Niko Sauer > > > > > > -- > Sponsored by Intel(R) XDK > Develop, test and display web and hybrid apps with a single code base. > Download it for free now! > http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk > > > > ___ > Geeqie-devel mailing list > Geeqie-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geeqie-devel > -- Sponsored by Intel(R) XDK Develop, test and display web and hybrid apps with a single code base. Download it for free now! http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Crash when open Nikon coolpix P330 raw file (NRW)
Howdy, Egor What filesystem are you using? Do you have other files in the same directory? Are any of them named with the same base filename as that one? (aka "DSCN0339") Cheers, --xsdg On 09/10/2013 08:46 AM, Egor Vakhromtsev wrote: > Hello! > > I have crash when try to open files from Nikon coolpix P330. > > $ geeqie DSCN0339.NRW > ** > ERROR:filedata.c:1153:file_data_new_group: assertion failed: (fd) > > > File for example: > https://dl.dropboxusercontent.com/u/59794362/geeqie-nrw/DSCN0339.NRW > > -- > Best regards > Egor Vakhromtsev -- How ServiceNow helps IT people transform IT departments: 1. Consolidate legacy IT systems to a single system of record for IT 2. Standardize and globalize service processes across IT 3. Implement zero-touch automation to replace manual, redundant tasks http://pubads.g.doubleclick.net/gampad/clk?id=5127&iu=/4140/ostg.clktrk ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Back after a while
Same here. I'm still around, just been focusing on other things. I still use geeqie every day, though, so have plenty of motivation to help it improve. --xsdg On 07/23/2013 04:09 PM, Klaus Ethgen wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Hey, > > I think I should come back to the geeqie development. Had to less time > the last months. > > Lets see what happens in the time. > > Regards > Klaus > - -- > Klaus Ethgen http://www.ethgen.ch/ > pub 4096R/4E20AF1C 2011-05-16 Klaus Ethgen > Fingerprint: 85D4 CA42 952C 949B 1753 62B3 79D0 B06F 4E20 AF1C > -BEGIN PGP SIGNATURE- > Version: GnuPG v1.4.12 (GNU/Linux) > > iQGcBAEBCgAGBQJR7qrWAAoJEKZ8CrGAGfasWicL/0VWsUGeEL+RTmnM+sdfb73W > DdLOF6CDvrsUVyDPraK/XbJmVRCk8eTdGIQI+BIqXsopS59Ex/AL5YKo1TTV8tKK > UEb30FuFNlIAq25eri4Y4+SIQa0ChixZux8epORAn0UPGL7UL8nok7y8pN9YSFT5 > YszWb/FiJrBAbMKHcPfJouoFxTZ9IIendzfbgGR9sNMTGR5runqvCTlsMq/iHiga > ygVMbWIMvcqBEEwwTJCaP/vnAwusFs4yDkPjySDO/ppDY0dFo1sgnaeUd0PvM797 > oOqZvdup05im8SpF6zbZLPgdRDWXOjlL3zj+rCTc6LuEQZWpENafE1uXEf6sfSb2 > JcFC4g0FEu2SdMsgSC6gVasiIW+YVod7esCwsr7s3qIoyogrOLPYKQZdJDHgLVbP > Qc2aUO1Fes3tLRz9DgIxhvEO2/nVxhGZjzXkI/t1bmdqyxzcTFTbHlmkWFbJ15fI > I7Qfl0c1EErCFS1+S814wV2xPY3B13cGWyeuXIWirw== > =ucuZ > -END PGP SIGNATURE- > > -- > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > ___ > Geeqie-devel mailing list > Geeqie-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geeqie-devel > -- See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Display slow for D300 RAWs at 100% scale
Okay, it looks like the rendering speed correlates with the total size of the image, which is really bad. If I crop out a small section, it works fine at unity gain. If I embed that cropped section in a 6000x9000 area of white, it goes even slower than that image alone. If I zoom in or out at all, it runs at expected rendering speed. --xsdg On 01/31/2013 07:42 PM, Omari Stephens wrote: > This image is a 100% repro case for me: > http://ocaml.xvm.mit.edu/~xsdg/stuff/geeqie/testcases/300_1708.embedded.jpg > > If I view the image with any non-unity scaling factor, it renders fine. >At 100% (aka unity), rendering is really, really slow. > > http://ocaml.xvm.mit.edu/~xsdg/stuff/geeqie/testcases/300_1708.embedded.jpg > > --xsdg > > On 01/31/2013 07:33 PM, Omari Stephens wrote: >> Looks like the regression happened when Vladimir switched to Cairo drawing: >> >> $git show --name-only >> commit b4c4a924121c3aa6b2f1eb7570dd3f419d2f4d83 >> Author: Vladimir Nadvornik >> Date: Thu Aug 2 00:15:16 2012 +0200 >> >>use cairo for drawing >> >>cairo is the only supported drawing method in gtk3 >> >> I am using Debian with libgtk2.0-0 version 2.24.10-2 >> >> --xsdg >> >> On 01/31/2013 06:10 PM, Omari Stephens wrote: >>> Howdy, y'all >>> >>> Some recent (aka past couple of months) change caused geeqie to slow >>> down when only when displaying images from my D300 NEFs at 100% scale. >>> If I zoom in or zoom out from 100%, it displays at normal speed. At >>> 100%, it's slow as molasses. I'll try to poke at it, but is anyone else >>> seeing this kind of behavior? >>> >>> --xsdg >>> >>> -- >>> Everyone hates slow websites. So do we. >>> Make your web apps faster with AppDynamics >>> Download AppDynamics Lite for free today: >>> http://p.sf.net/sfu/appdyn_d2d_jan >>> ___ >>> Geeqie-devel mailing list >>> Geeqie-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/geeqie-devel >>> >> >> >> -- >> Everyone hates slow websites. So do we. >> Make your web apps faster with AppDynamics >> Download AppDynamics Lite for free today: >> http://p.sf.net/sfu/appdyn_d2d_jan >> ___ >> Geeqie-devel mailing list >> Geeqie-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geeqie-devel >> > > > -- > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_d2d_jan > ___ > Geeqie-devel mailing list > Geeqie-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geeqie-devel > -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_jan ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Display slow for D300 RAWs at 100% scale
This image is a 100% repro case for me: http://ocaml.xvm.mit.edu/~xsdg/stuff/geeqie/testcases/300_1708.embedded.jpg If I view the image with any non-unity scaling factor, it renders fine. At 100% (aka unity), rendering is really, really slow. http://ocaml.xvm.mit.edu/~xsdg/stuff/geeqie/testcases/300_1708.embedded.jpg --xsdg On 01/31/2013 07:33 PM, Omari Stephens wrote: > Looks like the regression happened when Vladimir switched to Cairo drawing: > > $git show --name-only > commit b4c4a924121c3aa6b2f1eb7570dd3f419d2f4d83 > Author: Vladimir Nadvornik > Date: Thu Aug 2 00:15:16 2012 +0200 > > use cairo for drawing > > cairo is the only supported drawing method in gtk3 > > I am using Debian with libgtk2.0-0 version 2.24.10-2 > > --xsdg > > On 01/31/2013 06:10 PM, Omari Stephens wrote: >> Howdy, y'all >> >> Some recent (aka past couple of months) change caused geeqie to slow >> down when only when displaying images from my D300 NEFs at 100% scale. >> If I zoom in or zoom out from 100%, it displays at normal speed. At >> 100%, it's slow as molasses. I'll try to poke at it, but is anyone else >> seeing this kind of behavior? >> >> --xsdg >> >> -- >> Everyone hates slow websites. So do we. >> Make your web apps faster with AppDynamics >> Download AppDynamics Lite for free today: >> http://p.sf.net/sfu/appdyn_d2d_jan >> ___ >> Geeqie-devel mailing list >> Geeqie-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geeqie-devel >> > > > -- > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_d2d_jan > ___ > Geeqie-devel mailing list > Geeqie-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geeqie-devel > -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_jan ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Display slow for D300 RAWs at 100% scale
Looks like the regression happened when Vladimir switched to Cairo drawing: $git show --name-only commit b4c4a924121c3aa6b2f1eb7570dd3f419d2f4d83 Author: Vladimir Nadvornik Date: Thu Aug 2 00:15:16 2012 +0200 use cairo for drawing cairo is the only supported drawing method in gtk3 I am using Debian with libgtk2.0-0 version 2.24.10-2 --xsdg On 01/31/2013 06:10 PM, Omari Stephens wrote: > Howdy, y'all > > Some recent (aka past couple of months) change caused geeqie to slow > down when only when displaying images from my D300 NEFs at 100% scale. > If I zoom in or zoom out from 100%, it displays at normal speed. At > 100%, it's slow as molasses. I'll try to poke at it, but is anyone else > seeing this kind of behavior? > > --xsdg > > -- > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_d2d_jan > ___ > Geeqie-devel mailing list > Geeqie-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geeqie-devel > -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_jan ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
[Geeqie-devel] Display slow for D300 RAWs at 100% scale
Howdy, y'all Some recent (aka past couple of months) change caused geeqie to slow down when only when displaying images from my D300 NEFs at 100% scale. If I zoom in or zoom out from 100%, it displays at normal speed. At 100%, it's slow as molasses. I'll try to poke at it, but is anyone else seeing this kind of behavior? --xsdg -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_jan ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] tagging/marks feature not working?
On 12/27/2012 02:16 AM, Dieter Plaetinck wrote: > Hi, > is there any way to assign strings to the marks? for example > 'holiday-trip-2012' or 'new_york', 'family' > > also i can't get geeqie to actually write any metadata. tried both option 1 ( > in file), 2 (.metadata in image folder). option 3 is blanked out > interestingly. > i enabled all write options (1s timeout, on image change, on directory change) > i assign marks to images, then go to other images or directories, or close > and restart geeqie, and it has forgotten about the applied marks. > tried both geekie 1.1 and latest git build. this is on arch linux 64bit. > > the image directory and images have correct permissions (i can create new > files, delete or alter existing files) > > any idea what might be wrong? i'ld love to try out the tagging features... First off: marks are stored in-memory only. This is why they go away when you close geeqie (as you noticed). Second: If you have keywords set up in geeqie, you can associate specific marks with each keyword, and the keywords themselves are persisted in the image metadata. Note that you will need to redo the keyword->mark association if you want to use them with marks after you close geeqie Steps: 1) Make sure you have the metadata panel open. Ctrl+K 2a1) In the keywords section, right-click the _right_ pane, and select "Add keyword" (should be the first entry in the context menu) 2a2) Type in your keyword 2b) They keywords section might already have a keyword you want to use, if so; you don't need to add another one 3) Right-click the keyword (called "name" hereafter) 4) Go into 'Connect "name" to mark' and select an available mark (mark N) Now, mark N is associated with the selected keyword. If you add the mark to an image, geeqie will add the associated keyword (which will be saved). If an image already has the specified keyword added, it will also have the associated mark set. There are other options in the keywords context menu, but given the above explanation, it shouldn't be too difficult to figure out what the others do, perhaps with some experimentation. HTH, --xsdg -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_123012 ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] install 1.1 problem
On 11/18/2012 06:40 PM, David Vincent-Jones wrote: > I am installing on a new machine and appear to still not have all the > requires bits and pieces for the compile. I have an error message: > "configure: error: GLIB >= 2.4.0 not installed." On Debian-like machines, that's libglib2.0-dev. The likelihood is that it's just not installed, rather than too old. > Not sure exactly what it is looking for .. > Is there a way of checking and grabbing all needed pieces? You can try `apt-get build-dep geeqie`, but that may not get everything, depending on what the packaged version may or may not require. --xsdg > > David > > -- > Monitor your physical, virtual and cloud infrastructure from a single > web console. Get in-depth insight into apps, servers, databases, vmware, > SAP, cloud infrastructure, etc. Download 30-day Free Trial. > Pricing starts from $795 for 25 servers or applications! > http://p.sf.net/sfu/zoho_dev2dev_nov > ___ > Geeqie-devel mailing list > Geeqie-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geeqie-devel > -- Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
[Geeqie-devel] Patchset to make marks considerably faster when connected to keywords
I had done something similar in the past, but this is a more well-engineered attempt. The situation it optimizes is as follows: 1) right-click on a keyword in the keyword pane 2) Select "Connect \"keyword\" to mark" -> Mark N 2a) Optionally, repeat for other keywords 3) Hit "m" or Select -> Show Marks At this point, it is typically the case that if you restrict the view by filtering on a mark, the restriction happens instantly. At the same time, the FileData instances that _don't_ match the filter would be freed. If you subsequently broaden the view at all, geeqie would need to reparse the freed files to re-create those FileData instances. For small restrictions in large directories, you could end up reparsing almost every file in the directory. This gets Real Slow, Real Fast. This set of changes optimizes the situation by adding a secondary mechanism to prevent FileData instances from being freed until they go out of scope (that is, when the ViewDir changes directories). Thus, when a restriction happens, the non-matching FileData instances remain in memory, and thus a subsequent broaden operation becomes instant as well. This makes marks a _lot_ less frustrating to work with. The changes are below. I just finished them tonight, so I'd appreciate it if someone could review them/try them before I figure out how to send a merge request. https://gitorious.org/geeqie/xsdg-geeqie1/commit/710b009f5c61e7d1643a2a474e5020c760bf6462 https://gitorious.org/geeqie/xsdg-geeqie1/commit/1ea92516e2f91b7f99b1d41d44853f941d98e114 https://gitorious.org/geeqie/xsdg-geeqie1/commit/0ac57169c3c70c9b6c7e68033982a03511b79640 There are FileData leaks with this code, but there are also leaks without it. It's not yet clear if this is _causing_ any leaks. If people have thoughts/findings, lemme know. Cheers, --xsdg -- Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] External Rating
On 09/12/2012 11:14 PM, David Vincent-Jones wrote: > When I apply a 'star' rating during the raw conversion process this does > not appear to match the Geeqie rating system although the rating is > correctly shown in the exif data. What does "during the raw conversion process" mean? What program? Where is it saving the star count? > What form of rating can Geeqie work with? I want to be able to make a > selection based on the results of the raw processing. > > Should the Geeqie 'marks' correspond to the star rating? No. Perhaps it should be possible to associate marks with stars somehow, but marks serve a fundamentally different purpose — they allow you to easily set, unset, and filter on arbitrary labels. Moreover, marks are independent — that mark 4 is set has zero bearing on whether mark 3 is also set. --xsdg -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Next development
On 08/18/2012 09:14 PM, David Vincent-Jones wrote: > Would there be any point in trying to utilize an existing photo DB ... > for instance tying into Darktable? Perhaps, but DT definitely isn't a good option, unless they want to refactor. DT's image cache format is still really unstable (in the sense that it usually ends up requiring a full regeneration every couple months in master). Moreover, DT stores a _ton_ of info in its database that we shouldn't touch or be able to muck with. For instance, the image selection logic uses the database to store state (this is part of why image selection in DT is so horribly slow). Moreover, DT uses much more aggressive caching than geeqie will need to, since DT performs a ton more computation than geeqie to render a standard image. DT also does all kinds of mipmap caching to avoid scaling, but the scaling performance in geeqie seems really good already. --xsdg > > David > > On 12-08-17 09:20 AM, Uwe Ohse wrote: >> That certainly needs some kind of database. I remember some discussions >> on that, has there some kind of consensus been achieved? >> I'd personally like some kind of SQL database, for this would allow me >> to use the search functions of that DB. > > > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > Geeqie-devel mailing list > Geeqie-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geeqie-devel > -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Next development
On 08/16/2012 08:26 PM, vinit agrawal wrote: > Hi, > > I was thinking of, as i mentioned earlier sometime that a feature like > seemless image viewing mode will be very cool thing to add. > The inspiration is of course the google picasa viewer for windows, with > a dimmed background of the running windows and upfront will be the > image. But, a lot more things can be added to this. things like folder > navigation with image thumbnails and maybe a video preview option too. Never used Picasa. Can you describe in more detail, or take a screenshot? This sounds a lot like full-screen mode, which we already support. --xsdg > > I am not sure if clutter/libchamplain will be suitable to do these jobs. > Please let me know if you guys want to see such a feature as a view option. > and may be any suggestions on the libraries also. > > --Vinit > > On Fri, Aug 17, 2012 at 12:48 AM, Vladimir Nadvornik <mailto:nadvor...@suse.cz>> wrote: > > Dne čtvrtek 16 Srpen 2012 17:46:37 Omari Stephens napsal(a): > > On 08/16/2012 03:07 PM, Vladimir Nadvornik wrote: > > > On Wednesday, August 15, 2012 07:38:25 AM David Vincent-Jones > wrote: > > >> Is there an established goal, or set of goals, for Geeqie? If > so where > > >> will I find them. > > >> If the direction is already clearly stated somewhere it should > be much > > >> easier to prioritize the next development. > > > > > > Main goal is to create fast and flexible image viewer. > > > > > > The long term goals I can think of are: > > > > > > - GUI cleanup - now there are windows like search or > collections that > > > duplicates a lot of code of the main window. The common feature > they have > > > is that they provide a list of files, so they could be > integrated as > > > alternatives to the directory pane. > > > > Along these lines, When you chose "view image" from panview, that > goes > > to a separate display codepath as well. At one point that alternate > > display was not color-managed. ISTR that I may have fixed that, > but it > > should really be the same codepath as the standard window, with the > > ability to view EXIF info and change keywords and such. > > Yes, this code should be unified too. > > > > > > - porting to libgio > > > > > > - Pan view redesign - Pan view is based on a custom backend and > the code > > > is not easy to understand. With Clutter library it is possible > to achieve > > > the some functionality much easier. Also, integration of pan > view with > > > the rest of Geeqie could be improved. > > > > Yay! Is any of the code from the first Clutter attempt usable? > > > > Yes, I have a more or less working code for Clutter based renderer. > I will > just add an option to switch between clutter and the old renderer > and then I > will push it to master for wider testing. > > Then I think about implementing a Clutter Actor for Geeqie image - > with exif > orientation, color management, caching... and then it will be > possible to > rewrite the Pan View. But at the moment I am out of ideas for high-level > desing, so volunteers are welcome :-) > > > > > > - support of large images - currently there is a limitation > arould 32768 > > > pixels. Pixbuf renderer could be connected with image loader, > to request > > > downscaled version or only the displayed region of the image on > demand. > > > This will allow handling of large images with reasonable memory > > > requirements. > > > > This is 32,768 pixels of width or height, right? I have a 1920x1200 > > screen and have had zero problems displaying 50-megapixel images > > full-screen. > > > > IIRC there is a bug report about a panorama with dimensions 4x6000. > > > > > - use standard Gtk file dialog > > > > I don't generally use any file dialogs in Geeqie, but I _love_ > how the > > directory display textbox auto-completes and gives you an > autocomplete > > drop-down when you hit . Please don't replace that with GTK's > > horrendous button thing. > > > > OK :) > > Vladimir > > > > > -
Re: [Geeqie-devel] Next development
On 08/16/2012 03:07 PM, Vladimir Nadvornik wrote: > On Wednesday, August 15, 2012 07:38:25 AM David Vincent-Jones wrote: >> Is there an established goal, or set of goals, for Geeqie? If so where >> will I find them. >> If the direction is already clearly stated somewhere it should be much >> easier to prioritize the next development. >> > > Main goal is to create fast and flexible image viewer. > > The long term goals I can think of are: > > - GUI cleanup - now there are windows like search or collections that > duplicates a lot of code of the main window. The common feature they have is > that they provide a list of files, so they could be integrated as alternatives > to the directory pane. Along these lines, When you chose "view image" from panview, that goes to a separate display codepath as well. At one point that alternate display was not color-managed. ISTR that I may have fixed that, but it should really be the same codepath as the standard window, with the ability to view EXIF info and change keywords and such. > > - porting to libgio > > - Pan view redesign - Pan view is based on a custom backend and the code > is not easy to understand. With Clutter library it is possible to achieve the > some functionality much easier. Also, integration of pan view with the rest of > Geeqie could be improved. Yay! Is any of the code from the first Clutter attempt usable? > - support of large images - currently there is a limitation arould 32768 > pixels. Pixbuf renderer could be connected with image loader, to request > downscaled version or only the displayed region of the image on demand. This > will allow handling of large images with reasonable memory requirements. This is 32,768 pixels of width or height, right? I have a 1920x1200 screen and have had zero problems displaying 50-megapixel images full-screen. > - use standard Gtk file dialog I don't generally use any file dialogs in Geeqie, but I _love_ how the directory display textbox auto-completes and gives you an autocomplete drop-down when you hit . Please don't replace that with GTK's horrendous button thing. --xsdg -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Next development
On 08/13/2012 09:32 PM, David Vincent-Jones wrote: > > On 12-08-13 01:58 PM, Vladimir Nadvornik wrote: >> 16bit is necessary for editing. > Is there serious interest in *editing* in Geeqie? Not that I'm aware of; I'm pretty sure Vlad was merely contradicting my suggestion (and successfully). > My concern would be the facility for exporting to print with the full 16 > bit capability. Printing is hard; let's go shopping. More seriously, I only ever print from GIMP, because the printing process involves rescaling the image to match the print size at a given resolution (typically 250PPI), and then sharpening, which requires editing facilities. I believe this behavior is universal among serious photographers. That isn't to say that folks won't ever use geeqie to print, but I /do/ doubt that people who print from geeqie will care about taking advantage of the extra bit depth in their 16-bit images. This is assuming that geeqie already displays 16-bit images reasonably. --xsdg -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Next development
On 08/13/2012 06:10 PM, Vladimir Nadvornik wrote: > Hi all, > > Now, after 1.1 release it is time to focus on next development. > > As I wrote earlier, the next release will be 2.0. The main change will be Gtk3 > port, which I have mostly done. > > I also want to implement this: > > - GPU based scaling and color management with libclutter libclutter? color management? Are you referring to this? http://developer.gnome.org/clutter/1.9/clutter-Colors.html The thing that jumps out to me is that the 8-bit color assumption is baked in. Given that GIMP master already supports arbitrary-bit-depth images (not release-ready, yet, but it definitely works), it seems we should be preparing for an onslaught of 16-bit linear TIFFs and PNGs. As a photographer, I know there are lots of situations where 8-bit formats killed me for banding in large gradient areas (imagine a sunset in grayscale). (Naive statement) I'd personally like to see us use babl to support arbitrary color formats. To be explicitly clear, I don't know what we do or don't support today, and I also don't know how babl might affect our performance. Just wanted to put that out there, though. > - sorting by exif date (this will requiure some sort of metadata caching) > - presentation mode - window + fullscreen on second monitor > - fix problems in metadata editor > > Today I will push my Gtk3 code to master. It compiles and mostly works for me > with gtk 2.24 and 3.2. Porting to older versions is possible but I'd like to > drop support for too old versions, to make the code better readable. Please > test and report any problems. GTK 2.24.0 was released in Jan 2011. That'll have been a full two years by the end of this year. No need to support anything older than that, especially if it requires extra #ifdefs. --xsdg -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Geeqie 1.1
On 08/07/2012 07:27 PM, John Stoffel wrote: > > vinit> The current version of geeqie1.1 that vladimir has putted, is > vinit> not been able to recognize the image files if the file names of > vinit> these file do not end with one of the standard image file > vinit> extension. I think the application should look into the > vinit> directory for all the image files based on their format rather > vinit> than their file extension. like how the nautilus, the default > vinit> file browser for gnome does. it does it for all media files. i > vinit> think geeqie should have this feature. > > It's a good idea, but maybe have it as an option instead? If the > option is on (default off), geeqie does the equivilent of a 'file' > command on each file to see if it can determine the image type. > > And if you want to whip up a patch, even just an example one, I'm sure > that would be an incentive to get it into the app. If it's an option, it should default to off. Having to fork() and read() for every single file in a directory is drastically more expensive than just doing a single scandir() on the containing directory. That said, I do question just how useful or widely-used it would be. How many people (1) have images which are stored without appropriate file extensions, and (2) use, or would use, geeqie rather than something less powerful/more user-friendly? Given how many dark, unmaintained corners geeqie has already, I definitely think we should make sure that the features we add have sufficient value. --xsdg -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] assign keyword to group of images
On 07/08/2012 11:38 AM, Toni Mini wrote: > I was wondering if it is possible to assign the same keyword to a group > of images. Such as I have found in the documentation and by trying it > out myself, I can only assign the same keyword to one image at a time. You have to use the keywords pane (ctrl+shift+k) 1) Highlight the images you want 2a) If you have the keyword saved, right-click the keyword and hit "Add keyword to selected images" 2b) If you don't have the keyword saved, type in the keyword; then right-click the box and hit "Add keywords to selected images." If there are multiple keywords in the box, each of them will be added to every selected image. --xsdg -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Geeqie 1.1
On 07/27/2012 07:56 PM, Vladimir Nadvornik wrote: > Dne pátek 27 Červenec 2012 17:44:27 John Stoffel napsal(a): >> >> Can you give a summary of the differnces between the two branches? >> Maybe it would make sense to replace a 1.1beta patch release and a all >> the new features in a 2.0beta release so we cna look them over and see >> what's needed. >> > > stable/1.1 branch contains just some bugfixes > > master contains these features > - support for stereoscopic images > - rewritten file grouping - it no longer tries all uppercase combinations > - custom tiff loader - more efficient on large tiffs > > It is a long time since 1.0 release, I think that the distributions already > have their own fixes, so it makes no sense to do a pure bugfix release now. Release master. I've been using it also, and it's been stable for me as well. Call it whatever version number you like. Don't do any incremental releases before master. The main reason we ended up in this 1.5-year slump is because it took 6 months to release 1.0, because we kept trying to release something that was perfect instead of something that was good enough. Let's move faster this time and avoid getting burned out. --xsdg -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] XMP 'file' Display
No, my point was that if you figure out the answer to a question that nobody else has the answer to, you should share it, rather than just saying "oh, I know now." My email was prompting you to share your solution. --xsdg On 07/16/2012 05:02 PM, David Vincent-Jones wrote: > Sorry Omari your cryptic answer is not clear. > > On Mon, 2012-07-16 at 02:47 +0000, Omari Stephens wrote: >> And the answer is... >> >> --xsdg >> >> On 07/16/2012 02:26 AM, David Vincent-Jones wrote: >>> OK I finally found it! >>> >>> On Sun, 2012-07-15 at 12:11 -0700, David Vincent-Jones wrote: >>>> Is there any way that I can avoid Geeqie trying to display my .xmp files >>>> as if they were image files? > > -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] XMP 'file' Display
And the answer is... --xsdg On 07/16/2012 02:26 AM, David Vincent-Jones wrote: > OK I finally found it! > > On Sun, 2012-07-15 at 12:11 -0700, David Vincent-Jones wrote: >> Is there any way that I can avoid Geeqie trying to display my .xmp files >> as if they were image files? -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] [patch] fixes a crash on geeqie ~/foto.JPG
I'm pretty sure this is a problem that I found and created a fix for previously. See "[PATCH] Fix segfault when using a filename on the commandline" from 27 Feb 2012. If you have that change (or equivalent), it may mean my change was incorrect or incomplete, in which case I can take another look. Just fixing the segfault is not necessarily correct, since there are a couple different codepaths there, and some of them may depend on initialization in a specific order. --xsdg On 06/18/2012 11:21 PM, Carles Pina i Estany wrote: > > Hi, > > Using master I found a crash when doing geeqie ~/photo.JPG . > > I haven't had time to investigate properly (where the crash was added? > in the Debian package 1:1.0-10 this is not happening). > > Find attached a possible fix. > > Regars, -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] xmp information
On 06/15/2012 05:53 PM, David Vincent-Jones wrote: > Is there any way to be able to display the xmp data (specifically > 'keywords') when I click on an image? I have to click on the xmp file > now to see the tags. It sounds like geeqie isn't associating the xmp sidecars with the images. Maybe play around in the prefs? I know there are a couple settings related to where/how geeqie tries to find XMP files that are related to a given image. --xsdg -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] New development
I had sent a bugfix patch to the list, "[PATCH] Fix seghfault when using a filename on the commandline". Dunno if someone pushed that or not, but it should definitely be in any new release. --xsdg On 05/14/2012 05:22 PM, Klaus Ethgen wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Hi Tore, > > Am Mo den 14. Mai 2012 um 7:28 schrieb Tore Ericsson: >> I once comitted a complete Swedish translation (thanks for excellent >> guidance) >> but did never come to merge it into some main master branch being too >> unexperience with git. > > 2011-02-14, I see. > > I think we should train our staff to know how to work with our tools. > And git is a very powerful tool I think. :-) > > Would be a nice Idea to have a online course for such. > >> I would appreciate someone to also marge that translation into the main and >> tell if I can help to resolve any conflicts coming up. > > I can do so. In fact, I did. ;-) No conflicts. > >> And can we have an updated version on Sourceforge sooner or later? This is a >> too valuable a software to slumber like that for general users! > > I think, yes. We should update the 1.x version soon. Also we can provide > a monthly snapshot or so. > > Candidates for inclusion in stable branch (beside that, that are > settled in by now.): > - - Translation updates: 8c25cb5, 236bc4c, dc3dea1, ce2d11c, 1ce6b8f, >590da3d > - - b71f37b -- Bugfix > - - 7a426d7 -- File class extended > - - GTK deprecated stuff: dd54e57 > - - b71da22 -- Bugfix > - - svn->git leftovers: 55de20b, 4e2e57b > - - a4270ac -- Bugfix > - - 559683d -- Added copyright note > - - 7bb3871 -- Bugfix > - - 18d80ca -- Bugfix > - - 5ef3084 -- Bugfix > - - d53d2b9 -- Bugfix > - - 83db9a2 -- Bugfix > - - 09c22e6 -- Bugfix > - - 103c2e2 -- Better code (;-) > - - 4f944cd -- Better code, fixed whitespaces > - - 9b64785 -- README update > - - d8b7b32 -- Dito > - - 49d0e74 -- Better Text > - - evtl. 924ca61 > > I think I will cherry-pick them if there is no objectives against. How > should we number the stable update? 1.1, I would say? > >> This is, in my opinion, the best fast general image viewer ever made! > > My opinion too. That is the reason why I help making it more better. :-) > > Gruß > Klaus > - -- > Klaus Ethgen http://www.ethgen.ch/ > pub 4096R/4E20AF1C 2011-05-16 Klaus Ethgen > Fingerprint: 85D4 CA42 952C 949B 1753 62B3 79D0 B06F 4E20 AF1C > -BEGIN PGP SIGNATURE- > Version: GnuPG v1.4.12 (GNU/Linux) > > iQGcBAEBCgAGBQJPsT9VAAoJEKZ8CrGAGfasOOcL/2IviWqZzt5EATY68wj2KdWx > CIqepY0S6iauXAqGTbl0LwoAKGl8x+1n5Rja2GMT6VRC55zm4EjSZCSGfZlp6pHQ > ylnX8RTQkcQqPZKynZYW6WxTBveUTnKjW+1ein3NWftwalxBUCTk4y6mXa4xwVls > slYZuKqYkXKZvkHGxfsKVpPEAXZzsA2Xt5mNU3xocGniZCfVpotUV2x4urpHMh4V > DtQDMhf6Q/nB5IhD+51eBaXikHbXF4ECATKYmUHl1r6yChw9KwHTFH3CkLzTacrZ > gmo9NtbkuLRvr8o3vEDRSa7mjLQyLhLkR1jviawefBNeyG+Lu2aNS6l5WjxSLoEE > ktNeYz9O0KZO06LTSHFb8HTziQA7INBjwGr0ILRw/8LUUfFKMtrseTlha/ZuPbI0 > e0oARpVOXTnbi8kYnOkdPH5uv37fj8bivqAr8CmnuyDLMPQf4vkU+gsEJSX3EQ2y > Dl/YKQ9jQzsgPlTziPQ3uAUm0lWqUq6M8XJ6V99yhg== > =0VD3 > -END PGP SIGNATURE- > > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > Geeqie-devel mailing list > Geeqie-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geeqie-devel -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Star Rating
On 04/07/2012 08:14 PM, David Vincent-Jones wrote:
How are users dealing with the lack of a 'star' rating?
Is there any way to add to the Windows Rating value?
Personally, I just use keywords. I predominantly use three keywords
named "decent", "top20", and "top10". I use the "Connect keyword to
mark" functionality extensively, which lets me trivially toggle and
filter on up to six keywords. In particular, this works well for me
since I don't have info in geeqie that other apps need to know about.
I had written a partially-completed patch to plumb the EXIF (I think)
Rating value through to the UI, but it's bit-rotted a bit; I last
touched it 2.5 years ago (wow). It's attached.
That said, even when I had my local geeqie build patched with it, I
didn't find it anywhere near as useful as the keywords. Particularly
because it wasn't easy to filter by the rating (you could search, but
you couldn't just filter like you can with marks).
--xsdg
diff --git a/trunk/src/Makefile.am b/trunk/src/Makefile.am
index 144b090..9528d30 100644
--- a/trunk/src/Makefile.am
+++ b/trunk/src/Makefile.am
@@ -94,6 +94,8 @@ geeqie_SOURCES = \
bar_keywords.h \
bar_exif.c \
bar_exif.h \
+ bar_rating.c\
+ bar_rating.h\
bar_sort.c \
bar_sort.h \
cache.c \
diff --git a/trunk/src/bar.c b/trunk/src/bar.c
index 52d6a54..4d64b71 100644
--- a/trunk/src/bar.c
+++ b/trunk/src/bar.c
@@ -25,6 +25,7 @@
#include "ui_menu.h"
#include "bar_comment.h"
#include "bar_keywords.h"
+#include "bar_rating.h"
#include "bar_exif.h"
#include "bar_histogram.h"
#include "histogram.h"
@@ -76,6 +77,15 @@ static const gchar default_config_comment[] =
""
"";
+static const gchar default_config_rating[] =
+""
+""
+""
+""
+""
+""
+"";
+
static const gchar default_config_exif[] =
""
""
@@ -178,6 +188,7 @@ static const KnownPanes known_panes[] = {
{PANE_GPS, "gps", N_("GPS Map"), default_config_gps},
#endif
#endif
+ {PANE_RATING, "rating", N_("Rating"),
default_config_rating},
{PANE_UNDEF,NULL, NULL, NULL}
};
diff --git a/trunk/src/bar.h b/trunk/src/bar.h
index 61dc4be..d24acf3 100644
--- a/trunk/src/bar.h
+++ b/trunk/src/bar.h
@@ -20,7 +20,8 @@ typedef enum {
PANE_EXIF,
PANE_HISTOGRAM,
PANE_KEYWORDS,
- PANE_GPS
+ PANE_GPS,
+ PANE_RATING
} PaneType;
typedef struct _PaneData PaneData;
diff --git a/trunk/src/bar_rating.c b/trunk/src/bar_rating.c
new file mode 100644
index 000..0898183
--- /dev/null
+++ b/trunk/src/bar_rating.c
@@ -0,0 +1,401 @@
+/*
+ * Geeqie
+ * (C) 2004 John Ellis
+ * Copyright (C) 2008 - 2009 The Geeqie Team
+ *
+ * Author: Omari Stephens
+ *
+ * This software is released under the GNU General Public License (GNU GPL).
+ * Please read the included file COPYING for more information.
+ * This software comes with no warranty of any kind, use at your own risk!
+ */
+
+
+#include "main.h"
+#include "bar_rating.h"
+
+#include "bar.h"
+#include "metadata.h"
+#include "filedata.h"
+#include "ui_menu.h"
+#include "ui_misc.h"
+#include "rcfile.h"
+#include "layout.h"
+#include "layout_image.h"
+
+static void bar_pane_rating_changed(GtkSpinButton *button, gpointer data);
+
+/*
+ *---
+ * rating utils
+ *---
+ */
+
+
+
+typedef struct _PaneRatingData PaneRatingData;
+struct _PaneRatingData
+{
+ PaneData pane;
+ GtkHBox *container;
+ GtkSpinButton *spinbutton;
+ GtkToggleButton *auto_adv; // autoadvance
+ FileData *fd;
+ gchar *key;
+ gint height;
+};
+
+
+static void bar_pane_rating_write(PaneRatingData *prd)
+{
+ guint value;
+
+ if (!prd->fd) return;
+
+ value = gtk_spin_button_get_value_as_int(prd->spinbutton);
+
+ metadata_write_int(prd->fd, prd->key, value);
+}
+
+
+static void bar_pane_rating_update(PaneRatingData *prd)
+{
+ guint64 value;
+
+ g_signal_handlers_block_by_func(prd->spinbutton,
bar_pane_rating_changed, prd);
+
+ value = metadata_read_int(prd->fd, prd->key, (guint64)-1);
+
+ if(value != (guint64)-1)
+ {
+ gtk_spin_button_set_value(prd->spinbutton, value);
+ }
+ else
+ {
+ gtk_spin_button_set_value(prd->spinbut
[Geeqie-devel] [PATCH] Fix segfault when using a filename on the commandline
Patch attached.
I don't know if this is the correct fix, but it does seem to work in the
limited testing that I've done. The problem only happens when
specifying an image filename on the commandline. Simply specifying a
directory works fine.
--xsdg
>From 4e29db57ca00952c7485758099034c058916331f Mon Sep 17 00:00:00 2001
From: Omari Stephens
Date: Mon, 27 Feb 2012 06:02:02 +
Subject: [PATCH] Fix segfault when a filename is specified on the commandline
Somehow, the file-specified-on-commandline codepath developed a
dependency on the options global, which hadn't been initialized
yet. This change simply moves the commandline parsing to below
the options variable initialization.
(gdb) r /PATH/TO/FILE.jpg
[...]
(gdb) bt
#0 0x004559d2 in filelist_read_real (dir_path=,
files=0x7fffe638, dirs=0x0, follow_symlinks=)
at filedata.c:955
#1 0x00455f0c in file_data_new_group (
path_utf8=0x773300 "/PATH/TO/FILE.jpg") at filedata.c:1040
#2 0x0047472f in parse_command_line_add_file (
file_path=, path=0x773da8, file=0x773db0,
list=0x7fffe758, collection_list=0x773dc0) at main.c:128
#3 0x00419ae2 in parse_command_line_process_file (
first_dir=0x7fffe768, collection_list=,
list=0x7fffe758, file=, path=,
file_path=0x773220 "/PATH/TO/FILE.jpg") at main.c:205
#4 parse_command_line (argv=0x7fffe888, argc=)
at main.c:241
#5 main (argc=2, argv=0x7fffe888) at main.c:805
---
src/main.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/main.c b/src/main.c
index 1ddee03..9b25b4c 100644
--- a/src/main.c
+++ b/src/main.c
@@ -801,9 +801,6 @@ gint main(gint argc, gchar *argv[])
DEBUG_1("%s main: pixbuf_inline_register_stock_icons", get_exec_time());
pixbuf_inline_register_stock_icons();
- DEBUG_1("%s main: parse_command_line", get_exec_time());
- parse_command_line(argc, argv);
-
DEBUG_1("%s main: mkdir_if_not_exists", get_exec_time());
/* these functions don't depend on config file */
mkdir_if_not_exists(get_rc_dir());
@@ -821,6 +818,9 @@ gint main(gint argc, gchar *argv[])
options = init_options(NULL);
setup_default_options(options);
+ DEBUG_1("%s main: parse_command_line", get_exec_time());
+ parse_command_line(argc, argv);
+
DEBUG_1("%s main: load_options", get_exec_time());
if (!load_options(options))
{
--
1.7.2.3
--
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Geeqie with Darktable
Please keep replies on the mailing list. On 10/27/2011 05:25 PM, David Vincent-Jones wrote: > On Thu, 2011-10-27 at 08:49 +0000, Omari Stephens wrote: >> If you manually edit to, > Excuse my ignorance but where do I make this edit? I assume > that would be a global change. I mean, take a text editor and edit the .xmp file directly. This is just an experiment to see if that could be confusing geeqie (I'm not entirely sure how its XMP parsing works). > In the preferences/metadata I have checked the (non-standard) item 2 > since, I assume that, item 1 would write directly to my raw date files. Check 1. Otherwise, geeqie will look for an XMP in a separated .metadata directory. Otherwise, you could try to figure out the .metadata business; I've never used that setting, so I don't know how it behaves. Just make a copy of a couple files in a test directory so you can play around with these settings without actually endangering the files you care about. --xsdg > In the preferences/files if I check xmp then the sidecar files show .. > not very nice. I do have "%.cr2.xmp" added to sidecar grouping and that > appears to work correctly. > > David > -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Geeqie with Darktable
[re-adding geeqie-devel] So, it looks like this is closer to working than I initially suspected. From your darktable sample xmp, I see: darktable|format|cr2 Soglio Switzerland From a random geeqie xmp of mine, I see: decent art225 top20 top10 So both are using the dublin core standard for storing tags. If you manually edit to , does that help things out? The other thing: if you go to Edit->Preferences->Metadata and twiddle with the checkboxes in the "Metadata writing process" section, does that help? It's possible that geeqie isn't finding the XMP at all, and is only displaying the EXIF data that's embedded in the PNG itself. --xsdg On 10/26/2011 08:50 PM, David Vincent-Jones wrote: > Omari; > > I am using 'mybigfile' to send a raw file set to you. > > The Raw+xmp display in Geeqie displays absolutely no exif data from the > sidecar file. The Sidecar file by itself ( if included in the display > list) can however be used to view the exif data. I do not really need to > see the sidecar file just need to view the exif data. > > The exif sidebar file does not display anything other than basic camera > settings. Can it be modified? > > My png file from this set correctly displays the exif data in Digikam > but not in Geeqie ... maybe this is my set-up problem. > > There is no * 'star' rating from any other program despite a rating > being shown in the exif material. > > A further question: is it possible to display the thumbnails in a > 'non-wrapped' mode in the top display position. Wrapping often puts the > raw and final products on different rows which is annoying. > > Bottom line: I just need Geeqie to be able to read and sort incoming > exif aware images, hopefully using tags and ratings. > > David > > On Sun, 2011-10-23 at 21:20 +, Omari Stephens wrote: >> On 10/22/2011 03:38 PM, David Vincent-Jones wrote: >>> I am a new user and would like to use Geeqie as a manager for my images >>> in conjunction with the darktable editor. >>> >>> Image titles, tags and other exif data that I add to my images during >>> the raw conversion process are not included within the Geeqie exif >>> listing ... can that list be modified to include such data? >>> >>> Can the Key-word listing be modified to also filter for exif data? >> >> My initial guess would be that dt is saving the data as IPTC metadata >> (google it). Geeqie currently has no support for IPTC. >> >> It'd be helpful if you could share a link to a RAW image, the associated >> XMP (that dt will save in the same directory), and the output image >> (JPEG/PNG/whatever). >> >> Cheers, >> --xsdg > > -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Geeqie with Darktable
On 10/23/2011 09:51 PM, David Vincent-Jones wrote: > Thanks for the response .. > > A bit more investigating from my end and I see that if I use the exif > separate 'window', information is being correctly written to the sidecar > file .. but .. it is not being displayed where I need to see it in the > 'sidebar exif window'. Can added fields be added somehow? I have tried > to modify the config to do this but without success. So, as far as I can tell, geeqie's keywords list uses the "Dublin Core" spec to store keywords. There are other ways to store keywords. Again, it'd be a lot easier to figure out what's actually going on with sample files. > Again, if I modify the sidebar keywords' list in the config file will it > read the exif tags or do I need to totally re-tag my images (big job). Modifying the list of stored keywords is unlikely to help. Keywords should show up in the keywords list (aka left side) without being in the stored keywords list (right side). > When I try to Keyword tag an image group I find that only the last image > in the tag becomes tagged ... how would one add keywords to a selected > image group? Select all of the relevant images, and then right-click on a stored keyword. You should see the option "Add keyword to all selected images" near the top of the contextual menu. --xsdg > > David > > On Sun, 2011-10-23 at 21:20 +, Omari Stephens wrote: >> On 10/22/2011 03:38 PM, David Vincent-Jones wrote: >>> I am a new user and would like to use Geeqie as a manager for my images >>> in conjunction with the darktable editor. >>> >>> Image titles, tags and other exif data that I add to my images during >>> the raw conversion process are not included within the Geeqie exif >>> listing ... can that list be modified to include such data? >>> >>> Can the Key-word listing be modified to also filter for exif data? >> >> My initial guess would be that dt is saving the data as IPTC metadata >> (google it). Geeqie currently has no support for IPTC. >> >> It'd be helpful if you could share a link to a RAW image, the associated >> XMP (that dt will save in the same directory), and the output image >> (JPEG/PNG/whatever). >> >> Cheers, >> --xsdg > > -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Geeqie with Darktable
On 10/22/2011 03:38 PM, David Vincent-Jones wrote: > I am a new user and would like to use Geeqie as a manager for my images > in conjunction with the darktable editor. > > Image titles, tags and other exif data that I add to my images during > the raw conversion process are not included within the Geeqie exif > listing ... can that list be modified to include such data? > > Can the Key-word listing be modified to also filter for exif data? My initial guess would be that dt is saving the data as IPTC metadata (google it). Geeqie currently has no support for IPTC. It'd be helpful if you could share a link to a RAW image, the associated XMP (that dt will save in the same directory), and the output image (JPEG/PNG/whatever). Cheers, --xsdg -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] New behavior for alphabetical order?
Both of these problems sound like they stem from locale problems. Locale affects both sort order and default console charset. Try `echo $LANG` on both machines. --xsdg On 05/19/2011 11:40 PM, Raymond Ouellette wrote: > Québec, le 19 mai 2011 > > Hi, > > I was a long time user of GQview now using Geeqie with great pleasure > since it's out. > > After a trekking trip in Nepal, I retained more than 1200 photos that I > usually present with Geeqie. Using version 1.0beta2 (Ubuntu 10.04 > 64bits) a picture with a name like 101011-1319.jpg comes BEFORE > 101011-1319a.jpg. > > But, on my small netbook, with Geeqie 1.0 (Ubuntu 11.04 32bits), it's > the opposite: 101011-1319a comes AFTER 101011-1319. Why is there a > change in the behavior of alphabetical order? > > I also notice another change: I use Niccolo Rigacci's python script to > interact with metadata and write an Exif.Photo.UserComment (unicode > char). Everything was OK with 1.0beta2, but with the new Geeqie 1.0 > most of my comments now display chinese characters :-( I have to > rewrite them by hand... I also notice that using Exiv2 -pt the comment > also use chinese characters... I don't know how to explain this change > either! > > T thought that it was because my comments are in french and some > diacritics (accents, cedilla...) where the cause of the > misunderstanding of character set, but this is not the case. Some > comments, with diacritics are OK, others that have none are not OK... > > I hope to find a solution! > > Regards, > > Raymond > -- What Every C/C++ and Fortran developer Should Know! Read this article and learn how Intel has extended the reach of its next-generation tools to help Windows* and Linux* C/C++ and Fortran developers boost performance applications - including clusters. http://p.sf.net/sfu/intel-dev2devmay ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] On refcounting
On 05/07/2011 09:20 AM, Vladimir Nadvornik wrote: > Hi, > > On St 4. května 2011, Omari Stephens wrote: >> Howdy, all >> >> I'm poking around with the marks code. Currently, marks are _really >> slow_ when you connect at least one mark to an image tag — when an image >> with no marks drops to zero refs, we lose track of what marks it may >> have, and on the next marks filtering op, we end up having to hit the >> XMP for every file in the directory. >> > > This analysis is not exactly right. > > 1. All files in current directory are hold in ViewFile->list so they can't > have zero refs. > > 2. When there is a connection between mark and keyword, the mark value is > no longer taken from FileData, but file_data_get_mark() calls > file_data_get_mark_func and uses it's result. The value in FileData is then > updated, but it is important only for keeping the last value after the > connection is switched off. > > 3. file_data_get_mark_func points to meta_data_get_keyword_mark which then > calls metadata_read_list(). It uses cached metadata when they are available > or it really reads them from file. > > So IMHO the problem appears the number of files in the directory is higher > than the number of files with cached metadata. Caching all metadata is quite > expensive (even 100KB per file), so I would fix this by implementing another > long-term cache for selected metadata entries (keywords) in > metadata_read_list(). Hmm. So the observation I made is that with the stock code, for all files _except_ for those with some marks set, fd->valid_marks is reset to 0 each time we enter file_data_get_mark. That automatically means that fd->marks is a cache miss and we hit file_data_get_mark_func as you mentioned. If I do a single unbalanced file_data_ref_fd(fd) after sticking a valid value into the fd->marks cache, then we get cache hits on fd->marks every time thereafter. So there's something that's causing the cached marks to get GCed which doesn't happen when I do a single extra ref increment. That said, I'll print out the actual refcount or something to try to figure out what's going on. Also, I wasn't aware that there was another metadata cache, I'll go poke at that. --xsdg -- WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Documentation and code standards
On 05/05/2011 07:50 AM, Colin Clark wrote: > Hi > Perhaps I could make some comments here not as a developer, but as a user. >> 1) It's probably a good idea for us to start documenting the functions >> we write and the APIs we create. For one, it's a reminder to think >> about what specific problems the function/API is solving. Beyond that, >> it helps someone unfamiliar with the code figure out what's going on, >> and it helps them avoid misusing a particular function. > What I find missing is high-level documentation, not low-level. An > overall description of the way the system is organised and how the main > functions and structures should be used. But in my experience, > programmers won't produce documentation even when they are being paid to > do it, and no-one is being paid to work on Geeqie. Being realistic, I > don't think it is reasonable to expect people to do this. I agree that high-level documentation is missing; this is what Klaus also mentioned at the end of his email. I specifically mentioned function-level documentation because the pieces are easy, and as we gradually get more coverage, writing a higher-level document becomes that much easier. >> 2) We need to have a maximum line length. It can be long, sure, but >> it's pretty obscene when there are lines so long that they wrap on my >> 26" widescreen monitor (layout_util.c is a pretty bad offender). I'm >> going to suggest 160 characters; see * below. >> > Line length was important to me when I used 72-character terminals > nearly half a century ago. Now I use a visual editor with line-wrap > enabled. No matter what size window I use, the code is readable. I find it visually disconcerting when text wraps automatically at what is typically some arbitrary point in the line. I think it would be more readable if the breaks were made intentionally rather than incidentally. > But I do find it very surprising that Geeqie has a non-standard coding > format. Layout consistency could be achieved if the developers selected > a standard format - maybe Allman or Whitesmith - and run all code > through a code beautifier before putting it in the repository. Time > spent on code formatting by hand is not a good use of time and will > result in inconsistencies. I'm not a fan of auto-formatters because they typically make it hard to deviate from the standard, _even in situations where the deviation would make code that is more readable_. > > > May I also make a plea for the common user, people like me who can just > about do a configure/make. > > Would it be possible for source tars (or even .deb files) of the latest > files to be put on the Geeqie homepage on sourceforge? Is it possible > for this do be done automatically whenever one of the git repositories > is updated? Not to dismiss your plea, but please remember that Geeqie is a project whose development was essentially stalled for a year and a half, and is only now just starting to get back up to speed. Those things will undoubtedly come in time, but now is certainly not the time for people to overcommit again. We can probably wait for any sort of automated stuff until we average more than one commit to master per month. > I would also encourage the developers to try to make Geeqie at least as > good as GQview. There are two problems where I find GQview is > significantly better than Geeqie: At this point, I think it's most important for devs to work on whatever the heck they want; something (anything) is better than nothing. Later on down the line, we can probably start making a more concerted effort to fix the bugs that have been reported and add useful features, but at this point, I think the key first step is for people to get back in the habit of spending time working on geeqie, and coming up with changes that end up in master. --xsdg -- WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
[Geeqie-devel] On refcounting
Howdy, all I'm poking around with the marks code. Currently, marks are _really slow_ when you connect at least one mark to an image tag — when an image with no marks drops to zero refs, we lose track of what marks it may have, and on the next marks filtering op, we end up having to hit the XMP for every file in the directory. My current plan is to just ref every FileData in the directory if marks are turned on (and then unref them all when we change directories), which means that marks filter operations will be hitting an in-memory cache rather than having to go to disk _and_ reparse all the XML. That said, I imagine that we'd be better off just always holding a ref for every FileData in the current directory. On my machine, a FileData is 176 bytes and a GList is 24 bytes, so for a directory of 20,000 images, we'd be spending 3.8MB holding FileDatas. That's nothing. In turn, it'd mean that we could suddenly sort or filter by any XMP or EXIF tag and it'd be fast, without having to do any refcount special-casing. We'd hit the disk at most once for every FileData in the directory, and that's it. Thoughts? --xsdg -- WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
[Geeqie-devel] Documentation and code standards
Howdy, all. It's time for a thought on code cleanliness
1) It's probably a good idea for us to start documenting the functions
we write and the APIs we create. For one, it's a reminder to think
about what specific problems the function/API is solving. Beyond that,
it helps someone unfamiliar with the code figure out what's going on,
and it helps them avoid misusing a particular function. That will help
keep the code clean because it'll decrease the likelihood that we have
to disentangle two bits of code that shouldn't have been coupled in the
first place. As mentioned in CODING, we use doxygen.
Note that my intention here isn't to have folks pick through the code
and document _every last thing right now_. But rather, it's for people
to document the code that they're working with, working on, and writing,
as they do so.
2) We need to have a maximum line length. It can be long, sure, but
it's pretty obscene when there are lines so long that they wrap on my
26" widescreen monitor (layout_util.c is a pretty bad offender). I'm
going to suggest 160 characters; see * below.
3) Indentation. First, we should probably document the size of the tabs
(currently 8 characters, at least from the one file I'm looking at).
Secondly, it would take a lot of effort to switch, but I think we should
at least consider a more compact indentation format. I'm personally a
fan of 4 spaces. But I think that the width of our indents is a
contributing factor to the immense lengths of lines in our code.
* Below is a histogram of line lengths in our .c files. I think 160
characters is sufficiently long that it won't be _too_ much of a chore
to shorten all of the super-long lines, but it's still short enough to
be feasible on most of today's monitors.
16:28:27> [xsdg{intercal}@~/files/compile/photos/gitqi/src]
$ruby -e 'lc = Hash.new{|h,k| h[k] = 0}; ARGV.each{|f|
File.new(f).each_line{|l| l.gsub!(/\t/, " "*8); lc[l.length/10] += 1}};
csum = 0; lc.sort.each{|(x,y)| csum += y; printf "%3d-%3d: %s %d\n",
10*x, 10*(x+1)-1, y.to_s.ljust(5), csum}' *.c
0- 9: 26174 26174
10- 19: 8520 34694
20- 29: 12967 47661
30- 39: 11622 59283
40- 49: 7885 67168
50- 59: 6237 73405
60- 69: 5867 79272
70- 79: 5349 84621
80- 89: 3516 88137
90- 99: 1951 90088
100-109: 1120 91208
110-119: 579 91787
120-129: 313 92100
130-139: 9392193
140-149: 4392236
150-159: 2192257
160-169: 2092277
170-179: 1892295
180-189: 2392318
190-199: 3692354
200-209: 5992413
210-219: 3992452
220-229: 5 92457
** an expanded version of the ruby one-liner above:
ruby -e 'counts = Hash.new{|h,k| h[k] = 0}; # default value of 0
ARGV.each{|fname|
File.new(fname).each_line{|line|
line.gsub!(/\t/, " "*8); # count a tab as 8 spaces
counts[line.length/10] += 1 # histogram with bucket size 10
}
};
csum = 0; # cumulative line counts
counts.sort.each{|(range, count)|
csum += count;
printf("%3d-%3d: %s %d\n",
10*range, 10*(range+1)-1, count.to_s.ljust(5), csum)
}' *.c
--xsdg
--
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network
management toolset available today. Delivers lowest initial
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Geeqie repositories
Reply-to considered harmful 8) --xsdg -- WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Geeqie repositories
Hey, Klaus
I just created an account on gitorious ("xsdg" as might be expected).
Could you add me to geeqie-developers?
Thanks,
--xsdg
On 04/15/2011 03:35 PM, Klaus Ethgen wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> Hello Vladimir,
>
> Am Fr den 15. Apr 2011 um 14:54 schrieb Vladimir Nadvornik:
>> Do I understand it correctly that now everybody is using his own branch
>> and master is unchanged since December?
>
> So far until now.
>
>> Who and when will merge the branches to master?
>
> Well, I think, if one feature is ready to go in the main branch it could
> be merged. I think that this should be done of the owner of the work but
> could be done by everyone that can commit.
>
>> Does merging of one branch mean that the other branches should be
>> rebased?
>
> I do not think that rebasing is the right way then. You can merge back
> the master to your branch or cherry-pick commits from there. The power
> of git is to handle multiple merges very well.
>
> It is also thinkable to delete the branch after full merge and recreate
> it later on as a new branch.
>
> That is the freedom you have with git. :-)
>
>> Now for my patches. They are not 100% finished, but I want to publish them
>> for testing, so I will push them to gitorious/nadvornik-stereo, OK?
>
> Right.
>
> If someone want to test, he can checkout that branch or do a (temporary)
> merge to his own local branch.
>
> But as I see correct, you have to be added to geeqie-developers. As I
> see, your account there is nadvornik so I added you.
>
>> Can you please give me write permission for the project?
>
> Ah right, sorry, read sequential. ;) You should be an administrator now.
>
> I think the main persons are in that group now.
>
> Regards
> Klaus
> - --
> Klaus Ethgenhttp://www.ethgen.ch/
> pub 2048R/D1A4EDE5 2000-02-26 Klaus Ethgen
> Fingerprint: D7 67 71 C4 99 A6 D4 FE EA 40 30 57 3C 88 26 2B
> -BEGIN PGP SIGNATURE-
> Version: GnuPG v1.4.11 (GNU/Linux)
>
> iQEVAwUBTahlrp+OKpjRpO3lAQpbxQgAkisChVQwgsQovCT+Xbm1CUqhR4JbPSnD
> VtD1iPRLXM0Cb4io1MINevSHae6Sa38KhPPRa2/BuMulbfgGtW6RHB4AkfRGwFgS
> +8A9OPWPoH6s0xbbQcxlJVByQ6R2ICD+/cypwfGXj0JbXI5MdymkL94Qd2EVRpNA
> AQziYq+mfjgVKIMt8MA7NlfRg6/XutHzeLSQTjDr8yBUde2k2cf0PZOpYbOo68VJ
> Cx0f8EJdvkFc+i+G/qN6iUNedSavgWnifveaZmwUAysjefHI4qJl43NRT1lFQ9fR
> I2ROgPHm3XN4RyelN+raSRU/zwtWy+MdLnAky8b1xkOZvE4tGZk3tA==
> =/NeL
> -END PGP SIGNATURE-
>
> --
> Benefiting from Server Virtualization: Beyond Initial Workload
> Consolidation -- Increasing the use of server virtualization is a top
> priority.Virtualization can reduce costs, simplify management, and improve
> application availability and disaster protection. Learn more about boosting
> the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
> ___
> Geeqie-devel mailing list
> Geeqie-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geeqie-devel
--
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network
management toolset available today. Delivers lowest initial
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] grouping with darktable xmp files
On 04/14/2011 05:39 PM, Colin Clark wrote:
> On 13/04/11 22:01, Colin Clark wrote:
>> On 10/04/11 17:51, stair wrote:
>>> I have recently starting using darktable for my raw processing and have
>>> come across a problem with the way geeqie groups darktable's xmp files, or
>>> rather doesn't, the files are not grouped
>>>
>>> when darktable creates it's sidecar files they are given the raw file full
>>> name including extension, in my case image.CR2, and adds the .xmp
>>> extension, so the sidecar is image.CR2.xmp.
>>>
>>> The only way I can get grouping to work is to change the sidecar file name
>>> to eliminate the .CR2 bit but this is not a solution since it breaks the
>>> connection in darktable. Trying various things in the sidecar extensions
>>> list does not help
>>>
>>> I don't think I am missing something here, if so a pointer would be
>>> appreciated. If not then it would be very good if this could be fixed
>>
>> Hi
>>
>> I find that if I append ".CR2.xmp" to the sidecars extension list
>> (edit/preferences/preferences/files), then using right click on an image
>> set Disable File Grouping followed by Enable File Grouping -
>>
>> the .CR2.xmp files are then shown as grouped with the image.
>>
>> But this is not working correctly as the grouping is lost on re-start
>> and the file extensions of the sidecar files get corrupted when doing a
>> copy or move.
>>
>> So there is clearly a bug in this part of the code, but if this is
>> corrected it may be that you will get the functionality you are looking for.
>>
>> Colin Clark
>>
> Try changing line 761 of ui_fileops.c from
>
> return strrchr(path, '.');
>
> to
>
> return strchr(path, '.');
>
>
> I have no idea if that's a real solution to the problem - I'll have to
> leave that decision to someone who knows how Geeqie works.
>
>
> Colin Clark
I'm pretty sure that's not actually correct; it'll fail on any file that
contains a period in the middle of the name. The Correct (though
probably a lot more computationally involved) solution is to consider a
file as having some sequence of zero or more extensions, starting at the
right edge of the filename. If you recognize the rightmost N portions
of that sequence, then you can identify the filetype.
In practice, you can find the last segment (with strrchr), and if that's
".xmp" or something, do it again and see if the next segment looks like
a recognizable file extension (".CR2" or somesuch). It seems reasonable
to only support two levels.
--xsdg
--
Benefiting from Server Virtualization: Beyond Initial Workload
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve
application availability and disaster protection. Learn more about boosting
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] zoom to fit
Please keep replies on the list. On 03/08/2011 03:36 PM, Lee Gold wrote: > > Compare a small image with GQView vs. Geeqie. Do zoom to fit and then resize > the window bigger than the image size. With Geeqie it will not go past what > seems to be actual image size. GQView on the other hand will zoom to fit the > window. > > This is based on actual experience doing the above. Try it! Edit->Preferences->Preferences->Image Enable "Allow enlargement of image for zoom to fit." --xsdg > > > > >> - Original Message - >> From: Omari Stephens >> To: geeqie-devel@lists.sourceforge.net >> Cc: Lee Gold >> Subject: Re: [Geeqie-devel] zoom to fit >> Date: Sun, 06 Mar 2011 18:11:18 + >> >> >> On 03/06/2011 05:46 PM, Lee Gold wrote: >>> The zoom to fit still does not work! >> >> Yes it does! >> >> --xsdg >> >> PS: You're going to need to include some more details about what >> you're trying and what happens when you try it for someone to be >> able to help. > >> > > -- What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] zoom to fit
On 03/06/2011 05:46 PM, Lee Gold wrote: > The zoom to fit still does not work! Yes it does! --xsdg PS: You're going to need to include some more details about what you're trying and what happens when you try it for someone to be able to help. -- What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Revisiting file_data_free: assertion failed: (fd->sidecar_files == NULL)
On 03/04/2011 11:04 PM, Michael Schwendt wrote: > Hello everyone! > > This post is related to Geeqie crashing in an assertion in file_data_unref > (see subject line). > > In addition to perusing more of the source code, I've received helpful --debug > output from a bug reporter, who can reproduce the issue with a few attempts, > while I don't manage to reproduce it: > >filedata.c:718: file_data_unref: deleting > '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.JPG', parent > '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.jpg' >** >ERROR:filedata.c:676:file_data_free: assertion failed: (fd->sidecar_files > == NULL) > > This has been encountered during loading images from an SD card. > > As one can see, it added a file (*.JPG) as its own sidecar file (*.jpg), > and file_data_unref cannot cope with that. > > This is because in filedata.c file_data_check_sidecars() > and check_case_insensitive_ext() a case-insensitive fstat is performed > for files with a generated list of potential sidecar file name extensions. > This gives wrong results on a case-insensitive file-system and apparently > adds .jpg as a sidecar file for .JPG. > > layout.c:2204: 0.341570 (+0.033411) layout_new: end > filedata.c:390: file_data_new: > '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.JPG' 1 0 > filedata.c:390: file_data_new: > '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.JPG' 0 0 > filedata.c:655: file_data_ref (2): > '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.JPG' @ filedata.c:398 > filedata.c:428: file_data_pool hit: > '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.JPG' > filedata.c:390: file_data_new: > '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.JPg' 0 0 > filedata.c:390: file_data_new: > '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.JpG' 0 0 > filedata.c:390: file_data_new: > '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.Jpg' 0 0 > filedata.c:390: file_data_new: > '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.jPG' 0 0 > filedata.c:390: file_data_new: > '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.jPg' 0 0 > filedata.c:390: file_data_new: > '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.jpG' 0 0 > filedata.c:390: file_data_new: > '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.jpg' 0 0 > filedata.c:390: file_data_new: > '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.CR2' 0 0 > filedata.c:390: file_data_new: > '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.Cr2' 0 0 > filedata.c:390: file_data_new: > '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.cR2' 0 0 > filedata.c:390: file_data_new: > '/media/EOS_DIGITAL/DCIM/100CANON/IMG_3230.cr2' 0 0 > > As a work-around, I've inserted a file ext comparison directly in > file_data_check_sidecars(), but I could imagine adding another one in > file_data_unref(). > > What do you think? I don't think it's ever legitimate for file foo.jpg to have a sidecar foo.JPG, even on a case-sensitive filesystem. So doing a check in file_data_check_sidecars() sounds reasonable. I wouldn't add extra checks in file_data_unref() unless they are guaranteed to be correct for all filesystems (since it is definitely valid for foo.jpg and foo.JPG to _exist_, and we don't want to end up with memory/resource leaks in that case). --xsdg -- What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Geeqie repositories
Having 10 different repositories doesn't do anyone any good. How about sending an email first so we're all on the same page? Currently, there are geeqie git repositories at: github (started by zas) sourceforge (ported from sourceforge svn by someone; I forget who, but they sent email to the list) gitorious (started by klaus) We should pick a canonical one and stick with it. --xsdg On 02/13/2011 02:28 PM, Klaus Ethgen wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Hello folks, > > as I am not happy with the closed source state of github (see also [1]) > I did also upload geeqie to gitorious[0]. If you have a gitorious > account, please tell me and I add you to the project. > > See also that the gitorious url is much nicer than that on github. ;-) > > To use it, just execute the following commands: > git remote add gitorious git://gitorious.org/geeqie/geeqie.git > git remote update > # optional: > git remote add --push gitorious g...@gitorious.org:geeqie/geeqie.git > > At the moment the master and my branches are pushed. > > Regards > Klaus > > [0] http://gitorious.org/geeqie > [1] http://mako.cc/writing/hill-free_tools.html > - -- > Klaus Ethgenhttp://www.ethgen.ch/ > pub 2048R/D1A4EDE5 2000-02-26 Klaus Ethgen > Fingerprint: D7 67 71 C4 99 A6 D4 FE EA 40 30 57 3C 88 26 2B > -BEGIN PGP SIGNATURE- > Version: GnuPG v1.4.10 (GNU/Linux) > > iQEVAwUBTVfqgJ+OKpjRpO3lAQqtIAgAjoraPzo9kJeMUizV676fe0UgkLjc8X58 > VVqdBml6WDwzwESRVaCC26xSzLXfKoG/GAccKa0hFlNElaqjN/n7qhhcNgA3jHYN > xLN2m1He/EP61Xktaz5jlKGIZnCn9gbHUWvBZgBucjYwaDh7LkqwiXyTYrnfw2j2 > b4fXiGIIJi2Qp974pzPB/UROioLd9VUgPzYjnCIPw2bdZ8m4kGLA6Ejgl17SOc1N > /uis8V9OpX8ALDyTdYhStAtfezOXWdFQiupfsWHI9vLBhY8/r5J6bJhC1lLUL0xT > XeNe9VaEW9FXC0DPlqyuD4CCvhpuaCsxm/xPRBJEQCsi7FUI99r1OA== > =ghQ6 > -END PGP SIGNATURE- > > -- > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > Pinpoint memory and threading errors before they happen. > Find and fix more than 250 security defects in the development cycle. > Locate bottlenecks in serial and parallel code that limit performance. > http://p.sf.net/sfu/intel-dev2devfeb > ___ > Geeqie-devel mailing list > Geeqie-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geeqie-devel -- The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] feature request: RW2 raw files
On 01/29/2011 12:46 PM, Lars Täuber wrote: > Hi there, > > lately i realized that geeqie knows about Canon RAW files. Unfortunately the > RAW files from my Panansonic GH1 are unknown to it. > dcraw and ufraw understand the Panasonic raw format. The files end on .RW2 > and are based on TIFF like most raw formats. > Is it easy to add support for this raw format to geeqie? In most cases, all that's needed is to add a mapping for geeqie to recognize this extension as being a TIFF file. You can do that from the Preferences->Files screen. > Is it possible to support (EXIF, IPTC or XMP?) keywords for this RW2 file too? I'm 90% sure the ability to store this metadata is inherent in the TIFF container format. --xsdg -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] geeqie & db integration
On 01/20/2011 08:33 AM, Zeus V Panchenko wrote: > Omari Stephens (x...@csail.mit.edu) [11.01.20 10:17] wrote: >> >> There was definitely discussion about using a database for image >> metadata. > > really not only image metadata but anything related to image, for > example commercial history (for stock sells) e.t.c. That still counts as metadata. Basically, it would potentially include anything that can be stored in EXIF or XMP. Of course, there are some forms of metadata (like large thumbnails) which might not make sense to store directly in the DB. >> That said, given that Lightroom uses sqlite, it at least demonstrates >> that sqlite is a feasible solution for this type of problem (although > > i actively use darktable.sourceforge.net (the best raw processor for > xNIX) project and they use sqlite too and to be hones, now it is too > difficult to implement something different in UI than what was planned > and allowed at the project start If the schema isn't designed to be flexible, that may definitely be a concern. On the other hand, if a schema is _too_ flexible, you end up with very few guarantees about the nature of the data that's stored in the DB, and you can end up spending a lot of CPU validating the data as you access it. It can be a tricky balancing act. > and again, can it be considered applicable to place db integration > into todo list? :) Sounds good to me. zas or Klaus may have access to the wiki; I don't think I do. --xsdg -- Protect Your Site and Customers from Malware Attacks Learn about various malware tactics and how to avoid them. Understand malware threats, the impact they can have on your business, and how you can protect your company and customers by using code signing. http://p.sf.net/sfu/oracle-sfdevnl ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] geeqie & db integration
On 01/20/2011 08:09 AM, Zeus V Panchenko wrote: > Hi all, > > i'm new fan of geeqie. Before discovering geeqie i was using gqview > for a several years. > > i was testing all monster-not-depen graphics viwers in FreeBSD ports > collection and geeqie is the best featured for my workflow. > > while reading wiki i didn't find any entry in wish list for any db > intgration and wanna ask: > > can it be considered to integrate geeqie to some db? > > > many projects today are using sqlite for example, though to my mind, > nosql approach could be more natural, since image data represent > `document' structure and such integration could broaden much possible > features of the cataloging tasks. > > > what do you think? There was definitely discussion about using a database for image metadata. It's all stuff that got lost after the whole 1.0 release debacle, however. The choice of database should have a lot to do with how the data will be accessed and used. The non-relational options are good for scalability, but they tend to have very weak query languages, which can severely limit the utility of the datastore. On the other hand, SQL is a very powerful query language, but SQL-based solutions may have scalability issues. That said, given that Lightroom uses sqlite, it at least demonstrates that sqlite is a feasible solution for this type of problem (although it's not obvious what kind of optimizations they had to do to keep performance up to par). --xsdg -- Protect Your Site and Customers from Malware Attacks Learn about various malware tactics and how to avoid them. Understand malware threats, the impact they can have on your business, and how you can protect your company and customers by using code signing. http://p.sf.net/sfu/oracle-sfdevnl ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Keyword handling
On 01/14/2011 02:37 AM, Daniel Skorka (by way of Daniel Skorka ) wrote: > Hello list, > > I'm using geeqie 1.0 and have run into a problem. I used geeqie to tag > a bunch of images with my own keywords, that were saved to XMP info > inside the file. Saved and quit, so far everything's fine, when I load > up geeqie again, the keywords are in the file, but they are no longer > in the list of possible keywords, and I can't figure out how import > them from the images. > I've seen that I can add them in ~/.config/geeqie/geeqie.rc, but I'd > rather avoid putting a few dozen of them in there by hand, and I also > don't want to have to remember to do this everytime I add a new keyword. > Isn't there some way to do this from within geeqie? It's been awhile since I used 1.0. That said, I don't think this has changed since 1.0: On the Keywords list in the Info sidebar (Ctrl+K), you've got a right pane and a left pane. The left pane is pretty much free-form. You can (permanently) add keywords to the right pane by right-clicking and choosing "Add keyword". This basically adds them to the config file, but is a lot more straightforward to do when you're actually in geeqie. The right pane also allows you to tag an image with a keyboard just by clicking the checkbox. --xsdg -- Protect Your Site and Customers from Malware Attacks Learn about various malware tactics and how to avoid them. Understand malware threats, the impact they can have on your business, and how you can protect your company and customers by using code signing. http://p.sf.net/sfu/oracle-sfdevnl ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] [PATCH] optionally autorotate proofs
On 12/13/2010 01:31 AM, Jonathan Woithe wrote: >>> Around April 2010 I submitted a diff to the ML which adds auto-rotation to >>> proofs ... >> >> I already did, check >> https://github.com/zas/geeqie_zas/commit/c4e3c3ee6f8b80c43925b0d38b8bcfae71050c6a >> If the patch is the same, we are done. Thanks for the patch > > Yep, that's the patch. There have been no changes. > > I was confused because I went to > >https://github.com/zas/geeqie_zas > > hit the "history" button and saw no evidence of the commit in the resulting > list. What did I do wrong? By default, it shows the commit history of the master branch — you can see that in the "Switch branches" dropdown in the top-left. zas committed your patch in the devel branch, which (now that I check) seems to have been renamed "lm". --xsdg -- Oracle to DB2 Conversion Guide: Learn learn about native support for PL/SQL, new data types, scalar functions, improved concurrency, built-in packages, OCI, SQL*Plus, data movement tools, best practices and more. http://p.sf.net/sfu/oracle-sfdev2dev ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Geeqie developemant stopped?
On 12/11/2010 05:53 PM, Laurent Monin wrote: > Милош Поповић a écrit : >> 1. I can see that last commit to SourceForge SVN was in May 2010. Are >> you giving up with Geeqie? >> >> 2. Can you implement writing XMP to RAW files? As far as I know it can >> be done with ExifTools >> >> 3. Can Geeqie list photos from some directory recursively? I can see >> that option for slideshow. >> >> >> >> > > Since Vladimir, Petr or I are too busy to work on Geeqie, i converted > geeqie current > subversion repository to Git, and put it on github : > > https://github.com/zas/geeqie_zas > > I quickly committed patches from mailing list to it (3). > I don't have much time to work on it, but i'll try to commit submitted > patches if any. Cool. Could you give me commit access? I'm https://github.com/xsdg/ --xsdg -- Oracle to DB2 Conversion Guide: Learn learn about native support for PL/SQL, new data types, scalar functions, improved concurrency, built-in packages, OCI, SQL*Plus, data movement tools, best practices and more. http://p.sf.net/sfu/oracle-sfdev2dev ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Issue/Error with move/delete files (Ubuntu 10.10, Geeqie 1.0)
On 11/18/2010 12:02 PM, Callan Jefferson Davies wrote:
>>> - If I delete file, a copy DOES appear in /home/callan/geeqie_trash
>>> - But the file on my NAS is not removed - I get an error 'external
>>> editor returned error status - file delete failed'
> >
>> Is this the exact error message you get? Is it not "File deletion
>> failed"?
>
>
>
> Hi there,
>
> Yes I'm sorry, the error is as you've mentioned...
>
> FILE DELETION FAILED
> External editor returned error status.
> File deletion failed
> /media/shared/PhotoAlbum/2010-11-06/20101109-142129.366.JPG
>
>
> Just to confirm also, that - 00_20101109-142129.366.JPG - did appear
> in /home/callan/geeqie_trash/
>
> I'm not sure how helpful it'll be, but I've attached a copy of the
> terminal output when using geeqie --debug.
The debug output was useful; thanks
That said, I am not able to trivially reproduce this. Here's my test setup:
$ls -la mygroup/
total 652
drwxrwx--- 2 root xsdg 4096 Nov 23 10:15 ./
drwxr-xr-x 5 xsdg xsdg 4096 Nov 23 10:12 ../
-rw-rw 1 root xsdg 160762 Apr 22 2010 300_3293.jpg
-rw-rw 1 root xsdg 259218 Apr 22 2010 300_4212.jpg
-rw-rw 1 root xsdg 232682 Apr 22 2010 300_4236.jpg
And the files are successfully deleted from the directory
$ls -la ~/geeqie_trash/
total 608
drwxr-xr-x 2 xsdg xsdg 4096 Nov 23 10:15 ./
drwxr-xr-x 14 xsdg xsdg 4096 Nov 23 10:14 ../
-rw-r--r-- 1 xsdg xsdg 354195 Apr 5 2010 00_300_2704.jpg
-rw-rw 1 root xsdg 254442 Apr 22 2010 01_300_3265.jpg
Could you do something similar to my setup, where you have a directory
and files owned by root/BOGGLERS, but living in your homedir? After
that, could you try setting your safe delete location on the SAMBA share
somewhere? I'm just curious whether or not those situations cause the
problem to show up or not.
Also, could you do an `ls -la` on your geeqie_trash directory? I'm
curious what permissions the deleted files have (and, more specifically,
if they're owned by root or not).
Oh, what version of GNU mv do you have? (`mv --version`)
And lastly, could you do a move by hand (on the cmdline) and check the
return value?
mv /media/shared/PhotoAlbum/2010-11-06/20101109-142129.366.JPG
~/geeqie_trash; echo "return value is $?"
My current guess is that a mv implementation somewhere is failing to do
a cross-filesystem move since it won't be able to chown the file to
root, and geeqie is noticing. For instance, by running GNU `mv` under
strace, you can see it try a move, fail, and fall-back to a
copy/chmod/chown pattern:
rename("300__4212.jpg", "/var/tmp/xsdg/300_4212.jpg") = -1 EXDEV
(Invalid cross-device link)
open("/var/tmp/xsdg/300_4212.jpg", O_WRONLY|O_CREAT|O_EXCL, 0600) = 4
[it copies some bytes]
fchown(4, 0, 1000) = -1 EPERM (Operation not permitted)
fchown(4, 4294967295, 1000) = 0
fchmod(4, 0100660) = 0
If geeqie switched to using an internal version of mv, instead of
shelling out, I could see it causing this. (I don't actually know if
this is the case)
Thanks,
--xsdg
--
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Geeqie editor checking write permission unnecessarily
On 11/18/2010 09:03 PM, Jared Henley wrote: > Hi, > > I have a use case where geeqie's checking for > write permissions on a directory is unnecessary and annoying. The behavior does sound like a bug. As it happens, there was a likely-related issue reported a couple days ago. That said, could you run geeqie in debug mode (`geeqie --debug` from the cmdline) and attach the log, please? That should make it easier to figure out what's going on. --xsdg -- Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Issue/Error with move/delete files (Ubuntu 10.10, Geeqie 1.0)
On 11/16/2010 11:30 AM, Callan Jefferson Davies wrote: ::snip? SNIP!:: >- An example file would be : > > -rwxrwx--- 1 root bogglers 4.1M 2010-11-12 21:54 20101109-142128.JPG > >- If I delete file, a copy DOES appear in /home/callan/geeqie_trash >- But the file on my NAS is not removed - I get an error 'external > editor returned error status - file delete failed' Is this the exact error message you get? Is it not "File deletion failed"? --xsdg -- Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today http://p.sf.net/sfu/msIE9-sfdev2dev ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Geeqie developemant stopped?
On 09/07/2010 01:14 AM, Милош Поповић wrote: > 1. I can see that last commit to SourceForge SVN was in May 2010. Are > you giving up with Geeqie? Dev on geeqie does seem to have stalled again. I haven't seen zas, Vladimir, or Klaus around the list in a long while. That said, I suspect that development will march on, whether the committers return, or hand over the reigns to someone else, or if (like geeqie) someone ends up having to fork the codebase. I know that a couple different folks (myself included) all have various patches waiting in the wings, and at some point, they're going to land somewhere :o) --xsdg -- This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010. http://p.sf.net/sfu/intel-thread-sfd ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Feature request: Toggle viewing button
On 08/16/2010 02:35 AM, Jeffery Small wrote: > > One thing that I would find to be a very useful addition to geeqie would be > a button that would toggle between the current picture and the last picture > viewed. If you select multiple images, when you cycle (by pressing spacebar/backspace, clicking, or using your mouse's scroll wheel), it will cycle through only the selected images. --xsdg -- This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] bug in CMS?
On 05/26/2010 10:51 PM, Bartosz SKOWRON wrote: > hi guys, > > i've just bought a new LCD (EIZO S2433W) with pretty wide gamut. I use > gnome-color-manager to set the profile for the LCD. In Geeqie's > preferences I have turn on 'Use system screen profile if available' > and in the menu View -> Color Management -> use color profiles and > use profile from image. > > So there are 2 problems. First one, when there is no ICC profile > embedded in an image (e.g. PNG files I believe). The color of images PNG files support embedded color profiles, though a smaller proportion of them of them have one, compared to JPEGs > is compltely bad. In shortcut it looks like the saturation was > completely down. Please see the screenshot: > http://img265.imageshack.us/img265/6493/zrzutekranu5g.png > When I turn off 'use color profiles' it looks OK. > Funny thing is with taking screenshots of Geeqie with this problem. > Another screenshot of the screenshot is with lower and lower > saturation. "Lack of saturation" sounds like you're viewing an AdobeRGB image without using the AdobeRGB profile. If so, there's not really anything geeqie can do. In the View->Color Management menu, you can force geeqie to interpret the photo as if it were AdobeRGB, but the real answer is "images without embedded profiles should be sRGB, or you should expect pain and know how to deal with it." The other big possibility is that this is some interaction problem between X11 and OS X. Not having used the two together for anything color-centric, I have no idea what the story is there. > The second problem is with files with embedded profiles. They look OK, > however if I compare it to Firefox or VirtualBox, there are some > slightly differences between Geeqie and others. I checked it with > Color Sampler as well. Screenshot below: Firefox's color rendering is not accurate, period. For one thing, IME, it consistently renders photos-with-embedded-profiles with a noticeably high blackpoint. You should compare with an app whose only purpose is to display images, like GIMP. It would probably also be useful to compare both geeqie and firefox to an OS X-native app like Photoshop that is guaranteed to treat color profiles correctly and display images accurately. I don't know how much I'd trust Preview or Safari. --xsdg -- ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] [PATCH] exif autorotate for proofs
Only a minor nitpick from me: I don't think you actually need the
"rotated" temporary variable. Regardless, looks good to my eyes (of
course, I have no say over what gets included or not :o)
--xsdg
On 04/02/2010 11:17 AM, Jonathan Woithe wrote:
> Hi
>
> Find below a patch which adds auto-rotation of proof images based on image
> EXIF information. It is a revision of a proof-of-concept patch I did up for
> gqview 2.0.4 which, for well documented reasons, didn't get anywhere after
> submission. The patch below is against geeqie 1.0.
>
> The proof auto-rotation feature is controlled by a new setting in the
> "convenience" section of the image preferences dialog. This way the
> existing behaviour is still available for those who want to use it.
>
> I find this new feature very useful when preparing proofing sheets and I
> suspect others would too. Please consider this for inclusion in geeqie.
>
> Regards
>jonathan
>
> diff -ru --unidirectional-new-file geeqie-1.0-orig/src/options.c
> geeqie-1.0/src/options.c
> --- geeqie-1.0-orig/src/options.c 2010-02-18 07:51:19.0 +1030
> +++ geeqie-1.0/src/options.c 2010-04-02 20:36:46.448672632 +1030
> @@ -66,6 +66,7 @@
> options->image.dither_quality = GDK_RGB_DITHER_NORMAL;
> options->image.enable_read_ahead = TRUE;
> options->image.exif_rotate_enable = TRUE;
> + options->image.exif_proof_rotate_enable = TRUE;
> options->image.fit_window_to_image = FALSE;
> options->image.limit_autofit_size = FALSE;
> options->image.limit_window_size = TRUE;
> diff -ru --unidirectional-new-file geeqie-1.0-orig/src/options.h
> geeqie-1.0/src/options.h
> --- geeqie-1.0-orig/src/options.h 2010-02-18 07:51:19.0 +1030
> +++ geeqie-1.0/src/options.h 2010-04-02 20:36:17.742672675 +1030
> @@ -50,6 +50,7 @@
> /* image */
> struct {
> gboolean exif_rotate_enable;
> + gboolean exif_proof_rotate_enable;
> guint scroll_reset_method;
> gboolean fit_window_to_image;
> gboolean limit_window_size;
> diff -ru --unidirectional-new-file geeqie-1.0-orig/src/preferences.c
> geeqie-1.0/src/preferences.c
> --- geeqie-1.0-orig/src/preferences.c 2010-02-18 07:51:19.0 +1030
> +++ geeqie-1.0/src/preferences.c 2010-04-02 20:41:25.949672731 +1030
> @@ -285,6 +285,7 @@
>
> options->update_on_time_change = c_options->update_on_time_change;
> options->image.exif_rotate_enable = c_options->image.exif_rotate_enable;
> + options->image.exif_proof_rotate_enable =
> c_options->image.exif_proof_rotate_enable;
>
> options->duplicates_similarity_threshold =
> c_options->duplicates_similarity_threshold;
>
> @@ -1309,6 +1310,9 @@
>
> pref_checkbox_new_int(group, _("Auto rotate image using Exif
> information"),
>
> options->image.exif_rotate_enable,&c_options->image.exif_rotate_enable);
> +
> + pref_checkbox_new_int(group, _("Auto rotate proofs using Exif
> information"),
> +
> options->image.exif_proof_rotate_enable,&c_options->image.exif_proof_rotate_enable);
> }
>
> /* windows tab */
> diff -ru --unidirectional-new-file geeqie-1.0-orig/src/print.c
> geeqie-1.0/src/print.c
> --- geeqie-1.0-orig/src/print.c 2010-02-18 07:51:19.0 +1030
> +++ geeqie-1.0/src/print.c2010-04-02 20:48:31.690672852 +1030
> @@ -2189,6 +2189,7 @@
> gdouble icon_w, icon_h;
> gdouble scale;
> gboolean success = TRUE;
> + GdkPixbuf *rotated = NULL;
>
> if (pw->proof_columns< 1 || pw->proof_rows< 1)
> {
> @@ -2202,6 +2203,11 @@
>
> pixbuf = image_loader_get_pixbuf(il);
>
> + if (options->image.exif_proof_rotate_enable == TRUE) {
> + rotated = pixbuf_apply_orientation(pixbuf,
> il->fd->exif_orientation);
> + pixbuf = rotated;
> + }
> +
> w = gdk_pixbuf_get_width(pixbuf);
> h = gdk_pixbuf_get_height(pixbuf);
>
>
>
> --
> Download Intel® Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> ___
> Geeqie-devel mailing list
> Geeqie-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geeqie-devel
--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforg
[Geeqie-devel] 1.0?
It is now February. Geeqie has had no substantive feature checkins in 3 months. Please, please tag _something_ as 1.0 and kick it out the door so we can move on. Please. Seriously. --xsdg -- The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Segfault on trying to view image
On 01/29/2010 01:31 PM, Alex Dedul wrote: > By the way, just noticed it writes this on the console > > pl...@plisk ~/dl/DC $ geeqie thefun.ru-britni-9-15.jpg > warning: exif tag Exif.Photo.ExifVersion has 0 elements, exif spec requests 4 > exif tag Exif.Photo.ExifVersion data size mismatch > warning: exif tag Exif.Photo.FlashpixVersion has 0 elements, exif spec > requests 4 > exif tag Exif.Photo.FlashpixVersion data size mismatch > warning: exif tag Exif.Photo.ColorSpace has 0 elements, exif spec requests 1 > exif tag Exif.Photo.ColorSpace data size mismatch > exif tag unknown data size mismatch > Segmentation fault What happens if you just run `exiv2 foo.jpg`? What version of libexiv2 do you have? --xsdg -- The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Segfault on trying to view image
[cc+ zas] --xsdg On 01/29/2010 01:54 AM, Alex Dedul wrote: > Hi there! > > Hm, i was trying to do this bug report in bug tracker [1], but there > it was just deleted without explanations, so i'd like to discuss this > here then. > > I just downloaded this image [2] and here geeqie just segfaults when > i'm trying to view it, while other image viewers show it okay. I'm > using the latest svn to date and i'm on gentoo 64 bit. > > I know this is a porn image, so what ? Geeqie segfaults on it, this is > what matters. This is a valid bug report if you look to the real issue > with geeqie, not to the pic itself (by the way - nothing wrong with it > too). > > Also i tried to recompile with -O0 - also segfaults, just to test this. > > [1] > https://sourceforge.net/tracker/?func=detail&aid=2941915&group_id=222125&atid=1054680 > [2] http://narod.ru/disk/17376593000/thefun.ru-britni-9-15.jpg.html > > With best regards from the Soul, Alex. > > -- > The Planet: dedicated and managed hosting, cloud storage, colocation > Stay online with enterprise data centers and the best network in the business > Choose flexible plans and management services without long-term contracts > Personal 24x7 support from experience hosting pros just a phone call away. > http://p.sf.net/sfu/theplanet-com > ___ > Geeqie-devel mailing list > Geeqie-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geeqie-devel -- The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] svn -> git
On 01/16/2010 10:24 AM, Klaus Ethgen wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Hi, > > I think about the last break in into berlios. Principle that could also > happens to sourceforge. > > With a subversion repository all our work could be compromised and we > are not able to see it. Git would be a way to get around such a > compromising. > > So, what do you think about converting the project to git before > releasing the 1.0 version? That should be not that big problem at all > and some of us still work with git as frontend to svn. I would suggest that we stay focused on getting 1.0 out the door and leave the switch for afterward. There's a lot of git-related learning to be done, and given how long this has taken already, we're probably better off leaving whatever unexpected issues may come up for after the release. --xsdg -- Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
[Geeqie-devel] We need to release 1.0 before the end of January
Unfortunately, for whatever different reasons, we're having a lot of trouble pulling things together. Regardless of what the reasons are, we can't let this continue to kill the development momentum that geeqie's been building over the past many months. Consider that in June of 2009, there were 68 commits made to the geeqie repository. This has dropped to just 6 in November and 7 in December. Basically, we're dead in the water. That said, we need to get 1.0 out the door. Despite having a lot of incomplete translations and documentation, we've still done a ton of work that other folks should have access to. There's more work to be done, undoubtedly, but what's there now is still pretty good and very usable. Maybe 1.0 won't be quite as awesome as we'd hope, but there is life after 1.0 — right now, we need the opportunity to keep developing and keep improving things, rather than sitting in a never-ending release freeze. We need to be able to accept contributions of code before the contributors get frustrated and move on to other things. In short, I would strongly suggest that we set a 1.0 release date sometime in January, preferably early rather than late January, and stick to it. It might not be the quality of release we were hoping for, but at this point, it's more important to be able to continue moving forward than to try to make this release perfect, which will never happen. --xsdg -- This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Reduce size of thumbnail files
On 12/26/2009 10:07 PM, Wojciech Muła wrote: > Hi all! > > Single thumbnail file is quite small, but when we have bunch of them > it could be a problem; recently I discovered, that size of my > .thumbnails directory was 2GB. > > I've tested very simple method to reduce size of thumb pngs - before > save a file, n lower bits of each pixel component is reset. Of course > this cause lost of some information, but thumbnails are just... > thumbnails, and I think it is not problem for anyone. My quick tests > with patched geeqie show significant reduction of size: > for n=3 - 20-30% less, for n=4 - 40-50%. Is this really worth it? For one, this runs the risk of destroying a significant amount of the image content for images that are fairly dark. Beyond that, though, the difference between a 1GB and a 2GB .thumbnails directory is pretty small, in practice. If the size of the directory is an issue, the answer is probably to do something that will maintain some certain maximum directory size, rather than hurting the quality of each and every thumbnail with no practical way to prevent the .thumbnails directory size from continuing to grow. Finally, I imagine the thumbnail storage paradigm will probably change once folks start moving geeqie over to a database backend. --xsdg -- This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Rate your images using geeqie!
Howdy, all
The attached (incremental) patch adds search support for Ratings. You
can search for images with ratings less than, equal to, or greater than
a specific value; images with ratings in a specified range, or images
without ratings.
Full patch:
http://ocaml.xvm.mit.edu/~xsdg/stuff/geeqie/ratings/ratings.v5.full.patch.txt
Cheers,
--xsdg
commit c49f2751dd0aac4f5c90e5399178ff84e7cfccca
Author: Omari Stephens
Date: Sat Nov 21 20:32:19 2009 +
Add support for searching for Ratings
diff --git a/trunk/src/bar_rating.c b/trunk/src/bar_rating.c
index 80b972c..0898183 100644
--- a/trunk/src/bar_rating.c
+++ b/trunk/src/bar_rating.c
@@ -310,7 +310,8 @@ static GtkWidget *bar_pane_rating_new(const gchar *id,
const gchar *title, const
// SPIN BUTTON
- prd->spinbutton = (GtkSpinButton*) gtk_spin_button_new_with_range(0.0,
10.0, 1.0);
+ prd->spinbutton = (GtkSpinButton*)
gtk_spin_button_new_with_range((gdouble) MIN_RATING,
+ (gdouble) MAX_RATING, 1.0);
gtk_spin_button_set_numeric(prd->spinbutton, TRUE);
gtk_spin_button_set_snap_to_ticks(prd->spinbutton, TRUE);
diff --git a/trunk/src/bar_rating.h b/trunk/src/bar_rating.h
index 7453a4c..1862159 100644
--- a/trunk/src/bar_rating.h
+++ b/trunk/src/bar_rating.h
@@ -22,6 +22,9 @@ void bar_pane_rating_inc_value(gpointer data);
void bar_pane_rating_dec_value(gpointer data);
void bar_pane_rating_set_value(gint value, gpointer data);
+#define MIN_RATING 0
+#define MAX_RATING 10
+
#endif
/* vim: set shiftwidth=8 softtabstop=0 cindent cinoptions={1s: */
diff --git a/trunk/src/filedata.c b/trunk/src/filedata.c
index 43dc828..97e5ff9 100644
--- a/trunk/src/filedata.c
+++ b/trunk/src/filedata.c
@@ -230,6 +230,9 @@ static void file_data_set_collate_keys(FileData *fd)
g_free(fd->collate_key_name);
g_free(fd->collate_key_name_nocase);
+ g_free(fd->metadata_collate_key);
+ fd->metadata_collate_key = NULL;
+
#if GLIB_CHECK_VERSION(2, 8, 0)
fd->collate_key_name = g_utf8_collate_key_for_filename(fd->name, -1);
fd->collate_key_name_nocase =
g_utf8_collate_key_for_filename(caseless_name, -1);
diff --git a/trunk/src/search.c b/trunk/src/search.c
index 451e091..f99687b 100644
--- a/trunk/src/search.c
+++ b/trunk/src/search.c
@@ -40,6 +40,7 @@
#include "utilops.h"
#include "window.h"
#include "bar_keywords.h"
+#include "bar_rating.h"
#include /* for keyboard values */
@@ -122,6 +123,11 @@ struct _SearchData
GtkWidget *spin_similarity;
GtkWidget *entry_similarity;
+ GtkWidget *check_rating;
+ GtkWidget *menu_rating;
+ GtkWidget *spin_rating;
+ GtkWidget *spin_rating_end;
+
GtkWidget *check_keywords;
GtkWidget *menu_keywords;
GtkWidget *entry_keywords;
@@ -136,6 +142,8 @@ struct _SearchData
gboolean search_name_match_case;
gint64 search_size;
gint64 search_size_end;
+ guint64 search_rating;
+ guint64 search_rating_end;
gint search_date_y;
gint search_date_m;
gint search_date_d;
@@ -159,6 +167,7 @@ struct _SearchData
MatchType match_size;
MatchType match_date;
MatchType match_dimensions;
+ MatchType match_rating;
MatchType match_keywords;
MatchType match_comment;
@@ -167,6 +176,7 @@ struct _SearchData
gboolean match_date_enable;
gboolean match_dimensions_enable;
gboolean match_similarity_enable;
+ gboolean match_rating_enable;
gboolean match_keywords_enable;
gboolean match_comment_enable;
@@ -233,6 +243,14 @@ static const MatchList text_search_menu_date[] = {
{ N_("between"),SEARCH_MATCH_BETWEEN }
};
+static const MatchList text_search_menu_rating[] = {
+ { N_("equal to"), SEARCH_MATCH_EQUAL },
+ { N_("less than"), SEARCH_MATCH_UNDER },
+ { N_("greater than"), SEARCH_MATCH_OVER },
+ { N_("between"),SEARCH_MATCH_BETWEEN },
+ { N_("unset"), SEARCH_MATCH_NONE },
+};
+
static const MatchList text_search_menu_keyword[] = {
{ N_("match all"), SEARCH_MATCH_ALL },
{ N_("match any"), SEARCH_MATCH_ANY },
@@ -1799,6 +1817,36 @@ static gboolean search_file_next(SearchData *sd)
}
}
+ if (match && sd->match_rating_enable)
+ {
+ tested = TRUE;
+ match = FALSE;
+ guint64 rating = metadata_read_int(fd, RATING_KEY, (guint64)
-1);
+
+ if (rating == (guint64) -1)
+ {
+ /* Files without a rating only match if we're actively
looking for them */
+ match = (sd->match_rating == SEAR
[Geeqie-devel] Rate your images using geeqie!
Howdy, everybody
This feature is still under development and still has some rough edges, but it's
finally gotten to the point where I think it'll be a big help to anyone dealing
with a lot of images.
### What it does so far:
- Reads/updates/creates the 'xap:Rating' tag, where most if not all image
viewers store image ratings (LightRoom, Adobe Bridge, etc.)
- Has an "auto-advance" feature; if it's checked, you'll automatically advance
to the next image after changing the Rating for the current image.
- Supports keyboard accelerators with defaults for increment, decrement, and
rate 0–10
This means that you'll be able to go through and rate a directory of photos
without taking your hands off of the number-pad. If you change your mind on
one, just use normal navigation (backspace/space) to go back, and then go back
to hitting numbers.
### How to get it:
1) Compile geeqie with the attached patch
2) Hit Ctrl+k to bring up the metadata bar, if you don't have it open already
3) Right-click on the metadata bar, and select "Rating" from the pop-up menu to
add it.
4) Profit.
5) ???
### How to use it:
Increment the rating:
- Press the "Inc. " button
- Hit the spinbutton "+" button
- Hit the Increment accelerator, Alt+(KP+) by default
Decrement the rating:
- Press the "Dec." button; twiddle the spinbutton; Alt+(KP-)
Set the rating arbitrarily:
- Spin the spinbutton with your scroll-wheel
- Type a number in the box
- Use one of the numeric accels: Alt+(KP0) up to Alt+(KP9), or Alt+(KP.) for 10
Auto-advance:
- When checked, any change of the rating will automatically advance you to the
next image. This includes one spin if you use your scroll-wheel with the
spin-button.
### To change the keyboard accelerators:
a) Go to Edit->Preferences->Preferences to bring up the Prefs dialog
b) Switch to the "Keyboard" tab
c) Look for the "Increment Rating" and "Decrement Rating" entries.
d) Click the empty box in the "KEY" column for that row and then type the
shortcut you want
### What's missing right now:
- Non-ugly UI
- Ability to sort by rating
- Ability to remove the rating from an image
Let me know what you like, what you don't like, and what you'd like to change.
Full patch:
http://ocaml.xvm.mit.edu/~xsdg/stuff/geeqie/ratings/ratings.v4.full.patch.txt
Incremental patches:
http://ocaml.xvm.mit.edu/~xsdg/stuff/geeqie/ratings/ratings.v1.patch.txt
http://ocaml.xvm.mit.edu/~xsdg/stuff/geeqie/ratings/ratings.v2.inc.patch.txt
http://ocaml.xvm.mit.edu/~xsdg/stuff/geeqie/ratings/ratings.v3.inc.patch.txt
http://ocaml.xvm.mit.edu/~xsdg/stuff/geeqie/ratings/ratings.v4.inc.patch.txt
--xsdg
diff --git a/trunk/src/Makefile.am b/trunk/src/Makefile.am
index 144b090..9528d30 100644
--- a/trunk/src/Makefile.am
+++ b/trunk/src/Makefile.am
@@ -94,6 +94,8 @@ geeqie_SOURCES = \
bar_keywords.h \
bar_exif.c \
bar_exif.h \
+ bar_rating.c \
+ bar_rating.h \
bar_sort.c \
bar_sort.h \
cache.c \
diff --git a/trunk/src/bar.c b/trunk/src/bar.c
index 52d6a54..4d64b71 100644
--- a/trunk/src/bar.c
+++ b/trunk/src/bar.c
@@ -25,6 +25,7 @@
#include "ui_menu.h"
#include "bar_comment.h"
#include "bar_keywords.h"
+#include "bar_rating.h"
#include "bar_exif.h"
#include "bar_histogram.h"
#include "histogram.h"
@@ -76,6 +77,15 @@ static const gchar default_config_comment[] =
""
"";
+static const gchar default_config_rating[] =
+""
+""
+""
+""
+""
+""
+"";
+
static const gchar default_config_exif[] =
""
""
@@ -178,6 +188,7 @@ static const KnownPanes known_panes[] = {
{PANE_GPS, "gps", N_("GPS Map"), default_config_gps},
#endif
#endif
+ {PANE_RATING, "rating", N_("Rating"), default_config_rating},
{PANE_UNDEF, NULL, NULL, NULL}
};
diff --git a/trunk/src/bar.h b/trunk/src/bar.h
index 61dc4be..d24acf3 100644
--- a/trunk/src/bar.h
+++ b/trunk/src/bar.h
@@ -20,7 +20,8 @@ typedef enum {
PANE_EXIF,
PANE_HISTOGRAM,
PANE_KEYWORDS,
- PANE_GPS
+ PANE_GPS,
+ PANE_RATING
} PaneType;
typedef struct _PaneData PaneData;
diff --git a/trunk/src/bar_rating.c b/trunk/src/bar_rating.c
new file mode 100644
index 000..80b972c
--- /dev/null
+++ b/trunk/src/bar_rating.c
@@ -0,0 +1,400 @@
+/*
+ * Geeqie
+ * (C) 2004 John Ellis
+ * Copyright (C) 2008 - 2009 The Geeqie Team
+ *
+ * Author: Omari Stephens
+ *
+ * This software is released under the GNU General Public License (GNU GPL).
+ * Please read the included file COPYING for more information.
+ * This software comes with no warranty of any kind, use at your own risk!
+ */
+
+
+#include "main.h&
Re: [Geeqie-devel] Evidence based photo selection
Slowly chugging along. This patch includes "Increment"/"Decrement" buttons, and preliminary auto-advance (so when you click one of the buttons, it automatically advances to the next image). I'm halfway done with adding keyboard shortcut support; that'll probably be done before I go to sleep, but pretty late tonight. The magic of the keyboard shortcuts menu means you'll be able to choose to steal whatever shortcuts you want (yay). Incremental patch (against the v1 patch): http://ocaml.xvm.mit.edu/~xsdg/stuff/geeqie/ratings/ratings.v2.inc.patch.txt Full patch: http://ocaml.xvm.mit.edu/~xsdg/stuff/geeqie/ratings/ratings.v2.full.patch.txt --xsdg -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Next development steps
Vladimir Nadvornik wrote: ::snip? SNIP!:: >> Yes, i agree, 1.0 should be released. What is missing for that ? >> > I thought we could improve the documentation first, but I agree that it is > not > a showstopper. > > I have also mostly implemented a script for converting the wiki to docbook > and > html, it just needs some integration with makefiles. I will try to look into > it on the weekend. Would it be possible for the wiki to at least be visible for people without SF.net accounts? I think the current state, where you need an SF.net account just to _look_ at the wiki, is fairly detrimental to our ability to get help with documentation. It's certainly deterred me for the past month or few. --xsdg -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Saving marks
Peter Falter wrote: > It seems that Marks are not saved when geeqie is quitted and switched > on again, right? > > This is an odd behavior, i recognized after marking around 180 > pictures in a folder with over 750 pics... > > Despite this not so nice "feature" of 1.0beta2 i like geeqie very much. I no longer feel that saving marks is a useful feature. You can connect marks to keywords: right-click a keyword, then select "Connect 'keyword' to Mark". This means that instead of potentially having a bunch of marks of unknown meaning, you instead have arbitrary keywords which, if you like, you can name 1, 2, 3, 4, 5, 6. Also, the ratings work that I'm in the middle of will hopefully ease the need to use marks as some form of rating. While it'd be nice to not _lose_ marks, I think there are better ways to do that than to actually save the numbers. Something like "Save Mark 1 as keyword Foo", perhaps. --xsdg -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Evidence based photo selection
The first stage of this is done. Patch attached. More comments inline and
below.
Omari Stephens wrote:
Noah Slater wrote:
Hello,
I use Geeqie to select photographs from very large collections, such as the
thousands I might take on a shoot. As it stands, run through the photographs in
a directory, deleting the ones that I don't think should make it to the next
stage of the selection process. I usually do this a number of times, using
different directories, until I have a small handful that I like.
Because I the selection process is subjective, I add safety measures such as
copying the photographs to a new directory for each run, or running through a
copy of the same directory twice so that I can merge the selection pools of two
identical runs. This is a tedious process, and prone to errors.
I would like to suggest the following features:
* A scorecard for each photo that can be incremented or decremented using
keyboard shortcuts. Two obvious shortcuts would be "-" and "=". After
pressing a key, a notification area could display the score.
I am working on this. My plan for right now is to implement it as a simple hack
on top of the keywords system. I could use a keyword "score:6" for storage, and
then it'd just need buttons with keyboard mappings for incrementing or
decrementing the score.
I ended up doing this the Right Way and using the XMP xap:Rating tag. If you've
got photos that you added ratings to with other programs (Lightroom, Bridge,
etc.) you should see them. Changes you make should show up in those programs
(for now; more below).
* A way of sorting on the list of photographs by score.
As Vlad suggested, this will be more difficult to do properly. It might be
possible to come up with a nice hack that works well; we'll see. I haven't yet
poked at the sorting code.
I still haven't looked at this yet. Worst comes to worst, I'm just going to
write a cache of some sort.
Next steps, in approximate order:
1) Add buttons and keyboard shortcuts
2) Probably get rid of the limited [0,5] range. Note that I'm not sure what
other apps will do if they see data outside of that range. If you've got
Lightroom or Bridge, it would be nice if you could try out the next version of
the patch (or just manually edit the XMP) and see what happens.
3) Figure out whole the sorting situation.
--xsdg
PS: patch is also on the net at
http://ocaml.xvm.mit.edu/~xsdg/stuff/geeqie/ratings.v1.patch.txt
commit 9c3b2fabe4e990c4d95d03eb77f6eb285376b7a6
Author: Omari Stephens
Date: Sun Nov 15 00:57:03 2009 +
Add support for reading and writing Rating xmp metadata
- Add a constant to metadata.h to reference the Xmp.xmp.Rating tag
- Add a UI in the metadata bar
- Add associated configuration stuff
diff --git a/trunk/src/Makefile.am b/trunk/src/Makefile.am
index 144b090..9528d30 100644
--- a/trunk/src/Makefile.am
+++ b/trunk/src/Makefile.am
@@ -94,6 +94,8 @@ geeqie_SOURCES = \
bar_keywords.h \
bar_exif.c \
bar_exif.h \
+ bar_rating.c \
+ bar_rating.h \
bar_sort.c \
bar_sort.h \
cache.c \
diff --git a/trunk/src/bar.c b/trunk/src/bar.c
index 52d6a54..4d64b71 100644
--- a/trunk/src/bar.c
+++ b/trunk/src/bar.c
@@ -25,6 +25,7 @@
#include "ui_menu.h"
#include "bar_comment.h"
#include "bar_keywords.h"
+#include "bar_rating.h"
#include "bar_exif.h"
#include "bar_histogram.h"
#include "histogram.h"
@@ -76,6 +77,15 @@ static const gchar default_config_comment[] =
""
"";
+static const gchar default_config_rating[] =
+""
+""
+""
+""
+""
+""
+"";
+
static const gchar default_config_exif[] =
""
""
@@ -178,6 +188,7 @@ static const KnownPanes known_panes[] = {
{PANE_GPS, "gps", N_("GPS Map"), default_config_gps},
#endif
#endif
+ {PANE_RATING, "rating", N_("Rating"), default_config_rating},
{PANE_UNDEF, NULL, NULL, NULL}
};
diff --git a/trunk/src/bar.h b/trunk/src/bar.h
index 61dc4be..d24acf3 100644
--- a/trunk/src/bar.h
+++ b/trunk/src/bar.h
@@ -20,7 +20,8 @@ typedef enum {
PANE_EXIF,
PANE_HISTOGRAM,
PANE_KEYWORDS,
- PANE_GPS
+ PANE_GPS,
+ PANE_RATING
} PaneType;
typedef struct _PaneData PaneData;
diff --git a/trunk/src/bar_rating.c b/trunk/src/bar_rating.c
new file mode 100644
index 000..684e713
--- /dev/null
+++ b/trunk/src/bar_rating.c
@@ -0,0 +1,344 @@
+/*
+ * Geeqie
+ * (C) 2004 John Ellis
+ * Copyright (C) 2008 - 2009 The Geeqie Team
+ *
+ * Author: Omari Stephens
+ *
+ * This software is released under the GNU General Public License (GNU GPL).
+ * Please read the included file COPYING for more information.
+ * This software comes with no warranty of any kind, us
Re: [Geeqie-devel] Evidence based photo selection
Noah Slater wrote: > Hello, > > I use Geeqie to select photographs from very large collections, such as the > thousands I might take on a shoot. As it stands, run through the photographs > in > a directory, deleting the ones that I don't think should make it to the next > stage of the selection process. I usually do this a number of times, using > different directories, until I have a small handful that I like. > > Because I the selection process is subjective, I add safety measures such as > copying the photographs to a new directory for each run, or running through a > copy of the same directory twice so that I can merge the selection pools of > two > identical runs. This is a tedious process, and prone to errors. > > I would like to suggest the following features: > > * A scorecard for each photo that can be incremented or decremented using > keyboard shortcuts. Two obvious shortcuts would be "-" and "=". After > pressing a key, a notification area could display the score. I am working on this. My plan for right now is to implement it as a simple hack on top of the keywords system. I could use a keyword "score:6" for storage, and then it'd just need buttons with keyboard mappings for incrementing or decrementing the score. > * A way of sorting on the list of photographs by score. As Vlad suggested, this will be more difficult to do properly. It might be possible to come up with a nice hack that works well; we'll see. I haven't yet poked at the sorting code. > I could then change my workflow to: > > * Go into a random, repeated, slideshow of a directory of photographs. > > * Run through the slideshow multiple times, scoring each photograph with > either a single positive or single negative vote, or perhaps none. > > * Sort the directory of photographs by score. > > * Delete all those photographs bellow a certain threshold. There is a random slideshow, though I'm not sure how it works. With Klaus's patch for adding a keyword, you might be able to 1) Go into random slideshow 2) Do the scoring thing 3) Sort by score 4) Add a "level 4" or whatever keyword to distinguish the ones that have made it through at least 4 rounds of selections 5) Search for the "level 4" tag, or link it to a Mark, or something to filter on that. 6) Repeat Of course, there's a lot of this picture left to be filled in as of right now. --xsdg -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
[Geeqie-devel] What needs to happen to get the release out the door?
It would be really nice to get 1.0 out the door, so folks can take advantage of the steps we've made in the past year-and-a-half. What things are blocking the release? What do we need to do to take care of those things? As for the "looking for translators and documentation writers" link on the website, it would be nice if you could at least view it without having a SF.net account. I think if people could see "oh, I know how to do this. I can help with such-and-such," then they may be more likely to actually jump in. It's hard to convince someone to get an account just to see if they might want to help, though. --xsdg -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
[Geeqie-devel] Panview menus are unusably broken
Easy to trigger (r1854): 1) Start geeqie 2) Start panview 3) Right-click anywhere 4) Dismiss the menu, either by clicking somewhere, or hitting escape, or selecting a menu option 5) Boom filedata.c:680: fd magick mismatch @ filedata.c:1104 ** ERROR:filedata.c:682:file_data_unref_debug: assertion failed: (fd->magick == 0x12345678) Program received signal SIGABRT, Aborted. [Switching to Thread 0x7fe349a6d770 (LWP 5595)] 0x7fe345c77105 in raise () from /lib/libc.so.6 (gdb) bt full #0 0x7fe345c77105 in raise () from /lib/libc.so.6 No symbol table info available. #1 0x7fe345c78623 in abort () from /lib/libc.so.6 No symbol table info available. #2 0x7fe3473b2e90 in g_assertion_message () from /usr/lib/libglib-2.0.so.0 No symbol table info available. #3 0x7fe3473b3412 in g_assertion_message_expr () from /usr/lib/libglib-2.0.so.0 No symbol table info available. #4 0x00455911 in file_data_unref_debug (file=0x4e04db "filedata.c", line=1104, fd=0x155ddd0) at filedata.c:682 __PRETTY_FUNCTION__ = "file_data_unref_debug" #5 0x00457a6a in filelist_free (list=0x1762000) at filedata.c:1104 work = (GList *) 0x1762000 #6 0x7fe34782711d in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #7 0x7fe34783abc8 in ?? () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #8 0x7fe34783c032 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #9 0x7fe34783c503 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #10 0x7fe3494e9730 in ?? () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #11 0x7fe347829092 in g_object_unref () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #12 0x7fe347849363 in g_value_unset () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #13 0x7fe34783c052 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #14 0x7fe34783c503 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #15 0x7fe3495d7c05 in ?? () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #16 0x7fe347829092 in g_object_unref () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #17 0x7fe3494d49b2 in gtk_menu_shell_activate_item () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #18 0x7fe3494d63d5 in ?? () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #19 0x7fe3494c6958 in ?? () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #20 0x7fe34782711d in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #21 0x7fe34783a8bf in ?? () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #22 0x7fe34783bebd in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #23 0x7fe34783c503 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #24 0x7fe3495ce98e in ?? () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #25 0x7fe3494bf1f3 in gtk_propagate_event () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #26 0x7fe3494c0313 in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #27 0x7fe34913acbc in ?? () from /usr/lib/libgdk-x11-2.0.so.0 No symbol table info available. #28 0x7fe34738ce4a in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0 No symbol table info available. ---Type to continue, or q to quit--- #29 0x7fe347390510 in ?? () from /usr/lib/libglib-2.0.so.0 No symbol table info available. #30 0x7fe3473909dd in g_main_loop_run () from /usr/lib/libglib-2.0.so.0 No symbol table info available. #31 0x7fe3494c0727 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #32 0x00476bfc in main (argc=1, argv=0x7fff00b97af8) at main.c:912 first_collection = (CollectionData *) 0x0 cd = (CollectionData *) 0x0 --xsdg -- Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Speed Comparisons
Vladimir Nadvornik wrote: > On Tuesday 25 August 2009 20:33:14 Omari Stephens wrote: >> [NOTE: I just realized that my tree is patched with the multi-threaded >> thumbnail loaders patch. I'm not sure what this may have changed.] >> >> So, the vast majority of the time is spent in: >> static void vflist_name_cell_data_cb(...) >> which lives around line 1771 of view_file_list.c >> > > Yes, this was indeed slow. It was removed in rev. 1799 ;) bah :o) OK, with r1824, it now takes ~11 seconds to go from program start to a state where UI interactions end up with different images being rendered. For a directory of 46,000 images, this seems pretty reasonable. And this seems an unlikely enough case that I'm not sure how valuable it'd be to optimize further. Arnd, were you running something >=r1799? Klaus? --xsdg -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Speed Comparisons
Sabin Iacob wrote: ::snip? SNIP!:: > P.S. is it me, or do Nikon NEF files really render faster than JPEGs? :-/ They should render as fast as JPEGs of the same quality. What you see is actually an embedded (iirc) ~75% quality JPEG preview that lives in every NEF. It's not actually processing the RAW contents— that'd take 5+ seconds per image for a low-quality version, even without doing the debayer so that you could see the image at 100% scale. --xsdg -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Speed Comparisons
[NOTE: I just realized that my tree is patched with the multi-threaded thumbnail
loaders patch. I'm not sure what this may have changed.]
So, the vast majority of the time is spent in:
static void vflist_name_cell_data_cb(...)
which lives around line 1771 of view_file_list.c
The backtrace generally looks something like:
#0 0x7fa6702496d4 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#1 0x004bc950 in vflist_name_cell_data_cb (tree_column=0x103d260,
cell=0xf12c90, tree_model=0x1031880,
iter=0x7fff69fbbed0, data=0xe7f980) at view_file_list.c:1780
#2 0x7fa67026a2f3 in gtk_tree_view_column_cell_set_cell_data () from
/usr/lib/libgtk-x11-2.0.so.0
#3 0x7fa670262226 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#4 0x7fa670262b31 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#5 0x7fa670262eab in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#6 0x7fa66fdaff6b in ?? () from /usr/lib/libgdk-x11-2.0.so.0
#7 0x7fa66e034e4a in g_main_context_dispatch () from
/usr/lib/libglib-2.0.so.0
#8 0x7fa66e038510 in ?? () from /usr/lib/libglib-2.0.so.0
#9 0x7fa66e0389dd in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
#10 0x7fa670168727 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
#11 0x00475b28 in main (argc=1, argv=0x7fff69fbc338) at main.c:899
I added some profiling code against r1796 and then wrote some one-liners to
analyze it. Basically, it looks like vflist_name_cell_data_cb is being called
approx. once per file. It generally takes <=3 msecs to run. It seems unlikely
that we can optimize this a whole lot.
The main problem is that we don't get to render until all these calls finish.
That is, even though the UI stays responsive, no rendering happens. I forget
what the function is, but we probably need to periodically call the function
that checks if there are pending tasks to be done. We could live with calling
it once every 1000 iterations of vflist_name_cell_data_cb without too much of a
performance hit, I imagine.
Anyway, here's some data. All times are in msecs. This was in a directory with
46,000 NEFs (well, symlinks to NEFs). The results were pretty stable.
Histogram for time spent outside of vflist_name_cell_data_cb():
time: count
0: 38192
1: 8273
2: 40
3: 13
4: 6
5: 9
7: 16
8: 4
This is 9.054 seconds
Histogram for time spent inside of vflist_name_cell_data_cb():
time: count
0: 12815
1: 18616
2: 14413
3: 561
4: 27
5: 9
6: 5
7: 10
8: 27
9: 35
This is 50.808 seconds
So for 59.862 seconds, the UI is responsive, but no rendering happens. This is
entirely CPU-bound — no I/O or memory allocation seems to happen during this period.
--xsdg
/* USAGE:
* "use" is actually related to the precision. It should be a power of 10,
* between 1 and 100, inclusive. The whole seconds are multiplied
* by this value, and then the partial seconds are added in beneath, so
* 1 will give you 1-second precision (that is, 1/1sec = 1 second)
* 1000 will give you 1-msec precision (1/1000sec = 1 millisecond)
* 100 will give you 1-usec precision (1/100sec = 1 microsecond)
* Note that the accuracy may not be as tight as the precision.
*
* call rstime(use) to reset the timer
* call gotime("some tag", use) to measure how long it's been since the last
* call and print the interval length
*/
#define rstime(use) timestuff("", use, 1)
#define gotime(tag, use) timestuff(tag, use, 0)
static void timestuff(const char **tag, int use, int reset)
{
static struct timeval curtime;
static struct timeval prevtime;
static long long diff;
static int ratio = 100;
gettimeofday(&curtime, NULL);
if(reset == 0)
{
diff = ((long long) curtime.tv_sec * use + curtime.tv_usec / (ratio / use)) -
((long long) prevtime.tv_sec * use + prevtime.tv_usec / (ratio / use));
printf("time diff %s: %ld\n", tag, diff);
}
prevtime.tv_sec = curtime.tv_sec;
prevtime.tv_usec = curtime.tv_usec;
}
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Rotating images
Vladimir Nadvornik wrote: ::snip? SNIP!:: > IMO this would be superfluous. There are two clear steps: > > 1. mark the correct orientation in metadata - this is usually done by the > camera or it can be done manually in geeqie > > 2. adjust the pixels according to metatata - this is what the "Apply the > orientation to image content" command does. I don't think you can reasonably consider these to be two separate steps. At the point after the first step has happened, but before the second has happened, the image is in an invalid state. If the computer were to have a power outage just then, it would require manual intervention to again make sure that the metadata is in sync with the true orientation of the pixel data. --xsdg -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] A request
Jeffery Small wrote: > Using Geeqie 1.0alpha3: > > I don't remember if this issue was raised before, but would it be possible > to include a command line switch that would suppress the display of Warning > messages. I get many of the following: It was. These messages are printed directly by exiv2, which is compiled by whoever ships your distribution. IIRC, there is nothing we can do about this. You can recompile your exiv2 to disable these, and possibly complain to your distro (or possibly to upstream). --xsdg -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Geeqie 1.0 beta2 assertion failed bug
Yes, this does look similar to the bug I encountered. Note that my bug wasn't necessarily related to panview; that's just a way I found to consistently reproduce it. It was a memory corruption bug, as this seems to be. --xsdg big...@spin.ict.pwr.wroc.pl wrote: > Hi, > >I've got an assertion failed error and program abort under certain > circumstances. I've discovered it on one (as for now) of many > directories with my photos. Steps do > reproduce: > > 1. Run geeqie > 2. Go to the "bad" directory > 3. Try do go the subdirectory or to the parent directory > 4. On the output I see something like this: > ERROR:filedata.c:580:file_data_free: assertion failed: (fd->magick == > 0x12345678) > Aborted > > ... and program exits > > I've copied my test directory to other location to test if it has anything > with filesystem level error, but with no luck. > > I've run gdb and after program crash this is backtrace content: > > ** > ERROR:filedata.c:580:file_data_free: assertion failed: (fd->magick == > 0x12345678) > > Program received signal SIGABRT, Aborted. > [Switching to Thread 0x7f5179f9c780 (LWP 28626)] > 0x7f51763c0d25 in raise () from /lib/libc.so.6 > (gdb) backtrace > #0 0x7f51763c0d25 in raise () from /lib/libc.so.6 > #1 0x7f51763c3de1 in abort () from /lib/libc.so.6 > #2 0x7f5177afa010 in g_assertion_message () from > /usr/lib/libglib-2.0.so.0 > #3 0x7f5177afa592 in g_assertion_message_expr () from > /usr/lib/libglib-2.0.so.0 > #4 0x00460bd7 in file_data_free (fd=0x190f610) at filedata.c:580 > #5 0x00460f53 in file_data_unref_debug (file=0x501f18 > "filedata.c", line=1028, fd=0x1910b60) > at filedata.c:641 > #6 0x00461b8d in filelist_free (list=0x190e320) at > filedata.c:1028 > #7 0x004df799 in vflist_set_fd (vf=0x18bbd50, dir_fd=0x190e860) > at view_file_list.c:1940 > #8 0x004da7a0 in vf_set_fd (vf=0x18bbd50, dir_fd=0x190e860) at > view_file.c:648 > #9 0x004783eb in layout_sync_path (lw=0x16264e0) at layout.c:844 > #10 0x0047867a in layout_set_fd (lw=0x16264e0, fd=0x190e860) at > layout.c:914 > #11 0x00476c46 in layout_vd_select_cb (vd=0x18adc00, fd=0x190e860, > data=0x16264e0) at layout.c:249 > #12 0x004d3fb6 in vd_select_row (vd=0x18adc00, fd=0x190e860) at > view_dir.c:196 > #13 0x004d5d6e in vd_release_cb (widget=0x18bc020, > bevent=0x1611ce0, data=0x18adc00) at view_dir.c:1041 > #14 0x7f51799fa958 in ?? () from /usr/lib/libgtk-x11-2.0.so.0 > #15 0x7f5177f6e11d in g_closure_invoke () from > /usr/lib/libgobject-2.0.so.0 > #16 0x7f5177f81c2b in ?? () from /usr/lib/libgobject-2.0.so.0 > #17 0x7f5177f82ead in g_signal_emit_valist () from > /usr/lib/libgobject-2.0.so.0 > #18 0x7f5177f834f3 in g_signal_emit () from > /usr/lib/libgobject-2.0.so.0 > #19 0x7f5179b0298e in ?? () from /usr/lib/libgtk-x11-2.0.so.0 > #20 0x7f51799f31f3 in gtk_propagate_event () from > /usr/lib/libgtk-x11-2.0.so.0 > #21 0x7f51799f4313 in gtk_main_do_event () from > /usr/lib/libgtk-x11-2.0.so.0 > #22 0x7f517966ecbc in ?? () from /usr/lib/libgdk-x11-2.0.so.0 > #23 0x7f5177ad3f7a in g_main_context_dispatch () from > /usr/lib/libglib-2.0.so.0 > #24 0x7f5177ad7640 in ?? () from /usr/lib/libglib-2.0.so.0 > #25 0x7f5177ad7b0d in g_main_loop_run () from > /usr/lib/libglib-2.0.so.0 > #26 0x7f51799f4727 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 > #27 0x00487e27 in main (argc=1, argv=0x7fff820d4a38) at main.c:899 > > I've found some similar errors on the one of other threads of geeqie > maillists, but it was related to the panview functionality. > Geeqie built from trunk sources behaves the same way - it generates > assertion failed error and exits. > > I would be grateful for any help. :-) > > Kindly regards, > Rafal > > -- > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > trial. Simplify your report design, integration and deployment - and focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > ___ > Geeqie-devel mailing list > Geeqie-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geeqie-devel -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
[Geeqie-devel] Geeqie needs documentation
Geeqie clearly needs documentation — one shouldn't be required to email the mailing list to discover all of its cool features. I might just be insane enough to start working on this. Thoughts? For the record, the type of documentation I have in mind is probably called a "user manual." --xsdg -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Comercial programs and other issues
Oscar Miras wrote: > Hi guys, > > I'm writting a preview of my project and I would like to insert an image > of any comercial software that works in the way that Geeqie with Pan > View Calendar mode does; but incredibly I don't find any searching in > google. Could you help me :( ? > > Thanks in andvace! I believe I've heard that ACDSee and/or Picasa do this. I might be misrecalling, though. I've never used either of them, so I don't know from personal experience. --xsdg -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Compiling geeqie on Mac
Laurent Monin wrote: > Martin Proetzsch a écrit : >> Hello Laurent, >> >> >> On Jul 26, 2009, at 9:09 PM, Laurent Monin wrote: >> >> >>> Yes, instead can you try the attached patch ? >>> >>> MAP_ANON should be defined, but not MAP_ANONYMOUS on some systems, >>> so making an alias should suffice. >>> >> I have done so and geeqie works as expected. So, if it also works for >> the other operating systems, someone could apply the patch to svn >> (together with my patch of the exiv2.cc concerning the explicit cast). >> >> Thanks a lot. I'll frequently check for changes and tell you about >> news on osx. >> >> Martin >> >> > On ubuntu jaunty i get this compilation error after applying your > exiv2.cc patch: > > exiv2.cc: In function ‘void debug_exception(Exiv2::AnyError&)’: > exiv2.cc:106: erreur: request for member ‘c_str’ in > ‘((Exiv2::AnyError*)e)->Exiv2::AnyError::.std::exception::what()’, > which is of non-class type ‘const char*’ Is this really part of the "Compiling geeqie on Mac" thread? I don't see the connection. --xsdg -- ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
[Geeqie-devel] #geeqie IRC on Freenode
Hey, all Just a quick heads-up that I created #geeqie on irc.freenode.net Feel free to stop by/idle/whatever :o) --xsdg -- ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] [PATCH] Multithreaded image loading
Klaus Ethgen wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Hi, > > Am Fr den 24. Jul 2009 um 23:08 schrieb Vladimir Nadvornik: >> I'd rather wait with adding the patch after 1.0, since it is a non-trivial >> change. > > Wouldn't it be better to add such patches to a branch and merge it > later? At least with git (its how I manage geeqie) it is pretty easy to > do so. I have several branches locally by myself to manage ideas, > translations and so on. At least as of svn 1.4, this could sometimes get pretty hairy. I've heard there was a lot of progress made with svk, a lot of which ended up in svn 1.5, but I haven't used 1.5 seriously enough to know. --xsdg -- ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Evidence based photo selection
Vladimir Nadvornik wrote:
> Hi all,
>
> I am back ;)
Welcome back. Hope you enjoyed your vacation
>
> On so 18. července 2009, Omari Stephens wrote:
::snip? SNIP!::
>> Score (aka stars) would be nice.
>
> Adding star rating is easy.
>
> Sorting images according to the rating is more tricky, because it has to
> read metadata from all images in a directory first and that can be slow.
> Sorting according to exif date has the same problem. It will need some
> infrastructure changes first (the metadata cache).
Gotta love XML. `grep Rating: .../*.gq.xmp` would be super-fast.
::snip? SNIP!::
>> People who know this part of the code: please, please, please add a way to
>> bulk-add keywords. I doubt I'll get time to poke at geeqie this weekend,
>> and I'd need to learn this part of the code anyway.
>>
> There are 2 ways:
>
> - right click on the keyword list (not the tree) and select "Add keywords to
> selected files" or "Replace keywords in selected files"
I agree with Klaus: while this would work for me, that is only the case because
I only ever use keywords as a proxy for star ratings ("good," "vgood," etc.).
If I actually used keywords appropriately, this wouldn't be very useful.
Something like "Add/Remove keyword Foo to/from the selected images" would be a
nice short-term solution. I think a fantastic (longer-term) way to solve this
problem is demonstrated by the exfalso audio tag editor (which I've only ever
used as embedded in the quodlibet audio player).
Here, I selected a group of tracks crossing an album boundary, then
right-clicked and hit "Edit Tags":
http://ocaml.xvm.mit.edu/~xsdg/stuff/geeqie/exfalso1.png
From the dialog that pops up (top-right corner), it's obvious which tags are
shared and which aren't. You can edit any value (regardless of whether it
differs or not) and all of the tracks will have that tag set to the new value.
You can see how intuitive this is. When I deselect the three tracks from the
'Out of Exile' album and hit "Edit Tags" again, it now looks like this:
http://ocaml.xvm.mit.edu/~xsdg/stuff/geeqie/exfalso2.png
In the context of geeqie, we could simply show the tree of tags, and for each
one, have a check-box that is either filled, empty, or gray (or something else
to denote "tag not uniformly selected/deselected"). Then you can click
checkboxes to add or remove that tag from all of the selected photos. Have a
"Revert" button so users know off-the-bat that they can mess up and start over,
and also a right-click "Revert this tag" option so that people can revert
individual mistakes. Et voila.
> - right click on a keyword in keyword tree and select "connect to mark".
> Since
> then, toggling the mark will add or remove the corresponding keyword. You can
> use all the operations from Select menu.
This just blew my mind.
--xsdg
--
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/Challenge
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Evidence based photo selection
Noah Slater wrote: > Hello, > > I use Geeqie to select photographs from very large collections, such as the > thousands I might take on a shoot. As it stands, run through the photographs > in > a directory, deleting the ones that I don't think should make it to the next > stage of the selection process. I usually do this a number of times, using > different directories, until I have a small handful that I like. > > Because I the selection process is subjective, I add safety measures such as > copying the photographs to a new directory for each run, or running through a > copy of the same directory twice so that I can merge the selection pools of > two > identical runs. This is a tedious process, and prone to errors. > > I would like to suggest the following features: > > * A scorecard for each photo that can be incremented or decremented using > keyboard shortcuts. Two obvious shortcuts would be "-" and "=". After > pressing a key, a notification area could display the score. - and = are used for zoom. (and _ and + are used for linked zoom) > * A way of sorting on the list of photographs by score. It should be trivial to add score to the sort menu once it's added. > I could then change my workflow to: > > * Go into a random, repeated, slideshow of a directory of photographs. > > * Run through the slideshow multiple times, scoring each photograph with > either a single positive or single negative vote, or perhaps none. > > * Sort the directory of photographs by score. > > * Delete all those photographs bellow a certain threshold. Admittedly, I don't see the point in deleting images. Disk is cheap, mistakes are not, and rm is forever. > What do you think? Perhaps this is already possible? Score (aka stars) would be nice. You can already (sort of, see caveat at end) get a big step up over your current workflow by using keywords and/or marks. There are six marks, which you can toggle with the number keys 1–6. Hit "m" to see the marks in the directory listview. You can also easily filter on marks by clicking the appropriate square that appears above the listview. So, the workflow I imagine is something like: - Go through, add Mark 1 to the images that make the first cut - Filter out Mark 1 (do this via the Select menu) to go through the images that didn't make the first cut. Add any that you've changed your mind about. - Restrict to only Mark 1 images by clicking the box above the listview - Go through, add Mark 2 to images that make the second cut - (etc.) - Add some keyword to images that make the final cut. There is one serious problem with this workflow. Hopefully, though, it shouldn't be too hard to fix. The problem is that there is no good way to save marks. That is, marks themselves aren't saved as part of the image metadata, and (more importantly) there is no way to bulk-add keywords. People who know this part of the code: please, please, please add a way to bulk-add keywords. I doubt I'll get time to poke at geeqie this weekend, and I'd need to learn this part of the code anyway. --xsdg -- Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
