date:20181219

Change in osmo-mgw[neels/iuup]: iuup_cn_node.c: make it work for AMR 12.2k codec

2018-12-19 Thread Mykola Shchetinin

Mykola Shchetinin has posted comments on this change. ( 
https://gerrit.osmocom.org/12390 )

Change subject: iuup_cn_node.c: make it work for AMR 12.2k codec
..


Patch Set 1:

I've uploaded the commit to gerrit as it seems that I am not allowed to create 
new branches.


--
To view, visit https://gerrit.osmocom.org/12390
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: neels/iuup
Gerrit-MessageType: comment
Gerrit-Change-Id: I244c4c4778798912c818812a15709695d3251f87
Gerrit-Change-Number: 12390
Gerrit-PatchSet: 1
Gerrit-Owner: Mykola Shchetinin 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Mykola Shchetinin 
Gerrit-Comment-Date: Thu, 20 Dec 2018 07:05:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-mgw[neels/iuup]: iuup_cn_node.c: make it work for AMR 12.2k codec

2018-12-19 Thread Mykola Shchetinin

Mykola Shchetinin has uploaded this change for review. ( 
https://gerrit.osmocom.org/12390


Change subject: iuup_cn_node.c: make it work for AMR 12.2k codec
..

iuup_cn_node.c: make it work for AMR 12.2k codec

rx_data: prepend hardcoded AMR 12.2 header "0xf03c" to the front of RTP
payload
osmo_iuup_cn_tx_payload: strip AMR header (2 bytes) from the front of RTP
payload

Change-Id: I244c4c4778798912c818812a15709695d3251f87
---
M src/libosmo-mgcp/iuup_cn_node.c
M tests/iuup/iuup_test.c
M tests/iuup/iuup_test.ok
3 files changed, 17 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/90/12390/1

diff --git a/src/libosmo-mgcp/iuup_cn_node.c b/src/libosmo-mgcp/iuup_cn_node.c
index f555e36..fda7a7a 100644
--- a/src/libosmo-mgcp/iuup_cn_node.c
+++ b/src/libosmo-mgcp/iuup_cn_node.c
@@ -85,10 +85,12 @@
   struct osmo_iuup_hdr_data *hdr)
 {
/* Remove the IuUP bit from the middle of the buffer by writing the RTP 
header forward. */
+   /* And append AMR 12.2k header "0xf03c". - AD HOC fix */
unsigned int pre_hdr_len = ((uint8_t*)hdr) - pdu->data;
-   memmove(pdu->data + sizeof(*hdr), pdu->data, pre_hdr_len);
-
-   msgb_pull(pdu, sizeof(*hdr));
+   memmove(pdu->data + sizeof(*hdr) - 2, pdu->data, pre_hdr_len);
+   ((uint8_t*)hdr)[2] = 0xf0;
+   ((uint8_t*)hdr)[3] = 0x3c;
+   msgb_pull(pdu, sizeof(*hdr) - 2);

LOGP(DIUUP, LOGL_DEBUG, "(%s) IuUP stripping IuUP header from RTP 
data\n", cn->name);
cn->cfg.rx_payload(pdu, cn->cfg.node_priv);
@@ -191,7 +193,8 @@
rtp_was = (void*)pdu->data;

/* copy the RTP header part backwards by the size needed for the IuUP 
header */
-   rtp = (void*)msgb_push(pdu, sizeof(*iuup_hdr));
+   /* also strips 2 bytes from the front of RTP payload - AMR header - AD 
HOC fix */
+   rtp = (void*)msgb_push(pdu, sizeof(*iuup_hdr) - 2);
memmove(rtp, rtp_was, sizeof(*rtp));

/* Send the same payload type to the peer (erm...) */
diff --git a/tests/iuup/iuup_test.c b/tests/iuup/iuup_test.c
index 8d96f06..e6f2ca5 100644
--- a/tests/iuup/iuup_test.c
+++ b/tests/iuup/iuup_test.c
@@ -111,7 +111,7 @@
 #define RTP_PAYLOAD 
"6cfb23bc46d18180c3e5ffe04004565a7d35b625b80005fff03214ced0"
printf("\nReceive payload encapsulated in IuUP. Expecting rx_payload() 
of just RTP packet\n");
printf("i.e. should strip away " IUUP_HEADER "\n");
-   expect_rx_payload = RTP_HEADER RTP_PAYLOAD;
+   expect_rx_payload = RTP_HEADER "f03c" RTP_PAYLOAD;
rx_pdu(cn,
   msgb_from_hex("IuUP-Data",
 RTP_HEADER IUUP_HEADER RTP_PAYLOAD));
@@ -119,18 +119,18 @@
printf("\nTransmit RTP. Expecting tx_msg() with inserted IuUP 
header\n");
expect_tx_msg = RTP_HEADER "02b3" RTP_PAYLOAD;
tx_payload(cn,
-  msgb_from_hex("RTP data", RTP_HEADER RTP_PAYLOAD));
+  msgb_from_hex("RTP data", RTP_HEADER "f03c" RTP_PAYLOAD));

printf("\nMore RTP, each time the Frame Nr advances, causing a new 
header CRC.\n");
expect_tx_msg = RTP_HEADER "0100e2b3" RTP_PAYLOAD;
tx_payload(cn,
-  msgb_from_hex("RTP data", RTP_HEADER RTP_PAYLOAD));
+  msgb_from_hex("RTP data", RTP_HEADER "f03c" RTP_PAYLOAD));
expect_tx_msg = RTP_HEADER "02007eb3" RTP_PAYLOAD;
tx_payload(cn,
-  msgb_from_hex("RTP data", RTP_HEADER RTP_PAYLOAD));
+  msgb_from_hex("RTP data", RTP_HEADER "f03c" RTP_PAYLOAD));
expect_tx_msg = RTP_HEADER "03009eb3" RTP_PAYLOAD;
tx_payload(cn,
-  msgb_from_hex("RTP data", RTP_HEADER RTP_PAYLOAD));
+  msgb_from_hex("RTP data", RTP_HEADER "f03c" RTP_PAYLOAD));

printf("All done.\n");
 }
diff --git a/tests/iuup/iuup_test.ok b/tests/iuup/iuup_test.ok
index 2b09c66..8c473d6 100644
--- a/tests/iuup/iuup_test.ok
+++ b/tests/iuup/iuup_test.ok
@@ -15,14 +15,14 @@
 
8060944c6256042c000101020100e2b36cfb23bc46d18180c3e5ffe04004565a7d35b625b80005fff03214ced0
 rx_payload() invoked by iuup_cn!
 [IuUP] -RTP->
-8060944c6256042c000101026cfb23bc46d18180c3e5ffe04004565a7d35b625b80005fff03214ced0
+8060944c6256042c00010102f03c6cfb23bc46d18180c3e5ffe04004565a7d35b625b80005fff03214ced0
 node_priv=0x2342
 ok: matches expected msg
 rc=0

 Transmit RTP. Expecting tx_msg() with inserted IuUP header
 [IuUP] <-RTP-
-8060944c6256042c000101026cfb23bc46d18180c3e5ffe04004565a7d35b625b80005fff03214ced0
+8060944c6256042c00010102f03c6cfb23bc46d18180c3e5ffe04004565a7d35b625b80005fff03214ced0
 tx_msg() invoked by iuup_cn!
  <-PDU- [IuUP]
 
8060944c6256042c0001010202b36cfb23bc46d18180c3e5ffe04004565a7d35b625b80005fff03214ced0
@@ -32,7 +32,7 @@

 More RTP, each time the Frame Nr advances, causing a new header CRC.
 [IuUP] <-RTP-

Jenkins build is back to normal : master-osmo-msc » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #7590

2018-12-19 Thread jenkins

See

Jenkins build is back to normal : master-osmo-msc » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #7590

2018-12-19 Thread jenkins

See

Change in osmo-msc[master]: fix test_nodes.vty after libosmo-mgcp-client vty changes

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12389 )

Change subject: fix test_nodes.vty after libosmo-mgcp-client vty changes
..

fix test_nodes.vty after libosmo-mgcp-client vty changes

osmo-mgw I98a9f1f17a1c4ab20cea3b08c7d21663592134d6 broke the build here. Fix
that.

Change-Id: I20e37c5228928b67e67f16aef0eb2930d21ef60a
---
M tests/test_nodes.vty
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Neels Hofmeyr: Looks good to me, approved



diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty
index dcbf580..d080082 100644
--- a/tests/test_nodes.vty
+++ b/tests/test_nodes.vty
@@ -45,8 +45,6 @@
   mgw local-port <0-65535>
   mgw remote-ip A.B.C.D
   mgw remote-port <0-65535>
-  mgw endpoint-range <1-65534> <1-65534>
-  mgw bts-base <0-65534>
 ...

 OsmoMSC(config-msc)# mncc?

--
To view, visit https://gerrit.osmocom.org/12389
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I20e37c5228928b67e67f16aef0eb2930d21ef60a
Gerrit-Change-Number: 12389
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr

Change in osmo-msc[master]: fix test_nodes.vty after libosmo-mgcp-client vty changes

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12389 )

Change subject: fix test_nodes.vty after libosmo-mgcp-client vty changes
..


Patch Set 1: Code-Review+2

urgent: fix build


--
To view, visit https://gerrit.osmocom.org/12389
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I20e37c5228928b67e67f16aef0eb2930d21ef60a
Gerrit-Change-Number: 12389
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Thu, 20 Dec 2018 03:49:48 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: fix test_nodes.vty after libosmo-mgcp-client vty changes

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/12389


Change subject: fix test_nodes.vty after libosmo-mgcp-client vty changes
..

fix test_nodes.vty after libosmo-mgcp-client vty changes

osmo-mgw I98a9f1f17a1c4ab20cea3b08c7d21663592134d6 broke the build here. Fix
that.

Change-Id: I20e37c5228928b67e67f16aef0eb2930d21ef60a
---
M tests/test_nodes.vty
1 file changed, 0 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/89/12389/1

diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty
index dcbf580..d080082 100644
--- a/tests/test_nodes.vty
+++ b/tests/test_nodes.vty
@@ -45,8 +45,6 @@
   mgw local-port <0-65535>
   mgw remote-ip A.B.C.D
   mgw remote-port <0-65535>
-  mgw endpoint-range <1-65534> <1-65534>
-  mgw bts-base <0-65534>
 ...

 OsmoMSC(config-msc)# mncc?

--
To view, visit https://gerrit.osmocom.org/12389
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I20e37c5228928b67e67f16aef0eb2930d21ef60a
Gerrit-Change-Number: 12389
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr

Change in osmo-bsc[master]: make sure early lchan act failure resets the lchan

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/12388


Change subject: make sure early lchan act failure resets the lchan
..

make sure early lchan act failure resets the lchan

Fix crash after AMR configuration fails.

The crash is due to an assertion that finds a non-NULL conn in the lchan, when
re-using an lchan that has failed in AMR configuration earlier on. That is
because the AMR config still happens in state UNUSED.

  DCHAN ERROR lchan(0-0-2-TCH_F_TCH_H_PDCH-0)[0x612066a0]{UNUSED}: 
(type=TCH_F) lchan allocation failed in state UNUSED: Can not generate 
multirate configuration IE
  ...
  DCHAN DEBUG lchan(0-0-2-TCH_F_TCH_H_PDCH-0)[0x612066a0]{UNUSED}: 
(type=TCH_F) After failure handling, already in state UNUSED
  ...
  ...
  DCHAN DEBUG lchan(0-0-2-TCH_F_TCH_H_PDCH-0)[0x612066a0]{UNUSED}: Received 
Event LCHAN_EV_ACTIVATE (lchan_fsm.c:324)
  Assert failed !lchan->conn 
../../../../src/osmo-bsc/src/osmo-bsc/lchan_fsm.c:491

The FSM design idea is that when returning to the UNUSED state, all lchan state
is cleared. However, when calling lchan_activate(), a failure may happen still
in state UNUSED, so that we don't transition *back* to UNUSED properly.

So, first transition out of UNUSED before failures can happen. (Other ways to
solve this would be to invoke lchan clearing even if already in UNUSED, but
semantically, transitioning first makes more sense.)

Upon LCHAN_EV_ACTIVATE, just remember the lchan_activate_info and transition to
WAIT_TS_READY, so that on lchan_fail(), we can normally transition back to
UNUSED and clear the lchan.

Move the initial lchan activation code to lchan_fsm_wait_ts_ready_onenter().

Also, there is a bit of duplication of members of the lchan->activate (lchan
state) and the lchan_activate_info (passed to lchan_activate()) structs. The
fix for this also removes the dup:

Add struct lchan_activate_info as child struct at lchan->activate.info, drop
the other lchan->activate members that would dup .info.*. Move struct
lchan_activate_info declaration to gsm_data.h.

Apply the new '.info' member struct throughout the code.

Related: OS#3737
Change-Id: Ide665b10fa3f4583059c55346db8da833959e3cc
---
M include/osmocom/bsc/gsm_data.h
M include/osmocom/bsc/lchan_fsm.h
M src/osmo-bsc/assignment_fsm.c
M src/osmo-bsc/bsc_subscr_conn_fsm.c
M src/osmo-bsc/handover_fsm.c
M src/osmo-bsc/lchan_fsm.c
M src/osmo-bsc/lchan_rtp_fsm.c
M src/osmo-bsc/osmo_bsc_bssap.c
8 files changed, 104 insertions(+), 106 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/88/12388/1

diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index cf34c6f..2090142 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -503,6 +503,19 @@
 static inline const char *lchan_activate_mode_name(enum lchan_activate_mode 
activ_for)
 { return get_value_string(lchan_activate_mode_names, activ_for); }

+struct lchan_activate_info {
+   enum lchan_activate_mode activ_for;
+   struct gsm_subscriber_connection *for_conn;
+   /* This always is for a specific lchan, so its lchan->type indicates 
full or half rate.
+* When a dyn TS was selected, the lchan->type has been set to the 
desired rate. */
+   enum gsm48_chan_mode chan_mode;
+   uint16_t s15_s0;
+   bool requires_voice_stream;
+   bool wait_before_switching_rtp; /*< true = requires 
LCHAN_EV_READY_TO_SWITCH_RTP */
+   uint16_t msc_assigned_cic;
+   struct gsm_lchan *re_use_mgw_endpoint_from_lchan;
+};
+
 struct gsm_lchan {
/* The TS that we're part of */
struct gsm_bts_trx_ts *ts;
@@ -517,18 +530,14 @@
struct mgwep_ci *mgw_endpoint_ci_bts;

struct {
-   enum lchan_activate_mode activ_for;
+   struct lchan_activate_info info;
bool activ_ack; /*< true as soon as RSL Chan Activ Ack is 
received */
bool immediate_assignment_sent;
/*! This flag ensures that when an lchan activation has 
succeeded, and we have already
 * sent ACKs like Immediate Assignment or BSSMAP Assignment 
Complete, and if other errors
 * occur later, e.g. during release, that we don't send a NACK 
out of context. */
bool concluded;
-   bool requires_voice_stream;
-   bool wait_before_switching_rtp; /*< true = requires 
LCHAN_EV_READY_TO_SWITCH_RTP */
-   uint16_t msc_assigned_cic;
enum gsm0808_cause gsm0808_error_cause;
-   struct gsm_lchan *re_use_mgw_endpoint_from_lchan;
} activate;

struct {
diff --git a/include/osmocom/bsc/lchan_fsm.h b/include/osmocom/bsc/lchan_fsm.h
index 48cd383..55ab024 100644
--- a/include/osmocom/bsc/lchan_fsm.h
+++ b/include/osmocom/bsc/lchan_fsm.h
@@ -52,19 +52,6 @@
 void lchan_release(struct gsm_lchan *lchan, bool

Build failed in Jenkins: master-osmo-msc » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #7589

2018-12-19 Thread jenkins

See 


--
[...truncated 1.20 MB...]
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  iu rab-assign-addr-enc (x213|v4raw)
  asn1 debug (1|0)
  asn1 xer-print (1|0)
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6640 bytes in  53 blocks)
iu contains  2 bytes in   2 blocks (ref 0) 
0x60b000168550
asn1   contains  1 bytes in   1 blocks (ref 
0) 0x60b0001684a0
struct osmo_ss7_instance   contains   2509 bytes in  29 blocks (ref 0) 
0x6140a4a0
struct osmo_sccp_instance  contains359 bytes in   5 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f09010
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168340
struct osmo_sccp_user  contains 93 bytes in   2 blocks 
(ref 0) 0x60f09100
OsmoMSC-IuCS   contains 13 bytes in   1 
blocks (ref 0) 0x60b0001683f0
struct osmo_ss7_aspcontains   1099 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains365 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A-Iu)[0x61216d20] contains 47 
bytes in   1 blocks (ref 0) 0x60d27b30
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c465a0
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168600
struct osmo_fsm_inst   contains276 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b0001686b0
xua_default_lm(asp-clnt-OsmoMSC-A-Iu)[0x61217020] contains  
   54 bytes in   1 blocks (ref 0) 0x60e39e60
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c46660
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b000168760
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 blocks 
(ref 0) 0x60c46720
struct osmo_ss7_as contains607 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains362 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A-Iu)[0x61217320] contains 45 
bytes in   1 blocks (ref 0) 0x60d27c00
as-clnt-OsmoMSC-A-Iu   contains 21 bytes in   1 
blocks (ref 0) 0x60c46960
as-clnt-OsmoMSC-A-Iu   contains 21 bytes

Build failed in Jenkins: master-osmo-msc » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #7589

2018-12-19 Thread jenkins

See 


--
[...truncated 859.21 KB...]
  no stats reporter statsd
  stats reporter log
  no stats reporter log
  stats interval <1-65535>
  network
  msc
  mncc-int
  hlr
  smpp

OsmoMSC(config)# network

OsmoMSC(config-net)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;m  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
full talloc report on 'osmo_msc' (total   6502 bytes in  49 blocks)
struct osmo_ss7_instance   contains   2389 bytes in  27 blocks (ref 0) 
0x6140a6a0
struct osmo_sccp_instance  contains266 bytes in   3 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f091f0
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016ab20
struct osmo_ss7_aspcontains   1084 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains359 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A)[0x61216d20] contains 44 
bytes in   1 blocks (ref 0) 0x60d27da0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46a20
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016abd0
struct osmo_fsm_inst   contains270 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b00016ac80
xua_default_lm(asp-clnt-OsmoMSC-A)[0x61217020] contains 
51 bytes in   1 blocks (ref 0) 0x60e3a1e0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46ae0
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b00016ad30
asp-clnt-OsmoMSC-A contains 19 bytes in   1 blocks 
(ref 0) 0x60c46ba0
struct osmo_ss7_as contains598 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains356 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A)[0x61217320] contains 42 bytes 
in   1 blocks (ref 0) 0x60d27e70
as-clnt-OsmoMSC-A  contains 18 bytes in   1 
blocks (ref 0) 0x60c46de0
as-clnt-OsmoMSC-A  contains 18 bytes in   1 blocks 
(ref 0) 0x60c46ea0
struct osmo_ss7_route_tablecontains145 bytes in   4 blocks (ref 
0) 0x60e3a3a0
struct osmo_ss7_route  contains 82 bytes in   2 blocks 
(ref 0) 0x60e3a2c0
as-clnt-OsmoMSC-A

Change in osmo-bts[master]: rsl: Send PDCH ACT NACK if TCH chan is still active

2018-12-19 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12180 )

Change subject: rsl: Send PDCH ACT NACK if TCH chan is still active
..


Patch Set 1:

> The idea of a commit log is that the reviewer can skip all that
 > because you have explained it :)

I think the commit description provides enough context to understand the issue 
and how it was added (originating commit), how to reproduce the issue (TTCN3 
test, and how it behaves in commit description), and why exactly the added code 
behaves (there's a comment explaining the case/scenario on top of the code).

Feel free to provide an explicit change in order to merge the change, or we can 
keep with osmo-bts misbehaving and a TTCN3 failing for a few more months for 
apparently no good reason. It's a 2 lines change with a TTCN3 test behind it 
showcasing the issue, not a complete refactor of 1000 code lines.


--
To view, visit https://gerrit.osmocom.org/12180
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d6d12aec10c801fe55012ca6e58d0bc8755b15d
Gerrit-Change-Number: 12180
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 20 Dec 2018 00:58:12 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Build failed in Jenkins: master-osmo-msc » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #7588

2018-12-19 Thread jenkins

See 


--
[...truncated 859.12 KB...]
  no stats reporter statsd
  stats reporter log
  no stats reporter log
  stats interval <1-65535>
  network
  msc
  mncc-int
  hlr
  smpp

OsmoMSC(config)# network

OsmoMSC(config-net)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6502 bytes in  49 blocks)
struct osmo_ss7_instance   contains   2389 bytes in  27 blocks (ref 0) 
0x6140a6a0
struct osmo_sccp_instance  contains266 bytes in   3 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f091f0
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016ab20
struct osmo_ss7_aspcontains   1084 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains359 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A)[0x61216d20] contains 44 
bytes in   1 blocks (ref 0) 0x60d27da0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46a20
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016abd0
struct osmo_fsm_inst   contains270 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b00016ac80
xua_default_lm(asp-clnt-OsmoMSC-A)[0x61217020] contains 
51 bytes in   1 blocks (ref 0) 0x60e3a1e0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46ae0
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b00016ad30
asp-clnt-OsmoMSC-A contains 19 bytes in   1 blocks 
(ref 0) 0x60c46ba0
struct osmo_ss7_as contains598 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains356 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A)[0x61217320] contains 42 bytes 
in   1 blocks (ref 0) 0x60d27e70
as-clnt-OsmoMSC-A  contains 18 bytes in   1 
blocks (ref 0) 0x60c46de0
as-clnt-OsmoMSC-A  contains 18 bytes in   1 blocks 
(ref 0) 0x60c46ea0
struct osmo_ss7_route_tablecontains145 bytes in   4 blocks (ref 
0) 0x60e3a3a0
struct osmo_ss7_route  contains 82 bytes in   2 blocks 
(ref 0) 0x60e3a2c0
as-clnt-OsmoMSC-A

Build failed in Jenkins: master-osmo-msc » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #7588

2018-12-19 Thread jenkins

See 


--
[...truncated 1.20 MB...]
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  iu rab-assign-addr-enc (x213|v4raw)
  asn1 debug (1|0)
  asn1 xer-print (1|0)
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6640 bytes in  53 blocks)
iu contains  2 bytes in   2 blocks (ref 0) 
0x60b000168550
asn1   contains  1 bytes in   1 blocks (ref 
0) 0x60b0001684a0
struct osmo_ss7_instance   contains   2509 bytes in  29 blocks (ref 0) 
0x6140a4a0
struct osmo_sccp_instance  contains359 bytes in   5 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f09010
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168340
struct osmo_sccp_user  contains 93 bytes in   2 blocks 
(ref 0) 0x60f09100
OsmoMSC-IuCS   contains 13 bytes in   1 
blocks (ref 0) 0x60b0001683f0
struct osmo_ss7_aspcontains   1099 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains365 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A-Iu)[0x61216d20] contains 47 
bytes in   1 blocks (ref 0) 0x60d27b30
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c465a0
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168600
struct osmo_fsm_inst   contains276 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b0001686b0
xua_default_lm(asp-clnt-OsmoMSC-A-Iu)[0x61217020] contains  
   54 bytes in   1 blocks (ref 0) 0x60e39e60
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c46660
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b000168760
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 blocks 
(ref 0) 0x60c46720
struct osmo_ss7_as contains607 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains362 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A-Iu)[0x61217320] contains 45 
bytes in   1 blocks (ref 0) 0x60d27c00
as-clnt-OsmoMSC-A-Iu   contains 21 bytes in   1 
blocks (ref 0) 0x60c46960
as-clnt-OsmoMSC-A-Iu   contains 21 bytes

Build failed in Jenkins: master-osmo-msc » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #7587

2018-12-19 Thread jenkins

See 


--
[...truncated 1.20 MB...]
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  iu rab-assign-addr-enc (x213|v4raw)
  asn1 debug (1|0)
  asn1 xer-print (1|0)
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6640 bytes in  53 blocks)
iu contains  2 bytes in   2 blocks (ref 0) 
0x60b000168550
asn1   contains  1 bytes in   1 blocks (ref 
0) 0x60b0001684a0
struct osmo_ss7_instance   contains   2509 bytes in  29 blocks (ref 0) 
0x6140a4a0
struct osmo_sccp_instance  contains359 bytes in   5 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f09010
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168340
struct osmo_sccp_user  contains 93 bytes in   2 blocks 
(ref 0) 0x60f09100
OsmoMSC-IuCS   contains 13 bytes in   1 
blocks (ref 0) 0x60b0001683f0
struct osmo_ss7_aspcontains   1099 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains365 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A-Iu)[0x61216d20] contains 47 
bytes in   1 blocks (ref 0) 0x60d27b30
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c465a0
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168600
struct osmo_fsm_inst   contains276 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b0001686b0
xua_default_lm(asp-clnt-OsmoMSC-A-Iu)[0x61217020] contains  
   54 bytes in   1 blocks (ref 0) 0x60e39e60
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c46660
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b000168760
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 blocks 
(ref 0) 0x60c46720
struct osmo_ss7_as contains607 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains362 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A-Iu)[0x61217320] contains 45 
bytes in   1 blocks (ref 0) 0x60d27c00
as-clnt-OsmoMSC-A-Iu   contains 21 bytes in   1 
blocks (ref 0) 0x60c46960
as-clnt-OsmoMSC-A-Iu   contains 21 bytes

Build failed in Jenkins: master-osmo-msc » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #7587

2018-12-19 Thread jenkins

See 


--
[...truncated 859.14 KB...]
  no stats reporter statsd
  stats reporter log
  no stats reporter log
  stats interval <1-65535>
  network
  msc
  mncc-int
  hlr
  smpp

OsmoMSC(config)# network

OsmoMSC(config-net)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6502 bytes in  49 blocks)
struct osmo_ss7_instance   contains   2389 bytes in  27 blocks (ref 0) 
0x6140a6a0
struct osmo_sccp_instance  contains266 bytes in   3 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f091f0
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016ab20
struct osmo_ss7_aspcontains   1084 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains359 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A)[0x61216d20] contains 44 
bytes in   1 blocks (ref 0) 0x60d27da0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46a20
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016abd0
struct osmo_fsm_inst   contains270 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b00016ac80
xua_default_lm(asp-clnt-OsmoMSC-A)[0x61217020] contains 
51 bytes in   1 blocks (ref 0) 0x60e3a1e0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46ae0
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b00016ad30
asp-clnt-OsmoMSC-A contains 19 bytes in   1 blocks 
(ref 0) 0x60c46ba0
struct osmo_ss7_as contains598 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains356 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A)[0x61217320] contains 42 bytes 
in   1 blocks (ref 0) 0x60d27e70
as-clnt-OsmoMSC-A  contains 18 bytes in   1 
blocks (ref 0) 0x60c46de0
as-clnt-OsmoMSC-A  contains 18 bytes in   1 blocks 
(ref 0) 0x60c46ea0
struct osmo_ss7_route_tablecontains145 bytes in   4 blocks (ref 
0) 0x60e3a3a0
struct osmo_ss7_route  contains 82 bytes in   2 blocks 
(ref 0) 0x60e3a2c0
as-clnt-OsmoMSC-A

Change in osmo-mgw[master]: mgcp_client: make domain part of endpoint configurable

2018-12-19 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12357 )

Change subject: mgcp_client: make domain part of endpoint configurable
..


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/#/c/12357/3/src/libosmo-mgcp-client/mgcp_client.c
File src/libosmo-mgcp-client/mgcp_client.c:

https://gerrit.osmocom.org/#/c/12357/3/src/libosmo-mgcp-client/mgcp_client.c@822
PS3, Line 822: name[0]?
Missing space.


https://gerrit.osmocom.org/#/c/12357/3/src/libosmo-mgcp-client/mgcp_client.c@830
PS3, Line 830: "rtpbridge/*@%s"
Oh, wow, this breaks Gerrit's syntax highlighting :D



--
To view, visit https://gerrit.osmocom.org/12357
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia662016f29dd8727d9c4626d726729641e21e1f8
Gerrit-Change-Number: 12357
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 20 Dec 2018 00:41:38 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-msc[master]: abort assignment on Assignment Failure

2018-12-19 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12368 )

Change subject: abort assignment on Assignment Failure
..


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/12368/4/src/libmsc/osmo_msc.c
File src/libmsc/osmo_msc.c:

https://gerrit.osmocom.org/#/c/12368/4/src/libmsc/osmo_msc.c@128
PS4, Line 128: rr_cause?
Missing space.



--
To view, visit https://gerrit.osmocom.org/12368
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I358cfbaf0f44f25148e8b9bafcb9257b1952b35a
Gerrit-Change-Number: 12368
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 20 Dec 2018 00:32:25 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmocore[master]: add LOGPFSMSL(), LOGPFSMSLSRC()

2018-12-19 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12386 )

Change subject: add LOGPFSMSL(), LOGPFSMSLSRC()
..


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/12386/1/include/osmocom/core/fsm.h
File include/osmocom/core/fsm.h:

https://gerrit.osmocom.org/#/c/12386/1/include/osmocom/core/fsm.h@122
PS1, Line 122: /*! Log using FSM instance's context, on explicit logging 
subsystem and level.
Same comments apply here. Both macros depend on other macros,
which defined below. Also, \ref and "format string".



--
To view, visit https://gerrit.osmocom.org/12386
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11b182a03f5ecb6df7cd8f260757d3626c8e945d
Gerrit-Change-Number: 12386
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 20 Dec 2018 00:30:35 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in libosmocore[master]: LOGPFSM*: guard against fi == NULL

2018-12-19 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12385 )

Change subject: LOGPFSM*: guard against fi == NULL
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12385/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12385/1//COMMIT_MSG@9
PS1, Line 9: they should guard against a NULL
Any reasons why should we tolerate NULL?



--
To view, visit https://gerrit.osmocom.org/12385
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eaf8b7e2cf1e450ae626cb2fc928862008f6233
Gerrit-Change-Number: 12385
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 20 Dec 2018 00:23:40 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Build failed in Jenkins: master-osmo-msc » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #7586

2018-12-19 Thread jenkins

See 


--
[...truncated 1.20 MB...]
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  iu rab-assign-addr-enc (x213|v4raw)
  asn1 debug (1|0)
  asn1 xer-print (1|0)
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6640 bytes in  53 blocks)
iu contains  2 bytes in   2 blocks (ref 0) 
0x60b000168550
asn1   contains  1 bytes in   1 blocks (ref 
0) 0x60b0001684a0
struct osmo_ss7_instance   contains   2509 bytes in  29 blocks (ref 0) 
0x6140a4a0
struct osmo_sccp_instance  contains359 bytes in   5 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f09010
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168340
struct osmo_sccp_user  contains 93 bytes in   2 blocks 
(ref 0) 0x60f09100
OsmoMSC-IuCS   contains 13 bytes in   1 
blocks (ref 0) 0x60b0001683f0
struct osmo_ss7_aspcontains   1099 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains365 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A-Iu)[0x61216d20] contains 47 
bytes in   1 blocks (ref 0) 0x60d27b30
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c465a0
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168600
struct osmo_fsm_inst   contains276 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b0001686b0
xua_default_lm(asp-clnt-OsmoMSC-A-Iu)[0x61217020] contains  
   54 bytes in   1 blocks (ref 0) 0x60e39e60
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c46660
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b000168760
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 blocks 
(ref 0) 0x60c46720
struct osmo_ss7_as contains607 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains362 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A-Iu)[0x61217320] contains 45 
bytes in   1 blocks (ref 0) 0x60d27c00
as-clnt-OsmoMSC-A-Iu   contains 21 bytes in   1 
blocks (ref 0) 0x60c46960
as-clnt-OsmoMSC-A-Iu   contains 21 bytes

Change in libosmocore[master]: add API doc for LOGPFSM* macros

2018-12-19 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12384 )

Change subject: add API doc for LOGPFSM* macros
..


Patch Set 1: Code-Review+1

(3 comments)

This is exactly what I was thinking about while reading previous
change - comments! Looks fine, my comments are not critical.

https://gerrit.osmocom.org/#/c/12384/1/include/osmocom/core/fsm.h
File include/osmocom/core/fsm.h:

https://gerrit.osmocom.org/#/c/12384/1/include/osmocom/core/fsm.h@123
PS1, Line 123: osmo_fsm_inst
\ref


https://gerrit.osmocom.org/#/c/12384/1/include/osmocom/core/fsm.h@125
PS1, Line 125: string format
"format string" is more common term I think


https://gerrit.osmocom.org/#/c/12384/1/include/osmocom/core/fsm.h@126
PS1, Line 126: String format
same



--
To view, visit https://gerrit.osmocom.org/12384
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf6500889aa58195f50a726dec0876c0c2baec3
Gerrit-Change-Number: 12384
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 20 Dec 2018 00:20:45 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-osmo-msc » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #7586

2018-12-19 Thread jenkins

See 


--
[...truncated 860.11 KB...]
  no stats reporter statsd
  stats reporter log
  no stats reporter log
  stats interval <1-65535>
  network
  msc
  mncc-int
  hlr
  smpp

OsmoMSC(config)# network

OsmoMSC(config-net)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6502 bytes in  49 blocks)
struct osmo_ss7_instance   contains   2389 bytes in  27 blocks (ref 0) 
0x6140a6a0
struct osmo_sccp_instance  contains266 bytes in   3 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f091f0
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016ab20
struct osmo_ss7_aspcontains   1084 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains359 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A)[0x61216d20] contains 44 
bytes in   1 blocks (ref 0) 0x60d27da0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46a20
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016abd0
struct osmo_fsm_inst   contains270 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b00016ac80
xua_default_lm(asp-clnt-OsmoMSC-A)[0x61217020] contains 
51 bytes in   1 blocks (ref 0) 0x60e3a1e0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46ae0
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b00016ad30
asp-clnt-OsmoMSC-A contains 19 bytes in   1 blocks 
(ref 0) 0x60c46ba0
struct osmo_ss7_as contains598 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains356 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A)[0x61217320] contains 42 bytes 
in   1 blocks (ref 0) 0x60d27e70
as-clnt-OsmoMSC-A  contains 18 bytes in   1 
blocks (ref 0) 0x60c46de0
as-clnt-OsmoMSC-A  contains 18 bytes in   1 blocks 
(ref 0) 0x60c46ea0
struct osmo_ss7_route_tablecontains145 bytes in   4 blocks (ref 
0) 0x60e3a3a0
struct osmo_ss7_route  contains 82 bytes in   2 blocks 
(ref 0) 0x60e3a2c0
as-clnt-OsmoMSC-A

Build failed in Jenkins: master-osmo-msc » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #7585

2018-12-19 Thread jenkins

See 


--
[...truncated 1.10 MB...]
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  iu rab-assign-addr-enc (x213|v4raw)
  asn1 debug (1|0)
  asn1 xer-print (1|0)
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6640 bytes in  53 blocks)
iu contains  2 bytes in   2 blocks (ref 0) 
0x60b000168550
asn1   contains  1 bytes in   1 blocks (ref 
0) 0x60b0001684a0
struct osmo_ss7_instance   contains   2509 bytes in  29 blocks (ref 0) 
0x6140a4a0
struct osmo_sccp_instance  contains359 bytes in   5 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f09010
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168340
struct osmo_sccp_user  contains 93 bytes in   2 blocks 
(ref 0) 0x60f09100
OsmoMSC-IuCS   contains 13 bytes in   1 
blocks (ref 0) 0x60b0001683f0
struct osmo_ss7_aspcontains   1099 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains365 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A-Iu)[0x61216d20] contains 47 
bytes in   1 blocks (ref 0) 0x60d27b30
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c465a0
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168600
struct osmo_fsm_inst   contains276 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b0001686b0
xua_default_lm(asp-clnt-OsmoMSC-A-Iu)[0x61217020] contains  
   54 bytes in   1 blocks (ref 0) 0x60e39e60
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c46660
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b000168760
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 blocks 
(ref 0) 0x60c46720
struct osmo_ss7_as contains607 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains362 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A-Iu)[0x61217320] contains 45 
bytes in   1 blocks (ref 0) 0x60d27c00
as-clnt-OsmoMSC-A-Iu   contains 21 bytes in   1 
blocks (ref 0) 0x60c46960
as-clnt-OsmoMSC-A-Iu   contains 21 bytes

Jenkins build is back to normal : master-osmo-iuh » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #2707

2018-12-19 Thread jenkins

See

Build failed in Jenkins: master-osmo-msc » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #7585

2018-12-19 Thread jenkins

See 


--
[...truncated 828.66 KB...]
  no stats reporter statsd
  stats reporter log
  no stats reporter log
  stats interval <1-65535>
  network
  msc
  mncc-int
  hlr
  smpp

OsmoMSC(config)# network

OsmoMSC(config-net)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6502 bytes in  49 blocks)
struct osmo_ss7_instance   contains   2389 bytes in  27 blocks (ref 0) 
0x6140a6a0
struct osmo_sccp_instance  contains266 bytes in   3 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f091f0
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016ab20
struct osmo_ss7_aspcontains   1084 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains359 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A)[0x61216d20] contains 44 
bytes in   1 blocks (ref 0) 0x60d27da0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46a20
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016abd0
struct osmo_fsm_inst   contains270 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b00016ac80
xua_default_lm(asp-clnt-OsmoMSC-A)[0x61217020] contains 
51 bytes in   1 blocks (ref 0) 0x60e3a1e0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46ae0
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b00016ad30
asp-clnt-OsmoMSC-A contains 19 bytes in   1 blocks 
(ref 0) 0x60c46ba0
struct osmo_ss7_as contains598 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains356 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A)[0x61217320] contains 42 bytes 
in   1 blocks (ref 0) 0x60d27e70
as-clnt-OsmoMSC-A  contains 18 bytes in   1 
blocks (ref 0) 0x60c46de0
as-clnt-OsmoMSC-A  contains 18 bytes in   1 blocks 
(ref 0) 0x60c46ea0
struct osmo_ss7_route_tablecontains145 bytes in   4 blocks (ref 
0) 0x60e3a3a0
struct osmo_ss7_route  contains 82 bytes in   2 blocks 
(ref 0) 0x60e3a2c0
as-clnt-OsmoMSC-A

Build failed in Jenkins: master-osmo-msc » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #7584

2018-12-19 Thread jenkins

See 


--
[...truncated 1.10 MB...]
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  iu rab-assign-addr-enc (x213|v4raw)
  asn1 debug (1|0)
  asn1 xer-print (1|0)
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6640 bytes in  53 blocks)
iu contains  2 bytes in   2 blocks (ref 0) 
0x60b000168550
asn1   contains  1 bytes in   1 blocks (ref 
0) 0x60b0001684a0
struct osmo_ss7_instance   contains   2509 bytes in  29 blocks (ref 0) 
0x6140a4a0
struct osmo_sccp_instance  contains359 bytes in   5 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f09010
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168340
struct osmo_sccp_user  contains 93 bytes in   2 blocks 
(ref 0) 0x60f09100
OsmoMSC-IuCS   contains 13 bytes in   1 
blocks (ref 0) 0x60b0001683f0
struct osmo_ss7_aspcontains   1099 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains365 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A-Iu)[0x61216d20] contains 47 
bytes in   1 blocks (ref 0) 0x60d27b30
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c465a0
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168600
struct osmo_fsm_inst   contains276 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b0001686b0
xua_default_lm(asp-clnt-OsmoMSC-A-Iu)[0x61217020] contains  
   54 bytes in   1 blocks (ref 0) 0x60e39e60
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c46660
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b000168760
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 blocks 
(ref 0) 0x60c46720
struct osmo_ss7_as contains607 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains362 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A-Iu)[0x61217320] contains 45 
bytes in   1 blocks (ref 0) 0x60d27c00
as-clnt-OsmoMSC-A-Iu   contains 21 bytes in   1 
blocks (ref 0) 0x60c46960
as-clnt-OsmoMSC-A-Iu   contains 21 bytes

Build failed in Jenkins: master-osmo-msc » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #7584

2018-12-19 Thread jenkins

See 


--
[...truncated 859.61 KB...]
  no stats reporter statsd
  stats reporter log
  no stats reporter log
  stats interval <1-65535>
  network
  msc
  mncc-int
  hlr
  smpp

OsmoMSC(config)# network

OsmoMSC(config-net)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6502 bytes in  49 blocks)
struct osmo_ss7_instance   contains   2389 bytes in  27 blocks (ref 0) 
0x6140a6a0
struct osmo_sccp_instance  contains266 bytes in   3 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f091f0
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016ab20
struct osmo_ss7_aspcontains   1084 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains359 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A)[0x61216d20] contains 44 
bytes in   1 blocks (ref 0) 0x60d27da0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46a20
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016abd0
struct osmo_fsm_inst   contains270 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b00016ac80
xua_default_lm(asp-clnt-OsmoMSC-A)[0x61217020] contains 
51 bytes in   1 blocks (ref 0) 0x60e3a1e0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46ae0
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b00016ad30
asp-clnt-OsmoMSC-A contains 19 bytes in   1 blocks 
(ref 0) 0x60c46ba0
struct osmo_ss7_as contains598 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains356 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A)[0x61217320] contains 42 bytes 
in   1 blocks (ref 0) 0x60d27e70
as-clnt-OsmoMSC-A  contains 18 bytes in   1 
blocks (ref 0) 0x60c46de0
as-clnt-OsmoMSC-A  contains 18 bytes in   1 blocks 
(ref 0) 0x60c46ea0
struct osmo_ss7_route_tablecontains145 bytes in   4 blocks (ref 
0) 0x60e3a3a0
struct osmo_ss7_route  contains 82 bytes in   2 blocks 
(ref 0) 0x60e3a2c0
as-clnt-OsmoMSC-A

Jenkins build is back to normal : master-osmo-bts » sysmo,femtobts_v2.7,1,default,osmocom-master-debian9 #1577

2018-12-19 Thread jenkins

See

Change in libosmocore[master]: define LOGPFSM fmt only once, in LOGPFSMLSRC

2018-12-19 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12383 )

Change subject: define LOGPFSM fmt only once, in LOGPFSMLSRC
..


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/12383/1/include/osmocom/core/fsm.h
File include/osmocom/core/fsm.h:

https://gerrit.osmocom.org/#/c/12383/1/include/osmocom/core/fsm.h@122
PS1, Line 122: LOGPFSML
Maybe rather place it between LOGPFSMLSRC and LOGPFSM?
Not mandatory, but would look cleaner.



--
To view, visit https://gerrit.osmocom.org/12383
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f23c57ebfdb5355919c06ac5ded7732e3b17a97
Gerrit-Change-Number: 12383
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 20 Dec 2018 00:02:17 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-osmo-msc » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #7583

2018-12-19 Thread jenkins

See 


--
[...truncated 1.20 MB...]
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  iu rab-assign-addr-enc (x213|v4raw)
  asn1 debug (1|0)
  asn1 xer-print (1|0)
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6640 bytes in  53 blocks)
iu contains  2 bytes in   2 blocks (ref 0) 
0x60b000168550
asn1   contains  1 bytes in   1 blocks (ref 
0) 0x60b0001684a0
struct osmo_ss7_instance   contains   2509 bytes in  29 blocks (ref 0) 
0x6140a4a0
struct osmo_sccp_instance  contains359 bytes in   5 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f09010
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168340
struct osmo_sccp_user  contains 93 bytes in   2 blocks 
(ref 0) 0x60f09100
OsmoMSC-IuCS   contains 13 bytes in   1 
blocks (ref 0) 0x60b0001683f0
struct osmo_ss7_aspcontains   1099 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains365 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A-Iu)[0x61216d20] contains 47 
bytes in   1 blocks (ref 0) 0x60d27b30
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c465a0
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168600
struct osmo_fsm_inst   contains276 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b0001686b0
xua_default_lm(asp-clnt-OsmoMSC-A-Iu)[0x61217020] contains  
   54 bytes in   1 blocks (ref 0) 0x60e39e60
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c46660
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b000168760
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 blocks 
(ref 0) 0x60c46720
struct osmo_ss7_as contains607 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains362 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A-Iu)[0x61217320] contains 45 
bytes in   1 blocks (ref 0) 0x60d27c00
as-clnt-OsmoMSC-A-Iu   contains 21 bytes in   1 
blocks (ref 0) 0x60c46960
as-clnt-OsmoMSC-A-Iu   contains 21 bytes

Build failed in Jenkins: master-osmo-msc » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #7583

2018-12-19 Thread jenkins

See 


--
[...truncated 857.41 KB...]
  no stats reporter statsd
  stats reporter log
  no stats reporter log
  stats interval <1-65535>
  network
  msc
  mncc-int
  hlr
  smpp

OsmoMSC(config)# network

OsmoMSC(config-net)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6502 bytes in  49 blocks)
struct osmo_ss7_instance   contains   2389 bytes in  27 blocks (ref 0) 
0x6140a6a0
struct osmo_sccp_instance  contains266 bytes in   3 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f091f0
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016ab20
struct osmo_ss7_aspcontains   1084 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains359 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A)[0x61216d20] contains 44 
bytes in   1 blocks (ref 0) 0x60d27da0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46a20
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016abd0
struct osmo_fsm_inst   contains270 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b00016ac80
xua_default_lm(asp-clnt-OsmoMSC-A)[0x61217020] contains 
51 bytes in   1 blocks (ref 0) 0x60e3a1e0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46ae0
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b00016ad30
asp-clnt-OsmoMSC-A contains 19 bytes in   1 blocks 
(ref 0) 0x60c46ba0
struct osmo_ss7_as contains598 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains356 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A)[0x61217320] contains 42 bytes 
in   1 blocks (ref 0) 0x60d27e70
as-clnt-OsmoMSC-A  contains 18 bytes in   1 
blocks (ref 0) 0x60c46de0
as-clnt-OsmoMSC-A  contains 18 bytes in   1 blocks 
(ref 0) 0x60c46ea0
struct osmo_ss7_route_tablecontains145 bytes in   4 blocks (ref 
0) 0x60e3a3a0
struct osmo_ss7_route  contains 82 bytes in   2 blocks 
(ref 0) 0x60e3a2c0
as-clnt-OsmoMSC-A

Change in osmo-mgw[master]: mgcp_client: make domain part of endpoint configurable

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has removed a vote on this change.

Change subject: mgcp_client: make domain part of endpoint configurable
..


Removed Code-Review-1 by Max 
--
To view, visit https://gerrit.osmocom.org/12357
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia662016f29dd8727d9c4626d726729641e21e1f8
Gerrit-Change-Number: 12357
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr

Change in osmo-mgw[master]: mgcp_client: make domain part of endpoint configurable

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12357 )

Change subject: mgcp_client: make domain part of endpoint configurable
..


Patch Set 3:

I'm going to remove that -1 because I think it is not actual code review 
related to this patch, more like a general question on how our MGCP works.


--
To view, visit https://gerrit.osmocom.org/12357
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia662016f29dd8727d9c4626d726729641e21e1f8
Gerrit-Change-Number: 12357
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 19 Dec 2018 23:56:34 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: vty cfg: move 'ipa-name' from 'msc' to 'hlr' section

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/12387


Change subject: vty cfg: move 'ipa-name' from 'msc' to 'hlr' section
..

vty cfg: move 'ipa-name' from 'msc' to 'hlr' section

during code review, I completely overlooked this:

We've added the 'ipa-name', which identifies the MSC on the GSUP link to the
HLR, under the 'msc' section, while all other GSUP/HLR related config is under
the 'hlr' section.

Before we roll that out in a release, move it over to 'hlr'.

Change-Id: I1a572865aa90c5fa43c6f57282a6e2b06776e425
---
M src/libmsc/msc_vty.c
1 file changed, 21 insertions(+), 22 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/87/12387/1

diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index c5d2832..bb57d65 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -458,24 +458,6 @@
return CMD_SUCCESS;
 }

-DEFUN(cfg_msc_ipa_name,
-  cfg_msc_ipa_name_cmd,
-  "ipa-name NAME",
-  "Set the IPA name of this MSC\n"
-  "A unique name for this MSC. For example: PLMN + redundancy server 
number: MSC-901-70-0. "
-  "This name is used for GSUP routing and must be set if more than one MSC 
is connected to the HLR. "
-  "The default is 'MSC-00-00-00-00-00-00'.\n")
-{
-   if (!msc_parsing_config_file) {
-   vty_out(vty, "The IPA name cannot be changed at run-time; "
-   "It can only be set in the configuraton file.%s", 
VTY_NEWLINE);
-   return CMD_WARNING;
-   }
-
-   gsmnet->msc_ipa_name = talloc_strdup(gsmnet, argv[0]);
-   return CMD_SUCCESS;
-}
-
 static int config_write_msc(struct vty *vty)
 {
vty_out(vty, "msc%s", VTY_NEWLINE);
@@ -509,9 +491,6 @@
gsmnet->emergency.route_to_msisdn, VTY_NEWLINE);
}

-   if (gsmnet->msc_ipa_name)
-   vty_out(vty, " ipa-name %s%s", gsmnet->msc_ipa_name, 
VTY_NEWLINE);
-
mgcp_client_config_write(vty, " ");
 #ifdef BUILD_IU
ranap_iu_vty_config_write(vty, " ");
@@ -1485,6 +1464,24 @@
return CMD_SUCCESS;
 }

+DEFUN(cfg_hlr_ipa_name,
+  cfg_hlr_ipa_name_cmd,
+  "ipa-name NAME",
+  "Set the IPA name of this MSC\n"
+  "A unique name for this MSC. For example: PLMN + redundancy server 
number: MSC-901-70-0. "
+  "This name is used for GSUP routing and must be set if more than one MSC 
is connected to the HLR. "
+  "The default is 'MSC-00-00-00-00-00-00'.\n")
+{
+   if (!msc_parsing_config_file) {
+   vty_out(vty, "The IPA name cannot be changed at run-time; "
+   "It can only be set in the configuraton file.%s", 
VTY_NEWLINE);
+   return CMD_WARNING;
+   }
+
+   gsmnet->msc_ipa_name = talloc_strdup(gsmnet, argv[0]);
+   return CMD_SUCCESS;
+}
+
 static int config_write_hlr(struct vty *vty)
 {
vty_out(vty, "hlr%s", VTY_NEWLINE);
@@ -1492,6 +1489,8 @@
gsmnet->gsup_server_addr_str, VTY_NEWLINE);
vty_out(vty, " remote-port %u%s",
gsmnet->gsup_server_port, VTY_NEWLINE);
+   if (gsmnet->msc_ipa_name)
+   vty_out(vty, " ipa-name %s%s", gsmnet->msc_ipa_name, 
VTY_NEWLINE);
return CMD_SUCCESS;
 }

@@ -1532,7 +1531,6 @@
install_element(MSC_NODE, _msc_cs7_instance_iu_cmd);
install_element(MSC_NODE, _msc_paging_response_timer_cmd);
install_element(MSC_NODE, _msc_emergency_msisdn_cmd);
-   install_element(MSC_NODE, _msc_ipa_name_cmd);

mgcp_client_vty_init(msc_network, MSC_NODE, _network->mgw.conf);
 #ifdef BUILD_IU
@@ -1582,4 +1580,5 @@
install_node(_node, config_write_hlr);
install_element(HLR_NODE, _hlr_remote_ip_cmd);
install_element(HLR_NODE, _hlr_remote_port_cmd);
+   install_element(HLR_NODE, _hlr_ipa_name_cmd);
 }

--
To view, visit https://gerrit.osmocom.org/12387
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a572865aa90c5fa43c6f57282a6e2b06776e425
Gerrit-Change-Number: 12387
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr

Change in osmo-msc[master]: abort assignment on Assignment Failure

2018-12-19 Thread Neels Hofmeyr

Hello Vadim Yanitskiy, Pau Espin Pedrol, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12368

to look at the new patch set (#4).

Change subject: abort assignment on Assignment Failure
..

abort assignment on Assignment Failure

If Assignment fails in the BSC, trigger an EV_TEARDOWN_ERROR in the mgcp_ctx
FSM instance, so that the call gets torn down immediately. Before this, the
non-call would idle around without anything happening.

Related: OS#3236
Depends: I11b182a03f5ecb6df7cd8f260757d3626c8e945d (libosmocore)
Change-Id: I358cfbaf0f44f25148e8b9bafcb9257b1952b35a
---
M include/osmocom/msc/msc_mgcp.h
M src/libmsc/msc_mgcp.c
M src/libmsc/osmo_msc.c
3 files changed, 21 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/68/12368/4
--
To view, visit https://gerrit.osmocom.org/12368
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I358cfbaf0f44f25148e8b9bafcb9257b1952b35a
Gerrit-Change-Number: 12368
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-msc[master]: abort assignment on Assignment Failure

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12368 )

Change subject: abort assignment on Assignment Failure
..


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/12368/3/src/libmsc/msc_mgcp.c
File src/libmsc/msc_mgcp.c:

https://gerrit.osmocom.org/#/c/12368/3/src/libmsc/msc_mgcp.c@1085
PS3, Line 1085: conn->fi->id);
> > Maybe we also need LOGPFSMSL(FI, SUBSYS, LEVEL, fmt, args)? […]
https://gerrit.osmocom.org/c/libosmocore/+/12386



--
To view, visit https://gerrit.osmocom.org/12368
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I358cfbaf0f44f25148e8b9bafcb9257b1952b35a
Gerrit-Change-Number: 12368
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 19 Dec 2018 23:24:14 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmocore[master]: add API doc for LOGPFSM* macros

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/12384


Change subject: add API doc for LOGPFSM* macros
..

add API doc for LOGPFSM* macros

Change-Id: I3bf6500889aa58195f50a726dec0876c0c2baec3
---
M include/osmocom/core/fsm.h
1 file changed, 31 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/12384/1

diff --git a/include/osmocom/core/fsm.h b/include/osmocom/core/fsm.h
index ee71451..0b02e9a 100644
--- a/include/osmocom/core/fsm.h
+++ b/include/osmocom/core/fsm.h
@@ -119,9 +119,24 @@

 void osmo_fsm_log_addr(bool log_addr);

+/*! Log using FSM instance's context, on explicit logging level.
+ * \param fi  An osmo_fsm_inst.
+ * \param level  A logging level, e.g. LOGL_INFO.
+ * \param fmt  printf-like string format.
+ * \param args  String format arguments.
+ */
 #define LOGPFSML(fi, level, fmt, args...) \
LOGPFSMLSRC(fi, level, __FILE__, __LINE__, fmt, ## args)

+/*! Log using FSM instance's context, on explicit logging level, and with 
explicit source file and line info.
+ * The log subsystem to log on is obtained from the underlying FSM definition.
+ * \param fi  An osmo_fsm_inst.
+ * \param level  A logging level, e.g. LOGL_INFO.
+ * \param caller_file  A string constant containing a source file path, like 
__FILE__.
+ * \param caller_line  A number constant containing a source file line, like 
__LINE__.
+ * \param fmt  printf-like string format.
+ * \param args  String format arguments.
+ */
 #define LOGPFSMLSRC(fi, level, caller_file, caller_line, fmt, args...) \
LOGPSRC((fi)->fsm->log_subsys, level, \
caller_file, caller_line, \
@@ -130,9 +145,25 @@
osmo_fsm_state_name((fi)->fsm, (fi)->state), \
## args)

+/*! Log using FSM instance's context.
+ * The log level to log on is obtained from the FSM instance.
+ * The log subsystem to log on is obtained from the underlying FSM definition.
+ * \param fi  An osmo_fsm_inst.
+ * \param fmt  printf-like string format.
+ * \param args  String format arguments.
+ */
 #define LOGPFSM(fi, fmt, args...) \
LOGPFSML(fi, (fi)->log_level, fmt, ## args)

+/*! Log using FSM instance's context, with explicit source file and line info.
+ * The log level to log on is obtained from the FSM instance.
+ * The log subsystem to log on is obtained from the underlying FSM definition.
+ * \param fi  An osmo_fsm_inst.
+ * \param caller_file  A string constant containing a source file path, like 
__FILE__.
+ * \param caller_line  A number constant containing a source file line, like 
__LINE__.
+ * \param fmt  printf-like string format.
+ * \param args  String format arguments.
+ */
 #define LOGPFSMSRC(fi, caller_file, caller_line, fmt, args...) \
LOGPFSMLSRC(fi, (fi)->log_level, \
caller_file, caller_line, \

--
To view, visit https://gerrit.osmocom.org/12384
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3bf6500889aa58195f50a726dec0876c0c2baec3
Gerrit-Change-Number: 12384
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr

Change in libosmocore[master]: define LOGPFSM fmt only once, in LOGPFSMLSRC

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/12383


Change subject: define LOGPFSM fmt only once, in LOGPFSMLSRC
..

define LOGPFSM fmt only once, in LOGPFSMLSRC

Instead of duplicating the fmt and args in LOGPFSML and LOGPFSMLSRC, rather
make LOGPFSML invoke LOGPFSMLSRC with __FILE__ and __LINE__.

This is a cosmetic preparation for more tweaks coming up.

Change-Id: I2f23c57ebfdb5355919c06ac5ded7732e3b17a97
---
M include/osmocom/core/fsm.h
1 file changed, 4 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/83/12383/1

diff --git a/include/osmocom/core/fsm.h b/include/osmocom/core/fsm.h
index 54bbad5..ee71451 100644
--- a/include/osmocom/core/fsm.h
+++ b/include/osmocom/core/fsm.h
@@ -120,13 +120,7 @@
 void osmo_fsm_log_addr(bool log_addr);

 #define LOGPFSML(fi, level, fmt, args...) \
-   LOGP((fi)->fsm->log_subsys, OSMO_MAX(level, (fi)->log_level), \
-   "%s{%s}: " fmt, \
-   osmo_fsm_inst_name(fi), \
-   osmo_fsm_state_name((fi)->fsm, (fi)->state), ## args)
-
-#define LOGPFSM(fi, fmt, args...) \
-   LOGPFSML(fi, (fi)->log_level, fmt, ## args)
+   LOGPFSMLSRC(fi, level, __FILE__, __LINE__, fmt, ## args)

 #define LOGPFSMLSRC(fi, level, caller_file, caller_line, fmt, args...) \
LOGPSRC((fi)->fsm->log_subsys, level, \
@@ -136,6 +130,9 @@
osmo_fsm_state_name((fi)->fsm, (fi)->state), \
## args)

+#define LOGPFSM(fi, fmt, args...) \
+   LOGPFSML(fi, (fi)->log_level, fmt, ## args)
+
 #define LOGPFSMSRC(fi, caller_file, caller_line, fmt, args...) \
LOGPFSMLSRC(fi, (fi)->log_level, \
caller_file, caller_line, \

--
To view, visit https://gerrit.osmocom.org/12383
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f23c57ebfdb5355919c06ac5ded7732e3b17a97
Gerrit-Change-Number: 12383
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr

Change in libosmocore[master]: LOGPFSM*: guard against fi == NULL

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/12385


Change subject: LOGPFSM*: guard against fi == NULL
..

LOGPFSM*: guard against fi == NULL

The LOGPFSM macros are in such wide use that they should guard against a NULL
fi pointer. In case of NULL, default to subsys = DLGLOBAL, loglevel =
LOGL_ERROR and state = "fi=NULL".

Change-Id: I9eaf8b7e2cf1e450ae626cb2fc928862008f6233
---
M include/osmocom/core/fsm.h
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/85/12385/1

diff --git a/include/osmocom/core/fsm.h b/include/osmocom/core/fsm.h
index 0b02e9a..5b43e56 100644
--- a/include/osmocom/core/fsm.h
+++ b/include/osmocom/core/fsm.h
@@ -138,11 +138,11 @@
  * \param args  String format arguments.
  */
 #define LOGPFSMLSRC(fi, level, caller_file, caller_line, fmt, args...) \
-   LOGPSRC((fi)->fsm->log_subsys, level, \
+   LOGPSRC((fi) ? (fi)->fsm->log_subsys : DLGLOBAL, level, \
caller_file, caller_line, \
"%s{%s}: " fmt, \
osmo_fsm_inst_name(fi), \
-   osmo_fsm_state_name((fi)->fsm, (fi)->state), \
+   (fi) ? osmo_fsm_state_name((fi)->fsm, (fi)->state) : 
"fi=NULL", \
## args)

 /*! Log using FSM instance's context.
@@ -153,7 +153,7 @@
  * \param args  String format arguments.
  */
 #define LOGPFSM(fi, fmt, args...) \
-   LOGPFSML(fi, (fi)->log_level, fmt, ## args)
+   LOGPFSML(fi, (fi) ? (fi)->log_level : LOGL_ERROR, fmt, ## args)

 /*! Log using FSM instance's context, with explicit source file and line info.
  * The log level to log on is obtained from the FSM instance.
@@ -165,7 +165,7 @@
  * \param args  String format arguments.
  */
 #define LOGPFSMSRC(fi, caller_file, caller_line, fmt, args...) \
-   LOGPFSMLSRC(fi, (fi)->log_level, \
+   LOGPFSMLSRC(fi, (fi) ? (fi)->log_level : LOGL_ERROR, \
caller_file, caller_line, \
fmt, ## args)


--
To view, visit https://gerrit.osmocom.org/12385
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9eaf8b7e2cf1e450ae626cb2fc928862008f6233
Gerrit-Change-Number: 12385
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr

Change in libosmocore[master]: add LOGPFSMSL(), LOGPFSMSLSRC()

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/12386


Change subject: add LOGPFSMSL(), LOGPFSMSLSRC()
..

add LOGPFSMSL(), LOGPFSMSLSRC()

Using an FSM instace's logging context is very useful. Sometimes it makes sense
to log something on a different logging category than the FSM definition's
default category.

For example, an MSC conn has aspects concerning MM, CC, RR, MGCP, ..., and
currently all of those log on DMM.

This came up in I358cfbaf0f44f25148e8b9bafcb9257b1952b35a, where I want to log
an MGCP event using a ran_conn context, and used the conn->fi->id. That of
course omits context like the current conn FSM state...

I remember at least one other place where I recently added logging using some
fi->id as context, so it might turn out useful in various places.

Change-Id: I11b182a03f5ecb6df7cd8f260757d3626c8e945d
---
M include/osmocom/core/fsm.h
1 file changed, 30 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/86/12386/1

diff --git a/include/osmocom/core/fsm.h b/include/osmocom/core/fsm.h
index 5b43e56..3c35c20 100644
--- a/include/osmocom/core/fsm.h
+++ b/include/osmocom/core/fsm.h
@@ -119,6 +119,34 @@

 void osmo_fsm_log_addr(bool log_addr);

+/*! Log using FSM instance's context, on explicit logging subsystem and level.
+ * \param fi  An osmo_fsm_inst.
+ * \param subsys  A logging subsystem, e.g. DLGLOBAL.
+ * \param level  A logging level, e.g. LOGL_INFO.
+ * \param fmt  printf-like string format.
+ * \param args  String format arguments.
+ */
+#define LOGPFSMSL(fi, subsys, level, fmt, args...) \
+   LOGPFSMSLSRC(fi, subsys, level, __FILE__, __LINE__, fmt, ## 
args)
+
+/*! Log using FSM instance's context, on explicit logging subsystem and level,
+ * and passing explicit source file and line information.
+ * \param fi  An osmo_fsm_inst.
+ * \param subsys  A logging subsystem, e.g. DLGLOBAL.
+ * \param level  A logging level, e.g. LOGL_INFO.
+ * \param caller_file  A string constant containing a source file path, like 
__FILE__.
+ * \param caller_line  A number constant containing a source file line, like 
__LINE__.
+ * \param fmt  printf-like string format.
+ * \param args  String format arguments.
+ */
+#define LOGPFSMSLSRC(fi, subsys, level, caller_file, caller_line, fmt, 
args...) \
+   LOGPSRC(subsys, level, \
+   caller_file, caller_line, \
+   "%s{%s}: " fmt, \
+   osmo_fsm_inst_name(fi), \
+   (fi) ? osmo_fsm_state_name((fi)->fsm, (fi)->state) : 
"fi=NULL", ## args)
+
+
 /*! Log using FSM instance's context, on explicit logging level.
  * \param fi  An osmo_fsm_inst.
  * \param level  A logging level, e.g. LOGL_INFO.
@@ -138,12 +166,8 @@
  * \param args  String format arguments.
  */
 #define LOGPFSMLSRC(fi, level, caller_file, caller_line, fmt, args...) \
-   LOGPSRC((fi) ? (fi)->fsm->log_subsys : DLGLOBAL, level, \
-   caller_file, caller_line, \
-   "%s{%s}: " fmt, \
-   osmo_fsm_inst_name(fi), \
-   (fi) ? osmo_fsm_state_name((fi)->fsm, (fi)->state) : 
"fi=NULL", \
-   ## args)
+   LOGPFSMSLSRC(fi, (fi) ? (fi)->fsm->log_subsys : DLGLOBAL, 
level, \
+caller_file, caller_line, fmt, ## args)

 /*! Log using FSM instance's context.
  * The log level to log on is obtained from the FSM instance.

--
To view, visit https://gerrit.osmocom.org/12386
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11b182a03f5ecb6df7cd8f260757d3626c8e945d
Gerrit-Change-Number: 12386
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr

Build failed in Jenkins: master-osmo-bts » sysmo,femtobts_v2.7,1,default,osmocom-master-debian9 #1576

2018-12-19 Thread jenkins

See 


--
[...truncated 54.07 KB...]
  CC   timer_gettimeofday.lo
  CC   select.lo
  CC   timer_clockgettime.lo
  CC   timer.lo
  CC   signal.lo
  CC   bits.lo
  CC   msgb.lo
  CC   bitvec.lo
  CC   bitcomp.lo
  CC   counter.lo
  CC   fsm.lo
  CC   write_queue.lo
  CC   utils.lo
  CC   socket.lo
  CC   logging.lo
  CC   logging_syslog.lo
  CC   logging_gsmtap.lo
  CC   rate_ctr.lo
  CC   gsmtap_util.lo
  CC   crc16.lo
  CC   panic.lo
  CC   backtrace.lo
  CC   conv.lo
  CC   application.lo
  CC   rbtree.lo
  CC   strrb.lo
  CC   loggingrb.lo
  CC   crc8gen.lo
  CC   crc16gen.lo
  CC   crc32gen.lo
  CC   crc64gen.lo
  CC   macaddr.lo
  CC   stats.lo
  CC   stat_item.lo
  CC   stats_statsd.lo
  CC   prim.lo
  CC   conv_acc_generic.lo
  CC   conv_acc.lo
  CC   sercomm.lo
  CC   prbs.lo
  CC   conv_acc_sse.lo
  CC   isdnhdlc.lo
  CC   conv_acc_sse_avx.lo
  CC   plugin.lo
  CC   msgfile.lo
  CC   serial.lo
  CCLD libosmocore.la
make[4]: Entering directory 
'
make[4]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p 
'
 /bin/bash ../libtool   --mode=install /usr/bin/install -c   libosmocore.la 
'
libtool: install: /usr/bin/install -c .libs/libosmocore.so.11.0.0 

libtool: install: (cd 

 && { ln -s -f libosmocore.so.11.0.0 libosmocore.so.11 || { rm -f 
libosmocore.so.11 && ln -s libosmocore.so.11.0.0 libosmocore.so.11; }; })
libtool: install: (cd 

 && { ln -s -f libosmocore.so.11.0.0 libosmocore.so || { rm -f libosmocore.so 
&& ln -s libosmocore.so.11.0.0 libosmocore.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocore.lai 

libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/sbin" 
ldconfig -n 

--
Libraries have been installed in:
   


If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the '-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the 'LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the 'LD_RUN_PATH' environment variable
 during linking
   - use the '-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to '/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[4]: Leaving directory 
'
make[3]: Leaving directory

Build failed in Jenkins: master-osmo-msc » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #7582

2018-12-19 Thread jenkins

See 


--
[...truncated 1.20 MB...]
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  iu rab-assign-addr-enc (x213|v4raw)
  asn1 debug (1|0)
  asn1 xer-print (1|0)
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6640 bytes in  53 blocks)
iu contains  2 bytes in   2 blocks (ref 0) 
0x60b000168550
asn1   contains  1 bytes in   1 blocks (ref 
0) 0x60b0001684a0
struct osmo_ss7_instance   contains   2509 bytes in  29 blocks (ref 0) 
0x6140a4a0
struct osmo_sccp_instance  contains359 bytes in   5 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f09010
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168340
struct osmo_sccp_user  contains 93 bytes in   2 blocks 
(ref 0) 0x60f09100
OsmoMSC-IuCS   contains 13 bytes in   1 
blocks (ref 0) 0x60b0001683f0
struct osmo_ss7_aspcontains   1099 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains365 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A-Iu)[0x61216d20] contains 47 
bytes in   1 blocks (ref 0) 0x60d27b30
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c465a0
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168600
struct osmo_fsm_inst   contains276 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b0001686b0
xua_default_lm(asp-clnt-OsmoMSC-A-Iu)[0x61217020] contains  
   54 bytes in   1 blocks (ref 0) 0x60e39e60
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c46660
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b000168760
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 blocks 
(ref 0) 0x60c46720
struct osmo_ss7_as contains607 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains362 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A-Iu)[0x61217320] contains 45 
bytes in   1 blocks (ref 0) 0x60d27c00
as-clnt-OsmoMSC-A-Iu   contains 21 bytes in   1 
blocks (ref 0) 0x60c46960
as-clnt-OsmoMSC-A-Iu   contains 21 bytes

Change in osmo-msc[master]: abort assignment on Assignment Failure

2018-12-19 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12368 )

Change subject: abort assignment on Assignment Failure
..


Patch Set 3: Code-Review+1

(1 comment)

Code looks good, logging is not critical.

https://gerrit.osmocom.org/#/c/12368/3/src/libmsc/msc_mgcp.c
File src/libmsc/msc_mgcp.c:

https://gerrit.osmocom.org/#/c/12368/3/src/libmsc/msc_mgcp.c@1085
PS3, Line 1085: conn->fi->id);
> Maybe we also need LOGPFSMSL(FI, SUBSYS, LEVEL, fmt, args)?

I like this idea.



--
To view, visit https://gerrit.osmocom.org/12368
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I358cfbaf0f44f25148e8b9bafcb9257b1952b35a
Gerrit-Change-Number: 12368
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 19 Dec 2018 23:04:57 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-osmo-msc » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #7582

2018-12-19 Thread jenkins

See 


--
[...truncated 857.00 KB...]
  no stats reporter statsd
  stats reporter log
  no stats reporter log
  stats interval <1-65535>
  network
  msc
  mncc-int
  hlr
  smpp

OsmoMSC(config)# network

OsmoMSC(config-net)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6502 bytes in  49 blocks)
struct osmo_ss7_instance   contains   2389 bytes in  27 blocks (ref 0) 
0x6140a6a0
struct osmo_sccp_instance  contains266 bytes in   3 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f091f0
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016ab20
struct osmo_ss7_aspcontains   1084 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains359 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A)[0x61216d20] contains 44 
bytes in   1 blocks (ref 0) 0x60d27da0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46a20
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016abd0
struct osmo_fsm_inst   contains270 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b00016ac80
xua_default_lm(asp-clnt-OsmoMSC-A)[0x61217020] contains 
51 bytes in   1 blocks (ref 0) 0x60e3a1e0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46ae0
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b00016ad30
asp-clnt-OsmoMSC-A contains 19 bytes in   1 blocks 
(ref 0) 0x60c46ba0
struct osmo_ss7_as contains598 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains356 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A)[0x61217320] contains 42 bytes 
in   1 blocks (ref 0) 0x60d27e70
as-clnt-OsmoMSC-A  contains 18 bytes in   1 
blocks (ref 0) 0x60c46de0
as-clnt-OsmoMSC-A  contains 18 bytes in   1 blocks 
(ref 0) 0x60c46ea0
struct osmo_ss7_route_tablecontains145 bytes in   4 blocks (ref 
0) 0x60e3a3a0
struct osmo_ss7_route  contains 82 bytes in   2 blocks 
(ref 0) 0x60e3a2c0
as-clnt-OsmoMSC-A

Build failed in Jenkins: master-osmo-msc » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #7581

2018-12-19 Thread jenkins

See 


--
[...truncated 1.20 MB...]
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  iu rab-assign-addr-enc (x213|v4raw)
  asn1 debug (1|0)
  asn1 xer-print (1|0)
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6640 bytes in  53 blocks)
iu contains  2 bytes in   2 blocks (ref 0) 
0x60b000168550
asn1   contains  1 bytes in   1 blocks (ref 
0) 0x60b0001684a0
struct osmo_ss7_instance   contains   2509 bytes in  29 blocks (ref 0) 
0x6140a4a0
struct osmo_sccp_instance  contains359 bytes in   5 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f09010
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168340
struct osmo_sccp_user  contains 93 bytes in   2 blocks 
(ref 0) 0x60f09100
OsmoMSC-IuCS   contains 13 bytes in   1 
blocks (ref 0) 0x60b0001683f0
struct osmo_ss7_aspcontains   1099 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains365 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A-Iu)[0x61216d20] contains 47 
bytes in   1 blocks (ref 0) 0x60d27b30
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c465a0
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168600
struct osmo_fsm_inst   contains276 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b0001686b0
xua_default_lm(asp-clnt-OsmoMSC-A-Iu)[0x61217020] contains  
   54 bytes in   1 blocks (ref 0) 0x60e39e60
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c46660
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b000168760
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 blocks 
(ref 0) 0x60c46720
struct osmo_ss7_as contains607 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains362 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A-Iu)[0x61217320] contains 45 
bytes in   1 blocks (ref 0) 0x60d27c00
as-clnt-OsmoMSC-A-Iu   contains 21 bytes in   1 
blocks (ref 0) 0x60c46960
as-clnt-OsmoMSC-A-Iu   contains 21 bytes

Build failed in Jenkins: master-osmo-msc » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #7581

2018-12-19 Thread jenkins

See 


--
[...truncated 858.20 KB...]
  no stats reporter statsd
  stats reporter log
  no stats reporter log
  stats interval <1-65535>
  network
  msc
  mncc-int
  hlr
  smpp

OsmoMSC(config)# network

OsmoMSC(config-net)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6502 bytes in  49 blocks)
struct osmo_ss7_instance   contains   2389 bytes in  27 blocks (ref 0) 
0x6140a6a0
struct osmo_sccp_instance  contains266 bytes in   3 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f091f0
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016ab20
struct osmo_ss7_aspcontains   1084 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains359 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A)[0x61216d20] contains 44 
bytes in   1 blocks (ref 0) 0x60d27da0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46a20
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016abd0
struct osmo_fsm_inst   contains270 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b00016ac80
xua_default_lm(asp-clnt-OsmoMSC-A)[0x61217020] contains 
51 bytes in   1 blocks (ref 0) 0x60e3a1e0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46ae0
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b00016ad30
asp-clnt-OsmoMSC-A contains 19 bytes in   1 blocks 
(ref 0) 0x60c46ba0
struct osmo_ss7_as contains598 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains356 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A)[0x61217320] contains 42 bytes 
in   1 blocks (ref 0) 0x60d27e70
as-clnt-OsmoMSC-A  contains 18 bytes in   1 
blocks (ref 0) 0x60c46de0
as-clnt-OsmoMSC-A  contains 18 bytes in   1 blocks 
(ref 0) 0x60c46ea0
struct osmo_ss7_route_tablecontains145 bytes in   4 blocks (ref 
0) 0x60e3a3a0
struct osmo_ss7_route  contains 82 bytes in   2 blocks 
(ref 0) 0x60e3a2c0
as-clnt-OsmoMSC-A

Change in osmo-bts[master]: rsl: Send PDCH ACT NACK if TCH chan is still active

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12180 )

Change subject: rsl: Send PDCH ACT NACK if TCH chan is still active
..


Patch Set 1:

> Well as it states it fixes the TTCN3 test, so if someone wants to get more 
> deep knowledge on it, he can just read the scenario exposed in TTCN3 test 
> from git description, run it with and without this patch and see the result.

The idea of a commit log is that the reviewer can skip all that because you 
have explained it :)


--
To view, visit https://gerrit.osmocom.org/12180
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d6d12aec10c801fe55012ca6e58d0bc8755b15d
Gerrit-Change-Number: 12180
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 19 Dec 2018 22:49:54 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-mgw[master]: mgcp_client: logging tweaks

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12270 )

Change subject: mgcp_client: logging tweaks
..

mgcp_client: logging tweaks

Fix typos, use osmo_sock_get_name2() to show the tx source and target IP:port,
shorten some wording.

Depends: I8ad89ac447c9c582742e70d082072bdd40a5a398 (libosmocore)
Change-Id: Iae728192f499330d16836d9435648f6b8ed213b6
---
M src/libosmo-mgcp-client/mgcp_client.c
1 file changed, 12 insertions(+), 12 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/libosmo-mgcp-client/mgcp_client.c 
b/src/libosmo-mgcp-client/mgcp_client.c
index 2ceab3c..8fa82cd 100644
--- a/src/libosmo-mgcp-client/mgcp_client.c
+++ b/src/libosmo-mgcp-client/mgcp_client.c
@@ -651,11 +651,13 @@

ret = read(fd->fd, msg->data, 4096 - 128);
if (ret <= 0) {
-   LOGP(DLMGCP, LOGL_ERROR, "Failed to read: %d/%s\n", errno, 
strerror(errno));
+   LOGP(DLMGCP, LOGL_ERROR, "Failed to read: %s: %d='%s'\n", 
osmo_sock_get_name2(fd->fd),
+errno, strerror(errno));
+
msgb_free(msg);
return -1;
} else if (ret > 4096 - 128) {
-   LOGP(DLMGCP, LOGL_ERROR, "Too much data: %d\n", ret);
+   LOGP(DLMGCP, LOGL_ERROR, "Too much data: %s: %d\n", 
osmo_sock_get_name2(fd->fd), ret);
msgb_free(msg);
return -1;
}
@@ -670,13 +672,13 @@
 {
int ret;

-   LOGP(DLMGCP, LOGL_DEBUG, "Sending msg to MGCP GW size: len=%u 
'%s'...\n",
-msg->len, osmo_escape_str((const char*)msg->data, OSMO_MIN(42, 
msg->len)));
+   LOGP(DLMGCP, LOGL_DEBUG, "Tx MGCP: %s: len=%u '%s'...\n",
+osmo_sock_get_name2(fd->fd), msg->len, osmo_escape_str((const 
char*)msg->data, OSMO_MIN(42, msg->len)));

ret = write(fd->fd, msg->data, msg->len);
if (ret != msg->len)
-   LOGP(DLMGCP, LOGL_ERROR, "Failed to Tx MGCP: %d='%s'; msg: 
len=%u '%s'...\n",
-errno, strerror(errno),
+   LOGP(DLMGCP, LOGL_ERROR, "Failed to Tx MGCP: %s: %d='%s'; msg: 
len=%u '%s'...\n",
+osmo_sock_get_name2(fd->fd), errno, strerror(errno),
 msg->len, osmo_escape_str((const char*)msg->data, 
OSMO_MIN(42, msg->len)));
return ret;
 }
@@ -733,12 +735,12 @@

/* Choose a new port number to try next */
LOGP(DLMGCP, LOGL_NOTICE,
-"MGCPGW faild to bind to port %u, retrying with port %u -- 
check configuration!\n",
-mgcp->actual.local_port, mgcp->actual.local_port + 1);
+"MGCPGW failed to bind to %s:%u, retrying with port %u\n",
+mgcp->actual.local_addr, mgcp->actual.local_port, 
mgcp->actual.local_port + 1);
mgcp->actual.local_port++;
}

-   LOGP(DLMGCP, LOGL_FATAL, "MGCPGW faild to find a port to bind on %i 
times.\n", i);
+   LOGP(DLMGCP, LOGL_FATAL, "MGCPGW failed to find a port to bind on %i 
times.\n", i);
return -EINVAL;
 }

@@ -776,9 +778,7 @@
wq->read_cb = mgcp_do_read;
wq->write_cb = mgcp_do_write;

-   LOGP(DLMGCP, LOGL_INFO, "MGCP GW connection: %s:%u -> %s:%u\n",
-mgcp->actual.local_addr, mgcp->actual.local_port,
-mgcp->actual.remote_addr, mgcp->actual.remote_port);
+   LOGP(DLMGCP, LOGL_INFO, "MGCP GW connection: %s\n", 
osmo_sock_get_name2(wq->bfd.fd));

return 0;
 error_close_fd:

--
To view, visit https://gerrit.osmocom.org/12270
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae728192f499330d16836d9435648f6b8ed213b6
Gerrit-Change-Number: 12270
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-mgw[master]: mgcp_client: logging tweaks

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12270 )

Change subject: mgcp_client: logging tweaks
..


Patch Set 2: Code-Review+2

let me pull "triviality" here.


--
To view, visit https://gerrit.osmocom.org/12270
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae728192f499330d16836d9435648f6b8ed213b6
Gerrit-Change-Number: 12270
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 19 Dec 2018 22:47:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-sccp[master]: fix ipa_asp_fsm down state transition

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12364 )

Change subject: fix ipa_asp_fsm down state transition
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12364
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb8e7bd1c74a4b47080fe32ebe0161c503ead571
Gerrit-Change-Number: 12364
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 19 Dec 2018 22:46:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-osmo-msc » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #7580

2018-12-19 Thread jenkins

See 


--
[...truncated 1.20 MB...]
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  iu rab-assign-addr-enc (x213|v4raw)
  asn1 debug (1|0)
  asn1 xer-print (1|0)
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6640 bytes in  53 blocks)
iu contains  2 bytes in   2 blocks (ref 0) 
0x60b000168550
asn1   contains  1 bytes in   1 blocks (ref 
0) 0x60b0001684a0
struct osmo_ss7_instance   contains   2509 bytes in  29 blocks (ref 0) 
0x6140a4a0
struct osmo_sccp_instance  contains359 bytes in   5 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f09010
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168340
struct osmo_sccp_user  contains 93 bytes in   2 blocks 
(ref 0) 0x60f09100
OsmoMSC-IuCS   contains 13 bytes in   1 
blocks (ref 0) 0x60b0001683f0
struct osmo_ss7_aspcontains   1099 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains365 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A-Iu)[0x61216d20] contains 47 
bytes in   1 blocks (ref 0) 0x60d27b30
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c465a0
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168600
struct osmo_fsm_inst   contains276 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b0001686b0
xua_default_lm(asp-clnt-OsmoMSC-A-Iu)[0x61217020] contains  
   54 bytes in   1 blocks (ref 0) 0x60e39e60
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c46660
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b000168760
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 blocks 
(ref 0) 0x60c46720
struct osmo_ss7_as contains607 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains362 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A-Iu)[0x61217320] contains 45 
bytes in   1 blocks (ref 0) 0x60d27c00
as-clnt-OsmoMSC-A-Iu   contains 21 bytes in   1 
blocks (ref 0) 0x60c46960
as-clnt-OsmoMSC-A-Iu   contains 21 bytes

Build failed in Jenkins: master-osmo-msc » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #7580

2018-12-19 Thread jenkins

See 


--
[...truncated 826.56 KB...]
  no stats reporter statsd
  stats reporter log
  no stats reporter log
  stats interval <1-65535>
  network
  msc
  mncc-int
  hlr
  smpp

OsmoMSC(config)# network

OsmoMSC(config-net)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6502 bytes in  49 blocks)
struct osmo_ss7_instance   contains   2389 bytes in  27 blocks (ref 0) 
0x6140a6a0
struct osmo_sccp_instance  contains266 bytes in   3 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f091f0
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016ab20
struct osmo_ss7_aspcontains   1084 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains359 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A)[0x61216d20] contains 44 
bytes in   1 blocks (ref 0) 0x60d27da0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46a20
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016abd0
struct osmo_fsm_inst   contains270 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b00016ac80
xua_default_lm(asp-clnt-OsmoMSC-A)[0x61217020] contains 
51 bytes in   1 blocks (ref 0) 0x60e3a1e0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46ae0
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b00016ad30
asp-clnt-OsmoMSC-A contains 19 bytes in   1 blocks 
(ref 0) 0x60c46ba0
struct osmo_ss7_as contains598 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains356 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A)[0x61217320] contains 42 bytes 
in   1 blocks (ref 0) 0x60d27e70
as-clnt-OsmoMSC-A  contains 18 bytes in   1 
blocks (ref 0) 0x60c46de0
as-clnt-OsmoMSC-A  contains 18 bytes in   1 blocks 
(ref 0) 0x60c46ea0
struct osmo_ss7_route_tablecontains145 bytes in   4 blocks (ref 
0) 0x60e3a3a0
struct osmo_ss7_route  contains 82 bytes in   2 blocks 
(ref 0) 0x60e3a2c0
as-clnt-OsmoMSC-A

Change in osmo-msc[master]: abort assignment on Assignment Failure

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12368 )

Change subject: abort assignment on Assignment Failure
..


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/12368/3/src/libmsc/msc_mgcp.c
File src/libmsc/msc_mgcp.c:

https://gerrit.osmocom.org/#/c/12368/3/src/libmsc/msc_mgcp.c@1085
PS3, Line 1085: conn->fi->id);
> Why not 'LOGPFSM(conn->fi, ... […]
because then it would be clamped to another logging category.

To reiterate, the LOGPFSM() was initially intended for logging the FSM state 
transitions, but using the FSM instance's context is super useful. So at some 
point I added LOGPFSML() to be able to modify the logging level. However, so 
far each FSM definition is fixed to one particular logging category, ran_conn 
is always DMM.

Maybe we also need LOGPFSMSL(FI, SUBSYS, LEVEL, fmt, args)?

The next best thing is to use the FSM instance's context as a string in a 
normal log statement. That omits the current FSM state, but otherwise logs 
everything else of interest.



--
To view, visit https://gerrit.osmocom.org/12368
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I358cfbaf0f44f25148e8b9bafcb9257b1952b35a
Gerrit-Change-Number: 12368
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 19 Dec 2018 22:29:42 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Build failed in Jenkins: master-osmo-msc » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #7579

2018-12-19 Thread jenkins

See 


--
[...truncated 1.10 MB...]
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  iu rab-assign-addr-enc (x213|v4raw)
  asn1 debug (1|0)
  asn1 xer-print (1|0)
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6640 bytes in  53 blocks)
iu contains  2 bytes in   2 blocks (ref 0) 
0x60b000168550
asn1   contains  1 bytes in   1 blocks (ref 
0) 0x60b0001684a0
struct osmo_ss7_instance   contains   2509 bytes in  29 blocks (ref 0) 
0x6140a4a0
struct osmo_sccp_instance  contains359 bytes in   5 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f09010
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168340
struct osmo_sccp_user  contains 93 bytes in   2 blocks 
(ref 0) 0x60f09100
OsmoMSC-IuCS   contains 13 bytes in   1 
blocks (ref 0) 0x60b0001683f0
struct osmo_ss7_aspcontains   1099 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains365 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A-Iu)[0x61216d20] contains 47 
bytes in   1 blocks (ref 0) 0x60d27b30
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c465a0
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b000168600
struct osmo_fsm_inst   contains276 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b0001686b0
xua_default_lm(asp-clnt-OsmoMSC-A-Iu)[0x61217020] contains  
   54 bytes in   1 blocks (ref 0) 0x60e39e60
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 
blocks (ref 0) 0x60c46660
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b000168760
asp-clnt-OsmoMSC-A-Iu  contains 22 bytes in   1 blocks 
(ref 0) 0x60c46720
struct osmo_ss7_as contains607 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains362 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A-Iu)[0x61217320] contains 45 
bytes in   1 blocks (ref 0) 0x60d27c00
as-clnt-OsmoMSC-A-Iu   contains 21 bytes in   1 
blocks (ref 0) 0x60c46960
as-clnt-OsmoMSC-A-Iu   contains 21 bytes

Change in libosmocore[master]: tests/gsm0808: use new msgb comparison API

2018-12-19 Thread Vadim Yanitskiy

Vadim Yanitskiy has uploaded a new patch set (#3) to the change originally 
created by Max. ( https://gerrit.osmocom.org/12271 )

Change subject: tests/gsm0808: use new msgb comparison API
..

tests/gsm0808: use new msgb comparison API

Since I3bc95f2f5ab6e3f4b502647fb3e0aaaf1f7c4cf5, we have some
helpers to compare certain msgb layer to a given buffer. Let's
change 'VERIFY' macro to use msgb_eq_l3_data_print().

Change-Id: Ib6be778236eff8f2153f3113f9379ecfbec9052b
---
M tests/gsm0808/gsm0808_test.c
1 file changed, 3 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/71/12271/3
--
To view, visit https://gerrit.osmocom.org/12271
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib6be778236eff8f2153f3113f9379ecfbec9052b
Gerrit-Change-Number: 12271
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Assignee: fixeria 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: fixeria

Build failed in Jenkins: master-osmo-msc » --disable-iu,1,a3=default,a4=default,osmocom-master-debian9 #7579

2018-12-19 Thread jenkins

See 


--
[...truncated 826.51 KB...]
  no stats reporter statsd
  stats reporter log
  no stats reporter log
  stats interval <1-65535>
  network
  msc
  mncc-int
  hlr
  smpp

OsmoMSC(config)# network

OsmoMSC(config-net)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  network country code <1-999>
  mobile network code <0-999>
  short name NAME
  long name NAME
  encryption a5 <0-3> [<0-3>] [<0-3>] [<0-3>]
  authentication (optional|required)
  rrlp mode (none|ms-based|ms-preferred|ass-preferred)
  mm info (0|1)
  timezone <-19-19> (0|15|30|45)
  timezone <-19-19> (0|15|30|45) <0-2>
  no timezone
  periodic location update <6-1530>
  no periodic location update

OsmoMSC(config-net)# exit

OsmoMSC(config)# msc

OsmoMSC(config-msc)# list
  help
  list
  write terminal
  write file
  write memory
  write
  show running-config
  exit
  end
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
Error during transcript step 8:
[
OsmoMSC(config-msc)# list
...
  assign-tmsi
  mncc internal
  mncc external MNCC_SOCKET_PATH
  mncc guard-timeout <0-255>
  no assign-tmsi
  auth-tuple-max-reuse-count <-1-2147483647>
  auth-tuple-reuse-on-error (0|1)
  cs7-instance-a <0-15>
  cs7-instance-iu <0-15>
  paging response-timer (default|<1-65535>)
  emergency-call route-to-msisdn MSISDN
  ipa-name NAME
  mgw local-ip A.B.C.D
  mgw local-port <0-65535>
  mgw remote-ip A.B.C.D
  mgw remote-port <0-65535>
  mgw endpoint-range <1-65534> <1-65534>
  mgw bts-base <0-65534>
...
]
Error while verifying transcript file './test_nodes.vty'
<0006> msc_main.c:236 Terminating due to signal 15
[0;mfull talloc report on 'osmo_msc' (total   6502 bytes in  49 blocks)
struct osmo_ss7_instance   contains   2389 bytes in  27 blocks (ref 0) 
0x6140a6a0
struct osmo_sccp_instance  contains266 bytes in   3 blocks (ref 
0) 0x61216ba0
struct osmo_sccp_user  contains 90 bytes in   2 blocks 
(ref 0) 0x60f091f0
OsmoMSC-A  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016ab20
struct osmo_ss7_aspcontains   1084 bytes in  13 blocks (ref 
0) 0x612171a0
struct osmo_fsm_inst   contains359 bytes in   4 blocks 
(ref 0) 0x61216d20
struct xua_asp_fsm_privcontains104 bytes in   1 
blocks (ref 0) 0x61100e60
XUA_ASP(asp-clnt-OsmoMSC-A)[0x61216d20] contains 44 
bytes in   1 blocks (ref 0) 0x60d27da0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46a20
struct osmo_stream_cli contains234 bytes in   2 blocks 
(ref 0) 0x61216ea0
127.0.0.1  contains 10 bytes in   1 
blocks (ref 0) 0x60b00016abd0
struct osmo_fsm_inst   contains270 bytes in   4 blocks 
(ref 0) 0x61217020
struct lm_fsm_priv contains  8 bytes in   1 
blocks (ref 0) 0x60b00016ac80
xua_default_lm(asp-clnt-OsmoMSC-A)[0x61217020] contains 
51 bytes in   1 blocks (ref 0) 0x60e3a1e0
asp-clnt-OsmoMSC-A contains 19 bytes in   1 
blocks (ref 0) 0x60c46ae0
127.0.0.1  contains 10 bytes in   1 blocks 
(ref 0) 0x60b00016ad30
asp-clnt-OsmoMSC-A contains 19 bytes in   1 blocks 
(ref 0) 0x60c46ba0
struct osmo_ss7_as contains598 bytes in   6 blocks (ref 
0) 0x612174a0
struct osmo_fsm_inst   contains356 bytes in   4 blocks 
(ref 0) 0x61217320
struct xua_as_fsm_priv contains104 bytes in   1 
blocks (ref 0) 0x61100fa0
XUA_AS(as-clnt-OsmoMSC-A)[0x61217320] contains 42 bytes 
in   1 blocks (ref 0) 0x60d27e70
as-clnt-OsmoMSC-A  contains 18 bytes in   1 
blocks (ref 0) 0x60c46de0
as-clnt-OsmoMSC-A  contains 18 bytes in   1 blocks 
(ref 0) 0x60c46ea0
struct osmo_ss7_route_tablecontains145 bytes in   4 blocks (ref 
0) 0x60e3a3a0
struct osmo_ss7_route  contains 82 bytes in   2 blocks 
(ref 0) 0x60e3a2c0
as-clnt-OsmoMSC-A

Change in osmo-mgw[master]: mgcp_client: drop a bunch of dead code

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12354 )

Change subject: mgcp_client: drop a bunch of dead code
..

mgcp_client: drop a bunch of dead code

Remove public API that makes no sense anymore and is dead code.

I see the dropped API as a dead-end initial misconception of the early mgcp
client, and it doesn't really make sense to drag this stuff along. It has not
been used by osmo-msc,-bsc for a long time now, and just confuses the reader.

It is public API, yes, and older versions of osmo-msc / osmo-bsc will not be
able to compile against this, but even if it did, the resulting MGCP client
would not work with the current osmo-mgw: this API is still based on the
premise that the MGCP client dictates the MGW endpoint numbers, a concept that
cannot be used with the current osmo-mgw. Instead, osmo-mgw expects a
wildcarded endpoint upon CRCX and assigns its own endpoint names.

Also, the bts-base configuration is unused and a legacy of when osmo-bsc_mgcp
had explicit BTS and CN sides.

Change-Id: I98a9f1f17a1c4ab20cea3b08c7d21663592134d6
---
M TODO-RELEASE
M include/osmocom/mgcp_client/mgcp_client.h
M src/libosmo-mgcp-client/mgcp_client.c
M src/libosmo-mgcp-client/mgcp_client_vty.c
M tests/mgcp_client/mgcp_client_test.c
M tests/mgcp_client/mgcp_client_test.err
M tests/mgcp_client/mgcp_client_test.ok
7 files changed, 12 insertions(+), 415 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Max: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/TODO-RELEASE b/TODO-RELEASE
index c5a3b36..3969146 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -24,3 +24,4 @@
 # If any interfaces have been removed or changed since the last public 
release, a=0.
 #
 #library   whatdescription / commit summary line
+libosmo-mgcp-clientvarious Drop legacy API functions and 
mgcp_client_conf members
diff --git a/include/osmocom/mgcp_client/mgcp_client.h 
b/include/osmocom/mgcp_client/mgcp_client.h
index 79f2078..c1fd1b0 100644
--- a/include/osmocom/mgcp_client/mgcp_client.h
+++ b/include/osmocom/mgcp_client/mgcp_client.h
@@ -22,9 +22,6 @@
int local_port;
const char *remote_addr;
int remote_port;
-   uint16_t first_endpoint;
-   uint16_t last_endpoint;
-   uint16_t bts_base;
 };

 typedef unsigned int mgcp_trans_id_t;
@@ -123,9 +120,6 @@
 uint16_t mgcp_client_remote_port(struct mgcp_client *mgcp);
 uint32_t mgcp_client_remote_addr_n(struct mgcp_client *mgcp);

-int mgcp_client_next_endpoint(struct mgcp_client *client);
-void mgcp_client_release_endpoint(uint16_t id, struct mgcp_client *client);
-
 /* Invoked when an MGCP response is received or sending failed.  When the
  * response is passed as NULL, this indicates failure during transmission. */
 typedef void (* mgcp_response_cb_t )(struct mgcp_response *response, void 
*priv);
@@ -137,20 +131,6 @@

 enum mgcp_connection_mode;

-struct msgb *mgcp_msg_crcx(struct mgcp_client *mgcp,
-  uint16_t rtp_endpoint, unsigned int call_id,
-  enum mgcp_connection_mode mode)
-OSMO_DEPRECATED("Use mgcp_msg_gen() instead");
-
-struct msgb *mgcp_msg_mdcx(struct mgcp_client *mgcp,
-  uint16_t rtp_endpoint, const char *rtp_conn_addr,
-  uint16_t rtp_port, enum mgcp_connection_mode mode)
-OSMO_DEPRECATED("Use mgcp_msg_gen() instead");
-
-struct msgb *mgcp_msg_dlcx(struct mgcp_client *mgcp, uint16_t rtp_endpoint,
-  unsigned int call_id)
-OSMO_DEPRECATED("Use mgcp_msg_gen() instead");
-
 struct msgb *mgcp_msg_gen(struct mgcp_client *mgcp, struct mgcp_msg *mgcp_msg);
 mgcp_trans_id_t mgcp_msg_trans_id(struct msgb *msg);

diff --git a/src/libosmo-mgcp-client/mgcp_client.c 
b/src/libosmo-mgcp-client/mgcp_client.c
index fc9c5d3..2ceab3c 100644
--- a/src/libosmo-mgcp-client/mgcp_client.c
+++ b/src/libosmo-mgcp-client/mgcp_client.c
@@ -190,75 +190,9 @@
.local_port = -1,
.remote_addr = NULL,
.remote_port = -1,
-   .first_endpoint = 0,
-   .last_endpoint = 0,
-   .bts_base = 0,
};
 }

-/* Test if a given endpoint id is currently in use */
-static bool endpoint_in_use(uint16_t id, struct mgcp_client *client)
-{
-   struct mgcp_inuse_endpoint *endpoint;
-   llist_for_each_entry(endpoint, >inuse_endpoints, entry) {
-   if (endpoint->id == id)
-   return true;
-   }
-
-   return false;
-}
-
-/*! Pick next free endpoint ID.
- *  \param[in,out] client MGCP client descriptor.
- *  \returns 0 on success, -EINVAL on error. */
-int mgcp_client_next_endpoint(struct mgcp_client *client)
-{
-   int i;
-   uint16_t first_endpoint =

Change in osmo-mgw[master]: mgcp_client: drop a bunch of dead code

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12354 )

Change subject: mgcp_client: drop a bunch of dead code
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12354
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98a9f1f17a1c4ab20cea3b08c7d21663592134d6
Gerrit-Change-Number: 12354
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter 
Gerrit-Comment-Date: Wed, 19 Dec 2018 22:22:33 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-mgw[master]: mgcp_client_vty: fix missing talloc_free

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12355 )

Change subject: mgcp_client_vty: fix missing talloc_free
..

mgcp_client_vty: fix missing talloc_free

If the vty client enters multiple local / remote addresses, that leaks talloc
memory of the previously set addresses. Free those first, if any, using
osmo_talloc_replace_string().

Change-Id: I331b3d53b5eb330b87d798f952077a043674d409
---
M src/libosmo-mgcp-client/mgcp_client_vty.c
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libosmo-mgcp-client/mgcp_client_vty.c 
b/src/libosmo-mgcp-client/mgcp_client_vty.c
index 48fcd70..ecc205f 100644
--- a/src/libosmo-mgcp-client/mgcp_client_vty.c
+++ b/src/libosmo-mgcp-client/mgcp_client_vty.c
@@ -43,8 +43,9 @@
if (!global_mgcp_client_conf)
return CMD_ERR_NOTHING_TODO;
OSMO_ASSERT(global_mgcp_client_ctx);
-   global_mgcp_client_conf->local_addr =
-   talloc_strdup(global_mgcp_client_ctx, argv[0]);
+   osmo_talloc_replace_string(global_mgcp_client_ctx,
+  (char**)_mgcp_client_conf->local_addr,
+  argv[0]);
return CMD_SUCCESS;
 }
 ALIAS_DEPRECATED(cfg_mgw_local_ip, cfg_mgcpgw_local_ip_cmd,
@@ -75,8 +76,9 @@
if (!global_mgcp_client_conf)
return CMD_ERR_NOTHING_TODO;
OSMO_ASSERT(global_mgcp_client_ctx);
-   global_mgcp_client_conf->remote_addr =
-   talloc_strdup(global_mgcp_client_ctx, argv[0]);
+   osmo_talloc_replace_string(global_mgcp_client_ctx,
+  
(char**)_mgcp_client_conf->remote_addr,
+  argv[0]);
return CMD_SUCCESS;
 }
 ALIAS_DEPRECATED(cfg_mgw_remote_ip, cfg_mgcpgw_remote_ip_cmd,

--
To view, visit https://gerrit.osmocom.org/12355
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I331b3d53b5eb330b87d798f952077a043674d409
Gerrit-Change-Number: 12355
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy

Change in libosmocore[master]: tests/gsup_test.c: drop session IEs from MO-ForwardSM Error

2018-12-19 Thread Vadim Yanitskiy

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/12382


Change subject: tests/gsup_test.c: drop session IEs from MO-ForwardSM Error
..

tests/gsup_test.c: drop session IEs from MO-ForwardSM Error

Both session state and session ID IEs were left from the initial
version of Ibe325c64ae2d6c626b232533bb4cbc65fc2b5d71. There is
no need to use them (as we use SM-RP-MR), so let's claen up.

Change-Id: I0d910b87f15ffbc0aeeca9cb4fcbef32bdf3ef88
---
M tests/gsup/gsup_test.c
M tests/gsup/gsup_test.err
2 files changed, 4 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/82/12382/1

diff --git a/tests/gsup/gsup_test.c b/tests/gsup/gsup_test.c
index b3a8c77..6c5d351 100644
--- a/tests/gsup/gsup_test.c
+++ b/tests/gsup/gsup_test.c
@@ -256,12 +256,6 @@
0x25, /* OSMO_GSUP_MSGT_MO_FORWARD_SM_ERROR */
TEST_IMSI_IE,

-   /* Session related IEs */
-   0x30, 0x04, /* Session ID */
-   0xde, 0xad, 0xbe, 0xef,
-   0x31, 0x01, /* Session state (END) */
-   0x03,
-
/* SM related IEs */
0x40, 0x01, /* SM-RP-MR (Message Reference) */
0xfa,
diff --git a/tests/gsup/gsup_test.err b/tests/gsup/gsup_test.err
index 236c38a..c81755e 100644
--- a/tests/gsup/gsup_test.err
+++ b/tests/gsup/gsup_test.err
@@ -58,8 +58,8 @@
   generated message: 2a 01 08 21 43 65 87 09 21 43 f5 40 01 fa 43 04 de ad be 
ef
   original message:  2a 01 08 21 43 65 87 09 21 43 f5 40 01 fa 43 04 de ad be 
ef
   IMSI:  123456789012345
-  generated message: 25 01 08 21 43 65 87 09 21 43 f5 30 04 de ad be ef 31 01 
03 40 01 fa 44 01 af
-  original message:  25 01 08 21 43 65 87 09 21 43 f5 30 04 de ad be ef 31 01 
03 40 01 fa 44 01 af
+  generated message: 25 01 08 21 43 65 87 09 21 43 f5 40 01 fa 44 01 af
+  original message:  25 01 08 21 43 65 87 09 21 43 f5 40 01 fa 44 01 af
   IMSI:  123456789012345
   generated message: 2c 01 08 21 43 65 87 09 21 43 f5 46 01 02
   original message:  2c 01 08 21 43 65 87 09 21 43 f5 46 01 02
@@ -84,7 +84,7 @@
   message 17: tested 33 truncations, 29 parse failures
   message 18: tested 44 truncations, 39 parse failures
   message 19: tested 20 truncations, 18 parse failures
-  message 20: tested 26 truncations, 22 parse failures
+  message 20: tested 17 truncations, 15 parse failures
   message 21: tested 14 truncations, 13 parse failures
 DLGSUP Stopping DLGSUP logging
   message 0: tested 2816 modifications, 510 parse failures
@@ -107,5 +107,5 @@
   message 17: tested 8448 modifications, 2053 parse failures
   message 18: tested 11264 modifications, 2307 parse failures
   message 19: tested 5120 modifications, 1031 parse failures
-  message 20: tested 6656 modifications, 1546 parse failures
+  message 20: tested 4352 modifications, 1030 parse failures
   message 21: tested 3584 modifications, 771 parse failures

--
To view, visit https://gerrit.osmocom.org/12382
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d910b87f15ffbc0aeeca9cb4fcbef32bdf3ef88
Gerrit-Change-Number: 12382
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy

Build failed in Jenkins: master-osmo-iuh » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #2706

2018-12-19 Thread jenkins

See 


--
[...truncated 713.21 KB...]
../../include/osmocom/ranap/RANAP_LA-LIST.h:27:23: warning: ‘struct MemberA’ 
declared inside parameter list will not be visible outside of this definition 
or declaration
  A_SEQUENCE_OF(struct MemberA {
   ^
:17:16:
 note: in definition of macro ‘A_SET_OF’
   void (*free)(type *);   \
^~~~
../../include/osmocom/ranap/RANAP_LA-LIST.h:27:2: note: in expansion of macro 
‘A_SEQUENCE_OF’
  A_SEQUENCE_OF(struct MemberA {
  ^
  CC   RANAP_LHN-ID.lo
  CC   RANAP_Links-to-log.lo
  CC   RANAP_ListOF-SNAs.lo
  CC   RANAP_ListOfInterfacesToTrace.lo
  CC   RANAP_InterfacesToTraceItem.lo
  CC   RANAP_LoadValue.lo
  CC   RANAP_LocationRelatedDataRequestType.lo
  CC   RANAP_LocationRelatedDataRequestTypeSpecificToGERANIuMode.lo
  CC   RANAP_LocationReportingTransferInformation.lo
  CC   RANAP_ReportChangeOfSAI.lo
  CC   RANAP_PeriodicReportingIndicator.lo
  CC   RANAP_DirectReportingIndicator.lo
  CC   RANAP_L3-Information.lo
  CC   RANAP_M1Report.lo
  CC   RANAP_M2Report.lo
  CC   RANAP_M4Report.lo
  CC   RANAP_M4-Collection-Parameters.lo
  CC   RANAP_M4-Period.lo
  CC   RANAP_M4-Threshold.lo
  CC   RANAP_M5Report.lo
  CC   RANAP_M5-Period.lo
  CC   RANAP_M6Report.lo
  CC   RANAP_M6-Period.lo
  CC   RANAP_M7Report.lo
  CC   RANAP_M7-Period.lo
  CC   RANAP_Management-Based-MDT-Allowed.lo
  CC   RANAP_MaxBitrate.lo
  CC   RANAP_MaxSDU-Size.lo
  CC   RANAP_MBMS-PTP-RAB-ID.lo
  CC   RANAP_MBMSBearerServiceType.lo
  CC   RANAP_MBMSCNDe-Registration.lo
  CC   RANAP_MBMSCountingInformation.lo
  CC   RANAP_MBMSHCIndicator.lo
  CC   RANAP_MBMSIPMulticastAddressandAPNRequest.lo
  CC   RANAP_MBMSLinkingInformation.lo
  CC   RANAP_MBMSRegistrationRequestType.lo
  CC   RANAP_MBMSServiceArea.lo
  CC   RANAP_MBMSSessionDuration.lo
  CC   RANAP_MBMSSessionIdentity.lo
  CC   RANAP_MBMSSessionRepetitionNumber.lo
  CC   RANAP_MDT-Activation.lo
  CC   RANAP_MDTAreaScope.lo
  CC   RANAP_MDT-Configuration.lo
  CC   RANAP_MDTMode.lo
  CC   RANAP_MDT-PLMN-List.lo
  CC   RANAP_MDT-Report-Parameters.lo
  CC   RANAP_MeasurementQuantity.lo
  CC   RANAP_MeasurementsToActivate.lo
  CC   RANAP_MSISDN.lo
  CC   RANAP_NAS-PDU.lo
  CC   RANAP_NAS-SequenceNumber.lo
  CC   RANAP_NAS-SynchronisationIndicator.lo
  CC   RANAP_NewBSS-To-OldBSS-Information.lo
  CC   RANAP_NonSearchingIndication.lo
  CC   RANAP_NRTLoadInformationValue.lo
  CC   RANAP_NumberOfIuInstances.lo
  CC   RANAP_NumberOfSteps.lo
  CC   RANAP_Offload-RAB-Parameters.lo
  CC   RANAP_Offload-RAB-Parameters-APN.lo
  CC   RANAP_Offload-RAB-Parameters-ChargingCharacteristics.lo
  CC   RANAP_OldBSS-ToNewBSS-Information.lo
  CC   RANAP_OMC-ID.lo
  CC   RANAP_Out-Of-UTRAN.lo
  CC   RANAP_PagingAreaID.lo
  CC   RANAP_PagingCause.lo
  CC   RANAP_PDP-TypeInformation.lo
  CC   RANAP_PDP-Type.lo
  CC   RANAP_PDP-TypeInformation-extension.lo
  CC   RANAP_PDP-Type-extension.lo
  CC   RANAP_PDUType14FrameSequenceNumber.lo
  CC   RANAP_PeriodicLocationInfo.lo
  CC   RANAP_PermanentNAS-UE-ID.lo
  CC   RANAP_PermittedEncryptionAlgorithms.lo
  CC   RANAP_PermittedIntegrityProtectionAlgorithms.lo
  CC   RANAP_LABased.lo
  CC   RANAP_LAI-List.lo
  CC   RANAP_LoggedMDT.lo
  CC   RANAP_LoggingInterval.lo
  CC   RANAP_LoggingDuration.lo
  CC   RANAP_PLMNidentity.lo
  CC   RANAP_PLMNs-in-shared-network.lo
  CC   RANAP_Port-Number.lo
  CC   RANAP_PositioningDataDiscriminator.lo
  CC   RANAP_PositioningDataSet.lo
  CC   RANAP_PositioningMethodAndUsage.lo
In file included from 
:8:0,
 from 
../../include/osmocom/ranap/RANAP_PLMNs-in-shared-network.h:14,
 from RANAP_PLMNs-in-shared-network.c:7:
../../include/osmocom/ranap/RANAP_LA-LIST.h:27:23: warning: ‘struct MemberA’ 
declared inside parameter list will not be visible outside of this definition 
or declaration
  A_SEQUENCE_OF(struct MemberA {
   ^

Change in libosmocore[master]: TLV: add convenience function for 1-byte values

2018-12-19 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12373 )

Change subject: TLV: add convenience function for 1-byte values
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/12373/2/include/osmocom/gsm/tlv.h
File include/osmocom/gsm/tlv.h:

https://gerrit.osmocom.org/#/c/12373/2/include/osmocom/gsm/tlv.h@498
PS2, Line 498: Obtain 1-byte TLV element
Neels recently asked me to take care about punctuation, so let's please use 
dots.



--
To view, visit https://gerrit.osmocom.org/12373
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0a148bd04b8860e321f509fdcd913f688c8e920
Gerrit-Change-Number: 12373
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 19 Dec 2018 20:56:07 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in libosmocore[master]: TLV: fix doc copy-paste error

2018-12-19 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12372 )

Change subject: TLV: fix doc copy-paste error
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12372
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8aa79cab7505585de00ee2aaae125462108906e8
Gerrit-Change-Number: 12372
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 19 Dec 2018 20:53:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: LCLS: don't encode incorrect values

2018-12-19 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12375 )

Change subject: LCLS: don't encode incorrect values
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12375/1/src/gsm/gsm0808.c
File src/gsm/gsm0808.c:

https://gerrit.osmocom.org/#/c/12375/1/src/gsm/gsm0808.c@340
PS1, Line 340:  if (status == GSM0808_LCLS_STS_NA)
I'm not sure this is worth it.  The value can be *any* integer in most C 
compilers (particularly, gcc), and you are now checking for one invalid value, 
but not for close to 2^32 to 2^64 other invalid values...



--
To view, visit https://gerrit.osmocom.org/12375
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ac4bae75f5796e6e11346b8cb34d3897ae70b59
Gerrit-Change-Number: 12375
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 19 Dec 2018 20:53:14 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-mgw[master]: mgcp_client_vty: fix missing talloc_free

2018-12-19 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12355 )

Change subject: mgcp_client_vty: fix missing talloc_free
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12355
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I331b3d53b5eb330b87d798f952077a043674d409
Gerrit-Change-Number: 12355
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 19 Dec 2018 20:51:45 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: TLV: fix doc copy-paste error

2018-12-19 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12372 )

Change subject: TLV: fix doc copy-paste error
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12372
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8aa79cab7505585de00ee2aaae125462108906e8
Gerrit-Change-Number: 12372
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 19 Dec 2018 20:50:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: TLV: add convenience function for 1-byte values

2018-12-19 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12373 )

Change subject: TLV: add convenience function for 1-byte values
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12373
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0a148bd04b8860e321f509fdcd913f688c8e920
Gerrit-Change-Number: 12373
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 19 Dec 2018 20:50:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: rename CELL_IDENT_LAI_AND_LAC to CELL_IDENT_LAI

2018-12-19 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12374 )

Change subject: rename CELL_IDENT_LAI_AND_LAC to CELL_IDENT_LAI
..

rename CELL_IDENT_LAI_AND_LAC to CELL_IDENT_LAI

The name "LAI AND LAC" makes no sense because a LAC
is part of a LAI. Keep the old name available for
API backwards compatibility.

Change-Id: I2749cf75b7b45de0cd43cf4c696a6b6984f5a065
Related: OS#3124
---
M include/osmocom/gsm/protocol/gsm_08_08.h
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h 
b/include/osmocom/gsm/protocol/gsm_08_08.h
index cb9fe01..676d1cf 100644
--- a/include/osmocom/gsm/protocol/gsm_08_08.h
+++ b/include/osmocom/gsm/protocol/gsm_08_08.h
@@ -18,14 +18,15 @@
CELL_IDENT_LAC_AND_CI   = 1,
CELL_IDENT_CI   = 2,
CELL_IDENT_NO_CELL  = 3,
-   CELL_IDENT_LAI_AND_LAC  = 4,
+   CELL_IDENT_LAI  = 4,
CELL_IDENT_LAC  = 5,
CELL_IDENT_BSS  = 6,
CELL_IDENT_UTRAN_PLMN_LAC_RNC   = 8,
CELL_IDENT_UTRAN_RNC= 9,
CELL_IDENT_UTRAN_LAC_RNC= 10,
 };
-
+/* Keep this misnamed CELL_IDENT for API backwards compatibility (see 
OS#3124). */
+#define CELL_IDENT_LAI_AND_LAC CELL_IDENT_LAI

 /* GSM 08.06 § 6.3 */
 enum BSSAP_MSG_TYPE {

--
To view, visit https://gerrit.osmocom.org/12374
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2749cf75b7b45de0cd43cf4c696a6b6984f5a065
Gerrit-Change-Number: 12374
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmocore[master]: rename CELL_IDENT_LAI_AND_LAC to CELL_IDENT_LAI

2018-12-19 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12374 )

Change subject: rename CELL_IDENT_LAI_AND_LAC to CELL_IDENT_LAI
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12374
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2749cf75b7b45de0cd43cf4c696a6b6984f5a065
Gerrit-Change-Number: 12374
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 19 Dec 2018 20:49:59 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: add a test for LU with invalid LAI

2018-12-19 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12380 )

Change subject: add a test for LU with invalid LAI
..


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/12380/1/msc/MSC_Tests.ttcn
File msc/MSC_Tests.ttcn:

https://gerrit.osmocom.org/#/c/12380/1/msc/MSC_Tests.ttcn@2839
PS1, Line 2839: f_enc_mcc_mnc
This function is private in BSSMAP_Templates.ttcn :/


https://gerrit.osmocom.org/#/c/12380/1/msc/MSC_Tests.ttcn@2844
PS1, Line 2844: tr_ML3_MT_LU_Rej
Should we expect any particular reject cause?



--
To view, visit https://gerrit.osmocom.org/12380
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I676894358259b9cc0f973769ce552ba58a2a58a1
Gerrit-Change-Number: 12380
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 19 Dec 2018 20:49:30 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmocore[master]: Use define for key buffers

2018-12-19 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12381 )

Change subject: Use define for key buffers
..


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/12381/1/src/gsm/auth_core.c
File src/gsm/auth_core.c:

https://gerrit.osmocom.org/#/c/12381/1/src/gsm/auth_core.c@101
PS1, Line 101: 3GPP TS 33.102 §6.8.2.3 C5
> The commit message says "Use define for key buffers". […]
it's just a change in a comment, nevermind.



--
To view, visit https://gerrit.osmocom.org/12381
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5e2aad86eaecd8eada667b3488ba415d81c6312
Gerrit-Change-Number: 12381
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 19 Dec 2018 20:48:48 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: abort assignment on Assignment Failure

2018-12-19 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12368 )

Change subject: abort assignment on Assignment Failure
..


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/#/c/12368/3/src/libmsc/msc_mgcp.c
File src/libmsc/msc_mgcp.c:

https://gerrit.osmocom.org/#/c/12368/3/src/libmsc/msc_mgcp.c@1085
PS3, Line 1085: conn->fi->id);
Why not 'LOGPFSM(conn->fi, ...);'?


https://gerrit.osmocom.org/#/c/12368/3/src/libmsc/osmo_msc.c
File src/libmsc/osmo_msc.c:

https://gerrit.osmocom.org/#/c/12368/3/src/libmsc/osmo_msc.c@127
PS3, Line 127: LOGP
Same, LOGPFSM()?



--
To view, visit https://gerrit.osmocom.org/12368
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I358cfbaf0f44f25148e8b9bafcb9257b1952b35a
Gerrit-Change-Number: 12368
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 19 Dec 2018 20:39:22 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmocore[master]: Use define for key buffers

2018-12-19 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12381 )

Change subject: Use define for key buffers
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12381/1/src/gsm/auth_core.c
File src/gsm/auth_core.c:

https://gerrit.osmocom.org/#/c/12381/1/src/gsm/auth_core.c@101
PS1, Line 101: 3GPP TS 33.102 §6.8.2.3 C5
The commit message says "Use define for key buffers".
Let's do it in a separate change.



--
To view, visit https://gerrit.osmocom.org/12381
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5e2aad86eaecd8eada667b3488ba415d81c6312
Gerrit-Change-Number: 12381
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 19 Dec 2018 20:28:00 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmocore[master]: Use define for key buffers

2018-12-19 Thread Max

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12381


Change subject: Use define for key buffers
..

Use define for key buffers

Add corresponding spec. references and comments where appropriate.

Change-Id: If5e2aad86eaecd8eada667b3488ba415d81c6312
---
M include/osmocom/crypt/auth.h
M src/gsm/auth_core.c
M tests/auth/milenage_test.c
3 files changed, 9 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/81/12381/1

diff --git a/include/osmocom/crypt/auth.h b/include/osmocom/crypt/auth.h
index e544126..c653b61 100644
--- a/include/osmocom/crypt/auth.h
+++ b/include/osmocom/crypt/auth.h
@@ -42,7 +42,7 @@
union {
struct {
uint8_t opc[16]; /*!< operator invariant value */
-   uint8_t k[16];  /*!< secret key of the subscriber */
+   uint8_t k[OSMO_A5_MAX_KEY_LEN_BYTES];   /*!< secret key 
of the subscriber */
uint8_t amf[2];
uint64_t sqn;   /*!< sequence number (in: prev sqn; 
out: used sqn) */
int opc_is_op;  /*!< is the OPC field OPC (0) or OP (1) 
? */
@@ -60,8 +60,8 @@
 struct osmo_auth_vector {
uint8_t rand[16];   /*!< random challenge */
uint8_t autn[16];   /*!< authentication nonce */
-   uint8_t ck[16]; /*!< ciphering key */
-   uint8_t ik[16]; /*!< integrity key */
+   uint8_t ck[OSMO_A5_MAX_KEY_LEN_BYTES];  /*!< ciphering key */
+   uint8_t ik[OSMO_A5_MAX_KEY_LEN_BYTES];  /*!< integrity key */
uint8_t res[16];/*!< authentication result */
uint8_t res_len;/*!< length (in bytes) of res */
uint8_t kc[8];  /*!< Kc for GSM encryption (A5) */
diff --git a/src/gsm/auth_core.c b/src/gsm/auth_core.c
index f171ed4..9e750a0 100644
--- a/src/gsm/auth_core.c
+++ b/src/gsm/auth_core.c
@@ -98,7 +98,7 @@
return 0;
 }

-/* C5 function to derive UMTS IK from GSM Kc */
+/* 3GPP TS 33.102 §6.8.2.3 C5 function to derive UMTS IK from GSM Kc */
 static inline void c5_function(uint8_t *ik, const uint8_t *kc)
 {
unsigned int i;
@@ -110,7 +110,7 @@
ik[i] = ik[i-12];
 }

-/* C4 function to derive UMTS CK from GSM Kc */
+/* 3GPP TS 33.102 §6.8.2.3 C4 function to derive UMTS CK from GSM Kc */
 void osmo_c4(uint8_t *ck, const uint8_t *kc)
 {
memcpy(ck, kc, 8);
diff --git a/tests/auth/milenage_test.c b/tests/auth/milenage_test.c
index 2bd3cf2..8b058e5 100644
--- a/tests/auth/milenage_test.c
+++ b/tests/auth/milenage_test.c
@@ -23,7 +23,10 @@

if (vec->auth_types & OSMO_AUTH_TYPE_GSM) {
printf("SRES:\t%s\n", osmo_hexdump(vec->sres, 
sizeof(vec->sres)));
-   printf("Kc:\t%s\n", osmo_hexdump(vec->kc, sizeof(vec->kc)));
+   /* According to 3GPP TS 55.205 Sec. 4 the GSM-MILENAGE output 
is limited to 64 bits.
+  According to 3GPP TS 33.102 Annex. B5 in UMTS security 
context Kc can be 128 bits.
+  Here we test the former, so make sure we only print 
interesting Kc bits. */
+   printf("Kc:\t%s\n", osmo_hexdump(vec->kc, 
OSMO_A5_MAX_KEY_LEN_BYTES/2));
}
 }


--
To view, visit https://gerrit.osmocom.org/12381
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5e2aad86eaecd8eada667b3488ba415d81c6312
Gerrit-Change-Number: 12381
Gerrit-PatchSet: 1
Gerrit-Owner: Max

Change in osmo-msc[master]: libmsc/VTY: introduce kill-switch for routing SMS over GSUP

2018-12-19 Thread Vadim Yanitskiy

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11918

to look at the new patch set (#8).

Change subject: libmsc/VTY: introduce kill-switch for routing SMS over GSUP
..

libmsc/VTY: introduce kill-switch for routing SMS over GSUP

As a rudiment of OsmoNiTB, OsmoMSC is still involved in SMS
processing, storage (in SQLite DB), and routing (via SMPP).
In real networks this is done by the external entity called
SMSC (SMS Centre), while the MSC is doing re-encapsulation
of GSM 04.11 SM-TL (Transport Layer) payload (i.e. TPDU)
between SM-RL (Relay Layer) and MAP.

Since OsmoMSC itself is not a 'Network in The Box' anymore, it
makes sense to replicate the 'traditional' behaviour of MSC.
The problem is that this behaviour cannot co-exist with the
current implementation, so the key idea is to rip out the
local SMS storage and routing from OsmoMSC, and (re)implement
it in a separate process (OsmoSMSC?).

As a temporary solution, this change introduces a 'kill-switch'
VTY option that enables routing of SMS messages over GSUP
towards ESME (through VLR and HLR), but breaks the local
storage and routing. This is why it's disabled by default.

As soon as we move the SMS processing and storage away from
OsmoMSC, this behaviour would be enabled by default, and
the VTY option would be hidden and deprecated. At the moment,
this option basically does nothing, and will take an effect
in the follow-up changes.

Change-Id: Ie57685ed2ce1e4c978e775b68fdffe58de44882b
Related: OS#3587
---
M include/osmocom/msc/gsm_data.h
M src/libmsc/msc_vty.c
M tests/test_nodes.vty
3 files changed, 33 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/18/11918/8
--
To view, visit https://gerrit.osmocom.org/11918
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie57685ed2ce1e4c978e775b68fdffe58de44882b
Gerrit-Change-Number: 11918
Gerrit-PatchSet: 8
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-msc[master]: abort assignment on Assignment Failure

2018-12-19 Thread Neels Hofmeyr

Hello Pau Espin Pedrol, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12368

to look at the new patch set (#3).

Change subject: abort assignment on Assignment Failure
..

abort assignment on Assignment Failure

If Assignment fails in the BSC, trigger an EV_TEARDOWN_ERROR in the mgcp_ctx
FSM instance, so that the call gets torn down immediately. Before this, the
non-call would idle around without anything happening.

Related: OS#3236
Change-Id: I358cfbaf0f44f25148e8b9bafcb9257b1952b35a
---
M include/osmocom/msc/msc_mgcp.h
M src/libmsc/msc_mgcp.c
M src/libmsc/osmo_msc.c
3 files changed, 21 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/68/12368/3
--
To view, visit https://gerrit.osmocom.org/12368
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I358cfbaf0f44f25148e8b9bafcb9257b1952b35a
Gerrit-Change-Number: 12368
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-msc[master]: abort assignment on Assignment Failure

2018-12-19 Thread Neels Hofmeyr

Hello Pau Espin Pedrol, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12368

to look at the new patch set (#2).

Change subject: abort assignment on Assignment Failure
..

abort assignment on Assignment Failure

If Assignment fails in the BSC, trigger an EV_TEARDOWN_ERROR in the mgcp_ctx
FSM instance, so that the call gets torn down immediately. Before this, the
non-call would idle around without anything happening.

Related: OS#3236
Change-Id: I358cfbaf0f44f25148e8b9bafcb9257b1952b35a
---
M include/osmocom/msc/msc_mgcp.h
M src/libmsc/msc_mgcp.c
M src/libmsc/osmo_msc.c
3 files changed, 21 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/68/12368/2
--
To view, visit https://gerrit.osmocom.org/12368
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I358cfbaf0f44f25148e8b9bafcb9257b1952b35a
Gerrit-Change-Number: 12368
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-ttcn3-hacks[master]: add a test for LU with invalid LAI

2018-12-19 Thread Stefan Sperling

Stefan Sperling has uploaded this change for review. ( 
https://gerrit.osmocom.org/12380


Change subject: add a test for LU with invalid LAI
..

add a test for LU with invalid LAI

Verify that the MSC rejects a location update with a LAI that
contains a PLMN which does not match the network's PLMN.

Change-Id: I676894358259b9cc0f973769ce552ba58a2a58a1
Related: OS#3162
---
M msc/MSC_Tests.cfg
M msc/MSC_Tests.ttcn
M msc/expected-results.xml
3 files changed, 36 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/80/12380/1

diff --git a/msc/MSC_Tests.cfg b/msc/MSC_Tests.cfg
index b412889..efe4666 100644
--- a/msc/MSC_Tests.cfg
+++ b/msc/MSC_Tests.cfg
@@ -61,3 +61,4 @@
 #MSC_Tests.TC_reset_two
 #MSC_Tests.TC_lu_and_mt_call
 #MSC_Tests.TC_cipher_complete_with_invalid_cipher
+#MSC_Tests.TC_lu_with_invalid_lai
diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 1b37329..bf83427 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -2826,6 +2826,38 @@
vc_conn.done;
 }

+/* Location Update with PLMN mismatch in the LAI. */
+private function f_tc_lu_with_invalid_lai(charstring id, BSC_ConnHdlrPars 
pars) runs on BSC_ConnHdlr {
+   f_init_handler(pars);
+
+   /* tell GSUP dispatcher to send this IMSI to us */
+   f_create_gsup_expect(hex2str(g_pars.imsi));
+
+   /* Send BSSAP_Conn_Req with COMPL L3 INFO to MSC */
+   var PDU_ML3_MS_NW l3_lu := f_build_lu_imsi(g_pars.imsi)
+   /* Override the location update's LAI with a different PLMN; 
osmo-msc.cfg uses mcc 262 mnc 42 */
+   l3_lu.msgs.mm.locationUpdateRequest.locationAreaIdentification.mcc_mnc 
:= f_enc_mcc_mnc('262'H, '23'H);
+   f_bssap_compl_l3(l3_lu);
+
+   /* Expect LU reject from MSC. */
+   alt {
+   [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) {
+   setverdict(pass);
+   }
+   [] BSSAP.receive {
+   setverdict(fail, "Unknown/unexpected BSSAP received");
+   mtc.stop;
+   }
+   }
+}
+
+testcase TC_lu_with_invalid_lai() runs on MTC_CT {
+   var BSC_ConnHdlr vc_conn;
+   f_init();
+   vc_conn := f_start_handler(refers(f_tc_lu_with_invalid_lai), 53);
+   vc_conn.done;
+}
+
 /* TODO (SMS):
* different user data lengths
* SMPP transaction mode with unsuccessful delivery
@@ -2916,6 +2948,8 @@

execute( TC_cipher_complete_with_invalid_cipher() );

+   execute( TC_lu_with_invalid_lai() );
+
/* Run this last: at the time of writing this test crashes the MSC */
execute( TC_lu_imsi_auth_tmsi_encr_3_1_log_msc_debug() );
execute( TC_mo_cc_bssmap_clear() );
diff --git a/msc/expected-results.xml b/msc/expected-results.xml
index 83c8010..8eebd57 100644
--- a/msc/expected-results.xml
+++ b/msc/expected-results.xml
@@ -70,6 +70,7 @@
   
   
   
+  
   
   
 

--
To view, visit https://gerrit.osmocom.org/12380
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I676894358259b9cc0f973769ce552ba58a2a58a1
Gerrit-Change-Number: 12380
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling

Change in libosmocore[master]: LCLS: don't send invalid status in HO messages

2018-12-19 Thread Max

Max has posted comments on this change. ( https://gerrit.osmocom.org/12369 )

Change subject: LCLS: don't send invalid status in HO messages
..


Patch Set 4:

This change is ready for review.


--
To view, visit https://gerrit.osmocom.org/12369
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2958a8613627c4e54c004ffa3578c300ed0360b
Gerrit-Change-Number: 12369
Gerrit-PatchSet: 4
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter 
Gerrit-Comment-Date: Wed, 19 Dec 2018 18:59:20 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bsc[master]: LCLS: use enum values instead of magic numbers

2018-12-19 Thread Max

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12378


Change subject: LCLS: use enum values instead of magic numbers
..

LCLS: use enum values instead of magic numbers

Change-Id: I3f49f74edb5400df1b13bb75da3d524f234c8d03
Related: OS#3659
---
M src/osmo-bsc/osmo_bsc_lcls.c
1 file changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/78/12378/1

diff --git a/src/osmo-bsc/osmo_bsc_lcls.c b/src/osmo-bsc/osmo_bsc_lcls.c
index 26b3244..2d5a077 100644
--- a/src/osmo-bsc/osmo_bsc_lcls.c
+++ b/src/osmo-bsc/osmo_bsc_lcls.c
@@ -50,11 +50,11 @@
 enum gsm0808_lcls_status lcls_get_status(struct gsm_subscriber_connection 
*conn)
 {
if (!conn->lcls.fi)
-   return 0xff;
+   return GSM0808_LCLS_STS_NA;

switch (conn->lcls.fi->state) {
case ST_NO_LCLS:
-   return 0xff;
+   return GSM0808_LCLS_STS_NA;
case ST_NOT_YET_LS:
return GSM0808_LCLS_STS_NOT_YET_LS;
case ST_NOT_POSSIBLE_LS:
@@ -76,7 +76,7 @@
enum gsm0808_lcls_status status = lcls_get_status(conn);
struct msgb *msg;

-   if (status == 0xff)
+   if (status == GSM0808_LCLS_STS_NA)
return;

LOGPFSM(conn->lcls.fi, "Sending BSSMAP LCLS NOTIFICATION (%s)\n",
@@ -384,7 +384,7 @@
return;
return;
case LCLS_EV_APPLY_CFG_CSC:
-   if (conn->lcls.config == 0xff)
+   if (conn->lcls.config == GSM0808_LCLS_CFG_NA)
return;
if (lcls_perform_correlation(conn) != 0) {
/* Correlation leads to no result: Not Possible to LS */
@@ -887,7 +887,7 @@
 void bssmap_add_lcls_status_if_needed(struct gsm_subscriber_connection *conn, 
struct msgb *msg)
 {
enum gsm0808_lcls_status status = lcls_get_status(conn);
-   if (status != 0xff) {
+   if (status != GSM0808_LCLS_STS_NA) {
LOGPFSM(conn->fi, "Adding LCLS BSS-Status (%s) to %s\n",
gsm0808_lcls_status_name(status),
gsm0808_bssmap_name(msg->l3h[2]));

--
To view, visit https://gerrit.osmocom.org/12378
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f49f74edb5400df1b13bb75da3d524f234c8d03
Gerrit-Change-Number: 12378
Gerrit-PatchSet: 1
Gerrit-Owner: Max

Change in osmo-bsc[master]: LCLS: use Status for HO-COMPLETE message

2018-12-19 Thread Max

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12379


Change subject: LCLS: use Status for HO-COMPLETE message
..

LCLS: use Status for HO-COMPLETE message

This requires Ib2958a8613627c4e54c004ffa3578c300ed0360b in libosmocore.

Change-Id: I813024ac8eef73c65b49d6d1c6ea1647b97e2fab
---
M src/osmo-bsc/osmo_bsc_bssap.c
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/79/12379/1

diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index 60ec5fb..6268778 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -1096,7 +1096,6 @@
.chosen_channel_present = true,
.chosen_channel = gsm0808_chosen_channel(lchan->type, 
lchan->tch_mode),

-   .lcls_bss_status_present = (lcls_status != 0xff),
.lcls_bss_status = lcls_status,
};


--
To view, visit https://gerrit.osmocom.org/12379
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I813024ac8eef73c65b49d6d1c6ea1647b97e2fab
Gerrit-Change-Number: 12379
Gerrit-PatchSet: 1
Gerrit-Owner: Max

Change in libosmocore[master]: LCLS: drop boolean status_present from HO structs

2018-12-19 Thread Max

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12377


Change subject: LCLS: drop boolean status_present from HO structs
..

LCLS: drop boolean status_present from HO structs

The validity of lcls_bss_status can be determined from the value itself
so we don't need those parameters in the struct.

Change-Id: I2dc3a2896b133298cbf850d68e6898300884bbce
---
M TODO-RELEASE
M include/osmocom/gsm/gsm0808.h
2 files changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/77/12377/1

diff --git a/TODO-RELEASE b/TODO-RELEASE
index 16d96ec..f6ec3ab 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -19,3 +19,4 @@
 libosmogsm osmo_gsup_message   extended with SMS 
related fields
 libosmogsm osmo_gsup_sms_{en|de}code_sm_rp_da  GSUP SM-RP-DA coding 
helpers
 libosmogsm osmo_gsup_sms_{en|de}code_sm_rp_oa  GSUP SM-RP-OA coding 
helpers
+libosmogsm struct gsm0808_handover_completeRemove unnecessary 
boolean parameters
\ No newline at end of file
diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h
index 79d89e5..ccecda4 100644
--- a/include/osmocom/gsm/gsm0808.h
+++ b/include/osmocom/gsm/gsm0808.h
@@ -157,7 +157,6 @@
bool chosen_channel_present;
uint8_t chosen_channel;

-   bool lcls_bss_status_present;
enum gsm0808_lcls_status lcls_bss_status;

/* more items are defined in the spec and may be added later */
@@ -194,7 +193,6 @@
bool speech_codec_chosen_present;
struct gsm0808_speech_codec speech_codec_chosen;

-   bool lcls_bss_status_present;
enum gsm0808_lcls_status lcls_bss_status;

/* more items are defined in the spec and may be added later */

--
To view, visit https://gerrit.osmocom.org/12377
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2dc3a2896b133298cbf850d68e6898300884bbce
Gerrit-Change-Number: 12377
Gerrit-PatchSet: 1
Gerrit-Owner: Max

Change in osmo-msc[master]: libmsc/gsm_04_11.c: accept MT SMS messages over GSUP

2018-12-19 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11920 )

Change subject: libmsc/gsm_04_11.c: accept MT SMS messages over GSUP
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11920
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57357982ca0e51f6722c24a4aa1d0fb3e6caef88
Gerrit-Change-Number: 11920
Gerrit-PatchSet: 7
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Wed, 19 Dec 2018 18:47:30 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: libmsc/gsm_04_11.c: forward MO SMS messages over GSUP

2018-12-19 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11919 )

Change subject: libmsc/gsm_04_11.c: forward MO SMS messages over GSUP
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11919
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d651fde3d608d02f275a74043dc42262aabb1b8
Gerrit-Change-Number: 11919
Gerrit-PatchSet: 7
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 19 Dec 2018 18:47:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: libmsc/VTY: introduce kill-switch for routing SMS over GSUP

2018-12-19 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11918 )

Change subject: libmsc/VTY: introduce kill-switch for routing SMS over GSUP
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11918
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie57685ed2ce1e4c978e775b68fdffe58de44882b
Gerrit-Change-Number: 11918
Gerrit-PatchSet: 7
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 19 Dec 2018 18:47:18 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: abort assignment on Assignment Failure

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12368 )

Change subject: abort assignment on Assignment Failure
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12368/1/src/libmsc/msc_mgcp.c
File src/libmsc/msc_mgcp.c:

https://gerrit.osmocom.org/#/c/12368/1/src/libmsc/msc_mgcp.c@1085
PS1, Line 1085: LOGP(DMGCP, LOGL_DEBUG, "(subscriber:%s) assignment 
failed\n", vlr_subscr_name(conn->vsub));
> Use at least LOGL_NOTICE or LOGL_INFO.
argh!



--
To view, visit https://gerrit.osmocom.org/12368
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I358cfbaf0f44f25148e8b9bafcb9257b1952b35a
Gerrit-Change-Number: 12368
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Wed, 19 Dec 2018 18:40:40 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmocore[master]: add/clean big-endian packed structs (struct_endianess.py)

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11787 )

Change subject: add/clean big-endian packed structs (struct_endianess.py)
..

add/clean big-endian packed structs (struct_endianess.py)

This is 1:1 the result of doing

  cd libosmocore
  ./contrib/struct_endianess.py
  git commit -a

Running struct_endianess.py again should result in no changes.

That means we could include such a check in the gerrit verification job now.

Change-Id: Ia0b99d76932aeb03e93bd0c62d3bf025dec5f9d2
---
M include/osmocom/gprs/protocol/gsm_04_60.h
M include/osmocom/gsm/protocol/gsm_03_41.h
M include/osmocom/gsm/protocol/gsm_04_08.h
M include/osmocom/gsm/protocol/gsm_04_08_gprs.h
M include/osmocom/gsm/protocol/gsm_04_12.h
M include/osmocom/gsm/protocol/gsm_04_14.h
M include/osmocom/gsm/protocol/gsm_08_58.h
M include/osmocom/gsm/protocol/gsm_44_318.h
M tests/endian/endian_test.c
9 files changed, 647 insertions(+), 45 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Max: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Stefan Sperling: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/include/osmocom/gprs/protocol/gsm_04_60.h 
b/include/osmocom/gprs/protocol/gsm_04_60.h
index 96e9ab7..5d5fca9 100644
--- a/include/osmocom/gprs/protocol/gsm_04_60.h
+++ b/include/osmocom/gprs/protocol/gsm_04_60.h
@@ -7,10 +7,12 @@
 #pragma once

 #include 
+#include 

 #if OSMO_IS_LITTLE_ENDIAN == 1
 /* TS 04.60  10.3a.4.1.1 */
 struct gprs_rlc_ul_header_egprs_1 {
+#if OSMO_IS_LITTLE_ENDIAN
uint8_t r:1,
 si:1,
 cv:4,
@@ -26,10 +28,20 @@
 spare_hi:1;
uint8_t spare_lo:6,
 dummy:2;
+#elif OSMO_IS_BIG_ENDIAN
+/* auto-generated from the little endian part above 
(libosmocore/contrib/struct_endianess.py) */
+   uint8_t tfi_hi:2, cv:4, si:1, r:1;
+   uint8_t bsn1_hi:5, tfi_lo:3;
+   uint8_t bsn2_hi:2, bsn1_lo:6;
+   uint8_t bsn2_lo:8;
+   uint8_t spare_hi:1, pi:1, rsb:1, cps:5;
+   uint8_t dummy:2, spare_lo:6;
+#endif
 } __attribute__ ((packed));

 /* TS 04.60  10.3a.4.2.1 */
 struct gprs_rlc_ul_header_egprs_2 {
+#if OSMO_IS_LITTLE_ENDIAN
uint8_t r:1,
 si:1,
 cv:4,
@@ -44,10 +56,19 @@
 spare_hi:5;
uint8_t spare_lo:5,
 dummy:3;
+#elif OSMO_IS_BIG_ENDIAN
+/* auto-generated from the little endian part above 
(libosmocore/contrib/struct_endianess.py) */
+   uint8_t tfi_hi:2, cv:4, si:1, r:1;
+   uint8_t bsn1_hi:5, tfi_lo:3;
+   uint8_t cps_hi:2, bsn1_lo:6;
+   uint8_t spare_hi:5, pi:1, rsb:1, cps_lo:1;
+   uint8_t dummy:3, spare_lo:5;
+#endif
 } __attribute__ ((packed));

 /* TS 04.60  10.3a.4.3.1 */
 struct gprs_rlc_ul_header_egprs_3 {
+#if OSMO_IS_LITTLE_ENDIAN
uint8_t r:1,
 si:1,
 cv:4,
@@ -62,9 +83,17 @@
 pi:1,
 spare:1,
 dummy:1;
+#elif OSMO_IS_BIG_ENDIAN
+/* auto-generated from the little endian part above 
(libosmocore/contrib/struct_endianess.py) */
+   uint8_t tfi_hi:2, cv:4, si:1, r:1;
+   uint8_t bsn1_hi:5, tfi_lo:3;
+   uint8_t cps_hi:2, bsn1_lo:6;
+   uint8_t dummy:1, spare:1, pi:1, rsb:1, spb:2, cps_lo:2;
+#endif
 } __attribute__ ((packed));

 struct gprs_rlc_dl_header_egprs_1 {
+#if OSMO_IS_LITTLE_ENDIAN
uint8_t usf:3,
 es_p:2,
 rrbp:2,
@@ -77,9 +106,18 @@
 bsn2_hi:7;
uint8_t bsn2_lo:3,
 cps:5;
+#elif OSMO_IS_BIG_ENDIAN
+/* auto-generated from the little endian part above 
(libosmocore/contrib/struct_endianess.py) */
+   uint8_t tfi_hi:1, rrbp:2, es_p:2, usf:3;
+   uint8_t bsn1_hi:2, pr:2, tfi_lo:4;
+   uint8_t bsn1_mid:8;
+   uint8_t bsn2_hi:7, bsn1_lo:1;
+   uint8_t cps:5, bsn2_lo:3;
+#endif
 } __attribute__ ((packed));

 struct gprs_rlc_dl_header_egprs_2 {
+#if OSMO_IS_LITTLE_ENDIAN
uint8_t usf:3,
 es_p:2,
 rrbp:2,
@@ -91,9 +129,17 @@
uint8_t bsn1_lo:1,
 cps:3,
 dummy:4;
+#elif OSMO_IS_BIG_ENDIAN
+/* auto-generated from the little endian part above 
(libosmocore/contrib/struct_endianess.py) */
+   uint8_t tfi_hi:1, rrbp:2, es_p:2, usf:3;
+   uint8_t bsn1_hi:2, pr:2, tfi_lo:4;
+   uint8_t bsn1_mid:8;
+   uint8_t dummy:4, cps:3, bsn1_lo:1;
+#endif
 } __attribute__ ((packed));

 struct gprs_rlc_dl_header_egprs_3 {
+#if OSMO_IS_LITTLE_ENDIAN
uint8_t usf:3,
 es_p:2,
 rrbp:2,
@@ -106,10 +152,18 @@
 cps:4,
 spb:2,
 dummy:1;
+#elif OSMO_IS_BIG_ENDIAN
+/* auto-generated from the little endian part above

Change in libosmocore[master]: add/clean big-endian packed structs (struct_endianess.py)

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11787 )

Change subject: add/clean big-endian packed structs (struct_endianess.py)
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11787
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0b99d76932aeb03e93bd0c62d3bf025dec5f9d2
Gerrit-Change-Number: 11787
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Assignee: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Wed, 19 Dec 2018 18:40:02 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: LCLS: don't encode incorrect values

2018-12-19 Thread Max

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12375


Change subject: LCLS: don't encode incorrect values
..

LCLS: don't encode incorrect values

Change-Id: I9ac4bae75f5796e6e11346b8cb34d3897ae70b59
---
M src/gsm/gsm0808.c
1 file changed, 12 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/12375/1

diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index 69da57d..0f9e8df 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -335,8 +335,12 @@
  *  \returns callee-allocated msgb with BSSMAP LCLS NOTIFICATION */
 struct msgb *gsm0808_create_lcls_conn_ctrl_ack(enum gsm0808_lcls_status status)
 {
-   struct msgb *msg = msgb_alloc_headroom(BSSMAP_MSG_SIZE, 
BSSMAP_MSG_HEADROOM,
-  "bssmap: LCLS CONN CTRL ACK");
+   struct msgb *msg;
+
+   if (status == GSM0808_LCLS_STS_NA)
+   return NULL;
+
+   msg = msgb_alloc_headroom(BSSMAP_MSG_SIZE, BSSMAP_MSG_HEADROOM, 
"bssmap: LCLS CONN CTRL ACK");
if (!msg)
return NULL;

@@ -353,8 +357,12 @@
  *  \returns callee-allocated msgb with BSSMAP LCLS NOTIFICATION */
 struct msgb *gsm0808_create_lcls_notification(enum gsm0808_lcls_status status, 
bool break_req)
 {
-   struct msgb *msg = msgb_alloc_headroom(BSSMAP_MSG_SIZE, 
BSSMAP_MSG_HEADROOM,
-  "bssmap: LCLS NOTIFICATION");
+   struct msgb *msg;
+
+   if (status == GSM0808_LCLS_STS_NA)
+   return NULL;
+
+   msg = msgb_alloc_headroom(BSSMAP_MSG_SIZE, BSSMAP_MSG_HEADROOM, 
"bssmap: LCLS NOTIFICATION");
if (!msg)
return NULL;


--
To view, visit https://gerrit.osmocom.org/12375
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ac4bae75f5796e6e11346b8cb34d3897ae70b59
Gerrit-Change-Number: 12375
Gerrit-PatchSet: 1
Gerrit-Owner: Max

Change in libosmocore[master]: LCLS: fix LCLS-CONNECT-CONTROL encoder

2018-12-19 Thread Max

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12376


Change subject: LCLS: fix LCLS-CONNECT-CONTROL encoder
..

LCLS: fix LCLS-CONNECT-CONTROL encoder

Previously it could encode both incorrect values as well as incorrect
message. Let's fix this by explicitly checking for invalid values and
ensuring that at least one of the parameters is valid.

This function have no external or internal users so it's better to fix
type signature as well to match the rest of gsm0808_create_lcls_*().

Change-Id: I7b33a771acbd391c5f9a494d6450edb18511433f
---
M TODO-RELEASE
M include/osmocom/gsm/gsm0808.h
M src/gsm/gsm0808.c
3 files changed, 16 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/76/12376/1

diff --git a/TODO-RELEASE b/TODO-RELEASE
index 16d96ec..8b5f841 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -19,3 +19,4 @@
 libosmogsm osmo_gsup_message   extended with SMS 
related fields
 libosmogsm osmo_gsup_sms_{en|de}code_sm_rp_da  GSUP SM-RP-DA coding 
helpers
 libosmogsm osmo_gsup_sms_{en|de}code_sm_rp_oa  GSUP SM-RP-OA coding 
helpers
+libosmogsm gsm0808_create_lcls_conn_ctrl() API/ABI break: change 
parameters from pointers to plain values
diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h
index 79d89e5..ac88748 100644
--- a/include/osmocom/gsm/gsm0808.h
+++ b/include/osmocom/gsm/gsm0808.h
@@ -92,8 +92,8 @@
   const struct gsm0808_cell_id_list *cil,
   const uint8_t *chan_needed)
   OSMO_DEPRECATED("use gsm0808_create_paging2 
instead");
-struct msgb *gsm0808_create_lcls_conn_ctrl(enum gsm0808_lcls_config *config,
-  enum gsm0808_lcls_control *control);
+struct msgb *gsm0808_create_lcls_conn_ctrl(enum gsm0808_lcls_config config,
+  enum gsm0808_lcls_control control);
 struct msgb *gsm0808_create_lcls_conn_ctrl_ack(enum gsm0808_lcls_status 
status);
 struct msgb *gsm0808_create_lcls_notification(enum gsm0808_lcls_status status, 
bool break_req);

diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index 0f9e8df..6df3ba4 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -312,19 +312,24 @@
  *  \param[in] config LCLS Configuration
  *  \param[in] control LCLS Connection Status Control
  *  \returns callee-allocated msgb with BSSMAP LCLS NOTIFICATION */
-struct msgb *gsm0808_create_lcls_conn_ctrl(enum gsm0808_lcls_config *config,
-  enum gsm0808_lcls_control *control)
+struct msgb *gsm0808_create_lcls_conn_ctrl(enum gsm0808_lcls_config config,
+  enum gsm0808_lcls_control control)
 {
-   struct msgb *msg = msgb_alloc_headroom(BSSMAP_MSG_SIZE, 
BSSMAP_MSG_HEADROOM,
-  "bssmap: LCLS CONN CTRL");
+   struct msgb *msg;
+
+   /* According to NOTE 1 in §3.2.1.91 at least one of the parameters is 
required */
+   if (config == GSM0808_LCLS_CFG_NA && control == GSM0808_LCLS_CSC_NA)
+   return NULL;
+
+   msg = msgb_alloc_headroom(BSSMAP_MSG_SIZE, BSSMAP_MSG_HEADROOM, 
"bssmap: LCLS CONN CTRL");
if (!msg)
return NULL;

msgb_v_put(msg, BSS_MAP_MSG_LCLS_CONNECT_CTRL);
-   if (config)
-   msgb_tv_put(msg, GSM0808_IE_LCLS_CONFIG, *config);
-   if (control)
-   msgb_tv_put(msg, GSM0808_IE_LCLS_CONFIG, *control);
+   if (config != GSM0808_LCLS_CFG_NA)
+   msgb_tv_put(msg, GSM0808_IE_LCLS_CONFIG, config);
+   if (control != GSM0808_LCLS_CSC_NA)
+   msgb_tv_put(msg, GSM0808_IE_LCLS_CONFIG, control);
msg->l3h = msgb_tv_push(msg, BSSAP_MSG_BSS_MANAGEMENT, 
msgb_length(msg));

return msg;

--
To view, visit https://gerrit.osmocom.org/12376
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b33a771acbd391c5f9a494d6450edb18511433f
Gerrit-Change-Number: 12376
Gerrit-PatchSet: 1
Gerrit-Owner: Max

Change in libosmocore[master]: LCLC: fix doc to match type signature

2018-12-19 Thread Max

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12370 )

Change subject: LCLC: fix doc to match type signature
..

LCLC: fix doc to match type signature

Change-Id: I8f7b3dca080ef0e632d47a907154f8404b0ec523
---
M src/gsm/gsm0808_utils.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/src/gsm/gsm0808_utils.c b/src/gsm/gsm0808_utils.c
index a04adde..aa0d3d7 100644
--- a/src/gsm/gsm0808_utils.c
+++ b/src/gsm/gsm0808_utils.c
@@ -526,8 +526,7 @@

 /*! Decode BSSMAP Global Call Reference, 3GPP TS 29.205 Table B 2.1.9.1.
  *  \param[out] gcr Caller-provided memory to store Global Call Reference
- *  \param[in] elem IE value to be decoded
- *  \param[in] len Length of \a elem in bytes
+ *  \param[in] tp IE values to be decoded
  *  \returns number of bytes parsed; negative on error */
 int gsm0808_dec_gcr(struct osmo_gcr_parsed *gcr, const struct tlv_parsed *tp)
 {

--
To view, visit https://gerrit.osmocom.org/12370
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f7b3dca080ef0e632d47a907154f8404b0ec523
Gerrit-Change-Number: 12370
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-mgw[master]: mgcp_client_vty: fix missing talloc_free

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12355 )

Change subject: mgcp_client_vty: fix missing talloc_free
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12355/2/src/libosmo-mgcp-client/mgcp_client_vty.c
File src/libosmo-mgcp-client/mgcp_client_vty.c:

https://gerrit.osmocom.org/#/c/12355/2/src/libosmo-mgcp-client/mgcp_client_vty.c@47
PS2, Line 47:  
(char**)_mgcp_client_conf->local_addr,
> Probably, 'const char *' vs 'char *'?
yea the struct defines it as const, and that won't go with talloc.

It should have been a char[] from the start, but probably not worth the trouble 
to change that



-- 
To view, visit https://gerrit.osmocom.org/12355
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I331b3d53b5eb330b87d798f952077a043674d409
Gerrit-Change-Number: 12355
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 19 Dec 2018 18:38:49 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmocore[master]: rename CELL_IDENT_LAI_AND_LAC to CELL_IDENT_LAI

2018-12-19 Thread Stefan Sperling

Stefan Sperling has uploaded this change for review. ( 
https://gerrit.osmocom.org/12374


Change subject: rename CELL_IDENT_LAI_AND_LAC to CELL_IDENT_LAI
..

rename CELL_IDENT_LAI_AND_LAC to CELL_IDENT_LAI

The name "LAI AND LAC" makes no sense because a LAC
is part of a LAI. Keep the old name available for
API backwards compatibility.

Change-Id: I2749cf75b7b45de0cd43cf4c696a6b6984f5a065
Related: OS#3124
---
M include/osmocom/gsm/protocol/gsm_08_08.h
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/74/12374/1

diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h 
b/include/osmocom/gsm/protocol/gsm_08_08.h
index cb9fe01..676d1cf 100644
--- a/include/osmocom/gsm/protocol/gsm_08_08.h
+++ b/include/osmocom/gsm/protocol/gsm_08_08.h
@@ -18,14 +18,15 @@
CELL_IDENT_LAC_AND_CI   = 1,
CELL_IDENT_CI   = 2,
CELL_IDENT_NO_CELL  = 3,
-   CELL_IDENT_LAI_AND_LAC  = 4,
+   CELL_IDENT_LAI  = 4,
CELL_IDENT_LAC  = 5,
CELL_IDENT_BSS  = 6,
CELL_IDENT_UTRAN_PLMN_LAC_RNC   = 8,
CELL_IDENT_UTRAN_RNC= 9,
CELL_IDENT_UTRAN_LAC_RNC= 10,
 };
-
+/* Keep this misnamed CELL_IDENT for API backwards compatibility (see 
OS#3124). */
+#define CELL_IDENT_LAI_AND_LAC CELL_IDENT_LAI

 /* GSM 08.06 § 6.3 */
 enum BSSAP_MSG_TYPE {

--
To view, visit https://gerrit.osmocom.org/12374
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2749cf75b7b45de0cd43cf4c696a6b6984f5a065
Gerrit-Change-Number: 12374
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling

Change in osmo-hlr[master]: gsupclient: introduce osmo_gsup_client_enc_send()

2018-12-19 Thread Vadim Yanitskiy

Vadim Yanitskiy has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11989 )

Change subject: gsupclient: introduce osmo_gsup_client_enc_send()
..

gsupclient: introduce osmo_gsup_client_enc_send()

Several parts of OsmoMSC (e.g. GSM 04.11, 09.11, etc.) are dealing
with GSUP message encoding and sending towards OsmoHLR. In order
to avoid code duplication, let's have a shared function here.

Change-Id: I0589ff27933e9bca2bcf93b8259004935778db8f
---
M include/osmocom/gsupclient/gsup_client.h
M src/gsupclient/gsup_client.c
2 files changed, 39 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Stefan Sperling: Looks good to me, but someone else must approve
  Vadim Yanitskiy: Looks good to me, approved



diff --git a/include/osmocom/gsupclient/gsup_client.h 
b/include/osmocom/gsupclient/gsup_client.h
index 95163cd..154e3e0 100644
--- a/include/osmocom/gsupclient/gsup_client.h
+++ b/include/osmocom/gsupclient/gsup_client.h
@@ -24,6 +24,7 @@
 #include 
 #include 
 #include 
+#include 

 /* a loss of GSUP between MSC and HLR is considered quite serious, let's try 
to recover as quickly as
  * possible.  Even one new connection attempt per second should be quite 
acceptable until the link is
@@ -70,5 +71,7 @@

 void osmo_gsup_client_destroy(struct osmo_gsup_client *gsupc);
 int osmo_gsup_client_send(struct osmo_gsup_client *gsupc, struct msgb *msg);
+int osmo_gsup_client_enc_send(struct osmo_gsup_client *gsupc,
+ const struct osmo_gsup_message *gsup_msg);
 struct msgb *osmo_gsup_client_msgb_alloc(void);

diff --git a/src/gsupclient/gsup_client.c b/src/gsupclient/gsup_client.c
index f259bdc..c8408fd 100644
--- a/src/gsupclient/gsup_client.c
+++ b/src/gsupclient/gsup_client.c
@@ -360,6 +360,42 @@
return 0;
 }

+/*! Encode and send a GSUP message.
+ * \param[in] gsupcGSUP client.
+ * \param[in] gsup_msg GSUP message to be sent.
+ * \returns 0 in case of success, negative on error.
+ */
+int osmo_gsup_client_enc_send(struct osmo_gsup_client *gsupc,
+ const struct osmo_gsup_message *gsup_msg)
+{
+   struct msgb *gsup_msgb;
+   int rc;
+
+   gsup_msgb = osmo_gsup_client_msgb_alloc();
+   if (!gsup_msgb) {
+   LOGP(DLGSUP, LOGL_ERROR, "Couldn't allocate GSUP message\n");
+   return -ENOMEM;
+   }
+
+   rc = osmo_gsup_encode(gsup_msgb, gsup_msg);
+   if (rc) {
+   LOGP(DLGSUP, LOGL_ERROR, "Couldn't encode GSUP message\n");
+   goto error;
+   }
+
+   rc = osmo_gsup_client_send(gsupc, gsup_msgb);
+   if (rc) {
+   LOGP(DLGSUP, LOGL_ERROR, "Couldn't send GSUP message\n");
+   goto error;
+   }
+
+   return 0;
+
+error:
+   talloc_free(gsup_msgb);
+   return rc;
+}
+
 struct msgb *osmo_gsup_client_msgb_alloc(void)
 {
return msgb_alloc_headroom(4000, 64, __func__);

--
To view, visit https://gerrit.osmocom.org/11989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0589ff27933e9bca2bcf93b8259004935778db8f
Gerrit-Change-Number: 11989
Gerrit-PatchSet: 9
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-hlr[master]: gsupclient: introduce osmo_gsup_client_enc_send()

2018-12-19 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11989 )

Change subject: gsupclient: introduce osmo_gsup_client_enc_send()
..


Patch Set 9: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0589ff27933e9bca2bcf93b8259004935778db8f
Gerrit-Change-Number: 11989
Gerrit-PatchSet: 9
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 19 Dec 2018 18:28:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-hlr[master]: gsupclient: introduce osmo_gsup_client_enc_send()

2018-12-19 Thread Stefan Sperling

Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/11989 )

Change subject: gsupclient: introduce osmo_gsup_client_enc_send()
..


Patch Set 9: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0589ff27933e9bca2bcf93b8259004935778db8f
Gerrit-Change-Number: 11989
Gerrit-PatchSet: 9
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 19 Dec 2018 18:20:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-hlr[master]: gsupclient: introduce osmo_gsup_client_enc_send()

2018-12-19 Thread Vadim Yanitskiy

Hello Stefan Sperling, Max, Neels Hofmeyr, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11989

to look at the new patch set (#9).

Change subject: gsupclient: introduce osmo_gsup_client_enc_send()
..

gsupclient: introduce osmo_gsup_client_enc_send()

Several parts of OsmoMSC (e.g. GSM 04.11, 09.11, etc.) are dealing
with GSUP message encoding and sending towards OsmoHLR. In order
to avoid code duplication, let's have a shared function here.

Change-Id: I0589ff27933e9bca2bcf93b8259004935778db8f
---
M include/osmocom/gsupclient/gsup_client.h
M src/gsupclient/gsup_client.c
2 files changed, 39 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/89/11989/9
--
To view, visit https://gerrit.osmocom.org/11989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0589ff27933e9bca2bcf93b8259004935778db8f
Gerrit-Change-Number: 11989
Gerrit-PatchSet: 9
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-hlr[master]: gsupclient: introduce osmo_gsup_client_enc_send()

2018-12-19 Thread Vadim Yanitskiy

Hello Stefan Sperling, Max, Neels Hofmeyr, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11989

to look at the new patch set (#8).

Change subject: gsupclient: introduce osmo_gsup_client_enc_send()
..

gsupclient: introduce osmo_gsup_client_enc_send()

Several parts of OsmoMSC (e.g. GSM 04.11, 09.11, etc.) are dealing
with GSUP message encoding and sending towards OsmoHLR. In order
to avoid code duplication, let's have a shared function here.

Change-Id: I0589ff27933e9bca2bcf93b8259004935778db8f
---
M include/osmocom/gsupclient/gsup_client.h
M src/gsupclient/gsup_client.c
2 files changed, 39 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/89/11989/8
--
To view, visit https://gerrit.osmocom.org/11989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0589ff27933e9bca2bcf93b8259004935778db8f
Gerrit-Change-Number: 11989
Gerrit-PatchSet: 8
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-hlr[master]: gsupclient: introduce osmo_gsup_client_enc_send()

2018-12-19 Thread Neels Hofmeyr

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11989 )

Change subject: gsupclient: introduce osmo_gsup_client_enc_send()
..


Patch Set 7: Code-Review+1

(3 comments)

if you like, fix the doc first

https://gerrit.osmocom.org/#/c/11989/4/src/gsupclient/gsup_client.c
File src/gsupclient/gsup_client.c:

https://gerrit.osmocom.org/#/c/11989/4/src/gsupclient/gsup_client.c@366
PS4, Line 366:  * \returns 0 in case of success, otherwise -errno
> Ok.
osmo_gsup_client_{send,encode}() both return negative on error, and you're 
returning their rc, so this should also say "negative"


https://gerrit.osmocom.org/#/c/11989/4/src/gsupclient/gsup_client.c@381
PS4, Line 381:  if (rc) {
> > to make reading code easier. […]
if (rc) is fine


https://gerrit.osmocom.org/#/c/11989/4/src/gsupclient/gsup_client.c@387
PS4, Line 387:  if (rc) {
> And here too. It's a common practice to expect 0 and nothing else.
if (rc) is fine



--
To view, visit https://gerrit.osmocom.org/11989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0589ff27933e9bca2bcf93b8259004935778db8f
Gerrit-Change-Number: 11989
Gerrit-PatchSet: 7
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 19 Dec 2018 18:08:05 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in libosmocore[master]: TLV: add convenience function for 1-byte values

2018-12-19 Thread Max

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12373


Change subject: TLV: add convenience function for 1-byte values
..

TLV: add convenience function for 1-byte values

Similar to existing 16 and 32 bit value helpers but simpler because we
don't have to worry about alingment and endianness.

Change-Id: Ic0a148bd04b8860e321f509fdcd913f688c8e920
---
M include/osmocom/gsm/tlv.h
1 file changed, 16 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/73/12373/1

diff --git a/include/osmocom/gsm/tlv.h b/include/osmocom/gsm/tlv.h
index 4c39264..621a282 100644
--- a/include/osmocom/gsm/tlv.h
+++ b/include/osmocom/gsm/tlv.h
@@ -495,6 +495,22 @@
(TLVP_PRES_LEN(_tp, tag, min_len)? (_tp)->lv[tag].val : NULL)


+/*! Obtain 1-byte TLV element
+ *  \param[in] tp pointer to \ref tlv_parsed
+ *  \param[in] tag the Tag to look for
+ *  \param[in] default_val default value to use if tag not available
+ *  \returns the 1st byte of value with a given tag or default_val if tag was 
not found
+ */
+static inline uint8_t tlvp_val8(const struct tlv_parsed *tp, uint8_t tag, 
uint8_t default_val)
+{
+   const uint8_t *res = TLVP_VAL_MINLEN(tp, tag, 1);
+
+   if (res)
+   return res[0];
+
+   return default_val;
+}
+
 /*! Align given TLV element with 16 bit value to an even address
  *  \param[in] tp pointer to \ref tlv_parsed
  *  \param[in] pos element to return

--
To view, visit https://gerrit.osmocom.org/12373
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0a148bd04b8860e321f509fdcd913f688c8e920
Gerrit-Change-Number: 12373
Gerrit-PatchSet: 1
Gerrit-Owner: Max

1 2 >

1 - 100 of 176 matches

Mail list logo