Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]
joewitt commented on code in PR #8892: URL: https://github.com/apache/nifi/pull/8892#discussion_r1619329171 ## nifi-assembly/pom.xml: ## @@ -350,6 +350,42 @@ language governing permissions and limitations under the License. --> 2.0.0-SNAPSHOT nar + +org.apache.nifi +nifi-generic-db-adapter-provider-nar +2.0.0-SNAPSHOT +nar + + +org.apache.nifi +nifi-oracle-db-adapter-provider-nar Review Comment: I dont think I realized we had a 'database-adapter-api' and a 'database-adapter-provider-api'. The word 'adapter' is generic/broad as is 'provider' so it just looks odd having them both side by side. I dont know enough about why we need these two separate APIs so I guess I'll back out of this comment for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13284: Only saving canvas routes that are not edit or history [nifi]
rfellows merged PR #8891: URL: https://github.com/apache/nifi/pull/8891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13269] - Order parameter reference list alphabetically [nifi]
mcgilman merged PR #8885: URL: https://github.com/apache/nifi/pull/8885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13284: Only saving canvas routes that are not edit or history [nifi]
rfellows commented on PR #8891: URL: https://github.com/apache/nifi/pull/8891#issuecomment-2137990180 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13307 Replace KeyStoreUtils with nifi-security-ssl Builders [nifi]
exceptionfactory opened a new pull request, #8895: URL: https://github.com/apache/nifi/pull/8895 # Summary [NIFI-13307](https://issues.apache.org/jira/browse/NIFI-13307) Replaces `KeyStoreUtils` in `nifi-security-utils` with Builder classes from the `nifi-security-ssl` module. The `nifi-security-ssl` module has no external dependencies and provides specific Builder interfaces and classes to instantiate various TLS components. These classes are already widely used throughout the system, leaving minimal references to `KeyStoreUtils`. In addition, adjusting the custom validation logic in `StandardSSLContextService` reduced unnecessary loading of KeyStore files. Additional changes include removing a number of unused test classes from `nifi-web-api`, some of which had references to `KeyStoreUtils` methods. Other adjustments include relocating the `HashService` and `HashAlgorithm` classes to the `nifi-standard-processors` module, since the `CryptographicHashContent` Processor was the only consumer of these specialized components. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]
takraj commented on code in PR #8892: URL: https://github.com/apache/nifi/pull/8892#discussion_r1619267802 ## nifi-assembly/pom.xml: ## @@ -350,6 +350,42 @@ language governing permissions and limitations under the License. --> 2.0.0-SNAPSHOT nar + +org.apache.nifi +nifi-generic-db-adapter-provider-nar +2.0.0-SNAPSHOT +nar Review Comment: @exceptionfactory Sounds reasonable. I'll try to apply this concept to my PR soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]
takraj commented on code in PR #8892: URL: https://github.com/apache/nifi/pull/8892#discussion_r1619227955 ## nifi-assembly/pom.xml: ## @@ -350,6 +350,42 @@ language governing permissions and limitations under the License. --> 2.0.0-SNAPSHOT nar + +org.apache.nifi +nifi-generic-db-adapter-provider-nar +2.0.0-SNAPSHOT +nar + + +org.apache.nifi +nifi-oracle-db-adapter-provider-nar Review Comment: I'm fine with removing the word 'provider' from the controller services, but I'm not sure if it's a good practice, since we have actual 'adapter' classes, that are instantiated by the 'provider' classes. If you feel like you have better wording for this concept, then I'm OK with renaming. Or did you mean this 'adapter' - 'provider' abstraction does not seem useful? IMHO it adds some flexibility to how we organize, or combine various adapters, because for example a single controller service for MSSQL can provide adapters for multiple versions of that dialect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]
exceptionfactory commented on code in PR #8892: URL: https://github.com/apache/nifi/pull/8892#discussion_r1619219742 ## nifi-assembly/pom.xml: ## @@ -350,6 +350,42 @@ language governing permissions and limitations under the License. --> 2.0.0-SNAPSHOT nar + +org.apache.nifi +nifi-generic-db-adapter-provider-nar +2.0.0-SNAPSHOT +nar Review Comment: For clarification, I think the Service interface should be for an individual dialect, but all the implementations should be packaged in a single NAR. This should allow Apache NiFi-maintained implementations to be distributed easily, but also allow for external development of other implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]
takraj commented on code in PR #8892: URL: https://github.com/apache/nifi/pull/8892#discussion_r1619203022 ## nifi-extension-bundles/nifi-extension-utils/nifi-database-adapters/nifi-database-adapter-api/pom.xml: ## @@ -0,0 +1,36 @@ +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd;> + +4.0.0 + +org.apache.nifi +nifi-database-adapters +2.0.0-SNAPSHOT + + +nifi-database-adapter-api +jar + + +org.apache.nifi +nifi-utils Review Comment: OK I'll check if I can remove this dependency. I used DBCP CS as a template, while creating these. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]
takraj commented on code in PR #8892: URL: https://github.com/apache/nifi/pull/8892#discussion_r1619200158 ## nifi-assembly/pom.xml: ## @@ -350,6 +350,42 @@ language governing permissions and limitations under the License. --> 2.0.0-SNAPSHOT nar + +org.apache.nifi +nifi-generic-db-adapter-provider-nar +2.0.0-SNAPSHOT +nar Review Comment: I was not sure about what granularity would be accaptable. I'm fine with combining them all together in a single controller service. The user could then select the needed dialect from a dropdown. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13299: Adding min validators where appropriate [nifi]
mcgilman opened a new pull request, #8894: URL: https://github.com/apache/nifi/pull/8894 NIFI-13299: - Adding min validators where appropriate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13030 Adding endpoint for comparing versions of registered flows [nifi]
bbende commented on code in PR #8670:
URL: https://github.com/apache/nifi/pull/8670#discussion_r1619124970
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java:
##
@@ -2104,6 +2203,24 @@ public Response getVersions(
return
generateOkResponse(versionedFlowSnapshotMetadataSetEntity).build();
}
+private static FlowComparisonEntity limitDifferences(final
FlowComparisonEntity original, final int offset, final int limit) {
+final List limited =
PaginationHelper.paginateByContainedItems(
+original.getComponentDifferences(), offset, limit,
ComponentDifferenceDTO::getDifferences, FlowResource::limitDifferences);
+final FlowComparisonEntity result = new FlowComparisonEntity();
+result.setComponentDifferences(new HashSet<>(limited));
+return result;
+}
+
+private static ComponentDifferenceDTO limitDifferences(final
ComponentDifferenceDTO original, final List partial) {
+final ComponentDifferenceDTO result = new ComponentDifferenceDTO();
+result.setComponentType(original.getComponentType());
+result.setComponentId(original.getComponentId());
+result.setComponentName(original.getComponentName());
+result.setProcessGroupId(original.getProcessGroupId());
+result.setDifferences(partial);
+return result;
+}
Review Comment:
Just want to ask whether we think we truly need paging here. Generally most
of NiFi's REST APIs don't page anything, and all of the paging is done on the
client side. The reason is because the slow part is not sending a large
response from server to client, it is the rendering of the whole response on
the client. So as long as the client is rendering pages, it usually works
totally fine.
If we do want paging, then shouldn't the entity being returned contain some
paging info? At a minimum I would think we need to return the total rows in the
result set, otherwise how can a client know when to page to?
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java:
##
@@ -2057,6 +2062,100 @@ public Response getDetails(
return generateOkResponse(flowDetails).build();
}
+@GET
+@Consumes(MediaType.WILDCARD)
+@Produces(MediaType.APPLICATION_JSON)
+
@Path("registries/{registry-id}/branches/{branch-id-a}/buckets/{bucket-id-a}/flows/{flow-id-a}/{version-a}/diff/branches/{branch-id-b}/buckets/{bucket-id-b}/flows/{flow-id-b}/{version-b}")
Review Comment:
Is the intended use case for this to right-click on a process group under
version control and be able to choose something like `Compare With` and then
choose another version to compare with? is there any other scenario where we
want to compare two flow versions?
I'm asking because if it is limited to the first scenario I described, we
may want to consider a more specific API to the PG, similar to
`process-groups/{id}local-changes`, maybe `/process-groups/{id}/diff`. Then it
would only need the parameters for the other flow version to compare to, which
could be added to the path, or as query params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13030 Adding endpoint for comparing versions of registered flows [nifi]
bbende commented on code in PR #8670:
URL: https://github.com/apache/nifi/pull/8670#discussion_r1619117358
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java:
##
@@ -2057,6 +2062,100 @@ public Response getDetails(
return generateOkResponse(flowDetails).build();
}
+@GET
+@Consumes(MediaType.WILDCARD)
+@Produces(MediaType.APPLICATION_JSON)
+
@Path("registries/{registry-id}/branches/{branch-id-a}/buckets/{bucket-id-a}/flows/{flow-id-a}/{version-a}/diff/branches/{branch-id-b}/buckets/{bucket-id-b}/flows/{flow-id-b}/{version-b}")
Review Comment:
Is the intended use case for this to right-click on a process group under
version control and be able to choose something like `Compare With` and then
choose another version to compare with? is there any other scenario where we
want to compare two flow versions?
I'm asking because if it is limited to the first scenario I described, we
may want to consider a more specific API to the PG, similar to
`process-groups/{id}/local-changes`, maybe `/process-groups/{id}/diff`. Then it
would only need the parameters for the other flow version to compare to, which
could be added to the path, or as query params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] MINIFICPP-2388 Fix warnings on Windows build [nifi-minifi-cpp]
lordgamez opened a new pull request, #1805: URL: https://github.com/apache/nifi-minifi-cpp/pull/1805 https://issues.apache.org/jira/browse/MINIFICPP-2388 Depends on https://github.com/apache/nifi-minifi-cpp/pull/1802 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]
joewitt commented on code in PR #8892: URL: https://github.com/apache/nifi/pull/8892#discussion_r1619060507 ## nifi-assembly/pom.xml: ## @@ -350,6 +350,42 @@ language governing permissions and limitations under the License. --> 2.0.0-SNAPSHOT nar + +org.apache.nifi +nifi-generic-db-adapter-provider-nar +2.0.0-SNAPSHOT +nar + + +org.apache.nifi +nifi-oracle-db-adapter-provider-nar Review Comment: Is the word 'provider' helpful in these? It seems to me we have database adapter api and database adapters that implement the api. Ie we have nifi-database-adapter-api is the api module. nifi-oracle-db-adapter-nar implements the api specific to oracle column/types. Provider seems not needed. Can you share more if that is helpful? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]
joewitt commented on code in PR #8892: URL: https://github.com/apache/nifi/pull/8892#discussion_r1619054989 ## nifi-extension-bundles/nifi-extension-utils/nifi-database-adapters/nifi-database-adapter-api/pom.xml: ## @@ -0,0 +1,36 @@ +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd;> + +4.0.0 + +org.apache.nifi +nifi-database-adapters +2.0.0-SNAPSHOT + + +nifi-database-adapter-api +jar + + +org.apache.nifi +nifi-utils Review Comment: Can we dump this since commons-lang is there? it seems nifi-utils is being used for a simple string utils class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13231 Added Private key authentication for GitHubFlowRegistryClient [nifi]
exceptionfactory commented on code in PR #8890:
URL: https://github.com/apache/nifi/pull/8890#discussion_r1618922463
##
nifi-extension-bundles/nifi-github-bundle/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubFlowRegistryClient.java:
##
@@ -128,7 +128,22 @@ public class GitHubFlowRegistryClient extends
AbstractFlowRegistryClient {
.sensitive(true)
.dependsOn(AUTHENTICATION_TYPE,
GitHubAuthenticationType.APP_INSTALLATION_TOKEN.name())
.build();
-
+static final PropertyDescriptor PRIVATE_KEY = new
PropertyDescriptor.Builder()
+.name("Private Key")
+.description("Private RSA key generated foo Github App to use for
Authentication")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.required(true)
+.sensitive(true)
+.dependsOn(AUTHENTICATION_TYPE,
GitHubAuthenticationType.PRIVATE_KEY.name())
+.build();
+static final PropertyDescriptor APP_ID = new PropertyDescriptor.Builder()
+.name("APP ID")
Review Comment:
```suggestion
.name("App ID")
```
##
nifi-extension-bundles/nifi-github-bundle/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubFlowRegistryClient.java:
##
@@ -128,7 +128,22 @@ public class GitHubFlowRegistryClient extends
AbstractFlowRegistryClient {
.sensitive(true)
.dependsOn(AUTHENTICATION_TYPE,
GitHubAuthenticationType.APP_INSTALLATION_TOKEN.name())
.build();
-
+static final PropertyDescriptor PRIVATE_KEY = new
PropertyDescriptor.Builder()
+.name("Private Key")
+.description("Private RSA key generated foo Github App to use for
Authentication")
Review Comment:
Recommend the following wording adjustments, also noting that PKCS 8 is
required.
```suggestion
.description("RSA private key associated with GitHub App to use
for authentication. The private key must be PEM-encoded using PKCS 8.")
```
##
nifi-extension-bundles/nifi-github-bundle/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubFlowRegistryClient.java:
##
@@ -128,7 +128,22 @@ public class GitHubFlowRegistryClient extends
AbstractFlowRegistryClient {
.sensitive(true)
.dependsOn(AUTHENTICATION_TYPE,
GitHubAuthenticationType.APP_INSTALLATION_TOKEN.name())
.build();
-
+static final PropertyDescriptor PRIVATE_KEY = new
PropertyDescriptor.Builder()
+.name("Private Key")
+.description("Private RSA key generated foo Github App to use for
Authentication")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.required(true)
+.sensitive(true)
+.dependsOn(AUTHENTICATION_TYPE,
GitHubAuthenticationType.PRIVATE_KEY.name())
+.build();
+static final PropertyDescriptor APP_ID = new PropertyDescriptor.Builder()
+.name("APP ID")
+.description("App Id of Github App to use for Authentication")
Review Comment:
```suggestion
.description("Identifier of GitHub App to use for
authentication")
```
##
nifi-extension-bundles/nifi-github-bundle/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubRepositoryClient.java:
##
@@ -35,10 +40,11 @@
import java.io.FileNotFoundException;
import java.io.IOException;
import java.io.InputStream;
-import java.util.List;
-import java.util.Objects;
-import java.util.Optional;
-import java.util.Set;
+import java.io.StringReader;
+import java.security.KeyFactory;
+import java.security.PrivateKey;
+import java.security.spec.PKCS8EncodedKeySpec;
+import java.util.*;
Review Comment:
Asterisk imports are not permitted in the the Checkstyle configuration.
##
nifi-extension-bundles/nifi-github-bundle/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubRepositoryClient.java:
##
@@ -379,6 +392,41 @@ public GHContent deleteContent(final String filePath,
final String commitMessage
});
}
+/**
+ * Creates the JwtToken for Authentication with Private Key
+ *
+ * @param pemString is the PKCS#1 String
+ * @return the JwtToken
+ *
+ * @throws Exception if an error occurs parsing key
+ */
+private static String loadPrivateKeyFromPEM(String pemString) throws
Exception {
+long nowMillis = System.currentTimeMillis();
+long expMillis = nowMillis + 60; // Token validity 10 minutes
+Date now = new Date(nowMillis);
+Date exp = new Date(expMillis);
+PEMParser pemParser = new PEMParser(new StringReader(pemString));
+Object object = pemParser.readObject();
+pemParser.close();
+
+if (object instanceof PEMKeyPair) {
+PEMKeyPair keyPair = (PEMKeyPair) object;
+RSAPrivateKey rsaPrivateKey =
Re: [PR] NIFI-13311: Turn DB adapters into controller services [nifi]
joewitt commented on code in PR #8892: URL: https://github.com/apache/nifi/pull/8892#discussion_r1619049108 ## nifi-assembly/pom.xml: ## @@ -350,6 +350,42 @@ language governing permissions and limitations under the License. --> 2.0.0-SNAPSHOT nar + +org.apache.nifi +nifi-generic-db-adapter-provider-nar +2.0.0-SNAPSHOT +nar Review Comment: Can you share more about the benefit of each of these being their own nar? If i understand each nar correctly it does not contain provider specific things like mssql/etc.. So it seems like they can all be together. If something had bespoke requirements splitting them is good. Can you share more on what you had in mind? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13126: Add Impala DB Adapter [nifi]
takraj commented on PR #8728: URL: https://github.com/apache/nifi/pull/8728#issuecomment-2137622470 @mattyb149 @joewitt I have created a PoC / PR implementing the concept of having controller services instead of fixed lists of supported SQL dialects. If we accept this solution, then Impala dialect is not necessarily needed to be included & maintained in the NiFi repository. Please have a look: https://github.com/apache/nifi/pull/8892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13311: Turn DB adapters into controller services [nifi]
takraj opened a new pull request, #8892: URL: https://github.com/apache/nifi/pull/8892 # Summary [NIFI-13311](https://issues.apache.org/jira/browse/NIFI-13311) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### UI Contributions - [x] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13309 Lookup compatible bundles even if previous flow was empty [nifi]
briansolo1985 commented on PR #: URL: https://github.com/apache/nifi/pull/#issuecomment-2137473601 Thanks for submitting the change and incorporating the suggestions. +1 from my side -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13269] - Order parameter reference list alphabetically [nifi]
mcgilman commented on PR #8885: URL: https://github.com/apache/nifi/pull/8885#issuecomment-2137363552 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13303] - Remove text indicating property verification is disabled. [nifi]
mcgilman merged PR #8884: URL: https://github.com/apache/nifi/pull/8884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13289 Add tooltip to NewCanvas item [nifi]
rfellows commented on code in PR #8870:
URL: https://github.com/apache/nifi/pull/8870#discussion_r1618830563
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/tooltips/nifi-tooltip.directive.ts:
##
@@ -58,11 +59,29 @@ export class NifiTooltipDirective implements OnDestroy {
}
}
+@HostListener('mousemove')
+mouseMove() {
+if (this.overlayRef?.hasAttached() && this.tooltipDisabled) {
+this.overlayRef?.detach();
+} else {
+this.attach();
Review Comment:
I don't think this attach is needed. In fact it causes console errors...
https://github.com/apache/nifi/assets/713866/e9060af1-ddb5-44f5-9e24-9089513668e4;>
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/tooltips/nifi-tooltip.directive.ts:
##
@@ -58,11 +59,29 @@ export class NifiTooltipDirective implements OnDestroy {
}
}
+@HostListener('mousemove')
+mouseMove() {
+if (this.overlayRef?.hasAttached() && this.tooltipDisabled) {
+this.overlayRef?.detach();
+} else {
+this.attach();
+}
+}
+
+@HostListener('mouseup')
+mouseup() {
+this.attach();
Review Comment:
Nice touch but i think this should also be guarded. It currently can cause
an error (similar to the above) if you mousedown outside of the target object
and then mouseup over it. The tooltip will render based on the mouseenter and
then try to attach another on the mouseup.
```suggestion
if (!this.overlayRef?.hasAttached()) {
this.attach();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13303] - Remove text indicating property verification is disabled. [nifi]
mcgilman commented on PR #8884: URL: https://github.com/apache/nifi/pull/8884#issuecomment-2137298095 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13309 Lookup compatible bundles even if previous flow was empty [nifi]
ferencerdei commented on code in PR #:
URL: https://github.com/apache/nifi/pull/#discussion_r1618793587
##
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/serialization/VersionedFlowSynchronizer.java:
##
@@ -257,6 +257,10 @@ private void mapCompatibleBundles(final DataFlow
proposedFlow, final ExtensionMa
final Set missingComponentIds =
proposedFlow.getMissingComponents();
final VersionedDataflow dataflow = proposedFlow.getVersionedDataflow();
+if (dataflow == null) {
Review Comment:
changed it to use the recommended method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13309 Lookup compatible bundles even if previous flow was empty [nifi]
simonbence commented on code in PR #:
URL: https://github.com/apache/nifi/pull/#discussion_r1618732933
##
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/serialization/VersionedFlowSynchronizer.java:
##
@@ -257,6 +257,10 @@ private void mapCompatibleBundles(final DataFlow
proposedFlow, final ExtensionMa
final Set missingComponentIds =
proposedFlow.getMissingComponents();
final VersionedDataflow dataflow = proposedFlow.getVersionedDataflow();
+if (dataflow == null) {
Review Comment:
I propose the usage of the `isFlowEmpty`method here, which covers more
possible variations for an empty `dataFlow`. I tested it via standard NiFi and
it worked properly during initial startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13030 Adding endpoint for comparing versions of registered flows [nifi]
simonbence commented on code in PR #8670:
URL: https://github.com/apache/nifi/pull/8670#discussion_r1618730811
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/util/Interval.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.web.util;
+
+public interface Interval {
+
+enum RelativePosition {
+/**
+ * The compared interval ends before the actual, there is no
intersection.
+ */
+BEFORE,
+
+/**
+ * The compared interval exceeds the actual both at the low and high
ends.
+ */
+EXCEEDS,
+
+/**
+ * The compared interval's tail (but not the whole interval)
intersects the actual interval (part of it or the whole actual interval).
+ */
+TAIL_INTERSECTS,
+
+/**
+ * The compared interval is within the actual interval. It can match
with the actual or contained by that.
+ */
+WITHIN,
+
+/**
+ *The compared interval's head (but not the whole interval) intersects
the actual interval (part of it or the whole actual interval).
+ */
+HEAD_INTERSECTS,
+
+/**
+ * The compared interval starts after the actual, there is no
intersection.
+ */
+AFTER,
+}
+
+/**
+ * Relative position of the "other" interval compared to this.
+ *
+ * @param otherIntervalLowerBoundary Lower boundary of the compared
interval.
+ * @param otherIntervalHigherBoundary Higher boundary of the compared
interval.
+ *
+ * @return Returns the relative position of the "other" interval compared
to this interval. For example: if the result
+ * is BEFORE, read it as: the other interval ends BEFORE the
actual (and there is no intersection between them).
+ */
+RelativePosition getRelativePositionOf(final int
otherIntervalLowerBoundary, final int otherIntervalHigherBoundary);
+
+/**
+ * @return Returns an interval instance with closed low and open high
boundary.
+ */
+static Interval getClosedOpenInterval(final int lowerBoundary, final int
higherBoundary) {
Review Comment:
I slightly disagree with this primarily because of the static method usage
but I have no strong feelings about it. Please expect a commit soonish
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] MINIFICPP-2390 Save build type and build dir in python bootstrap state [nifi-minifi-cpp]
lordgamez opened a new pull request, #1804: URL: https://github.com/apache/nifi-minifi-cpp/pull/1804 https://issues.apache.org/jira/browse/MINIFICPP-2390 - Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13231 Added Private key authentication for GitHubFlowRegistryClient [nifi]
maybevanshh opened a new pull request, #8890: URL: https://github.com/apache/nifi/pull/8890 # Summary [NIFI-13231](https://issues.apache.org/jira/browse/NIFI-13231) This PR adds function to Generate Jwt Token in GitHubFlowRegistryClient and PrivateKey Authentication support. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Added Private key authentication for GitHubFlowRegistryClient [nifi]
maybevanshh closed pull request #8889: Added Private key authentication for GitHubFlowRegistryClient URL: https://github.com/apache/nifi/pull/8889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Added Private key authentication for GitHubFlowRegistryClient [nifi]
maybevanshh opened a new pull request, #8889: URL: https://github.com/apache/nifi/pull/8889 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13309 Lookup compatible bundles even if previous flow was empty [nifi]
ferencerdei opened a new pull request, #: URL: https://github.com/apache/nifi/pull/ # Summary [NIFI-13309](https://issues.apache.org/jira/browse/NIFI-13309) This change modifies the VersionedFlowSyncronizer to call mapCompatibleBundles even if the original flow was empty. An additional null check was added to the proposed dataFlow instead to prevent exception during NiFi startup. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13030 Adding endpoint for comparing versions of registered flows [nifi]
pgyori commented on code in PR #8670:
URL: https://github.com/apache/nifi/pull/8670#discussion_r1618578862
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/util/Interval.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.web.util;
+
+public interface Interval {
+
+enum RelativePosition {
+/**
+ * The compared interval ends before the actual, there is no
intersection.
+ */
+BEFORE,
+
+/**
+ * The compared interval exceeds the actual both at the low and high
ends.
+ */
+EXCEEDS,
+
+/**
+ * The compared interval's tail (but not the whole interval)
intersects the actual interval (part of it or the whole actual interval).
+ */
+TAIL_INTERSECTS,
+
+/**
+ * The compared interval is within the actual interval. It can match
with the actual or contained by that.
+ */
+WITHIN,
+
+/**
+ *The compared interval's head (but not the whole interval) intersects
the actual interval (part of it or the whole actual interval).
+ */
+HEAD_INTERSECTS,
+
+/**
+ * The compared interval starts after the actual, there is no
intersection.
+ */
+AFTER,
+}
+
+/**
+ * Relative position of the "other" interval compared to this.
+ *
+ * @param otherIntervalLowerBoundary Lower boundary of the compared
interval.
+ * @param otherIntervalHigherBoundary Higher boundary of the compared
interval.
+ *
+ * @return Returns the relative position of the "other" interval compared
to this interval. For example: if the result
+ * is BEFORE, read it as: the other interval ends BEFORE the
actual (and there is no intersection between them).
+ */
+RelativePosition getRelativePositionOf(final int
otherIntervalLowerBoundary, final int otherIntervalHigherBoundary);
+
+/**
+ * @return Returns an interval instance with closed low and open high
boundary.
+ */
+static Interval getClosedOpenInterval(final int lowerBoundary, final int
higherBoundary) {
Review Comment:
I understand your thought that since there is a finite number of
combinations of boundaries, the interface could have methods for instantiating
each combination and would not need to expose which implementing class is used.
However, this current implementation violates 3 of the SOLID principles, namely:
- Single Responsibility: the interface now not only defines the capabilities
of an Interval, but is also responsible for creating instances.
- Open-Closed Principle: Adding new implementations other than
ClosedOpenInterval requires modification of Interval (to add new factory
methods or modify exiting one(s)).
- Dependency Inversion: currently the interface depends on the implementing
class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] libminifi: Rename mutex_ to mtx_ member of ConcurrentQueue [nifi-minifi-cpp]
lordgamez commented on PR #1803: URL: https://github.com/apache/nifi-minifi-cpp/pull/1803#issuecomment-2136692854 Hi @kraj, thanks for the contribution! Please create an jira ticket in the Apache Jira system under the [MiNiFi C++ project](https://issues.apache.org/jira/projects/MINIFICPP/) and include the MINIFICPP- ticket number in the PR title. If you do not have Jira access yet you can request access here: https://selfserve.apache.org/jira-account.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] libminifi: Rename mutex_ to mtx_ member of ConcurrentQueue [nifi-minifi-cpp]
kraj opened a new pull request, #1803:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1803
Fixes
libminifi/include/utils/MinifiConcurrentQueue.h:48:75: error: no member
named 'mutex_' in 'ConcurrentQueue'; did you mean 'mtx_'?
|48 | : ConcurrentQueue(std::move(other),
std::lock_guard(other.mutex_)) {}
| |
^~
| |
mtx_
| libminifi/include/utils/MinifiConcurrentQueue.h:140:22: note: 'mtx_'
declared here
| 140 | mutable std::mutex mtx_;
| | ^
| 1 error generated.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP- where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI
results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13285: If there is no transform to restore for the current viewport, executing a zoom fit [nifi]
rfellows merged PR #8874: URL: https://github.com/apache/nifi/pull/8874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13289 Add tooltip to NewCanvas item [nifi]
zeevo commented on PR #8870: URL: https://github.com/apache/nifi/pull/8870#issuecomment-2136240955 @rfellows Thanks for the review and in-depth suggestions. It really helped. My latest commit has the following new behaviors: - Tooltip dismisses on drag. - Tooltip reappears on mouse up if within a canvas item. I decided to short circuit within `attach()` as it made things easier in my opinion. Let me know if you disagree with that implementation, and I'll try doing it within the `HostListener` event methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13308 bumped dependencies slack,maven,mariadb,spring boot, spring framework, jersey, netty, box, aws [nifi]
joewitt commented on PR #8887: URL: https://github.com/apache/nifi/pull/8887#issuecomment-2136128983 integration test failures seem unrelated/typical aperiodic failure due to heap size w jars -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
knguyen1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1617876327
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/test/java/org/apache/nifi/processors/network/pcap/TestSplitPCAP.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+package org.apache.nifi.processors.network.pcap;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Collections;
+
+import org.apache.nifi.util.TestRunner;
+import org.apache.nifi.util.TestRunners;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+
+
+public class TestSplitPCAP {
+
+private Header hdr;
+private Packet validPacket;
+private Packet invalidPacket;
+
+@BeforeEach
+public void init() {
+// Create a header for the test PCAP
+this.hdr = new Header(
+new byte[]{(byte) 0xa1, (byte) 0xb2, (byte) 0xc3, (byte) 0xd4},
+2,
+4,
+0,
+(long) 0,
+(long) 40,
+(long) 1 // ETHERNET
+);
+
+this.validPacket = new Packet(
+(long) 1713184965,
+(long) 1000,
+(long) 30,
+(long) 30,
+new byte[]{
+0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
+10, 11, 12, 13, 14, 15, 16, 17, 18, 19,
+20, 21, 22, 23, 24, 25, 26, 27, 28, 29,
+}
+);
+
+this.invalidPacket = new Packet(
+(long) 1713184965,
+(long) 1000,
+(long) 10,
+(long) 10,
+new byte[]{
+0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
+10, 11, 12, 13, 14, 15, 16, 17, 18, 19,
+20, 21, 22, 23, 24, 25, 26, 27, 28, 29,
+}
+);
+
+}
+
+@Test
+public void testValidPackets() {
+TestRunner runner = TestRunners.newTestRunner(SplitPCAP.class);
+runner.setProperty(SplitPCAP.PCAP_MAX_SIZE, "100");
+List packets = Collections.nCopies(3, this.validPacket);
+
+PCAP testPcap = new PCAP(this.hdr, packets);
+
+runner.enqueue(testPcap.readBytesFull());
+
+runner.run();
+
+runner.assertTransferCount(SplitPCAP.REL_SPLIT, 3);
+runner.assertTransferCount(SplitPCAP.REL_ORIGINAL, 1);
+runner.assertQueueEmpty();
+}
+
+@Test
+public void testInvalidPackets() throws IOException {
Review Comment:
There's some repeating patterns in these tests. You could refactor to
follow DRY.
`void executeTest(String pcapMaxSize, List packets, String
expectedRelation) throws IOException`
then call...
`runTest("100", Collections.nCopies(3, validPacket), SplitPCAP.REL_SPLIT);`
etc...
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/test/java/org/apache/nifi/processors/network/pcap/TestSplitPCAP.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+package org.apache.nifi.processors.network.pcap;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Collections;
+
+import org.apache.nifi.util.TestRunner;
+import org.apache.nifi.util.TestRunners;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+
+
+public class TestSplitPCAP {
+
+
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
knguyen1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1617870817
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/test/java/org/apache/nifi/processors/network/pcap/TestSplitPCAP.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+package org.apache.nifi.processors.network.pcap;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Collections;
+
+import org.apache.nifi.util.TestRunner;
+import org.apache.nifi.util.TestRunners;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+
+
+public class TestSplitPCAP {
+
+private Header hdr;
+private Packet validPacket;
+private Packet invalidPacket;
+
+@BeforeEach
+public void init() {
+// Create a header for the test PCAP
+this.hdr = new Header(
+new byte[]{(byte) 0xa1, (byte) 0xb2, (byte) 0xc3, (byte) 0xd4},
+2,
+4,
+0,
+(long) 0,
+(long) 40,
+(long) 1 // ETHERNET
+);
+
+this.validPacket = new Packet(
+(long) 1713184965,
+(long) 1000,
+(long) 30,
+(long) 30,
+new byte[]{
+0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
+10, 11, 12, 13, 14, 15, 16, 17, 18, 19,
+20, 21, 22, 23, 24, 25, 26, 27, 28, 29,
+}
+);
+
+this.invalidPacket = new Packet(
+(long) 1713184965,
+(long) 1000,
+(long) 10,
+(long) 10,
+new byte[]{
+0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
+10, 11, 12, 13, 14, 15, 16, 17, 18, 19,
+20, 21, 22, 23, 24, 25, 26, 27, 28, 29,
+}
+);
+
+}
+
+@Test
+public void testValidPackets() {
Review Comment:
Remove the `public` modifier. Quote:
>Test classes, test methods, and lifecycle methods are not required to be
public, but they must not be private.
>
>It is generally recommended to omit the public modifier for test classes,
test methods, and lifecycle methods unless there is a technical reason for
doing so – for example, when a test class is extended by a test class in
another package. Another technical reason for making classes and methods public
is to simplify testing on the module path when using the Java Module System.
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/test/java/org/apache/nifi/processors/network/pcap/TestSplitPCAP.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+package org.apache.nifi.processors.network.pcap;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Collections;
+
+import org.apache.nifi.util.TestRunner;
+import org.apache.nifi.util.TestRunners;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+
+
+public class TestSplitPCAP {
Review Comment:
Remove the `public` modifier. Quote:
>Test classes, test methods, and lifecycle methods are not required to be
public, but they must not be private.
>
>It is generally recommended to omit the public modifier for test classes,
test methods, and lifecycle methods unless there is a technical reason for
[PR] NIFI-13308 bumped dependencies slack,maven,mariadb,spring boot, spring framework, jersey, netty, box, aws [nifi]
joewitt opened a new pull request, #8887: URL: https://github.com/apache/nifi/pull/8887 com.slack.api/bot-socket-mode 1.39.2 1.39.3 org.apache.maven/maven-artifact 3.9.6 3.9.7 org.mariadb.jdbc mariadb-java-client 3.3.3 3.4.0 org.springframework.boot spring-boot-* 3.2.5 3.2.6 software.amazon.awssdk * 2.25.55 2.25.60 org.springframework spring* 6.1.7 6.1.8 org.glassfish.jersey.* * 3.1.6 3.1.7 io.netty netty-* 4.1.109.Final 4.1.110.Final com.box box-java-sdk 4.9.0 4.9.1 com.amazonaws aws* 1.12.725 1.12.730 # Summary [NIFI-13308](https://issues.apache.org/jira/browse/NIFI-13308) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13287: Added note to msal4j dependency in Azure bundle's pom [nifi]
turcsanyip commented on PR #8869: URL: https://github.com/apache/nifi/pull/8869#issuecomment-2136022091 @joewitt Thanks for merging it. I believe one can find enough information if they check the Jira / PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12674 Modified ValidateCSV to make the schema optional if a head… [nifi]
mattyb149 commented on code in PR #8362:
URL: https://github.com/apache/nifi/pull/8362#discussion_r1617825158
##
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java:
##
@@ -240,7 +254,11 @@ protected Collection
customValidate(ValidationContext context)
}
// If no Expression Language is present, try parsing the schema
try {
-this.parseSchema(schema);
+if (schema != null) {
+this.parseSchema(schema);
+} else if (!headerProp.asBoolean()) {
+throw(new Exception("Schema cannot be empty if header is
false."));
Review Comment:
Rather than throwing an exception, a ValidationResult should be added to a
list to be returned at the end of the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12967: Introducing Back action [nifi]
scottyaslan merged PR #8859: URL: https://github.com/apache/nifi/pull/8859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13305 Upgrade HBase dependencies from 2.5.8 to 2.6.0 [nifi]
joewitt commented on PR #8886: URL: https://github.com/apache/nifi/pull/8886#issuecomment-2135897692 manually closing since I goofed up the commit message. thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13305 Upgrade HBase dependencies from 2.5.8 to 2.6.0 [nifi]
joewitt closed pull request #8886: NIFI-13305 Upgrade HBase dependencies from 2.5.8 to 2.6.0 URL: https://github.com/apache/nifi/pull/8886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13290: Manually closing dialogs with proper result in Navigation lifecycle to ensure back/forward browser button works [nifi]
scottyaslan merged PR #8871: URL: https://github.com/apache/nifi/pull/8871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12343 allow override of JSON field max string length for PutElasticsearchJson [nifi]
ChrisSamo632 commented on code in PR #8881:
URL: https://github.com/apache/nifi/pull/8881#discussion_r1617547019
##
nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/ElasticsearchRestProcessor.java:
##
@@ -182,6 +186,15 @@ public interface ElasticsearchRestProcessor extends
Processor, VerifiableProcess
.required(false)
.build();
+PropertyDescriptor MAX_JSON_FIELD_STRING_LENGTH = new
PropertyDescriptor.Builder()
+.name("Max JSON Field String Length")
+.displayName("Max JSON FieldString Length")
Review Comment:
D'oh, good spot - updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13030 Adding endpoint for comparing versions of registered flows [nifi]
simonbence commented on code in PR #8670:
URL: https://github.com/apache/nifi/pull/8670#discussion_r1617424178
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/util/Interval.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.web.util;
+
+public interface Interval {
+
+enum RelativePosition {
+/**
+ * The compared interval ends before the actual, there is no
intersection.
+ */
+BEFORE,
+
+/**
+ * The compared interval exceeds the actual both at the low and high
ends.
+ */
+EXCEEDS,
+
+/**
+ * The compared interval's tail (but not the whole interval)
intersects the actual interval (part of it or the whole actual interval).
+ */
+TAIL_INTERSECTS,
+
+/**
+ * The compared interval is within the actual interval. It can match
with the actual or contained by that.
+ */
+WITHIN,
+
+/**
+ *The compared interval's head (but not the whole interval) intersects
the actual interval (part of it or the whole actual interval).
+ */
+HEAD_INTERSECTS,
+
+/**
+ * The compared interval starts after the actual, there is no
intersection.
+ */
+AFTER,
+}
+
+/**
+ * Relative position of the "other" interval compared to this.
+ *
+ * @param otherIntervalLowerBoundary Lower boundary of the compared
interval.
+ * @param otherIntervalHigherBoundary Higher boundary of the compared
interval.
+ *
+ * @return Returns the relative position of the "other" interval compared
to this interval. For example: if the result
+ * is BEFORE, read it as: the other interval ends BEFORE the
actual (and there is no intersection between them).
+ */
+RelativePosition getRelativePositionOf(final int
otherIntervalLowerBoundary, final int otherIntervalHigherBoundary);
+
+/**
+ * @return Returns an interval instance with closed low and open high
boundary.
+ */
+static Interval getClosedOpenInterval(final int lowerBoundary, final int
higherBoundary) {
Review Comment:
I prefer to keep the actual implementation class part of the implementation
details. In general, clients do not need to know about if all the possible
permutations of boundaries (ClosedClosed, ClosedOpen, etc.) are served by
different classes or the same. Hiding this provides more flexibility for later
changes and also prevents unintended usages. An other way would be to provide a
factory class, like `IntervalFactory` but I felt it overkill.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12343 allow override of JSON field max string length for PutElasticsearchJson [nifi]
exceptionfactory commented on code in PR #8881:
URL: https://github.com/apache/nifi/pull/8881#discussion_r1617500167
##
nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/ElasticsearchRestProcessor.java:
##
@@ -182,6 +186,15 @@ public interface ElasticsearchRestProcessor extends
Processor, VerifiableProcess
.required(false)
.build();
+PropertyDescriptor MAX_JSON_FIELD_STRING_LENGTH = new
PropertyDescriptor.Builder()
+.name("Max JSON Field String Length")
+.displayName("Max JSON FieldString Length")
Review Comment:
In this case, recommend removing the `displayName` since it should be the
same as the name (although there appears to be a space missing between `Field`
and `String`.
##
nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/ElasticsearchRestProcessor.java:
##
@@ -182,6 +186,15 @@ public interface ElasticsearchRestProcessor extends
Processor, VerifiableProcess
.required(false)
.build();
+PropertyDescriptor MAX_JSON_FIELD_STRING_LENGTH = new
PropertyDescriptor.Builder()
+.name("Max JSON Field String Length")
+.displayName("Max JSON FieldString Length")
Review Comment:
In this case, recommend removing the `displayName` since it should be the
same as the name (although there appears to be a space missing between `Field`
and `String`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12343 allow override of JSON field max string length for PutElasticsearchJson [nifi]
exceptionfactory commented on code in PR #8881:
URL: https://github.com/apache/nifi/pull/8881#discussion_r1617500167
##
nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/ElasticsearchRestProcessor.java:
##
@@ -182,6 +186,15 @@ public interface ElasticsearchRestProcessor extends
Processor, VerifiableProcess
.required(false)
.build();
+PropertyDescriptor MAX_JSON_FIELD_STRING_LENGTH = new
PropertyDescriptor.Builder()
+.name("Max JSON Field String Length")
+.displayName("Max JSON FieldString Length")
Review Comment:
In this case, recommend removing the `displayName` since it should be the
same as the name` (although there appears to be a space missing between `Field`
and `String`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13305 Upgrade HBase dependencies from 2.5.8 to 2.6.0 [nifi]
joewitt commented on PR #8886: URL: https://github.com/apache/nifi/pull/8886#issuecomment-2135500405 oh very nice! +1 pending outcome of CI build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13305 Upgrade HBase dependencies from 2.5.8 to 2.6.0 [nifi]
exceptionfactory opened a new pull request, #8886: URL: https://github.com/apache/nifi/pull/8886 # Summary [NIFI-13305](https://issues.apache.org/jira/browse/NIFI-13305) Upgrades Apache HBase dependencies from 2.5.8 to [2.6.0](https://issues.apache.org/jira/projects/HBASE/versions/12350930), incorporating a number of bug fixes and improvements. Changes include removing dependency overrides that are no longer required based on updates in HBase 2.6.0 # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13030 Adding endpoint for comparing versions of registered flows [nifi]
simonbence commented on code in PR #8670:
URL: https://github.com/apache/nifi/pull/8670#discussion_r1617424178
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/util/Interval.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.web.util;
+
+public interface Interval {
+
+enum RelativePosition {
+/**
+ * The compared interval ends before the actual, there is no
intersection.
+ */
+BEFORE,
+
+/**
+ * The compared interval exceeds the actual both at the low and high
ends.
+ */
+EXCEEDS,
+
+/**
+ * The compared interval's tail (but not the whole interval)
intersects the actual interval (part of it or the whole actual interval).
+ */
+TAIL_INTERSECTS,
+
+/**
+ * The compared interval is within the actual interval. It can match
with the actual or contained by that.
+ */
+WITHIN,
+
+/**
+ *The compared interval's head (but not the whole interval) intersects
the actual interval (part of it or the whole actual interval).
+ */
+HEAD_INTERSECTS,
+
+/**
+ * The compared interval starts after the actual, there is no
intersection.
+ */
+AFTER,
+}
+
+/**
+ * Relative position of the "other" interval compared to this.
+ *
+ * @param otherIntervalLowerBoundary Lower boundary of the compared
interval.
+ * @param otherIntervalHigherBoundary Higher boundary of the compared
interval.
+ *
+ * @return Returns the relative position of the "other" interval compared
to this interval. For example: if the result
+ * is BEFORE, read it as: the other interval ends BEFORE the
actual (and there is no intersection between them).
+ */
+RelativePosition getRelativePositionOf(final int
otherIntervalLowerBoundary, final int otherIntervalHigherBoundary);
+
+/**
+ * @return Returns an interval instance with closed low and open high
boundary.
+ */
+static Interval getClosedOpenInterval(final int lowerBoundary, final int
higherBoundary) {
Review Comment:
I prefer to keep the actual implementation class part of the implementation
details. In general, clients does not need to know about if all the possible
permutations of boundaries (ClosedClosed, ClosedOpen, etc.) are served by
different classes or the same. Hiding this provides more flexibility for later
changes and also prevents unintended usages. An other way would be to provide a
factory class, like `IntervalFactory` but I felt it overkill.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13030 Adding endpoint for comparing versions of registered flows [nifi]
simonbence commented on code in PR #8670:
URL: https://github.com/apache/nifi/pull/8670#discussion_r1617407509
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/util/Interval.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.web.util;
+
+public interface Interval {
+
+enum RelativePosition {
+/**
+ * The compared interval ends before the actual, there is no
intersection.
+ */
+BEFORE,
+
+/**
+ * The compared interval exceeds the actual both at the low and high
ends.
+ */
+EXCEEDS,
+
+/**
+ * The compared interval's tail (but not the whole interval)
intersects the actual interval (part of it or the whole actual interval).
+ */
+TAIL_INTERSECTS,
+
+/**
+ * The compared interval is within the actual interval. It can match
with the actual or contained by that.
+ */
+WITHIN,
+
+/**
+ *The compared interval's head (but not the whole interval) intersects
the actual interval (part of it or the whole actual interval).
+ */
+HEAD_INTERSECTS,
+
+/**
+ * The compared interval starts after the actual, there is no
intersection.
+ */
+AFTER,
+}
+
+/**
+ * Relative position of the "other" interval compared to this.
+ *
+ * @param otherIntervalLowerBoundary Lower boundary of the compared
interval.
+ * @param otherIntervalHigherBoundary Higher boundary of the compared
interval.
+ *
+ * @return Returns the relative position of the "other" interval compared
to this interval. For example: if the result
+ * is BEFORE, read it as: the other interval ends BEFORE the
actual (and there is no intersection between them).
+ */
+RelativePosition getRelativePositionOf(final int
otherIntervalLowerBoundary, final int otherIntervalHigherBoundary);
Review Comment:
I had this idea due to symmetry but finally I voted against that. The
following implications made me leave it out:
- With its current usage, numerous unnecessary object creation would come
with this
- The "open ended" (no higher boundary) cases as you mention would need
special handling
- With introducting the interface, later on possibly other implementations
might be added which might make this method unnecessary complicated for its
current purpose
So in the end, I did let it like this and in case of need we can add it
later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13298 Removed unused instantiated java.util.HashSet from RouteAttribute [nifi]
exceptionfactory closed pull request #8883: NIFI-13298 Removed unused instantiated java.util.HashSet from RouteAttribute URL: https://github.com/apache/nifi/pull/8883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [NIFI-13269] - Order parameter reference list alphabetically [nifi]
rfellows opened a new pull request, #8885: URL: https://github.com/apache/nifi/pull/8885 [NIFI-13269](https://issues.apache.org/jira/browse/NIFI-13269) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
exceptionfactory commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2135356741 > > To the question about manipulating content as it is streamed in, `SplitText` and `SplitContent` are capable of reading large files and breaking them up into smaller FlowFiles. > > Ah fair enough, so if I were to chain FetchFile and SplitContent to split a file into 100MB chunks, I should be able to start reading a 200TB file from disk and get some 100MB chunks back before the initial load of the 200TB file has fully completed? The exact behavior depends on the Processor in question, but that could be possible with a custom implementation. The `ProcessSession` is transactional, so sending 100 MB chunks to a particular relationship would require committing the transaction in the middle of processing the 200 TB stream. Most Processors do not commit the session until processing is complete, but it depends on the desired behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
JackHintonSmartDCSIT commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2135328279 > To the question about manipulating content as it is streamed in, `SplitText` and `SplitContent` are capable of reading large files and breaking them up into smaller FlowFiles. Ah fair enough, so if I were to chain FetchFile and SplitContent to split a file into 100MB chunks, I should be able to start reading a 200TB file from disk and get some 100MB chunks back before the initial load of the 200TB file has fully completed? This is vaguely unrelated to this processor by the way, we're just having to process some very large files and we're wondering how best to go about it. Thanks for the replies! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13285: If there is no transform to restore for the current viewport, executing a zoom fit [nifi]
rfellows commented on code in PR #8874:
URL: https://github.com/apache/nifi/pull/8874#discussion_r1617276676
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/canvas-view.service.ts:
##
@@ -638,11 +638,11 @@ export class CanvasView {
newScale = 1;
// since the entire graph will fit on the canvas, offset origin
appropriately
-graphLeft -= 100;
-graphTop -= 50;
+graphLeft -= 313;
+graphTop -= 25;
Review Comment:
This logic could probably be improved. If the canvas is just slightly bigger
than the graph, the offset used here could push some content out of the
viewable area.
We might consider offsetting by the difference between the canvas and graph
size divided by 2 (essentially center in the canvas). If that is too much, we
could only do it in the case where the difference in the sizes is smaller than
the hardcoded offsets chose here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
exceptionfactory commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2135255496 > Thanks for your response! Out of curiosity, is there a way to stream large files into NiFi and manipulate them as they're streamed in? > To the question about manipulating content as it is streamed in, `SplitText` and `SplitContent` are capable of reading large files and breaking them up into smaller FlowFiles. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
exceptionfactory commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2135251655 > Thanks for your response! Out of curiosity, is there a way to stream large files into NiFi and manipulate them as they're streamed in? Yes, any number of Processors support reading in very large files for subsequent handling. This includes Processors like FetchFile, for reading from local disk, or others like FetchSFTP and FetchS3Object, which read from remote services. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
JackHintonSmartDCSIT commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2135241225 > > > Thanks for the continued work on this Processor @JackHintonSmartDCSIT, and thanks for the thorough review thus far @dan-s1. > > > Reviewing the latest version, there is a serious concern with reading the entire input FlowFile content into memory. > > > I have not evaluated all the details of the `PCAP` class, but it looks like it should be possible to read packets in a streaming fashion, which would avoid significant memory consumption. Although the current approach could work for small files, this needs to be refactored as it will not scale for larger files. > > > > > > The assumption used in the creation of this processor was that the flowfile to be split would already be present in NiFi in order to be processed, which (one would assume) necessitates that the PCAP file is already present in memory in its' entirety. I don't disagree with your assessment, but I would like to clarify; is there a way of streaming flowfiles between processors in such a way that they aren't required to be held entirely in memory? If so, can you point me to a processor that uses this mechanism or some documentation of it so I can adopt it here? Thanks! > > Thanks for the reply @JackHintonSmartDCSIT. > > FlowFile content in a NiFi queue does not use heap memory, and instead uses a persistent repository. This allows NiFi to process very large files with relatively small amounts of memory in many cases. The vast majority of NiFi processors do not read the entire FlowFile content into memory, and those that do are more exceptional cases. > > The `SplitRecord` Processors is one example of a Processor that reads an InputStream, consisting of an unknown number of Records, and then writes a segmented number of Records to one or more output FlowFiles. Some of the other Split Processors follow a similar pattern. > > Based on the code as it stands, it looks like it will be necessary to refactor the PCAP reading to emit a stream of packets. The `java.util.Iterator` interface is one general way to model this strategy, but the details depend on consuming bytes from an InputStream, then writing packets to a FlowFile OutputStream, which avoids retaining a large number of objects in memory. I realize this will take some work to refactor, but reviewing some of the existing Split Processors should provide some helpful background examples. Thanks for your response! Out of curiosity, is there a way to stream large files into NiFi and manipulate them as they're streamed in? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13286: Conditionally reloading the child PG or current PG when emptying all queues [nifi]
rfellows merged PR #8872: URL: https://github.com/apache/nifi/pull/8872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
exceptionfactory commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2135201964 > > Thanks for the continued work on this Processor @JackHintonSmartDCSIT, and thanks for the thorough review thus far @dan-s1. > > Reviewing the latest version, there is a serious concern with reading the entire input FlowFile content into memory. > > I have not evaluated all the details of the `PCAP` class, but it looks like it should be possible to read packets in a streaming fashion, which would avoid significant memory consumption. Although the current approach could work for small files, this needs to be refactored as it will not scale for larger files. > > The assumption used in the creation of this processor was that the flowfile to be split would already be present in NiFi in order to be processed, which (one would assume) necessitates that the PCAP file is already present in memory in its' entirety. I don't disagree with your assessment, but I would like to clarify; is there a way of streaming flowfiles between processors in such a way that they aren't required to be held entirely in memory? If so, can you point me to a processor that uses this mechanism or some documentation of it so I can adopt it here? Thanks! Thanks for the reply @JackHintonSmartDCSIT. FlowFile content in a NiFi queue does not use heap memory, and instead uses a persistent repository. This allows NiFi to process very large files with relatively small amounts of memory in many cases. The vast majority of NiFi processors do not read the entire FlowFile content into memory, and those that do are more exceptional cases. The `SplitRecord` Processors is one example of a Processor that reads an InputStream, consisting of an unknown number of Records, and then writes a segmented number of Records to one or more output FlowFiles. Some of the other Split Processors follow a similar pattern. Based on the code as it stands, it looks like it will be necessary to refactor the PCAP reading to emit a stream of packets. The `java.util.Iterator` interface is one general way to model this strategy, but the details depend on consuming bytes from an InputStream, then writing packets to a FlowFile OutputStream, which avoids retaining a large number of objects in memory. I realize this will take some work to refactor, but reviewing some of the existing Split Processors should provide some helpful background examples. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13270: Persisting the select tab index [nifi]
rfellows merged PR #8877: URL: https://github.com/apache/nifi/pull/8877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13030 Adding endpoint for comparing versions of registered flows [nifi]
pgyori commented on code in PR #8670:
URL: https://github.com/apache/nifi/pull/8670#discussion_r1617159432
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/util/ClosedOpenInterval.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.web.util;
+
+/**
+ * This implementation includes the lower boundary bud does not include the
higher boundary.
+ */
+final class ClosedOpenInterval implements Interval {
+private final int lowerBoundary;
+private final int higherBoundary;
+
+/**
+ * @param lowerBoundary Inclusive index of lower boundary
+ * @param higherBoundary Exclusive index of higher boundary. In case of 0,
the higher boundary is unspecified and the interval is open.
+ */
+ClosedOpenInterval(final int lowerBoundary, final int higherBoundary) {
+if (lowerBoundary < 0) {
+throw new IllegalArgumentException("Lower boundary cannot be
negative");
+}
+
+if (higherBoundary < 0) {
+throw new IllegalArgumentException("Higher boundary cannot be
negative");
+}
+
+if (higherBoundary <= lowerBoundary && higherBoundary != 0) {
+throw new IllegalArgumentException(
+"Higher boundary cannot be lower than or equal to lower
boundary except when unspecified. Higher boundary is considered unspecified
when the value is set to 0"
+);
+}
+
+this.lowerBoundary = lowerBoundary;
+this.higherBoundary = higherBoundary;
+}
+
+@Override
+public RelativePosition getRelativePositionOf(final int
otherIntervalLowerBoundary, final int otherIntervalHigherBoundary) {
+if (otherIntervalLowerBoundary < 0) {
+throw new IllegalArgumentException("Lower boundary cannot be
negative");
+}
+
+if (otherIntervalHigherBoundary <= 0) {
+// Note: as a design decision the implementation currently does
not support comparison with unspecified higher boundary
+throw new IllegalArgumentException("Higher boundary must be
positive");
+}
+
+if (otherIntervalLowerBoundary > otherIntervalHigherBoundary) {
Review Comment:
`otherIntervalLowerBoundary >= otherIntervalHigherBoundary` needs to be used
in order to check for 0-length intervals where lower==higher (currently this
case is not covered).
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/util/Interval.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.web.util;
+
+public interface Interval {
+
+enum RelativePosition {
+/**
+ * The compared interval ends before the actual, there is no
intersection.
+ */
+BEFORE,
+
+/**
+ * The compared interval exceeds the actual both at the low and high
ends.
+ */
+EXCEEDS,
+
+/**
+ * The compared interval's tail (but not the whole interval)
intersects the actual interval (part of it or the whole actual interval).
+ */
+TAIL_INTERSECTS,
+
+/**
+ * The compared interval is within the actual interval. It can match
with the actual or contained by that.
+ */
+WITHIN,
+
+/**
+ *The compared interval's head (but not the whole interval) intersects
Re: [PR] NIFI-13270: Persisting the select tab index [nifi]
rfellows commented on PR #8877: URL: https://github.com/apache/nifi/pull/8877#issuecomment-2135104214 reviewing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [NIFI-13303] - Remove text indicating property verification is disabled. [nifi]
rfellows opened a new pull request, #8884: URL: https://github.com/apache/nifi/pull/8884 [NIFI-13303](https://issues.apache.org/jira/browse/NIFI-13303) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
JackHintonSmartDCSIT commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2134784182 > Thanks for the continued work on this Processor @JackHintonSmartDCSIT, and thanks for the thorough review thus far @dan-s1. > > Reviewing the latest version, there is a serious concern with reading the entire input FlowFile content into memory. > > I have not evaluated all the details of the `PCAP` class, but it looks like it should be possible to read packets in a streaming fashion, which would avoid significant memory consumption. Although the current approach could work for small files, this needs to be refactored as it will not scale for larger files. The assumption used in the creation of this processor was that the flowfile to be split would already be present in NiFi in order to be processed, which (one would assume) necessitates that the PCAP file is already present in memory in its' entirety. I don't disagree with your assessment, but I would like to clarify; is there a way of streaming flowfiles between processors in such a way that they aren't required to be held entirely in memory? If so, can you point me to a processor that uses this mechanism or some documentation of it so I can adopt it here? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] MINIFICPP-2387 Improve error handling in Python processors [nifi-minifi-cpp]
lordgamez opened a new pull request, #1802: URL: https://github.com/apache/nifi-minifi-cpp/pull/1802 In case a function is called from the minifi_native python module from a user defined python processor and an error occurs in one of the python stable API functions, then instead of throwing our own exception we should only return with an error value. The Python API functions already raise an exception if an error occurs in the python code, that can be handled there instead of throwing an exception in the C++ code. In NiFi python processors this will be handled in the onTrigger method and we will get a proper traceback and the flow file will be transferred to the failure relationship instead of an error and rollback. This will help us debug any python errors easier and also handle the errors by moving them to the failure relationship the same way as the NiFi python extension works. https://issues.apache.org/jira/browse/MINIFICPP-2387 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2386 Add Jom support for building OpenSSL in parallel [nifi-minifi-cpp]
lordgamez commented on code in PR #1799:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1799#discussion_r1616692166
##
cmake/BundledOpenSSL.cmake:
##
@@ -71,17 +71,37 @@ function(use_openssl SOURCE_DIR BINARY_DIR)
# Note: when upgrading to a later release than 3.1.1 the --no-apps could
be used instead of --no-tests to minimize the build size
if (WIN32)
+if(MINIFI_USE_JOM_FOR_OPENSSL_BUILD)
+find_program(JOM_EXECUTABLE_PATH
+NAMES jom.exe
+PATHS ENV PATH
+NO_DEFAULT_PATH)
+if (NOT JOM_EXECUTABLE_PATH)
+message(FATAL_ERROR "jom.exe not found. Please install jom and
add it to the PATH or turn MINIFI_USE_JOM_FOR_OPENSSL_BUILD option off.")
+endif()
+message("Using jom for OpenSSL build: ${JOM_EXECUTABLE_PATH}")
+include(ProcessorCount)
+processorcount(jobs)
+set(OPENSSL_BUILD_COMMAND ${JOM_EXECUTABLE_PATH} -j${jobs})
+set(OPENSSL_INSTALL_COMMAND ${JOM_EXECUTABLE_PATH} install)
+set(OPENSSL_WINDOWS_COMPILE_FLAGS /FS)
+else()
+message("Using nmake for OpenSSL build")
+set(OPENSSL_BUILD_COMMAND nmake)
+set(OPENSSL_INSTALL_COMMAND nmake install)
+set(OPENSSL_WINDOWS_COMPILE_FLAGS "")
+endif()
Review Comment:
Updated in 36f6133cbd3c5c280d20c3738a7610d45735e11d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] NIFI-13298 Removed unused instantiated java.util.HashSet from RouteAttribute [nifi]
dan-s1 opened a new pull request, #8883: URL: https://github.com/apache/nifi/pull/8883 # Summary [NIFI-13298](https://issues.apache.org/jira/browse/NIFI-13298) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13302 Replaced deprecated method authorizeRequests with method authorizeHttpRequests [nifi]
dan-s1 opened a new pull request, #8882: URL: https://github.com/apache/nifi/pull/8882 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12343 allow override of JSON field max string length for PutElasticsearchJson [nifi]
ChrisSamo632 opened a new pull request, #8881: URL: https://github.com/apache/nifi/pull/8881 # Summary [NIFI-12343](https://issues.apache.org/jira/browse/NIFI-12343) allow override of JSON field max string length for PutElasticsearchJson. Also allow the same override for other Elasticsearch processors that use an `ObjectMapper` to parse input/output. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - ~[ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi).~ ### Licensing - ~[ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)~ - ~[ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files~ ### Documentation - ~[ ] Documentation formatting appears as expected in rendered files~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13154 Display parameter reference when used as Sensitive property value [nifi]
joewitt commented on code in PR #8853:
URL: https://github.com/apache/nifi/pull/8853#discussion_r1614859942
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java:
##
@@ -4116,7 +4117,16 @@ private List createThreadDumpDtos(final
ProcessorNode procNode) {
return threadDumps;
}
- /**
+// Pattern to match a parameter reference i.e. "#{anything}"
+private static final Pattern PARAMETER_REFERENCE =
Pattern.compile("^#\\{.*}$");
Review Comment:
Yeah these are a couple good questions that came to mind for me as well. My
opinion, and i'm curious what others would say, is that
1. Yes it should match an existing parameter for us to reflect that
parameter name as the value in the case of a sensitive field whose value is a
parameter. I'm thinking we should be able to know they selected a parameter
by more than simply matching the string but i'm not positive about that.
2. If the user in question does not have read access to the associated
parameter then they should not get to know that parameter is in use for a
sensitive field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13294 Deprecate Apache Knox SSO Authentication [nifi]
joewitt closed pull request #8875: NIFI-13294 Deprecate Apache Knox SSO Authentication URL: https://github.com/apache/nifi/pull/8875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13294 Deprecate Apache Knox SSO Authentication [nifi]
joewitt commented on PR #8875: URL: https://github.com/apache/nifi/pull/8875#issuecomment-2131426772 +1 merged to support/nifi-1.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13295 Remove Apache Knox SSO Authentication [nifi]
asfgit closed pull request #8876: NIFI-13295 Remove Apache Knox SSO Authentication URL: https://github.com/apache/nifi/pull/8876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13296 Deprecate Kerberos SPNEGO Authentication [nifi]
joewitt commented on PR #8878: URL: https://github.com/apache/nifi/pull/8878#issuecomment-2131418194 +1 merged to support/nifi-1.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13296 Deprecate Kerberos SPNEGO Authentication [nifi]
joewitt closed pull request #8878: NIFI-13296 Deprecate Kerberos SPNEGO Authentication URL: https://github.com/apache/nifi/pull/8878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13297 Remove Kerberos SPENGO Authentication [nifi]
asfgit closed pull request #8879: NIFI-13297 Remove Kerberos SPENGO Authentication URL: https://github.com/apache/nifi/pull/8879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13296 Deprecate Kerberos SPNEGO Authentication [nifi]
joewitt commented on PR #8878: URL: https://github.com/apache/nifi/pull/8878#issuecomment-2131414667 Thanks for the very thorough changeset. It is great to see all the progress with SSO/OIDC/SAML that allows us to now move on from this approach. much appreciated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13287: Added note to msal4j dependency in Azure bundle's pom [nifi]
asfgit closed pull request #8869: NIFI-13287: Added note to msal4j dependency in Azure bundle's pom URL: https://github.com/apache/nifi/pull/8869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13293 Upgrade Spring Security from 6.2.4 to 6.3.0 [nifi]
asfgit closed pull request #8873: NIFI-13293 Upgrade Spring Security from 6.2.4 to 6.3.0 URL: https://github.com/apache/nifi/pull/8873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13300 bumped to apache parent 32. maven wrapper 3.3.2. maven 3.9.7 [nifi]
joewitt opened a new pull request, #8880: URL: https://github.com/apache/nifi/pull/8880 # Summary [NIFI-13300](https://issues.apache.org/jira/browse/NIFI-13300) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13297 Remove Kerberos SPENGO Authentication [nifi]
exceptionfactory opened a new pull request, #8879: URL: https://github.com/apache/nifi/pull/8879 # Summary [NIFI-13297](https://issues.apache.org/jira/browse/NIFI-13297) Removes framework support for Kerberos SPNEGO authentication from the main branch for NiFi 2, along with supporting application properties. [NIFI-13296](https://issues.apache.org/jira/browse/NIFI-13296) Deprecates Kerberos SPNEGO authentication for removal and provides additional background. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13296 Deprecate Kerberos SPNEGO Authentication [nifi]
exceptionfactory opened a new pull request, #8878: URL: https://github.com/apache/nifi/pull/8878 # Summary [NIFI-13296](https://issues.apache.org/jira/browse/NIFI-13296) Deprecates Kerberos [SPNEGO](https://en.wikipedia.org/wiki/SPNEGO) authentication for subsequent removal in NiFi 2. This deprecation applies to framework-level configuration as opposed to username and password-based authentication using the Kerberos Login Identity Provider. Kerberos SPNEGO authentication requires non-standard [client browser configuration](https://docs.spring.io/spring-security-kerberos/docs/current/reference/html/browserspnegoconfig.html) that is specific to particular host addresses, whereas standards-based Single Sign-On integration using OpenID Connect or SAML 2 does not have similar constraints. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13295 Remove Apache Knox SSO Authentication [nifi]
exceptionfactory opened a new pull request, #8876: URL: https://github.com/apache/nifi/pull/8876 # Summary [NIFI-13295](https://issues.apache.org/jira/browse/NIFI-13295) Removes Apache Knox [Single Sign-On](https://knox.apache.org/books/knox-1-6-0/user-guide.html#SSO+Cookie+Provider) authentication from the main branch for NiFi 2. OpenID Connect and SAML 2 integration provide standards-based SSO without reference to particular identity providers. This removal does not impact Apache Knox [proxy gateway access](https://knox.apache.org/books/knox-1-6-0/user-guide.html#Nifi+UI) to NiFi, which continues to be supported using X.509 client certificates and the `X-ProxiedEntitiesChain` HTTP header. Removed code includes NiFi properties specific to Apache Knox SSO and REST API methods used for processing Knox tokens. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable [nifi]
mattyb149 commented on PR #7544: URL: https://github.com/apache/nifi/pull/7544#issuecomment-2130235297 The checkstyle rules were recently made more stringent, looks like this needs another rebase and please run your Maven build with the `contrib-check` profile activated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13294 Deprecate Apache Knox SSO Authentication [nifi]
exceptionfactory opened a new pull request, #8875: URL: https://github.com/apache/nifi/pull/8875 # Summary [NIFI-13294](https://issues.apache.org/jira/browse/NIFI-13294) Deprecates Apache Knox [Single Sign-On](https://knox.apache.org/books/knox-1-6-0/user-guide.html#SSO+Cookie+Provider) authentication for subsequent removal in NiFi 2. OpenID Connect and SAML 2 integration provide standards-based SSO without reference to particular identity providers. This deprecation does not impact Apache Knox [proxy gateway access](https://knox.apache.org/books/knox-1-6-0/user-guide.html#Nifi+UI) to NiFi, which continues to be supported using X.509 client certificates and the `X-ProxiedEntitiesChain` HTTP header. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13293 Upgrade Spring Security from 6.2.4 to 6.3.0 [nifi]
exceptionfactory opened a new pull request, #8873: URL: https://github.com/apache/nifi/pull/8873 # Summary [NIFI-13293](https://issues.apache.org/jira/browse/NIFI-13293) Upgrades Spring Security dependencies from 6.2.4 to [6.3.0](https://github.com/spring-projects/spring-security/releases/tag/6.3.0) incorporating bug fixes and feature improvements. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13289 Add tooltip to NewCanvas item [nifi]
zeevo commented on code in PR #8870:
URL: https://github.com/apache/nifi/pull/8870#discussion_r1613638267
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/header/new-canvas-item/new-canvas-item.component.ts:
##
@@ -25,19 +25,33 @@ import { selectDragging } from
'../../../../state/flow/flow.selectors';
import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
import { ComponentType } from '../../../../../../state/shared';
import { CanvasView } from '../../../../service/canvas-view.service';
+import { NifiTooltipDirective } from
'../../../../../../ui/common/tooltips/nifi-tooltip.directive';
+import { TextTip } from
'../../../../../../ui/common/tooltips/text-tip/text-tip.component';
+import { ConnectedPosition } from '@angular/cdk/overlay';
@Component({
selector: 'new-canvas-item',
standalone: true,
templateUrl: './new-canvas-item.component.html',
-imports: [CdkDrag],
+imports: [CdkDrag, NifiTooltipDirective],
styleUrls: ['./new-canvas-item.component.scss']
})
export class NewCanvasItem {
@Input() type!: ComponentType;
@Input() iconClass = '';
@Input() iconHoverClass = '';
@Input() disabled = false;
+@Input() tooltip = '';
+
+protected readonly TextTip = TextTip;
+
+tooltipPosition: ConnectedPosition = {
+originX: 'center', // maybe start?
Review Comment:
I need to remove this comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12967: Introducing Back action [nifi]
mcgilman commented on code in PR #8859:
URL: https://github.com/apache/nifi/pull/8859#discussion_r1613429317
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/state/navigation/navigation.reducer.ts:
##
@@ -28,7 +28,14 @@ export const navigationReducer = createReducer(
initialState,
on(pushBackNavigation, (state, { backNavigation }) => {
return produce(state, (draftState) => {
-draftState.backNavigations.push(backNavigation);
+if (draftState.backNavigations.length > 0) {
Review Comment:
Thanks @scottyaslan! Good catch. I've pushed another commit that should
address this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] NIFI-13289 Add tooltip to NewCanvas item [nifi]
zeevo opened a new pull request, #8870: URL: https://github.com/apache/nifi/pull/8870 # Summary [NIFI-13289](https://issues.apache.org/jira/browse/NIFI-13289) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### UI Contributions - [x] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12983: Qdrant vector store support [nifi]
Anush008 commented on PR #8590: URL: https://github.com/apache/nifi/pull/8590#issuecomment-2128392260 I am unsure if the failing test is related to the changes in this PR. Doesn't look like it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12967: Introducing Back action [nifi]
scottyaslan commented on code in PR #8859:
URL: https://github.com/apache/nifi/pull/8859#discussion_r1612591011
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/state/navigation/navigation.reducer.ts:
##
@@ -28,7 +28,14 @@ export const navigationReducer = createReducer(
initialState,
on(pushBackNavigation, (state, { backNavigation }) => {
return produce(state, (draftState) => {
-draftState.backNavigations.push(backNavigation);
+if (draftState.backNavigations.length > 0) {
Review Comment:
Looks like there is still a bug in here:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12967: Introducing Back action [nifi]
mcgilman commented on code in PR #8859:
URL: https://github.com/apache/nifi/pull/8859#discussion_r1612409434
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/flow/flow.effects.ts:
##
@@ -1392,14 +1478,7 @@ export class FlowEffects {
.subscribe((updateProcessorRequest:
UpdateProcessorRequest) => {
this.store.dispatch(
FlowActions.updateProcessor({
-request: {
-id: processorId,
-uri: request.uri,
-type: request.type,
-payload:
updateProcessorRequest.payload,
-errorStrategy: 'banner',
-postUpdateNavigation:
updateProcessorRequest.postUpdateNavigation
-}
+request: updateProcessorRequest
})
);
});
Review Comment:
@scottyaslan Thanks for filing the JIRA. Agreed that is an issue with our
dialog close handling when the user navigates forward/back with their browsers.
The other scenario looks like a bug in the logic when a new back navigation is
pushed that is introduced in this PR. I think simply avoid pushing a duplicate
back navigation would address this case. Great idea. Let me prep another commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12967: Introducing Back action [nifi]
scottyaslan commented on code in PR #8859:
URL: https://github.com/apache/nifi/pull/8859#discussion_r1612402084
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/flow/flow.effects.ts:
##
@@ -1392,14 +1478,7 @@ export class FlowEffects {
.subscribe((updateProcessorRequest:
UpdateProcessorRequest) => {
this.store.dispatch(
FlowActions.updateProcessor({
-request: {
-id: processorId,
-uri: request.uri,
-type: request.type,
-payload:
updateProcessorRequest.payload,
-errorStrategy: 'banner',
-postUpdateNavigation:
updateProcessorRequest.postUpdateNavigation
-}
+request: updateProcessorRequest
})
);
});
Review Comment:
https://issues.apache.org/jira/browse/NIFI-13290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
