[GitHub] gavinju commented on issue #5010: superset db upgrade error: ImportError: cannot import name EncryptedType
gavinju commented on issue #5010: superset db upgrade error: ImportError: cannot import name EncryptedType URL: https://github.com/apache/incubator-superset/issues/5010#issuecomment-389550176 OK，Thank you for your help, This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI
miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into
SQLAlchemy URI
URL:
https://github.com/apache/incubator-superset/issues/5013#issuecomment-389522281
@TianyangLi I have tried with sudo apt-get install python-mysqldb, but still
no success in Ubuntu either (@xrmx). It gives me error:
> ERROR: {"error": "Connection failed!\n\nThe error message returned
was:\nNo module named MySQLdb"}
And in the terminal it is the following info:
> Traceback (most recent call last):
File
"/home/miki/venv/local/lib/python2.7/site-packages/superset/views/core.py",
line 1691, in testconn
engine = create_engine(uri, connect_args=connect_args)
File
"/home/miki/venv/local/lib/python2.7/site-packages/sqlalchemy/engine/__init__.py",
line 419, in create_engine
return strategy.create(*args, **kwargs)
File
"/home/miki/venv/local/lib/python2.7/site-packages/sqlalchemy/engine/strategies.py",
line 80, in create
dbapi = dialect_cls.dbapi(**dbapi_args)
File
"/home/miki/venv/local/lib/python2.7/site-packages/sqlalchemy/dialects/mysql/mysqldb.py",
line 102, in dbapi
return __import__('MySQLdb')
ImportError: No module named MySQLdb
I am using Superset==0.24, because 0.25 (or latest) gives me problem with
flask.
Anyone any idea? Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] AbdealiJK opened a new issue #5005: DB Upgrade - Fails with sqlalchemy_utils errors
AbdealiJK opened a new issue #5005: DB Upgrade - Fails with sqlalchemy_utils errors URL: https://github.com/apache/incubator-superset/issues/5005 Make sure these boxes are checked before submitting your issue - thank you! - [X] I have checked the superset logs for python stacktraces and included it here as text if any - [X] I have reproduced the issue with at least the latest released version of superset - [X] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version 0.25.2 ### Expected results DB upgrade should happen seamlessly. ### Actual results DB upgrade fails on fresh installs. ### Steps to reproduce I was following steps at https://superset.incubator.apache.org/installation.html# and found that the "superset db upgrade" step fails. ```python $ superset db upgrade 2018-05-15 14:28:24,171:DEBUG:passlib.utils.compat:loaded lazy attr 'SafeConfigParser': 2018-05-15 14:28:24,172:DEBUG:passlib.utils.compat:loaded lazy attr 'NativeStringIO': 2018-05-15 14:28:24,172:DEBUG:passlib.utils.compat:loaded lazy attr 'BytesIO': INFO [alembic.runtime.migration] Context impl SQLiteImpl. INFO [alembic.runtime.migration] Will assume transactional DDL. Traceback (most recent call last): File "/Users/abdealijk/anaconda3/bin/superset", line 15, in manager.run() File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/flask_script/__init__.py", line 417, in run result = self.handle(argv[0], argv[1:]) File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/flask_script/__init__.py", line 386, in handle res = handle(*args, **config) File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/flask_script/commands.py", line 216, in __call__ return self.run(*args, **kwargs) File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/flask_migrate/__init__.py", line 259, in upgrade command.upgrade(config, revision, sql=sql, tag=tag) File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/alembic/command.py", line 254, in upgrade script.run_env() File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/alembic/script/base.py", line 427, in run_env util.load_python_file(self.dir, 'env.py') File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/alembic/util/pyfiles.py", line 81, in load_python_file module = load_module_py(module_id, path) File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/alembic/util/compat.py", line 83, in load_module_py spec.loader.exec_module(module) File "", line 678, in exec_module File "", line 219, in _call_with_frames_removed File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/superset/migrations/env.py", line 103, in run_migrations_online() File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/superset/migrations/env.py", line 96, in run_migrations_online context.run_migrations() File "", line 8, in run_migrations File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/alembic/runtime/environment.py", line 836, in run_migrations self.get_context().run_migrations(**kw) File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/alembic/runtime/migration.py", line 321, in run_migrations for step in self._migrations_fn(heads, self): File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/alembic/command.py", line 243, in upgrade return script._upgrade_revs(revision, rev) File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/alembic/script/base.py", line 336, in _upgrade_revs revs = list(revs) File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/alembic/script/revision.py", line 656, in _iterate_revisions uppers = util.dedupe_tuple(self.get_revisions(upper)) File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/alembic/script/revision.py", line 301, in get_revisions resolved_id, branch_label = self._resolve_revision_number(id_) File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/alembic/script/revision.py", line 437, in _resolve_revision_number self._revision_map File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/alembic/util/langhelpers.py", line 239, in __get__ obj.__dict__[self.__name__] = result = self.fget(obj) File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/alembic/script/revision.py", line 122, in _revision_map for revision in self._generator(): File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/alembic/script/base.py", line 99, in _load_revisions script = Script._from_filename(self, vers, file_) File "/Users/abdealijk/anaconda3/lib/python3.6/site-packages/alembic/script/base.py", line 812, in _from_filename
[GitHub] TianyangLi commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI
TianyangLi commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389476460 @miloradkrstevski assuming your language of choice is python you need a python driver for mysql as superset uses SQLAlchemy to process SQL related queries in the back-end. Do you have that python driver installed?? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] xrmx commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI
xrmx commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389513748 @miloradkrstevski if you had read the documentation you'll have see that 1) windows is not supported, 2) the docs suggests another driver for mysql This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] qyoz commented on issue #1797: Add Ability to Save Results from Previous Queries Using S3
qyoz commented on issue #1797: Add Ability to Save Results from Previous Queries Using S3 URL: https://github.com/apache/incubator-superset/issues/1797#issuecomment-389486609 @mistercrunch I'd like to ask for this to be reopened. Our use case is showing query results from today together with a "snapshot" of yesterdays data. So like @jfeng15 asked, what's the remaining gap that needs to be developed? Is the S3 cache working? I couldn't find any examples in the documentation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI
miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into
SQLAlchemy URI
URL:
https://github.com/apache/incubator-superset/issues/5013#issuecomment-389513140
@TianyangLi Does not work. Here is the info (from Windows): (in Ubuntu will
try next)
> Traceback (most recent call last):
File "C:\venv\lib\site-packages\superset\views\core.py", line 1691, in
testconn
engine = create_engine(uri, connect_args=connect_args)
File "C:\venv\lib\site-packages\sqlalchemy\engine\__init__.py", line 419,
in create_engine
return strategy.create(*args, **kwargs)
File "C:\venv\lib\site-packages\sqlalchemy\engine\strategies.py", line 80,
in create
dbapi = dialect_cls.dbapi(**dbapi_args)
File "C:\venv\lib\site-packages\sqlalchemy\dialects\mysql\mysqldb.py",
line 102, in dbapi
return __import__('MySQLdb')
ImportError: No module named MySQLdb
2018-05-16 15:08:43,316:INFO:werkzeug:127.0.0.1 - - [16/May/2018 15:08:43]
"POST /superset/testconn HTTP/1.1" 500 -
Something else comes to mind for a solution?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI
miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389514720 @xrmx Dude, I read the docs. And somehow it was working in Windows with some previous version of Superset and conn with MySQL. The thing is that I did not write it down what I have installed to work, but I know it was searching for solution pretty well, like now. Now, I will test as @TianyangLi suggests and will find out. BTW, do you have any possible solution in mind? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI
miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389514720 @xrmx Dude, I read the docs. And somehow it was working in Windows with some previous version of Superset and conn with MySQL. The thing is that I did not write it down what I have installed to work, but I know it was searching for solution pretty well, like now. Now, I will test as @TianyangLi suggests and will find out. BTW, @xrmx, do you have any possible solution in mind? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI
miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389514720 @xrmx Dude, I read the docs. And somehow it was working in Windows with some previous version of Superset and conn with MySQL. The thing is that I did not write it down what I have installed to work, but I know it was searching for solution pretty well, like now. Now, I will test as @TianyangLi suggests and will find you. BTW, do you have any possible solution in mind? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] TianyangLi commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI
TianyangLi commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389490045 @miloradkrstevski The error itself is a very straight forward fix. On ubuntu its as straight forward as: sudo apt-get install python-mysqldb If you have a alternative linux set-up that might just do it. let me know how you go...not sure if running python 2.7 might have an affect. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] TianyangLi commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI
TianyangLi commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389490045 @miloradkrstevski The error itself is a very straight forward fix. On ubuntu its as straight forward as: sudo apt-get install python-mysqldb If you have a alternative linux set-up that might just do it. let me know how you go... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] gdkatant1 commented on issue #4999: Use a better version number in `master`
gdkatant1 commented on issue #4999: Use a better version number in `master` URL: https://github.com/apache/incubator-superset/issues/4999#issuecomment-389222902 Hi, Thanks for your reply and your action. I don't know if it's related to the version but i am getting an error in the "Country Map" visualization type. This is working in the version that i install using pip (not locally built from source) The error is the following : Table actually shows (the normal behavior) :  When i choose Country Map, i get an "unhashable type: 'dict'" error  If you say it's unrelated to the version i can open a different issue and give more details about it. Thanks again This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] gdkatant1 commented on issue #4999: Use a better version number in `master`
gdkatant1 commented on issue #4999: Use a better version number in `master` URL: https://github.com/apache/incubator-superset/issues/4999#issuecomment-389222902 Hi, Thanks for your reply and your action. I don't know if it's related to the version but i am getting an error in the "Country Map" visualization type. This is working in the version that i install using pip (not locally built from source) The error is the following : Table actually shows (the normal behavior) :  When i choose Country Map, i get an "unhashable type: 'dict'" error  If you say it's unrelated to the version i can open a different issue and give more details about it. Thanks again This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch opened a new pull request #5007: Fix EncryptedType error
mistercrunch opened a new pull request #5007: Fix EncryptedType error URL: https://github.com/apache/incubator-superset/pull/5007 fixes https://github.com/apache/incubator-superset/issues/5005 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] findepi commented on issue #4953: flask-appbuilder 1.10.0 has requirement Flask<0.12.99, >=0.12.1, but you'll have flask 1.0.2 which is incompatible
findepi commented on issue #4953: flask-appbuilder 1.10.0 has requirement Flask<0.12.99,>=0.12.1, but you'll have flask 1.0.2 which is incompatible URL: https://github.com/apache/incubator-superset/issues/4953#issuecomment-389248933 No, i use docker, so I get fresh state each time > This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] graceguo-supercat opened a new pull request #5009: [WiP] fix dashboard server-side unit tests
graceguo-supercat opened a new pull request #5009: [WiP] fix dashboard server-side unit tests URL: https://github.com/apache/incubator-superset/pull/5009 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5002: superset presto database support editing `X-Presto-Source`
mistercrunch commented on issue #5002: superset presto database support editing `X-Presto-Source` URL: https://github.com/apache/incubator-superset/issues/5002#issuecomment-38922 In the newer version you can use the impersonation feature or the `DB_CONNECTION_MUTATOR` config key: https://github.com/apache/incubator-superset/blob/master/superset/config.py#L401 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5000: Use a dummy version number on master
mistercrunch commented on issue #5000: Use a dummy version number on master URL: https://github.com/apache/incubator-superset/pull/5000#issuecomment-389246486 @xrmx it means an extra PR at every release and it's easy to forget. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5004: db upgrade importError:No module named 'contextlib2'
mistercrunch commented on issue #5004: db upgrade importError:No module named 'contextlib2' URL: https://github.com/apache/incubator-superset/issues/5004#issuecomment-389250941 Which version of python? Which os/version? Please provide the full stacktrace. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] gdkatant1 commented on issue #4999: Use a better version number in `master`
gdkatant1 commented on issue #4999: Use a better version number in `master` URL: https://github.com/apache/incubator-superset/issues/4999#issuecomment-389231281 Hi, Thank you for your reply. Should i close this issue or do you need it to stay open for final fix that works with npm and setuptools ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5000: Use a dummy version number on master
mistercrunch commented on issue #5000: Use a dummy version number on master URL: https://github.com/apache/incubator-superset/pull/5000#issuecomment-389246486 @xrmx I means an extra PR at every release and it's easy to forget. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5019: fix missing datasource error message
mistercrunch commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389933718 Can we change the error message to something like "The data source associated with this chart no longer exists"? Also, should we raise right then (asap) instead of waiting for raising in `viz.py` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] abowden-spotx closed pull request #4747: [WiP] Download Dashboards as PDF
abowden-spotx closed pull request #4747: [WiP] Download Dashboards as PDF
URL: https://github.com/apache/incubator-superset/pull/4747
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/javascripts/dashboard/components/Header.jsx
b/superset/assets/javascripts/dashboard/components/Header.jsx
index 52d3024ff9..f56ee1c932 100644
--- a/superset/assets/javascripts/dashboard/components/Header.jsx
+++ b/superset/assets/javascripts/dashboard/components/Header.jsx
@@ -7,6 +7,7 @@ import Button from '../../components/Button';
import FaveStar from '../../components/FaveStar';
import InfoTooltipWithTrigger from '../../components/InfoTooltipWithTrigger';
import { t } from '../../locales';
+import * as util from '../../reduxUtils';
const propTypes = {
dashboard: PropTypes.object.isRequired,
@@ -68,6 +69,19 @@ class Header extends React.PureComponent {
{btnText}
);
}
+ renderDownloadButton() {
+// TODO: review button style
+const btnText = 'Download';
+return (
+
+{btnText}
+ );
+ }
render() {
const dashboard = this.props.dashboard;
return (
diff --git a/superset/assets/javascripts/reduxUtils.js
b/superset/assets/javascripts/reduxUtils.js
index d843d279a2..9036e5421f 100644
--- a/superset/assets/javascripts/reduxUtils.js
+++ b/superset/assets/javascripts/reduxUtils.js
@@ -98,3 +98,15 @@ export function areArraysShallowEqual(arr1, arr2) {
export function areObjectsEqual(obj1, obj2) {
return equals(obj1, obj2, true);
}
+
+export function downloadCurPage() {
+ // This will call a python script to download the current page as a pdf
+ $.ajax({
+ type: 'GET',
+ url: '/download_pdf',
+ data: function() {
+ return string(window.location.href) //TODO: pass dash specific info
+ },
+ success: alert('PDF Downloaded')
+ })
+}
diff --git a/superset/views/core.py b/superset/views/core.py
index 91a420ae28..d723a37adf 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -692,6 +692,15 @@ def ping():
return 'OK'
+@app.route('/download_pdf')
+def download_pdf(url='http://localhost:8088/superset/dashboard/births/'):
#TODO: collect url to download
+#TODO: pass session authorization
+dir = os.getcwd() #TODO
+file_name = 'sample_dl.pdf' #TODO: file naming structure
+pdfkit.from_url(url, dir + file_name)
+return 'Success'
+
+
class KV(BaseSupersetView):
"""Used for storing and retrieving key value pairs"""
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit
timifasubaa commented on a change in pull request #5023: [sqllab] force limit
queries only when there is no existing limit
URL:
https://github.com/apache/incubator-superset/pull/5023#discussion_r189043405
##
File path: superset/sql_lab.py
##
@@ -171,6 +171,7 @@ def handle_error(msg):
# Limit enforced only for retrieving the data, not for the CTA queries.
superset_query = SupersetQuery(rendered_query)
executed_sql = superset_query.stripped()
+SQL_MAX_ROWS = int(app.config.get('SQL_MAX_ROW', None))
Review comment:
I'll send out the fir for this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression
mistercrunch commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389936762 All examples get executed as integration test, so if you add a new example chart that cover this use case it should fail before your PR, succeed after This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #1797: Add Ability to Save Results from Previous Queries Using S3
mistercrunch commented on issue #1797: Add Ability to Save Results from Previous Queries Using S3 URL: https://github.com/apache/incubator-superset/issues/1797#issuecomment-389931667 Seems like a data engineering / data preparation would be best in this case. You'd ETL your user conf data into a data warehouse, while keeping track of the history/changes. While Superset has caching features, there's no chart "snapshoting" feature and would make the cache saved as of a point in time for a specific chart. I don't see that coming anytime soon, so your best bet is ETL. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit
mistercrunch commented on a change in pull request #5023: [sqllab] force limit
queries only when there is no existing limit
URL:
https://github.com/apache/incubator-superset/pull/5023#discussion_r189029978
##
File path: superset/sql_lab.py
##
@@ -185,7 +186,8 @@ def handle_error(msg):
query.user_id, start_dttm.strftime('%Y_%m_%d_%H_%M_%S'))
executed_sql = superset_query.as_create_table(query.tmp_table_name)
query.select_as_cta_used = True
-elif (query.limit and superset_query.is_select()):
+elif (not query.limit and superset_query.is_select() and SQL_MAX_ROWS):
Review comment:
Wait I think you remove all handling of `query.limit` where it's defined
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit
mistercrunch commented on a change in pull request #5023: [sqllab] force limit
queries only when there is no existing limit
URL:
https://github.com/apache/incubator-superset/pull/5023#discussion_r189029182
##
File path: superset/sql_lab.py
##
@@ -171,6 +171,7 @@ def handle_error(msg):
# Limit enforced only for retrieving the data, not for the CTA queries.
superset_query = SupersetQuery(rendered_query)
executed_sql = superset_query.stripped()
+SQL_MAX_ROWS = int(app.config.get('SQL_MAX_ROW', None))
Review comment:
`None` is implicit on the get method and will make `int` raise
```
In [1]: int(None)
TypeError: int() argument must be a string, a bytes-like object or a number,
not 'NoneType'
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5019: fix missing datasource error message
mistercrunch commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389934250 About cascading, I think that would be the desired behavior as long as there's clarity on what is happening. There should be a confirmation screen with all the associated objects that are going to be deleted, and the person performing the operation should have write/delete access to all these objects. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit
timifasubaa commented on a change in pull request #5023: [sqllab] force limit
queries only when there is no existing limit
URL:
https://github.com/apache/incubator-superset/pull/5023#discussion_r189043307
##
File path: superset/sql_lab.py
##
@@ -185,7 +186,8 @@ def handle_error(msg):
query.user_id, start_dttm.strftime('%Y_%m_%d_%H_%M_%S'))
executed_sql = superset_query.as_create_table(query.tmp_table_name)
query.select_as_cta_used = True
-elif (query.limit and superset_query.is_select()):
+elif (not query.limit and superset_query.is_select() and SQL_MAX_ROWS):
Review comment:
@mistercrunch I tested it and it works correctly.
I changed the place where query.limit is defined upstream and it is None
only when it is not specified. It is only in those cases that we append the
default limit to the end.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] zkenstein opened a new issue #5017: Error Add MySQL DB
zkenstein opened a new issue #5017: Error Add MySQL DB URL: https://github.com/apache/incubator-superset/issues/5017 Make sure these boxes are checked before submitting your issue - thank you! - [* ] I have checked the superset logs for python stacktraces and included it here as text if any - [* ] I have reproduced the issue with at least the latest released version of superset - [ ] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version ### Expected results ### Actual results ### Steps to reproduce Hi All I am very new with superset, i tired to add a mysql database, all connection tested result seem OK with the list of the tables at the bottom of page, but when I tried to save it present the error: General Error . Any one have faced this before? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message
graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message URL: https://github.com/apache/incubator-superset/pull/4900#issuecomment-389617808 @jasnovak @mistercrunch If user doesn't have save access to dashboard, we used to allow user `save-as` a new copy of this dashboard ( and allow copy all slices under current dashboard). With this PR, user can't save-as another dashboard anymore. Is this intended behavior? before: https://user-images.githubusercontent.com/27990562/40135870-37ad10fe-58fb-11e8-9e6c-d21738246f7a.png;> after: https://user-images.githubusercontent.com/27990562/40136272-41b3deb0-58fc-11e8-8869-083a113eea22.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mashbourne commented on issue #900: Nanosecond timestamp year range workaround
mashbourne commented on issue #900: Nanosecond timestamp year range workaround URL: https://github.com/apache/incubator-superset/issues/900#issuecomment-389603000 Throws (default): pd.to_datetime(datetime.date(2262, 4, 12),errors='raise') Swallows: pd.to_datetime(datetime.date(2262, 4, 12),errors='coerce') any chance we could change this to coerce? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI
miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into
SQLAlchemy URI
URL:
https://github.com/apache/incubator-superset/issues/5013#issuecomment-389605825
@mistercrunch When I try to install `pip install mysqlclient`, it goes me
the following error:
> Collecting mysqlclient
Downloading
https://files.pythonhosted.org/packages/6f/86/bad31f1c1bb0cc99e88ca2adb7cb5c71f7a6540c1bb001480513de76a931/mysqlclient-1.3.12.tar.gz
(89kB)
100% || 92kB 735kB/s
Complete output from command python setup.py egg_info:
sh: 1: mysql_config: not found
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-build-WdyxRX/mysqlclient/setup.py", line 17, in
metadata, options = get_config()
File "setup_posix.py", line 44, in get_config
libs = mysql_config("libs_r")
File "setup_posix.py", line 26, in mysql_config
raise EnvironmentError("%s not found" % (mysql_config.path,))
EnvironmentError: mysql_config not found
Command "python setup.py egg_info" failed with error code 1 in
/tmp/pip-build-WdyxRX/mysqlclient/
What does this mean? Can anyone please explain me? I am novice in this and
using only Superset. Thank you.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message
graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message URL: https://github.com/apache/incubator-superset/pull/4900#issuecomment-389617808 @jasnovak @mistercrunch If user doesn't have save access to dashboard, we used to allow user `save-as` to another copy (allow copy slices under current dashboard). With this PR, user can't save-as another dashboard anymore. Is this intended behavior? https://user-images.githubusercontent.com/27990562/40135870-37ad10fe-58fb-11e8-9e6c-d21738246f7a.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI
mistercrunch commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389617576 Please research how to install `mysqlclient` on the os your own, usually installing the package for the mysql client (CLI) will install the required deps. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5010: superset db upgrade error: ImportError: cannot import name EncryptedType
mistercrunch commented on issue #5010: superset db upgrade error: ImportError: cannot import name EncryptedType URL: https://github.com/apache/incubator-superset/issues/5010#issuecomment-389620809 Should be fixed in `0.25.3` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5005: DB Upgrade - Fails with sqlalchemy_utils errors
mistercrunch commented on issue #5005: DB Upgrade - Fails with sqlalchemy_utils errors URL: https://github.com/apache/incubator-superset/issues/5005#issuecomment-389620646 Should be fixed in `0.25.3` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] zkenstein closed issue #5017: Error Add MySQL DB
zkenstein closed issue #5017: Error Add MySQL DB URL: https://github.com/apache/incubator-superset/issues/5017 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] qyoz commented on issue #1797: Add Ability to Save Results from Previous Queries Using S3
qyoz commented on issue #1797: Add Ability to Save Results from Previous Queries Using S3 URL: https://github.com/apache/incubator-superset/issues/1797#issuecomment-389579059 so it this the right issue for what we're asking? or should I open a feature request? this isn't about running in async mode, the use case here is saving the result and being able to slice it This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] jasnovak commented on issue #4900: Hide restricted ui elements, remove from error message
jasnovak commented on issue #4900: Hide restricted ui elements, remove from error message URL: https://github.com/apache/incubator-superset/pull/4900#issuecomment-389625306 Yes, this is intended behavior. We have a read-only role that we don't want to give the ability to create dashboards. So we don't give them save access, which for this case should also mean no save-as. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mts2016 opened a new issue #5018: Data too long for column 'type' at row 1
mts2016 opened a new issue #5018: Data too long for column 'type' at row 1
URL: https://github.com/apache/incubator-superset/issues/5018
Make sure these boxes are checked before submitting your issue - thank you!
- [x ] I have checked the superset logs for python stacktraces and included
it here as text if any
- [x] I have reproduced the issue with at least the latest released version
of superset
- [] I have checked the issue tracker for the same issue and I haven't found
one similar
### Superset version
0.25.2
Configuration :
OS: Ubuntu 18.04 LTS
Python: 3.6,
Backend Source database : MS SQL Server
Metadatabase : mysql
Trying to refresh Column Metadata of a table, I'm getting the following
error :
(Similar issue : #4271)
Exception on /tablemodelview/action_post [POST]
Traceback (most recent call last):
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/sqlalchemy/engine/base.py",
line 1193, in _execute_context
context)
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/sqlalchemy/engine/default.py",
line 507, in do_execute
cursor.execute(statement, parameters)
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/MySQLdb/cursors.py",
line 250, in execute
self.errorhandler(self, exc, value)
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/MySQLdb/connections.py",
line 50, in defaulterrorhandler
raise errorvalue
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/MySQLdb/cursors.py",
line 247, in execute
res = self._query(query)
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/MySQLdb/cursors.py",
line 411, in _query
rowcount = self._do_query(q)
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/MySQLdb/cursors.py",
line 374, in _do_query
db.query(q)
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/MySQLdb/connections.py",
line 277, in query
_mysql.connection.query(self, query)
_mysql_exceptions.DataError: (1406, "Data too long for column 'type' at row
1")
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/flask/app.py",
line 1982, in wsgi_app
response = self.full_dispatch_request()
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/flask/app.py",
line 1614, in full_dispatch_request
rv = self.handle_user_exception(e)
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/flask/app.py",
line 1517, in handle_user_exception
reraise(exc_type, exc_value, tb)
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/flask/_compat.py",
line 33, in reraise
raise value
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/flask/app.py",
line 1612, in full_dispatch_request
rv = self.dispatch_request()
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/flask/app.py",
line 1598, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/flask_appbuilder/views.py",
line 578, in action_post
return action.func(items)
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/superset/connectors/sqla/views.py",
line 300, in refresh
t.fetch_metadata()
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/superset/connectors/sqla/models.py",
line 793, in fetch_metadata
self.add_missing_metrics(metrics)
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/superset/connectors/base/models.py",
line 127, in add_missing_metrics
exisiting_metrics = {m.metric_name for m in self.metrics}
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/sqlalchemy/orm/attributes.py",
line 242, in __get__
return self.impl.get(instance_state(instance), dict_)
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/sqlalchemy/orm/attributes.py",
line 599, in get
value = self.callable_(state, passive)
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/sqlalchemy/orm/strategies.py",
line 623, in _load_for_state
return self._emit_lazyload(session, state, ident_key, passive)
File "", line 1, in
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/sqlalchemy/orm/strategies.py",
line 747, in _emit_lazyload
result = q(session).params(**params).all()
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/sqlalchemy/ext/baked.py",
line 434, in all
return list(self)
File
"/home/user/anaconda3/envs/super/lib/python3.6/site-packages/sqlalchemy/ext/baked.py",
line
[GitHub] veszig commented on issue #5004: db upgrade importError:No module named 'contextlib2'
veszig commented on issue #5004: db upgrade importError:No module named 'contextlib2' URL: https://github.com/apache/incubator-superset/issues/5004#issuecomment-389277179 I have the same issue. After upgrading I get the following error message when I try to upgrade the db: ``` $ superset db upgrade Traceback (most recent call last): File "/mnt/srv/superset/venv/bin/superset", line 12, in from superset.cli import manager File "/mnt/srv/superset/venv/local/lib/python2.7/site-packages/superset/__init__.py", line 179, in ConnectorRegistry.register_sources(module_datasource_map) File "/mnt/srv/superset/venv/local/lib/python2.7/site-packages/superset/connectors/connector_registry.py", line 20, in register_sources module_obj = __import__(module_name, fromlist=class_names) File "/mnt/srv/superset/venv/local/lib/python2.7/site-packages/superset/connectors/sqla/__init__.py", line 3, in from . import views # noqa File "/mnt/srv/superset/venv/local/lib/python2.7/site-packages/superset/connectors/sqla/views.py", line 19, in from superset.connectors.base.views import DatasourceModelView File "/mnt/srv/superset/venv/local/lib/python2.7/site-packages/superset/connectors/base/views.py", line 11, in from superset.views.base import SupersetModelView File "/mnt/srv/superset/venv/local/lib/python2.7/site-packages/superset/views/__init__.py", line 3, in from . import core # noqa File "/mnt/srv/superset/venv/local/lib/python2.7/site-packages/superset/views/core.py", line 36, in from superset import ( File "/mnt/srv/superset/venv/local/lib/python2.7/site-packages/superset/sql_lab.py", line 12, in from contextlib2 import contextmanager ImportError: No module named contextlib2 ``` Versions: ``` $ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description:Ubuntu 16.04.3 LTS Release:16.04 Codename: xenial $ python -V Python 2.7.12 ``` And `pip install contextlib2` fixes this issue but I get another seemingly unrelated exception. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] GabeLoins commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression
GabeLoins commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389688161 @michellethomas do we need to do something like this for druid as well? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on a change in pull request #5019: fix missing datasource error message
mistercrunch commented on a change in pull request #5019: fix missing
datasource error message
URL:
https://github.com/apache/incubator-superset/pull/5019#discussion_r188800947
##
File path: superset/views/core.py
##
@@ -1229,7 +1229,10 @@ def datasource_info(datasource_id, datasource_type,
form_data):
datasource = form_data.get('datasource', '')
if '__' in datasource:
datasource_id, datasource_type = datasource.split('__')
-datasource_id = int(datasource_id)
+# The case where the datasource has been deleted
+datasource_id = None if datasource_id == 'None' else datasource_id
Review comment:
I don't understand how `datasource_id == 'None'` comes into being in the
first place. Can we catch the issue upstream?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5006: ImportError: No module named 'flask.exthook'
mistercrunch commented on issue #5006: ImportError: No module named 'flask.exthook' URL: https://github.com/apache/incubator-superset/issues/5006#issuecomment-389697967 Ooops, my bad, fixing in 0.25.4 (pushing this out now) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression
michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389699387 @mistercrunch I didn't see a lot of tests for this section of the code. Did you have thoughts on where to add tests for this (viz_tests maybe?)? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5022: Fix flask<1.0.0
codecov-io commented on issue #5022: Fix flask<1.0.0 URL: https://github.com/apache/incubator-superset/pull/5022#issuecomment-389701303 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5022?src=pr=h1) Report > Merging [#5022](https://codecov.io/gh/apache/incubator-superset/pull/5022?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2bf53dad9892fb2fa7b8f634cdd7e4381cd1696a?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/5022?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5022 +/- ## === Coverage 77.34% 77.34% === Files 44 44 Lines8665 8665 === Hits 6702 6702 Misses 1963 1963 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5022?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5022?src=pr=footer). Last update [2bf53da...2ba929a](https://codecov.io/gh/apache/incubator-superset/pull/5022?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression
michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389699387 @mistercrunch I didn't see a lot of tests for this section of the code. Did you have thoughts on where to add tests for this? It looks like I could fit it into viz_tests.TableVizTestCase. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] zkenstein opened a new issue #5016: Hi All I am very new with superset, i tired to add a mysql database, all connection tested result seem OK with the list of the tables at the bottom of page
zkenstein opened a new issue #5016: Hi All I am very new with superset, i tired to add a mysql database, all connection tested result seem OK with the list of the tables at the bottom of page, but when I tried to save it present the error: General Error . Any one have faced this before? URL: https://github.com/apache/incubator-superset/issues/5016 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included it here as text if any - [ ] I have reproduced the issue with at least the latest released version of superset - [ ] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version ### Expected results ### Actual results ### Steps to reproduce This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #1797: Add Ability to Save Results from Previous Queries Using S3
mistercrunch commented on issue #1797: Add Ability to Save Results from Previous Queries Using S3 URL: https://github.com/apache/incubator-superset/issues/1797#issuecomment-389618284 Why not creating a summary table (CREATE TABLE AS) and then slice/dicing the result set in that summary table? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression
codecov-io commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389692391 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=h1) Report > Merging [#5021](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2bf53dad9892fb2fa7b8f634cdd7e4381cd1696a?src=pr=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `14.28%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=tree) ```diff @@Coverage Diff@@ ## master #5021 +/- ## = - Coverage 77.34% 77.3% -0.04% = Files 44 44 Lines86658669 +4 = Hits 67026702 - Misses 19631967 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5021/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `75.8% <14.28%> (-0.62%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=footer). Last update [2bf53da...4ea337c](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression
michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389699387 @mistercrunch I didn't see a lot of tests for this section of the code. Did you have thoughts on where to add tests for this? It looks like I could fit it into TableVizTestCase but maybe worth adding tests for the line chart. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] joaomg opened a new issue #5047: Request for guidance
joaomg opened a new issue #5047: Request for guidance
URL: https://github.com/apache/incubator-superset/issues/5047
Make sure these boxes are checked before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included
it here as text if any
- [ ] I have reproduced the issue with at least the latest released version
of superset
- [x] I have checked the issue tracker for the same issue and I haven't
found one similar
### Superset version
Superset 0.23.0dev
### Expected results
I'd like to reuse the controls, React components, inside a visualization.
I'm using a custom made visualization in my local repo.
I want to add further interaction with the user inside the slice component.
My visualization is implemented, as expected, in distinct files: graph.js,
graph.css.
It's being called with the result data as it's supposed.
import './graph.css';
...
function graphVis(slice, payload) {
...
};
module.exports = graphVis;
Now, somewhere inside the graphVis function I'd like to add Superset
controls, namely VirtualizedSelect as a child of the slice.container
(slice.containerId).
I'm aware this is a bit unusual, but it's a requirement for my project.
I'd appreciate any hints on how to make this work.
### Actual results
N/A
### Steps to reproduce
N/A
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5038: [Explore] [Adhoc Metrics/Filters] Force Ace editor to refresh when it is shown
codecov-io commented on issue #5038: [Explore] [Adhoc Metrics/Filters] Force Ace editor to refresh when it is shown URL: https://github.com/apache/incubator-superset/pull/5038#issuecomment-390711361 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5038?src=pr=h1) Report > Merging [#5038](https://codecov.io/gh/apache/incubator-superset/pull/5038?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9f66dae328b70b277bfc0e1f47c3f63aff541ae4?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/5038?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5038 +/- ## === Coverage 77.34% 77.34% === Files 44 44 Lines8671 8671 === Hits 6707 6707 Misses 1964 1964 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5038?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5038?src=pr=footer). Last update [9f66dae...719c625](https://codecov.io/gh/apache/incubator-superset/pull/5038?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] joaomg commented on issue #5047: Request for guidance
joaomg commented on issue #5047: Request for guidance URL: https://github.com/apache/incubator-superset/issues/5047#issuecomment-390716950 I've realized that the FilterBoxViz should be my starting point. I'll probably extend it to my needs. Closing this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] joaomg closed issue #5047: Request for guidance
joaomg closed issue #5047: Request for guidance URL: https://github.com/apache/incubator-superset/issues/5047 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] GabeLoins commented on issue #5045: Can't select the table's other metrics when explore the chart expect the count(*) metric
GabeLoins commented on issue #5045: Can't select the table's other metrics when explore the chart expect the count(*) metric URL: https://github.com/apache/incubator-superset/issues/5045#issuecomment-390699146 @zhangjian0111 we recently updated how the Metrics Control is used, refer to https://github.com/apache/incubator-superset/pull/4736 and https://github.com/apache/incubator-superset/pull/4663 for examples of how to add metrics. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] zhaoyongjie opened a new pull request #5048: [bugfix] Render to section by override value
zhaoyongjie opened a new pull request #5048: [bugfix] Render to section by override value URL: https://github.com/apache/incubator-superset/pull/5048  render section by override value and adding renderTigger to histogram This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5030: [Explore][AdhocMetrics] treating floats like doubles for druid versions lower than 11.0.0
codecov-io commented on issue #5030: [Explore][AdhocMetrics] treating floats like doubles for druid versions lower than 11.0.0 URL: https://github.com/apache/incubator-superset/pull/5030#issuecomment-390709874 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5030?src=pr=h1) Report > Merging [#5030](https://codecov.io/gh/apache/incubator-superset/pull/5030?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9f66dae328b70b277bfc0e1f47c3f63aff541ae4?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `93.33%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5030?src=pr=tree) ```diff @@Coverage Diff @@ ## master#5030 +/- ## == + Coverage 77.34% 77.35% +<.01% == Files 44 44 Lines8671 8677 +6 == + Hits 6707 6712 +5 - Misses 1964 1965 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5030?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5030/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `80.53% <93.33%> (+0.02%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5030?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5030?src=pr=footer). Last update [9f66dae...be99931](https://codecov.io/gh/apache/incubator-superset/pull/5030?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5030: [Explore][AdhocMetrics] treating floats like doubles for druid versions lower than 11.0.0
codecov-io commented on issue #5030: [Explore][AdhocMetrics] treating floats like doubles for druid versions lower than 11.0.0 URL: https://github.com/apache/incubator-superset/pull/5030#issuecomment-390709874 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5030?src=pr=h1) Report > Merging [#5030](https://codecov.io/gh/apache/incubator-superset/pull/5030?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9f66dae328b70b277bfc0e1f47c3f63aff541ae4?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `93.33%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5030?src=pr=tree) ```diff @@Coverage Diff @@ ## master#5030 +/- ## == + Coverage 77.34% 77.35% +<.01% == Files 44 44 Lines8671 8677 +6 == + Hits 6707 6712 +5 - Misses 1964 1965 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5030?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5030/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `80.53% <93.33%> (+0.02%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5030?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5030?src=pr=footer). Last update [9f66dae...be99931](https://codecov.io/gh/apache/incubator-superset/pull/5030?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] chutianshu1981 commented on issue #2756: Advanced Analytics Documentation
chutianshu1981 commented on issue #2756: Advanced Analytics Documentation URL: https://github.com/apache/incubator-superset/issues/2756#issuecomment-390656544 +1 same question This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] williaster commented on issue #4993: [dashboard v2] tests!
williaster commented on issue #4993: [dashboard v2] tests! URL: https://github.com/apache/incubator-superset/pull/4993#issuecomment-390735896 @graceguo-supercat can you please review the tests for filters + dashboard since you are most familiar with this code? still can't find the bug you mentioned about filters. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] michellethomas opened a new issue #5049: Slices with new Adhoc Filters break dashboards
michellethomas opened a new issue #5049: Slices with new Adhoc Filters break dashboards URL: https://github.com/apache/incubator-superset/issues/5049 Currently on master adding a slice with an adhoc filter breaks the dashboard page. `Cannot read property 'concat' of undefined at eval (eval at getFormDataExtra (Dashboard.jsx?623f:546), :1:23)` - [x] I have checked the superset logs for python stacktraces and included it here as text if any - [x] I have reproduced the issue with at least the latest released version of superset - [x] I have checked the issue tracker for the same issue and I haven't found one similar ### Expected results Slices with adhoc filters display correctly ### Actual results Slices with adhoc filters break dashboard pages ### Steps to reproduce Create a slice with an adhoc filter and add it to a dashboard This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] williaster commented on a change in pull request #4979: Dashboard save button
williaster commented on a change in pull request #4979: Dashboard save button
URL:
https://github.com/apache/incubator-superset/pull/4979#discussion_r189679922
##
File path: superset/assets/src/dashboard/components/SaveModal.jsx
##
@@ -1,36 +1,40 @@
/* eslint-env browser */
import React from 'react';
import PropTypes from 'prop-types';
-import $ from 'jquery';
import { Button, FormControl, FormGroup, Radio } from 'react-bootstrap';
-import { getAjaxErrorMsg } from '../../modules/utils';
import ModalTrigger from '../../components/ModalTrigger';
import { t } from '../../locales';
import Checkbox from '../../components/Checkbox';
+export const SAVE_TYPE_OVERWRITE = 'overwrite';
Review comment:
see comment about moving these to constants file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] williaster commented on a change in pull request #4979: Dashboard save button
williaster commented on a change in pull request #4979: Dashboard save button
URL:
https://github.com/apache/incubator-superset/pull/4979#discussion_r189680562
##
File path: superset/assets/src/dashboard/reducers/dashboardState.js
##
@@ -14,13 +14,13 @@ import {
TOGGLE_BUILDER_PANE,
TOGGLE_EXPAND_SLICE,
TOGGLE_FAVE_STAR,
- UPDATE_DASHBOARD_TITLE,
+ UPDATE_CSS,
} from '../actions/dashboardState';
export default function dashboardStateReducer(state = {}, action) {
const actionHandlers = {
-[UPDATE_DASHBOARD_TITLE]() {
Review comment:
nice catch
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch closed pull request #5030: [Explore][AdhocMetrics] treating floats like doubles for druid versions lower than 11.0.0
mistercrunch closed pull request #5030: [Explore][AdhocMetrics] treating floats
like doubles for druid versions lower than 11.0.0
URL: https://github.com/apache/incubator-superset/pull/5030
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.pylintrc b/.pylintrc
index 0f9710688d..820637dbd0 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -277,7 +277,7 @@ ignore-mixin-members=yes
# (useful for modules/projects where namespaces are manipulated during runtime
# and thus existing member attributes cannot be deduced by static analysis. It
# supports qualified module names, as well as Unix pattern matching.
-ignored-modules=numpy,pandas,alembic.op,sqlalchemy,alembic.context,flask_appbuilder.security.sqla.PermissionView.role,flask_appbuilder.Model.metadata,flask_appbuilder.Base.metadata
+ignored-modules=numpy,pandas,alembic.op,sqlalchemy,alembic.context,flask_appbuilder.security.sqla.PermissionView.role,flask_appbuilder.Model.metadata,flask_appbuilder.Base.metadata,distutils
# List of class names for which member attributes should not be checked (useful
# for classes with dynamically set attributes). This supports the use of
diff --git a/superset/connectors/druid/models.py
b/superset/connectors/druid/models.py
index 85afc852b2..79b0dad607 100644
--- a/superset/connectors/druid/models.py
+++ b/superset/connectors/druid/models.py
@@ -9,6 +9,7 @@
from collections import OrderedDict
from copy import deepcopy
from datetime import datetime, timedelta
+from distutils.version import LooseVersion
import json
import logging
from multiprocessing.pool import ThreadPool
@@ -899,8 +900,8 @@ def resolve_postagg(postagg, post_aggs, agg_names,
visited_postaggs, metrics_dic
missing_postagg, post_aggs, agg_names, visited_postaggs,
metrics_dict)
post_aggs[postagg.metric_name] =
DruidDatasource.get_post_agg(postagg.json_obj)
-@classmethod
-def metrics_and_post_aggs(cls, metrics, metrics_dict):
+@staticmethod
+def metrics_and_post_aggs(metrics, metrics_dict, druid_version=None):
# Separate metrics into those that are aggregations
# and those that are post aggregations
saved_agg_names = set()
@@ -920,9 +921,13 @@ def metrics_and_post_aggs(cls, metrics, metrics_dict):
for postagg_name in postagg_names:
postagg = metrics_dict[postagg_name]
visited_postaggs.add(postagg_name)
-cls.resolve_postagg(
+DruidDatasource.resolve_postagg(
postagg, post_aggs, saved_agg_names, visited_postaggs,
metrics_dict)
-aggs = cls.get_aggregations(metrics_dict, saved_agg_names,
adhoc_agg_configs)
+aggs = DruidDatasource.get_aggregations(
+metrics_dict,
+saved_agg_names,
+adhoc_agg_configs,
+)
return aggs, post_aggs
def values_for_column(self,
@@ -997,11 +1002,12 @@ def _add_filter_from_pre_query_data(self, df,
dimensions, dim_filter):
@staticmethod
def druid_type_from_adhoc_metric(adhoc_metric):
-column_type = adhoc_metric.get('column').get('type').lower()
-aggregate = adhoc_metric.get('aggregate').lower()
-if (aggregate == 'count'):
+column_type = adhoc_metric['column']['type'].lower()
+aggregate = adhoc_metric['aggregate'].lower()
+
+if aggregate == 'count':
return 'count'
-if (aggregate == 'count_distinct'):
+if aggregate == 'count_distinct':
return 'cardinality'
else:
return column_type + aggregate.capitalize()
@@ -1132,6 +1138,17 @@ def run_query( # noqa / druid
metrics_dict = {m.metric_name: m for m in self.metrics}
columns_dict = {c.column_name: c for c in self.columns}
+if (
+self.cluster and
+LooseVersion(self.cluster.get_druid_version()) <
LooseVersion('0.11.0')
+):
+for metric in metrics:
+if (
+utils.is_adhoc_metric(metric) and
+metric['column']['type'].upper() == 'FLOAT'
+):
+metric['column']['type'] = 'DOUBLE'
+
aggregations, post_aggs = DruidDatasource.metrics_and_post_aggs(
metrics,
metrics_dict)
@@ -1187,7 +1204,7 @@ def run_query( # noqa / druid
pre_qry = deepcopy(qry)
if timeseries_limit_metric:
order_by = timeseries_limit_metric
-aggs_dict, post_aggs_dict = self.metrics_and_post_aggs(
+aggs_dict, post_aggs_dict =
DruidDatasource.metrics_and_post_aggs(
[timeseries_limit_metric],
metrics_dict)
if phase == 1:
@@
[GitHub] mistercrunch commented on issue #5030: [Explore][AdhocMetrics] treating floats like doubles for druid versions lower than 11.0.0
mistercrunch commented on issue #5030: [Explore][AdhocMetrics] treating floats like doubles for druid versions lower than 11.0.0 URL: https://github.com/apache/incubator-superset/pull/5030#issuecomment-390747151 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] williaster commented on a change in pull request #4979: Dashboard save button
williaster commented on a change in pull request #4979: Dashboard save button
URL:
https://github.com/apache/incubator-superset/pull/4979#discussion_r189680390
##
File path: superset/assets/src/dashboard/components/SaveModal.jsx
##
@@ -138,15 +112,15 @@ class SaveModal extends React.PureComponent {
modalBody={
{t('Overwrite Dashboard [%s]', this.props.dashboardTitle)}
[GitHub] williaster commented on a change in pull request #4979: Dashboard save button
williaster commented on a change in pull request #4979: Dashboard save button
URL:
https://github.com/apache/incubator-superset/pull/4979#discussion_r189680285
##
File path: superset/assets/src/dashboard/components/SaveModal.jsx
##
@@ -138,15 +112,15 @@ class SaveModal extends React.PureComponent {
modalBody={
[GitHub] michellethomas commented on issue #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands
michellethomas commented on issue #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands URL: https://github.com/apache/incubator-superset/pull/5032#issuecomment-390728041 @GabeLoins a few questions but lgtm otherwise! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] michellethomas commented on a change in pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands
michellethomas commented on a change in pull request #5032: [Explore][Adhoc
Filters] Expanding the Adhoc Filter popover when the content expands
URL:
https://github.com/apache/incubator-superset/pull/5032#discussion_r189660899
##
File path: superset/assets/src/explore/components/AdhocFilterEditPopover.jsx
##
@@ -78,6 +79,13 @@ export default class AdhocFilterEditPopover extends
React.Component {
document.removeEventListener('mousemove', this.onMouseMove);
}
+ adjustHeight(heightDifference) {
+this.setState(state => ({
+ ...state,
+ height: state.height + heightDifference,
Review comment:
Just curious, is there a specific reason to add the height difference
instead of just strictly setting the new height?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] williaster commented on a change in pull request #4979: Dashboard save button
williaster commented on a change in pull request #4979: Dashboard save button
URL:
https://github.com/apache/incubator-superset/pull/4979#discussion_r189679344
##
File path: superset/assets/src/dashboard/components/Header.jsx
##
@@ -1,12 +1,18 @@
+/* eslint-env browser */
import React from 'react';
import PropTypes from 'prop-types';
-import { ButtonGroup, ButtonToolbar } from 'react-bootstrap';
+import {
+ DropdownButton,
+ MenuItem,
+ ButtonGroup,
+ ButtonToolbar,
+} from 'react-bootstrap';
import Controls from './Controls';
import EditableTitle from '../../components/EditableTitle';
import Button from '../../components/Button';
import FaveStar from '../../components/FaveStar';
-import SaveModal from './SaveModal';
+import SaveModal, { SAVE_TYPE_OVERWRITE } from './SaveModal';
Review comment:
I think `SAVE_TYPE_OVERWRITE ` should be moved into the dashboard constants
file, this defeats the purpose of having that file and centralizes all
constants.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] michellethomas commented on a change in pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands
michellethomas commented on a change in pull request #5032: [Explore][Adhoc
Filters] Expanding the Adhoc Filter popover when the content expands
URL:
https://github.com/apache/incubator-superset/pull/5032#discussion_r189660170
##
File path: superset/assets/src/explore/components/AdhocFilterEditPopover.jsx
##
@@ -78,6 +79,13 @@ export default class AdhocFilterEditPopover extends
React.Component {
document.removeEventListener('mousemove', this.onMouseMove);
}
+ adjustHeight(heightDifference) {
+this.setState(state => ({
+ ...state,
Review comment:
Do you need this? I thought you could just return the update to state.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] williaster commented on a change in pull request #4979: Dashboard save button
williaster commented on a change in pull request #4979: Dashboard save button
URL:
https://github.com/apache/incubator-superset/pull/4979#discussion_r189680024
##
File path: superset/assets/src/dashboard/components/Header.jsx
##
@@ -161,44 +197,63 @@ class Header extends React.PureComponent {
- {editMode ? t('Switch to View Mode') : t('Edit Dashboard')}
+ {editMode ? t('Switch to view mode') : t('Edit dashboard')}
) : (
+
+ {t('Save changes')}
+
+ )}
+
[GitHub] williaster commented on a change in pull request #4979: Dashboard save button
williaster commented on a change in pull request #4979: Dashboard save button
URL:
https://github.com/apache/incubator-superset/pull/4979#discussion_r189680138
##
File path: superset/assets/src/dashboard/components/SaveModal.jsx
##
@@ -59,37 +64,7 @@ class SaveModal extends React.PureComponent {
handleNameChange(event) {
this.setState({
newDashName: event.target.value,
- saveType: 'newDashboard',
Review comment:
thanks for moving this to the new file!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] williaster commented on a change in pull request #5031: Dashboard initial page load logging with tabs
williaster commented on a change in pull request #5031: Dashboard initial page
load logging with tabs
URL:
https://github.com/apache/incubator-superset/pull/5031#discussion_r189677504
##
File path: superset/assets/src/dashboard/util/layoutHelper.js
##
@@ -0,0 +1,42 @@
+import {
+ TABS_TYPE,
+ CHART_TYPE,
+} from './componentTypes';
+
+import {
+ DASHBOARD_ROOT_ID,
+} from './constants';
+
+export function getChartIdsFromLayout(layout) {
+ return Object.values(layout).reduce((chartIds, value) => {
+if (value && value.meta && value.meta.chartId) {
+ chartIds.push(value.meta.chartId);
+}
+return chartIds;
+ }, []);
+}
+
+export function findInitialPageLoadCharts(layout) {
+ if (!layout) {
+return [];
+ }
+
+ let chartIds = [];
+ function doTraverse(node) {
+const type = node.type;
Review comment:
object destructuring is preferred, I'll add a lint rule for this. `const {
type } = node;`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] williaster commented on a change in pull request #5031: Dashboard initial page load logging with tabs
williaster commented on a change in pull request #5031: Dashboard initial page
load logging with tabs
URL:
https://github.com/apache/incubator-superset/pull/5031#discussion_r189677298
##
File path: superset/assets/src/dashboard/util/layoutHelper.js
##
@@ -0,0 +1,42 @@
+import {
Review comment:
can you separate this into one function per file? "util files" can easily
become unreadable and way too long. I'd prefer more files over large ones.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] betodealmeida commented on a change in pull request #4981: Make time filter more usable
betodealmeida commented on a change in pull request #4981: Make time filter
more usable
URL:
https://github.com/apache/incubator-superset/pull/4981#discussion_r189730436
##
File path:
superset/assets/src/explore/components/controls/DateFilterControl.jsx
##
@@ -28,172 +51,265 @@ const propTypes = {
const defaultProps = {
animation: true,
onChange: () => {},
- value: '',
+ value: 'Last week',
};
+
export default class DateFilterControl extends React.Component {
constructor(props) {
super(props);
-const value = props.value || '';
+const value = props.value || defaultProps.value;
this.state = {
+ type: TYPES[0],
+
+ // for range
num: '7',
- grain: 'days',
- rel: 'ago',
- dttm: '',
- type: 'free',
- free: '',
+ grain: TIME_GRAIN_OPTIONS[3],
+ rel: RELATIVE_TIME_OPTIONS[0],
+ common: COMMON_TIME_FRAMES[0],
+
+ // for start:end(includes freeform)
+ since: DEFAULT_SINCE,
+ until: DEFAULT_UNTIL,
+ isFreeform: {},
};
-const words = value.split(' ');
-if (words.length >= 3 && RELATIVE_TIME_OPTIONS.indexOf(words[2]) >= 0) {
- this.state.num = words[0];
- this.state.grain = words[1];
- this.state.rel = words[2];
- this.state.type = 'rel';
-} else if (moment(value).isValid()) {
- this.state.dttm = value;
- this.state.type = 'fix';
+if (value.indexOf(SEPARATOR) >= 0) {
+ this.state.type = 'startend';
Review comment:
Good point, let me fix this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] betodealmeida commented on a change in pull request #4981: Make time filter more usable
betodealmeida commented on a change in pull request #4981: Make time filter
more usable
URL:
https://github.com/apache/incubator-superset/pull/4981#discussion_r189732530
##
File path:
superset/assets/src/explore/components/controls/DateFilterControl.jsx
##
@@ -1,20 +1,43 @@
import React from 'react';
import PropTypes from 'prop-types';
import {
- Button, ButtonGroup, FormControl, InputGroup,
- Label, OverlayTrigger, Popover, Glyphicon,
+ Button,
+ DropdownButton,
+ FormControl,
+ FormGroup,
+ InputGroup,
+ Label,
+ MenuItem,
+ OverlayTrigger,
+ Popover,
+ Radio,
+ Tab,
+ Tabs,
} from 'react-bootstrap';
-import Select from 'react-select';
-import Datetime from 'react-datetime';
import 'react-datetime/css/react-datetime.css';
+import DateTimeField from 'react-bootstrap-datetimepicker';
+import 'react-bootstrap-datetimepicker/css/bootstrap-datetimepicker.min.css';
import moment from 'moment';
import ControlHeader from '../ControlHeader';
-import PopoverSection from '../../../components/PopoverSection';
+import InfoTooltipWithTrigger from
'../../../components/InfoTooltipWithTrigger';
+import { t } from '../../../locales';
-const RELATIVE_TIME_OPTIONS = ['ago', 'from now'];
+const TYPES = ['range', 'startend'];
+const COMMON_TIME_FRAMES = ['Yesterday', 'Last week', 'Last month', 'Last
year'];
+const RELATIVE_TIME_OPTIONS = ['Last', 'Next'];
const TIME_GRAIN_OPTIONS = ['seconds', 'minutes', 'hours', 'days', 'weeks',
'months', 'years'];
+const MOMENT_FORMAT = '-MM-DD[T]HH:mm:ss';
+const DEFAULT_SINCE = moment().startOf('day').subtract(7,
'days').format(MOMENT_FORMAT);
+const DEFAULT_UNTIL = moment().startOf('day').format(MOMENT_FORMAT);
+const INVALID_DATE_MESSAGE = 'Invalid date';
+const SEPARATOR = ' : ';
+const FREEFORM_TOOLTIP = t(
+ 'Superset supports smart date parsing. Strings like `last sunday` or ' +
Review comment:
Yeah, without feedback informing if the input is valid this doesn't seem
very usable. We could do a backend call and show it in red if not supported?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] betodealmeida commented on a change in pull request #4981: Make time filter more usable
betodealmeida commented on a change in pull request #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#discussion_r189732362 ## File path: superset/assets/package.json ## @@ -88,6 +88,7 @@ "react-addons-shallow-compare": "^15.4.2", "react-alert": "^2.3.0", "react-bootstrap": "^0.31.5", +"react-bootstrap-datetimepicker": "0.0.22", Review comment: Let me take a look at how much effort is needed to use that one... I remember testing it when I was looking for calendar components, and it didn't work for some cases but TBH I don't remember the details. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] betodealmeida commented on a change in pull request #4981: Make time filter more usable
betodealmeida commented on a change in pull request #4981: Make time filter
more usable
URL:
https://github.com/apache/incubator-superset/pull/4981#discussion_r189734396
##
File path:
superset/assets/src/explore/components/controls/DateFilterControl.jsx
##
@@ -28,172 +51,265 @@ const propTypes = {
const defaultProps = {
animation: true,
onChange: () => {},
- value: '',
+ value: 'Last week',
};
+
export default class DateFilterControl extends React.Component {
constructor(props) {
super(props);
-const value = props.value || '';
+const value = props.value || defaultProps.value;
this.state = {
+ type: TYPES[0],
+
+ // for range
num: '7',
- grain: 'days',
- rel: 'ago',
- dttm: '',
- type: 'free',
- free: '',
+ grain: TIME_GRAIN_OPTIONS[3],
+ rel: RELATIVE_TIME_OPTIONS[0],
+ common: COMMON_TIME_FRAMES[0],
+
+ // for start:end(includes freeform)
+ since: DEFAULT_SINCE,
+ until: DEFAULT_UNTIL,
+ isFreeform: {},
};
-const words = value.split(' ');
-if (words.length >= 3 && RELATIVE_TIME_OPTIONS.indexOf(words[2]) >= 0) {
- this.state.num = words[0];
- this.state.grain = words[1];
- this.state.rel = words[2];
- this.state.type = 'rel';
-} else if (moment(value).isValid()) {
- this.state.dttm = value;
- this.state.type = 'fix';
+if (value.indexOf(SEPARATOR) >= 0) {
+ this.state.type = 'startend';
+ [this.state.since, this.state.until] = value.split(SEPARATOR, 2);
} else {
- this.state.free = value;
- this.state.type = 'free';
+ this.state.type = 'range';
+ if (COMMON_TIME_FRAMES.indexOf(value) >= 0) {
+this.state.common = value;
+ } else {
+this.state.common = null;
+[this.state.rel, this.state.num, this.state.grain] = value.split(' ',
3);
+ }
}
+this.state.isFreeform.since = !moment(this.state.since,
MOMENT_FORMAT).isValid();
+this.state.isFreeform.until = !moment(this.state.until,
MOMENT_FORMAT).isValid();
+
+// We need direct access to the state of the `DateTimeField` component
+this.dateTimeFieldRefs = {};
}
- onControlChange(target, opt) {
-this.setState({ [target]: opt.value });
- }
- onNumberChange(event) {
-this.setState({ num: event.target.value });
+ onEnter(event) {
+if (event.key === 'Enter') {
+ this.close();
+}
}
- onFreeChange(event) {
-this.setState({ free: event.target.value });
+ setStartEnd(key, value) {
+const nextState = {
+ type: 'startend',
+ isFreeform: { ...this.state.isFreeform },
+};
+if (value === INVALID_DATE_MESSAGE) {
+ // the DateTimeField component will return `Invalid date` for freeform
+ // text, so we need to cheat and steal the value from the state
+ const freeformValue = this.dateTimeFieldRefs[key].state.inputValue;
+ nextState.isFreeform[key] = true;
+ nextState[key] = freeformValue;
+} else {
+ nextState.isFreeform[key] = false;
+ nextState[key] = value;
+}
+this.setState(nextState, this.updateRefs);
}
- setType(type) {
-this.setState({ type });
+ setCommonRange(timeFrame) {
+const nextState = {
+ type: 'range',
+ common: timeFrame,
+ until: moment().startOf('day').format(MOMENT_FORMAT),
+};
+let units;
+if (timeFrame === 'Yesterday') {
+ units = 'days';
+} else {
+ units = timeFrame.split(' ')[1] + 's';
+}
+nextState.since = moment().startOf('day').subtract(1,
units).format(MOMENT_FORMAT);
+this.setState(nextState, this.updateRefs);
}
- setValueAndClose(val) {
-this.setState({ type: 'free', free: val }, this.close);
+ setCustomRange(key, value) {
+const nextState = { ...this.state, type: 'range', common: null };
+if (key !== undefined && value !== undefined) {
+ nextState[key] = value;
+}
+if (nextState.rel === 'Last') {
+ nextState.until = moment().startOf('day').format(MOMENT_FORMAT);
+ nextState.since = moment()
+.startOf('day')
+.subtract(nextState.num, nextState.grain)
+.format(MOMENT_FORMAT);
+} else {
+ nextState.until = moment()
+.startOf('day')
+.add(nextState.num, nextState.grain)
+.format(MOMENT_FORMAT);
+ nextState.since = moment().startOf('day').format(MOMENT_FORMAT);
+}
+this.setState(nextState, this.updateRefs);
}
- setDatetime(dttm) {
-this.setState({ dttm: dttm.format().substring(0, 19) });
+ updateRefs() {
Review comment:
This is needed for freeform text. The calendar component uses `moment` to
parse the string, and if it fails the state is not set. This prevents us from
initializing the component saved with freeform values.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[GitHub] betodealmeida commented on a change in pull request #4981: Make time filter more usable
betodealmeida commented on a change in pull request #4981: Make time filter
more usable
URL:
https://github.com/apache/incubator-superset/pull/4981#discussion_r189734505
##
File path:
superset/assets/src/explore/components/controls/DateFilterControl.jsx
##
@@ -28,172 +51,265 @@ const propTypes = {
const defaultProps = {
animation: true,
onChange: () => {},
- value: '',
+ value: 'Last week',
};
+
export default class DateFilterControl extends React.Component {
constructor(props) {
super(props);
-const value = props.value || '';
+const value = props.value || defaultProps.value;
this.state = {
+ type: TYPES[0],
+
+ // for range
num: '7',
- grain: 'days',
- rel: 'ago',
- dttm: '',
- type: 'free',
- free: '',
+ grain: TIME_GRAIN_OPTIONS[3],
+ rel: RELATIVE_TIME_OPTIONS[0],
+ common: COMMON_TIME_FRAMES[0],
+
+ // for start:end(includes freeform)
+ since: DEFAULT_SINCE,
+ until: DEFAULT_UNTIL,
+ isFreeform: {},
};
-const words = value.split(' ');
-if (words.length >= 3 && RELATIVE_TIME_OPTIONS.indexOf(words[2]) >= 0) {
- this.state.num = words[0];
- this.state.grain = words[1];
- this.state.rel = words[2];
- this.state.type = 'rel';
-} else if (moment(value).isValid()) {
- this.state.dttm = value;
- this.state.type = 'fix';
+if (value.indexOf(SEPARATOR) >= 0) {
+ this.state.type = 'startend';
+ [this.state.since, this.state.until] = value.split(SEPARATOR, 2);
} else {
- this.state.free = value;
- this.state.type = 'free';
+ this.state.type = 'range';
+ if (COMMON_TIME_FRAMES.indexOf(value) >= 0) {
+this.state.common = value;
+ } else {
+this.state.common = null;
+[this.state.rel, this.state.num, this.state.grain] = value.split(' ',
3);
+ }
}
+this.state.isFreeform.since = !moment(this.state.since,
MOMENT_FORMAT).isValid();
+this.state.isFreeform.until = !moment(this.state.until,
MOMENT_FORMAT).isValid();
+
+// We need direct access to the state of the `DateTimeField` component
+this.dateTimeFieldRefs = {};
}
- onControlChange(target, opt) {
-this.setState({ [target]: opt.value });
- }
- onNumberChange(event) {
-this.setState({ num: event.target.value });
+ onEnter(event) {
+if (event.key === 'Enter') {
+ this.close();
+}
}
- onFreeChange(event) {
-this.setState({ free: event.target.value });
+ setStartEnd(key, value) {
+const nextState = {
+ type: 'startend',
+ isFreeform: { ...this.state.isFreeform },
+};
+if (value === INVALID_DATE_MESSAGE) {
+ // the DateTimeField component will return `Invalid date` for freeform
+ // text, so we need to cheat and steal the value from the state
+ const freeformValue = this.dateTimeFieldRefs[key].state.inputValue;
+ nextState.isFreeform[key] = true;
+ nextState[key] = freeformValue;
+} else {
+ nextState.isFreeform[key] = false;
+ nextState[key] = value;
+}
+this.setState(nextState, this.updateRefs);
}
- setType(type) {
-this.setState({ type });
+ setCommonRange(timeFrame) {
+const nextState = {
+ type: 'range',
+ common: timeFrame,
+ until: moment().startOf('day').format(MOMENT_FORMAT),
+};
+let units;
+if (timeFrame === 'Yesterday') {
+ units = 'days';
+} else {
+ units = timeFrame.split(' ')[1] + 's';
+}
+nextState.since = moment().startOf('day').subtract(1,
units).format(MOMENT_FORMAT);
+this.setState(nextState, this.updateRefs);
}
- setValueAndClose(val) {
-this.setState({ type: 'free', free: val }, this.close);
+ setCustomRange(key, value) {
+const nextState = { ...this.state, type: 'range', common: null };
+if (key !== undefined && value !== undefined) {
+ nextState[key] = value;
+}
+if (nextState.rel === 'Last') {
+ nextState.until = moment().startOf('day').format(MOMENT_FORMAT);
+ nextState.since = moment()
+.startOf('day')
+.subtract(nextState.num, nextState.grain)
+.format(MOMENT_FORMAT);
+} else {
+ nextState.until = moment()
+.startOf('day')
+.add(nextState.num, nextState.grain)
+.format(MOMENT_FORMAT);
+ nextState.since = moment().startOf('day').format(MOMENT_FORMAT);
+}
+this.setState(nextState, this.updateRefs);
}
- setDatetime(dttm) {
-this.setState({ dttm: dttm.format().substring(0, 19) });
+ updateRefs() {
+this.dateTimeFieldRefs.since.setState({ inputValue: this.state.since });
+this.dateTimeFieldRefs.until.setState({ inputValue: this.state.until });
}
close() {
let val;
-if (this.state.type === 'rel') {
- val = `${this.state.num} ${this.state.grain} ${this.state.rel}`;
-} else if (this.state.type === 'fix') {
- val = this.state.dttm;
-} else if
[GitHub] GabeLoins commented on a change in pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands
GabeLoins commented on a change in pull request #5032: [Explore][Adhoc Filters]
Expanding the Adhoc Filter popover when the content expands
URL:
https://github.com/apache/incubator-superset/pull/5032#discussion_r189705621
##
File path: superset/assets/src/explore/components/AdhocFilterEditPopover.jsx
##
@@ -78,6 +79,13 @@ export default class AdhocFilterEditPopover extends
React.Component {
document.removeEventListener('mousemove', this.onMouseMove);
}
+ adjustHeight(heightDifference) {
+this.setState(state => ({
+ ...state,
Review comment:
good call fixing now
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] zkenstein commented on issue #5041: Permission to enable / disable CSV export on chart / slice
zkenstein commented on issue #5041: Permission to enable / disable CSV export
on chart / slice
URL:
https://github.com/apache/incubator-superset/issues/5041#issuecomment-390777583
I think on this line CSV_EXPORT = {
'encoding': 'utf-8',
}
around line 197?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands
codecov-io commented on issue #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands URL: https://github.com/apache/incubator-superset/pull/5032#issuecomment-390067823 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5032?src=pr=h1) Report > Merging [#5032](https://codecov.io/gh/apache/incubator-superset/pull/5032?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ce0011e5fcacf8510142353df6c3cf530c04b1c2?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/5032?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5032 +/- ## === Coverage 77.35% 77.35% === Files 44 44 Lines8677 8677 === Hits 6712 6712 Misses 1965 1965 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5032?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5032?src=pr=footer). Last update [ce0011e...d68c718](https://codecov.io/gh/apache/incubator-superset/pull/5032?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message
graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message URL: https://github.com/apache/incubator-superset/pull/4900#issuecomment-390806736 @jasnovak In Superset build-in [roles](https://superset.apache.org/security.html#provided-roles): both Alpha user and Gamma user can save dashboard, and can save other owner's dashboard as their copy. [There are tests to assure this feature](https://github.com/apache/incubator-superset/blob/7f1d7543d05cedf5b5725b6da81943bd551ccc87/tests/security_tests.py#L48). We have a lot of users want to copy other's dashboard, but not change the original one. But with this PR, all Alpha and Gamma users can't save copy anymore. I want to make some changes that still allow Alpha+Gamma users `save dashboard as copy`. For the users in your system that don't have save access, are they any of build-in roles, or any role that removes can_save_dash? thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression
michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-390806412 @mistercrunch added tests, thanks for the suggestion! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] ibnjay opened a new issue #5050: self registration issue with LDAP
ibnjay opened a new issue #5050: self registration issue with LDAP URL: https://github.com/apache/incubator-superset/issues/5050 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included it here as text if any - [ ] I have reproduced the issue with at least the latest released version of superset - [ ] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version 0.24 ### Expected results Users signs in using their LDAP credential. If the user doesn't exists it is created.They are assigned a public role. ### Actual results A few users are not able to self register. When i create the user manually. They are able to login. ### Steps to reproduce None / need help. Need help understanding how to reproduce. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on a change in pull request #4981: Make time filter more usable
mistercrunch commented on a change in pull request #4981: Make time filter more
usable
URL:
https://github.com/apache/incubator-superset/pull/4981#discussion_r189731791
##
File path:
superset/assets/src/explore/components/controls/DateFilterControl.jsx
##
@@ -1,20 +1,43 @@
import React from 'react';
import PropTypes from 'prop-types';
import {
- Button, ButtonGroup, FormControl, InputGroup,
- Label, OverlayTrigger, Popover, Glyphicon,
+ Button,
+ DropdownButton,
+ FormControl,
+ FormGroup,
+ InputGroup,
+ Label,
+ MenuItem,
+ OverlayTrigger,
+ Popover,
+ Radio,
+ Tab,
+ Tabs,
} from 'react-bootstrap';
-import Select from 'react-select';
-import Datetime from 'react-datetime';
import 'react-datetime/css/react-datetime.css';
+import DateTimeField from 'react-bootstrap-datetimepicker';
+import 'react-bootstrap-datetimepicker/css/bootstrap-datetimepicker.min.css';
import moment from 'moment';
import ControlHeader from '../ControlHeader';
-import PopoverSection from '../../../components/PopoverSection';
+import InfoTooltipWithTrigger from
'../../../components/InfoTooltipWithTrigger';
+import { t } from '../../../locales';
-const RELATIVE_TIME_OPTIONS = ['ago', 'from now'];
+const TYPES = ['range', 'startend'];
+const COMMON_TIME_FRAMES = ['Yesterday', 'Last week', 'Last month', 'Last
year'];
+const RELATIVE_TIME_OPTIONS = ['Last', 'Next'];
const TIME_GRAIN_OPTIONS = ['seconds', 'minutes', 'hours', 'days', 'weeks',
'months', 'years'];
+const MOMENT_FORMAT = '-MM-DD[T]HH:mm:ss';
+const DEFAULT_SINCE = moment().startOf('day').subtract(7,
'days').format(MOMENT_FORMAT);
+const DEFAULT_UNTIL = moment().startOf('day').format(MOMENT_FORMAT);
+const INVALID_DATE_MESSAGE = 'Invalid date';
+const SEPARATOR = ' : ';
+const FREEFORM_TOOLTIP = t(
+ 'Superset supports smart date parsing. Strings like `last sunday` or ' +
Review comment:
Even if we decided we're better off without it, it'd be hard to deprecate
(would break charts).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] TianyangLi commented on issue #5041: Permission to enable / disable CSV export on chart / slice
TianyangLi commented on issue #5041: Permission to enable / disable CSV export on chart / slice URL: https://github.com/apache/incubator-superset/issues/5041#issuecomment-390781564 @miloradkrstevski @zkenstein Close, but i think its jus a matter of commenting out the following:  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] betodealmeida commented on a change in pull request #4981: Make time filter more usable
betodealmeida commented on a change in pull request #4981: Make time filter
more usable
URL:
https://github.com/apache/incubator-superset/pull/4981#discussion_r189731834
##
File path:
superset/assets/src/explore/components/controls/DateFilterControl.jsx
##
@@ -28,172 +51,265 @@ const propTypes = {
const defaultProps = {
animation: true,
onChange: () => {},
- value: '',
+ value: 'Last week',
};
+
export default class DateFilterControl extends React.Component {
constructor(props) {
super(props);
-const value = props.value || '';
+const value = props.value || defaultProps.value;
this.state = {
+ type: TYPES[0],
+
+ // for range
num: '7',
- grain: 'days',
- rel: 'ago',
- dttm: '',
- type: 'free',
- free: '',
+ grain: TIME_GRAIN_OPTIONS[3],
+ rel: RELATIVE_TIME_OPTIONS[0],
+ common: COMMON_TIME_FRAMES[0],
+
+ // for start:end(includes freeform)
+ since: DEFAULT_SINCE,
+ until: DEFAULT_UNTIL,
+ isFreeform: {},
Review comment:
What if we initialize it as:
```js
isFreeform: { since: false, until: false }
```
I can also rename it to `freeformFields`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] betodealmeida commented on a change in pull request #4981: Make time filter more usable
betodealmeida commented on a change in pull request #4981: Make time filter
more usable
URL:
https://github.com/apache/incubator-superset/pull/4981#discussion_r189733719
##
File path:
superset/assets/src/explore/components/controls/DateFilterControl.jsx
##
@@ -28,172 +51,265 @@ const propTypes = {
const defaultProps = {
animation: true,
onChange: () => {},
- value: '',
+ value: 'Last week',
};
+
export default class DateFilterControl extends React.Component {
constructor(props) {
super(props);
-const value = props.value || '';
+const value = props.value || defaultProps.value;
this.state = {
+ type: TYPES[0],
+
+ // for range
num: '7',
- grain: 'days',
- rel: 'ago',
- dttm: '',
- type: 'free',
- free: '',
+ grain: TIME_GRAIN_OPTIONS[3],
+ rel: RELATIVE_TIME_OPTIONS[0],
+ common: COMMON_TIME_FRAMES[0],
+
+ // for start:end(includes freeform)
+ since: DEFAULT_SINCE,
+ until: DEFAULT_UNTIL,
+ isFreeform: {},
};
-const words = value.split(' ');
-if (words.length >= 3 && RELATIVE_TIME_OPTIONS.indexOf(words[2]) >= 0) {
- this.state.num = words[0];
- this.state.grain = words[1];
- this.state.rel = words[2];
- this.state.type = 'rel';
-} else if (moment(value).isValid()) {
- this.state.dttm = value;
- this.state.type = 'fix';
+if (value.indexOf(SEPARATOR) >= 0) {
+ this.state.type = 'startend';
+ [this.state.since, this.state.until] = value.split(SEPARATOR, 2);
} else {
- this.state.free = value;
- this.state.type = 'free';
+ this.state.type = 'range';
+ if (COMMON_TIME_FRAMES.indexOf(value) >= 0) {
+this.state.common = value;
+ } else {
+this.state.common = null;
+[this.state.rel, this.state.num, this.state.grain] = value.split(' ',
3);
+ }
}
+this.state.isFreeform.since = !moment(this.state.since,
MOMENT_FORMAT).isValid();
+this.state.isFreeform.until = !moment(this.state.until,
MOMENT_FORMAT).isValid();
+
+// We need direct access to the state of the `DateTimeField` component
+this.dateTimeFieldRefs = {};
}
- onControlChange(target, opt) {
-this.setState({ [target]: opt.value });
- }
- onNumberChange(event) {
-this.setState({ num: event.target.value });
+ onEnter(event) {
+if (event.key === 'Enter') {
+ this.close();
+}
}
- onFreeChange(event) {
-this.setState({ free: event.target.value });
+ setStartEnd(key, value) {
+const nextState = {
+ type: 'startend',
+ isFreeform: { ...this.state.isFreeform },
+};
+if (value === INVALID_DATE_MESSAGE) {
+ // the DateTimeField component will return `Invalid date` for freeform
+ // text, so we need to cheat and steal the value from the state
+ const freeformValue = this.dateTimeFieldRefs[key].state.inputValue;
+ nextState.isFreeform[key] = true;
+ nextState[key] = freeformValue;
+} else {
+ nextState.isFreeform[key] = false;
+ nextState[key] = value;
+}
+this.setState(nextState, this.updateRefs);
}
- setType(type) {
-this.setState({ type });
+ setCommonRange(timeFrame) {
+const nextState = {
+ type: 'range',
+ common: timeFrame,
+ until: moment().startOf('day').format(MOMENT_FORMAT),
+};
+let units;
+if (timeFrame === 'Yesterday') {
+ units = 'days';
+} else {
+ units = timeFrame.split(' ')[1] + 's';
+}
+nextState.since = moment().startOf('day').subtract(1,
units).format(MOMENT_FORMAT);
+this.setState(nextState, this.updateRefs);
}
- setValueAndClose(val) {
-this.setState({ type: 'free', free: val }, this.close);
+ setCustomRange(key, value) {
+const nextState = { ...this.state, type: 'range', common: null };
+if (key !== undefined && value !== undefined) {
+ nextState[key] = value;
+}
+if (nextState.rel === 'Last') {
+ nextState.until = moment().startOf('day').format(MOMENT_FORMAT);
+ nextState.since = moment()
+.startOf('day')
+.subtract(nextState.num, nextState.grain)
+.format(MOMENT_FORMAT);
+} else {
+ nextState.until = moment()
+.startOf('day')
+.add(nextState.num, nextState.grain)
+.format(MOMENT_FORMAT);
+ nextState.since = moment().startOf('day').format(MOMENT_FORMAT);
+}
+this.setState(nextState, this.updateRefs);
}
- setDatetime(dttm) {
-this.setState({ dttm: dttm.format().substring(0, 19) });
+ updateRefs() {
+this.dateTimeFieldRefs.since.setState({ inputValue: this.state.since });
+this.dateTimeFieldRefs.until.setState({ inputValue: this.state.until });
}
close() {
let val;
-if (this.state.type === 'rel') {
- val = `${this.state.num} ${this.state.grain} ${this.state.rel}`;
-} else if (this.state.type === 'fix') {
- val = this.state.dttm;
-} else if
[GitHub] codecov-io commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression
codecov-io commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389692391 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=h1) Report > Merging [#5021](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ce0011e5fcacf8510142353df6c3cf530c04b1c2?src=pr=desc) will **increase** coverage by `0.1%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=tree) ```diff @@Coverage Diff@@ ## master#5021 +/- ## = + Coverage 77.35% 77.46% +0.1% = Files 44 44 Lines8677 8683 +6 = + Hits 6712 6726 +14 + Misses 1965 1957 -8 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5021/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `78.22% <100%> (+1.8%)` | :arrow_up: | | [superset/data/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/5021/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YS9fX2luaXRfXy5weQ==) | `100% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=footer). Last update [ce0011e...f1db6f9](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression
codecov-io commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389692391 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=h1) Report > Merging [#5021](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ce0011e5fcacf8510142353df6c3cf530c04b1c2?src=pr=desc) will **increase** coverage by `0.1%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=tree) ```diff @@Coverage Diff@@ ## master#5021 +/- ## = + Coverage 77.35% 77.46% +0.1% = Files 44 44 Lines8677 8683 +6 = + Hits 6712 6726 +14 + Misses 1965 1957 -8 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/data/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/5021/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YS9fX2luaXRfXy5weQ==) | `100% <100%> (ø)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5021/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `78.22% <100%> (+1.8%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=footer). Last update [ce0011e...f1db6f9](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression
codecov-io commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389692391 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=h1) Report > Merging [#5021](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ce0011e5fcacf8510142353df6c3cf530c04b1c2?src=pr=desc) will **increase** coverage by `0.1%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=tree) ```diff @@Coverage Diff@@ ## master#5021 +/- ## = + Coverage 77.35% 77.46% +0.1% = Files 44 44 Lines8677 8683 +6 = + Hits 6712 6726 +14 + Misses 1965 1957 -8 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5021/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `78.22% <100%> (+1.8%)` | :arrow_up: | | [superset/data/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/5021/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YS9fX2luaXRfXy5weQ==) | `100% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=footer). Last update [ce0011e...f1db6f9](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] qin4zhang opened a new issue #5053: Database Permission for version 0.22.1
qin4zhang opened a new issue #5053: Database Permission for version 0.22.1 URL: https://github.com/apache/incubator-superset/issues/5053 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included it here as text if any - [ ] I have reproduced the issue with at least the latest released version of superset - [ ] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version 0.22.1 ### Expected results Granting access to a database allows for the user to access all data sources within that database, and will enable the user to query that database in SQL Lab, provided that the SQL Lab specific permission have been granted to the user ### Actual results Adding a new db(postgres),I can't grant database access on [dbname] to user for a new role. But I can grant **schema** access on [dbname].[schema]. I can't get access all data sources within database. ### Steps to reproduce 1. Adding a new db. 2. Adding a new role. 3. Editing the role to grant access. 4. Common user with Gamma and the new role with access on db(actually schema). 5. There is nothing for datasources as a common user. How could I grant access database to the role？ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] yuhai1023 commented on issue #347: Feature: Drill down
yuhai1023 commented on issue #347: Feature: Drill down URL: https://github.com/apache/incubator-superset/issues/347#issuecomment-390942451 +1 we need it too This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #4981: Make time filter more usable
codecov-io commented on issue #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#issuecomment-388507979 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4981?src=pr=h1) Report > Merging [#4981](https://codecov.io/gh/apache/incubator-superset/pull/4981?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b75942daa51014d49b707f7b5d7fe792b46b56c6?src=pr=desc) will **decrease** coverage by `0.14%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4981?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4981 +/- ## == - Coverage77.1% 76.96% -0.15% == Files 44 44 Lines8636 8708 +72 == + Hits 6659 6702 +43 - Misses 1977 2006 +29 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4981?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4981/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `88.93% <100%> (+1.02%)` | :arrow_up: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4981/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.9% <100%> (+0.24%)` | :arrow_up: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4981/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `78.22% <100%> (-2.07%)` | :arrow_down: | | [superset/legacy.py](https://codecov.io/gh/apache/incubator-superset/pull/4981/diff?src=pr=tree#diff-c3VwZXJzZXQvbGVnYWN5LnB5) | `18.3% <100%> (+3.6%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4981/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `76.21% <0%> (-0.21%)` | :arrow_down: | | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/4981/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `98.79% <0%> (-0.06%)` | :arrow_down: | | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/4981/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `70.47% <0%> (ø)` | :arrow_up: | | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4981/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `80.53% <0%> (+0.04%)` | :arrow_up: | | ... and [5 more](https://codecov.io/gh/apache/incubator-superset/pull/4981/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4981?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4981?src=pr=footer). Last update [b75942d...80e9c62](https://codecov.io/gh/apache/incubator-superset/pull/4981?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
