D10516: Update status to NeedsAttention when there is a menu

[Martin Kostolný]

martinkostolny accepted this revision.
martinkostolny added a comment.


  thanks!

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10522: Added vertical separator

[Marijo Mustac]

mmustac added a comment.


  I liked Breeze because of its light and easy concept, get rid of too many 
lines, keep only the ones which make sense or are totally necessary, this 
feeling gets lost here for me so that Breeze would slowly increase into a Storm 
(little overstated I know) Even when this change should happen, I would vote 
for an opt-in feature so that the default keeps clean.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10522

To: anemeth, ngraham, hpereiradacosta, #breeze, #vdg
Cc: mmustac, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10522: Added vertical separator

[Nathaniel Graham]

ngraham added a comment.


  Don't worry Hugo, I don't think we're going to turn Breeze into a mutant that 
you don't recognize. :) This change doesn't seem very popular, and if it's 
necessary to make a previous change work, that calls into question whether that 
was the right change.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10522

To: anemeth, ngraham, hpereiradacosta, #breeze, #vdg
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10522: Added vertical separator

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Ok. This time I am strongly against this change. 
  This vertical line serves no purpose, clutters the ui, and is not "simple by 
default".
  Why would one need to separate the checkbox from the icon and text to which 
it is directly related to.
  Also see how it breaks with separator and item selection.
  To me it is a no go.
  (Note that I am not happy with any on the later community accepted commits to 
breeze either: blur serves no purpose either, nor the extra space allocated for 
checkboxes, etc.)
  If people insist on this getting committed, I will oblige, and resign from 
maintaining breeze at the same time, for the reason that it is going in a 
direction which I do not like. I cannot maintain a code which renders to 
something I do not like (nor understand). 
  Sorry
  
  Hugo

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10522

To: anemeth, ngraham, hpereiradacosta, #breeze, #vdg
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10524: Improve ToolBarApplicationHeader left padding and eliding behavior

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10524

To: ngraham, #kirigami, apol
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10527: Improve "show more reviews" string and logic

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10527

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10527: Improve "show more reviews" string and logic

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Discover Software Store, apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Use slightly more natural text for the "show more reviews" button.
  
  Also fix the bug where the "show more reviews" text would be absent if 
`rating` was null, which triggered logic that set the number of reviews to be 
0. This didn't seem to be adding anything, so I removed it and everything still 
seems to work fine.

TEST PLAN
  Browsed a ton of apps. All appeared as expected, including apps like OpenScad 
that were previously affected by the above bug.

REPOSITORY
  R134 Discover Software Store

BRANCH
  better-more-reviews-string (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10527

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10525: Only let the user write the first review if they've actually installed the app

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10525

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10525: Only let the user write the first review if they've actually installed the app

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Discover Software Store, apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Previously, you could write the first review for an app even if you didn't 
have it installed. No longer, with this patch!

REPOSITORY
  R134 Discover Software Store

BRANCH
  dont-write-first-review-unless-app-is-installed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10525

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10524: Improve ToolBarApplicationHeader left padding and eliding behavior

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10524

To: ngraham, #kirigami, apol
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10524: Improve ToolBarApplicationHeader left padding and eliding behavior

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Kirigami, apol.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  If the header text is going to be left aligned, we'd better give it some left 
padding so it looks all right. Also fix eliding, which did not work at all 
before because no width value was set.

TEST PLAN
  Discover Featured page, before:
  
  Discover Featured page, after:
  
  Discover Flathub page, before:
  
  Discover Flathub page, after:

REPOSITORY
  R169 Kirigami

BRANCH
  header-polish (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10524

AFFECTED FILES
  src/controls/ToolBarApplicationHeader.qml

To: ngraham, #kirigami, apol
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10523: Fix warnings

[Nathaniel Graham]

ngraham added a comment.


  Much better! I still get a few warnings though:
  

file:///usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/kirigami.2/ToolBarApplicationHeader.qml:49:
 TypeError: Cannot read property of null

file:///usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/kirigami.2/ToolBarApplicationHeader.qml:48:
 TypeError: Cannot read property of null

file:///usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/kirigami.2/templates/OverlaySheet.qml:244:9:
 QML NumberAnimation: Binding loop detected for property "topOpenPosition"

file:///usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/kirigami.2/templates/OverlaySheet.qml:406:9:
 QML Binding: Binding loop detected for property "value"

file:///usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/kirigami.2/templates/OverlaySheet.qml:406:9:
 QML Binding: Binding loop detected for property "value"

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10523

To: apol, #kirigami
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D10523: Fix warnings

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Kirigami.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Make sure the page header is destroyed with the page itself
  Don't duplicate logic to fetch the lastItem from the pageStack
  Make sure we are not calling null items

TEST PLAN
  manual testing on discover and kirgami gallery

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10523

AFFECTED FILES
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/OverlayDrawer.qml
  src/controls/templates/OverlaySheet.qml

To: apol, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10522: Added vertical separator

[Christoph Feck]

cfeck added a comment.


  When I had designed the menus for the Skulpture style, I opted for  not using 
a separate column for checkboxes, but indent the items that use them. The 
separate column was used for icons, though. See 
http://skulpture.maxiom.de/images/skulpture-sample-2.png

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10522

To: anemeth, ngraham, hpereiradacosta, #breeze, #vdg
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10500: Make the review pop-up a bit more user-friendly

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10500

To: ngraham, #discover_software_store
Cc: anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10500: Make the review pop-up a bit more user-friendly

[Nathaniel Graham]

ngraham updated this revision to Diff 27203.
ngraham added a comment.


  - Merge branch 'master' into review-popup-button-text
  - Also fix 390426

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10500?vs=27131=27203

BRANCH
  review-popup-button-text

REVISION DETAIL
  https://phabricator.kde.org/D10500

AFFECTED FILES
  discover/qml/Rating.qml
  discover/qml/ReviewDialog.qml

To: ngraham, #discover_software_store
Cc: anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10522: Added vertical separator

[Alex Nemeth]

anemeth added a comment.


  The best looking solution would be that menu entries that have 
checkbox/radiobutton, do not get an icon and then we can show the icon and the 
checkbox/radiobutton on the left column.
  Like you see in the Windows 7 pic in the test plan.
  Or maybe I'm just used to that look and I'm biased... :)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10522

To: anemeth, ngraham, hpereiradacosta, #breeze, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10500: Make the review pop-up a bit more user-friendly

[Nathaniel Graham]

ngraham planned changes to this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10500

To: ngraham, #discover_software_store
Cc: anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10522: Added vertical separator

[Alex Nemeth]

anemeth updated this revision to Diff 27202.
anemeth added a comment.


  Reduced the width of the horizontal line so it doesn't intersect with the 
vertical line.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10522?vs=27201=27202

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10522

AFFECTED FILES
  kstyle/breezestyle.cpp

To: anemeth, ngraham, hpereiradacosta, #breeze, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10507: Turn code.js into a singleton

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10507

To: broulik, #plasma, hein, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10522: Added vertical separator

[Nathaniel Graham]

ngraham added a comment.


  Reminds me of Windows. I think I could get used to the vertical line, but I 
don't like how the horizontal lines intersect with it. Makes the menu look like 
a grid.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10522

To: anemeth, ngraham, hpereiradacosta, #breeze, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10522: Added vertical separator

[Alex Nemeth]

anemeth edited the summary of this revision.
anemeth edited the test plan for this revision.
anemeth added reviewers: ngraham, hpereiradacosta, Breeze, VDG.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10522

To: anemeth, ngraham, hpereiradacosta, #breeze, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10522: Added vertical separator

[Alex Nemeth]

anemeth created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
anemeth requested review of this revision.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10522

AFFECTED FILES
  kstyle/breezestyle.cpp

To: anemeth
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10471: Use Kirgami.ToolBarApplicationHeader instead of the view headers

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:d435e886d56d: Use Kirgami.ToolBarApplicationHeader 
instead of the view headers (authored by apol).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10471?vs=27080=27200

REVISION DETAIL
  https://phabricator.kde.org/D10471

AFFECTED FILES
  discover/qml/ApplicationPage.qml
  discover/qml/ApplicationsListPage.qml
  discover/qml/BrowsingPage.qml
  discover/qml/DiscoverWindow.qml
  discover/qml/InstallApplicationButton.qml
  discover/qml/InstalledPage.qml
  discover/qml/KirigamiActionBridge.qml
  discover/qml/SearchPage.qml
  discover/qml/SourcesPage.qml
  discover/resources.qrc

To: apol, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10521: Accidental diff. Sorry.

[Alex Nemeth]

anemeth removed R31 Breeze as the repository for this revision.
anemeth removed a project: Plasma.
anemeth removed a subscriber: plasma-devel.

REVISION DETAIL
  https://phabricator.kde.org/D10521

To: anemeth
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10521: Accidental diff. Sorry.

[Alex Nemeth]

anemeth retitled this revision from "Added vertical separator" to "Accidental 
diff. Sorry.".

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10521

To: anemeth
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10521: Accidental diff. Sorry.

[Alex Nemeth]

anemeth abandoned this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10521

To: anemeth
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10521: Added vertical separator

[Alex Nemeth]

anemeth created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
anemeth requested review of this revision.

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10521

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezeblurhelper.cpp
  kstyle/breezeblurhelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: anemeth
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10498: Workaround the touchpad toggle button not working

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10498

To: aacid, davidedmundson, xuetianweng
Cc: knambiar, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Michail Vourlakos]

mvourlakos added a comment.


  In D10516#206458 , @broulik wrote:
  
  > Oh, sorry, I assumed from the name of the files it was plasma-workspace :) 
lgtm!
  
  
  :) if this is accepted, then I will try to send a fix for plasma menu also 
afterwards...

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag updated this revision to Diff 27190.
zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  rebase on master

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9638?vs=26788=27190

BRANCH
  effects/slide

REVISION DETAIL
  https://phabricator.kde.org/D9638

AFFECTED FILES
  effects/effect_builtins.cpp
  effects/slide/slide.cpp
  effects/slide/slide.h
  effects/slide/slide.kcfg
  effects/slide/slide_config.cpp
  effects/slide/slide_config.h
  effects/slide/slide_config.ui

To: zzag, #vdg, #kwin, #plasma, graesslin, ngraham
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D10512: try to preload certain applets in a smart way

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> appletquickitem.cpp:789
> +if (!d->applet->isContainment()) {
> +applet()->config().writeEntry(QStringLiteral("PreloadWeight"), 
> qMin(d->preloadWeight() + s_preloadWeightIncrement, 100));
> +}

I was also wondering about dbus-activated applet, from what I can tell whenever 
I start a media player, the score is reduced, so I'll most likely end up with 0 
for media controller immediately.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D10516: Update status to NeedsAttention when there is a menu

[Kai Uwe Broulik]

broulik added a comment.


  Oh, sorry, I assumed from the name of the files it was plasma-workspace :) 
lgtm!

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10485: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:502e8dc1080f: [lookandfeel kcm] Do not declare plugin in 
lookandfeeltool code version (authored by kossebau).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10485?vs=27078=27188

REVISION DETAIL
  https://phabricator.kde.org/D10485

AFFECTED FILES
  kcms/lookandfeel/CMakeLists.txt
  kcms/lookandfeel/kcm.cpp

To: kossebau, #freebsd, tcberner, bshah, mart, davidedmundson
Cc: davidedmundson, rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Michail Vourlakos]

mvourlakos added a comment.


  In D10516#206437 , @martinkostolny 
wrote:
  
  > Thanks for fixing my code! :)
  
  
  can you please confirm also the update that follows @broulik suggestion? I 
confirmed with Latte that everything works flawlessly now.
  
  @broulik I created the diff without arcanist but I can merge the code with 
git, but this issue wont be closed automatically I think, is there any other 
way, e.g to referece in the commit text somehow the phabricator review?

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Michail Vourlakos]

mvourlakos updated this revision to Diff 27186.
mvourlakos added a comment.


  followed @broulik suggestions and added also an improvement to not update 
menu index all the time when changing from menu to menu

REPOSITORY
  R884 Active Window Control Applet for Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10516?vs=27174=27186

REVISION DETAIL
  https://phabricator.kde.org/D10516

AFFECTED FILES
  lib/appmenuapplet.cpp
  package/contents/ui/main.qml

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Martin Kostolný]

martinkostolny accepted this revision.
martinkostolny added a comment.
This revision is now accepted and ready to land.


  Thanks for fixing my code! :)
  
  I'm sure I can also provide a flag for menu availability (the code for 
appmenu is copied for now anyway). But I think in AWC it does not make sense to 
set status to active when menu is available because it has other use then 
showing menu. I can be wrong of course.
  
  Anyway I definitely agree with your proposed patch.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10515: Have all krunner plugin desktop files prefixed with "plasma-runner-"

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ddfc158a6715: Have all krunner plugin desktop files 
prefixed with plasma-runner- (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10515?vs=27170=27183#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10515?vs=27170=27183

REVISION DETAIL
  https://phabricator.kde.org/D10515

AFFECTED FILES
  runners/appstream/CMakeLists.txt
  runners/appstream/appstreamrunner.desktop
  runners/appstream/plasma-runner-appstream.desktop
  runners/recentdocuments/CMakeLists.txt
  runners/recentdocuments/plasma-runner-recentdocuments.desktop
  runners/recentdocuments/recentdocuments.desktop

To: kossebau, #plasma, broulik, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas abandoned this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Michail Vourlakos]

mvourlakos added a comment.


  In D10516#206373 , @broulik wrote:
  
  > Thanks for looking into this!
  >
  > I could prefer a QML binding that also takes into account wheter there is a 
menu at all, something like
  >
  >   Plasmoid.status: {
  >   if (currentIndex > -1) {
  >   return PlasmaCore.Types.NeedsAttentionStatus;
  >   } else if (menuAvailable) {
  >   return PlasmaCore.Types.ActiveStatus;
  >   } else {
  >   return PlasmaCore.Types.PassiveStatus;
  >   }
  >   }
  >
  >
  > also BUG: 390271
  
  
  @broulik no prob :) only problem is that this commit is for Active Window 
Control, not for the plasma menu applet. The AWC doesnt provide a 
**menuavailable** flag. Of course I can create a second commit for plasma and 
update this one with your proposal...
  
  would that be ok?

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas reclaimed this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas abandoned this revision.
stikonas added a comment.


  Le's close it in favour of https://phabricator.kde.org/D10518

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas updated this revision to Diff 27181.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10495?vs=27106=27181

REVISION DETAIL
  https://phabricator.kde.org/D10495

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10512: try to preload certain applets in a smart way

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> appletquickitem.cpp:789
> +if (!d->applet->isContainment()) {
> +applet()->config().writeEntry(QStringLiteral("PreloadWeight"), 
> qMin(d->preloadWeight() + s_preloadWeigthIncrement, 100));
> +}

So if you ever open the any applet slightly more than every alternate login (at 
any point during that session) over time it'll become blocking preloaded on 
boot?

Your login to desktop will just get slower and slower until it's ultimately 
loading everything.

---

I'm against doing any hacks without prior profiling.

If we find plasma-pa (for example) gains a lot at no cost, great! Add the entry.

If we find plasma-pa loaded in a nanosecond anyway, and takes up 10Mb of RAM to 
do so, then it's a very silly thing to do.

I'd like to see some numbers for every applet we add it to, I don't think the 
shell is in a position to do this automatically.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D10512: try to preload certain applets in a smart way

[Nathaniel Graham]

ngraham added a comment.


  Let's keep in mind the PR aspect of this: if we end up 30 MB heavier and a 
few seconds slower on a cold boot for a new install, advanced users who 
frequent internet forums and write reviews will notice this, but they probably 
won't notice that some widgets open more quickly once Plasma is loaded.
  
  Perhaps we could invert the logic: instead of preloading everything and then 
over time removing infrequently used widgets from the list, we could preload 
only a few fixed things like the menu, Task Manager, and plasma-nm, and for 
everything else, prelaod based on frequency of use.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: broulik, apol, ngraham, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> apol wrote in appletquickitem.cpp:87
> Isn't X-Plasma-PreloadWeight for that?

It's to have some default weights without having to populate every desktop file

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: broulik, apol, ngraham, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10512: try to preload certain applets in a smart way

[Kai Uwe Broulik]

broulik added a comment.


  Cool!
  
  Since this is all applet quick item stuff it will just work™ with applet 
within system tray?
  Would be nice to have some `qCInfo` in there somewhere so we can better 
understand what it's doing, when it's increasing/decreasing the rating, when 
it's preloading it, etc.

INLINE COMMENTS

> appletquickitem.cpp:47
> +//weight values for the logic for when or if to preload
> +static const int s_defaultPreloadWeight = 50;
> +static const int s_defaultLauncherPreloadWeight = 100;

imho using an `enum` rather than a bunch of `static int`s is nicer

> appletquickitem.cpp:49
> +static const int s_defaultLauncherPreloadWeight = 100;
> +static const int s_defaultDatePreloadWeight = 80;
> +static const int s_immediatePreloadWeight = 70;

Are you sure we want to preload the calendar right away? This thing takes 
forever to open, wouldn't want to have that slow down plasma startup massively.

> appletquickitem.cpp:95
> +//default widgets to be barely preloaded
> +return qBound(0, 
> applet->config().readEntry(QStringLiteral("PreloadWeight"), 
> qMax(defaultWeight, 
> applet->pluginMetaData().rawData().value(QStringLiteral("X-Plasma-PreloadWeight")).toInt())),
>  100);
> +}

Could this be split into multiple lines, it's quite hard to follow

> appletquickitem.cpp:636
> +//decrease weight until we open it again
> +applet()->config().writeEntry(QStringLiteral("PreloadWeight"), qMax(0, 
> preloadWeight - s_preloadWeightIncrement));
> +

This should go into a function, there's like three places where a "random" 
`writeEntry` is scattered around

> appletquickitem.cpp:642
> +//spread the creation over a random delay between 2 and 10 seconds, 
> to make it look plasma started before, and load everything in the background 
> without big noticeable freezes
> +QTimer::singleShot(qrand() % ((1 + 1) - 2000) + 2000, [this]() {
> +d->createFullRepresentationItem();

Add `this` as context or else it would blow up when the applet is destroyed 
before the timer fires:

  QTimer::singleShot(qrand..., this, [this]() {

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: broulik, apol, ngraham, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10516: Update status to NeedsAttention when there is a menu

[Kai Uwe Broulik]

broulik added a comment.


  Thanks for looking into this!
  
  I could prefer a QML binding that also takes into account wheter there is a 
menu at all, something like
  
Plasmoid.status: {
if (currentIndex > -1) {
return PlasmaCore.Types.NeedsAttentionStatus;
} else if (menuAvailable) {
return PlasmaCore.Types.ActiveStatus;
} else {
return PlasmaCore.Types.PassiveStatus;
}
}
  
  also BUG: 390271

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10500: Make the review pop-up a bit more user-friendly

[Nathaniel Graham]

ngraham added a comment.


  The empty space on the bottom is a bug in Kirigami that I fixed  this morning 
with D10502: Eliminate unnecessary bottom padding on OverlaySheets 
.
  
  The star rating change is a good idea (because yeah, 1 star as the default is 
a bad idea), just proposed by someone else this morning, in fact: 
https://bugs.kde.org/show_bug.cgi?id=390426
  
  I can look into that here.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10500

To: ngraham, #discover_software_store
Cc: anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10500: Make the review pop-up a bit more user-friendly

[Alex Nemeth]

anemeth added a comment.


  What purpose does the empty space serve?
  If it has no purpose then the Review textbox could be larger or the window 
smaller.
  
  F5711965: review,_empty.png 

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10500

To: ngraham, #discover_software_store
Cc: anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

[Christoph Feck]

cfeck added a reviewer: hein.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10342

To: jtamate, #plasma_workspaces, hein
Cc: mwolff, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Report on Plasma Wayland 5.13 Meeting at 18-02-14

[Roman Gilg]

We set ourselves the following goals for Wayland on Plasma 5.13:

* Upgrade Neon base --> Neon team, bshah
* Don't force QT_QPA_PLATFORM=wayland --> Mgraesslin
* Screen capture / Remote desktop --> Kanedias, reviewed by d_ed and romangg
* Security of KWin scripts (see notes) --> Mgraesslin
* Mouse KCM --> romangg
* Virtual Desktop protocol (pager) --> Eike, Marco
* Gamma correction --> romangg
* XDG Stable (see notes) --> Mgraesslin
* zwp_linux_dmabuf_v1 (see notes) --> fredrikh

More information can be found in the appended notes file or online at [1].

Each goal should be accompanied by a Phabricator task The assignees
please create such tasks for their goals, if there exists not yet
already a task for the respective goal.

[1] https://notes.kde.org/p/plasma_5_13_wayland


plasma_5_13_wayland_meeting_notes
Description: Binary data


plasma_5_13_wayland_meeting_log
Description: Binary data

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

[Jaime Torres Amate]

jtamate marked 2 inline comments as done.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10342

To: jtamate, #plasma_workspaces
Cc: mwolff, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

[Jaime Torres Amate]

jtamate updated this revision to Diff 27177.
jtamate added a comment.


  - From 1.03% to 0.08% cpu usage moving 50.000 files
  
  fixed mwolf comment

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10342?vs=26937=27177

BRANCH
  vivaldi (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10342

AFFECTED FILES
  libtaskmanager/xwindowtasksmodel.cpp

To: jtamate, #plasma_workspaces
Cc: mwolff, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10515: Have all krunner plugin desktop files prefixed with "plasma-runner-"

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  consistentkrunnerdesktopfilenames

REVISION DETAIL
  https://phabricator.kde.org/D10515

To: kossebau, #plasma, broulik, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos added a comment.


  It seems the problem is not with SVG icons, but with the systemtray code. If 
I make the systemtray's Flow's marginHints zero, the padding is preserved 
correctly! No magic constant is needed anymore:
  
//Do spacing with margins, to correctly compute the number of lines
property QtObject marginHints: QtObject {
property int left: Math.round(0)
property int top: Math.round(0)
property int right: Math.round(0)
property int bottom: Math.round(0)
}
  
  But I have no idea what this code was supposed to be doing.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces, davidedmundson
Cc: anthonyfieroni, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[David Edmundson]

davidedmundson added a comment.


  Thanks, that's much more the sort of thought process I'm looking for!
  
  > the tray icons are SVG icons, but the application shorcut icons are bitmaps.
  
  All application icons are SVGs and they both ultimately come from IconItem?
  
  I think we might find IconItem has internal margins between the item and the 
drawn shape rounding to the icon size stuff. 
  Gammaray is a useful tool here.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces, davidedmundson
Cc: anthonyfieroni, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10512: try to preload certain applets in a smart way

[Aleix Pol Gonzalez]

apol added a comment.


  It sounds like it should be the shell who decides what needs preloading, 
rather than the framework guessing it.

INLINE COMMENTS

> appletquickitem.cpp:87
> +//some applet types we want a bigger weight
> +if (provides.contains(QStringLiteral("org.kde.plasma.launchermenu"))) {
> +defaultWeight = s_defaultLauncherPreloadWeight;

Isn't X-Plasma-PreloadWeight for that?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: apol, ngraham, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> main.qml:42
>  property bool vertical: plasmoid.formFactor == PlasmaCore.Types.Vertical
> -property int itemSize: units.roundToIconSize(Math.min(Math.min(width, 
> height), units.iconSizes[iconSizes[plasmoid.configuration.iconSize]]))
>  property int hiddenItemSize: units.iconSizes.smallMedium

I see it has configuration for icon size ? What about to use it?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces, davidedmundson
Cc: anthonyfieroni, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos added a comment.


  There is something wrong and inconstent about SVG icon scaling. For example, 
if I put this line in systemtray ui main QML code instead:
  
  `property int itemSize: Math.min(width, height)`
  
  then the KDE Connect icon completely fills the height of the panel.
  
  Which is obviously wrong, because if we open 
/usr/share/plasma/desktoptheme/default/icons/kdeconnect.svgz in an SVG editor 
we see that the icon is drawn on a 32x32px canvas ("page") and it has 2px top 
and bottom padding inside the canvas.
  
  That padding disappears when the icon is drawn on the panel. That is wrong 
because if it was a 32x32px bitmap icon, the padding (transparent pixels) would 
be preserved.
  
  That is the reason why we need to force padding (0.85*height) in the tray, 
but not in the application shortcut icons - the tray icons are SVG icons, but 
the application shorcut icons are bitmaps.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Michail Vourlakos]

mvourlakos edited the test plan for this revision.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

To: mvourlakos, martinkostolny
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added a reviewer: martinkostolny.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  Following the discussion at: 
https://github.com/psifidotos/Latte-Dock/issues/862
  
  when AWC shows menus in a Latte panel it is able to trigger the solid 
background and panel shadows for plasma theme consistency... Latte achieves 
this for all apllets that change their status to NeedsAttention... By addind 
this code AWC now provides nice solid background and shadows will Latte without 
noticing any other implications.

TEST PLAN
  Apply the code and observe the AWC to not breake its behavior

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D10516

AFFECTED FILES
  lib/appmenuapplet.cpp

To: mvourlakos, martinkostolny
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10251: [RFC] Use mipmap filtering in window thumbnails

[Nathaniel Graham]

ngraham added a comment.


  Crisper would definitely be nicer too, but if that's too hard, this is 
already a big visual win even in its current state.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

To: fredrik, #plasma, #vdg
Cc: ngraham, hein, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Closing old Plasma 4 bugs

[Christoph Feck]

On 10.02.2018 21:24, Nate Graham wrote:

Hello folks,
We have more than 2,500 Plasma 4 bugzilla tickets that we don't intend
to look at or triage. We've already prevented new tickets from being
filed, but it doesn't do anyone any good to just have the old ones
sitting there. My sense is that most of the relevant bugs and wishlist
items are already represented in the plasmashell product, so what do you
think about doing a mass-close?

I was thinking of closing them all with one of the following two
messages (top one for bugs, bottom one for wishlist items). What do you
think?

Nate







For bugs:
=

Hello!

This bug was filed for KDE Plasma 4, which reached end-of-support status
in October 2015. Developers have not been triaging Plasma 4 bugs since
that time. Happily, because KDE Plasma 5's desktop shell was been almost
completely rewritten for better performance and usability, it is likely
that this bug has already been resolved in Plasma 5. Additionally, bug
triaging resources are extremely limited; if you would like to get
involved in this effort, please see
https://community.kde.org/Get_Involved#Bug_Triaging

Accordingly, and we hope you understand why we must close this bug. If
the issue described  here is still present in KDE Plasma 5.12 or later,
please feel free to open a new ticket in the "plasmashell" product after
reading https://community.kde.org/Get_Involved/Bug_Reporting

Thanks for your understanding!

Nate Graham






For wishlist items:
===

Hello!

This feature request was filed for KDE Plasma 4, which reached
end-of-support status in October 2015. Developers have not been triaging
Plasma 4 requests since that time. Happily, because KDE Plasma 5's
desktop shell was been almost completely rewritten, it is likely that
this feature request has already been implemented in Plasma 5, or is no
longer applicable. Additionally, bug triaging resources are extremely
limited; if you would like to get involved in this effort, please see
https://community.kde.org/Get_Involved#Bug_Triaging

Accordingly, and we hope you understand why we must close this feature
request. If the requested feature is still not implemented in KDE Plasma
5.12 or later, please feel free to open a new ticket in the
"plasmashell" product after reading
https://community.kde.org/Get_Involved/Bug_Reporting

Thanks for your understanding!

Nate Graham



Hi Nate,

had that on my TODO list, but happy to see you taking over for this task.

I suggest to wait until Ubuntu 18.04 LTS is released, ideally a month 
longer to give people with LTS requirements time to update it.


Christoph

D10475: Make it possible to show the title despite having ctx actions

[Nathaniel Graham]

ngraham added a comment.


  Don't worry Henrik, you're all good. The underlying issue here is that we 
haven't actually done the necessary design work for this feature yet. The 
appropriate Kirigami HIG section is empty: 
https://community.kde.org/KDE_Visual_Design_Group/KirigamiHIG#Bars
  
  If we merge this patch, there's a significant chance that a great deal of it 
will have to be re-done later. Thankfully there shouldn't be much if any 
downstream fallout because I don't believe any clients are actually using this 
feature on the desktop, so the worst thing that could happen is that we might 
just need to re-do this work later. If that seems unpalatable, it might make 
more sense to his the brakes and decide on our design before we implement it!

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10475

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10475: Make it possible to show the title despite having ctx actions

[Henrik Fehlauer]

rkflx added a comment.


  Oops, I really didn't want to block progress here. I think the only thing 
which needs clarification is what "title" entails in relation to the rest of 
the app, perhaps with a couple of examplary use cases.
  
  Another approach would be to define the text element as a kind of "label", 
showing things like a filename or a mode/state. Then it would still need 
spacing, but not so much, it could get a smaller font.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10475

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10502: Eliminate unnecessary bottom padding on OverlaySheets

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10502

To: ngraham, #kirigami, apol, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10475: Make it possible to show the title despite having ctx actions

[Nathaniel Graham]

ngraham added a comment.


  I agree with @rkflx. I think we need to step back here and do some more long, 
hard design work before we rush to implementation. The proposed approach will 
not work for most narrow headers as there will simply not be enough room for 
navigation buttons, a title, context actions, and the menu button.
  
  I'd like to get @abetts and #VDG  
involved in this process before we proceed, as I anticipate otherwise we'll 
just go around in circles with patches to implement, change, and undo the same 
things over and over again.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10475

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10515: Have all krunner plugin desktop files prefixed with "plasma-runner-"

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  With all desktop files being installed in KDE_INSTALL_KSERVICES5DIR,
  having a namespace prevents clashes and also helps identifying the files.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  consistentkrunnerdesktopfilenames

REVISION DETAIL
  https://phabricator.kde.org/D10515

AFFECTED FILES
  runners/appstream/CMakeLists.txt
  runners/appstream/appstreamrunner.desktop
  runners/appstream/plasma-runner-appstream.desktop
  runners/recentdocuments/CMakeLists.txt
  runners/recentdocuments/plasma-runner-recentdocuments.desktop
  runners/recentdocuments/recentdocuments.desktop

To: kossebau, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10475: Make it possible to show the title despite having ctx actions

[Henrik Fehlauer]

rkflx added a comment.


  @ngraham
  
  > In this patch, we are trying to solve the general case of how a navigation 
header with context actions should look.
  
  I see, but I'm afraid with only a single example (which should be solved 
differently anyway) it is going to be hard to reach a conclusion. I'm not sure 
about the purpose of the "title" element.
  
  > "worst case scenario" for a header with two navigation buttons, a title, 
and 2 or more context actions.
  
  I doubt a "title" with four more elements plus the required spacing will work 
at all as a title.
  
  > On another note, what would be your preference for title alignment: 
left-aligned, or centered?
  
  There are two qualities which make something a title: First and foremost, 
enough room to breathe, and less importantly a more pronounced font (bigger 
size, bolder). This means for me one of these situations:
  
  - lots of space title lots of space
  - title lots of space small icon possibly with text
  - small icon with no text at all lots of space title lots of space small icon 
with no text at all
  
  I would avoid anything involving the following in relation to the title:
  
  - small space
  - no space at all
  - more than two non-space items in addition to the title
  - | as a replacement for lots of space
  
  Otherwise the title element cannot perform its role properly and feels 
cramped. Unfortunately this means most of the screenshots above don't fit those 
requirements. On the plus side, it explains the "remaining issues" and 
weirdness you noted above.
  
  In your case I would think about a two-row approach, i.e. a row resembling a 
toolbar, and a separate row for the title. Once you only have a title and two 
non-text icons, it could collapse to a single row.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10475

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart updated this revision to Diff 27169.
mart added a comment.


  - correct typo

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10512?vs=27163=27169

BRANCH
  mart/preload

REVISION DETAIL
  https://phabricator.kde.org/D10512

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10475: Make it possible to show the title despite having ctx actions

[Aleix Pol Gonzalez]

apol updated this revision to Diff 27167.
apol added a comment.


  Fix placement of the navigation arrows

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10475?vs=27129=27167

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10475

AFFECTED FILES
  src/controls/ToolBarApplicationHeader.qml
  src/controls/templates/ApplicationHeader.qml

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10513: Fix launching by touchscreen tap

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:31bcd0ac9590: Fix launching by touchscreen tap (authored 
by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10513?vs=27165=27166

REVISION DETAIL
  https://phabricator.kde.org/D10513

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemGridView.qml

To: hein, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10502: Eliminate unnecessary bottom padding on OverlaySheets

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  less-popup-padding

REVISION DETAIL
  https://phabricator.kde.org/D10502

To: ngraham, #kirigami, apol, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10513: Fix launching by touchscreen tap

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10513

To: hein, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10513: Fix launching by touchscreen tap

[Eike Hein]

hein created this revision.
hein added a reviewer: Plasma.
Restricted Application added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  The mouse handling code relied on onPositionChanged to do setup work
  prior to onPressed. This is never guaranteed, but it's is likely to
  happen when using the mouse (since the pointer is usually moved from
  a panel icon to a delegate elsewhere on screen). In a touchscreen
  scenario, these odds reverse.
  
  The lesson to take away: Never assume onPositionChanged has run
  before onPressed.
  
  BUG:366527

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10513

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemGridView.qml

To: hein, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart updated this revision to Diff 27163.
mart added a comment.


  - silence warnings

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10512?vs=27162=27163

BRANCH
  mart/preload

REVISION DETAIL
  https://phabricator.kde.org/D10512

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  preload popups of some applets after init in the background
  based on a value of X-Plasma-PreloadWeight in the desktop file
  if present, otherwise some default values based on the applet
  type (Provides)
  
  Save the weight in the config, if an applet is never opened,
  slowly decrease the weight, when it reaches 0 don't preload it
  next start, increase every time it gets opened, so at the moment
  it's quite aggressive about preloading, in order to not do it
  a lot of plasma startups without touching the applet are needed
  
  Applet with a very big weigth will be preloaded immediately,
  therefore having an impact on the time it will take to have
  a panel visible and usable, while lesser weigths will preload
  after a random number of seconds between 2 and 10, so will load
  in the background after everything is started

TEST PLAN
  Plasma starts up correctly, applets load correctly and can be added
  correctly both those expanded or collapsed.
  plasmashell appears correctly usable without too big hiccups even
  while it's loading things in the background
  
  some numbers:
  without preloading, plasma takes around 64 mb of memory after startup
  when preloading everything about 94, so it's a cost of about 30 mb
  which is not negligible.
  don't have precise timing, but if everything gets preloaded immediately,
  the time to get an usable desktop appears to be at least doubled,
  while the delayed preloading (except just a couple of applets) doesn't
  seem to have a big impact on the time needed to get an usable desktop

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  mart/preload

REVISION DETAIL
  https://phabricator.kde.org/D10512

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10502: Eliminate unnecessary bottom padding on OverlaySheets

[Nathaniel Graham]

ngraham retitled this revision from "Eliminate unnecessary bottom pading on 
OverlaySheets" to "Eliminate unnecessary bottom padding on OverlaySheets".

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10502

To: ngraham, #kirigami, apol
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10461: GMenu-DBusMenu-Proxy

[Konstantin]

rilian added a comment.


  UPD: disabled an exporting of empty menubar on X11. Try latest 
appmenu-gtk-module master, please.
  I do not know how to do it in GTK Wayland.
  
  Can you explain me KDE Wayland Global Menu architecture?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10461

To: broulik, #plasma
Cc: rk, rilian, mtallur, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10510: Fix window pin not showing

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:840694cc5bbe: Fix window pin not showing (authored by 
hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10510?vs=27157=27160

REVISION DETAIL
  https://phabricator.kde.org/D10510

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderViewLayer.qml

To: hein, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10502: Eliminate unnecessary bottom pading on OverlaySheets

[Aleix Pol Gonzalez]

apol added a comment.


  +1 makes sense to me.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10502

To: ngraham, #kirigami, apol
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10461: GMenu-DBusMenu-Proxy

[Konstantin]

rilian added a comment.


  If you need help, I will provide it for you, because for me there is 2 
features which should be in KDE for me:
  
  1. Global Menu (for all protocols)
  2. QGtkStyle (with GTK3 themes)
  
  
  
  > Okay. Problem is that for example LibreOffice doesn't have a menu right 
away, so I can't realy tell "no menu because it's still loading" or "no menu 
because it doesn't have one" and then fallback to app menu. I could perhaps 
check if the app has an appmenu at all before trying to fallback but not really 
fond of adding even more complexity to it.
  
  I too because MenuModel can be empty on start, and I cannot differ than user 
turned menu off or just application do not have a menu?
  About searching of appmenu and fallback to it - LibreOffice have both appmenu 
and menubar, so, we will lose LibreOffice menu.
  
  > What kind of different actions? So far I have only had redundancy in the 
app menu, I'll try to look into this, merging two separate menus into one 
somehow, also getting the app name for the app menu..
  
  It can be actions (GActions, I mean) than exists only in appmenu, but not in 
menubar. User may want this.
  
  > How am I supposed to know which action belongs where?
  
  But all menuitems have "action" attribute)
  Or if you about a QAction (which, I think, should called QMenuItem), this is 
several ways to do this:
  
  1. Look for each section, name it by some action-name regex (as you did with 
icons) and then show it as menubar.
  2. Or just do it with each menuitem, but it is way more complicated. I 
suggest a section-way.
  
  
  
  > That was just for the icon mapping, I can probably remove this, since the 
actions in unity are just their localized labels plus unity. prefix, there's 
nothing I can map them to (like I would be able to window.open to document-open 
icon)
  
  I think you do not need mapping, because we have a bunch of this code:
  
C
static GtkImage *gtk_menu_item_get_nth_image(GtkMenuItem *menu_item, guint 
index)
{
UnityGtkSearch search;

g_return_val_if_fail(GTK_IS_MENU_ITEM(menu_item), NULL);

search.type   = GTK_TYPE_IMAGE;
search.index  = index;
search.object = NULL;

g_object_get_nth_object(G_OBJECT(menu_item), );

return search.object != NULL ? GTK_IMAGE(search.object) : NULL;
}

static GIcon *gtk_image_get_icon(GtkImage *image)
{
GIcon *icon = NULL;

g_return_val_if_fail(GTK_IS_IMAGE(image), NULL);

switch (gtk_image_get_storage_type(image))
{
case GTK_IMAGE_GICON:
{
gtk_image_get_gicon(image, , NULL);

if (icon != NULL)
g_object_ref(icon);
}

break;

case GTK_IMAGE_ICON_NAME:
{
const char *name = NULL;

gtk_image_get_icon_name(image, , NULL);

if (name != NULL)
icon = 
G_ICON(g_themed_icon_new_with_default_fallbacks(name));
}

break;

case GTK_IMAGE_PIXBUF:
{
GdkPixbuf *pixbuf = gtk_image_get_pixbuf(image);

if (pixbuf != NULL)
icon = g_object_ref(pixbuf);
}

break;

case GTK_IMAGE_ANIMATION:
{
GdkPixbufAnimation *animation = gtk_image_get_animation(image);

if (animation != NULL)
{
GdkPixbuf *pixbuf = 
gdk_pixbuf_animation_get_static_image(animation);

if (pixbuf != NULL)
icon = g_object_ref(pixbuf);
}
}

break;

case GTK_IMAGE_STOCK:
#if GTK_MAJOR_VERSION == 2
{
char *stock  = NULL;
GtkIconSize size = GTK_ICON_SIZE_INVALID;

gtk_image_get_stock(image, , );

if (stock != NULL)
{
GdkPixbuf *pixbuf =
gtk_widget_render_icon(GTK_WIDGET(image), stock, 
size, NULL);

if (pixbuf != NULL)
icon = G_ICON(pixbuf);
}
}
#elif GTK_MAJOR_VERSION == 3
{
GtkStyleContext *context = 
gtk_widget_get_style_context(GTK_WIDGET(image));

if (context != NULL)
{
char *stock  = NULL;
GtkIconSize size = GTK_ICON_SIZE_INVALID;

gtk_image_get_stock(image, , );

if (stock != NULL)
{
GtkIconSet *set = 
gtk_style_context_lookup_icon_set(context, stock);

if (set != NULL)
{

D10510: Fix window pin not showing

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10510

To: hein, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10510: Fix window pin not showing

[Eike Hein]

hein created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
hein requested review of this revision.

REVISION SUMMARY
  showPin oscillates during startup and the prop being null'd
  on destroy() is not sync, so this creates a race condition.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10510

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderViewLayer.qml

To: hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[David Edmundson]

davidedmundson added a comment.


  The part I care about is deciding what the problem is, and understanding the 
code around it.
  
  The goal apparently was to match the application icon on the left, which 
means any patch needs to be able to describe the current padding that happens 
there, and the current padding that happens here.
  
  Without that anything is guesswork.
  
  This patch adds padding directly through resizing (but only in one of the two 
paths of the size if statement) and then there's a completely separate 
additional path with the marginHints in tasksRow going through to AbstractItem 
doing the same thing, but differently.
  
  I'm fine with changing it, but not blindly.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10461: GMenu-DBusMenu-Proxy

[Kai Uwe Broulik]

broulik added a comment.


  Thanks for your input!
  
  > Yes, menubar may be empty
  
  Okay. Problem is that for example LibreOffice doesn't have a menu right away, 
so I can't realy tell "no menu because it's still loading" or "no menu because 
it doesn't have one" and then fallback to app menu. I could perhaps check if 
the app has an appmenu at all before trying to fallback but not really fond of 
adding even more complexity to it.
  
  > GTK3 applications (file-roller, for example) can use both appmenu and 
menubar with different items (and different action)
  
  What kind of different actions? So far I have only had redundancy in the app 
menu, I'll try to look into this, merging two separate menus into one somehow, 
also getting the app name for the app menu..
  
  > You can add New Window and Quit to File menu, Sidebar to View, Preferences 
and Keyboard shortcuts to Tools (or Edit), and Help and About to help.
  
  How am I supposed to know which action belongs where?
  
  > What about FIXME unity, what are you mean?
  
  That was just for the icon mapping, I can probably remove this, since the 
actions in unity are just their localized labels plus `unity.` prefix, there's 
nothing I can map them to (like I would be able to `window.open` to 
`document-open` icon)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10461

To: broulik, #plasma
Cc: rk, rilian, mtallur, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10507: Turn code.js into a singleton

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Otherwise we would create an instance of this JS file for every delegate.
  The only contextual object it uses is `i18n`, so pass that in for the 
function call.

TEST PLAN
  Verified that the JS file is created only once. Speeds up things somewhat.
  Verified that the favorites action still shows properly and works

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10507

AFFECTED FILES
  applets/kicker/package/contents/code/tools.js
  applets/kicker/package/contents/ui/DashboardRepresentation.qml
  applets/kicker/package/contents/ui/ItemGridDelegate.qml
  applets/kicker/package/contents/ui/ItemListDelegate.qml
  applets/kicker/package/contents/ui/SideBarItem.qml
  applets/kickoff/package/contents/code/tools.js
  applets/kickoff/package/contents/ui/KickoffItem.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10461: GMenu-DBusMenu-Proxy

[Konstantin]

rilian added a comment.


  What about FIXME unity, what are you mean? I can fix appmenu-gtk-module for 
you.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10461

To: broulik, #plasma
Cc: rk, rilian, mtallur, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10461: GMenu-DBusMenu-Proxy

[Konstantin]

rilian added a comment.


  O, some another note: You can generate menubar from appmenu.
  For example, Nautilus:
  It have 4 sections
  
  1. New Window
  2. Sidebar
  3. Preferences
  4. Keyboard Shortcuts Help About Quit.
  
  You can add New Window and Quit to File menu, Sidebar to View, Preferences 
and Keyboard shortcuts to Tools (or Edit), and Help and About to help.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10461

To: broulik, #plasma
Cc: rk, rilian, mtallur, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Nathaniel Graham]

ngraham added a comment.


  Going up from the 0.71 magic number to the 0.85 magic number would make the 
clock bigger than it currently is, no? Can you supply a screenshot of how this 
works now at standard size, increased size, and witha  high-DPI display?
  
  Since magic numbers are bad, and we already have one for the clock, it does 
seem reasonable to replace it with a constant of some sort that we can re-use, 
for example with the notification icons as you're proposing. Making it 
user-configurable seems like unnecessary overkill to me though.
  
  @davidedmundson, what do you think about that plan? We'd get rid of the 
existing magic number, which would be nice, right?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10475: Make it possible to show the title despite having ctx actions

[Nathaniel Graham]

ngraham added a comment.


  @rkflx Not naive at all!
  
  In this patch, we are trying to solve the general case of how a navigation 
header with context actions should look. Once we implement this control in 
Discover, we will //definitely// be removing the title from the app page's use 
of it, since as you point out, it's redundant as the page content below it 
already shows the app name. We may also even remove the context actions and put 
them on the page too, in a non-scrolling header as you suggest. So this patch 
is really trying to work out the "worst case scenario" for a header with two 
navigation buttons, a title, and 2 or more context actions.
  
  On another note, what would be your preference for title alignment: 
left-aligned, or centered?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10475

To: apol, #kirigami, mart, ngraham, abetts
Cc: rkflx, mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10502: Eliminate unnecessary bottom pading on OverlaySheets

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10502

To: ngraham, #kirigami, apol
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10502: Eliminate unnecessary bottom pading on OverlaySheets

[Nathaniel Graham]

ngraham marked an inline comment as done.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10502

To: ngraham, #kirigami, apol
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10502: Eliminate unnecessary bottom pading on OverlaySheets

[Nathaniel Graham]

ngraham updated this revision to Diff 27150.
ngraham added a comment.


  Use a more programmatically correct approach (top_adding+buttomPadding 
instead of Units.gridUnit*2); this will work for clients that change the 
padding values

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10502?vs=27133=27150

BRANCH
  less-popup-padding

REVISION DETAIL
  https://phabricator.kde.org/D10502

AFFECTED FILES
  src/controls/templates/OverlaySheet.qml

To: ngraham, #kirigami, apol
Cc: plasma-devel, apol, davidedmundson, mart, hein

D10506: Move autopopulate to AppsModel

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a0ca2d1bc204: [Kicker] Move autoPopulate to AppsModel 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10506?vs=27145=27148

REVISION DETAIL
  https://phabricator.kde.org/D10506

AFFECTED FILES
  applets/kicker/plugin/appsmodel.cpp
  applets/kicker/plugin/appsmodel.h
  applets/kicker/plugin/rootmodel.cpp
  applets/kicker/plugin/rootmodel.h
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10502: Eliminate unnecessary bottom pading on OverlaySheets

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> OverlaySheet.qml:270
>  width: root.contentItem.implicitWidth <= 0 ? mainItem.width : 
> Math.max(mainItem.width/2, Math.min(mainItem.width, 
> root.contentItem.implicitWidth))
> -height: scrollView.flickableItem && 
> root.contentItem.hasOwnProperty("contentY") ? 
> scrollView.flickableItem.contentHeight + headerHeight : 
> (root.contentItem.height + topPadding + bottomPadding + 
> Units.iconSizes.medium + Units.gridUnit)
> +height: scrollView.flickableItem && 
> root.contentItem.hasOwnProperty("contentY") ? 
> scrollView.flickableItem.contentHeight + headerHeight : 
> (root.contentItem.height + Units.gridUnit * 2)
>  Item {

Does this mean that setting the topPadding and bottomPadding to 0 would make 
this empty space go away?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D10502

To: ngraham, #kirigami, apol
Cc: plasma-devel, apol, davidedmundson, mart, hein

Re: Latte Dock findings and maybe useful to Plasma also...

[Marco Martin]

On lunedì 5 febbraio 2018 11:28:56 CET Michail Vourlakos wrote:
> plasma (shellcorona) I think this is done with a flag indicating when we
> are in delete mode in order to indicate when the crashing code to not be
> executed...

Thanks!
indeed very interesting, i think we can do it every time an applet is deleted 
and should indeed save something. (not sure if would help on activity switch 
as things are not getting deleted there)

-- 
Marco Martin

D10506: Move autopopulate to AppsModel

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10506

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10506: Move autopopulate to AppsModel

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Kickoff uses AppsModel instead of RootModel but since RootModel inherits 
AppsModel we can just move everything over here.

TEST PLAN
  Avoids Kickoff refreshing its model a gazillion times when opening.
  Kicker still working without adjustments.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10506

AFFECTED FILES
  applets/kicker/plugin/appsmodel.cpp
  applets/kicker/plugin/appsmodel.h
  applets/kicker/plugin/rootmodel.cpp
  applets/kicker/plugin/rootmodel.h
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart