Re: value error: year out of range
Resolved. I removed old mysql database. I removed the site directory. I changed locale on my debian lenny from it_IT utf-8 to en_US utf-8. I created a new mysql database with collation utf-8_general_ci. I recreated the site from scratch entering: rb-site install path. Now all work fine. But because of my python lack of knowledge I cannot fugure out where it was the problem. maybe the local settings? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
review-request email mime type
Hi, all I tried to change template for email. caz the review request email has no link. I looked up and I found the mime type of the mail from reviewboard is text/plain and the body is PRE /PRE so all the template I changed is only text. How can I change the mime type to add link the mail. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review under clearcase / HOW TO ?
I had this problem as well few months ago. Following patch to post-review should resolve it (attached). I had to fix some permissions in order to get rid of temp files + the '\n' (or \r?) was not stripped from the argument and also split_lines option was needed in a execute call. I don't remember if I reached the point of actually posting a review though as I had not much time to play with clearcase+reviewboard :) Regards, Bartek Celary 2009/5/25 mahesh forvai...@gmail.com: post-review under clearcase / HOW TO ? Hi, I have set up a django based review-board (i.e. without apache / mod_python) and it came up well. I would like to post-review from another client where I've installed RBTools (latest version_ I am in clearcase dynamic view and in vob path .. example /vobs/src/tmp_vob/tools and checked out build.ksh and I am issuing following command to make it diff from predecessor version and CHECKEDOUT version to RB as if posted by an admin user. Command - post-review --server=http://mvaidya-inl:8000 --username=admin -- password=admin build.ksh Please advise me if command usage is correct and I am getting this errors for now File /home/mvaidya/EGG-INFO/scripts/post-review, line 938, in diff return self.do_diff(self.get_extended_namespace(files)) File /home/mvaidya/EGG-INFO/scripts/post-review, line 802, in get_extended_namespace versions = self.get_previous_version(files) File /home/mvaidya/EGG-INFO/scripts/post-review, line 781, in get_previous_version [cleartool, desc, -pre, elem_path]) ValueError: too many values to unpack --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- Index: post-review === --- post-review (revision 1980) +++ post-review (working copy) @@ -1,4 +1,5 @@ #!/usr/bin/env python +import stat import cookielib import difflib import getpass @@ -781,7 +782,7 @@ # Call cleartool to get this version and the previous version # of the element. curr_version, pre_version = execute( -[cleartool, desc, -pre, elem_path]) +[cleartool, desc, -pre, elem_path], split_lines=True) curr_version = cpath.normpath(curr_version) pre_version = pre_version.split(':')[1].strip() @@ -899,8 +900,9 @@ tf = cpath.normpath(cpath.join(td, name)) if cpath.exists(tf): debug(WARNING: FILE EXISTS) -os.unlink(tf) -execute([cleartool, get, -to, tf, normkey]) +os.chmod(tf, stat.S_IWRITE | stat.S_IREAD) +os.remove(tf) +execute([cleartool, get, -to, tf, normkey.strip(\n)]) else: die(ERROR: FILE NOT FOUND : %s % epstr) @@ -995,7 +997,8 @@ file_data.append(fdata) # If the file was temp, it should be removed. if do_rem: -os.remove(filenam) +os.chmod(fn, stat.S_IWRITE | stat.S_IREAD) +os.remove(fn) modi = file_data.pop() orig = file_data.pop()
SVN error when viewing diff
Greetings, I'm running RB svn trunk version (rc3*) and when clicking view diff on a review request the following backtrace appears: Traceback (most recent call last): File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/views.py, line 152, in view_diff interdiffset, highlighting, True) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 620, in get_diff_files large_data=True) File /usr/lib/python2.4/site-packages/Djblets-0.5rc1-py2.4.egg/ djblets/util/misc.py, line 143, in cache_memoize data = lookup_callable() File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 619, in lambda enable_syntax_highlighting), File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 341, in get_chunks old = get_original_file(filediff) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 248, in get_original_file large_data=True)[0] File /usr/lib/python2.4/site-packages/Djblets-0.5rc1-py2.4.egg/ djblets/util/misc.py, line 143, in cache_memoize data = lookup_callable() File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 247, in lambda data = cache_memoize(key, lambda: [fetch_file(file, revision)], File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 227, in fetch_file data = tool.get_file(file, revision) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/scmtools/svn.py, line 117, in get_file raise SCMError(e) SCMError: Server sent unexpected return value (400 Bad Request) in response to OPTIONS request for 'http://code.ingres.com/ingres/ branches/geospatial/buildtools/test_env.sh' Any ideas if this is an issue with my SVN server or an issue with RB? Thanks! Alex --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
ReviewBoard General Inquiries
Hi, i am evaluating several code review software for our company. We have this question regarding review board, one of the barriers of entry for our programmers to use reviewboard is that we are not using diffs for code reviews but rather we are using files. We don't want to be able to upload diffs but rather upload files for consumption purposes. Does review-board support this kind of model? if not, will it support it in the future. Hopefully ReviewBoard will be able to support it in the future as it is such a nice tool. Also do you support writing a review by email , or adding comments via email? Thanks Carlo --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: ReviewBoard General Inquiries
I'm not really sure why this is an issue, but all uploads to reviewboard are via diff. If you use the post-review tool, you never have to see/touch/smell the diff at all, you just deal with the review, and your VCS's revision specs. Even though you're uploading a diff, reviewboard goes out to your VCS, pulls out the whole file, and hilights the areas which have changed. I think that answers your question as I understand it; if you're asking whether you can review existing files(like reviewing your whole codebase), check the archives of this list... Christian has covered that a few times, and it's very possible to do with post-review. -- Jeff O|||O 2009/5/25 Carlo Camerino cmcamer...@gmail.com Hi, i am evaluating several code review software for our company. We have this question regarding review board, one of the barriers of entry for our programmers to use reviewboard is that we are not using diffs for code reviews but rather we are using files. We don't want to be able to upload diffs but rather upload files for consumption purposes. Does review-board support this kind of model? if not, will it support it in the future. Hopefully ReviewBoard will be able to support it in the future as it is such a nice tool. Also do you support writing a review by email , or adding comments via email? Thanks Carlo --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: SVN error when viewing diff
Hi Alex, It sounds like an error either on the SVN server, or possibly a proxy if the server running Review Board is configured to go through a proxy server. We use PySVN to perform all requests on the SVN server, which just goes through the official libsvn, so at this point it's beyond our control. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Mon, May 25, 2009 at 10:52 AM, Alex atrof...@gmail.com wrote: Greetings, I'm running RB svn trunk version (rc3*) and when clicking view diff on a review request the following backtrace appears: Traceback (most recent call last): File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/views.py, line 152, in view_diff interdiffset, highlighting, True) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 620, in get_diff_files large_data=True) File /usr/lib/python2.4/site-packages/Djblets-0.5rc1-py2.4.egg/ djblets/util/misc.py, line 143, in cache_memoize data = lookup_callable() File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 619, in lambda enable_syntax_highlighting), File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 341, in get_chunks old = get_original_file(filediff) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 248, in get_original_file large_data=True)[0] File /usr/lib/python2.4/site-packages/Djblets-0.5rc1-py2.4.egg/ djblets/util/misc.py, line 143, in cache_memoize data = lookup_callable() File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 247, in lambda data = cache_memoize(key, lambda: [fetch_file(file, revision)], File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 227, in fetch_file data = tool.get_file(file, revision) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/scmtools/svn.py, line 117, in get_file raise SCMError(e) SCMError: Server sent unexpected return value (400 Bad Request) in response to OPTIONS request for 'http://code.ingres.com/ingres/ branches/geospatial/buildtools/test_env.shhttp://code.ingres.com/ingres/%0Abranches/geospatial/buildtools/test_env.sh ' Any ideas if this is an issue with my SVN server or an issue with RB? Thanks! Alex --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: review-request email mime type
At this point what you want to do is not trivial, but I plan to provide HTML e-mail support in Review Board 1.1. That said, we do provide the URL in each e-mail, and most e-mail clients will turn that into a hyperlink properly. Which e-mail client are you using? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Mon, May 25, 2009 at 3:46 AM, rozinante mw44@gmail.com wrote: Hi, all I tried to change template for email. caz the review request email has no link. I looked up and I found the mime type of the mail from reviewboard is text/plain and the body is PRE /PRE so all the template I changed is only text. How can I change the mime type to add link the mail. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Apache Authentication
Hi Andrew, There are some patches up on http://reviews.review-board.org/ for this. They're a little outdated, so you'll probably have to tweak them a bit if you decide to use them. We haven't put them into the main codebase yet because they depend on a feature newly added to the still-in-beta Django 1.1, and we won't be moving to that until after 1.0 is out the door. That's not far off, though. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Mon, May 25, 2009 at 1:00 PM, Andrew aschwa...@gmail.com wrote: Hi all. Is it possible to use the standard Apache authentication with Review Board? If so, can you point me in the right direction for doing so? Thanks. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: value error: year out of range
The backtrace you linked to was a 404 here, so I wasn't able to see it. I don't know why you'd get that error or where it came from. Glad it works now though. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Mon, May 25, 2009 at 1:07 AM, nicolar nicola.rugg...@gmail.com wrote: Resolved. I removed old mysql database. I removed the site directory. I changed locale on my debian lenny from it_IT utf-8 to en_US utf-8. I created a new mysql database with collation utf-8_general_ci. I recreated the site from scratch entering: rb-site install path. Now all work fine. But because of my python lack of knowledge I cannot fugure out where it was the problem. maybe the local settings? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: ReviewBoard General Inquiries
Hi Carlo, Jeff has a good summary of the diff part of this. I want to just reaffirm that we work with diffs but post-review is your good friend. Some people have requested being able to just upload files and not use a code repository, but it's not a high priority for us. Someone would have to do a lot of work to make it happen and so far I haven't seen too many cases where it's really beneficial over just storing them in an SVN repository or something. Either way, the end result is that you'll see the files in their entirety (collapsed to show changed regions by default, but you can expand to see the entire file) and you'll see the changes between them. We don't support commenting by e-mail. We've considered this and there's a feature request filed for it, but it's tricky to get right in all cases, and it's not something we personally plan to work on. However, much of Review Board is provided by third party contributors scratching an itch, so if someone wanted to work on it and provided a good implementation that handled reviews by e-mail, we'll certainly consider it. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Mon, May 25, 2009 at 10:57 AM, Carlo Camerino cmcamer...@gmail.comwrote: Hi, i am evaluating several code review software for our company. We have this question regarding review board, one of the barriers of entry for our programmers to use reviewboard is that we are not using diffs for code reviews but rather we are using files. We don't want to be able to upload diffs but rather upload files for consumption purposes. Does review-board support this kind of model? if not, will it support it in the future. Hopefully ReviewBoard will be able to support it in the future as it is such a nice tool. Also do you support writing a review by email , or adding comments via email? Thanks Carlo --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Code Review Process
Hi Rupert, There's not a one click for this, but you can post existing revisions up for review using post-review. See: http://www.review-board.org/docs/manual/dev/users/tools/post-review/#posting-committed-code I don't know if that plugin and Review Board could work together. I know it doesn't today, and I imagine it'd be best to keep that plugin around for simple code review integration in Trac and for someone to write a new one that's Review Board-specific. There are no current plans to write this, but if someone else did I'd love to see it :) Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Fri, May 22, 2009 at 5:51 AM, rupert.thurner rupert.thur...@gmail.comwrote: with much interest i found reviewboard. when starting newly reviewing existing code would be a really great option. is there any guideline to a one click review my existing code (or one command) ? i found one plugin into edgewall trac: http://trac-hacks.org/wiki/PeerReviewPlugin/Screenshots, but i am unsure if trac and reviewboard could work together (or, if it even makes sense that they do ...). rupert. On Jul 3 2008, 6:07 am, Christian Hammond chip...@chipx86.com wrote: Hi Jon. Love the title of your blog :) Though we don't advertise it nearly as much, Review Board can post review requests of already committed code. The web UI doesn't have support for this (yet) but the command line post-review tool does. You can specify a revision range to put up for review and people can review that. In time, probably after extensions support goes in, I envision a small repository browser that lets you easily put committed code up for review. But in the meantime, post-review is your best option. If you check the wiki, there's some documentation on using post-review in this way. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Wed, Jul 2, 2008 at 7:17 PM, jon latch...@gmail.com wrote: Hi all, After fully installing and reviewing reviewboard today, I realized that this product is kind of the opposite of what I'm looking for because my development model is a bit different than the one that this product supports. Instead of creating a patch and waiting for my co- workers to review it, I'd rather see a system where reviews are done on already committed code and there is a workflow around that system instead. To keep this email short, I just wrote a blog posting detailing my issues: http://lookfirst.com/2008/07/code-reviews.html I'd love to hear the experts here comment on my views. thanks, jon --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: SVN error when viewing diff
Thanks Christian, SVN worked fine outside of RB (browser and svn co etc). I rebooted apache and the issue disappeared for now. Thanks for the help. Alex On May 25, 2:53 pm, Christian Hammond chip...@chipx86.com wrote: Hi Alex, It sounds like an error either on the SVN server, or possibly a proxy if the server running Review Board is configured to go through a proxy server. We use PySVN to perform all requests on the SVN server, which just goes through the official libsvn, so at this point it's beyond our control. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Mon, May 25, 2009 at 10:52 AM, Alex atrof...@gmail.com wrote: Greetings, I'm running RB svn trunk version (rc3*) and when clicking view diff on a review request the following backtrace appears: Traceback (most recent call last): File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/views.py, line 152, in view_diff interdiffset, highlighting, True) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 620, in get_diff_files large_data=True) File /usr/lib/python2.4/site-packages/Djblets-0.5rc1-py2.4.egg/ djblets/util/misc.py, line 143, in cache_memoize data = lookup_callable() File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 619, in lambda enable_syntax_highlighting), File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 341, in get_chunks old = get_original_file(filediff) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 248, in get_original_file large_data=True)[0] File /usr/lib/python2.4/site-packages/Djblets-0.5rc1-py2.4.egg/ djblets/util/misc.py, line 143, in cache_memoize data = lookup_callable() File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 247, in lambda data = cache_memoize(key, lambda: [fetch_file(file, revision)], File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/diffviewer/diffutils.py, line 227, in fetch_file data = tool.get_file(file, revision) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0rc3.dev_r1979- py2.4.egg/reviewboard/scmtools/svn.py, line 117, in get_file raise SCMError(e) SCMError: Server sent unexpected return value (400 Bad Request) in response to OPTIONS request for 'http://code.ingres.com/ingres/ branches/geospatial/buildtools/test_env.shhttp://code.ingres.com/ingres/%0Abranches/geospatial/buildtools/test_... ' Any ideas if this is an issue with my SVN server or an issue with RB? Thanks! Alex --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request
Comment #5 on issue 831 by kbcmdba: Can't leave comments before you publish your own newly created review request http://code.google.com/p/reviewboard/issues/detail?id=831 I disagree with Christian. Commenting on your own posting is a good way of doing self-review. There are times when I need to look through my own changes allowing ReviewBoard to help me. This results in cases where it's easier to look at my own changes, especially when considering large diffs. In that type of situation, I may post a comment noting that I saw a problem and have already fixed it but won't re-post an updated review until I get more feedback from others. This saves other reviewers time. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---