ImproperlyConfigured: Error loading psycopg2 module: DLL load failed. The specified module could not be found
Hello, I am getting this error ever since I created a new rb site for Postgre DB. I downloaded psycopg2 using easy_install psycopg2 and it created egg file psycopg2-2.0.13-py2.5-win32.egg in my Site-Packages directory. I created new RB site to use Postgre DB and restarted Apache. I started getting error ImproperlyConfigured: Error loading psycopg2 module: DLL load failed: The specified module could not be found. Sometimes I also get error - Error loading psycopg2 module: cannot import name tz I struggled on web to find resolution and verified them against my setup. Python Egg Cache has been given access to user account Apache is running on. I can't guess any other reason. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ImproperlyConfigured: Error loading psycopg2 module: DLL load failed. The specified module could not be found
I had this problem when installing on RHEL5. On RHEL5, the pytz package (and several others) did not have egg files. Basically, reviewboard is querying the egg files on your system to see if you have them installed. If you manually install 'pytz', it's safe to remove that line from /usr/lib/python2.6/site-packages/ ReviewBoard-1.0.5.1-py2.6.egg-info/dependency_links.txt (which will stop throwing that error). On Feb 5, 4:57 am, Shankar Kalel shankar.ka...@gmail.com wrote: Hello, I am getting this error ever since I created a new rb site for Postgre DB. I downloaded psycopg2 using easy_install psycopg2 and it created egg file psycopg2-2.0.13-py2.5-win32.egg in my Site-Packages directory. I created new RB site to use Postgre DB and restarted Apache. I started getting error ImproperlyConfigured: Error loading psycopg2 module: DLL load failed: The specified module could not be found. Sometimes I also get error - Error loading psycopg2 module: cannot import name tz I struggled on web to find resolution and verified them against my setup. Python Egg Cache has been given access to user account Apache is running on. I can't guess any other reason. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Multiple diffs per review?
On 2010-02-04 18:15, Stodge wrote:
On Feb 4, 6:21 pm, Matthew Woehlke wrote:
On 2010-02-04 10:13, Stodge wrote:
[...] we need to be able to group multiple revisions on one review.
Is this possible with RB?
You could upload the diff of the first revision, publish it, upload the
cumulative diff of the first and second revisions, publish it, upload...
and so on. That will let reviewers view (vcs:r2) by looking at the
changes between (rb:r1 == vcs:r2) and (rb:r2 == vcs:r1+r2), which might
be close to what you want.
Thanks.
For example:
r1 committed by Mike
r2 committed by Mike
r3 committed by Bob
r4 committed by Fred
r5 committed by Mike
I would want to review r1, r2 and r5 in one single review, which I
don't think would work in your example.
Sure it will. Create a diff consisting of vcs:r1 and publish it. Now
create a diff consisting of vcs:r1+r2 and publish it. Then create a diff
of vcs:r1+r2+r5 and publish it.
The trick of course is telling Review Board that the diff you are
uploading is based off of vcs r0. AFAIK this can be done, though you'll
probably have to hack together your own script to generate the diffs and
submit the appropriate info to Review Board (this was already assumed).
So what you will see in Review Board is rb:r3 == vcs:r1+r2+r5. You can
look at rb:r1 to see just vcs:r1, or rb:r2-r1 to see just vcs:r2, or
rb:r3-r2 to see just vcs:r5. ('rb:x-y' means 'rb:x without rb:y', a.k.a.
'changes between y and x' in Review Board parlance.)
I'm assuming you want to be able to see each revision independently. If
you only care about r1+r2+r5, just generate that diff and post it.
(Again, the trick is telling Review Board what revision is base. Check
out postreview.py, you should be able to find how to do that.)
Actually... I think you can also just check out r0, read the diffs from
VCS and apply them, and simply post-review that. It just won't fill in
the revision field (but I think you may be out of luck there no matter
what).
--
Matthew
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Is it possible to specify a change number/revision for an SVN repository when creating a review request via json?
Is it possible to specify a change number/revision for an SVN
repository when creating a review request via json? I'm guessing not
but I wanted to check.
ERROR:root:Exception thrown for user admin at
http://localhost:9900/reviews/api/json/reviewrequests/new/
Traceback (most recent call last):
File /usr/lib/python2.5/site-packages/django/core/handlers/
base.py, line 92, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File /usr/lib/python2.5/site-packages/django/views/decorators/
cache.py, line 44, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File /usr/lib/python2.5/site-packages/Djblets-0.5.6-py2.5.egg/
djblets/webapi/decorators.py, line 59, in _checklogin
response = view_func(request, *args, **kwargs)
File /usr/lib/python2.5/site-packages/django/views/decorators/
http.py, line 37, in inner
return func(request, *args, **kwargs)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/
reviewboard/webapi/json.py, line 439, in new_review_request
user, repository, request.POST.get('changenum', None))
File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/
reviewboard/reviews/managers.py, line 73, in create
review_request.update_from_changenum(changenum)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/
reviewboard/reviews/models.py, line 342, in update_from_changenum
update_obj_with_changenum(self, self.repository, changenum)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/
reviewboard/reviews/models.py, line 36, in update_obj_with_changenum
changeset = repository.get_scmtool().get_changeset(changenum)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/
reviewboard/scmtools/core.py, line 65, in get_changeset
raise NotImplementedError
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard Error while posting review for GIT
It's failing here in git.py in scmtools folder.
class GitClient:
def __init__(self, path):
if not is_exe_in_path('git'):
# This is technically not the right kind of error, but
it's the
# pattern we use with all the other tools.
raise ImportError
self.path = path
p = subprocess.Popen(
['git', '--git-dir=%s' % self.path, 'config',
'core.repositoryformatversion'],
stderr=subprocess.PIPE,
stdout=subprocess.PIPE,
close_fds=(os.name != 'nt')
)
contents = p.stdout.read()
errmsg = p.stderr.read()
failure = p.wait()
if failure:
raise ImportError
On Feb 4, 1:31 pm, Kunjal kunjal.par...@gmail.com wrote:
When I look at the error.log for Apache server, It give me this:
Am I not Importing some modules?
Traceback (most recent call last):
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Django-1.1.1-py2.5.egg/django/core/handlers/base.py, line
92, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Django-1.1.1-py2.5.egg/django/views/decorators/cache.py,
line 44, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Djblets-0.5.5-py2.5.egg/djblets/webapi/decorators.py, line
59, in _checklogin
response = view_func(request, *args, **kwargs)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Django-1.1.1-py2.5.egg/django/views/decorators/http.py, line
37, in inner
return func(request, *args, **kwargs)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/webapi/json.py,
line 1178, in new_diff
form = UploadDiffForm(review_request.repository, form_data,
request.FILES)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
forms.py, line 44, in __init__
if self.repository.get_scmtool().get_diffs_use_absolute_paths():
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/scmtools/
models.py, line 43, in get_scmtool
return cls(self)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/scmtools/git.py,
line 23, in __init__
self.client = GitClient(repository.path)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/scmtools/git.py,
line 180, in __init__
raise ImportError
ImportError
ERROR:root:Exception thrown for user kaparikh
athttp://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/34/diff/new/
On Feb 3, 1:28 pm, Kunjal kunjal.par...@gmail.com wrote:
One more thing..
How to fix the issue of post-review can not find the branches
correctly?
As I mentioned you earlier, i have find/replace master branch to donut
in postreview.py to get to this point.
If I don't do that I get different set of errors.
Thanks for your help.
Kunjal
On Feb 2, 3:56 pm, Christian Hammond chip...@chipx86.com wrote:
Hmm okay, well at least it's talking to the server now. If you check your
server log file, you should be able to see some exception information that
says what's generated that 500 error. If not, then temporarily setting
DEBUG
= True in your site's conf/settings_local.py will display that exception
information in place of the 500 error. Either way, that should help to
figure out where it's failing and hopefully what's going wrong.
One thing that could be causing it, though, is your Review Board
repository
entry for your Git repository. Do you have it just referencing your remote
git:// URL, or is Path actually pointing to a local Git checkout? There's
no
concept of grabbing individual files from a remote Git repository, so you
need either a local clone accessible by Review Board, or if you're using
the
1.1/1.5 alphas/nightlies you can specify a special URL for checking out a
raw file from a Git web front-end such as cgit or gitweb.
Unless the Git guys someday extend the protocol to fetch an individual
file
by revision from an upstream repository without a local checkout, this is
the best we can do.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Tue, Feb 2, 2010 at 3:20 PM, Kunjal kunjal.par...@gmail.com wrote:
If i try with REVIEWBOARD_URL = 'None' (Below is the debug output)
It looks like the URL is correct now. But I am still getting error.
mob-rb-test{kaparikh}22: postreview.py -d
svn info
Re: Restricting access to Ship It checkbox
Thank you for your answer. I would like to respectfully disagree. What is the difference between the ship it checkbox and any other field in the review? There are specific permissions from changing the header, changing the diff, the text, etc, I think there is even a permission to say if people were allowed to post reviews or not. Why is the ship it button different? If this is a sociology problem, then why have permissions at all? Everything should be open, and people told what they are allowed to edit and not edit. We all know this does not work in the real world. Even with advance training and whatever, someone could check the box accidentally. Since there is no way a way to uncheck this box we want to limit its' exposure. We are working on cvs commit hook scripts, so checkin's cannot be made unless the referenced review has be marked ship it, so yes actually, a check-box *will* stop people from checking in code. :) On Feb 3, 5:18 pm, David Trowbridge trowb...@gmail.com wrote: In general we've avoided adding this sort of permissions and policy, since it adds a lot of UI complexity for what is essentially a sociology problem. We have a bug open requesting some sort of general policy set-up (while we try to figure out what that means), but I'd recommend that this is better enforced through training and management. If people are submitting code without the proper authorizations, then a check-box isn't going to stop them. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Using post-review outside of a working copy to upload a diff file
First off, I'm using svn on linux. Second, google seems to refuse to let me search this newsgroup (500: server error), so I apologize if this question has been asked before/recently. I'm attempting to use the post-review tool to upload diff files from outside a working copy. I tried to simply use the --diff-filename option, but this resulted in the complaint that my current directory doesn't contain a supported repository. Adding the --repository-url option complains that I'm required to specify a revision range. At this point I think post-review thinks I'm attempting to do a post- commit review because it seems to ignore my supplied diff file and try to generate its own based on the revision or revisions I supply to it. Is there no way to simply upload a diff and claim that it should apply to a certain directory as is done when using the web interface? Thanks for any help, -Luke -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Using post-review outside of a working copy to upload a diff file
Hi Luke, The --repository-url parameter was implemented for the purpose of post-commit support. It was also before the addition of --diff-filename (a very recent option). I'd be more than happy to have support for --diff-filename with --repository-url. We'll likely need a patch for it, though, as I won't have any time in the near future to implement it (will be out of town). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Feb 5, 2010 at 1:28 PM, LukeRobison lukerobi...@gmail.com wrote: First off, I'm using svn on linux. Second, google seems to refuse to let me search this newsgroup (500: server error), so I apologize if this question has been asked before/recently. I'm attempting to use the post-review tool to upload diff files from outside a working copy. I tried to simply use the --diff-filename option, but this resulted in the complaint that my current directory doesn't contain a supported repository. Adding the --repository-url option complains that I'm required to specify a revision range. At this point I think post-review thinks I'm attempting to do a post- commit review because it seems to ignore my supplied diff file and try to generate its own based on the revision or revisions I supply to it. Is there no way to simply upload a diff and claim that it should apply to a certain directory as is done when using the web interface? Thanks for any help, -Luke -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Is it possible to specify a change number/revision for an SVN repository when creating a review request via json?
Revisions are solely interpreted from the diff. So long as the files in the
diff reference the proper revisions, it should work.
Changesets are an entirely different thing. They're Perforce-only.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Fri, Feb 5, 2010 at 10:56 AM, Stodge sto...@gmail.com wrote:
Is it possible to specify a change number/revision for an SVN
repository when creating a review request via json? I'm guessing not
but I wanted to check.
ERROR:root:Exception thrown for user admin at
http://localhost:9900/reviews/api/json/reviewrequests/new/
Traceback (most recent call last):
File /usr/lib/python2.5/site-packages/django/core/handlers/
base.py, line 92, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File /usr/lib/python2.5/site-packages/django/views/decorators/
cache.py, line 44, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File /usr/lib/python2.5/site-packages/Djblets-0.5.6-py2.5.egg/
djblets/webapi/decorators.py, line 59, in _checklogin
response = view_func(request, *args, **kwargs)
File /usr/lib/python2.5/site-packages/django/views/decorators/
http.py, line 37, in inner
return func(request, *args, **kwargs)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/
reviewboard/webapi/json.py, line 439, in new_review_request
user, repository, request.POST.get('changenum', None))
File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/
reviewboard/reviews/managers.py, line 73, in create
review_request.update_from_changenum(changenum)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/
reviewboard/reviews/models.py, line 342, in update_from_changenum
update_obj_with_changenum(self, self.repository, changenum)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/
reviewboard/reviews/models.py, line 36, in update_obj_with_changenum
changeset = repository.get_scmtool().get_changeset(changenum)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.0.5.1-py2.5.egg/
reviewboard/scmtools/core.py, line 65, in get_changeset
raise NotImplementedError
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard Error while posting review for GIT
The nightlies of RBTools should be handling this a lot better. Is that what
you're running?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Feb 3, 2010 at 1:28 PM, Kunjal kunjal.par...@gmail.com wrote:
One more thing..
How to fix the issue of post-review can not find the branches
correctly?
As I mentioned you earlier, i have find/replace master branch to donut
in postreview.py to get to this point.
If I don't do that I get different set of errors.
Thanks for your help.
Kunjal
On Feb 2, 3:56 pm, Christian Hammond chip...@chipx86.com wrote:
Hmm okay, well at least it's talking to the server now. If you check your
server log file, you should be able to see some exception information
that
says what's generated that 500 error. If not, then temporarily setting
DEBUG
= True in your site's conf/settings_local.py will display that exception
information in place of the 500 error. Either way, that should help to
figure out where it's failing and hopefully what's going wrong.
One thing that could be causing it, though, is your Review Board
repository
entry for your Git repository. Do you have it just referencing your
remote
git:// URL, or is Path actually pointing to a local Git checkout? There's
no
concept of grabbing individual files from a remote Git repository, so you
need either a local clone accessible by Review Board, or if you're using
the
1.1/1.5 alphas/nightlies you can specify a special URL for checking out a
raw file from a Git web front-end such as cgit or gitweb.
Unless the Git guys someday extend the protocol to fetch an individual
file
by revision from an upstream repository without a local checkout, this is
the best we can do.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Tue, Feb 2, 2010 at 3:20 PM, Kunjal kunjal.par...@gmail.com wrote:
If i try with REVIEWBOARD_URL = 'None' (Below is the debug output)
It looks like the URL is correct now. But I am still getting error.
mob-rb-test{kaparikh}22: postreview.py -d
svn info
git rev-parse --git-dir
git svn info
git svn --version
git config --get svn-remote.svn.url
git remote show origin
repository info: Path: git://
mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git, Base
path: ,
Supports changesets: False
git config --get reviewboard.url
git diff --no-color --full-index donut
Looking for 'mob-rb-test.sj.broadcom.com /' cookie in
/home/kaparikh/.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request for None
_make_url: path = api/json/reviewrequests/new/
_make_url:app = /
_make_url: joined URL =
http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/
_make_url: Resulting URL =
http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/
HTTP POSTing to
http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/new/:
{'repository_path': 'git://
mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git'}
Review request created
Uploading diff, size: 867
_make_url: path = api/json/reviewrequests/30/diff/new/
_make_url:app = /
_make_url: joined URL =
http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/
_make_url: Resulting URL =
http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/
HTTP POSTing to
http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/
:
{}
!DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.0 Transitional//EN
http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd;
html xmlns=http://www.w3.org/1999/xhtml; xml:lang=en lang=en
head
title500 - Internal Server Error | Review Board/title
/head
body
h1Something broke! (Error 500)/h1
p
It appears something broke when you tried to go to here. This is
either
a bug in Review Board or a server configuration error. Please
report
this to your administrator.
/p
/body
/title
Unable to access
http://mob-rb-test.sj.broadcom.com/api/json/reviewrequests/30/diff/new/
.
The host path may be invalid
HTTP Error 500: Internal Server Error
####
Also, I get up to above error by replacing master branch to donut in
the post-review.py script.
If I do not change this, I get different error which is like:
[[
mob-rb-test{kaparikh}30: postreview.py -d
svn info
git rev-parse --git-dir
git svn info
git svn --version
git config --get svn-remote.svn.url
git remote show origin
repository info: Path: git://
mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git, Base
path: ,
Supports changesets: False
Re: ReviewBoard Error while posting review for GIT
I still need to see the repository Path field to be able to say what's going
on. Is it a remote path, or a local path on the filesystem? Git can only
operate on local paths.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Fri, Feb 5, 2010 at 11:05 AM, Kunjal kunjal.par...@gmail.com wrote:
It's failing here in git.py in scmtools folder.
class GitClient:
def __init__(self, path):
if not is_exe_in_path('git'):
# This is technically not the right kind of error, but
it's the
# pattern we use with all the other tools.
raise ImportError
self.path = path
p = subprocess.Popen(
['git', '--git-dir=%s' % self.path, 'config',
'core.repositoryformatversion'],
stderr=subprocess.PIPE,
stdout=subprocess.PIPE,
close_fds=(os.name != 'nt')
)
contents = p.stdout.read()
errmsg = p.stderr.read()
failure = p.wait()
if failure:
raise ImportError
On Feb 4, 1:31 pm, Kunjal kunjal.par...@gmail.com wrote:
When I look at the error.log for Apache server, It give me this:
Am I not Importing some modules?
Traceback (most recent call last):
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Django-1.1.1-py2.5.egg/django/core/handlers/base.py, line
92, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Django-1.1.1-py2.5.egg/django/views/decorators/cache.py,
line 44, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Djblets-0.5.5-py2.5.egg/djblets/webapi/decorators.py, line
59, in _checklogin
response = view_func(request, *args, **kwargs)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Django-1.1.1-py2.5.egg/django/views/decorators/http.py, line
37, in inner
return func(request, *args, **kwargs)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/webapi/json.py,
line 1178, in new_diff
form = UploadDiffForm(review_request.repository, form_data,
request.FILES)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/
forms.py, line 44, in __init__
if self.repository.get_scmtool().get_diffs_use_absolute_paths():
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/scmtools/
models.py, line 43, in get_scmtool
return cls(self)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/scmtools/git.py,
line 23, in __init__
self.client = GitClient(repository.path)
File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/scmtools/git.py,
line 180, in __init__
raise ImportError
ImportError
ERROR:root:Exception thrown for user kaparikh athttp://
mob-rb-test.sj.broadcom.com/api/json/reviewrequests/34/diff/new/
On Feb 3, 1:28 pm, Kunjal kunjal.par...@gmail.com wrote:
One more thing..
How to fix the issue of post-review can not find the branches
correctly?
As I mentioned you earlier, i have find/replace master branch to donut
in postreview.py to get to this point.
If I don't do that I get different set of errors.
Thanks for your help.
Kunjal
On Feb 2, 3:56 pm, Christian Hammond chip...@chipx86.com wrote:
Hmm okay, well at least it's talking to the server now. If you check
your
server log file, you should be able to see some exception information
that
says what's generated that 500 error. If not, then temporarily
setting DEBUG
= True in your site's conf/settings_local.py will display that
exception
information in place of the 500 error. Either way, that should help
to
figure out where it's failing and hopefully what's going wrong.
One thing that could be causing it, though, is your Review Board
repository
entry for your Git repository. Do you have it just referencing your
remote
git:// URL, or is Path actually pointing to a local Git checkout?
There's no
concept of grabbing individual files from a remote Git repository, so
you
need either a local clone accessible by Review Board, or if you're
using the
1.1/1.5 alphas/nightlies you can specify a special URL for checking
out a
raw file from a Git web front-end such as cgit or gitweb.
Unless the Git guys someday extend the protocol to fetch an
individual file
by revision from an upstream repository without a local checkout,
Re: Restricting access to Ship It checkbox
Hi Jennifer, The Ship It checkbox is part of a review, not a review request, and like all fields in a review, the reviewer has complete control over the contents. When a reviewer marks something as Ship It, that is his opinion. It's not necessarily approval for the code to be committed. What you're really wanting, I think, is some way to officially have someone approve code once it has been reviewed. This is where the sociology problem comes into play. This is handled differently in every organization. In some, lead developers have to approve it, even if other people give their opinion that it's ready to go in. In others, you need some number/percentage of Ship Its. In others, it's more loosely governed and the developer can commit when he gets Ship Its from people who know the code well enough, people who aren't wearing any particular hats. This is a complex thing for Review Board to just handle, and the Ship It mechanism is not flexible enough for it. It's a hint, and it's up to organizations to make use of it how they choose. David mentioned Policy support. I'll go into that briefly and let you know my thoughts. The idea is that, down the road, we'll have a way for administrators to create rules specifying who can do certain things, such as read code in parts of certain repositories, looked at review requests in certain groups only, make groups invite-only, and indicate what constitutes approval for code checkin. Note that in the last case there, the Ship It is not approval, or at least not the version today. Maybe we'll move to a thumbs up/down model of some sort to disambiguate Ship It. So, at that point, it'd be possible to query a review request and ask if the code is approved for going in. The review request won't be able to be marked as submitted until this approval is flagged. It would be up to organizations to specify the rules. Probably, we'd have some presets that can be chosen, and an expression editor for more advanced functionality. That's a ways off, though. Shorter-term, we're trying to get the 1.5 release out the door, and then the plan is to work on a 1.6 with some smaller features people have been asking for. We'd then be working on 2.0, which will have extension support (allowing for organizations to make their own additions to Review Board) and, hopefully, some form of policy. Since you're already writing a custom script for controlling whether code can go in, it might be worth at this point introducing your own policy support. Take into account the Ship Its and compare the reviewers based on those reviewers who are allowed to approve code. Sure, it won't be ideal, but it's probably the best you'll really be able to do short-term. Another possible option, which David and I would have to talk about, is to add a permission for allowing a user to mark code as Ship It. The problem that will need to be addressed is that of default permissions and retroactively setting permissions. While you likely want to only enable this for specific users, most places are content with allowing every user to specify Ship it. There's no mechanism today in either Review Board or Django for specifying defaults for permissions for users, so this would have to be written as well. Ends up becoming a slightly larger project Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Feb 5, 2010 at 11:42 AM, Jennifer quyr...@yahoo.com wrote: Thank you for your answer. I would like to respectfully disagree. What is the difference between the ship it checkbox and any other field in the review? There are specific permissions from changing the header, changing the diff, the text, etc, I think there is even a permission to say if people were allowed to post reviews or not. Why is the ship it button different? If this is a sociology problem, then why have permissions at all? Everything should be open, and people told what they are allowed to edit and not edit. We all know this does not work in the real world. Even with advance training and whatever, someone could check the box accidentally. Since there is no way a way to uncheck this box we want to limit its' exposure. We are working on cvs commit hook scripts, so checkin's cannot be made unless the referenced review has be marked ship it, so yes actually, a check-box *will* stop people from checking in code. :) On Feb 3, 5:18 pm, David Trowbridge trowb...@gmail.com wrote: In general we've avoided adding this sort of permissions and policy, since it adds a lot of UI complexity for what is essentially a sociology problem. We have a bug open requesting some sort of general policy set-up (while we try to figure out what that means), but I'd recommend that this is better enforced through training and management. If people are submitting code without the proper authorizations, then a check-box isn't going to stop them. -- Want to help
Re: RB review Process Automation
Are you storing and sending the cookie? We handle authentication persistence
by cookies, so you'd have to do this. If you're writing this in Python, take
a look at the CookieJar stuff in post-review.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Thu, Feb 4, 2010 at 11:21 PM, roshan pius roshanpiustho...@gmail.comwrote:
Hi Christian,
I'm not able to close the review through HTTP POST, it kept returning error
to login, even though i had logged in just before that.
I'm using a python script with simplejson to do this. I've tried logging in
as the user who submitted the review as well as the admin. But i'm not able
to close the review. Do i need to send any parameters for this HTTP post ?
Request to server: http://IPADDRESS/api/json/accounts/login/
Response from server: {'stat': 'ok'}
Closing the review for Reviewrequest 604...
Close review URL: reviewrequests/604/close/submitted
Request to server: http://
IPADDRESS/api/json/reviewrequests/604/close/submitted/
Response from server: {'stat': 'fail', 'err': {'msg': 'You are not logged
in', 'code': 103}}
Roshan Pius
On Thu, Feb 4, 2010 at 7:37 AM, roshan pius roshanpiustho...@gmail.comwrote:
Hi Kunjal,
Perforce has the p4 trigger(
http://www.perforce.com/perforce/doc.current/manuals/cmdref/triggers.html)
mechanism which can be used to run a script post-submission.
So if you want to close the review automatically you could run a script,
which would do the HTTP POST to
/api/json/reviewrequests/id/close/submitted/ as suggested by Christian.
Also if you use change-commit or change-submit triggers you would get
the original changelist numbers itself, before they are changed by Perforce
during submission.
We currently use the change-submit trigger to check the whether the
changelist was shipped before it can be submitted into Perforce.
Roshan Pius
On Thu, Feb 4, 2010 at 2:40 AM, Christian Hammond chip...@chipx86.comwrote:
It is available today. You can do an HTTP POST to
/api/json/reviewrequests/id/close/submitted/
So Kunjal, basically you can write a post-commit hook that automatically
closes the review request. It will require that there's some indication as
to which review request the change is associated with. In Perforce, the
change numbers will themselves change upon submit, but if you knew the
previous change number that was posted to Review Board, you could use the
/api/json/reviewrequests/repository/repositoryid/changenum/changenum/
call to get the info for the review request, pull the ID out of there, and
then use that to call the /close/submitted/ call above.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Feb 3, 2010 at 11:00 AM, Chris Clark chris.cl...@ingres.comwrote:
Kunjal wrote:
Once the Review is done, user has to make Review as Close-Submitted
eles reviewers dashboard will still have the review.
We enforce this process on developers and developers are saying that
this is one extra step.
I was thinking whether it is possible to close the review
automatically?
For example, for given Review, if the shipit_count is more then zero
then review is approved and we can close it.
Is there any way to do it programatically?
IMHO having shiptit mark as submitted would not be useful. Where we have
RB reployed Submitted means the code was submitted into source code
control (which is a semi-manual process). What we'd find useful would be a
json call (possibly called from postreview) to mark the review as submitted
(if this is already present please let me know).
Chris
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options,
Re: Git patchsets
Yes, it should work with 1.0.5.x. You should certainly be able to do the multiple patch thing today, though as Dan said, not elegantly. I think down the road we're going to want to look into patchset functionality. Internally, we already have a concept of a revisioned set of diffs (a DiffSetHistory). Today, a review request points to a single one of these, but in the future, we should be able to modify this so that it can point to more than one. The diff viewer would then allow switching between these. This would be a great Summer of Code project, actually. It's probably not all that difficult, though we'd need to figure out some backwards-compatibility issues, and make the API work well with it. I haven't given this much thought yet, but what I'm envisioning is that the diff viewer, when linking to multiple patchsets, would show a list of each one somewhere above the revision selector, and the user could specify which one to look at. Each patchset would be capable of having multiple revisions of diffs just like today (though I'm not entirely sure how useful this is -- maybe outside of the standard Git patchset model). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Feb 4, 2010 at 11:45 AM, Dan Savilonis d...@n-cube.org wrote: See the Distributed Version Control Systems section of: http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/ It's definitely available, and I believe it should work with git in 1.0.5.1, but TBH I've never run the stable version of RB. In a 3 patch series, for example, you'd submit the first patch directly, then the second patch with a parent diff of the first patch, then the third patch with a parent diff of the sum of the first two patches. Dan On Feb 4, 10:33 am, Stephen Gallagher karrde...@gmail.com wrote: On Feb 4, 10:20 am, Dan Savilonis d...@n-cube.org wrote: post-review can actually generate any arbitrary diff, not just a diff against HEAD. Make sure you're using the latest nightly build of rbtools for this functionality. It also supports a 'parent diff' mode where you can specify a parent of your diff set such that if you are submitting a series of patches not available in the server's repo, RB will still be able to understand how to generate the side-by-side diff. Can you point me at some documentation for the parent diff mode? I'd like to understand more about this. Is it available in the stable 1.0.5.1, or does it require the 1.1 alpha? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Django auth backend vs. ReviewBoard custom auth
That sounds quite ungood. Maybe try temporarily modifying your FasBackend to return None in get_or_create_user and in get_user. This *should* default it back to the built-in auth, I believe. I haven't tried it, though. How is your get_or_create_user and get_user handling not finding users in its backend? Maybe it's not allowing the default handler to be used. Is the code available to look at somewhere? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Feb 4, 2010 at 5:13 AM, Stephen Gallagher karrde...@gmail.comwrote: I have specified 'fedora.django.auth.backends.FasBackend' in the custom auth field. Once I hit Save, I can no longer log in as ANY user, neither from the FasBackend nor the built-in admin account. I see no errors in the Apache error_log. Any advice on how to track the problem? Running in 'manage.py runserver' gives no error messages either. On Feb 3, 4:07 pm, Christian Hammond chip...@chipx86.com wrote: Hi Stephen, Review Board can use custom Django auth backends by specifying the full module path in the Custom Authentication section in General Settings in the administration UI. Review Board will use that auth backend as the primary and fall back on the built-in authentication for existing accounts (so that your administration account will still work if your auth backend is broken). You shouldn't need to modify any code to make this work. Seehttp:// www.reviewboard.org/docs/manual/dev/admin/admin-ui/authenticat... Note that in 1.0.x, these are in General Settings, but in the upcoming 1.5 release, they're in their own settings page. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Wed, Feb 3, 2010 at 11:32 AM, Stephen Gallagher karrde...@gmail.com wrote: I'm trying to adapt a Django authentication backend to work with ReviewBoard (specifically https://fedorahosted.org/releases/p/y/python-fedora/doc/django.html) Is there a guide anywhere on how to convert a Django auth backend to a ReviewBoard backend? Or a guide on how to properly use a Django auth backend with ReviewBoard? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Using post-review outside of a working copy to upload a diff file
Patch submitted as http://reviews.reviewboard.org/r/1393/ The change was almost too simple. I only updated documentation and changed the logic that verifies the options have been specified correctly. -Luke On Feb 5, 4:12 pm, Christian Hammond chip...@chipx86.com wrote: Hi Luke, The --repository-url parameter was implemented for the purpose of post-commit support. It was also before the addition of --diff-filename (a very recent option). I'd be more than happy to have support for --diff-filename with --repository-url. We'll likely need a patch for it, though, as I won't have any time in the near future to implement it (will be out of town). Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Fri, Feb 5, 2010 at 1:28 PM, LukeRobison lukerobi...@gmail.com wrote: First off, I'm using svn on linux. Second, google seems to refuse to let me search this newsgroup (500: server error), so I apologize if this question has been asked before/recently. I'm attempting to use the post-review tool to upload diff files from outside a working copy. I tried to simply use the --diff-filename option, but this resulted in the complaint that my current directory doesn't contain a supported repository. Adding the --repository-url option complains that I'm required to specify a revision range. At this point I think post-review thinks I'm attempting to do a post- commit review because it seems to ignore my supplied diff file and try to generate its own based on the revision or revisions I supply to it. Is there no way to simply upload a diff and claim that it should apply to a certain directory as is done when using the web interface? Thanks for any help, -Luke -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB review Process Automation
One of the many things on my todo-but-never-get-to-it list is to add
close/submit support to postreview.
Roshan, if I was in your shoes I'd extend postreview to do what you want.
postreview already has the plumbing in place for auth and talking to the
RB server, admittedly postreview is really for posting code so this is
changing the behavior slightly. I think it does fit into what postreview
is used for, tying in working copies to reviews.
If you do this, I'd love to get a copy :-)
Chris
Christian Hammond wrote:
Are you storing and sending the cookie? We handle authentication
persistence by cookies, so you'd have to do this. If you're writing
this in Python, take a look at the CookieJar stuff in post-review.
Christian
--
Christian Hammond - chip...@chipx86.com mailto:chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Thu, Feb 4, 2010 at 11:21 PM, roshan pius
roshanpiustho...@gmail.com mailto:roshanpiustho...@gmail.com wrote:
Hi Christian,
I'm not able to close the review through HTTP POST, it kept
returning error to login, even though i had logged in just before
that.
I'm using a python script with simplejson to do this. I've tried
logging in as the user who submitted the review as well as the
admin. But i'm not able to close the review. Do i need to send any
parameters for this HTTP post ?
Request to server: http://IPADDRESS/api/json/accounts/login/
Response from server: {'stat': 'ok'}
Closing the review for Reviewrequest 604...
Close review URL: reviewrequests/604/close/submitted
Request to server:
http://IPADDRESS/api/json/reviewrequests/604/close/submitted/
Response from server: {'stat': 'fail', 'err': {'msg': 'You are not
logged in', 'code': 103}}
Roshan Pius
On Thu, Feb 4, 2010 at 7:37 AM, roshan pius
roshanpiustho...@gmail.com mailto:roshanpiustho...@gmail.com
wrote:
Hi Kunjal,
Perforce has the p4
trigger(http://www.perforce.com/perforce/doc.current/manuals/cmdref/triggers.html)
mechanism which can be used to run a script post-submission.
So if you want to close the review automatically you could run
a script, which would do the HTTP POST to
/api/json/reviewrequests/id/close/submitted/ as suggested by
Christian.
Also if you use change-commit or change-submit triggers
you would get the original changelist numbers itself, before
they are changed by Perforce during submission.
We currently use the change-submit trigger to check the
whether the changelist was shipped before it can be
submitted into Perforce.
Roshan Pius
On Thu, Feb 4, 2010 at 2:40 AM, Christian Hammond
chip...@chipx86.com mailto:chip...@chipx86.com wrote:
It is available today. You can do an HTTP POST to
/api/json/reviewrequests/id/close/submitted/
So Kunjal, basically you can write a post-commit hook that
automatically closes the review request. It will require
that there's some indication as to which review request
the change is associated with. In Perforce, the change
numbers will themselves change upon submit, but if you
knew the previous change number that was posted to Review
Board, you could use the
/api/json/reviewrequests/repository/repositoryid/changenum/changenum/
call to get the info for the review request, pull the ID
out of there, and then use that to call the
/close/submitted/ call above.
Christian
--
Christian Hammond - chip...@chipx86.com
mailto:chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Feb 3, 2010 at 11:00 AM, Chris Clark
chris.cl...@ingres.com mailto:chris.cl...@ingres.com
wrote:
Kunjal wrote:
Once the Review is done, user has to make Review
as Close-Submitted
eles reviewers dashboard will still have the review.
We enforce this process on developers and
developers are saying that
this is one extra step.
I was thinking whether it is possible to close the
review
automatically?
For example, for given Review, if the shipit_count
is more then zero
then review is approved and we can close it.
Is there any way to do it programatically?
IMHO having shiptit mark as submitted would not be
useful. Where we have RB reployed Submitted means
Re: RB review Process Automation
I'd be fine with this.
What I really want to do after we finally get this version of RBTools
finalized and out the door is to start splitting post-review into lots of
little utility apps, and a Python API. I want to do it Git-style, where
there's a central rb command with subcommands backed by programs. So users
could write their own rb-foo and just execute with rb foo and get all the
plumbing for free.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Fri, Feb 5, 2010 at 3:20 PM, Chris Clark chris.cl...@ingres.com wrote:
One of the many things on my todo-but-never-get-to-it list is to add
close/submit support to postreview.
Roshan, if I was in your shoes I'd extend postreview to do what you want.
postreview already has the plumbing in place for auth and talking to the RB
server, admittedly postreview is really for posting code so this is changing
the behavior slightly. I think it does fit into what postreview is used for,
tying in working copies to reviews.
If you do this, I'd love to get a copy :-)
Chris
Christian Hammond wrote:
Are you storing and sending the cookie? We handle authentication
persistence by cookies, so you'd have to do this. If you're writing this in
Python, take a look at the CookieJar stuff in post-review.
Christian
--
Christian Hammond - chip...@chipx86.com mailto:chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Thu, Feb 4, 2010 at 11:21 PM, roshan pius
roshanpiustho...@gmail.commailto:
roshanpiustho...@gmail.com wrote:
Hi Christian,
I'm not able to close the review through HTTP POST, it kept
returning error to login, even though i had logged in just before
that.
I'm using a python script with simplejson to do this. I've tried
logging in as the user who submitted the review as well as the
admin. But i'm not able to close the review. Do i need to send any
parameters for this HTTP post ?
Request to server: http://IPADDRESS/api/json/accounts/login/
Response from server: {'stat': 'ok'}
Closing the review for Reviewrequest 604...
Close review URL: reviewrequests/604/close/submitted
Request to server:
http://IPADDRESS/api/json/reviewrequests/604/close/submitted/
Response from server: {'stat': 'fail', 'err': {'msg': 'You are not
logged in', 'code': 103}}
Roshan Pius
On Thu, Feb 4, 2010 at 7:37 AM, roshan pius
roshanpiustho...@gmail.com mailto:roshanpiustho...@gmail.com
wrote:
Hi Kunjal,
Perforce has the p4
trigger(
http://www.perforce.com/perforce/doc.current/manuals/cmdref/triggers.html
)
mechanism which can be used to run a script post-submission.
So if you want to close the review automatically you could run
a script, which would do the HTTP POST to
/api/json/reviewrequests/id/close/submitted/ as suggested by
Christian.
Also if you use change-commit or change-submit triggers
you would get the original changelist numbers itself, before
they are changed by Perforce during submission.
We currently use the change-submit trigger to check the
whether the changelist was shipped before it can be
submitted into Perforce.
Roshan Pius
On Thu, Feb 4, 2010 at 2:40 AM, Christian Hammond
chip...@chipx86.com mailto:chip...@chipx86.com wrote:
It is available today. You can do an HTTP POST to
/api/json/reviewrequests/id/close/submitted/
So Kunjal, basically you can write a post-commit hook that
automatically closes the review request. It will require
that there's some indication as to which review request
the change is associated with. In Perforce, the change
numbers will themselves change upon submit, but if you
knew the previous change number that was posted to Review
Board, you could use the
/api/json/reviewrequests/repository/repositoryid/changenum/changenum/
call to get the info for the review request, pull the ID
out of there, and then use that to call the
/close/submitted/ call above.
Christian
--Christian Hammond - chip...@chipx86.com
mailto:chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Feb 3, 2010 at 11:00 AM, Chris Clark
chris.cl...@ingres.com mailto:chris.cl...@ingres.com
wrote:
Kunjal wrote:
Once the Review is done, user has to make Review
as Close-Submitted
eles reviewers dashboard will still have the review.
We enforce this process on developers and
Re: About Installation of Reviewboard
Hi, rb-site doesn't remember any of these values, so you can't reconfigure this way. However, it all really just boils down to making the initial directory structure and then writing conf/settings_local.py. So you can modify this file for any of your new settings. You'd want to see the Django documentation on these settings. The web server configuration, however, would probably require installing into a different location temporarily, taking the generated config file, modifying it for the old paths, and using that. There's no way today to just have it create a new web server config file. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Feb 3, 2010 at 5:41 PM, JohnHenry qhlonl...@163.com wrote: Hi, all. The reviewboard installation process is to run 'rb-site install path' , Then we will specify some parameters like 'Domain Name' 'DataBase Type' 'Cache Type' 'Webserver' ... . I want to konw, If I had finished the RB install and had used it for some time, Can I change those settings? and How? For example, Our installation did not install memcache, So we specify the 'Cache Type' as file type. But when We had used it for some time, We want speed up accession, So we used memcache, We want to change this settings then. Other settings, If we want change webserver, change database , and so on. How to do this, Do we need to reinstall the rb-site? Best Regards! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Active Directory form is disabled
Hi Jan, It doesn't tell you that there's a missing dependency or anything? You will need the ldap and PyDNS modules installed to use it. Make sure to restart Apache after installing those. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Feb 3, 2010 at 8:44 AM, Jan Koprowski jan.koprow...@gmail.comwrote: Hi ! How I can edit my ActiveDirectory settings? When I enter to this section i just get gray, disabled form. What modules needed? Greetings from Poland! -- Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
