Re: Custom post-review implementations making them easier proposal
For one, I would be interested. We use Bazaar and and have been slowly trying to intergrate ReviewBoard in our system. I looked into the post-review and it does not seem to support Bazaar. I have already extended it using the Mercurial example and override two or three methods that the Mercurial component did. I plan to soon post my changes for Bazaar once I can verify that my code actually works :) On Tue, Jun 2, 2009 at 1:56 PM, Chris Clark wrote: > > If you want to deploy post-review with some site specific customizations > (e.g. add support for a custom in house SCM) there are only a few options: > > * Privately fork post-review and try and sync all the changes that > occur in "trunk" into your version > * add a wrapper script around post-review, e.g. rename post-review > to postreview.py (python does not allow hypens "-" in > module/library names), import postreview in your tool and then > monkey patch in your changes. The rename can be handled in > setup.py when "building" > > Neither solution is optimal but this is the price you pay if you want > private custom versions :-( > > I don't have a solution to the above but I have some ideas on making it > suck slightly less by making either option easier to deal with. For > instance take the case where one needs to add in support for a custom > SCM. You need to add a new class (subclassed from SCMClient) and then > modify determine_client() to add it to the list of SCM's. > > * With the forked approach you have to edit determine_client(). > * With the wrapper approach you have to copy the existing > determine_client() into your wrapper, modify it then monkey patch > the original. > > Either way you have to be prepared to follow the trunk version in case > determine_client() changes. > > What do people think of the following ideas: > > 1) move the tuple of SCM clients into a global variable. > E.g. instead of: > > # Try to find the SCM Client we're going to be working with. > for tool in (SVNClient(), CVSClient(), GitClient(), MercurialClient(), > PerforceClient(), ClearCaseClient()): > > Have: > > > scm_tuple=(SVNClient(), CVSClient(), GitClient(), MercurialClient(), > PerforceClient(), ClearCaseClient()) > > def determine_client(): > > # Try to find the SCM Client we're going to be working with. > for tool in scm_tuple: > > > This makes monkey patching the list easier, you just update the global > from outside. > > 2) modify the trunk version of post-review to change the formatting that > is used in the tuple (list) of SCM clients to make it easier to edit the > list. E.g.: > > scm_tuple=( > SVNClient(), > CVSClient(), > GitClient(), > MercurialClient(), > PerforceClient(), > ClearCaseClient(), > ) > > This makes it easier to modify the code if you decide to fork the > script. You can re-order, add, or remove very easily. Diffs show up very > clearly. > > Does this appeal to anyone? #1 above would make my life easier. I wanted > to get a feel from a wide audience before posting a for patch for review > where it may not be seen by so many people. > > Chris > > > > > -- Ritesh http://www.riteshn.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Sending review emails and peculiar error
Just as an update I was able to finally figure out the issue. So my thunderbird is configured to use SSL/TLS on port 465 (I must have put this values looking into GMail docs). Putting the same value in RB gave me error as you know. Doing more research I found out: http://sial.org/howto/openssl/tls-name/ and http://kutuma.blogspot.com/2007/08/sending-emails-via-gmail-with-python.html. So looks like we might be using starttls. Thus just changing the port to 587 and everything now works. On Sat, Apr 25, 2009 at 1:39 PM, Christian Hammond wrote: > Hmm, I don't know. Perhaps GMail is doing some kind of sender verification, > and that's preventing the e-mails from being sent. Unless your internal > e-mail addresses can't be reached from an external server. You may just need > a local SMTP server. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.review-board.org > VMware, Inc. - http://www.vmware.com > > > On Fri, Apr 24, 2009 at 12:22 PM, Ritesh Nadhani wrote: >> >> Alright, finally I got some more time off work to review it. >> >> Not sure what is the problem. If I give incorrect SMTP details, >> reviewboard fails with the exception: >> >> Traceback: >> File >> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/core/handlers/base.py" >> in get_response >> 86. response = callback(request, *callback_args, >> **callback_kwargs) >> File >> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/views/decorators/cache.py" >> in _wrapped_view_func >> 44. response = view_func(request, *args, **kwargs) >> File >> "/usr/lib/python2.5/site-packages/Djblets-0.5beta1-py2.5.egg/djblets/webapi/decorators.py" >> in _checklogin >> 32. response = view_func(request, *args, **kwargs) >> File >> "/usr/lib/python2.5/site-packages/ReviewBoard-1.0beta2-py2.5.egg/reviewboard/webapi/json.py" >> in review_request_publish >> 493. review_request.publish(request.user) >> File >> "/usr/lib/python2.5/site-packages/ReviewBoard-1.0beta2-py2.5.egg/reviewboard/reviews/models.py" >> in publish >> 458. mail_review_request(user, self, changes) >> File >> "/usr/lib/python2.5/site-packages/ReviewBoard-1.0beta2-py2.5.egg/reviewboard/reviews/email.py" >> in mail_review_request >> 184. extra_context) >> File >> "/usr/lib/python2.5/site-packages/ReviewBoard-1.0beta2-py2.5.egg/reviewboard/reviews/email.py" >> in send_review_mail >> 114. message.send() >> File >> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/core/mail.py" >> in send >> 271. return >> self.get_connection(fail_silently).send_messages([self]) >> File >> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/core/mail.py" >> in send_messages >> 166. new_conn_created = self.open() >> File >> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/core/mail.py" >> in open >> 131. >> local_hostname=DNS_NAME.get_fqdn()) >> File "/usr/lib/python2.5/smtplib.py" in __init__ >> 244. (code, msg) = self.connect(host, port) >> File "/usr/lib/python2.5/smtplib.py" in connect >> 310. raise socket.error, msg >> >> Exception Type: error at /api/json/reviewrequests/8/publish/ >> Exception Value: (111, 'Connection refused') >> >> So that means the mailing module is being called. >> >> When I give right details, it just succeeds without any error...but >> the mail is never delivered? >> >> On Tue, Apr 14, 2009 at 2:06 PM, Ritesh Nadhani wrote: >> > Thanks Christian for all the inputs. >> > >> > I will work on it this after work later today and will try to find out >> > problems on my side. There has to be something stupid going on my side >> > as I believe people have been using RB without any problem :) >> > >> > Yes, I can also try with an internal server. Will come back with >> > feedback soon. >> > >> > On Tue, Apr 14, 2009 at 1:40 PM, Christian Hammond >> > wrote: >> >> It looks like your configuration is set up to log server >> >> connections/errors >> >> to an SQL database, and it's not configured correctly. So that's what >> >> most >> >> of those errors are. I don't see anything in there that would tell
cmemcache dosnt work but normal file does
Hello So I setup a review site with memcache settings. Reading: http://www.review-board.org/docs/manual/dev/admin/installation/linux/, I got it installed but when I go to view diff - the , it fails. If I just use file based caching, then I can see the diff. On closer inspection, after cleanly installing the latest cmemcache i.e 0.95, I run its test suite: ~/Downloads/cmemcache-0.95$ python test.py ip 127.0.0.1 port 11211 memcached not running, starting one (pid 26577) testing version $Revision: 431 $ from [not...@1240607505.466746] mcm_storage_cmd():3339: unable to store value: Operation now in progress: add [not...@1240607505.466885] mcm_storage_cmd():3339: unable to store value: Operation now in progress: replace [w...@1240607505.467494] mcm_server_stats():3027: unknown stat variable: pointer_size F == FAIL: test_memcache (__main__.TestCmemcache) -- Traceback (most recent call last): File "test.py", line 254, in test_memcache self._test_base(cmemcache, cmemcache.StringClient(self.servers), ok=1) File "test.py", line 132, in _test_base self.failUnlessEqual(len(stats), 1) AssertionError: 0 != 1 -- Ran 1 test in 0.507s FAILED (failures=1) So something wrong with my installation of memcache? Any suggested version? Configuring the logging settings, I get this in my log: 2009-04-24 14:25:19,444 - INFO - Log file for Review Board v1.0beta2 2009-04-24 14:25:19,582 - DEBUG - Generating diff viewer page for filediff id 2 2009-04-24 14:25:19,583 - DEBUG - Begin: Generating diff file info for diffset id 2 2009-04-24 14:25:19,585 - DEBUG - End: Generating diff file info for diffset id 2 2009-04-24 14:25:19,585 - DEBUG - Generating diff file info for diffset id 2 took 0.2107 seconds 2009-04-24 14:25:19,587 - DEBUG - Begin: Generating diff file info for diffset id 2, filediff 2 2009-04-24 14:25:19,588 - INFO - Cache miss for key 127.0.0.1:diff-sidebyside-hl-2. -- Ritesh http://www.riteshn.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Sending review emails and peculiar error
Surprisingly though, I am able to send mails using Thunderbird and same settings. On Fri, Apr 24, 2009 at 12:22 PM, Ritesh Nadhani wrote: > Alright, finally I got some more time off work to review it. > > Not sure what is the problem. If I give incorrect SMTP details, > reviewboard fails with the exception: > > Traceback: > File > "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/core/handlers/base.py" > in get_response > 86. response = callback(request, *callback_args, > **callback_kwargs) > File > "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/views/decorators/cache.py" > in _wrapped_view_func > 44. response = view_func(request, *args, **kwargs) > File > "/usr/lib/python2.5/site-packages/Djblets-0.5beta1-py2.5.egg/djblets/webapi/decorators.py" > in _checklogin > 32. response = view_func(request, *args, **kwargs) > File > "/usr/lib/python2.5/site-packages/ReviewBoard-1.0beta2-py2.5.egg/reviewboard/webapi/json.py" > in review_request_publish > 493. review_request.publish(request.user) > File > "/usr/lib/python2.5/site-packages/ReviewBoard-1.0beta2-py2.5.egg/reviewboard/reviews/models.py" > in publish > 458. mail_review_request(user, self, changes) > File > "/usr/lib/python2.5/site-packages/ReviewBoard-1.0beta2-py2.5.egg/reviewboard/reviews/email.py" > in mail_review_request > 184. extra_context) > File > "/usr/lib/python2.5/site-packages/ReviewBoard-1.0beta2-py2.5.egg/reviewboard/reviews/email.py" > in send_review_mail > 114. message.send() > File > "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/core/mail.py" > in send > 271. return self.get_connection(fail_silently).send_messages([self]) > File > "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/core/mail.py" > in send_messages > 166. new_conn_created = self.open() > File > "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/core/mail.py" > in open > 131. > local_hostname=DNS_NAME.get_fqdn()) > File "/usr/lib/python2.5/smtplib.py" in __init__ > 244. (code, msg) = self.connect(host, port) > File "/usr/lib/python2.5/smtplib.py" in connect > 310. raise socket.error, msg > > Exception Type: error at /api/json/reviewrequests/8/publish/ > Exception Value: (111, 'Connection refused') > > So that means the mailing module is being called. > > When I give right details, it just succeeds without any error...but > the mail is never delivered? > > On Tue, Apr 14, 2009 at 2:06 PM, Ritesh Nadhani wrote: >> Thanks Christian for all the inputs. >> >> I will work on it this after work later today and will try to find out >> problems on my side. There has to be something stupid going on my side >> as I believe people have been using RB without any problem :) >> >> Yes, I can also try with an internal server. Will come back with feedback >> soon. >> >> On Tue, Apr 14, 2009 at 1:40 PM, Christian Hammond >> wrote: >>> It looks like your configuration is set up to log server connections/errors >>> to an SQL database, and it's not configured correctly. So that's what most >>> of those errors are. I don't see anything in there that would tell us more >>> here. >>> >>> Generally, if your e-mail address is set for the administrator contact info >>> in General Settings, and DEBUG is False, you would receive an e-mail with >>> the error info. But of course that implies that you have e-mail working :) >>> The other method is to set DEBUG to True and then click the button on that >>> error banner for seeing more info, but if the page is jumping away, that >>> won't work so well. >>> >>> I don't have a working solution off-hand that I can recommend. I'll give it >>> some thought. >>> >>> Is there another e-mail server you can use that's internal? >>> >>> Christian >>> >>> -- >>> Christian Hammond - chip...@chipx86.com >>> Review Board - http://www.review-board.org >>> VMware, Inc. - http://www.vmware.com >>> >>> >>> On Tue, Apr 14, 2009 at 10:08 AM, Ritesh Nadhani wrote: >>>> >>>> Hello >>>> >>>> On Mon, Apr 13, 2009 at 7:40 PM, Christian Hammond >>>> wrote: >>>> > The e-mail settings being lost sounds like an iss
Re: Sending review emails and peculiar error
Alright, finally I got some more time off work to review it. Not sure what is the problem. If I give incorrect SMTP details, reviewboard fails with the exception: Traceback: File "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/core/handlers/base.py" in get_response 86. response = callback(request, *callback_args, **callback_kwargs) File "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/views/decorators/cache.py" in _wrapped_view_func 44. response = view_func(request, *args, **kwargs) File "/usr/lib/python2.5/site-packages/Djblets-0.5beta1-py2.5.egg/djblets/webapi/decorators.py" in _checklogin 32. response = view_func(request, *args, **kwargs) File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0beta2-py2.5.egg/reviewboard/webapi/json.py" in review_request_publish 493. review_request.publish(request.user) File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0beta2-py2.5.egg/reviewboard/reviews/models.py" in publish 458. mail_review_request(user, self, changes) File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0beta2-py2.5.egg/reviewboard/reviews/email.py" in mail_review_request 184. extra_context) File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0beta2-py2.5.egg/reviewboard/reviews/email.py" in send_review_mail 114. message.send() File "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/core/mail.py" in send 271. return self.get_connection(fail_silently).send_messages([self]) File "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/core/mail.py" in send_messages 166. new_conn_created = self.open() File "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/core/mail.py" in open 131. local_hostname=DNS_NAME.get_fqdn()) File "/usr/lib/python2.5/smtplib.py" in __init__ 244. (code, msg) = self.connect(host, port) File "/usr/lib/python2.5/smtplib.py" in connect 310. raise socket.error, msg Exception Type: error at /api/json/reviewrequests/8/publish/ Exception Value: (111, 'Connection refused') So that means the mailing module is being called. When I give right details, it just succeeds without any error...but the mail is never delivered? On Tue, Apr 14, 2009 at 2:06 PM, Ritesh Nadhani wrote: > Thanks Christian for all the inputs. > > I will work on it this after work later today and will try to find out > problems on my side. There has to be something stupid going on my side > as I believe people have been using RB without any problem :) > > Yes, I can also try with an internal server. Will come back with feedback > soon. > > On Tue, Apr 14, 2009 at 1:40 PM, Christian Hammond > wrote: >> It looks like your configuration is set up to log server connections/errors >> to an SQL database, and it's not configured correctly. So that's what most >> of those errors are. I don't see anything in there that would tell us more >> here. >> >> Generally, if your e-mail address is set for the administrator contact info >> in General Settings, and DEBUG is False, you would receive an e-mail with >> the error info. But of course that implies that you have e-mail working :) >> The other method is to set DEBUG to True and then click the button on that >> error banner for seeing more info, but if the page is jumping away, that >> won't work so well. >> >> I don't have a working solution off-hand that I can recommend. I'll give it >> some thought. >> >> Is there another e-mail server you can use that's internal? >> >> Christian >> >> -- >> Christian Hammond - chip...@chipx86.com >> Review Board - http://www.review-board.org >> VMware, Inc. - http://www.vmware.com >> >> >> On Tue, Apr 14, 2009 at 10:08 AM, Ritesh Nadhani wrote: >>> >>> Hello >>> >>> On Mon, Apr 13, 2009 at 7:40 PM, Christian Hammond >>> wrote: >>> > The e-mail settings being lost sounds like an issue we just fixed in a >>> > nightly. If you set the e-mail settings and then restart your web >>> > server, do >>> > they still disappear? >>> >>> Interestingly no. I restarted Apache couple of times and it kept the >>> record. Though after submitting 3-4 times, it loses it. Probably, >>> fixed in the nightly. >>> >>> So how do I go about testing it? Should I just get the SVN and do - >>> sudo setup.py install or do I have to upgrade the site also? >>> >>> This is a test machine so I
Re: Sending review emails and peculiar error
Thanks Christian for all the inputs. I will work on it this after work later today and will try to find out problems on my side. There has to be something stupid going on my side as I believe people have been using RB without any problem :) Yes, I can also try with an internal server. Will come back with feedback soon. On Tue, Apr 14, 2009 at 1:40 PM, Christian Hammond wrote: > It looks like your configuration is set up to log server connections/errors > to an SQL database, and it's not configured correctly. So that's what most > of those errors are. I don't see anything in there that would tell us more > here. > > Generally, if your e-mail address is set for the administrator contact info > in General Settings, and DEBUG is False, you would receive an e-mail with > the error info. But of course that implies that you have e-mail working :) > The other method is to set DEBUG to True and then click the button on that > error banner for seeing more info, but if the page is jumping away, that > won't work so well. > > I don't have a working solution off-hand that I can recommend. I'll give it > some thought. > > Is there another e-mail server you can use that's internal? > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.review-board.org > VMware, Inc. - http://www.vmware.com > > > On Tue, Apr 14, 2009 at 10:08 AM, Ritesh Nadhani wrote: >> >> Hello >> >> On Mon, Apr 13, 2009 at 7:40 PM, Christian Hammond >> wrote: >> > The e-mail settings being lost sounds like an issue we just fixed in a >> > nightly. If you set the e-mail settings and then restart your web >> > server, do >> > they still disappear? >> >> Interestingly no. I restarted Apache couple of times and it kept the >> record. Though after submitting 3-4 times, it loses it. Probably, >> fixed in the nightly. >> >> So how do I go about testing it? Should I just get the SVN and do - >> sudo setup.py install or do I have to upgrade the site also? >> >> This is a test machine so I can play around with stuff. >> >> > >> > It's hard to say what's wrong with your e-mail settings. Can you check >> > your >> > web server's error log and see if there's any backtraces? >> > >> >> Hmm, for some reason - the error message stayed for one second longer >> and it seemed to be some server error. >> >> tail -f /var/log/apache2/error.log >> [Tue Apr 14 10:05:45 2009] [error] mod_log_sql: child spawned but >> unable to open database link >> [Tue Apr 14 10:05:45 2009] [error] mod_log_sql: insufficient >> configuration info to establish database link >> [Tue Apr 14 10:05:45 2009] [error] mod_log_sql: child spawned but >> unable to open database link >> [Tue Apr 14 10:05:45 2009] [error] mod_log_sql: insufficient >> configuration info to establish database link >> [Tue Apr 14 10:05:45 2009] [error] mod_log_sql: child spawned but >> unable to open database link >> [Tue Apr 14 10:05:45 2009] [error] mod_log_sql: insufficient >> configuration info to establish database link >> [Tue Apr 14 10:05:45 2009] [error] mod_log_sql: child spawned but >> unable to open database link >> [Tue Apr 14 10:05:45 2009] [notice] Apache/2.2.8 (Ubuntu) >> mod_python/3.3.1 Python/2.5.2 PHP/5.2.4-2ubuntu5.5 with Suhosin-Patch >> configured -- resuming normal operations >> [Tue Apr 14 10:06:02 2009] [error] mod_log_sql: insufficient >> configuration info to establish database link >> [Tue Apr 14 10:06:02 2009] [error] mod_log_sql: child spawned but >> unable to open database link >> >> Does that help? I dont know how it can be database error because it >> seems to be the storing the data correctly. >> >> > Christian >> > >> > -- >> > Christian Hammond - chip...@chipx86.com >> > Review Board - http://www.review-board.org >> > VMware, Inc. - http://www.vmware.com >> > >> > >> > On Mon, Apr 13, 2009 at 4:07 PM, Ritesh Nadhani >> > wrote: >> >> >> >> Hello >> >> >> >> So I created 3 users and added them to default reviewer group. I then >> >> went to Admin section and added the Email settings. I added my gmail >> >> settings and checking use TLS authentication. >> >> >> >> According to docs at >> >> >> >> >> >> http://www.review-board.org/docs/manual/dev/admin/management/review-groups/#e-mail-and-review-groups, >> >> since I dont have any mailing list
Re: Sending review emails and peculiar error
Hello On Mon, Apr 13, 2009 at 7:40 PM, Christian Hammond wrote: > The e-mail settings being lost sounds like an issue we just fixed in a > nightly. If you set the e-mail settings and then restart your web server, do > they still disappear? Interestingly no. I restarted Apache couple of times and it kept the record. Though after submitting 3-4 times, it loses it. Probably, fixed in the nightly. So how do I go about testing it? Should I just get the SVN and do - sudo setup.py install or do I have to upgrade the site also? This is a test machine so I can play around with stuff. > > It's hard to say what's wrong with your e-mail settings. Can you check your > web server's error log and see if there's any backtraces? > Hmm, for some reason - the error message stayed for one second longer and it seemed to be some server error. tail -f /var/log/apache2/error.log [Tue Apr 14 10:05:45 2009] [error] mod_log_sql: child spawned but unable to open database link [Tue Apr 14 10:05:45 2009] [error] mod_log_sql: insufficient configuration info to establish database link [Tue Apr 14 10:05:45 2009] [error] mod_log_sql: child spawned but unable to open database link [Tue Apr 14 10:05:45 2009] [error] mod_log_sql: insufficient configuration info to establish database link [Tue Apr 14 10:05:45 2009] [error] mod_log_sql: child spawned but unable to open database link [Tue Apr 14 10:05:45 2009] [error] mod_log_sql: insufficient configuration info to establish database link [Tue Apr 14 10:05:45 2009] [error] mod_log_sql: child spawned but unable to open database link [Tue Apr 14 10:05:45 2009] [notice] Apache/2.2.8 (Ubuntu) mod_python/3.3.1 Python/2.5.2 PHP/5.2.4-2ubuntu5.5 with Suhosin-Patch configured -- resuming normal operations [Tue Apr 14 10:06:02 2009] [error] mod_log_sql: insufficient configuration info to establish database link [Tue Apr 14 10:06:02 2009] [error] mod_log_sql: child spawned but unable to open database link Does that help? I dont know how it can be database error because it seems to be the storing the data correctly. > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.review-board.org > VMware, Inc. - http://www.vmware.com > > > On Mon, Apr 13, 2009 at 4:07 PM, Ritesh Nadhani wrote: >> >> Hello >> >> So I created 3 users and added them to default reviewer group. I then >> went to Admin section and added the Email settings. I added my gmail >> settings and checking use TLS authentication. >> >> According to docs at >> >> http://www.review-board.org/docs/manual/dev/admin/management/review-groups/#e-mail-and-review-groups, >> since I dont have any mailing list attached to the repository so it >> will send mail to everybody in the review board. >> >> After doing the email settings, I went ahead and added a request. For >> some reason, the process got stuck when I click on Publish. The >> buttons are greyed out and nothing happened. Clicking on "View Diff" >> threw up some error for microsecond which I could not read. Then the >> publish/discard publish were gone and the patch was correctly >> submitted. >> >> Hoping that the mail was sent, I check my inbox and nothing there. >> >> I repeat the process using the same patch and test and same errors. I >> could not read the error :( >> >> Suddenly, it worked. But no mails. I went and checked the email >> settings and BAM and everything was gone. The settings were changed to >> the default localhost and port 25. Hmm. >> >> I edited the settings and tried to repeat the process and same thing. >> First 3-4 times (though I could not repeat the exact number of times) >> will give you an error (which will only stay for couple of >> microseconds and go off). Then suddenly it works and the email >> settings are lost. >> >> Setting the debug value to True as suggested at: >> >> http://groups.google.com/group/reviewboard/browse_thread/thread/42fd2fd6ee5285bd?pli=1 >> >> Nothing special happened except that the error stayed for some more >> time and I was able to catch a glimpse: >> >> Publishing of the draft has failed for some reason Error 0 (i think). >> >> Please contact your admin. >> >> If I go and remove the email, then everything works. >> >> Any idea how I can debug this problem? >> >> -- >> Ritesh >> http://www.riteshn.com >> >> > > > > > -- Ritesh http://www.riteshn.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Sending review emails and peculiar error
Hello So I created 3 users and added them to default reviewer group. I then went to Admin section and added the Email settings. I added my gmail settings and checking use TLS authentication. According to docs at http://www.review-board.org/docs/manual/dev/admin/management/review-groups/#e-mail-and-review-groups, since I dont have any mailing list attached to the repository so it will send mail to everybody in the review board. After doing the email settings, I went ahead and added a request. For some reason, the process got stuck when I click on Publish. The buttons are greyed out and nothing happened. Clicking on "View Diff" threw up some error for microsecond which I could not read. Then the publish/discard publish were gone and the patch was correctly submitted. Hoping that the mail was sent, I check my inbox and nothing there. I repeat the process using the same patch and test and same errors. I could not read the error :( Suddenly, it worked. But no mails. I went and checked the email settings and BAM and everything was gone. The settings were changed to the default localhost and port 25. Hmm. I edited the settings and tried to repeat the process and same thing. First 3-4 times (though I could not repeat the exact number of times) will give you an error (which will only stay for couple of microseconds and go off). Then suddenly it works and the email settings are lost. Setting the debug value to True as suggested at: http://groups.google.com/group/reviewboard/browse_thread/thread/42fd2fd6ee5285bd?pli=1 Nothing special happened except that the error stayed for some more time and I was able to catch a glimpse: Publishing of the draft has failed for some reason Error 0 (i think). Please contact your admin. If I go and remove the email, then everything works. Any idea how I can debug this problem? -- Ritesh http://www.riteshn.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Accessing over bzr+ssh giving errors
Hello On Fri, Apr 10, 2009 at 7:28 PM, plumpy wrote: > > I'm working on some of our bzr tools right now. I can try to look at > it early next week, but unless it's relatively straightforward, I > doubt I'll get around to fixing it. Honestly, I'm a little unsure why > it wouldn't work, since we're just using bzrlib, presumably accessing > it the exact same way bzr does. Are you sure you can access the > repository over ssh from the apache user? Can you 'su' to the apache > user and try? It was indeed a security issue. I looked around the thing using code at: http://bazaar-vcs.org/Integrating_with_Bazaar and I could not connect myself. So I guess its all good as of now :) Maybe a better error report might help! > > The code you're interested in is in scmtools/bzr.py. Feel free to > email me if you have questions. Even if I can't answer them, I can > probably ask my co-worker who wrote a bunch of it. > > On Apr 10, 4:49 pm, Ritesh Nadhani wrote: >> Hmm. >> >> I thought so. >> >> I work with Python though mostly along the lines of wxPython and >> Twisted but if given a correct poke in my head, I might be able to >> look into the problem. >> >> Any pointers where I should start? >> >> Right now we all have SSH keys in our homedirectory so doing >> bzr+ssh:// uses that and does not ask for password. I believe when we >> are doing from the web, it is foo baring on authentication. Maybe, >> adding the SSH key to apache user will work. >> >> No worries as I am just testing right now and in the end RB will be >> installed in the same machine as the repo so it will have direct >> access. >> >> >> >> On Fri, Apr 10, 2009 at 2:42 PM, Christian Hammond >> wrote: >> > It's likely that it just doesn't support this. Someone may have to write >> > the >> > support. >> >> > Bazaar support was written and used by contributors, but we (the lead >> > developers) have no experience with it, so it's hard to really help here. >> > Is >> > any Bazaar contributor able to answer this? >> >> > Christian >> >> > -- >> > Christian Hammond - chip...@chipx86.com >> > Review Board -http://www.review-board.org >> > VMware, Inc. -http://www.vmware.com >> >> > On Thu, Apr 9, 2009 at 12:53 PM, Ritesh Nadhani wrote: >> >> >> Hello >> >> >> So this is in continuation of my previous messages. >> >> >> Just for testing, I checked out a local copy of the repo by doing: >> >> >> cd ~/Codes >> >> bzr co bzr+ssh://hostname/bzr/repo1 repo1 >> >> >> and then in the settings, I set the repo path to be: >> >> >> /home/rnadhani/Codes/repo1 >> >> >> and its working now. >> >> >> So I guess RB is not able to access it over SSH. How can I use this >> >> option? >> >> >> -- >> >> Ritesh >> >>http://www.riteshn.com >> >> -- >> Riteshhttp://www.riteshn.com > > > -- Ritesh http://www.riteshn.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Accessing over bzr+ssh giving errors
Hmm. I thought so. I work with Python though mostly along the lines of wxPython and Twisted but if given a correct poke in my head, I might be able to look into the problem. Any pointers where I should start? Right now we all have SSH keys in our homedirectory so doing bzr+ssh:// uses that and does not ask for password. I believe when we are doing from the web, it is foo baring on authentication. Maybe, adding the SSH key to apache user will work. No worries as I am just testing right now and in the end RB will be installed in the same machine as the repo so it will have direct access. On Fri, Apr 10, 2009 at 2:42 PM, Christian Hammond wrote: > It's likely that it just doesn't support this. Someone may have to write the > support. > > Bazaar support was written and used by contributors, but we (the lead > developers) have no experience with it, so it's hard to really help here. Is > any Bazaar contributor able to answer this? > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.review-board.org > VMware, Inc. - http://www.vmware.com > > > On Thu, Apr 9, 2009 at 12:53 PM, Ritesh Nadhani wrote: >> >> Hello >> >> So this is in continuation of my previous messages. >> >> Just for testing, I checked out a local copy of the repo by doing: >> >> cd ~/Codes >> bzr co bzr+ssh://hostname/bzr/repo1 repo1 >> >> and then in the settings, I set the repo path to be: >> >> /home/rnadhani/Codes/repo1 >> >> and its working now. >> >> So I guess RB is not able to access it over SSH. How can I use this >> option? >> >> -- >> Ritesh >> http://www.riteshn.com >> >> > > > > > -- Ritesh http://www.riteshn.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Accessing over bzr+ssh giving errors
Hello So this is in continuation of my previous messages. Just for testing, I checked out a local copy of the repo by doing: cd ~/Codes bzr co bzr+ssh://hostname/bzr/repo1 repo1 and then in the settings, I set the repo path to be: /home/rnadhani/Codes/repo1 and its working now. So I guess RB is not able to access it over SSH. How can I use this option? -- Ritesh http://www.riteshn.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Fresh review board never lets me register or do anything...
Hello On Wed, Apr 8, 2009 at 12:33 PM, Ritesh Nadhani wrote: > Hi > > On Tue, Apr 7, 2009 at 7:17 PM, Christian Hammond wrote: >> There's a bug that will be fixed in the next beta where registration is >> turned off by default yet appears on in the settings. You'll need to log in >> as the admin user you created during install, go into the admin UI -> >> General Settings, make sure registration is enabled, and hit Save. It should >> then work. > > Thanks. I went thru the steps you suggested and it worked. I initially > had trouble submitting request but I found out that I need to create > some default reviewers. > > But when I submit a patch and go to View Diff, I get: > > http://paste.pocoo.org/show/111638/ > > what can I be doing wrong? So I was able to work a little more this morning on the problem. The error seemed to be some permission problem. Our bzr repo is hosted at: bzr+ssh://somehost/bzr/repo1 I tried doing both bzr+ssh://somehost/bzr/repo1 bzr+ssh://somehost/bzr/repo1/ and entered my SSH username/pwd in the option but no success. Earlier when I trying out Review Request option, I was giving the complete path in Base Diff Path option but after reading http://www.mail-archive.com/reviewboard@googlegroups.com/msg01548.html just tried '/' with no success. Is it possible that since the webapp is running as Apache user, it is not able to access bzr+ssh repo (though I have correctly entered my username password in the repository option). > > Also, I have two questions: > > 1) One more question before I take a leave. I assume that review board > does no show complete diffs from the history and only keep tracks of > patches etc submitted thru it. > > 2) When I review a patch and choose ship it, the code is actually not > pushed to the repository. Correct? > > Thanks, this is looking really great. > >> >> Christian >> >> -- >> Christian Hammond - chip...@chipx86.com >> Review Board - http://www.review-board.org >> VMware, Inc. - http://www.vmware.com >> >> >> On Tue, Apr 7, 2009 at 6:55 PM, riteshn wrote: >>> >>> Hi >>> >>> This is our first time using the product as we review it if suits our >>> needs. We plan to use it with Bazaar. >>> >>> I got the reviewboard and all the dependencies installed. Copying the >>> modpython conf file to apache sites-available directory and when I go >>> to the browser it shows up too. >>> >>> It is always in the login page and when i click on Register it always >>> reverts back to login page. Thus I am not able to setup the site as >>> suggested at: >>> http://www.mail-archive.com/reviewboard@googlegroups.com/msg01548.html >>> >>> During setup, I chose default authentication. >>> >>> Can somebody tell me what simple mistake I am doing? >>> >>> -- Ritesh >>> >> >> >> >> >> > > > > -- > Ritesh > http://www.riteshn.com > -- Ritesh http://www.riteshn.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Fresh review board never lets me register or do anything...
Hello Raghu On Thu, Apr 9, 2009 at 10:43 AM, Raghu wrote: > > I don't know about the diffviewer error but can answer other > questions. > > 1. Review board only knows about the code that you submit to it. If > you want to see version histories of the file, you need to go to > Bazaar. However, > if you update the diff as the result of a review comment, they will be > shown as revisions in review board. This way a reviewer can easily > find what > changed between the original review request and the update he just got > after the developer incorporated the review comments. > 2. Correct. Review will not submit the code in SCM. That clears up bunch of stuff. Now only if I can fix the diffviewerror :) > > -Raghu > > On Apr 9, 12:33 am, Ritesh Nadhani wrote: >> Hi >> >> On Tue, Apr 7, 2009 at 7:17 PM, Christian Hammond >> wrote: >> > There's a bug that will be fixed in the next beta where registration is >> > turned off by default yet appears on in the settings. You'll need to log in >> > as the admin user you created during install, go into the admin UI -> >> > General Settings, make sure registration is enabled, and hit Save. It >> > should >> > then work. >> >> Thanks. I went thru the steps you suggested and it worked. I initially >> had trouble submitting request but I found out that I need to create >> some default reviewers. >> >> But when I submit a patch and go to View Diff, I get: >> >> http://paste.pocoo.org/show/111638/ >> >> what can I be doing wrong? >> >> Also, I have two questions: >> >> 1) One more question before I take a leave. I assume that review board >> does no show complete diffs from the history and only keep tracks of >> patches etc submitted thru it. >> >> 2) When I review a patch and choose ship it, the code is actually not >> pushed to the repository. Correct? >> >> Thanks, this is looking really great. >> >> >> >> >> >> > Christian >> >> > -- >> > Christian Hammond - chip...@chipx86.com >> > Review Board -http://www.review-board.org >> > VMware, Inc. -http://www.vmware.com >> >> > On Tue, Apr 7, 2009 at 6:55 PM, riteshn wrote: >> >> >> Hi >> >> >> This is our first time using the product as we review it if suits our >> >> needs. We plan to use it with Bazaar. >> >> >> I got the reviewboard and all the dependencies installed. Copying the >> >> modpython conf file to apache sites-available directory and when I go >> >> to the browser it shows up too. >> >> >> It is always in the login page and when i click on Register it always >> >> reverts back to login page. Thus I am not able to setup the site as >> >> suggested at: >> >>http://www.mail-archive.com/reviewboard@googlegroups.com/msg01548.html >> >> >> During setup, I chose default authentication. >> >> >> Can somebody tell me what simple mistake I am doing? >> >> >> -- Ritesh >> >> -- >> Riteshhttp://www.riteshn.com > > > -- Ritesh http://www.riteshn.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: install 1.0beta2 on ubuntu 8.10, always show error page
I had the same issue. I figured our later that I didnt have the correct permission on the directory so Apache was not able to write for the database it needs. On Wed, Apr 8, 2009 at 12:39 PM, Ming Zhang wrote: > > Hi All > > I installed follow the instruction. Installed in under /var/www/ > reviews. Whenever I click login or register, it shows me the "taking a > nap" page. > > Any extra infgormation I need to provide, please let me know. > > Thanks > > Ming > > > > -- Ritesh http://www.riteshn.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Fresh review board never lets me register or do anything...
Hi On Tue, Apr 7, 2009 at 7:17 PM, Christian Hammond wrote: > There's a bug that will be fixed in the next beta where registration is > turned off by default yet appears on in the settings. You'll need to log in > as the admin user you created during install, go into the admin UI -> > General Settings, make sure registration is enabled, and hit Save. It should > then work. Thanks. I went thru the steps you suggested and it worked. I initially had trouble submitting request but I found out that I need to create some default reviewers. But when I submit a patch and go to View Diff, I get: http://paste.pocoo.org/show/111638/ what can I be doing wrong? Also, I have two questions: 1) One more question before I take a leave. I assume that review board does no show complete diffs from the history and only keep tracks of patches etc submitted thru it. 2) When I review a patch and choose ship it, the code is actually not pushed to the repository. Correct? Thanks, this is looking really great. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.review-board.org > VMware, Inc. - http://www.vmware.com > > > On Tue, Apr 7, 2009 at 6:55 PM, riteshn wrote: >> >> Hi >> >> This is our first time using the product as we review it if suits our >> needs. We plan to use it with Bazaar. >> >> I got the reviewboard and all the dependencies installed. Copying the >> modpython conf file to apache sites-available directory and when I go >> to the browser it shows up too. >> >> It is always in the login page and when i click on Register it always >> reverts back to login page. Thus I am not able to setup the site as >> suggested at: >> http://www.mail-archive.com/reviewboard@googlegroups.com/msg01548.html >> >> During setup, I chose default authentication. >> >> Can somebody tell me what simple mistake I am doing? >> >> -- Ritesh >> > > > > > -- Ritesh http://www.riteshn.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
