Re: Review Request 64971: AMBARI-22252. Revert Blueprint V2 changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64971/#review194938 --- ambari-server/src/test/java/org/apache/ambari/server/topology/validators/StackConfigTypeValidatorTest.java Line 74 (original), 67 (patched) <https://reviews.apache.org/r/64971/#comment274024> Why was static import of EasyMock removed? It improved clarity IMO. - Balázs Bence Sári On Jan. 5, 2018, 9:33 a.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64971/ > --- > > (Updated Jan. 5, 2018, 9:33 a.m.) > > > Review request for Ambari, Balázs Bence Sári, Dmytro Sen, Jayush Luniya, > Madhuvanthi Radhakrishnan, Robert Nettleton, and Vitalyi Brodetskyi. > > > Repository: ambari > > > Description > --- > > A few changes for Blueprint V2 work were initially commited on > `branch-feature-AMBARI-14714` before the "private" feature branch > `branch-feature-AMBARI-14714-blueprintv2` was forked. This change mostly > reverts those commits. > > It also fixes `ServiceComponentRequest` usage in `AmbariContext` (wrong > constructor was used), and expectations for `createServices` and > `createComponents` in `AmbariContextTest` (they are no longer `void` methods). > > The only functional change compared to `trunk` blueprint code is that it > creates a default service group when provisioning the cluster. This is > allows successful deployment using "old" blueprints. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java > 7171fc79c2d6997c1aa3669a96704e3f35592fa8 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java > 76782d5988364654a5326b5975b1449d7ddea854 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java > 9bbdc37a62cc82e22e3ecb14d016571c63f8943f > > ambari-server/src/main/java/org/apache/ambari/server/api/services/users/ActiveWidgetLayoutService.java > 2667a0c5d283d2cb2b2e361de833db43d98e144c > > ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java > 036f1bdb17495dd98ad84c9fed4c2e95d88b4a81 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > c88b23c8af374dd9bd695b70560079871f3366fd > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java > 53c3d1e77144458566b49b98d9a8c51381f6ff29 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2.java > 0b0329c31bb5800eb32ba4b437bd57a41a618dbe > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2Factory.java > 784b3683ba9d3909bb9e6d900e4175b6a00aec9a > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java > 5104354fce7701fe023723c19d56d25e7adf5219 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseClusterRequest.java > a38f478ed05ec88816e6363b31aa102a4a9d353f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > d2f24d9445ea5a33aaf1d286ff40bfc91787c277 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintV2ResourceProvider.java > 6d2c4f06f5c75fbdf9e81c2d711440862f375bb9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > cc0cea377233931bf65943f792f6a7e11b074f06 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationContext.java > aa63021b8a5a4e386652b936ceaefe6c2298797e > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java > 565369b08b6eeb1a598575e448ce0c6334b6234b > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java > f773fc8aac61f74988dd63a7a8b2cc30053023d2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java > 1284c265c150aa03c00b43b364c2163ca4e564a5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UnitUpdater.java > 3a70f8124be3034f29edd51a96e00b8e25dfd661 > > ambari-server/src/main/java/org/apache/ambari/ser
Re: Review Request 64971: AMBARI-22252. Revert Blueprint V2 changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64971/#review194939 --- Ship it! Ship It! - Balázs Bence Sári On Jan. 5, 2018, 9:33 a.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64971/ > --- > > (Updated Jan. 5, 2018, 9:33 a.m.) > > > Review request for Ambari, Balázs Bence Sári, Dmytro Sen, Jayush Luniya, > Madhuvanthi Radhakrishnan, Robert Nettleton, and Vitalyi Brodetskyi. > > > Repository: ambari > > > Description > --- > > A few changes for Blueprint V2 work were initially commited on > `branch-feature-AMBARI-14714` before the "private" feature branch > `branch-feature-AMBARI-14714-blueprintv2` was forked. This change mostly > reverts those commits. > > It also fixes `ServiceComponentRequest` usage in `AmbariContext` (wrong > constructor was used), and expectations for `createServices` and > `createComponents` in `AmbariContextTest` (they are no longer `void` methods). > > The only functional change compared to `trunk` blueprint code is that it > creates a default service group when provisioning the cluster. This is > allows successful deployment using "old" blueprints. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java > 7171fc79c2d6997c1aa3669a96704e3f35592fa8 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java > 76782d5988364654a5326b5975b1449d7ddea854 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java > 9bbdc37a62cc82e22e3ecb14d016571c63f8943f > > ambari-server/src/main/java/org/apache/ambari/server/api/services/users/ActiveWidgetLayoutService.java > 2667a0c5d283d2cb2b2e361de833db43d98e144c > > ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java > 036f1bdb17495dd98ad84c9fed4c2e95d88b4a81 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > c88b23c8af374dd9bd695b70560079871f3366fd > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java > 53c3d1e77144458566b49b98d9a8c51381f6ff29 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2.java > 0b0329c31bb5800eb32ba4b437bd57a41a618dbe > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2Factory.java > 784b3683ba9d3909bb9e6d900e4175b6a00aec9a > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java > 5104354fce7701fe023723c19d56d25e7adf5219 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseClusterRequest.java > a38f478ed05ec88816e6363b31aa102a4a9d353f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > d2f24d9445ea5a33aaf1d286ff40bfc91787c277 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintV2ResourceProvider.java > 6d2c4f06f5c75fbdf9e81c2d711440862f375bb9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > cc0cea377233931bf65943f792f6a7e11b074f06 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationContext.java > aa63021b8a5a4e386652b936ceaefe6c2298797e > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java > 565369b08b6eeb1a598575e448ce0c6334b6234b > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java > f773fc8aac61f74988dd63a7a8b2cc30053023d2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java > 1284c265c150aa03c00b43b364c2163ca4e564a5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UnitUpdater.java > 3a70f8124be3034f29edd51a96e00b8e25dfd661 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/BlueprintV2DAO.java > 6a054e8c9038acb63579065e6093193a3735eb90 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java > 8141f070bb40872fea9fae12e72adcf778ba8225 > > ambari-server/src/main/java/org
Re: Review Request 64914: AMBARI-22719. Regenerate Keytabs resets security.inter.broker.protocol to PLAINTEXTSASL
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64914/#review194696 --- Ship it! Ship It! - Balázs Bence Sári On Jan. 3, 2018, 11:24 a.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64914/ > --- > > (Updated Jan. 3, 2018, 11:24 a.m.) > > > Review request for Ambari, Attila Magyar, Balázs Bence Sári, Robert Levas, > and Yolanda Davis. > > > Bugs: AMBARI-22719 > https://issues.apache.org/jira/browse/AMBARI-22719 > > > Repository: ambari > > > Description > --- > > Let stack advisor retain `security.inter.broker.protocol` value if it is a > secure one. > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 125372011984791db4b1c54ef5874740882a2331 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 4f8eaf2ceb985996b7e3d888e615c3bdc91f7c90 > > > Diff: https://reviews.apache.org/r/64914/diff/1/ > > > Testing > --- > > Tested according to steps in > [AMBARI-22719](https://issues.apache.org/jira/browse/AMBARI-22719). > > Amended existing unit test case. Unit tests are OK: > > ``` > Total run:1200 > Total errors:0 > Total failures:0 > OK > ``` > > > Thanks, > > Attila Doroszlai > >
Re: Review Request 64670: AMBARI-22660. Fix unit tests failing due to ServiceGroup issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64670/#review194057 --- Ship it! Ship It! - Balázs Bence Sári On Dec. 17, 2017, 1:35 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64670/ > --- > > (Updated Dec. 17, 2017, 1:35 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Dmytro Sen, Jayush Luniya, > Madhuvanthi Radhakrishnan, Robert Nettleton, Swapan Shridhar, and Vitalyi > Brodetskyi. > > > Bugs: AMBARI-22660 > https://issues.apache.org/jira/browse/AMBARI-22660 > > > Repository: ambari > > > Description > --- > > Fixed mostly `ServiceGroupNotFound` due to `serviceGroupName=` and `Guice > provision errors` due to `serviceGroup=null` in `ServiceFactory.createNew()`. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > 25cfaf84c56b9b84f806ce43b9f8cd3fa4d36265 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 1bf5299e3c687403cbb8ba72b670929de5f53a12 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java > 2554c2544875f70bb10432dc4bd5685f0b3c9643 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceGroupDAO.java > 97659f74b5df2d837068644bce8dbd3e5319da1c > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java > 8994384956db0bac467cb61fd13afba07bbd21ab > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java > fedaee86fbbf4286b76a1c4758651f535bb6f642 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java > c479cdd42742ebada75f57efafd764d6b2112148 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > bdda9a79ec952fda4ee64c46c6e2ed1c7c9e2d58 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java > aff6d74f483ec365e3c8a96124f66e808c5b95ff > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java > 14ab8cf7baa26771f3b9eb72cf62518f9e93a7ce > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 0cc64e9d66b9afb21c62ab5b6346166d58e42036 > > ambari-server/src/test/java/org/apache/ambari/server/controller/BackgroundCustomCommandExecutionTest.java > 0b07fb7f1b31dde693116a97edc3a5425a82ba37 > > ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java > 99a7de370572ba055c31a056ea9012a66522 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java > 0f04e744bad5f4005428dc018c9850aecdccc3d5 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java > be7134e7c51426e941b92b3ac8aaa9f9935c0095 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java > bad63b789463653df5eaaabf89a2b0b917cebdbf > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java > d8575e7d6dfa9bda5671027bdf3ff152749a9ee9 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProviderTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java > 3a239689f2f5b21528f9b47f0b3f26963dc2a2c6 > > ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java > e9f7c4df07b623ac4c50e6869f80715b183fd45c > ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java > 2376079af4f45d17eec0cc1e91bcf0ec6ab96b90 > > ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java > 970b7cc6095f5607551fe66a5ea3792977582325 > ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java > 1a8340ab0aec52b6231177f34ecec32240ed7cbb > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java > b5525658c2b45a2ef3ba649e66ff95b673990519 > > ambari-server
Re: Review Request 64670: AMBARI-22660. Fix unit tests failing due to ServiceGroup issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64670/#review194055 --- ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java Lines 628 (patched) <https://reviews.apache.org/r/64670/#comment272765> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java Line 625 (original), 629 (patched) <https://reviews.apache.org/r/64670/#comment272763> Wonder if instead of swallowing an uncaught runtime exception we should rather modify the called method (getServiceByConfigType in ClusterImpl) to not throw this exception. ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java Line 64 (original), 64 (patched) <https://reviews.apache.org/r/64670/#comment272766> This column will shortly be removed in another patch so I'd prefer not changing it. ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProviderTest.java Lines 44 (patched) <https://reviews.apache.org/r/64670/#comment272767> Where are the test methods? - Balázs Bence Sári On Dec. 17, 2017, 1:35 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64670/ > --- > > (Updated Dec. 17, 2017, 1:35 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Dmytro Sen, Jayush Luniya, > Madhuvanthi Radhakrishnan, Robert Nettleton, Swapan Shridhar, and Vitalyi > Brodetskyi. > > > Bugs: AMBARI-22660 > https://issues.apache.org/jira/browse/AMBARI-22660 > > > Repository: ambari > > > Description > --- > > Fixed mostly `ServiceGroupNotFound` due to `serviceGroupName=` and `Guice > provision errors` due to `serviceGroup=null` in `ServiceFactory.createNew()`. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > 25cfaf84c56b9b84f806ce43b9f8cd3fa4d36265 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 1bf5299e3c687403cbb8ba72b670929de5f53a12 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java > 2554c2544875f70bb10432dc4bd5685f0b3c9643 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceGroupDAO.java > 97659f74b5df2d837068644bce8dbd3e5319da1c > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java > 8994384956db0bac467cb61fd13afba07bbd21ab > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java > fedaee86fbbf4286b76a1c4758651f535bb6f642 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java > c479cdd42742ebada75f57efafd764d6b2112148 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > bdda9a79ec952fda4ee64c46c6e2ed1c7c9e2d58 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java > aff6d74f483ec365e3c8a96124f66e808c5b95ff > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java > 14ab8cf7baa26771f3b9eb72cf62518f9e93a7ce > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 0cc64e9d66b9afb21c62ab5b6346166d58e42036 > > ambari-server/src/test/java/org/apache/ambari/server/controller/BackgroundCustomCommandExecutionTest.java > 0b07fb7f1b31dde693116a97edc3a5425a82ba37 > > ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java > 99a7de370572ba055c31a056ea9012a66522 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java > 0f04e744bad5f4005428dc018c9850aecdccc3d5 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java > be7134e7c51426e941b92b3ac8aaa9f9935c0095 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java > bad63b789463653df5eaaabf89a2b0b917cebdbf > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java > d8575e7d6dfa9bda5671027bdf3ff152749a9ee9 > > ambari-server/src/test/java/org/apache/ambari/se
Re: Review Request 64651: Revert adding repo_version column for stack table.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64651/ --- (Updated Dec. 15, 2017, 3:47 p.m.) Review request for Ambari, Attila Doroszlai, Jayush Luniya, Swapan Shridhar, and Vitalyi Brodetskyi. Bugs: AMBARI-22297 https://issues.apache.org/jira/browse/AMBARI-22297 Repository: ambari Description --- Stack table does not need the repo_version column, so it should be removed. Diffs - ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java c479cdd427 ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java dc77f19d63 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 84349b6d2f ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f9d5321e76 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql bc36e35a49 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 227645f1bb ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 333a0c3bc3 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 120bdb60d4 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 4313ae6028 ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 1a8340ab0a ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java d40679aea7 ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java 730d51cb98 ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 558b334267 ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java ca7a7aceb3 ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 8568b8c77e Diff: https://reviews.apache.org/r/64651/diff/1/ Testing (updated) --- - Fixed related unit tests in ambari-server. - Unit test run: slightly improved unit test results on the feature branch. See below. Before patch test results: Tests run: 4946, Failures: 216, Errors: 449, Skipped: 35 After patch test results: Tests run: 4950, Failures: 216, Errors: 421, Skipped: 35 Thanks, Balázs Bence Sári
Re: Review Request 64611: AMBARI-22196. yum repo file contains parsing errors due to initial whitespace
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64611/#review193917 --- Ship it! Ship It! - Balázs Bence Sári On Dec. 14, 2017, 1:06 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64611/ > --- > > (Updated Dec. 14, 2017, 1:06 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Jayush Luniya, and Swapan > Shridhar. > > > Bugs: AMBARI-22196 > https://issues.apache.org/jira/browse/AMBARI-22196 > > > Repository: ambari > > > Description > --- > > yum repo file created by Ambari results in `File contains parsing errors` due > to initial whitespace > > > Diffs > - > > ambari-server/src/main/resources/cluster-settings.xml > 70b100aba3d1378a7eb0d29c1c6dc609b42d8d89 > > > Diff: https://reviews.apache.org/r/64611/diff/1/ > > > Testing > --- > > Tested package installation via blueprint deployment. > > > Thanks, > > Attila Doroszlai > >
Re: Review Request 64613: AMBARI-22249. Fix AmbariContext.serviceGroupDependencyResourceProvider initialization
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64613/#review193916 --- Ship it! Ship It! - Balázs Bence Sári On Dec. 14, 2017, 1:16 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64613/ > --- > > (Updated Dec. 14, 2017, 1:16 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Swapan Shridhar, > and Vitalyi Brodetskyi. > > > Bugs: AMBARI-22249 > https://issues.apache.org/jira/browse/AMBARI-22249 > > > Repository: ambari > > > Description > --- > > Wrong variable is initialized. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > f4137683aaad84d5a66b93b4559abd7a1fb926bc > > > Diff: https://reviews.apache.org/r/64613/diff/1/ > > > Testing > --- > > Trivial fix. > > > Thanks, > > Attila Doroszlai > >
Re: Review Request 64614: AMBARI-22164. Fix wrong assignment due to leftover parameter name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64614/#review193915 --- Ship it! Ship It! - Balázs Bence Sári On Dec. 14, 2017, 1:25 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64614/ > --- > > (Updated Dec. 14, 2017, 1:25 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Madhuvanthi > Radhakrishnan, and Swapan Shridhar. > > > Bugs: AMBARI-22164 > https://issues.apache.org/jira/browse/AMBARI-22164 > > > Repository: ambari > > > Description > --- > > `serviceDisplayName` was changed to `serviceName` in both sides of the > assignment, but the parameter name was left as was, resulting in the member > variable `serviceName` always being set to `null`. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java > ea082c66e128a30368d6be195f3ee270a08e8518 > > > Diff: https://reviews.apache.org/r/64614/diff/1/ > > > Testing > --- > > Tested in blueprint deployment. > > > Thanks, > > Attila Doroszlai > >
Review Request 64651: Revert adding repo_version column for stack table.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64651/ --- Review request for Ambari, Attila Doroszlai, Jayush Luniya, Swapan Shridhar, and Vitalyi Brodetskyi. Bugs: AMBARI-22297 https://issues.apache.org/jira/browse/AMBARI-22297 Repository: ambari Description --- Stack table does not need the repo_version column, so it should be removed. Diffs - ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java c479cdd427 ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java dc77f19d63 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 84349b6d2f ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f9d5321e76 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql bc36e35a49 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 227645f1bb ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 333a0c3bc3 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 120bdb60d4 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 4313ae6028 ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 1a8340ab0a ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java d40679aea7 ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java 730d51cb98 ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 558b334267 ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java ca7a7aceb3 ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 8568b8c77e Diff: https://reviews.apache.org/r/64651/diff/1/ Testing --- - Fixed related unit tests in ambari-server. - Unit test run: pending Thanks, Balázs Bence Sári
Re: Review Request 64568: AMBARI-22638. yarn.timeline-service property enabled overriding preset secure blueprint config for the same
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64568/#review193710 --- Ship it! Ship It! - Balázs Bence Sári On Dec. 13, 2017, 6:54 a.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64568/ > --- > > (Updated Dec. 13, 2017, 6:54 a.m.) > > > Review request for Ambari, Attila Magyar, Balázs Bence Sári, Robert Levas, > and Robert Nettleton. > > > Bugs: AMBARI-22638 > https://issues.apache.org/jira/browse/AMBARI-22638 > > > Repository: ambari > > > Description > --- > > Changed `yarn.timeline-service.enabled` in `kerberos.json` to `false`, to > match stack default for HDP 3.0. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json > a3cfaea95918e629f02d2fa9d6eb72a5c77e5987 > > > Diff: https://reviews.apache.org/r/64568/diff/1/ > > > Testing > --- > > Tested secure cluster deployment with HDP 3.0, verified value of > `yarn.timeline-service.enabled` property: `false` if unset or set to `false` > in blueprint, `true` if set to `true` in blueprint. > > Unit tests: > > ``` > $ mvn -am -pl ambari-server clean test -Dtest='kerberos/*' > ... > Tests run: 205, Failures: 0, Errors: 0, Skipped: 1 > ... > Total run:1210 > Total errors:0 > Total failures:0 > ... > BUILD SUCCESS > ``` > > > Thanks, > > Attila Doroszlai > >
Re: Review Request 64478: Blueprint V2 API: object model, resource provider, cluster creation
> On Dec. 11, 2017, 10:23 p.m., Madhuvanthi Radhakrishnan wrote: > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql > > Line 42 (original) > > <https://reviews.apache.org/r/64478/diff/1/?file=1911954#file1911954line42> > > > > Where are we setting this value? I saw we removed it from the > > StackManager code. So, in UI deployment it might fail. > > Balázs Bence Sári wrote: > Mistakenly left there. Will remove. Hey Madhu, this column was added by me on the branch-feature-AMBARI-14714 branch. It turned out to be a mistake hence I am removing it. I don't think UI picked this property up yet. - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64478/#review193429 --- On Dec. 9, 2017, 12:19 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64478/ > --- > > (Updated Dec. 9, 2017, 12:19 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Madhuvanthi > Radhakrishnan, Robert Nettleton, and Swapan Shridhar. > > > Bugs: AMBARI-22253, AMBARI-22297 and AMBARI-22325 > https://issues.apache.org/jira/browse/AMBARI-22253 > https://issues.apache.org/jira/browse/AMBARI-22297 > https://issues.apache.org/jira/browse/AMBARI-22325 > > > Repository: ambari > > > Description > --- > > Implementation of Blueprint V2 API POST that allows cluster creation. > Co-authored by Balázs Bence Sári and Attila Doroszlai. > > Includes minor fixes for: > > * AMBARI-22196 -- yum repo file contains parsing errors due to initial > whitespace > * AMBARI-22249 -- AmbariContext.serviceGroupDependencyResourceProvider > initialization > * AMBARI-22164 -- wrong assignment due to leftover parameter name > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/ObjectNotFoundException.java > 75c9f3b5d50102f3beeeaa8041178cc08e22e241 > > ambari-server/src/main/java/org/apache/ambari/server/ParentObjectNotFoundException.java > 15bd7cb6bbe5026bf0a5ae9d3fc0bec575137643 > > ambari-server/src/main/java/org/apache/ambari/server/StackAccessException.java > b8bfff3991a4e49514801dbb480958941cff01ac > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > fd43edfa88339cd94686ddc13822b36ab7c74d6f > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java > 2582c71eb95255f0f8081e90473183243f12cdd0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 59e6622f708e7d8d27c9e28ce2ce58f014a4a5dc > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > c88b23c8af374dd9bd695b70560079871f3366fd > > ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationRequest.java > d26cf16b59897573173ea258133a1c1b4e6f31f1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > f2ff181da0327a82adb67e1405ab9ae238b5c4d4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java > cc84ce24b5e769257ac0e8744a93e3e236bb04e3 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java > 6d0f3fbd4288d31c3e077445e20c3b2bac696930 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java > ea082c66e128a30368d6be195f3ee270a08e8518 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2.java > 0b0329c31bb5800eb32ba4b437bd57a41a618dbe > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2Factory.java > 784b3683ba9d3909bb9e6d900e4175b6a00aec9a > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java > 5104354fce7701fe023723c19d56d25e7adf5219 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseClusterRequest.java > a38f478ed05ec88816e6363b31aa102a4a9d353f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintV2ResourceProvider.java > 6d2c4f06f5c75fbdf9e81c2d711440862f375bb9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > cc0cea377233931bf65943f792f6a7e11b074f06 > > ambari-ser
Re: Review Request 64478: Blueprint V2 API: object model, resource provider, cluster creation
> On Dec. 11, 2017, 10:23 p.m., Madhuvanthi Radhakrishnan wrote: > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql > > Line 42 (original) > > <https://reviews.apache.org/r/64478/diff/1/?file=1911954#file1911954line42> > > > > Where are we setting this value? I saw we removed it from the > > StackManager code. So, in UI deployment it might fail. Mistakenly left there. Will remove. - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64478/#review193429 --- On Dec. 9, 2017, 12:19 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64478/ > --- > > (Updated Dec. 9, 2017, 12:19 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Madhuvanthi > Radhakrishnan, Robert Nettleton, and Swapan Shridhar. > > > Bugs: AMBARI-22253, AMBARI-22297 and AMBARI-22325 > https://issues.apache.org/jira/browse/AMBARI-22253 > https://issues.apache.org/jira/browse/AMBARI-22297 > https://issues.apache.org/jira/browse/AMBARI-22325 > > > Repository: ambari > > > Description > --- > > Implementation of Blueprint V2 API POST that allows cluster creation. > Co-authored by Balázs Bence Sári and Attila Doroszlai. > > Includes minor fixes for: > > * AMBARI-22196 -- yum repo file contains parsing errors due to initial > whitespace > * AMBARI-22249 -- AmbariContext.serviceGroupDependencyResourceProvider > initialization > * AMBARI-22164 -- wrong assignment due to leftover parameter name > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/ObjectNotFoundException.java > 75c9f3b5d50102f3beeeaa8041178cc08e22e241 > > ambari-server/src/main/java/org/apache/ambari/server/ParentObjectNotFoundException.java > 15bd7cb6bbe5026bf0a5ae9d3fc0bec575137643 > > ambari-server/src/main/java/org/apache/ambari/server/StackAccessException.java > b8bfff3991a4e49514801dbb480958941cff01ac > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > fd43edfa88339cd94686ddc13822b36ab7c74d6f > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java > 2582c71eb95255f0f8081e90473183243f12cdd0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 59e6622f708e7d8d27c9e28ce2ce58f014a4a5dc > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > c88b23c8af374dd9bd695b70560079871f3366fd > > ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationRequest.java > d26cf16b59897573173ea258133a1c1b4e6f31f1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > f2ff181da0327a82adb67e1405ab9ae238b5c4d4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java > cc84ce24b5e769257ac0e8744a93e3e236bb04e3 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java > 6d0f3fbd4288d31c3e077445e20c3b2bac696930 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java > ea082c66e128a30368d6be195f3ee270a08e8518 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2.java > 0b0329c31bb5800eb32ba4b437bd57a41a618dbe > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2Factory.java > 784b3683ba9d3909bb9e6d900e4175b6a00aec9a > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java > 5104354fce7701fe023723c19d56d25e7adf5219 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseClusterRequest.java > a38f478ed05ec88816e6363b31aa102a4a9d353f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintV2ResourceProvider.java > 6d2c4f06f5c75fbdf9e81c2d711440862f375bb9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > cc0cea377233931bf65943f792f6a7e11b074f06 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java > 565369b08b6eeb1a598575e448ce0c6334b6234b > > ambari-server/src/main/java/org/apache/ambari/server/controller/
Re: Review Request 64027: Ambari server becomes unusable when config properties are misconfigured
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64027/#review191887 --- Ship it! Ship It! - Balázs Bence Sári On Nov. 22, 2017, 12:52 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64027/ > --- > > (Updated Nov. 22, 2017, 12:52 p.m.) > > > Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Miklos > Gergely. > > > Bugs: AMBARI-22499 > https://issues.apache.org/jira/browse/AMBARI-22499 > > > Repository: ambari > > > Description > --- > > Not all numeric values are valid doubles, eg. 86400L is a valid long, but not > a double. > > Changed to `NumberUtils.createNumber` instead of `Double.parseDouble` to > create the appropriate numeric object. > Checking `doubleValue()` is necessary for equal values of different types > (eg. `0.0` vs `0`). > > Also fixed possible NPE in non-numeric case. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > eade91458847125df8e50505cb2af5bd67ee0b3d > > ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java > 8a0a78228e72fc14ff361445363fa61d1cc4e977 > > > Diff: https://reviews.apache.org/r/64027/diff/1/ > > > Testing > --- > > Added unit test: > > ``` > [INFO] Tests run: 25, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.31 > s - in org.apache.ambari.server.state.ConfigHelperTest > ``` > > > Thanks, > > Attila Doroszlai > >
Re: Review Request 63754: AMBARI-22426. Push down Logger instances
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63754/#review190829 --- Ship it! Ship It! - Balázs Bence Sári On Nov. 13, 2017, 2:31 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63754/ > --- > > (Updated Nov. 13, 2017, 2:31 p.m.) > > > Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Jonathan > Hurley. > > > Bugs: AMBARI-22426 > https://issues.apache.org/jira/browse/AMBARI-22426 > > > Repository: ambari > > > Description > --- > > Make (almost) all loggers private, push down to subclasses, keep in super > class if also used there. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/handlers/BaseManagementHandler.java > d0bd5d32f50820adfecfc2282f253e9ae03fbeb3 > > ambari-server/src/main/java/org/apache/ambari/server/api/handlers/CreateHandler.java > 549da76b3b0c1651507d612b037f3d70715cb7be > > ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java > d24780b4ac191743d1e2c2cf4ea8c62c6f5844da > > ambari-server/src/main/java/org/apache/ambari/server/api/services/LoggingService.java > c86b9a0e50958c693b3f52f1de3aa3df1783fdd4 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java > 2dc45de22655d7c7a69a11335a50f6d130cef34a > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java > 34888f2408b7abcb75825acc1f6b6d15ea9fe2fa > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java > e134f6dc6ef9850bb4e8d2cc58b7bf7c860f4da0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java > 322596ea5e96c1e17433ad339f39d16898384015 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java > 1501a0186a315cff2391e0aadbe8c3232bb4d9ee > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java > 5598650ef1681557464eed5cfbb573f2ecc33c95 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java > 4e618e7ff63679086b507103adee2bc7736a16c4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java > 32f1fd8f4fcbddd47972add304648db9f44ba8a3 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java > cf4e7475b3ab6ed1e5375af23dcbe28d0533c839 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java > c71651e5ff0be669646950cc41b0aa56e73c47f0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java > 43ee7fe7c79a14e2de4c27bb1b121625381f413e > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java > c5c02cf274239fe3493b69f97e69cc63967375dd > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseProvider.java > 135eefece20046037fc5440f4dc3bc946601b1e3 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 5a7cda0d8101abccefd0464b75777c78e8cbc9cb > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java > 73d24908eabfe76908a60ebe4c0d3d08deb1f32a > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > 54c83600b78d77ee26dffea947133cc7d07e098e > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > 98adcd112d768cca61c9eb0d59b00d85d8da0d9a > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java > f05ffbe0167fe2a6d4970d3b628fea48a54217ec > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java > 2e86b2dcf45076315f54bbf298ab20a107fcf513 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java > 79254c6d8960867f737c64d2b48782e3a364d59d > > ambari-server/src/main/java/org/apache
Re: Review Request 63749: Quicklinks for OneFS
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63749/#review190828
---
Ship it!
Ship It!
- Balázs Bence Sári
On Nov. 13, 2017, 8:56 a.m., Attila Magyar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63749/
> ---
>
> (Updated Nov. 13, 2017, 8:56 a.m.)
>
>
> Review request for Ambari, Andrii Babiichuk, Andrii Tkach, Balázs Bence Sári,
> and Nate Cole.
>
>
> Bugs: AMBARI-22424
> https://issues.apache.org/jira/browse/AMBARI-22424
>
>
> Repository: ambari
>
>
> Description
> ---
>
> OneFS mpack should have a quicklink definition with links that point to the
> OneFS admin UI.
>
> OneFS is a client only service and the hostname of OneFS admin page is an
> external host. The quicklink engine needed to be improved to allow overriding
> hostnames.
>
> For example the following quicklink will point to http://scisilon.fqdn if
> core-site/fs.defaultFS=hdfs://scisilon.fqdn.
>
> "links": [
> {
> "component_name" : "ONEFS_CLIENT",
> "name": "onefs_web_ui",
> "label": "OneFS Web UI",
> "url": "%@://%@",
> "host": {
> "http_property": "fs.defaultFS",
> "site": "core-site"
> }
> }
> ]
> }
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Host.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
> 1d2e712
>
> ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java
> aac278d
> ambari-server/src/test/resources/child_quicklinks_to_override.json 4309532
> ambari-web/app/views/common/quick_view_link_view.js 5888acb
> ambari-web/test/views/common/quick_link_view_test.js 1998a9c
>
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/metainfo.xml
> 82e2022
>
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/quicklinks/quicklinks.json
> PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/63749/diff/1/
>
>
> Testing
> ---
>
> - installed mpack and clicked on quicklinks
>
> existing tests: passed
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 63735: Ambari checks fail with FIPS mode is activated on the OS
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63735/#review190739
---
Ship it!
Ship It!
- Balázs Bence Sári
On Nov. 10, 2017, 4:43 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63735/
> ---
>
> (Updated Nov. 10, 2017, 4:43 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Andrew Onischuk, Balázs Bence Sári,
> Eugene Chekanskiy, Jonathan Hurley, Robert Nettleton, Swapan Shridhar, and
> Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-22417
> https://issues.apache.org/jira/browse/AMBARI-22417
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Ambari checks fail with FIPS mode is activated on the OS (Rhel7). FIPS mode
> disables weak ciphers (such as MD5).
> Ambari code is doing
>
> ```
> ccache_file_name = _md5("
> {0}|{1}".format(principal, keytab)).hexdigest(). MD5 is disabled on the OS
> (RHEL7) so ambari throws errors.
> ```
>
> - All service checks fail, Ranger KMS start fails via ambari.
> - However all the services are actually running and fine.
>
> - Also Ranger KMS succesfully started from command Line
>
> Here is the stack trace from Ambari
>
> ```
> service_check
> params.kinit_path_local, False, None, params.smoke_user)
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/curl_krb_request.py",
> line 109, in curl_krb_request
> ccache_file_name = _md5("{0}
> |
> {1}
> ".format(principal, keytab)).hexdigest()
> ValueError: error:060800A3:digital envelope
> routines:EVP_DigestInit_ex:disabled for fips
> ```
>
> Fix:
> MD5 is disabled on the OS, Code needs to be updated to use SHA?
>
> This is required when FIPS mode is enabled on the RHEL OS
>
>
> Diffs
> -
>
>
> ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
> 95e8625d67
>
>
> Diff: https://reviews.apache.org/r/63735/diff/1/
>
>
> Testing
> ---
>
> Manually tested
>
>
> Thanks,
>
> Robert Levas
>
>
Review Request 63725: Fix tar_archive.py: 1. remove verbosity flags, 2. archive_dir() and archive_directory_dereference() should store relative paths
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63725/ --- Review request for Ambari, Attila Doroszlai, Attila Magyar, Andrew Onischuk, and Jonathan Hurley. Bugs: AMBARI-22413 https://issues.apache.org/jira/browse/AMBARI-22413 Repository: ambari Description --- Removed verbosity flag and fixed the two methods to store relative paths. Diffs - ambari-common/src/main/python/resource_management/libraries/functions/tar_archive.py e6d8924 ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 8c48347 ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py 3114fa8 Diff: https://reviews.apache.org/r/63725/diff/1/ Testing --- - Manually tested archiving / restoration at Falcon server start / stop. - Manually tested HDP upgrades with Falcon server and BigInsight 4.2.5 -> HDP upgrade (didn't not test the archival process only that upgrade went smoothly) - Updates python unit tests. All python unit tests pass in ambari-server Thanks, Balázs Bence Sári
Review Request 62649: AMBARI-21325: Quicklink support through Knox (new patch)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62649/ --- Review request for Ambari, Chandana Mirashi, Juanjo Marron, Larry McCay, and Sid Wagle. Bugs: AMBARI-21325 https://issues.apache.org/jira/browse/AMBARI-21325 Repository: ambari Description --- This is a continuation of Chandana Mirashi's patch reviewed here: https://reviews.apache.org/r/61043/ The original patch has been rebased and adapted to HDP-2.6 environment. Future HDP-3.0 compatibility has also been addressed. Diffs - ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 1d2e712 ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/quicklinks/quicklinks.json 5568122 ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/quicklinks/quicklinks.json 5318ba0 ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 5f470ec ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/quicklinks/quicklinks.json f15ddd7 ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/quicklinks/quicklinks.json 43cf641 ambari-server/src/main/resources/common-services/SPARK/2.2.0/quicklinks/quicklinks.json 4639272 ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/quicklinks-mapred/quicklinks.json 5ffbc07 ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/quicklinks/quicklinks.json 37248d0 ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json 5568122 ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json a4216e3 ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/metainfo.xml 26496f7 ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json 43cf641 ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json 36f71b5 ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json 0aca8e3 ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml df4c1b4 ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/metainfo.xml 66341c9 ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/quicklinks/quicklinks.json PRE-CREATION ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json c3e3f94 ambari-web/app/views/common/quick_view_link_view.js 5888acb Diff: https://reviews.apache.org/r/62649/diff/1/ Testing --- Manually tested with trunk version of Ambari and HDP-2.6. All quick links work except Spark2 ones as those would need the 2.1.0 version of SPARKHISTORYUI service definition. All unit tests for ambari-server and ambari-web passed. Thanks, Balázs Bence Sári
Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61043/#review183359 --- Ship it! Ship It! - Balázs Bence Sári On Aug. 17, 2017, 9:40 p.m., Chandana Mirashi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61043/ > --- > > (Updated Aug. 17, 2017, 9:40 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Juanjo Marron, and Sid Wagle. > > > Bugs: AMBARI-21325 > https://issues.apache.org/jira/browse/AMBARI-21325 > > > Repository: ambari > > > Description > --- > > Add quicklink support through Knox. > Changes: > 1. Add new json properties knox_url, knox_path, supports_knox >a. knox_url: template to be used for urls that are proxied through Knox >b. knox_path: Knox gateway path that will be added to the proxy url. >c. supports_knox: whether link will be redirected through Knox > 2. Add above json properties to quicklinks.json > 3. Add HDFSUI & DATANODE,YARNUI & NODEUI, JOBHISTORYUI, HBASEUI, OOZIEUI, > SPARKUI services to Knox topology template. > 4. Automate protocol and port added to Knox topology file. Based on whether > SSL is enabled for the services listed above, the port and protocol in > params_linux.py will be updated. > 5. Update quick_view_link_view.js so that when Knox is installed and > support_knox is true, quicklink url follows knox url template specified in > the quicklinks.json for the service/component. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java > 1d2e712 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 4558069 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json > 5568122 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json > a4216e3 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json > 43cf641 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json > 36f71b5 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json > 0aca8e3 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml > df4c1b4 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/quicklinks/quicklinks.json > PRE-CREATION > ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 1805c3b > ambari-web/app/views/common/quick_view_link_view.js 5888acb > > > Diff: https://reviews.apache.org/r/61043/diff/3/ > > > Testing > --- > > 1. ambari-server: mvn test > 2. mvn -DskipSurefireTests -Dpython.test.mask=test_knox_gateway.py test > 3. ambari-web: mvn test > 21213 passing (54s) > 128 pending > > > Thanks, > > Chandana Mirashi > >
Re: Review Request 61024: Implement support for recommending LDAP configuration
> On Aug. 8, 2017, 8:01 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java > > Lines 165 (patched) > > <https://reviews.apache.org/r/61024/diff/3/?file=1793035#file1793035line165> > > > > What are the performance implications? > > > > Is this invoked on every call? It has to be invoked in every call. It takes 1-2 millis in my local environment. > On Aug. 8, 2017, 8:01 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java > > Lines 184 (patched) > > <https://reviews.apache.org/r/61024/diff/3/?file=1793035#file1793035line184> > > > > Why is this issuing an HTTP call instead of calling the method directly > > to make it more efficient? It is not going through http, but calls the rest service endpoint. I copied the existing style of similar methods (getServicesInformation and getHostsInformation) in the class. Performance impact is negligible. - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61024/#review182428 --- On Aug. 8, 2017, 5:57 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61024/ > --- > > (Updated Aug. 8, 2017, 5:57 p.m.) > > > Review request for Ambari, Laszlo Puskas, Robert Levas, Sandor Magyari, and > Sebastian Toader. > > > Bugs: AMBARI-21545 > https://issues.apache.org/jira/browse/AMBARI-21545 > > > Repository: ambari > > > Description > --- > > Ldap configuration can be included in recommendation requests and validation > requests. Configuration is passed down to stack advisor in services.json > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java > d6714f9 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java > 0632361 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java > 7ba1b18 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java > 356754d > > ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java > eaa4716 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java > 6df8b8b > > > Diff: https://reviews.apache.org/r/61024/diff/3/ > > > Testing > --- > > - Tested the rest interface manually > - Wrote new unit tests > - Ambari-server unit tests: PENDING > > > Thanks, > > Balázs Bence Sári > >
Re: Review Request 61024: Implement support for recommending LDAP configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61024/ --- (Updated Aug. 8, 2017, 5:57 p.m.) Review request for Ambari, Laszlo Puskas, Robert Levas, Sandor Magyari, and Sebastian Toader. Changes --- Added one more unit test. Bugs: AMBARI-21545 https://issues.apache.org/jira/browse/AMBARI-21545 Repository: ambari Description --- Ldap configuration can be included in recommendation requests and validation requests. Configuration is passed down to stack advisor in services.json Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java d6714f9 ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java 0632361 ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java 7ba1b18 ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 356754d ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java eaa4716 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java 6df8b8b Diff: https://reviews.apache.org/r/61024/diff/3/ Changes: https://reviews.apache.org/r/61024/diff/2-3/ Testing --- - Tested the rest interface manually - Wrote new unit tests - Ambari-server unit tests: PENDING Thanks, Balázs Bence Sári
Re: Review Request 61024: Implement support for recommending LDAP configuration
> On July 21, 2017, 12:41 p.m., Sebastian Toader wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java > > Lines 81 (patched) > > <https://reviews.apache.org/r/61024/diff/1/?file=1780662#file1780662line81> > > > > Can this be placed to a common place and avoid defining it in two > > places? After the rewrite the property is only used in StackAdvisorCommand and its test. > On July 21, 2017, 12:41 p.m., Sebastian Toader wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java > > Lines 345 (patched) > > <https://reviews.apache.org/r/61024/diff/1/?file=1780662#file1780662line345> > > > > Add some comment what this method does. Methdod was deleted along with the rewrite. - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61024/#review18 ------- On Aug. 8, 2017, 1:40 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61024/ > --- > > (Updated Aug. 8, 2017, 1:40 p.m.) > > > Review request for Ambari, Laszlo Puskas, Robert Levas, Sandor Magyari, and > Sebastian Toader. > > > Bugs: AMBARI-21545 > https://issues.apache.org/jira/browse/AMBARI-21545 > > > Repository: ambari > > > Description > --- > > Ldap configuration can be included in recommendation requests and validation > requests. Configuration is passed down to stack advisor in services.json > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java > d6714f9 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java > 0632361 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java > 7ba1b18 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java > 356754d > > ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java > eaa4716 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java > 6df8b8b > > > Diff: https://reviews.apache.org/r/61024/diff/2/ > > > Testing > --- > > - Tested the rest interface manually > - Wrote new unit tests > - Ambari-server unit tests: PENDING > > > Thanks, > > Balázs Bence Sári > >
Re: Review Request 61024: Implement support for recommending LDAP configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61024/ --- (Updated Aug. 8, 2017, 1:40 p.m.) Review request for Ambari, Laszlo Puskas, Robert Levas, Sandor Magyari, and Sebastian Toader. Changes --- LDAP Config is retrieved from server within StackAdvisorCommand. In the previous version the LDAP config was sent with other configs with RecommendationRequest / ConfigurationRequest Bugs: AMBARI-21545 https://issues.apache.org/jira/browse/AMBARI-21545 Repository: ambari Description --- Ldap configuration can be included in recommendation requests and validation requests. Configuration is passed down to stack advisor in services.json Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java d6714f9 ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java 0632361 ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java 7ba1b18 ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 356754d ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java eaa4716 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java 6df8b8b Diff: https://reviews.apache.org/r/61024/diff/2/ Changes: https://reviews.apache.org/r/61024/diff/1-2/ Testing --- - Tested the rest interface manually - Wrote new unit tests - Ambari-server unit tests: PENDING Thanks, Balázs Bence Sári
Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61043/#review181664 --- ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java Lines 67 (patched) <https://reviews.apache.org/r/61043/#comment257293> Why not boolean? - Balázs Bence Sári On July 25, 2017, 12:53 a.m., Chandana Mirashi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61043/ > --- > > (Updated July 25, 2017, 12:53 a.m.) > > > Review request for Ambari, Balázs Bence Sári, Juanjo Marron, and Sid Wagle. > > > Bugs: AMBARI-21325 > https://issues.apache.org/jira/browse/AMBARI-21325 > > > Repository: ambari > > > Description > --- > > Add quicklink support through Knox. > Changes: > 1. Add new json properties knox_url, knox_path, supports_knox >a. knox_url: template to be used for urls that are proxied through Knox >b. knox_path: Knox gateway path that will be added to the proxy url. >c. supports_knox: whether link will be redirected through Knox > 2. Add above json properties to quicklinks.json > 3. Add HDFSUI & DATANODE,YARNUI & NODEUI, JOBHISTORYUI, HBASEUI, OOZIEUI, > SPARKUI services to Knox topology template. > 4. Automate protocol and port added to Knox topology file. Based on whether > SSL is enabled for the services listed above, the port and protocol in > params_linux.py will be updated. > 5. Update quick_view_link_view.js so that when Knox is installed and > support_knox is true, quicklink url follows knox url template specified in > the quicklinks.json for the service/component. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java > 1d2e712 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 4558069 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json > 5568122 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json > a4216e3 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json > 81e7cbe > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json > 36f71b5 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json > 0aca8e3 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml > df4c1b4 > ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 1805c3b > ambari-web/app/views/common/quick_view_link_view.js e39f230 > > > Diff: https://reviews.apache.org/r/61043/diff/2/ > > > Testing > --- > > 1. ambari-server: mvn test > 2. mvn -DskipSurefireTests -Dpython.test.mask=test_knox_gateway.py test > 3. ambari-web: mvn test > 21213 passing (54s) > 128 pending > > > Thanks, > > Chandana Mirashi > >
Review Request 61162: Ooozie quicklink configuration doesn't work with https
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61162/ --- Review request for Ambari, Andrii Tkach, Jaimin Jetly, Miklos Gergely, Oliver Szabo, Robert Levas, Sebastian Toader, and Yusaku Sako. Bugs: AMBARI-21579 https://issues.apache.org/jira/browse/AMBARI-21579 Repository: ambari Description --- Ooize quick links didn't work whith SSL enables die to two reasons: 1. Typos in the quicklink definitions (quicklinks.json) - fixed in this patch 2. An Oozie bug that prohibits changing the oozie-site/oozie.base.url property to the https address. The port for the quick link address was taken from this property. Issue #2 has been worked around in the patch by the using the oozie-site/oozie.https.port to determine the port for the https quick link. Code has been slightly changed to support custom regex to parse the https port for the quicklink. Diffs - ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Port.java 7bd4b81 ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/quicklinks/quicklinks.json 6353220 ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/quicklinks/quicklinks.json 81e7cbe ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/quicklinks/quicklinks.json f83bb5c ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json 81e7cbe ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java e37eaf0 ambari-server/src/test/resources/parent_quicklinks.json 0aca8e3 ambari-web/app/views/common/quick_view_link_view.js e39f230 ambari-web/test/views/common/quick_link_view_test.js 48cdb28 Diff: https://reviews.apache.org/r/61162/diff/1/ Testing --- - manually tested the fix - wrote to javascript unit tests - extended a java unit tests - unit tests pass in ambari-web (21223 passing / 128 pending) - java unit tests pass in ambari-server - 13 python unit test fail in ambari-server to an unrelated commit (the tests fail in CI builds too) Thanks, Balázs Bence Sári
Review Request 61024: Implement support for recommending LDAP configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61024/ --- Review request for Ambari, Laszlo Puskas, Robert Levas, Sandor Magyari, and Sebastian Toader. Bugs: AMBARI-21545 https://issues.apache.org/jira/browse/AMBARI-21545 Repository: ambari Description --- Ldap configuration can be included in recommendation requests and validation requests. Configuration is passed down to stack advisor in services.json Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java d6714f9 ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java 0632361 ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java 7ba1b18 ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 356754d ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java 2eed23d ambari-server/src/main/resources/properties.json 11ca7f6 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java 6df8b8b Diff: https://reviews.apache.org/r/61024/diff/1/ Testing --- - Tested the rest interface manually - Wrote new unit tests - Ambari-server unit tests: PENDING Thanks, Balázs Bence Sári
Re: Review Request 60665: Add swagger annotations to the new AmbariConfigurationService class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60665/ --- (Updated July 6, 2017, 10:13 a.m.) Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, and Sebastian Toader. Changes --- Fix a review comment and few other things Bugs: AMBARI-21307 https://issues.apache.org/jira/browse/AMBARI-21307 Repository: ambari Description --- Added swagger annotations to the new AmbariConfigurationService class. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationResponseSwagger.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java 0fa6e44 Diff: https://reviews.apache.org/r/60665/diff/2/ Changes: https://reviews.apache.org/r/60665/diff/1-2/ Testing --- Manually checked the generated html. Thanks, Balázs Bence Sári
Review Request 60668: Fixed outdated index.html generation in ambari-server/target/generated-sources/swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60668/ --- Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, and Sebastian Toader. Bugs: AMBARI-21410 https://issues.apache.org/jira/browse/AMBARI-21410 Repository: ambari Description --- The input for html generation is taken from the correct source (ambari-server/target/generated-sources/swagger/swagger.json instead of ambari-server/docs/api/generated/swagger.json). Diffs - ambari-server/pom.xml 878665e Diff: https://reviews.apache.org/r/60668/diff/1/ Testing --- Manually tested docs generation both with and without the -Dgenerate.swagger.resources flag. Thanks, Balázs Bence Sári
Review Request 60665: Add swagger annotations to the new AmbariConfigurationService class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60665/ --- Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, and Sebastian Toader. Bugs: AMBARI-21307 https://issues.apache.org/jira/browse/AMBARI-21307 Repository: ambari Description --- Added swagger annotations to the new AmbariConfigurationService class. Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationResponseSwagger.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java 0fa6e44 Diff: https://reviews.apache.org/r/60665/diff/1/ Testing --- Manually checked the generated html. Thanks, Balázs Bence Sári
Re: Review Request 60271: AMBARI-21295. Enable Swagger checkstyle rule for endpoints documented so far
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60271/#review178494 --- Ship it! Ship It! - Balázs Bence Sári On June 21, 2017, 1 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60271/ > --- > > (Updated June 21, 2017, 1 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Sumit Mohanty, > and Sebastian Toader. > > > Bugs: AMBARI-21295 > https://issues.apache.org/jira/browse/AMBARI-21295 > > > Repository: ambari > > > Description > --- > > * Enabled `UndocumentedRestApiOperationCheck` > * Added `@ApiIgnore` for operations not yet documented > > > Diffs > - > > ambari-server/checkstyle.xml 97fdc2a91a467390df0213f720fb015cfd189df5 > > ambari-server/src/main/java/org/apache/ambari/server/agent/rest/AgentResource.java > a332459c91ae9af0314f7fc9f6d14acbe15c9cb1 > > ambari-server/src/main/java/org/apache/ambari/server/api/rest/BootStrapResource.java > 1bf22b176c182d50407efbb16e620d6fa9edae5f > > ambari-server/src/main/java/org/apache/ambari/server/api/rest/HealthCheck.java > 4c7c5e873924e55df5e298558b30d29006ebe6e3 > > ambari-server/src/main/java/org/apache/ambari/server/api/rest/KdcServerReachabilityCheck.java > b4f1fe19236d0759f77a8c8e861efc8b485f0ee8 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertDefinitionService.java > bf9741a81266c4327c5ac47f2f86211521ba1200 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertGroupService.java > be1c65c0b632b5daaf9040204ed21fed96388cf4 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertHistoryService.java > 17733a257dff11429bf8fdbf56fb487926b1888b > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertNoticeService.java > 2bbc51f5f2700217b6d916f75ec6e7a6f2bc1ab1 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertService.java > 9922359e32f41f659eb4531c195490cea9a0bb5f > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertTargetService.java > f00dfbb782a6e05e5104cdd926d35de88dbe6f41 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterKerberosDescriptorService.java > 0aeb52b7fba3c097102b9dbd9817323c84e0dfa2 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java > eafc0760c482038c23ea09e9d97bf8381f6d7b1e > > ambari-server/src/main/java/org/apache/ambari/server/api/services/CompatibleRepositoryVersionService.java > 5927f8b3189b563b684ef86b137c5693f4e2ff76 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java > 800e0119e9c4f4243ade500feb62dc59ce1e4900 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ConfigGroupService.java > 5c52718a858c1eabfacb0ae937465c6f7952909f > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ConfigurationService.java > c256ecae46bfb7ed81575c104d75b04e68c95e2a > > ambari-server/src/main/java/org/apache/ambari/server/api/services/CredentialService.java > 449c292c079493775a47a1462a5a1c617c6593e9 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ExtensionLinksService.java > 1acccd87c26fc1372e9686014f068d5f90efad65 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ExtensionsService.java > 2fedd54329d512c43b8ba79e9b20011e8a164abf > > ambari-server/src/main/java/org/apache/ambari/server/api/services/FeedService.java > 73b99603bf63b89d9a96643a89d4a6a2d7660f23 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java > 62889722e5b15f26fcc3b5328f90a768c0a5a909 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostKerberosIdentityService.java > a99d269aa86f8021306a158a76eb915e5a81a418 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java > bce51c490cff82d6bc56f336d5cce7b4344ea152 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/InstanceService.java > 760ee24dc7cd839dfc269985e387906e4cfcdcb7 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/JobService.java > bb882f12889c261cf0fd1aaf1f4d671d0c02e55f > > ambari-server/src/main/java/org/apache/ambari/serv
Re: Review Request 60269: AMBARI-21293. Allow skipping Swagger generation
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60269/#review178491
---
Ship it!
Ship It!
- Balázs Bence Sári
On June 21, 2017, 9:24 a.m., Attila Doroszlai wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60269/
> ---
>
> (Updated June 21, 2017, 9:24 a.m.)
>
>
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, and Sebastian
> Toader.
>
>
> Bugs: AMBARI-21293
> https://issues.apache.org/jira/browse/AMBARI-21293
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Swagger generation can be skipped via `-Dswagger.skip` command-line
> parameter, similar to `-Dcheckstyle.skip` and `-Drat.skip`.
>
>
> Diffs
> -
>
> ambari-server/pom.xml 1ada974911cfe8ea205853f3d315e31ec0af0c66
>
>
> Diff: https://reviews.apache.org/r/60269/diff/1/
>
>
> Testing
> ---
>
> ```
> $ mvn -am -pl ambari-server clean test-compile
> ...
> [INFO] --- swagger-maven-plugin:3.1.4:generate (default) @ ambari-server ---
> [INFO] Reflections took 133 ms to scan 1 urls, producing 28 keys and 186
> values
> [INFO] Reading custom API reader:
> org.apache.ambari.swagger.AmbariSwaggerReader
> [INFO] Reflections took 92 ms to scan 1 urls, producing 28 keys and 186 values
> [INFO] This class exists both as top level and nested API:
> org.apache.ambari.server.api.services.HostService, treating it as top level
> API
> [INFO] Registering nested API: class
> org.apache.ambari.server.api.services.ServiceService
> [INFO] This class exists both as top level and nested API:
> org.apache.ambari.server.api.services.RequestService, treating it as top
> level API
> [INFO] Found 1 nested API's
> [INFO] Processing top level API: ViewPrivilegeService
> [INFO] Processing nested API: NestedApiRecord {nestedApi=class
> org.apache.ambari.server.api.services.ServiceService, parentApi=class
> org.apache.ambari.server.api.services.ClusterService,
> parentApiPath='/clusters', parentMethod=public
> org.apache.ambari.server.api.services.ServiceService
> org.apache.ambari.server.api.services.ClusterService.getServiceHandler(javax.ws.rs.core.Request,java.lang.String),
> parentMethodPath='{clusterName}/services'}
> [INFO] Will copy path params from parent method: [clusterName]
> [INFO] Processing top level API: ViewDataMigrationService
> [INFO] Processing top level API: ViewPermissionService
> [INFO] Processing top level API: ViewService
> [INFO] Processing top level API: GroupService
> [INFO] Processing top level API: UserPrivilegeService
> [INFO] Processing top level API: UserAuthorizationService
> [INFO] Processing top level API: GroupPrivilegeService
> [INFO] Processing top level API: ClusterService
> [INFO] Processing top level API: RootServiceService
> [INFO] Processing top level API: ViewVersionService
> [INFO] Processing top level API: HostService
> [INFO] Processing top level API: ActionService
> [INFO] Processing top level API: StacksService
> [INFO] Processing top level API: RequestService
> [INFO] Processing top level API: BlueprintService
> [INFO] Processing top level API: UserService
> [INFO] Processing top level API: SettingService
> [INFO] Processing top level API: ActiveWidgetLayoutService
> [INFO] Processing top level API: MemberService
> [INFO] Processing top level API: ViewInstanceService
> ...
> [INFO] BUILD SUCCESS
>
> $ mvn -am -pl ambari-server -Dswagger.skip clean test-compile
> ...
> [INFO] --- swagger-maven-plugin:3.1.4:generate (default) @ ambari-server ---
> [INFO] Swagger generation is skipped.
> ...
> [INFO] BUILD SUCCESS
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 60269: AMBARI-21293. Allow skipping Swagger generation
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60269/#review178481
---
What about the other steps (generating html, copying artifacts to ambar-web)
should they also be skipped?
- Balázs Bence Sári
On June 21, 2017, 9:24 a.m., Attila Doroszlai wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60269/
> ---
>
> (Updated June 21, 2017, 9:24 a.m.)
>
>
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, and Sebastian
> Toader.
>
>
> Bugs: AMBARI-21293
> https://issues.apache.org/jira/browse/AMBARI-21293
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Swagger generation can be skipped via `-Dswagger.skip` command-line
> parameter, similar to `-Dcheckstyle.skip` and `-Drat.skip`.
>
>
> Diffs
> -
>
> ambari-server/pom.xml 1ada974911cfe8ea205853f3d315e31ec0af0c66
>
>
> Diff: https://reviews.apache.org/r/60269/diff/1/
>
>
> Testing
> ---
>
> ```
> $ mvn -am -pl ambari-server clean test-compile
> ...
> [INFO] --- swagger-maven-plugin:3.1.4:generate (default) @ ambari-server ---
> [INFO] Reflections took 133 ms to scan 1 urls, producing 28 keys and 186
> values
> [INFO] Reading custom API reader:
> org.apache.ambari.swagger.AmbariSwaggerReader
> [INFO] Reflections took 92 ms to scan 1 urls, producing 28 keys and 186 values
> [INFO] This class exists both as top level and nested API:
> org.apache.ambari.server.api.services.HostService, treating it as top level
> API
> [INFO] Registering nested API: class
> org.apache.ambari.server.api.services.ServiceService
> [INFO] This class exists both as top level and nested API:
> org.apache.ambari.server.api.services.RequestService, treating it as top
> level API
> [INFO] Found 1 nested API's
> [INFO] Processing top level API: ViewPrivilegeService
> [INFO] Processing nested API: NestedApiRecord {nestedApi=class
> org.apache.ambari.server.api.services.ServiceService, parentApi=class
> org.apache.ambari.server.api.services.ClusterService,
> parentApiPath='/clusters', parentMethod=public
> org.apache.ambari.server.api.services.ServiceService
> org.apache.ambari.server.api.services.ClusterService.getServiceHandler(javax.ws.rs.core.Request,java.lang.String),
> parentMethodPath='{clusterName}/services'}
> [INFO] Will copy path params from parent method: [clusterName]
> [INFO] Processing top level API: ViewDataMigrationService
> [INFO] Processing top level API: ViewPermissionService
> [INFO] Processing top level API: ViewService
> [INFO] Processing top level API: GroupService
> [INFO] Processing top level API: UserPrivilegeService
> [INFO] Processing top level API: UserAuthorizationService
> [INFO] Processing top level API: GroupPrivilegeService
> [INFO] Processing top level API: ClusterService
> [INFO] Processing top level API: RootServiceService
> [INFO] Processing top level API: ViewVersionService
> [INFO] Processing top level API: HostService
> [INFO] Processing top level API: ActionService
> [INFO] Processing top level API: StacksService
> [INFO] Processing top level API: RequestService
> [INFO] Processing top level API: BlueprintService
> [INFO] Processing top level API: UserService
> [INFO] Processing top level API: SettingService
> [INFO] Processing top level API: ActiveWidgetLayoutService
> [INFO] Processing top level API: MemberService
> [INFO] Processing top level API: ViewInstanceService
> ...
> [INFO] BUILD SUCCESS
>
> $ mvn -am -pl ambari-server -Dswagger.skip clean test-compile
> ...
> [INFO] --- swagger-maven-plugin:3.1.4:generate (default) @ ambari-server ---
> [INFO] Swagger generation is skipped.
> ...
> [INFO] BUILD SUCCESS
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Review Request 60081: Improve error message for Blueprints deployment with incorrect credential type
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60081/ --- Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, Robert Levas, Robert Nettleton, Sandor Magyari, and Sebastian Toader. Bugs: AMBARI-21242 https://issues.apache.org/jira/browse/AMBARI-21242 Repository: ambari Description --- Changed the exeption text to list valid credential types. Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java 2c95806 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java e0735be Diff: https://reviews.apache.org/r/60081/diff/1/ Testing --- - Tested the change manually - Modified existing unit test for the API - Run all unit tests in ambari-server, no errors. Thanks, Balázs Bence Sári
Re: Review Request 59929: Extend Swagger Maven pluging to handle nested API's
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59929/ --- (Updated June 14, 2017, 12:21 p.m.) Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader. Changes --- Fix review comment Bugs: AMBARI-21207 https://issues.apache.org/jira/browse/AMBARI-21207 Repository: ambari Description --- Wrote a custom SwaggerReader in the utility project that handles nested API's. There is currently one nested API which is annotated for swagger: org.apache.ambari.server.api.services.ServiceService (nested under ClusterService). Using the custom reader operation paths and parameters are generated correctly for the nested API. Diffs (updated) - ambari-project/pom.xml 9bb2e26 ambari-server/pom.xml a1cd239 ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f61fb2a ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java a28c4aa utility/pom.xml 918080e utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java PRE-CREATION utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java PRE-CREATION utility/src/test/resources/log4j.properties PRE-CREATION Diff: https://reviews.apache.org/r/59929/diff/5/ Changes: https://reviews.apache.org/r/59929/diff/4-5/ Testing --- Tested Swagger API generation manually. Wrote new unit tests. Run all unit tests for the ambari-server and utility projects, no errors or failures. Thanks, Balázs Bence Sári
Re: Review Request 59929: Extend Swagger Maven pluging to handle nested API's
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59929/ --- (Updated June 14, 2017, 10:38 a.m.) Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader. Changes --- Rebased patch Bugs: AMBARI-21207 https://issues.apache.org/jira/browse/AMBARI-21207 Repository: ambari Description --- Wrote a custom SwaggerReader in the utility project that handles nested API's. There is currently one nested API which is annotated for swagger: org.apache.ambari.server.api.services.ServiceService (nested under ClusterService). Using the custom reader operation paths and parameters are generated correctly for the nested API. Diffs (updated) - ambari-project/pom.xml 9bb2e26 ambari-server/pom.xml a1cd239 ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f61fb2a ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java a28c4aa utility/pom.xml 918080e utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java PRE-CREATION utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java PRE-CREATION utility/src/test/resources/log4j.properties PRE-CREATION Diff: https://reviews.apache.org/r/59929/diff/4/ Changes: https://reviews.apache.org/r/59929/diff/3-4/ Testing --- Tested Swagger API generation manually. Wrote new unit tests. Run all unit tests for the ambari-server and utility projects, no errors or failures. Thanks, Balázs Bence Sári
Re: Review Request 59929: Extend Swagger Maven pluging to handle nested API's
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59929/ --- (Updated June 13, 2017, 9:39 p.m.) Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader. Changes --- organize dependencies more nicely Bugs: AMBARI-21207 https://issues.apache.org/jira/browse/AMBARI-21207 Repository: ambari Description --- Wrote a custom SwaggerReader in the utility project that handles nested API's. There is currently one nested API which is annotated for swagger: org.apache.ambari.server.api.services.ServiceService (nested under ClusterService). Using the custom reader operation paths and parameters are generated correctly for the nested API. Diffs (updated) - ambari-project/pom.xml 64d1416 ambari-server/pom.xml 669f90f ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f61fb2a ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java a28c4aa utility/pom.xml 7d5eb93 utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java PRE-CREATION utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java PRE-CREATION utility/src/test/resources/log4j.properties PRE-CREATION Diff: https://reviews.apache.org/r/59929/diff/3/ Changes: https://reviews.apache.org/r/59929/diff/2-3/ Testing --- Tested Swagger API generation manually. Wrote new unit tests. Run all unit tests for the ambari-server and utility projects, no errors or failures. Thanks, Balázs Bence Sári
Re: Review Request 59929: Extend Swagger Maven pluging to handle nested API's
> On June 12, 2017, 10:48 a.m., Attila Doroszlai wrote:
> > utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java
> > Lines 56 (patched)
> > <https://reviews.apache.org/r/59929/diff/1/?file=1744990#file1744990line56>
> >
> > Should be `LOG`, not `logger`
Unfortunately, LOG denotes an existing member variable which is a (less
sophisticated than slfj) Maven logger. I chose slf4j for logging, but I had to
chose a different variable name.
> On June 12, 2017, 10:48 a.m., Attila Doroszlai wrote:
> > utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java
> > Lines 80 (patched)
> > <https://reviews.apache.org/r/59929/diff/1/?file=1744990#file1744990line80>
> >
> > Please avoid + in `debug` message, use placeholders (`{}`) instead.
This is a reainder of switching logger implementations back and forth (slf4j vs
maven logging). I'll fix it.
- Balázs Bence
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59929/#review177602
-------
On June 12, 2017, 10:09 p.m., Balázs Bence Sári wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59929/
> ---
>
> (Updated June 12, 2017, 10:09 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo,
> Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-21207
> https://issues.apache.org/jira/browse/AMBARI-21207
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Wrote a custom SwaggerReader in the utility project that handles nested
> API's. There is currently one nested API which is annotated for swagger:
> org.apache.ambari.server.api.services.ServiceService (nested under
> ClusterService). Using the custom reader operation paths and parameters are
> generated correctly for the nested API.
>
>
> Diffs
> -
>
> ambari-project/pom.xml 64d1416
> ambari-server/pom.xml 669f90f
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
> f61fb2a
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
> a28c4aa
> utility/pom.xml 7d5eb93
> utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java
> PRE-CREATION
>
> utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java
> PRE-CREATION
> utility/src/test/resources/log4j.properties PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/59929/diff/2/
>
>
> Testing
> ---
>
> Tested Swagger API generation manually. Wrote new unit tests. Run all unit
> tests for the ambari-server and utility projects, no errors or failures.
>
>
> Thanks,
>
> Balázs Bence Sári
>
>
Re: Review Request 59929: Extend Swagger Maven pluging to handle nested API's
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59929/ --- (Updated June 12, 2017, 10:09 p.m.) Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader. Changes --- Review comments fixed. Bugs: AMBARI-21207 https://issues.apache.org/jira/browse/AMBARI-21207 Repository: ambari Description --- Wrote a custom SwaggerReader in the utility project that handles nested API's. There is currently one nested API which is annotated for swagger: org.apache.ambari.server.api.services.ServiceService (nested under ClusterService). Using the custom reader operation paths and parameters are generated correctly for the nested API. Diffs (updated) - ambari-project/pom.xml 64d1416 ambari-server/pom.xml 669f90f ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f61fb2a ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java a28c4aa utility/pom.xml 7d5eb93 utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java PRE-CREATION utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java PRE-CREATION utility/src/test/resources/log4j.properties PRE-CREATION Diff: https://reviews.apache.org/r/59929/diff/2/ Changes: https://reviews.apache.org/r/59929/diff/1-2/ Testing --- Tested Swagger API generation manually. Wrote new unit tests. Run all unit tests for the ambari-server and utility projects, no errors or failures. Thanks, Balázs Bence Sári
Review Request 59929: Extend Swagger Maven pluging to handle nested API's
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59929/ --- Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader. Bugs: AMBARI-21207 https://issues.apache.org/jira/browse/AMBARI-21207 Repository: ambari Description --- Wrote a custom SwaggerReader in the utility project that handles nested API's. There is currently one nested API which is annotated for swagger: org.apache.ambari.server.api.services.ServiceService (nested under ClusterService). Using the custom reader operation paths and parameters are generated correctly for the nested API. Diffs - ambari-server/pom.xml c0aed7b ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java f61fb2a ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java a28c4aa utility/pom.xml 7d5eb93 utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java PRE-CREATION utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java PRE-CREATION utility/src/test/resources/log4j.properties PRE-CREATION Diff: https://reviews.apache.org/r/59929/diff/1/ Testing --- Tested Swagger API generation manually. Wrote new unit tests. Run all unit tests for the ambari-server and utility projects, no errors or failures. Thanks, Balázs Bence Sári
Re: Review Request 59391: Integrate RequestService resource and it's subresources with swagger
> On May 20, 2017, 7:10 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java > > Line 26 (original), 27 (patched) > > <https://reviews.apache.org/r/59391/diff/2/?file=1724772#file1724772line27> > > > > The "dummy" interface `RequestPostRequest` also defines a > > `RequestResourceFilter`. Is this one really an `ApiModel`? > > Balázs Bence Sári wrote: > Th top level RequestResourceFilter class doesn't encapsulate all > information contained by the schema, hence the new one. > > Attila Doroszlai wrote: > Yes, I understand that. The question is whether we need the old one to > be an `ApiModel`. I think no because the new one is used for schema generation. - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59391/#review175589 ------- On May 22, 2017, 11:41 a.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59391/ > --- > > (Updated May 22, 2017, 11:41 a.m.) > > > Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, > Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-21063 > https://issues.apache.org/jira/browse/AMBARI-21063 > > > Repository: ambari > > > Description > --- > > Annotated RequrstServices and request/response models with Swagger > annotations. Sub-resources are skipped as Swagger doesn't support them out of > the box in their current form. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java > 936b857 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostRequest.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPutRequest.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/RequestRequest.java > db9268b > > ambari-server/src/main/java/org/apache/ambari/server/controller/RequestResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java > 4028e35 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java > 9704b33 > > > Diff: https://reviews.apache.org/r/59391/diff/3/ > > > Testing > --- > > Unit tests pendig. > > > Thanks, > > Balázs Bence Sári > >
Re: Review Request 59391: Integrate RequestService resource and it's subresources with swagger
> On May 20, 2017, 7:10 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java > > Line 26 (original), 27 (patched) > > <https://reviews.apache.org/r/59391/diff/2/?file=1724772#file1724772line27> > > > > The "dummy" interface `RequestPostRequest` also defines a > > `RequestResourceFilter`. Is this one really an `ApiModel`? Th top level RequestResourceFilter class doesn't encapsulate all information contained by the schema, hence the new one. - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59391/#review175589 ------- On May 22, 2017, 11:41 a.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59391/ > --- > > (Updated May 22, 2017, 11:41 a.m.) > > > Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, > Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-21063 > https://issues.apache.org/jira/browse/AMBARI-21063 > > > Repository: ambari > > > Description > --- > > Annotated RequrstServices and request/response models with Swagger > annotations. Sub-resources are skipped as Swagger doesn't support them out of > the box in their current form. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java > 936b857 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostRequest.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPutRequest.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/RequestRequest.java > db9268b > > ambari-server/src/main/java/org/apache/ambari/server/controller/RequestResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java > 4028e35 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java > 9704b33 > > > Diff: https://reviews.apache.org/r/59391/diff/3/ > > > Testing > --- > > Unit tests pendig. > > > Thanks, > > Balázs Bence Sári > >
Re: Review Request 59391: Integrate RequestService resource and it's subresources with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59391/ --- (Updated May 22, 2017, 11:41 a.m.) Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader. Changes --- Review comments Bugs: AMBARI-21063 https://issues.apache.org/jira/browse/AMBARI-21063 Repository: ambari Description --- Annotated RequrstServices and request/response models with Swagger annotations. Sub-resources are skipped as Swagger doesn't support them out of the box in their current form. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java 936b857 ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostRequest.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPutRequest.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/RequestRequest.java db9268b ambari-server/src/main/java/org/apache/ambari/server/controller/RequestResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java 4028e35 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 9704b33 Diff: https://reviews.apache.org/r/59391/diff/3/ Changes: https://reviews.apache.org/r/59391/diff/2-3/ Testing --- Unit tests pendig. Thanks, Balázs Bence Sári
Re: Review Request 59391: Integrate RequestService resource and it's subresources with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59391/ --- (Updated May 19, 2017, 9:41 a.m.) Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader. Bugs: AMBARI-21063 https://issues.apache.org/jira/browse/AMBARI-21063 Repository: ambari Description --- Annotated RequrstServices and request/response models with Swagger annotations. Sub-resources are skipped as Swagger doesn't support them out of the box in their current form. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java 936b857 ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostRequest.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPutRequest.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/RequestRequest.java db9268b ambari-server/src/main/java/org/apache/ambari/server/controller/RequestResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java 4028e35 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 9704b33 Diff: https://reviews.apache.org/r/59391/diff/2/ Changes: https://reviews.apache.org/r/59391/diff/1-2/ Testing --- Unit tests pendig. Thanks, Balázs Bence Sári
Review Request 59391: Integrate RequestService resource and it's subresources with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59391/ --- Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader. Bugs: AMBARI-21063 https://issues.apache.org/jira/browse/AMBARI-21063 Repository: ambari Description --- Annotated RequrstServices and request/response models with Swagger annotations. Sub-resources are skipped as Swagger doesn't support them out of the box in their current form. Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java 936b857 ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostRequest.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPutRequest.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/RequestRequest.java db9268b ambari-server/src/main/java/org/apache/ambari/server/controller/RequestResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java 4028e35 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java 9704b33 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java a2b0a0c Diff: https://reviews.apache.org/r/59391/diff/1/ Testing --- Unit tests pendig. Thanks, Balázs Bence Sári
Re: Review Request 59281: Integrate BlueprintService and subresources with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59281/ --- (Updated May 18, 2017, 9:27 a.m.) Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader. Changes --- Review comments fixed Bugs: AMBARI-21026 https://issues.apache.org/jira/browse/AMBARI-21026 Repository: ambari Description --- Documented the Blueprint API. Kerberos descriptor in Blueprint schema is not elaborated. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java 2808911 ambari-server/src/main/java/org/apache/ambari/server/api/services/BlueprintService.java 8159ea4 ambari-server/src/main/java/org/apache/ambari/server/controller/BlueprintSwagger.java PRE-CREATION Diff: https://reviews.apache.org/r/59281/diff/2/ Changes: https://reviews.apache.org/r/59281/diff/1-2/ Testing --- All unit tests for ambari-server pass, except ServicePropertiesTest.validatePropertySchemaOfServiceXMLs, which fails due to AMBARI-20443. Thanks, Balázs Bence Sári
Re: Review Request 59306: AMBARI-21029. Integrate SettingService with Swagger (adoroszlai)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59306/#review175075 --- Ship it! Ship It! - Balázs Bence Sári On May 16, 2017, 9:24 a.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59306/ > --- > > (Updated May 16, 2017, 9:24 a.m.) > > > Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, > Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-21029 > https://issues.apache.org/jira/browse/AMBARI-21029 > > > Repository: ambari > > > Description > --- > > * added request, request wrapper, response > * documented API > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/SettingRequestWrapper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/services/SettingService.java > e186be2afc31b26895dc88a67d4c88c914eff19e > > ambari-server/src/main/java/org/apache/ambari/server/controller/SettingRequest.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/SettingResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/SettingResourceProvider.java > e50490e5dd3aa8195dac36b2fb322408d7aab7df > > ambari-server/src/test/java/org/apache/ambari/server/api/services/SettingServiceTest.java > 1bc75ff38ccced3a4c5f03c6b67d9cfa316597d4 > > > Diff: https://reviews.apache.org/r/59306/diff/1/ > > > Testing > --- > > * verified generated doc > * `SettingResourceProviderTest` and `SettingServiceTest` pass > > > Thanks, > > Attila Doroszlai > >
Re: Review Request 59236: Integrate ActionService and subresources with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59236/ --- (Updated May 15, 2017, 8:50 p.m.) Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader. Changes --- Fixed 1 review comment. Bugs: AMBARI-21009 https://issues.apache.org/jira/browse/AMBARI-21009 Repository: ambari Description --- Annotated ActionService with Swagger annotations Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/ActionService.java 0290151 ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java 0b2afd1 ambari-server/src/main/java/org/apache/ambari/server/controller/ActionRequest.java 7a4fd36 ambari-server/src/main/java/org/apache/ambari/server/controller/ActionRequestSwagger.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ActionResponse.java e7edafb Diff: https://reviews.apache.org/r/59236/diff/3/ Changes: https://reviews.apache.org/r/59236/diff/2-3/ Testing (updated) --- All unit tests for ambari-server pass, except ServicePropertiesTest.validatePropertySchemaOfServiceXMLs, which fails due to AMBARI-20443. Thanks, Balázs Bence Sári
Re: Review Request 59224: Integrate ServiceService resource and it's subresources with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59224/ --- (Updated May 15, 2017, 8:04 p.m.) Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader. Changes --- Fix review comments and delete multiple API Bugs: AMBARI-20995 https://issues.apache.org/jira/browse/AMBARI-20995 Repository: ambari Description --- Documented ServiceService (except 3 calls that return other services - Swagger can't handle them out of the box). Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java 0b2afd1 ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java 52871f2 ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterServiceArtifactRequest.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterServiceArtifactResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java 6c0d4ea ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequestSwagger.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceResponse.java 3e35c0c Diff: https://reviews.apache.org/r/59224/diff/4/ Changes: https://reviews.apache.org/r/59224/diff/3-4/ Testing --- All unit tests for ambari-server pass, except ServicePropertiesTest.validatePropertySchemaOfServiceXMLs, which fails due to AMBARI-20443. Thanks, Balázs Bence Sári
Review Request 59281: Integrate BlueprintService and subresources with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59281/ --- Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader. Bugs: AMBARI-21026 https://issues.apache.org/jira/browse/AMBARI-21026 Repository: ambari Description --- Documented the Blueprint API. Kerberos descriptor in Blueprint schema is not elaborated. Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java 0b2afd1 ambari-server/src/main/java/org/apache/ambari/server/api/services/BlueprintService.java 8159ea4 ambari-server/src/main/java/org/apache/ambari/server/controller/BlueprintSwagger.java PRE-CREATION Diff: https://reviews.apache.org/r/59281/diff/1/ Testing --- All unit tests for ambari-server pass, except ServicePropertiesTest.validatePropertySchemaOfServiceXMLs, which fails due to AMBARI-20443. Thanks, Balázs Bence Sári
Re: Review Request 59224: Integrate ServiceService resource and it's subresources with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59224/ --- (Updated May 12, 2017, 7:29 p.m.) Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader. Changes --- Fix 400 messages Bugs: AMBARI-20995 https://issues.apache.org/jira/browse/AMBARI-20995 Repository: ambari Description --- Documented ServiceService (except 3 calls that return other services - Swagger can't handle them out of the box). Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java 0b2afd1 ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java 52871f2 ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterServiceArtifactRequest.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterServiceArtifactResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java 6c0d4ea ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequestSwagger.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceResponse.java 3e35c0c Diff: https://reviews.apache.org/r/59224/diff/3/ Changes: https://reviews.apache.org/r/59224/diff/2-3/ Testing --- All unit tests for ambari-server pass, except ServicePropertiesTest.validatePropertySchemaOfServiceXMLs, which fails due to AMBARI-20443. Thanks, Balázs Bence Sári
Re: Review Request 59236: Integrate ActionService and subresources with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59236/ --- (Updated May 12, 2017, 6:59 p.m.) Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader. Bugs: AMBARI-21009 https://issues.apache.org/jira/browse/AMBARI-21009 Repository: ambari Description --- Annotated ActionService with Swagger annotations Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/ActionService.java 0290151 ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java 0b2afd1 ambari-server/src/main/java/org/apache/ambari/server/controller/ActionRequest.java 7a4fd36 ambari-server/src/main/java/org/apache/ambari/server/controller/ActionRequestSwagger.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ActionResponse.java e7edafb Diff: https://reviews.apache.org/r/59236/diff/2/ Changes: https://reviews.apache.org/r/59236/diff/1-2/ Testing --- Unit tests pending. Thanks, Balázs Bence Sári
Review Request 59236: Integrate ActionService and subresources with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59236/ --- Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader. Bugs: AMBARI-21009 https://issues.apache.org/jira/browse/AMBARI-21009 Repository: ambari Description --- Annotated ActionService with Swagger annotations Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/ActionService.java 0290151 ambari-server/src/main/java/org/apache/ambari/server/controller/ActionRequest.java 7a4fd36 ambari-server/src/main/java/org/apache/ambari/server/controller/ActionRequestSwagger.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ActionResponse.java e7edafb Diff: https://reviews.apache.org/r/59236/diff/1/ Testing --- Unit tests pending. Thanks, Balázs Bence Sári
Re: Review Request 59224: Integrate ServiceService resource and it's subresources with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59224/ --- (Updated May 12, 2017, 6:05 p.m.) Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader. Changes --- fixed import issues Bugs: AMBARI-20995 https://issues.apache.org/jira/browse/AMBARI-20995 Repository: ambari Description --- Documented ServiceService (except 3 calls that return other services - Swagger can't handle them out of the box). Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java 0b2afd1 ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java 52871f2 ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterServiceArtifactRequest.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterServiceArtifactResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java 6c0d4ea ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequestSwagger.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceResponse.java 3e35c0c Diff: https://reviews.apache.org/r/59224/diff/2/ Changes: https://reviews.apache.org/r/59224/diff/1-2/ Testing --- All unit tests for ambari-server pass, except ServicePropertiesTest.validatePropertySchemaOfServiceXMLs, which fails due to AMBARI-20443. Thanks, Balázs Bence Sári
Review Request 59224: Integrate ServiceService resource and it's subresources with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59224/ --- Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader. Bugs: AMBARI-20995 https://issues.apache.org/jira/browse/AMBARI-20995 Repository: ambari Description --- Documented ServiceService (except 3 calls that return other services - Swagger can't handle them out of the box). Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java 0b2afd1 ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java 52871f2 ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterServiceArtifactRequest.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterServiceArtifactResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java 6c0d4ea ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequestSwagger.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceResponse.java 3e35c0c Diff: https://reviews.apache.org/r/59224/diff/1/ Testing --- All unit tests for ambari-server pass, except ServicePropertiesTest.validatePropertySchemaOfServiceXMLs, which fails due to AMBARI-20443. Thanks, Balázs Bence Sári
Re: Review Request 59104: Integrate StackService resource and it's subresources with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59104/ --- (Updated May 10, 2017, 3:10 p.m.) Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader. Changes --- Fixed import issues, deleted http constants. Bugs: AMBARI-20970 https://issues.apache.org/jira/browse/AMBARI-20970 Repository: ambari Description --- - Documented StackssService (except 3 calls that return other services - Swagger can't handle them out of the box) - Some inaccuracies on the response schema (e.g. Artifact and Configuration queries use the same response object, so service_name is reported for the stack level API call) - subresources are partially covered Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java 76d2b70 ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java 7b5f9cf ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java 86bacf1 ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserService.java 47515c9 ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java 8e87e6f ambari-server/src/main/java/org/apache/ambari/server/controller/ComponentDependencyResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkResponse.java 99c9ce9 ambari-server/src/main/java/org/apache/ambari/server/controller/QuickLinksResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/StackArtifactResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationDependencyResponse.java 14aab3b ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java 0338ed9 ambari-server/src/main/java/org/apache/ambari/server/controller/StackResponse.java 1901337 ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceArtifactResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java b48fad3 ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java 8e4200d ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java 3c65d05 ambari-server/src/main/java/org/apache/ambari/server/controller/ThemeResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ViewInstanceResponse.java d0a5206 ambari-server/src/main/java/org/apache/ambari/server/state/QuickLinksConfigurationInfo.java d4bdce8 ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 353dd86 ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java c41cd9a ambari-server/src/main/java/org/apache/ambari/server/state/ValueEntryInfo.java 7824933 ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigCondition.java a28d149 ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigPlacement.java 3bb8c77 ambari-server/src/main/java/org/apache/ambari/server/state/theme/Layout.java 840dbf0 ambari-server/src/main/java/org/apache/ambari/server/state/theme/Section.java 43d2170 ambari-server/src/main/java/org/apache/ambari/server/state/theme/Subsection.java 62fbfc1 ambari-server/src/main/java/org/apache/ambari/server/state/theme/Tab.java b949a12 ambari-server/src/main/java/org/apache/ambari/server/state/theme/TabLayout.java f7d4187 ambari-server/src/main/java/org/apache/ambari/server/state/theme/Theme.java 96d2fc0 ambari-server/src/main/java/org/apache/ambari/server/state/theme/ThemeConfiguration.java 58fe942 ambari-server/src/main/java/org/apache/ambari/server/state/theme/Unit.java 7bd058c ambari-server/src/main/java/org/apache/ambari/server/state/theme/Widget.java 1f38d8e ambari-server/src/main/java/org/apache/ambari/server/state/theme/WidgetEntry.java 9e9c068 docs/api/generated/swagger.json PRE-CREATION Diff: https://reviews.apache.org/r/59104/diff/3/ Changes: https://reviews.apache.org/r/59104/diff/2-3/ Testing --- All unit tests for ambari-server pass, except ServicePropertiesTest, which fails due to AMBARI-20443. Thanks, Balázs Bence Sári
Re: Review Request 59104: Integrate StackService resource and it's subresources with swagger
> On May 9, 2017, 7:17 p.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java > > Lines 52-54 (original), 54-56 (patched) > > <https://reviews.apache.org/r/59104/diff/2/?file=1711673#file1711673line54> > > > > Do we need really these constants? HttpStatus constants are defined in many libraries used by ambari-server and it is not obvious which one to chose. Instead of picking one randomly I created our own to promote a standard solution. - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59104/#review174358 ------- On May 9, 2017, 6:40 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59104/ > --- > > (Updated May 9, 2017, 6:40 p.m.) > > > Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, > Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-20970 > https://issues.apache.org/jira/browse/AMBARI-20970 > > > Repository: ambari > > > Description > --- > > - Documented StackssService (except 3 calls that return other services - > Swagger can't handle them out of the box) > - Some inaccuracies on the response schema (e.g. Artifact and Configuration > queries use the same response object, so service_name is reported for the > stack level API call) > - subresources are partially covered > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java > 76d2b70 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java > 7b5f9cf > > ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java > 86bacf1 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserService.java > 47515c9 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java > 8e87e6f > > ambari-server/src/main/java/org/apache/ambari/server/controller/ComponentDependencyResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkResponse.java > 99c9ce9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/QuickLinksResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackArtifactResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationDependencyResponse.java > 14aab3b > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java > 0338ed9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackResponse.java > 1901337 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceArtifactResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java > b48fad3 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java > 8e4200d > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java > 3c65d05 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ThemeResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/ViewInstanceResponse.java > d0a5206 > > ambari-server/src/main/java/org/apache/ambari/server/state/QuickLinksConfigurationInfo.java > d4bdce8 > ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java > 353dd86 > > ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java > c41cd9a > > ambari-server/src/main/java/org/apache/ambari/server/state/ValueEntryInfo.java > 7824933 > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigCondition.java > a28d149 > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigPlacement.java > 3bb8c77 > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/Layout.java > 840dbf0 > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/Section.java > 43d2170 > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/Subsection.java > 62fb
Re: Review Request 59104: Integrate StackService resource and it's subresources with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59104/ --- (Updated May 9, 2017, 6:40 p.m.) Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader. Changes --- deleted some unused imports Bugs: AMBARI-20970 https://issues.apache.org/jira/browse/AMBARI-20970 Repository: ambari Description --- - Documented StackssService (except 3 calls that return other services - Swagger can't handle them out of the box) - Some inaccuracies on the response schema (e.g. Artifact and Configuration queries use the same response object, so service_name is reported for the stack level API call) - subresources are partially covered Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java 76d2b70 ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java 7b5f9cf ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java 86bacf1 ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserService.java 47515c9 ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java 8e87e6f ambari-server/src/main/java/org/apache/ambari/server/controller/ComponentDependencyResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkResponse.java 99c9ce9 ambari-server/src/main/java/org/apache/ambari/server/controller/QuickLinksResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/StackArtifactResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationDependencyResponse.java 14aab3b ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java 0338ed9 ambari-server/src/main/java/org/apache/ambari/server/controller/StackResponse.java 1901337 ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceArtifactResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java b48fad3 ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java 8e4200d ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java 3c65d05 ambari-server/src/main/java/org/apache/ambari/server/controller/ThemeResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ViewInstanceResponse.java d0a5206 ambari-server/src/main/java/org/apache/ambari/server/state/QuickLinksConfigurationInfo.java d4bdce8 ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 353dd86 ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java c41cd9a ambari-server/src/main/java/org/apache/ambari/server/state/ValueEntryInfo.java 7824933 ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigCondition.java a28d149 ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigPlacement.java 3bb8c77 ambari-server/src/main/java/org/apache/ambari/server/state/theme/Layout.java 840dbf0 ambari-server/src/main/java/org/apache/ambari/server/state/theme/Section.java 43d2170 ambari-server/src/main/java/org/apache/ambari/server/state/theme/Subsection.java 62fbfc1 ambari-server/src/main/java/org/apache/ambari/server/state/theme/Tab.java b949a12 ambari-server/src/main/java/org/apache/ambari/server/state/theme/TabLayout.java f7d4187 ambari-server/src/main/java/org/apache/ambari/server/state/theme/Theme.java 96d2fc0 ambari-server/src/main/java/org/apache/ambari/server/state/theme/ThemeConfiguration.java 58fe942 ambari-server/src/main/java/org/apache/ambari/server/state/theme/Unit.java 7bd058c ambari-server/src/main/java/org/apache/ambari/server/state/theme/Widget.java 1f38d8e ambari-server/src/main/java/org/apache/ambari/server/state/theme/WidgetEntry.java 9e9c068 Diff: https://reviews.apache.org/r/59104/diff/2/ Changes: https://reviews.apache.org/r/59104/diff/1-2/ Testing --- All unit tests for ambari-server pass, except ServicePropertiesTest, which fails due to AMBARI-20443. Thanks, Balázs Bence Sári
Review Request 59104: Integrate StackService resource and it's subresources with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59104/ --- Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader. Repository: ambari Description --- - Documented StackssService (except 3 calls that return other services - Swagger can't handle them out of the box) - Some inaccuracies on the response schema (e.g. Artifact and Configuration queries use the same response object, so service_name is reported for the stack level API call) - subresources are partially covered Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java 76d2b70 ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java 7b5f9cf ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java 86bacf1 ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserService.java 47515c9 ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java 8e87e6f ambari-server/src/main/java/org/apache/ambari/server/controller/ComponentDependencyResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkResponse.java 99c9ce9 ambari-server/src/main/java/org/apache/ambari/server/controller/QuickLinksResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/StackArtifactResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationDependencyResponse.java 14aab3b ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java 0338ed9 ambari-server/src/main/java/org/apache/ambari/server/controller/StackResponse.java 1901337 ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceArtifactResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java b48fad3 ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java 8e4200d ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java 3c65d05 ambari-server/src/main/java/org/apache/ambari/server/controller/ThemeResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ViewInstanceResponse.java d0a5206 ambari-server/src/main/java/org/apache/ambari/server/state/QuickLinksConfigurationInfo.java d4bdce8 ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 353dd86 ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java c41cd9a ambari-server/src/main/java/org/apache/ambari/server/state/ValueEntryInfo.java 7824933 ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigCondition.java a28d149 ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigPlacement.java 3bb8c77 ambari-server/src/main/java/org/apache/ambari/server/state/theme/Layout.java 840dbf0 ambari-server/src/main/java/org/apache/ambari/server/state/theme/Section.java 43d2170 ambari-server/src/main/java/org/apache/ambari/server/state/theme/Subsection.java 62fbfc1 ambari-server/src/main/java/org/apache/ambari/server/state/theme/Tab.java b949a12 ambari-server/src/main/java/org/apache/ambari/server/state/theme/TabLayout.java f7d4187 ambari-server/src/main/java/org/apache/ambari/server/state/theme/Theme.java 96d2fc0 ambari-server/src/main/java/org/apache/ambari/server/state/theme/ThemeConfiguration.java 58fe942 ambari-server/src/main/java/org/apache/ambari/server/state/theme/Unit.java 7bd058c ambari-server/src/main/java/org/apache/ambari/server/state/theme/Widget.java 1f38d8e ambari-server/src/main/java/org/apache/ambari/server/state/theme/WidgetEntry.java 9e9c068 Diff: https://reviews.apache.org/r/59104/diff/1/ Testing --- All unit tests for ambari-server pass, except ServicePropertiesTest, which fails due to AMBARI-20443. Thanks, Balázs Bence Sári
Re: Review Request 59043: AMBARI-20951. Integrate HostService resource with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59043/#review174186 --- Ship it! Ship It! - Balázs Bence Sári On May 8, 2017, 7 a.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59043/ > --- > > (Updated May 8, 2017, 7 a.m.) > > > Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, > Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-20951 > https://issues.apache.org/jira/browse/AMBARI-20951 > > > Repository: ambari > > > Description > --- > > * documented `HostService`, `HostRequest`, `HostResponse` > * removed unused attributes > * introduced constants for common Swagger parameters > * subresources are not covered yet > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java > 0185d37f1a9127c2bd414229b8ab7885e849fbf4 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java > c26c5d85d4c90a1aee81cb5aafbcac49d185c5e2 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java > d05fe9dce86eaa712807c50744c1fb93000fbe56 > > ambari-server/src/main/java/org/apache/ambari/server/controller/HostRequest.java > a6168394bf4be45497924e73c84aae393d1c53fe > > ambari-server/src/main/java/org/apache/ambari/server/controller/HostResponse.java > 8032801dd7014b9532b5358c8fc44e5250b90c66 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java > 40fe3697e98acff0a36dd24f3e51193683b5af93 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java > f604a7f8be9b2dad7810e46444ae79ead73f8a98 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStatusHelper.java > 96457ed6302f98f6b402eb27f49cffc41bfe4585 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java > c2fb844ff7e81d8291ae27359dac864aadf50430 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java > b5d2f9de8a297b68ee569b92bc475e39b39986d2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java > c747a33a7d352d8614a573a6b9f3f7149ac5df7c > > ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java > db228b194e240a0c895072362ae68d1973742cef > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > 6d12402e9da92985176c8724f6b705304bba03e3 > > ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java > 168d13b44777b1891e72287de035e99d1064ab72 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/HostServiceTest.java > 6aef04dda19693cd2408dcfce9be5ca8751550e4 > > ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java > 2d1cefcfdcb3604d54338c4c0b314c5fbb740b50 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 554e0891020d90593aeee76cbeddf65f5b66e2b0 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java > c7613231b13c8402cffe29f90fac2449e0f0a395 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java > ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java > f15c9f2baa20fb69b855d24badb144e354b83891 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java > 48d1351dc527488cea06168d2fe0fcc90d9a6eb7 > > ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java > 2d5978b1788572c716ddfaae2e56b9502097e98f > > > Diff: https://reviews.apache.org/r/59043/diff/1/ > > > Testing > --- > > Unit tests pass, except `ServicePropertiesTest`, which fails due to > [AMBARI-20443](https://issues.apache.org/jira/browse/AMBARI-20443). > > ``` > $ mvn -am -pl ambari-server clean test > ... > Tests in error: > ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:49 » Ambari File > /Us... > > Tests run: 4971, Failures: 0, Errors: 1, Skipped: 39 > ``` > > > Thanks, > > Attila Doroszlai > >
Re: Review Request 58574: BE: Characters used in usernames should be constrained
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58574/#review172614
---
Ship it!
Ship It!
- Balázs Bence Sári
On April 21, 2017, 8:15 a.m., Attila Magyar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58574/
> ---
>
> (Updated April 21, 2017, 8:15 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas,
> and Sebastian Toader.
>
>
> Bugs: AMBARI-20771
> https://issues.apache.org/jira/browse/AMBARI-20771
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Characters used in usernames should be constrained such that they cannot
> contain the following characters:
> Less than symbols ( < )
> Greater than symbols ( > )
> Ampersand ( & )
> Back slashes ( \ )
> Backtick ( ` )
> Pipe ( | )
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java
> 576ca97
>
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserName.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
> 4ed777b
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java
> fdc19d1
>
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserDAOTest.java
> bb0b0cf
>
> ambari-server/src/test/java/org/apache/ambari/server/security/SecurityHelperImplTest.java
> d69d49a
>
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
> 6b98a5b
>
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
> 9ff381f
>
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariUserAuthenticationFilterTest.java
> 6541a59
>
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UserNameTest.java
> PRE-CREATION
>
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UsersTest.java
> f426c85
>
> ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
> e5e36f3
>
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
> e31a428
>
>
> Diff: https://reviews.apache.org/r/58574/diff/3/
>
>
> Testing
> ---
>
> Added new unittest, tested manually at end to end level using curl.
>
>
> [root@c6401 vagrant]# curl -H "X-Requested-By: Ambari" -H "Content-Type:
> application/json" -u admin:admin -d
> '{"Users/user_name":"admin34`","Users/password":"admin","Users/active":true,"Users/admin":false}'
> http://c6401.ambari.apache.org:8080/api/v1/users
> {
> "status" : 400,
> "message" : "Invalid username: admin34` Avoid characters [<, >, &, |, \, `]"
> }
>
> Existing tests: PENDING
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57959/ --- (Updated March 30, 2017, 7:04 p.m.) Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor Magyari, and Sebastian Toader. Changes --- Review comments. Bugs: AMBARI-20586 https://issues.apache.org/jira/browse/AMBARI-20586 Repository: ambari Description --- Added master_kdc to kerberos env and the krb5 config template. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 25f2001 ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml 965ee13 ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml c692b92 ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py 8cb1f0c ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py 57f062a ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2 0191953 ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml 7016437 ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml c692b92 ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_common.py 70c81e7 ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/params.py 3533b35 ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2 0191953 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java fa2082b ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 6727b2f ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 Diff: https://reviews.apache.org/r/57959/diff/4/ Changes: https://reviews.apache.org/r/57959/diff/3-4/ Testing --- - Tested manually - Updated Java unit tests - All ambari-server unit tests pass. Thanks, Balázs Bence Sári
Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57959/ --- (Updated March 30, 2017, 3:25 p.m.) Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor Magyari, and Sebastian Toader. Changes --- Removed duplicate template definition Bugs: AMBARI-20586 https://issues.apache.org/jira/browse/AMBARI-20586 Repository: ambari Description --- Added master_kdc to kerberos env and the krb5 config template. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 25f2001 ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml 965ee13 ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml c692b92 ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py 8cb1f0c ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py 57f062a ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2 0191953 ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml 7016437 ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml c692b92 ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2 0191953 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java fa2082b ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 6727b2f ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 Diff: https://reviews.apache.org/r/57959/diff/3/ Changes: https://reviews.apache.org/r/57959/diff/2-3/ Testing --- - Tested manually - Updated Java unit tests - All ambari-server unit tests pass. Thanks, Balázs Bence Sári
Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file
> On March 27, 2017, 3:18 p.m., Sebastian Toader wrote:
> > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
> > Lines 60-63 (original), 60-63 (patched)
> > <https://reviews.apache.org/r/57959/diff/1/?file=1676915#file1676915line60>
> >
> > This looks to be a duplication of the j2 file. Keep only just the j2
> > file and reference it from here.
>
> Balázs Bence Sári wrote:
> I tested this out:
> - In order to the reference the .j2 file from the xml, I need to move it
> from the *package/templates* folder to the *properties* folder.
> - There is a direct reference to the template from *kerberos-common.py*.
> If I move the script to the *properties* folder, that reference will be
> broken. Changing the path in Template constructor to
> *Template('../../properties/krb5_conf.j2')* will not fix it as the file will
> not be pushed to the agent.
>
> There are two ways I can deal with this duplication:
> 1. Keep the .j2 file in both *properties* and *package/templates* (still
> duplication, but better than pasting it to the xml)
> 2. Move the .j2 file to *properties* and only use *InlineTemplate* in
> *kerberos-common.py* (remove the if-else construct around line 119). I tested
> blueprint istallation and *InlineTemplate* is used i that case too, don't
> know when the else case is triggered.
... I mean "don't know when the **if** case is triggered"
- Balázs Bence
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57959/#review170180
---
On March 27, 2017, 2:54 p.m., Balázs Bence Sári wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57959/
> ---
>
> (Updated March 27, 2017, 2:54 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor
> Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-20586
> https://issues.apache.org/jira/browse/AMBARI-20586
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Added master_kdc to kerberos env and the krb5 config template.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
> 25f2001
>
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
> 965ee13
>
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
> c692b92
>
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
> 57f062a
>
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
> 0191953
>
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
> 7016437
>
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml
> c692b92
>
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2
> 0191953
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
> fa2082b
> ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py
> 6727b2f
> ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88
>
>
> Diff: https://reviews.apache.org/r/57959/diff/2/
>
>
> Testing
> ---
>
> - Tested manually
> - Updated Java unit tests
> - All ambari-server unit tests pass.
>
>
> Thanks,
>
> Balázs Bence Sári
>
>
Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file
> On March 27, 2017, 3:18 p.m., Sebastian Toader wrote:
> > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
> > Lines 60-63 (original), 60-63 (patched)
> > <https://reviews.apache.org/r/57959/diff/1/?file=1676915#file1676915line60>
> >
> > This looks to be a duplication of the j2 file. Keep only just the j2
> > file and reference it from here.
I tested this out:
- In order to the reference the .j2 file from the xml, I need to move it from
the *package/templates* folder to the *properties* folder.
- There is a direct reference to the template from *kerberos-common.py*. If I
move the script to the *properties* folder, that reference will be broken.
Changing the path in Template constructor to
*Template('../../properties/krb5_conf.j2')* will not fix it as the file will
not be pushed to the agent.
There are two ways I can deal with this duplication:
1. Keep the .j2 file in both *properties* and *package/templates* (still
duplication, but better than pasting it to the xml)
2. Move the .j2 file to *properties* and only use *InlineTemplate* in
*kerberos-common.py* (remove the if-else construct around line 119). I tested
blueprint istallation and *InlineTemplate* is used i that case too, don't know
when the else case is triggered.
- Balázs Bence
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57959/#review170180
-------
On March 27, 2017, 2:54 p.m., Balázs Bence Sári wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57959/
> ---
>
> (Updated March 27, 2017, 2:54 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor
> Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-20586
> https://issues.apache.org/jira/browse/AMBARI-20586
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Added master_kdc to kerberos env and the krb5 config template.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
> 25f2001
>
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
> 965ee13
>
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
> c692b92
>
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
> 57f062a
>
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
> 0191953
>
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
> 7016437
>
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml
> c692b92
>
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2
> 0191953
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
> fa2082b
> ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py
> 6727b2f
> ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88
>
>
> Diff: https://reviews.apache.org/r/57959/diff/2/
>
>
> Testing
> ---
>
> - Tested manually
> - Updated Java unit tests
> - All ambari-server unit tests pass.
>
>
> Thanks,
>
> Balázs Bence Sári
>
>
Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file
> On March 27, 2017, 3:18 p.m., Sebastian Toader wrote: > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml > > Line 91 (original), 94 (patched) > > <https://reviews.apache.org/r/57959/diff/1/?file=1676915#file1676915line94> > > > > I'm not familiar with master - slave KDC setup but if I understand > > correctly > > ```https://web.mit.edu/kerberos/krb5-1.13/doc/admin/install_kdc.html#start-kdc-daemons``` > > than the admin server has to be collocated (or not?) with master KDC > > server. > > > > Can you perform a test scenario to verify this? Collocation depends on how the KDC database is stored: "kadmind starts the Kerberos administration server. kadmind typically runs on the master Kerberos server, which stores the KDC database. If the KDC database uses the LDAP module, the administration server and the KDC server need not run on the same machine." https://web.mit.edu/kerberos/krb5-1.13/doc/admin/admin_commands/kadmind.html#kadmind-8 > On March 27, 2017, 3:18 p.m., Sebastian Toader wrote: > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml > > Lines 93-95 (original), 96-101 (patched) > > <https://reviews.apache.org/r/57959/diff/1/?file=1676915#file1676915line96> > > > > shouldn't this be an "else if" > > Robert Levas wrote: > I don't think so. This looks correct to me. It appears that the code > is adding an additional kdc_host for the master_kdc if it was not manually > added to the kdc_hosts list. Yes, this was the intention - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57959/#review170180 --- On March 27, 2017, 2:54 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57959/ > --- > > (Updated March 27, 2017, 2:54 p.m.) > > > Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor > Magyari, and Sebastian Toader. > > > Bugs: AMBARI-20586 > https://issues.apache.org/jira/browse/AMBARI-20586 > > > Repository: ambari > > > Description > --- > > Added master_kdc to kerberos env and the krb5 config template. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 25f2001 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml > 965ee13 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml > c692b92 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py > 57f062a > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2 > 0191953 > > ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml > 7016437 > > ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml > c692b92 > > ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2 > 0191953 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > fa2082b > ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py > 6727b2f > ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 > > > Diff: https://reviews.apache.org/r/57959/diff/2/ > > > Testing > --- > > - Tested manually > - Updated Java unit tests > - All ambari-server unit tests pass. > > > Thanks, > > Balázs Bence Sári > >
Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57959/ --- (Updated March 27, 2017, 2:54 p.m.) Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor Magyari, and Sebastian Toader. Changes --- small unit test typo fix Bugs: AMBARI-20586 https://issues.apache.org/jira/browse/AMBARI-20586 Repository: ambari Description --- Added master_kdc to kerberos env and the krb5 config template. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 25f2001 ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml 965ee13 ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml c692b92 ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py 57f062a ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2 0191953 ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml 7016437 ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml c692b92 ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2 0191953 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java fa2082b ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 6727b2f ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 Diff: https://reviews.apache.org/r/57959/diff/2/ Changes: https://reviews.apache.org/r/57959/diff/1-2/ Testing --- - Tested manually - Updated Java unit tests - All ambari-server unit tests pass. Thanks, Balázs Bence Sári
Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57959/ --- Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor Magyari, and Sebastian Toader. Bugs: AMBARI-20586 https://issues.apache.org/jira/browse/AMBARI-20586 Repository: ambari Description --- Added master_kdc to kerberos env and the krb5 config template. Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 25f2001 ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml 965ee13 ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml c692b92 ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py 57f062a ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2 0191953 ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml 7016437 ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml c692b92 ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2 0191953 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java fa2082b ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 6727b2f ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 Diff: https://reviews.apache.org/r/57959/diff/1/ Testing --- - Tested manually - Updated Java unit tests - All ambari-server unit tests pass. Thanks, Balázs Bence Sári
Re: Review Request 57683: Accessing a user after sync with AD is failing with 500
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57683/ --- (Updated March 16, 2017, 4:40 p.m.) Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, Oliver Szabo, Robert Levas, Sandor Magyari, and Sebastian Toader. Changes --- Changed apache JIRA Bugs: AMBARI-20482 https://issues.apache.org/jira/browse/AMBARI-20482 Repository: ambari Description --- 1. Install Ambari 2. Set up LDAP/AD and sync users 3. Create a local user with the same name as one of the LDAP users. 4. Invoke the http://c6401:8080/api/v1/users/ API. The duplicate user will be displayed along with the other users with data loaded for the local user. 5. Invoking the Invoke the http://c6401:8080/api/v1/users/ API will result in Http 500 error. Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java d9a7997 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 5659cc5 ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java e69bbc9 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java e370a8a ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserDAOTest.java a1ca11d ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java 2ca5396 ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UsersTest.java 0364213 Diff: https://reviews.apache.org/r/57683/diff/2/ Testing --- 1. Wrote new unit tests 2. Manually tested the following scenarios: 1. LDAP sync to existing local user, convert mode, 2. LDAP sync to existing local user, skip mode, 3. Trying to create local user over LDAP user 3. All unit tests pass in ambari-server Thanks, Balázs Bence Sári
Re: Review Request 57683: Accessing a user after sync with AD is failing with 500
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57683/ --- (Updated March 16, 2017, 1:16 p.m.) Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, Oliver Szabo, Robert Levas, Sandor Magyari, and Sebastian Toader. Changes --- Fixed unit test failures. Bugs: AMBARI-20477 https://issues.apache.org/jira/browse/AMBARI-20477 Repository: ambari Description --- 1. Install Ambari 2. Set up LDAP/AD and sync users 3. Create a local user with the same name as one of the LDAP users. 4. Invoke the http://c6401:8080/api/v1/users/ API. The duplicate user will be displayed along with the other users with data loaded for the local user. 5. Invoking the Invoke the http://c6401:8080/api/v1/users/ API will result in Http 500 error. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java d9a7997 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 5659cc5 ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java e69bbc9 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java e370a8a ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserDAOTest.java a1ca11d ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java 2ca5396 ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UsersTest.java 0364213 Diff: https://reviews.apache.org/r/57683/diff/2/ Changes: https://reviews.apache.org/r/57683/diff/1-2/ Testing (updated) --- 1. Wrote new unit tests 2. Manually tested the following scenarios: 1. LDAP sync to existing local user, convert mode, 2. LDAP sync to existing local user, skip mode, 3. Trying to create local user over LDAP user 3. All unit tests pass in ambari-server Thanks, Balázs Bence Sári
Review Request 57683: Accessing a user after sync with AD is failing with 500
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57683/ --- Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, Oliver Szabo, Robert Levas, Sandor Magyari, and Sebastian Toader. Bugs: AMBARI-20477 https://issues.apache.org/jira/browse/AMBARI-20477 Repository: ambari Description --- 1. Install Ambari 2. Set up LDAP/AD and sync users 3. Create a local user with the same name as one of the LDAP users. 4. Invoke the http://c6401:8080/api/v1/users/ API. The duplicate user will be displayed along with the other users with data loaded for the local user. 5. Invoking the Invoke the http://c6401:8080/api/v1/users/ API will result in Http 500 error. Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java d9a7997 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 5659cc5 ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java e69bbc9 ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserDAOTest.java a1ca11d ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UsersTest.java 0364213 Diff: https://reviews.apache.org/r/57683/diff/1/ Testing --- 1. Wrote new unit tests 2. Manually tested the following scenarios: 1. LDAP sync to existing local user, convert mode, 2. LDAP sync to existing local user, skip mode, 3. Trying to create local user over LDAP user 3. Unit tests: **PENDING** Thanks, Balázs Bence Sári
Re: Review Request 57417: NPE during Ambari server schema upgrade while updating hbase_master_cpu alert definition
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57417/#review168281 --- Ship it! Ship It! - Balázs Bence Sári On March 8, 2017, 11:58 a.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57417/ > --- > > (Updated March 8, 2017, 11:58 a.m.) > > > Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene > Chekanskiy, Laszlo Puskas, and Sebastian Toader. > > > Bugs: AMBARI-20358 > https://issues.apache.org/jira/browse/AMBARI-20358 > > > Repository: ambari > > > Description > --- > > Probably caused by this commit: > https://github.com/hortonworks/ambari/commit/6be4a18dd00f9d23d63410b748d67c952a6240c8 > > # STR > - Deploy HDP-2.3.6 with Ambari-2.2.2.0 > - Upgrade Ambari to 2.5.0.1-13 (hash: > 52b820b0c899a0246061c51245aca231c63583d7) - this includes executing 'yum > upgrade ambari-server' followed by 'ambari-server upgrade' > > # Result > Error during DB schema upgrade > ``` > 08 Mar 2017 04:52:22,059 INFO [main] AbstractUpgradeCatalog:609 - cluster > 'cl1' changed by: 'ambari-upgrade'; type='ranger-kafka-security' > tag='version1488948741867' from='version1488942647954' > 08 Mar 2017 04:52:23,469 INFO [main] UpgradeCatalog250:214 - Updating alert > definition hbase_master_cpu in cluster 2 > 08 Mar 2017 04:52:23,471 ERROR [main] SchemaUpgradeHelper:239 - Upgrade > failed. > java.lang.NullPointerException > at > org.apache.ambari.server.upgrade.UpgradeCatalog250.fixHBaseMasterCPUUtilizationAlertDefinition(UpgradeCatalog250.java:229) > at > org.apache.ambari.server.upgrade.UpgradeCatalog250.executeDMLUpdates(UpgradeCatalog250.java:197) > at > org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeData(AbstractUpgradeCatalog.java:952) > at > org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeDMLUpdates(SchemaUpgradeHelper.java:237) > at > org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:430) > 08 Mar 2017 04:52:23,474 ERROR [main] SchemaUpgradeHelper:443 - Exception > occurred during upgrade, failed > org.apache.ambari.server.AmbariException > at > org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeDMLUpdates(SchemaUpgradeHelper.java:240) > at > org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:430) > Caused by: java.lang.NullPointerException > at > org.apache.ambari.server.upgrade.UpgradeCatalog250.fixHBaseMasterCPUUtilizationAlertDefinition(UpgradeCatalog250.java:229) > at > org.apache.ambari.server.upgrade.UpgradeCatalog250.executeDMLUpdates(UpgradeCatalog250.java:197) > at > org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeData(AbstractUpgradeCatalog.java:952) > at > org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeDMLUpdates(SchemaUpgradeHelper.java:237) > ... 1 more > 08 Mar 2017 04:52:27,829 INFO [main] Configuration:2906 - Reading password > from existing file > 08 Mar 2017 04:52:27,863 INFO [main] Configuration:3382 - Hosts Mapping File > null > 08 Mar 2017 04:52:27,864 INFO [main] HostsMap:60 - Using hostsmap file null > ``` > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > b32e374 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > d1f8682 > > > Diff: https://reviews.apache.org/r/57417/diff/1/ > > > Testing > --- > > Manually tested Ambari upgrade (`ambari-server upgrade`) on DB from Ambari > 2.2.2 > > # Local test results: PENDING > > # Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
Review Request 57339: Server startup script keeps waiting even if DB consistency has failed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57339/ --- Review request for Ambari, Attila Doroszlai, Attila Magyar, Andrew Onischuk, Dmytro Sen, Laszlo Puskas, Nate Cole, Oliver Szabo, Robert Levas, Sandor Magyari, and Sebastian Toader. Bugs: AMBARI-20319 https://issues.apache.org/jira/browse/AMBARI-20319 Repository: ambari Description --- When DB check failed during ambari start up, the script waited some 50 seconds for the UI before timeout occured, even though the Java process had exited. This is fixed. Also added an extra pintStackTrace() in cases when unexpected error occured during startup. This is needed as testing showed that logs are not always flushed on system exit and importan diagnostic information was lost. Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 9540ca3 ambari-server/src/main/python/ambari_server/utils.py 6408285 ambari-server/src/main/python/ambari_server_main.py 0cd19cc Diff: https://reviews.apache.org/r/57339/diff/1/ Testing --- - Tested manually. - Run all python unit tests in ambari-server, all passed Thanks, Balázs Bence Sári
Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error
> On Feb. 27, 2017, 2:39 p.m., Balázs Bence Sári wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java, > > line 232 > > <https://reviews.apache.org/r/56980/diff/2/?file=1650134#file1650134line232> > > > > What does the comment mean? > > Attila Magyar wrote: > We don't cache keytab files that belong to servie principals. The error > should be added only if the principal is a non service principal (cache > should have been existed) but there is no cached keytab file Now that the condition has been inverted it is in line with the comment. - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56980/#review166868 --- On Feb. 27, 2017, 2:58 p.m., Attila Magyar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56980/ > --- > > (Updated Feb. 27, 2017, 2:58 p.m.) > > > Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, > and Sebastian Toader. > > > Bugs: AMBARI-20140 > https://issues.apache.org/jira/browse/AMBARI-20140 > > > Repository: ambari > > > Description > --- > > Spark2 and Spark1 shares the same principal name. This casuses a problem when > adding Spark2 to a kerberized cluster with Spark1. Ambari doesn't publish the > keytab to Spark2 because it thinks it already exists. > > I extended the existing conditional to take the existence of the destination > keytab file into consideration. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java > b968383 > > Diff: https://reviews.apache.org/r/56980/diff/ > > > Testing > --- > > - Created a cluster with Spark > - Enabled Kerberos > - Added Spark2 > - Checked if Spark2 started successfully and the exitence of > /etc/security/keytabs/spark2.headless.keytab > > > Existing tests ran without failure. > > > Thanks, > > Attila Magyar > >
Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56980/#review166868 --- ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java (line 232) <https://reviews.apache.org/r/56980/#comment238947> What does the comment mean? - Balázs Bence Sári On Feb. 27, 2017, 2:14 p.m., Attila Magyar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56980/ > --- > > (Updated Feb. 27, 2017, 2:14 p.m.) > > > Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, > and Sebastian Toader. > > > Bugs: AMBARI-20140 > https://issues.apache.org/jira/browse/AMBARI-20140 > > > Repository: ambari > > > Description > --- > > Spark2 and Spark1 shares the same principal name. This casuses a problem when > adding Spark2 to a kerberized cluster with Spark1. Ambari doesn't publish the > keytab to Spark2 because it thinks it already exists. > > I extended the existing conditional to take the existence of the destination > keytab file into consideration. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java > 5d6ccc0 > > Diff: https://reviews.apache.org/r/56980/diff/ > > > Testing > --- > > - Created a cluster with Spark > - Enabled Kerberos > - Added Spark2 > - Checked if Spark2 started successfully and the exitence of > /etc/security/keytabs/spark2.headless.keytab > > > Existing tests ran without failure. > > > Thanks, > > Attila Magyar > >
Re: Review Request 57039: Restart Kafka broker failed after enabling kerberos with "kinit(v5): No such file or directory while getting initial credentials"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57039/ --- (Updated Feb. 24, 2017, 9 p.m.) Review request for Ambari, Attila Magyar, Laszlo Puskas, Oliver Szabo, Robert Levas, and Sebastian Toader. Changes --- review comments. Bugs: AMBARI-20145 https://issues.apache.org/jira/browse/AMBARI-20145 Repository: ambari Description --- Kafka broker needs the hdfs keytab when Ranger is installed and Ranger Kafka plugin is enabled (plugin exists as of HDP 2.3) Diffs (updated) - ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 2b1c01b ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/kerberos.json e1e6461 Diff: https://reviews.apache.org/r/57039/diff/ Testing --- Manually tested the fix. Thanks, Balázs Bence Sári
Review Request 57039: Restart Kafka broker failed after enabling kerberos with "kinit(v5): No such file or directory while getting initial credentials"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57039/ --- Review request for Ambari, Attila Magyar, Laszlo Puskas, Oliver Szabo, Robert Levas, and Sebastian Toader. Bugs: AMBARI-20145 https://issues.apache.org/jira/browse/AMBARI-20145 Repository: ambari Description --- Kafka broker needs the hdfs keytab when Ranger is installed and Ranger Kafka plugin is enabled (plugin exists as of HDP 2.3) Diffs - ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 2b1c01b ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/kerberos.json e1e6461 Diff: https://reviews.apache.org/r/57039/diff/ Testing --- Manually tested the fix. Thanks, Balázs Bence Sári
Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56980/#review166520 --- Ship it! Ship It! - Balázs Bence Sári On Feb. 23, 2017, 12:11 p.m., Attila Magyar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56980/ > --- > > (Updated Feb. 23, 2017, 12:11 p.m.) > > > Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, > and Sebastian Toader. > > > Bugs: AMBARI-20140 > https://issues.apache.org/jira/browse/AMBARI-20140 > > > Repository: ambari > > > Description > --- > > Spark2 and Spark1 shares the same principal name. This casuses a problem when > adding Spark2 to a kerberized cluster with Spark1. Ambari doesn't publish the > keytab to Spark2 because it thinks it already exists. > > I extended the existing conditional to take the existence of the destination > keytab file into consideration. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java > 5d6ccc0 > > Diff: https://reviews.apache.org/r/56980/diff/ > > > Testing > --- > > - Created a cluster with Spark > - Enabled Kerberos > - Added Spark2 > - Checked if Spark2 started successfully and the exitence of > /etc/security/keytabs/spark2.headless.keytab > > > Existing tests ran without failure. > > > Thanks, > > Attila Magyar > >
Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56540/ --- (Updated Feb. 15, 2017, 3:43 p.m.) Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader. Changes --- Fixed a few more issues. Bugs: AMBARI-19957 https://issues.apache.org/jira/browse/AMBARI-19957 Repository: ambari Description --- Postgres allows multiple schemas on a database user's search path, that is users can query from tables in different schemas without the need of prefixing the tables in the query. This can lead to confusion when after an unsuccessful upgrade DBA's restore the tables into a different schema (e.g. public) to Ambari's configured one. As a result, Ambari server may see different data than indended. New consistency checks on server startup warn the user in such situations. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 7aa8652 ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java 2dd ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 1704546 ambari-server/src/main/python/ambari_server_main.py 7a21333 ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java f73562d Diff: https://reviews.apache.org/r/56540/diff/ Testing --- - Wrote new unit tests - Run all tests for ambari-server (all passed) - Performed manual testing Thanks, Balázs Bence Sári
Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion
> On Feb. 10, 2017, 2:18 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > lines 724-726 > > <https://reviews.apache.org/r/56540/diff/1/?file=1629358#file1629358line724> > > > > Use logging here, not System.out.println(...) > > Balázs Bence Sári wrote: > I copied existing behavior. I think the reason why it is here that the > python script checks the standard out, so the intention is to make sure this > line appears there, irrespectively of the logging config. > > Balázs Bence Sári wrote: > I reduced the occasions of System.out.println's in Ambari Server (a lot > of them existed in the original version). I am hesitating to completely > removing them as in this case the explicit intention is to make that line > appear on System.out, not the application log (as the python script relies on > the console output) and I think the most reliable way to achieve that is to > use System.out.println. > If I try to achieve that with loggers: > 1. Users may reconfigure logging, in that case the python script will > miss the output. > 2. Previously (not sure if it is still the case) Java server apps > suffered from loggers sometimes not getting flushed when System.exit() was > called. I removed my new method containing println(). Also reduced the number of printlns() in the original code as much as possible (respecting the python script). > On Feb. 10, 2017, 2:18 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > lines 715-729 > > <https://reviews.apache.org/r/56540/diff/1/?file=1629358#file1629358line715> > > > > This is strange - why not make the DatabaseConsistencyCheckHelper do > > this exception handling/logic and call it directly instead of having yet > > another method call in AmbariServer? Separation of concerns would be > > helpful. > > Balázs Bence Sári wrote: > I agree with this finding. I copied existing behavior that's why it is > here. I'll move it to DB checker. > > Balázs Bence Sári wrote: > Please have look at the new implementation. I simplified error handling > here, however not completely removed. I left DB Consistency checker's concern > to provide a check result and AmbariServer's concern to decide what to do > with the check result (e.g. exit with 1 exit code if errors occured in the > checks). However, I greatly simplified the overcomplicated logic there. I removed my new method and simplified the original check-result handling. - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56540/#review165122 --- On Feb. 15, 2017, 11:33 a.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56540/ > --- > > (Updated Feb. 15, 2017, 11:33 a.m.) > > > Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, > Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader. > > > Bugs: AMBARI-19957 > https://issues.apache.org/jira/browse/AMBARI-19957 > > > Repository: ambari > > > Description > --- > > Postgres allows multiple schemas on a database user's search path, that is > users can query from tables in different schemas without the need of > prefixing the tables in the query. > > This can lead to confusion when after an unsuccessful upgrade DBA's restore > the tables into a different schema (e.g. public) to Ambari's configured one. > As a result, Ambari server may see different data than indended. > > New consistency checks on server startup warn the user in such situations. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java > 7aa8652 > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java > 2dd > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 1704546 > ambari-server/src/main/python/ambari_server_main.py 7a21333 > > ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java > f73562d > > Diff: https://reviews.apache.org/r/56540/diff/ > > > Testing > --- > > - Wrote new unit tests > - Run all tests for ambari-server (all passed) > - Performed manual testing > > > Thanks, > > Balázs Bence Sári > >
Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56540/ --- (Updated Feb. 15, 2017, 11:33 a.m.) Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader. Changes --- Fixed review comments. Bugs: AMBARI-19957 https://issues.apache.org/jira/browse/AMBARI-19957 Repository: ambari Description --- Postgres allows multiple schemas on a database user's search path, that is users can query from tables in different schemas without the need of prefixing the tables in the query. This can lead to confusion when after an unsuccessful upgrade DBA's restore the tables into a different schema (e.g. public) to Ambari's configured one. As a result, Ambari server may see different data than indended. New consistency checks on server startup warn the user in such situations. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 7aa8652 ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java 2dd ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 1704546 ambari-server/src/main/python/ambari_server_main.py 7a21333 ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java f73562d Diff: https://reviews.apache.org/r/56540/diff/ Testing --- - Wrote new unit tests - Run all tests for ambari-server (all passed) - Performed manual testing Thanks, Balázs Bence Sári
Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion
> On Feb. 14, 2017, 4:54 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/IncompatibleSchemaException.java, > > lines 22-25 > > <https://reviews.apache.org/r/56540/diff/2/?file=1633277#file1633277line22> > > > > Any specific reason for a new Exception class? There's remarkable > > changed that isn't covered by a "regular" AmbariException. Will revert this. Probably a remainder of a previous - since then discarded - error handling mechanism. - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56540/#review165527 ------- On Feb. 14, 2017, 3:27 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56540/ > --- > > (Updated Feb. 14, 2017, 3:27 p.m.) > > > Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, > Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader. > > > Bugs: AMBARI-19957 > https://issues.apache.org/jira/browse/AMBARI-19957 > > > Repository: ambari > > > Description > --- > > Postgres allows multiple schemas on a database user's search path, that is > users can query from tables in different schemas without the need of > prefixing the tables in the query. > > This can lead to confusion when after an unsuccessful upgrade DBA's restore > the tables into a different schema (e.g. public) to Ambari's configured one. > As a result, Ambari server may see different data than indended. > > New consistency checks on server startup warn the user in such situations. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java > 7aa8652 > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java > 2dd > > ambari-server/src/main/java/org/apache/ambari/server/checks/IncompatibleSchemaException.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 1704546 > ambari-server/src/main/python/ambari_server_main.py 7a21333 > > ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java > f73562d > > Diff: https://reviews.apache.org/r/56540/diff/ > > > Testing > --- > > - Wrote new unit tests > - Run all tests for ambari-server (all passed) > - Performed manual testing > > > Thanks, > > Balázs Bence Sári > >
Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion
> On Feb. 14, 2017, 4:54 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java,
> > line 780
> > <https://reviews.apache.org/r/56540/diff/2/?file=1633274#file1633274line780>
> >
> > I thought Logger uses {} for the replacement token? I wonder if this
> > ever worked.
Sure, and it works. This line does not originate from me, I simply changed
LOG.error(...) to error(...).
- Balázs Bence
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56540/#review165527
-------
On Feb. 14, 2017, 3:27 p.m., Balázs Bence Sári wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56540/
> ---
>
> (Updated Feb. 14, 2017, 3:27 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley,
> Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-19957
> https://issues.apache.org/jira/browse/AMBARI-19957
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Postgres allows multiple schemas on a database user's search path, that is
> users can query from tables in different schemas without the need of
> prefixing the tables in the query.
>
> This can lead to confusion when after an unsuccessful upgrade DBA's restore
> the tables into a different schema (e.g. public) to Ambari's configured one.
> As a result, Ambari server may see different data than indended.
>
> New consistency checks on server startup warn the user in such situations.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
> 7aa8652
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
> 2dd
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/IncompatibleSchemaException.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
> 1704546
> ambari-server/src/main/python/ambari_server_main.py 7a21333
>
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
> f73562d
>
> Diff: https://reviews.apache.org/r/56540/diff/
>
>
> Testing
> ---
>
> - Wrote new unit tests
> - Run all tests for ambari-server (all passed)
> - Performed manual testing
>
>
> Thanks,
>
> Balázs Bence Sári
>
>
Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion
> On Feb. 10, 2017, 1:38 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > line 714 > > <https://reviews.apache.org/r/56540/diff/1/?file=1629358#file1629358line714> > > > > Doc. Method is deleted. - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56540/#review165118 --- On Feb. 14, 2017, 3:27 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56540/ > --- > > (Updated Feb. 14, 2017, 3:27 p.m.) > > > Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, > Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader. > > > Bugs: AMBARI-19957 > https://issues.apache.org/jira/browse/AMBARI-19957 > > > Repository: ambari > > > Description > --- > > Postgres allows multiple schemas on a database user's search path, that is > users can query from tables in different schemas without the need of > prefixing the tables in the query. > > This can lead to confusion when after an unsuccessful upgrade DBA's restore > the tables into a different schema (e.g. public) to Ambari's configured one. > As a result, Ambari server may see different data than indended. > > New consistency checks on server startup warn the user in such situations. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java > 7aa8652 > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java > 2dd > > ambari-server/src/main/java/org/apache/ambari/server/checks/IncompatibleSchemaException.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 1704546 > ambari-server/src/main/python/ambari_server_main.py 7a21333 > > ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java > f73562d > > Diff: https://reviews.apache.org/r/56540/diff/ > > > Testing > --- > > - Wrote new unit tests > - Run all tests for ambari-server (all passed) > - Performed manual testing > > > Thanks, > > Balázs Bence Sári > >
Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion
> On Feb. 10, 2017, 2:18 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > lines 715-729 > > <https://reviews.apache.org/r/56540/diff/1/?file=1629358#file1629358line715> > > > > This is strange - why not make the DatabaseConsistencyCheckHelper do > > this exception handling/logic and call it directly instead of having yet > > another method call in AmbariServer? Separation of concerns would be > > helpful. > > Balázs Bence Sári wrote: > I agree with this finding. I copied existing behavior that's why it is > here. I'll move it to DB checker. Please have look at the new implementation. I simplified error handling here, however not completely removed. I left DB Consistency checker's concern to provide a check result and AmbariServer's concern to decide what to do with the check result (e.g. exit with 1 exit code if errors occured in the checks). However, I greatly simplified the overcomplicated logic there. > On Feb. 10, 2017, 2:18 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > lines 724-726 > > <https://reviews.apache.org/r/56540/diff/1/?file=1629358#file1629358line724> > > > > Use logging here, not System.out.println(...) > > Balázs Bence Sári wrote: > I copied existing behavior. I think the reason why it is here that the > python script checks the standard out, so the intention is to make sure this > line appears there, irrespectively of the logging config. I reduced the occasions of System.out.println's in Ambari Server (a lot of them existed in the original version). I am hesitating to completely removing them as in this case the explicit intention is to make that line appear on System.out, not the application log (as the python script relies on the console output) and I think the most reliable way to achieve that is to use System.out.println. If I try to achieve that with loggers: 1. Users may reconfigure logging, in that case the python script will miss the output. 2. Previously (not sure if it is still the case) Java server apps suffered from loggers sometimes not getting flushed when System.exit() was called. - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56540/#review165122 --- On Feb. 14, 2017, 3:27 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56540/ > --- > > (Updated Feb. 14, 2017, 3:27 p.m.) > > > Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, > Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader. > > > Bugs: AMBARI-19957 > https://issues.apache.org/jira/browse/AMBARI-19957 > > > Repository: ambari > > > Description > --- > > Postgres allows multiple schemas on a database user's search path, that is > users can query from tables in different schemas without the need of > prefixing the tables in the query. > > This can lead to confusion when after an unsuccessful upgrade DBA's restore > the tables into a different schema (e.g. public) to Ambari's configured one. > As a result, Ambari server may see different data than indended. > > New consistency checks on server startup warn the user in such situations. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java > 7aa8652 > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java > 2dd > > ambari-server/src/main/java/org/apache/ambari/server/checks/IncompatibleSchemaException.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 1704546 > ambari-server/src/main/python/ambari_server_main.py 7a21333 > > ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java > f73562d > > Diff: https://reviews.apache.org/r/56540/diff/ > > > Testing > --- > > - Wrote new unit tests > - Run all tests for ambari-server (all passed) > - Performed manual testing > > > Thanks, > > Balázs Bence Sári > >
Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56540/ --- (Updated Feb. 14, 2017, 3:27 p.m.) Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader. Changes --- Review comments addressed Bugs: AMBARI-19957 https://issues.apache.org/jira/browse/AMBARI-19957 Repository: ambari Description --- Postgres allows multiple schemas on a database user's search path, that is users can query from tables in different schemas without the need of prefixing the tables in the query. This can lead to confusion when after an unsuccessful upgrade DBA's restore the tables into a different schema (e.g. public) to Ambari's configured one. As a result, Ambari server may see different data than indended. New consistency checks on server startup warn the user in such situations. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 7aa8652 ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java 2dd ambari-server/src/main/java/org/apache/ambari/server/checks/IncompatibleSchemaException.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 1704546 ambari-server/src/main/python/ambari_server_main.py 7a21333 ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java f73562d Diff: https://reviews.apache.org/r/56540/diff/ Testing --- - Wrote new unit tests - Run all tests for ambari-server (all passed) - Performed manual testing Thanks, Balázs Bence Sári
Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion
> On Feb. 10, 2017, 2:18 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > lines 715-729 > > <https://reviews.apache.org/r/56540/diff/1/?file=1629358#file1629358line715> > > > > This is strange - why not make the DatabaseConsistencyCheckHelper do > > this exception handling/logic and call it directly instead of having yet > > another method call in AmbariServer? Separation of concerns would be > > helpful. I agree with this finding. I copied existing behavior that's why it is here. I'll move it to DB checker. > On Feb. 10, 2017, 2:18 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > lines 724-726 > > <https://reviews.apache.org/r/56540/diff/1/?file=1629358#file1629358line724> > > > > Use logging here, not System.out.println(...) I copied existing behavior. I think the reason why it is here that the python script checks the standard out, so the intention is to make sure this line appears there, irrespectively of the logging config. - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56540/#review165122 ------- On Feb. 10, 2017, 12:21 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56540/ > --- > > (Updated Feb. 10, 2017, 12:21 p.m.) > > > Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, > Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader. > > > Bugs: AMBARI-19957 > https://issues.apache.org/jira/browse/AMBARI-19957 > > > Repository: ambari > > > Description > --- > > Postgres allows multiple schemas on a database user's search path, that is > users can query from tables in different schemas without the need of > prefixing the tables in the query. > > This can lead to confusion when after an unsuccessful upgrade DBA's restore > the tables into a different schema (e.g. public) to Ambari's configured one. > As a result, Ambari server may see different data than indended. > > New consistency checks on server startup warn the user in such situations. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java > 7aa8652 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 1704546 > ambari-server/src/main/python/ambari_server_main.py 7a21333 > > ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java > f73562d > > Diff: https://reviews.apache.org/r/56540/diff/ > > > Testing > --- > > - Wrote new unit tests > - Run all tests for ambari-server (all passed) > - Performed manual testing > > > Thanks, > > Balázs Bence Sári > >
Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion
> On Feb. 10, 2017, 12:54 p.m., Sebastian Toader wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java, > > line 689 > > <https://reviews.apache.org/r/56540/diff/1/?file=1629357#file1629357line689> > > > > It would be useful to log the schema name that is first on the search > > path as well. The whole search path is logged out, so it is easy to see which is the first item. E.g: 2017-02-09 22:46:25,936 ERROR [main] checks.DatabaseConsistencyCheckHelper (DatabaseConsistencyCheckHelper.java:checkSchemaName(658)) - The schema [ambari] defined for Ambari in ambari.properties is not first on the search path: [public, ambari]. This can lead to problems. - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56540/#review165115 ------- On Feb. 10, 2017, 12:21 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56540/ > --- > > (Updated Feb. 10, 2017, 12:21 p.m.) > > > Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, > Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader. > > > Bugs: AMBARI-19957 > https://issues.apache.org/jira/browse/AMBARI-19957 > > > Repository: ambari > > > Description > --- > > Postgres allows multiple schemas on a database user's search path, that is > users can query from tables in different schemas without the need of > prefixing the tables in the query. > > This can lead to confusion when after an unsuccessful upgrade DBA's restore > the tables into a different schema (e.g. public) to Ambari's configured one. > As a result, Ambari server may see different data than indended. > > New consistency checks on server startup warn the user in such situations. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java > 7aa8652 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 1704546 > ambari-server/src/main/python/ambari_server_main.py 7a21333 > > ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java > f73562d > > Diff: https://reviews.apache.org/r/56540/diff/ > > > Testing > --- > > - Wrote new unit tests > - Run all tests for ambari-server (all passed) > - Performed manual testing > > > Thanks, > > Balázs Bence Sári > >
Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56540/ --- Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader. Bugs: AMBARI-19957 https://issues.apache.org/jira/browse/AMBARI-19957 Repository: ambari Description --- Postgres allows multiple schemas on a database user's search path, that is users can query from tables in different schemas without the need of prefixing the tables in the query. This can lead to confusion when after an unsuccessful upgrade DBA's restore the tables into a different schema (e.g. public) to Ambari's configured one. As a result, Ambari server may see different data than indended. New consistency checks on server startup warn the user in such situations. Diffs - ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 7aa8652 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 1704546 ambari-server/src/main/python/ambari_server_main.py 7a21333 ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java f73562d Diff: https://reviews.apache.org/r/56540/diff/ Testing --- - Wrote new unit tests - Run all tests for ambari-server (all passed) - Performed manual testing Thanks, Balázs Bence Sári
Re: Review Request 56054: Inconsistent auth-to-local rules processing during Kerberos authentication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56054/#review163487 --- Ship it! Ship It! - Balázs Bence Sári On Jan. 29, 2017, 12:50 a.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56054/ > --- > > (Updated Jan. 29, 2017, 12:50 a.m.) > > > Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene > Chekanskiy, Laszlo Puskas, and Sebastian Toader. > > > Bugs: AMBARI-19767 > https://issues.apache.org/jira/browse/AMBARI-19767 > > > Repository: ambari > > > Description > --- > > Facing issue with local to auth rules. > ambari-qa-...@example.com is getting converted to ambari-qa-cl1 as well as > ambari-qa with same ambari configuration ie > authentication.kerberos.auth_to_local.rules=DEFAULT. > > 1st translation : > ``` > 28 Jan 2017 11:44:45,529 INFO [ambari-client-thread-3298] > AmbariAuthToLocalUserDetailsService:102 - Translated > ambari-qa-...@example.com to ambari-qa-cl1 using auth-to-local rules during > Kerberos authentication. > ``` > > 2nd translation : > ``` > 28 Jan 2017 11:47:36,425 INFO [ambari-client-thread-3172] > AmbariAuthToLocalUserDetailsService:102 - Translated > ambari-qa-...@example.com to ambari-qa using auth-to-local rules during > Kerberos authentication. > 28 Jan 2017 11:47:36,428 WARN [ambari-client-thread-3172] > AmbariAuthToLocalUserDetailsService:136 - Failed find user account for user > with username of ambari-qa during Kerberos authentication. > 28 > ``` > > Since authentication.kerberos.auth_to_local.rules=DEFAULT , > 'ambari-qa-...@example.com' should have been translated to 'ambari-qa-cl1'. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariAuthToLocalUserDetailsService.java > c85503c > > Diff: https://reviews.apache.org/r/56054/diff/ > > > Testing > --- > > # Local test results: > > ``` > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 35:42.972s > [INFO] Finished at: Sat Jan 28 17:37:32 EST 2017 > [INFO] Final Memory: 66M/1180M > [INFO] > > ``` > > # Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
Re: Review Request 55818: Unknown attributes should not be allowed in quick link filter definitions
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55818/
---
(Updated Jan. 23, 2017, 10:27 a.m.)
Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas,
Sandor Magyari, and Sebastian Toader.
Changes
---
Review comments
Bugs: AMBARI-19662
https://issues.apache.org/jira/browse/AMBARI-19662
Repository: ambari
Description
---
When the user makes a syntax error in a quick link definition, such as:
{ "linKKK_name": "namenode_ui", "visible": true }
the filter will be misinterpreted as an accept-all filter, due to the fact that
the parser would expect a proper "link_name" tag to interpret it as a link name
filter. This would lead to unexpected and difficult to debug behaviour.
To prevent this, quick link profile evaluation should throw an exception
whenever it finds unknown tags in a filter definition
Diffs (updated)
-
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilder.java
fca1155
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
150b7d4
ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilderTest.java
1cc3fd3
ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java
57badb8
ambari-server/src/test/resources/inconsistent_quicklinks_profile_3.json
PRE-CREATION
Diff: https://reviews.apache.org/r/55818/diff/
Testing
---
- Wrote new unit tests
- Tested manually: installing cluster via blueprint with both good and bad
quick link profile in the request, viewing quick links with both good and bad
quick link profiles set via Ambari settings API
- run the unit test suite for ambari-server. The only failing test was
org.apache.ambari.server.state.ServicePropertiesTest.validatePropertySchemaOfServiceXMLs
which currently fails on the trunk CI too.
Thanks,
Balázs Bence Sári
Review Request 55818: Unknown attributes should not be allowed in quick link filter definitions
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55818/
---
Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas,
Sandor Magyari, and Sebastian Toader.
Bugs: AMBARI-19662
https://issues.apache.org/jira/browse/AMBARI-19662
Repository: ambari
Description
---
When the user makes a syntax error in a quick link definition, such as:
{ "linKKK_name": "namenode_ui", "visible": true }
the filter will be misinterpreted as an accept-all filter, due to the fact that
the parser would expect a proper "link_name" tag to interpret it as a link name
filter. This would lead to unexpected and difficult to debug behaviour.
To prevent this, quick link profile evaluation should throw an exception
whenever it finds unknown tags in a filter definition
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilder.java
fca1155
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
150b7d4
ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilderTest.java
1cc3fd3
ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java
57badb8
ambari-server/src/test/resources/inconsistent_quicklinks_profile_3.json
PRE-CREATION
Diff: https://reviews.apache.org/r/55818/diff/
Testing
---
- Wrote new unit tests
- Tested manually: installing cluster via blueprint with both good and bad
quick link profile in the request, viewing quick links with both good and bad
quick link profiles set via Ambari settings API
- run the unit test suite for ambari-server. The only failing test was
org.apache.ambari.server.state.ServicePropertiesTest.validatePropertySchemaOfServiceXMLs
which currently fails on the trunk CI too.
Thanks,
Balázs Bence Sári
Review Request 55777: Update quicklink.json files in stack definitions with authenticated/sso features
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55777/
---
Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas,
Oliver Szabo, Sandor Magyari, and Sebastian Toader.
Bugs: AMBARI-19655
https://issues.apache.org/jira/browse/AMBARI-19655
Repository: ambari
Description
---
Existing quicklink definitions need to be updated with authenticatedness and
sso-ness information wherever applicable.
E.g:
"links": [
{
"name": "atlas_dashboard",
"label": "Atlas Dashboard",
"url": "%@://%@:%@/#!/search?user.name=%@",
...
"attributes": [
"authenticated",
"sso"
],
...
}
]
Diffs
-
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/quicklinks/quicklinks.json
e86b665
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/quicklinks/quicklinks.json
152ff57
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json
b6f6a09
ambari-server/src/main/resources/common-services/RANGER/0.4.0/quicklinks/quicklinks.json
ea8c378
ambari-server/src/main/resources/common-services/RANGER/0.5.0/quicklinks/quicklinks.json
3689ba9
ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/quicklinks/quicklinks.json
ccc52bc
Diff: https://reviews.apache.org/r/55777/diff/
Testing
---
Manually tested the change. Installed a cluster.
- Verified that attributes a returned by the API.
- Verified that attributes are respected when a quick links profile to show
authenticated/sso links only is in effect
Thanks,
Balázs Bence Sári
Re: Review Request 55643: Blueprint installation should accept quick link profile
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55643/ --- (Updated Jan. 19, 2017, 7:49 p.m.) Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader. Changes --- Fixed imports Bugs: AMBARI-19597 https://issues.apache.org/jira/browse/AMBARI-19597 Repository: ambari Description --- Specifying the quick links profile should be supported in blueprint based cluster installation. First implementation will address the possibility of adding the profile to the cluster creation template. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 5e8c803 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java cb30f2d ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java a35da86 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java d784a22 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java a1267df ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java c551830 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java c9ac6b4 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilder.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluationException.java 26819e1 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java a3ae677 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java 7724852 ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java 7db07a0 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java 2cf478a ambari-server/src/test/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProviderTest.java 8c723c9 ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilderTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 7e6e5a3 Diff: https://reviews.apache.org/r/55643/diff/ Testing --- - Wrote new unit tests - Run the unit test suite for ambari-server. No failures. - Covered the following cases by manual testing: -- Installing a cluster via blueprint, quick links profile in the cluster creation template, profile saved the first time -- Installing a cluster via blueprint, quick links profile in the cluster creation template, there was an existing quick links profile which was overwritten during cluster installation -- Installing a cluster via blueprint, no quick links profile in the cluster creation template Thanks, Balázs Bence Sári
Re: Review Request 55643: Blueprint installation should accept quick link profile
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55643/ --- (Updated Jan. 19, 2017, 7:43 p.m.) Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader. Changes --- Removed TimeSource Bugs: AMBARI-19597 https://issues.apache.org/jira/browse/AMBARI-19597 Repository: ambari Description --- Specifying the quick links profile should be supported in blueprint based cluster installation. First implementation will address the possibility of adding the profile to the cluster creation template. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 5e8c803 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java cb30f2d ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java a35da86 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java d784a22 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java a1267df ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java c551830 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java c9ac6b4 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilder.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluationException.java 26819e1 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java a3ae677 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java 7724852 ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java 7db07a0 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java 2cf478a ambari-server/src/test/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProviderTest.java 8c723c9 ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilderTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 7e6e5a3 Diff: https://reviews.apache.org/r/55643/diff/ Testing --- - Wrote new unit tests - Run the unit test suite for ambari-server. No failures. - Covered the following cases by manual testing: -- Installing a cluster via blueprint, quick links profile in the cluster creation template, profile saved the first time -- Installing a cluster via blueprint, quick links profile in the cluster creation template, there was an existing quick links profile which was overwritten during cluster installation -- Installing a cluster via blueprint, no quick links profile in the cluster creation template Thanks, Balázs Bence Sári
Re: Review Request 55643: Blueprint installation should accept quick link profile
> On Jan. 18, 2017, 1:43 p.m., Laszlo Puskas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/DefaultTimeSource.java, > > line 29 > > <https://reviews.apache.org/r/55643/diff/1/?file=1606956#file1606956line29> > > > > Why is this abstarction needed? Couldn't we simply use Calendar instead? > > Attila Doroszlai wrote: > If the abstraction is necessary you could use > `com.google.common.base.Ticker` instead. I wouldn't use j.u.Calendar as it is a horrible monster. The SettingsEntity is given a long time stamp (representing milliseconds, so Google's ticker is not appropriate) each time it is saved. The abstraction is needed to support testing. There are objects that produce timestamped entities. In a test I need to predict what timestamp will be given to the next entity, which is not possible when System.currentTimeMillis() is wired into the code. For this reason I abstracted away System.currentTimeMillis() into an interface that has a default implementation as well as test/mock implementations that produce predictable timestamps. - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55643/#review162065 ------- On Jan. 17, 2017, 9:30 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55643/ > --- > > (Updated Jan. 17, 2017, 9:30 p.m.) > > > Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, > Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-19597 > https://issues.apache.org/jira/browse/AMBARI-19597 > > > Repository: ambari > > > Description > --- > > Specifying the quick links profile should be supported in blueprint based > cluster installation. First implementation will address the possibility of > adding the profile to the cluster creation template. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 5e8c803 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > b7c9e85 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > cb30f2d > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java > a35da86 > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java > d784a22 > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java > a1267df > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java > c551830 > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java > c9ac6b4 > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilder.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluationException.java > 26819e1 > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java > a3ae677 > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java > 7724852 > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java > 7db07a0 > > ambari-server/src/main/java/org/apache/ambari/server/utils/DefaultTimeSource.java > PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/utils/TimeSource.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/agent/AgentResourceTest.java > 17b1e27 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java > 2cf478a > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProviderTest.java > 8c723c9 > > ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilderTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java > 7e6e5a3 > > ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java > 5c77831 > > Diff: https://reviews.apache.org/r
Re: Review Request 55643: Blueprint installation should accept quick link profile
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55643/ --- (Updated Jan. 17, 2017, 9:30 p.m.) Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader. Bugs: AMBARI-19597 https://issues.apache.org/jira/browse/AMBARI-19597 Repository: ambari Description --- Specifying the quick links profile should be supported in blueprint based cluster installation. First implementation will address the possibility of adding the profile to the cluster creation template. Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 5e8c803 ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java b7c9e85 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java cb30f2d ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java a35da86 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java d784a22 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java a1267df ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java c551830 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java c9ac6b4 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilder.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluationException.java 26819e1 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java a3ae677 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java 7724852 ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java 7db07a0 ambari-server/src/main/java/org/apache/ambari/server/utils/DefaultTimeSource.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/utils/TimeSource.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/agent/AgentResourceTest.java 17b1e27 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java 2cf478a ambari-server/src/test/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProviderTest.java 8c723c9 ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilderTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 7e6e5a3 ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java 5c77831 Diff: https://reviews.apache.org/r/55643/diff/ Testing --- - Wrote new unit tests - Run the unit test suite for ambari-server. No failures. - Covered the following cases by manual testing: -- Installing a cluster via blueprint, quick links profile in the cluster creation template, profile saved the first time -- Installing a cluster via blueprint, quick links profile in the cluster creation template, there was an existing quick links profile which was overwritten during cluster installation -- Installing a cluster via blueprint, no quick links profile in the cluster creation template Thanks, Balázs Bence Sári
Review Request 55643: Blueprint installation should accept quick link profile
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55643/ --- Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader. Repository: ambari Description --- Specifying the quick links profile should be supported in blueprint based cluster installation. First implementation will address the possibility of adding the profile to the cluster creation template. Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 5e8c803 ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java b7c9e85 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java cb30f2d ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java a35da86 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java d784a22 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java a1267df ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java c551830 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java c9ac6b4 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilder.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluationException.java 26819e1 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java a3ae677 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java 7724852 ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java 7db07a0 ambari-server/src/main/java/org/apache/ambari/server/utils/DefaultTimeSource.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/utils/TimeSource.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/agent/AgentResourceTest.java 17b1e27 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java 2cf478a ambari-server/src/test/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProviderTest.java 8c723c9 ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileBuilderTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 7e6e5a3 ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java 5c77831 Diff: https://reviews.apache.org/r/55643/diff/ Testing --- - Wrote new unit tests - Run the unit test suite for ambari-server. No failures. - Covered the following cases by manual testing: -- Installing a cluster via blueprint, quick links profile in the cluster creation template, profile saved the first time -- Installing a cluster via blueprint, quick links profile in the cluster creation template, there was an existing quick links profile which was overwritten during cluster installation -- Installing a cluster via blueprint, no quick links profile in the cluster creation template Thanks, Balázs Bence Sári
Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.
> On Jan. 11, 2017, 4:28 p.m., Attila Doroszlai wrote: > > ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java, > > line 113 > > <https://reviews.apache.org/r/55342/diff/3/?file=1600123#file1600123line113> > > > > Somehow this comment doesn't seem right. The test verifies the link is > > visible, not hidden. The comment is meant for a different test. Probably a result of a former merge. - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55342/#review161258 ------- On Jan. 11, 2017, 5:27 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55342/ > --- > > (Updated Jan. 11, 2017, 5:27 p.m.) > > > Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, > Sandor Magyari, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-19426 > https://issues.apache.org/jira/browse/AMBARI-19426 > > > Repository: ambari > > > Description > --- > > Existing quicklinks API (e.g: > http://c6401:8080/api/v1/stacks/HDP/versions/2.5/services/ACCUMULO/quicklinks/quicklinks.json) > should return visible = true/false based on the quick links profile. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java > cc20324 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 0affa4f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProvider.java > 5603765 > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java > f589f5d > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinkVisibilityController.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinkVisibilityControllerFactory.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java > e86af38 > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java > 31335b6 > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java > c24281a > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/ShowAllLinksVisibilityController.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProviderTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java > f54842d > > ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinkVisibilityControllerFactoryTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java > 6a31ca0 > > ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java > 6f5dd07 > ambari-server/src/test/resources/example_quicklinks_profile.json 2fa33a4 > ambari-server/src/test/resources/inconsistent_quicklinks_profile_2.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/55342/diff/ > > > Testing > --- > > 1. Did manual testing > 2. Wrote new unit tests > 3. Run the ambari-server unit test suite. Only KerberosServiceMetaInfoTest > failed, but it succeeded in a subsequent run. > > > Thanks, > > Balázs Bence Sári > >
Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55342/ --- (Updated Jan. 11, 2017, 5:27 p.m.) Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, Sandor Magyari, Sumit Mohanty, and Sebastian Toader. Changes --- Fixed review comments. Bugs: AMBARI-19426 https://issues.apache.org/jira/browse/AMBARI-19426 Repository: ambari Description --- Existing quicklinks API (e.g: http://c6401:8080/api/v1/stacks/HDP/versions/2.5/services/ACCUMULO/quicklinks/quicklinks.json) should return visible = true/false based on the quick links profile. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java cc20324 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0affa4f ambari-server/src/main/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProvider.java 5603765 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java f589f5d ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinkVisibilityController.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinkVisibilityControllerFactory.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java e86af38 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java 31335b6 ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java c24281a ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/ShowAllLinksVisibilityController.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProviderTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java f54842d ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinkVisibilityControllerFactoryTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java 6a31ca0 ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java 6f5dd07 ambari-server/src/test/resources/example_quicklinks_profile.json 2fa33a4 ambari-server/src/test/resources/inconsistent_quicklinks_profile_2.json PRE-CREATION Diff: https://reviews.apache.org/r/55342/diff/ Testing --- 1. Did manual testing 2. Wrote new unit tests 3. Run the ambari-server unit test suite. Only KerberosServiceMetaInfoTest failed, but it succeeded in a subsequent run. Thanks, Balázs Bence Sári
